Re: [FFmpeg-devel] [PATCH 2/2] aacenc: unmark the fast coder as experimental

2016-08-07 Thread Moritz Barsnick
On Sun, Aug 07, 2016 at 00:51:30 +0100, Rostislav Pehlivanov wrote: > This version has had much testing so there's little point in keeping it > maked as experimental. ^ marked Moritz ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.o

Re: [FFmpeg-devel] [PATCH 2/2] aacenc: unmark the fast coder as experimental

2016-08-07 Thread Moritz Barsnick
On Sun, Aug 07, 2016 at 01:10:55 -0500, Burt P. wrote: > "The ANMR coder requires -strict -2 and some may be removed in the future" > should have "some" removed. And I would probably quote the command line part of that, and use the symbolic value: "The ANMR coder requires \"-strict experimental\"

Re: [FFmpeg-devel] [PATCH 1/2] aacenc: add a faster version of twoloop as the "fast" coder

2016-08-07 Thread Moritz Barsnick
On Sun, Aug 07, 2016 at 00:51:29 +0100, Rostislav Pehlivanov wrote: > +//XXX: some heuristic to determine initial quantizers will reduce search > time Is the "XXX" trying to tell someone something? > +for (g = 0; g < sce->ics.num_swb; g++) { I detect a spurious space in there. ;-)

[FFmpeg-devel] [PATCH] libavformat/http: add support for content_type option in listen mode

2016-08-10 Thread Moritz Barsnick
Instead of silently ignoring the content_type option in listen mode, apply its value to the provided "Content-Type:" header. Signed-off-by: Moritz Barsnick --- doc/protocols.texi | 2 +- libavformat/http.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/prot

[FFmpeg-devel] [PATCH] libavformat/http: add support for headers option in listen mode

2016-08-10 Thread Moritz Barsnick
Instead of silently ignoring the headers option in listen mode, use the provided headers. Signed-off-by: Moritz Barsnick --- libavformat/http.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/libavformat/http.c b/libavformat/http.c index cbeaebf..70d64af 100644 --- a

[FFmpeg-devel] [PATCH] libavformat/http: add support for headers option in listen mode

2016-08-11 Thread Moritz Barsnick
Instead of silently ignoring the headers option in listen mode, use the provided headers. Signed-off-by: Moritz Barsnick --- libavformat/http.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/libavformat/http.c b/libavformat/http.c index cbeaebf..adb3d92 100644 --- a

[FFmpeg-devel] [PATCH] libavformat/http: add support for headers option in listen mode

2016-08-11 Thread Moritz Barsnick
Sorry, I shouldn't have refactored and remerged without testing. Big mistake. Fixed (and tested) patch attached. Moritz ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] libavformat/http: add support for content_type option in listen mode

2016-08-13 Thread Moritz Barsnick
On Wed, Aug 10, 2016 at 21:18:00 +0200, Moritz Barsnick wrote: > Instead of silently ignoring the content_type option in listen mode, > apply its value to the provided "Content-Type:" header. > > Signed-off-by: Moritz Barsnick > --- > doc/protocols.texi | 2 +- >

Re: [FFmpeg-devel] [PATCH] avfilter: add bitplanenoise filter

2016-08-16 Thread Moritz Barsnick
On Tue, Aug 16, 2016 at 09:45:49 +0200, Paul B Mahol wrote: > +Show & measure bit plane noise. '&' seems a bit casual instead of "and". In several places. It would perhaps be valuable to document how it's measured, and how it's shown. (Is it really shown? Is the measured value not inserted into

Re: [FFmpeg-devel] [GSOC][PATCH 2/4] FFV1 p frames

2016-08-17 Thread Moritz Barsnick
On Wed, Aug 17, 2016 at 14:07:24 +0300, Станислав Долганов wrote: > +{ "pframe", "Using P frames", OFFSET(p_frame), AV_OPT_TYPE_BOOL, { .i64 > = 0 }, 0, 1, VE }, Nit: imperative wording, i.e. "Use P frames". Moritz ___ ffmpeg-devel mailing list ff

Re: [FFmpeg-devel] h264_qsv decoder speed

2016-08-18 Thread Moritz Barsnick
On Wed, Aug 17, 2016 at 23:13:13 +0100, Mark Thompson wrote: > > The test video was captured from a 3MP(2048x1536) camera. The commands I > > used: > > - ffmpeg -c:v h264_qsv -async_depth 10 -i test.h264 -c:v rawvideo -f null > > /dev/null > > - sample_decode h264 -i test.h264 > > Both uses 100%

Re: [FFmpeg-devel] [GSOC][PATCH 2/4] FFV1 p frames

2016-08-18 Thread Moritz Barsnick
On Thu, Aug 18, 2016 at 14:49:28 +0300, Станислав Долганов wrote: > +static int decode_q_branch(FFV1Context *f, int level, int x, int y){ > +RangeCoder *const c = &f->slice_context[0]->c; > +OBMCContext *s = &f->obmc; > +const int w= s->b_width << s->block_max_depth; This whole functi

Re: [FFmpeg-devel] [PATCH v11 01/11] avformat: Add fifo pseudo-muxer

2016-08-18 Thread Moritz Barsnick
On Thu, Aug 18, 2016 at 01:25:01 +0200, sebechlebsky...@gmail.com wrote: > +@item attempt_recovery @var{bool} > +If failure occurs, attempt to recover the output. This is especially useful > +when used with network output, allows to restart streaming transparently. > +By default this option set to

Re: [FFmpeg-devel] [GSoC] Motion Interpolation

2016-08-18 Thread Moritz Barsnick
On Thu, Aug 18, 2016 at 19:26:39 +, Davinder Singh wrote: > +@table @option > +@item algo > +Set the algorithm to be used. Accepts one of the following values: > + > +@table @samp > +@item ebma > +Exhaustive block matching algorithm. > +@end table > +Default value is @samp{ebma}. [...] > +

Re: [FFmpeg-devel] [PATCH v11 01/11] avformat: Add fifo pseudo-muxer

2016-08-18 Thread Moritz Barsnick
On Thu, Aug 18, 2016 at 22:07:34 +0200, Jan Sebechlebsky wrote: > > You're re-assigning ret in the error case but not using it. I think you > > meant to return it? > Yes, that's right - thanks for noticing that. I'll fix that and also the > issues above and resend the patch. Apparently, the defau

Re: [FFmpeg-devel] [GSoC] Motion Interpolation

2016-08-19 Thread Moritz Barsnick
On Fri, Aug 19, 2016 at 11:19:22 +, Davinder Singh wrote: > > Same here and many other places. "!=" is a valid operator. ;) > > yes, that would be in case of == operator, not = operator, no? D'uh, stupid me, I missed that. Sorry! > will do. can you tell which is faster? I *believe* switch/c

Re: [FFmpeg-devel] [GSOC][PATCH 2/4] FFV1 p frames

2016-08-20 Thread Moritz Barsnick
On Sat, Aug 20, 2016 at 13:10:56 +0200, Michael Niedermayer wrote: > On Thu, Aug 18, 2016 at 08:50:08PM +0200, Moritz Barsnick wrote: > This code is based on libavcodec/snowdec.c:static int decode_q_branch > Fixing formating is very welcome but it should be in a seperate patch I thoug

Re: [FFmpeg-devel] [PATCH] avfilter: add maskedclamp filter

2016-08-22 Thread Moritz Barsnick
On Mon, Aug 22, 2016 at 11:27:12 +0200, Paul B Mahol wrote: I have no idea what the result looks like, but perhaps "looks like" is thinking too unhypothetical. ;-) Anyways: > +Clamp the first input stream with the second input and third input stream. Perhaps: Clamp the first input stream's pixel

Re: [FFmpeg-devel] [PATCH] tests/fate:Add FATE for hls_flags append option

2016-08-24 Thread Moritz Barsnick
On Wed, Aug 24, 2016 at 15:04:59 +0800, Steven Liu wrote: > [root@localhost ffmpeg]# make fate-filter-hls-append [...] > tests/audiomatch.c: 在函数‘main’中: > tests/audiomatch.c:40: 警告:此函数中的‘bestpos’在使用前可能未初始化 Just a hint: For improved readability on this list, please use something like $ LANG=C make

Re: [FFmpeg-devel] [PATCH] avfilter: add yuvtestsrc source filter

2016-08-24 Thread Moritz Barsnick
On Wed, Aug 24, 2016 at 18:57:57 +0200, Paul B Mahol wrote: > +The @code{yuvtestsrc} source generates an YUV test pattern. You should ^ a > +see a y, cb and cr stripe from top to bottom. This makes it sound like the stripes go from top to bottom, i.e. the

Re: [FFmpeg-devel] [PATCH] added expr evaluation to drawtext - fontsize

2016-08-27 Thread Moritz Barsnick
On Fri, Aug 26, 2016 at 14:37:42 -0700, Brett Harrison wrote: > +if (diff != 0) { > + return diff > 0 ? 1 : diff < 0 ? -1 : 0; > +} If diff != 0, it can only be >0 or <0, nothing else: if (diff != 0) return diff > 0 ? 1 : -1; (And you can drop the curly brackets.) >

Re: [FFmpeg-devel] [PATCH] added expr evaluation to drawtext - fontsize

2016-09-02 Thread Moritz Barsnick
On Thu, Sep 01, 2016 at 18:17:11 -0700, Brett Harrison wrote: > Most recent patch. I was evaluating fontsize too early before when using > the 'n' variable in equations. > +av_log(ctx, AV_LOG_ERROR, "Font not open\n"); I was wondering: Was does this message tell the user? > +if ((re

Re: [FFmpeg-devel] [PATCH] added expr evaluation to drawtext - fontsize

2016-09-02 Thread Moritz Barsnick
On Fri, Sep 02, 2016 at 14:10:41 +0200, Moritz Barsnick wrote: > > +if ((ret = update_fontsize(ctx))) { > You were meaning to write >if (ret = update_fontsize(ctx)) { > or >if ((ret = update_fontsize(ctx)) < 0) { > ?? (Too many brackets the way you d

Re: [FFmpeg-devel] [PATCH] added expr evaluation to drawtext - fontsize

2016-09-02 Thread Moritz Barsnick
On Fri, Sep 02, 2016 at 14:20:37 +0200, Nicolas George wrote: > You mean the parentheses? Well, if you are not sure, then the parentheses > are necessary. We are not playing golf, we want code that is readable and > robust. > > For reference, comparisons have precedence over assignments. That mean

Re: [FFmpeg-devel] [PATCH] swscale: add unscaled copy from yuv420p10 to p010

2016-09-02 Thread Moritz Barsnick
On Fri, Sep 02, 2016 at 15:40:54 +0300, Oliver Collyer wrote: > In my test, my sample file went from 80mb encoded down to 69mb with > the same global quality setting. (using -constq -global_quality 21) I also wonder whether the 10-bit algorithms have the same visual result as the 8-bit algorithms,

Re: [FFmpeg-devel] [PATCH v4] lavf : scale_vaapi : add denoise/sharpless support

2016-09-11 Thread Moritz Barsnick
On Fri, Sep 09, 2016 at 11:31:22 +0800, Jun Zhao wrote: > v4 : - fix sharpless typo(sharpless -> sharpness) [...] > Date: Tue, 30 Aug 2016 14:36:00 +0800 > Subject: [PATCH v4] lavf : scale_vaapi : add denoise/sharpless support. > > add denoise/sharpless support, used scope [-1, 100] as the input

Re: [FFmpeg-devel] [PATCH] Select cubic and lanczos as alternative where super-sampling is not supported

2016-09-11 Thread Moritz Barsnick
Moin Sven, On Fri, Sep 09, 2016 at 11:13:55 +0100, Sven C. Dack wrote: I may be missing something, but my excuse is that I can't test, but just inspect by looking at it: > + if (s->interp_algo == NPPI_INTER_SUPER && > + (out_width > in_width && out_height > in_height)) { > +

Re: [FFmpeg-devel] [PATCH] Select cubic and lanczos as alternative where super-sampling is not supported

2016-09-11 Thread Moritz Barsnick
On Sun, Sep 11, 2016 at 19:04:39 +0100, Sven C. Dack wrote: > the second body if it entered the first, because the value is part of both > the > conditions. D'uh, I missed that part. (It wasn't obvious enough to me. ;-)) > I thought about some neat logic at first, but decided to do it this > wa

Re: [FFmpeg-devel] [PATCH] avdev: Add SDL2 output device

2016-09-11 Thread Moritz Barsnick
Nice, seeing how often this has been pitched in the past. On Sun, Sep 11, 2016 at 16:38:12 +0100, Josh de Kock wrote: > This actually seems to work now, it didn't in the past, so maybe SDL2 > was patched or something changed in FFmpeg. Interesting... > + * Copyright (c) 2011 Stefano Sabatini Do

Re: [FFmpeg-devel] [PATCH v4 1/3] lavd: Add SDL2 output device

2016-09-11 Thread Moritz Barsnick
On Sun, Sep 11, 2016 at 21:46:58 +0100, Josh de Kock wrote: > +{ "window_fullscreen", "set SDL window fullscreen", > OFFSET(window_fullscreen), AV_OPT_TYPE_BOOL, { .i64 = 0 }, INT_MIN, INT_MAX, > AV_OPT_FLAG_ENCODING_PARAM }, > +{ "window_borderless", "set SDL window border off", > OFFSE

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: refine EXT-X-BYTERANGE support for segments

2016-09-13 Thread Moritz Barsnick
On Tue, Sep 13, 2016 at 11:25:39 +0800, Steven Liu wrote: > +int byterange_mode = hls->flags & (HLS_SINGLE_FILE) || hls->max_seg_size > > 0; ^ ^ Why the bracket? > +av_log(oc, AV_LOG_ERROR, "Invalid segment filename templa

Re: [FFmpeg-devel] mpeg12dec fix up DVD caption handling

2016-09-13 Thread Moritz Barsnick
On Mon, Sep 12, 2016 at 18:19:43 -0700, Jonathan Campbell wrote: > Subject: [PATCH 2/7] read caption words field-wise, count properly and limit > to cc_count. transfer each CC word taking into consideration immediate CC > field bit or for DVDs that don't use it, keep track according to first fiel

[FFmpeg-devel] [PATCH] libavcodec/qsvdec_h2645.c: drop executable permission

2016-09-15 Thread Moritz Barsnick
Accidentally set in b93e2233155e6c1f0a074cad4135a70d9d2934d3. Signed-off-by: Moritz Barsnick --- libavcodec/qsvdec_h2645.c | 0 1 file changed, 0 insertions(+), 0 deletions(-) mode change 100755 => 100644 libavcodec/qsvdec_h2645.c diff --git a/libavcodec/qsvdec_h2645.c b/libavco

Re: [FFmpeg-devel] [PATCH 4/4] MAINTAINERS: update my entries

2016-09-15 Thread Moritz Barsnick
On Wed, Sep 14, 2016 at 23:27:33 +0100, Josh de Kock wrote: > - ffplay.c Marton Balint > + ffplay.c Marton Balint, Josh de Kock > + ffplay_sdl1.c Josh de Kock Since ffplay_sdl1.c was created as a copy (or basicall

Re: [FFmpeg-devel] Dropping SDL1 support [VOTE]

2016-09-15 Thread Moritz Barsnick
On Thu, Sep 15, 2016 at 14:36:32 -0300, James Almer wrote: > * SDL1 is old and effectively unmaintained. I understand this verbatim, but what is it supposed to mean? Has SDL1 gotten rotten? Or more precisely: - Has technology evolved, and the library not kept up? - Is a long list of bugs (somehow

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: refine EXT-X-BYTERANGE support for segments

2016-09-18 Thread Moritz Barsnick
On Sun, Sep 18, 2016 at 23:40:34 +0800, Steven Liu wrote: > +if (byterange_mode) { > +version = 4; > +sequence = byterange_mode ? 0 : sequence; What does the ternary if-then-else operation do here? Two lines above, byterange_mode was checked for !=0, how can it be anything els

[FFmpeg-devel] [PATCH] doc/encoders: minor aac encoder formatting improvements

2016-09-18 Thread Moritz Barsnick
Minor changes for markup consistency. That line I shifted is probably redundant. Moritz >From 9c4de92a603ff998d0b45cb783bd624374df6d3d Mon Sep 17 00:00:00 2001 From: Moritz Barsnick Date: Sun, 18 Sep 2016 23:51:48 +0200 Subject: [PATCH] doc/encoders: minor aac encoder formatting improveme

Re: [FFmpeg-devel] [PATCH] pass TLS args for RTSPS

2016-09-27 Thread Moritz Barsnick
On Mon, Sep 26, 2016 at 11:24:33 -0400, jayri...@gmail.com wrote: > +{ "tls_verify", "Verify the peer certificate", OFFSET(verify), > AV_OPT_TYPE_INT, {.i64 = 0}, 0, 1, DEC|ENC}, AV_OPT_TYPE_BOOL > +{ "cert_file", "Certificate file", OFFSET(cert_file), > AV_OPT_TYPE_STRING, {.str = NULL}

Re: [FFmpeg-devel] [PATCH 3/4] V10 - SCTE-35 support in hlsenc

2016-09-27 Thread Moritz Barsnick
On Mon, Sep 26, 2016 at 10:59:46 -0700, Carlos Fernandez Sanz wrote: > @@ -1,4 +1,4 @@ > -/* > + /* Stray accidental change. > + * Refrence Material Used Reference > + * ANSI/SCTE 35 2013 ( Digital Program Insertion Cueing Message for Cable ) Drop the spaces next to the brackets. Nit: There's al

[FFmpeg-devel] [PATCH] ffmpeg_vaapi: fix choice of decoder_format

2016-09-27 Thread Moritz Barsnick
As discovered and suggested by Mihai Chindea, http://ffmpeg.org/pipermail/ffmpeg-devel/2016-September/198932.html I have only inspected/reviewed this change visually, not tested. Moritz >From bc8437848870f6143d3cf5b3e615e865b0411ecf Mon Sep 17 00:00:00 2001 From: Moritz Barsnick Date: Tue,

Re: [FFmpeg-devel] [PATCH 2/3] lavf/mov.c: Make audio timestamps strictly monotonically increasing inside an edit list. Fixes gapless decoding. Adjust skip_samples field correctly in case of DISCARDed

2016-09-27 Thread Moritz Barsnick
On Mon, Sep 26, 2016 at 11:42:51 -0700, Sasi Inguva wrote: > Subject: [FFmpeg-devel] [PATCH 2/3] lavf/mov.c: Make audio timestamps > strictly monotonically increasing inside an edit list. Fixes gapless > decoding. Adjust skip_samples field correctly in case of DISCARDed audio > frames. Please

Re: [FFmpeg-devel] [PATCH 2/3] lavf/mov.c: Make audio timestamps strictly monotonically increasing inside an edit list.

2016-09-27 Thread Moritz Barsnick
On Tue, Sep 27, 2016 at 09:28:13 -0700, Sasi Inguva wrote: > if (curr_cts < edit_list_media_time || curr_cts >= > (edit_list_duration + edit_list_media_time)) { > -if (st->codecpar->codec_type == AVMEDIA_TYPE_AUDIO && > curr_cts < edit_list_media_time && > -

Re: [FFmpeg-devel] [PATCH 2/3] doc/muxers: fix error for hlsenc exmpales

2016-09-28 Thread Moritz Barsnick
On Wed, Sep 28, 2016 at 16:25:30 +0800, Steven Liu wrote: > > > Subject: [PATCH 2/3] doc/muxers: fix error for hlsenc exmpales > > > > not a english word You didn't fix this in your commit message!? Moritz __

Re: [FFmpeg-devel] [PATCH 2/3] doc/muxers: fix error for hlsenc exmpales

2016-09-28 Thread Moritz Barsnick
On Wed, Sep 28, 2016 at 17:56:27 +0800, Steven Liu wrote: > change from "in.nut" to "-i in.nut" > > what about: > > The examples of hlsenc is error, for example: > ffmpeg in.nut -use_localtime 1 -hls_segment_filename 'file-%Y%m%d-%s.ts' > out.m3u8 > this example missing input parameter -i, so thi

Re: [FFmpeg-devel] imagepipe filter (was [PATCH] avfilter: add dynoverlay filter.)

2016-09-28 Thread Moritz Barsnick
On Wed, Sep 28, 2016 at 12:40:24 +, Priebe, Jason wrote: > Like I said, I don't see any way to decode an in-memory encoded > image (PNG, JPG, etc.) with the existing function calls. I only > see ff_load_image(), which takes a filename. The image2pipe demuxer already handles a "stream" of stil

Re: [FFmpeg-devel] [PATCH] doc/codecs.texi: fix and expand color related options doxigen

2016-09-28 Thread Moritz Barsnick
> Subject: [FFmpeg-devel] [PATCH] doc/codecs.texi: fix and expand color related > options doxigen This isn't doxygen (which you didn't spell correctly ;-)), but texinfo. You can just drop the last word. Moritz ___ ffmpeg-devel mailing list ffmpeg-devel

Re: [FFmpeg-devel] lurking bugs in the mmx-related assembler code (?)

2016-10-01 Thread Moritz Barsnick
On Sat, Oct 01, 2016 at 17:37:50 +0200, u-h...@aetey.se wrote: > My troubleshooting [...] > behaves erratically on certain combinations [...] > Most often You are a busy troubleshooter, but you fail to describe what you did, and what exactly went wrong. No-one will be able to (even try to) reprod

Re: [FFmpeg-devel] [PATCH 2/2] lavc/ccaption_dec: implement special and extended character sets

2016-02-11 Thread Moritz Barsnick
On Wed, Feb 10, 2016 at 22:21:10 -0800, Aman Gupta wrote: > +enum cc_charset { > +CCSET_BASIC_AMERICAN, > +CCSET_SPECIAL_AMERICAN, > +CCSET_EXTENDED_SPANISH_FRENCH, > +CCSET_EXTENDED_PORTUGUESE_GERMAN, > +}; Do these correspond to these from EIA-608?: https://en.wikipedia.org/wiki/

Re: [FFmpeg-devel] /libavcodec/h264_slice.c: selectively discard MB to be decoded

2016-02-11 Thread Moritz Barsnick
On Thu, Feb 11, 2016 at 01:20:52 -0800, Mehdi Hosseini wrote: > I want to discard some MBs of a B-FRAME from decoding. In fact, I want to > avoid some special MBs to be decoded and instead copying MBs of one of its > parents. Note that no B-Frame is encoded as a reference frame. The best > function

Re: [FFmpeg-devel] [patch] gdigrab-mouse-dpi-awareness

2016-02-12 Thread Moritz Barsnick
On Fri, Feb 12, 2016 at 09:25:54 +0100, Hendrik Leppkes wrote: > On Fri, Feb 12, 2016 at 9:21 AM, Γιώργος Μεταξάκης wrote: > > i'm very sorry for those mistakes > That looks much better already, unfortunately there is still tabs in the > patch. A good hint for new contributors is to use: ./tools

[FFmpeg-devel] [PATCH] lavf/options_table: mark use_wallclock_as_timestamps as boolean

2016-02-18 Thread Moritz Barsnick
It was probably forgotten to convert this to AV_OPT_TYPE_BOOL, because that's how it is actually used. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH] lavf/options_table: mark use_wallclock_as_timestamps as boolean

2016-02-18 Thread Moritz Barsnick
It is only used in a boolean context. Also clarify its documentation. Signed-off-by: Moritz Barsnick --- doc/formats.texi| 2 +- libavformat/options_table.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/formats.texi b/doc/formats.texi index 617cda5

Re: [FFmpeg-devel] [PATCH] avformat/avienc: Store pal8 palette

2016-02-18 Thread Moritz Barsnick
On Thu, Feb 18, 2016 at 21:14:55 +0100, Michael Niedermayer wrote: > + * no zerp if a new packet was allocated and ppkt has to be freed "no zerp"? Cute. Probably "non-zero" Moritz ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmp

Re: [FFmpeg-devel] [PATCH 5/5] lavc: add h264 mediacodec decoder

2016-02-19 Thread Moritz Barsnick
On Fri, Feb 19, 2016 at 10:07:06 +0100, Matthieu Bouron wrote: IANAL, but: > + * Copyright (c) Matthieu Bouron Every copyright notice within the ffmpeg source tree has a year (or a set of years or a range) attached, until now. Moritz ___ ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] lavf/md5enc: New streammd5 muxer

2016-02-20 Thread Moritz Barsnick
On Fri, Feb 19, 2016 at 17:51:00 +0100, Nicolas George wrote: > Changing the name of existing muxers is annoying, but for new features I > would like much better if we did not wave around the name of a hash function > that has known vulnerabilities since 20 years: "streamhash" would be an > obvious

Re: [FFmpeg-devel] [PATCH v22] lavf/movenc: Add palette to video sample description

2016-02-23 Thread Moritz Barsnick
On Tue, Feb 23, 2016 at 09:00:02 +0100, Mats Peterson wrote: > Some simplifications. Thank you for letting us take part in the commits to your local git clone, though that's not the list I subscribed to. You will share the final patch with us when it's ready for discussion, will you? Moritz J

Re: [FFmpeg-devel] [PATCH 4/7] vc2enc: clip and warn when user bitrate set too low

2016-02-27 Thread Moritz Barsnick
On Sat, Feb 27, 2016 at 19:29:05 +, Rostislav Pehlivanov wrote: > +av_log(avctx, AV_LOG_WARNING, > + "Bitrate too low, clipping to minimum = %.2lf Mbps!\n", > + (double)avctx->bit_rate/100.0f); "%lf" is undefined in C90, and otherwise identical to "%f".

Re: [FFmpeg-devel] [PATCH] lavf/md5enc: New streammd5 muxer

2016-02-29 Thread Moritz Barsnick
On Fri, Feb 19, 2016 at 17:51:00 +0100, Nicolas George wrote: > Changing the name of existing muxers is annoying, but for new features I > would like much better if we did not wave around the name of a hash function > that has known vulnerabilities since 20 years: "streamhash" would be an > obvious

Re: [FFmpeg-devel] [PATCH]configure: Check for msghdr struct

2016-03-01 Thread Moritz Barsnick
On Tue, Mar 01, 2016 at 10:32:55 +0100, Carl Eugen Hoyos wrote: > A user claims that not all (Solaris) systems have a sufficiently new msghdr > struct. Attached patch adds an additional check. This disables the sctp protocol on those systems then? Probably fine, but *searchengine* tells me that s

Re: [FFmpeg-devel] [PATCH]configure: Check for msghdr struct

2016-03-01 Thread Moritz Barsnick
On Tue, Mar 01, 2016 at 12:01:10 +, Carl Eugen Hoyos wrote: > Which of the links you provided is related to msghdr? Possibly only the first one. I assumed that CMSG_SPACE was related, but that was my mind running amok. It would be easier to see if we had the Solaris headers or a Solaris insta

Re: [FFmpeg-devel] [PATCH]configure: Check for msghdr struct

2016-03-01 Thread Moritz Barsnick
On Tue, Mar 01, 2016 at 14:00:14 +0100, Moritz Barsnick wrote: > Possibly only the first one. I assumed that CMSG_SPACE was related, but > that was my mind running amok. Actually, other sources hint that they are all related, defined as X/Open Unix Extensions. And these need to be enabled

[FFmpeg-devel] [PATCH 1/3] lavf: rename md5enc source to hashenc

2016-03-02 Thread Moritz Barsnick
To move away from naming it by only one of the supported algorithms. Signed-off-by: Moritz Barsnick --- libavformat/Makefile | 4 +- libavformat/hashenc.c | 171 ++ libavformat/md5enc.c | 171

[FFmpeg-devel] [PATCH 0/3] lavf: generalize md5enc to hashenc and clone the muxers

2016-03-02 Thread Moritz Barsnick
le time. I copied the currently known algorithm strings from libavutil/hash.c to the texi documentation. Moritz Barsnick (3): lavf: rename md5enc source to hashenc lavf/hashenc: rename variables where appropriate lavf/hashenc: clone md5 and framemd5 muxers into hash an

[FFmpeg-devel] [PATCH 2/3] lavf/hashenc: rename variables where appropriate

2016-03-02 Thread Moritz Barsnick
d of "md5", now gains an "md5" name, as it will continue to exist in order to carry the same default option for the "legacy" muxers. Signed-off-by: Moritz Barsnick --- libavformat/hashenc.c | 68 +-- 1 file changed, 34

[FFmpeg-devel] [PATCH 3/3] lavf/hashenc: clone md5 and framemd5 muxers into hash and framehash muxers

2016-03-02 Thread Moritz Barsnick
The two new muxers are functionally identical, except that they default to the SHA-512 algorithm instead of MD5. The original "legacy" muxers continue to provide their MD5 defaults. The currently supported hash functions are now documented. Signed-off-by: Moritz Barsnick ---

Re: [FFmpeg-devel] Regression maybe

2016-03-03 Thread Moritz Barsnick
Hi Julian, On Thu, Mar 03, 2016 at 18:43:11 +, JULIAN GARDNER wrote: > I was going to bisect it and see if i can find a commit which breaks the > mpegts output?, but what commit do I start on for 63057 [...] > ffmpeg version N-78734-g666e2ed Copyright (c) 2000-2016 the FFmpeg developers

Re: [FFmpeg-devel] [PATCH] nvenc.c Fix H264 and HEVC vui info update

2016-03-04 Thread Moritz Barsnick
On Thu, Mar 03, 2016 at 22:50:10 -0800, Timothy Gu wrote: > This patched is corrupted by your mail client. What's wrong with the first > patch you sent (with git-send-email)? While the first one was mail-technically okay (probably), the patch contained apparent whitespace changes and trailing whit

[FFmpeg-devel] [PATCH] lavc/mjpegdec: avoid printing useless message in default log level

2016-03-08 Thread Moritz Barsnick
The change of bps from 0 doesn't contain any info useful to the user. This message is now at info log level only if the original value is !=0, otherwise pushed back to debug log level. The original value is displayed additionally. Signed-off-by: Moritz Barsnick --- libavcodec/mjpegdec.

[FFmpeg-devel] [PATCH] lavf/mp3dec: avoid printing useless message in default log level

2016-03-08 Thread Moritz Barsnick
"Skipping 0 bytes of junk" is useless to the user, and essentially indicates a NOP. At 0 bytes, this message is now pushed back to the debug log level. Signed-off-by: Moritz Barsnick --- libavformat/mp3dec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/l

Re: [FFmpeg-devel] [PATCH] lavf/mp3dec: avoid printing useless message in default log level

2016-03-08 Thread Moritz Barsnick
On Tue, Mar 08, 2016 at 15:53:15 +0100, wm4 wrote: > AV_LOG_INFO is effectively a verbose level anyway, because FFmpeg > prints a lot of stuff at level INFO, so I'm not sure how useful it is. It is verbose, but it's the default, and has recently been cluttered with this confusing information. I ju

[FFmpeg-devel] [PATCH v2] lavf/mp3dec: avoid printing useless message in default log level

2016-03-08 Thread Moritz Barsnick
"Skipping 0 bytes of junk" is useless to the user, and essentially indicates a NOP. At 0 bytes, this message is now pushed back to the verbose log level. Signed-off-by: Moritz Barsnick --- libavformat/mp3dec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/l

[FFmpeg-devel] [PATCH v2] lavc/mjpegdec: avoid printing useless message in default log level

2016-03-08 Thread Moritz Barsnick
The change of bps from 0 doesn't contain any useful information. This message is now at info log level only if the original value is !=0, otherwise pushed back to verbose log level. The original value is displayed additionally. Signed-off-by: Moritz Barsnick --- libavcodec/mjpegdec.c | 2

Re: [FFmpeg-devel] [PATCH v2] lavc/mjpegdec: avoid printing useless message in default log level

2016-03-08 Thread Moritz Barsnick
On Tue, Mar 08, 2016 at 16:55:02 +0100, Moritz Barsnick wrote: > The change of bps from 0 doesn't contain any useful information. > This message is now at info log level only if the original value > is !=0, otherwise pushed back to verbose log level. The original > value is displ

Re: [FFmpeg-devel] [PATCH] lavc/lpc: exploit even symmetry of window function

2016-03-09 Thread Moritz Barsnick
On Tue, Mar 08, 2016 at 22:16:50 -0500, Ganesh Ajjanagadde wrote: > ffmpeg -i sin.flac -acodec aac -y sin_new.aac 5.22s user 0.03s system 105% > cpu 4.970 total Just wondering: Is this the sin.flac from ffmpeg -f lavfi -i aevalsrc="sin(440*2*PI*t):s=48000" -t 300 -y sin.flac ?? Is a sinusoidal

Re: [FFmpeg-devel] [PATCH] Use matroska TrackNumber for populating AVStream::id

2016-03-10 Thread Moritz Barsnick
On Wed, Mar 09, 2016 at 15:56:53 -0800, Sergey Volk wrote: > -if (fmt_ctx->iformat->flags & AVFMT_SHOW_IDS) print_fmt("id", > "0x%x", stream->id); > +#if FF_API_OLD_INT32_STREAM_ID > +#define STREAM_ID_FORMAT "0x%x" > +#else > +#define STREAM_ID_FORMAT "0x%"PRIx64 > +#endif > +if (fmt_c

Re: [FFmpeg-devel] JPEG 2000 support via OpenJPEG

2016-03-10 Thread Moritz Barsnick
On Thu, Mar 10, 2016 at 17:13:12 -0500, Aaron Boxer wrote: > Does FFMpeg support OpenJPEG version 2.x ? Since January, yes: https://ffmpeg.org/pipermail/ffmpeg-devel/2015-December/185794.html > with same CLI and same name for binaries. ffmpeg doesn't use cli, it uses libraries, APIs and ABIs. M

Re: [FFmpeg-devel] [PATCH 0/3] lavf: generalize md5enc to hashenc and clone the muxers

2016-03-11 Thread Moritz Barsnick
On Wed, Mar 02, 2016 at 15:17:58 +0100, Moritz Barsnick wrote: > As suggested in the thread regarding the proposed streammd5 muxer: > http://ffmpeg.org/pipermail/ffmpeg-devel/2016-February/189694.html > this patchset converts the md5/framemd5 muxers into hash/hashenc muxers with > al

Re: [FFmpeg-devel] [PATCH]lavc/hevc: Support GBR encoding and decoding

2016-03-12 Thread Moritz Barsnick
On Sat, Mar 12, 2016 at 13:44:13 +0100, Carl Eugen Hoyos wrote: > break; > +case AV_PIX_FMT_GBRP: > +case AV_PIX_FMT_GBRP10: > +case AV_PIX_FMT_GBRP12: > +ctx->params->vui.matrixCoeffs = AVCOL_SPC_RGB; > +ctx->params->vui.bEnableVideoSignalTypePresentFlag = 1;

Re: [FFmpeg-devel] JPEG 2000 support via OpenJPEG

2016-03-14 Thread Moritz Barsnick
On Mon, Mar 14, 2016 at 10:00:52 -0400, Aaron Boxer wrote: > On Thu, Mar 10, 2016 at 5:18 PM, Moritz Barsnick wrote: > > On Thu, Mar 10, 2016 at 17:13:12 -0500, Aaron Boxer wrote: > > > with same CLI and same name for binaries. > > ffmpeg doesn't use cli, it

Re: [FFmpeg-devel] [PATCH 2/2] lavf: Add coreimage filter for GPU based image filtering on OSX.

2016-03-14 Thread Moritz Barsnick
On Mon, Mar 14, 2016 at 19:37:33 +0100, Thilo Borgmann wrote: > > So > > if (x) > > SafeCFRelease(a); > > else > > SafeCFRelease(b); > > > > can work. > > At least the clang preprocessor keeps the outer {} so that this should work. > I'm not arguing - if experience says compilers

Re: [FFmpeg-devel] libav commit f8c34f4b8d62afad3f63cf3d9617d73735bef8c1 (again)

2016-03-16 Thread Moritz Barsnick
On Wed, Mar 16, 2016 at 09:17:55 +0100, Mats Peterson wrote: > >> > >> > >> > >> Why are always 10+ mails quoted, when none of the context is of interest? I'm tired of skipping all this stuff... I must find that mutt patch again. (Mats, this isn't personally directe

Re: [FFmpeg-devel] [PATCH] lavc/indeo2: Fix banding artifacts and washed-out display

2016-03-16 Thread Moritz Barsnick
On Wed, Mar 16, 2016 at 09:47:05 +0100, Mats Peterson wrote: > Well, OK. Although in one way I'm the author, since I was the one who > cut and pasted his changes. I might has well have written them > myself. No! Don't do this! How can you even think that way? BTW, that's exactly what some people

Re: [FFmpeg-devel] [PATCH 2/2] lavf: Add coreimage filter for GPU based image filtering on OSX.

2016-03-18 Thread Moritz Barsnick
On Wed, Mar 16, 2016 at 14:43:23 +0100, Thilo Borgmann wrote: > +by a list of space separated float values. Character escaping has to be done. > +A special option name @code{default} is available to use default options for > a > +filter. > +It is required to specify either @code{default} or at le

Re: [FFmpeg-devel] [PATCH] added support for hardware assist H264 video encoding for the Raspberry Pi

2016-03-22 Thread Moritz Barsnick
On Tue, Mar 22, 2016 at 11:12:18 -0800, Lou Logan wrote: > > +* Redistributions of source code must retain the above copyright > > + notice, this list of conditions and the following disclaimer. > > + * Redistributions in binary form must reproduce the above copyright > > + notice, t

Re: [FFmpeg-devel] Building FFmpeg with OpenJPEG 2

2016-03-22 Thread Moritz Barsnick
On Tue, Mar 22, 2016 at 15:44:26 -0400, Aaron Boxer wrote: > Sorry, I have another question about OpenJPEG: Again, this is the list for the development of ffmpeg, not its compilation, use or development *with*. Please refer to the ffmpeg-user list for such questions. Moritz _

Re: [FFmpeg-devel] GP License question

2016-03-22 Thread Moritz Barsnick
On Tue, Mar 22, 2016 at 08:44:34 -0400, Aaron Boxer wrote: > That would be OpenJPEG. I have made quite a few contributions to OpenJPEG. > For a number of reason which I don't want to bore you with, I decided to > fork the project. Is that the code you are proposing to integrate? Then why doesn't

Re: [FFmpeg-devel] [PATCH] avcodec: Remove libdcadec, we already have it merged internally

2016-03-25 Thread Moritz Barsnick
On Fri, Mar 25, 2016 at 21:34:45 +, Kieran Kunhya wrote: > +- libfaac removed Well, this is most certainly a typo. ;-) Moritz ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH]lavc/fic: Be less verbose for invisible or empty cursor

2016-03-27 Thread Moritz Barsnick
On Sat, Mar 26, 2016 at 14:24:53 +0100, Carl Eugen Hoyos wrote: > -av_log(avctx, AV_LOG_WARNING, > +av_log(avctx, AV_LOG_DEBUG, > "Invalid cursor position: (%d,%d). Skipping cusor.\n", "Unrelated fix", but you might as well fix the typo: ^ Moritz __

Re: [FFmpeg-devel] [PATCH] doc/developer.texi: Add a code of conduct

2016-03-28 Thread Moritz Barsnick
On Mon, Mar 28, 2016 at 02:18:32 +0200, Michael Niedermayer wrote: > +it is malice its rarely good to start with that as initial assumption. ^ , it's > +The goal of Software development is to create technical excellence, not for > any ^ s Moritz _

Re: [FFmpeg-devel] [RFC]lavf/mpegtsenc: Allow DVB stream_type for mp2 audio

2016-03-29 Thread Moritz Barsnick
On Tue, Mar 29, 2016 at 21:09:07 +0200, Carl Eugen Hoyos wrote: > Afaict, this is not what was requested in the ticket though. Pretty much so, except if you want to interpret different things into "broadcasting standards". From an ITU-T H.222.0 standpoint, your patch at least correctly fixes *som

Re: [FFmpeg-devel] Need help with transcoding example

2016-03-31 Thread Moritz Barsnick
Hello Przemysław, On Thu, Mar 31, 2016 at 11:17:17 +0200, Przemysław Sobala wrote: > Hello > I've altered doc/examples/transcoding.c to encode using aac codec: Please use the libav-user list for questions regarding the usage of ffmpeg's libraries and the programming with ffmpeg. https://ffmp

Re: [FFmpeg-devel] [PATCH] avformat/framehash: Add more information to the output

2016-04-02 Thread Moritz Barsnick
On Sat, Apr 02, 2016 at 02:45:05 -0300, James Almer wrote: > Somebody recently sent a patch to rename framemd5 and probably also framecrc > into framehash (keeping the old names as aliases for compat reason). Maybe the > efforts could be combined. That was me: https://ffmpeg.org/pipermail/ffmpeg-d

Re: [FFmpeg-devel] Error while generating images from video through network

2016-04-06 Thread Moritz Barsnick
On Wed, Apr 06, 2016 at 10:59:00 +, Gururaj Nayak wrote: > Dear Team, >I am using ffmpeg.exe for converting video into images and getting > problem while extraction . Video files are located on network . Some > times images (frames) getting skipped while extracting it

Re: [FFmpeg-devel] [PATCH 8/8] lavf/movenc+dashenc: add automatic bitstream filtering

2016-04-08 Thread Moritz Barsnick
On Thu, Apr 07, 2016 at 19:38:09 -0500, Rodger Combs wrote: > --- > libavformat/dashenc.c | 43 +++- > libavformat/movenc-test.c | 3 ++ > libavformat/movenc.c | 100 > +++--- > 3 files changed, 121 insertions(+), 25 deletions(-)

Re: [FFmpeg-devel] hardware codec for ffmpeg upstream

2016-04-08 Thread Moritz Barsnick
On Fri, Apr 08, 2016 at 14:30:13 +0800, Jung Zhao wrote: > Yes, I have written. Any code format and patch rules I need to abide? Yes, plenty. See http://ffmpeg.org/developer.html (all of it), and for the patches particularily http://ffmpeg.org/developer.html#Submitting-patches . Cheers, Moritz __

Re: [FFmpeg-devel] [PATCH] lavfi/perspective: Add basic timeline editing.

2016-04-11 Thread Moritz Barsnick
On Sun, Apr 10, 2016 at 18:33:47 +0200, Thilo Borgmann wrote: > +It accepts the following values: > +@table @samp > +@item init > +only evaluate expressions once during the filter initialization or > +when a command is processed Please add (somewhere) that this is the default. Moritz

Re: [FFmpeg-devel] [PATCH] lavfi/perspective: Add basic timeline editing.

2016-04-11 Thread Moritz Barsnick
On Mon, Apr 11, 2016 at 12:30:26 +0200, Thilo Borgmann wrote: > > Please add (somewhere) that this is the default. > This is already in: Oh darn, sorry. I apparently checked above and inline. Moritz ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCHv2] add signature filter for MPEG7 video signature

2016-04-19 Thread Moritz Barsnick
Just some random observations from me. > BTW: > ./ffmpeg -i ~/test2.mkv -vf signature=xml:filename=signature.xml -f null - > fails because xml is not a valid parameter. > ./ffmpeg -i ~/test2.mkv -vf > signature=xml:filename=signature.xml:detectmode=full -f null - > fails not, but write binary to

Re: [FFmpeg-devel] Compiling issue with x265 with ffmpeg

2016-04-19 Thread Moritz Barsnick
On Tue, Apr 19, 2016 at 19:53:07 +, Akshat Singh wrote: > I use this guide to compile ffmpeg and other libraries but I have come to Which guide? Questions regarding the compilation of ffmpeg and the use of the command line tools should be directed to the ffmpeg-user mailing list. What's more,

Re: [FFmpeg-devel] FFmpeg 3.0.2 and other point releases

2016-04-21 Thread Moritz Barsnick
On Thu, Apr 21, 2016 at 15:48:08 +0200, Michael Niedermayer wrote: > like always, backport things to the release branches if you want to > backport something before. *Something* seems to have been fixed on master with parsing HLS, which wasn't working in 3.0.1: http://ffmpeg.org/pipermail/ffmpeg-u

<    2   3   4   5   6   7   8   9   10   11   >