Re: [FFmpeg-devel] [V5 2/4] lavc/vaapi_encode: Add max slices number query.

2017-09-13 Thread Moritz Barsnick
On Thu, Aug 24, 2017 at 09:13:09 +0800, Jun Zhao wrote: > +// Supported max-slices number per frame. (0 means driver cannot > +// support max mutil-slices query) ^ multi Moritz ___ ffmpeg-devel mailing list ffmpeg-devel@

Re: [FFmpeg-devel] [V5 3/4] lavc/vaapi_encode_h264: respect "slices" option in h264 vaapi encoder

2017-09-13 Thread Moritz Barsnick
On Thu, Aug 24, 2017 at 09:13:20 +0800, Jun Zhao wrote: > +av_log(avctx, AV_LOG_ERROR, "The max slices number per frame " > + "cannot more than %d.\n", ctx->max_slices); "cannot be more" (This remark also applies to the h265 patch.) Moritz ___

Re: [FFmpeg-devel] [FFmpeg-cvslog] avcodec/pngdec: Fix () placement

2017-09-13 Thread Moritz Barsnick
On Wed, Aug 23, 2017 at 22:26:45 +0200, Alexander Strasser wrote: > > -if ((ret = decode_zbuf(&bp, s->gb.buffer, s->gb.buffer + length) < 0)) > > +if ((ret = decode_zbuf(&bp, s->gb.buffer, s->gb.buffer + length)) < 0) > > IMHO another reason not to do the assignment and the comparison on t

Re: [FFmpeg-devel] [PATCH] avfilter: add despill filter

2017-09-14 Thread Moritz Barsnick
On Mon, Aug 28, 2017 at 15:25:54 +0200, Paul B Mahol wrote: > +@table @option > +@item type > +Set what type of despill to use. Please add: Accepted values are @code{green} and @code{blue} for greenscreen and bluescreen spills. (Or make this a list.) > +@item mix > +Set how spillmap will

Re: [FFmpeg-devel] [PATCHv3] avformat/mpegts: opus muxing & demuxing for mapping family 255

2017-09-14 Thread Moritz Barsnick
On Fri, Sep 08, 2017 at 01:46:38 +0200, pkv.stream wrote: > -avpriv_request_sample(fc, "Opus in MPEG-TS - > channel_config_code > 0x8"); [...] > +avpriv_request_sample(fc, "Opus in MPEG-TS - > channel_config_code"); You probably need to mention the

Re: [FFmpeg-devel] [PATCH] lavd: add audio packets adopting example of NewTek NDI

2017-09-17 Thread Moritz Barsnick
On Mon, Sep 04, 2017 at 17:12:45 +0300, Maksym Veremeyenko wrote: > Subject: [PATCH 2/3] lavd: add audio packets adopting example of NewTek NDI ^ doc/outdevs: > +Some NDI receiver want audio packets with 1920 samples per audio packet and > interleaved closer to video pa

Re: [FFmpeg-devel] rtmps connect block

2017-09-19 Thread Moritz Barsnick
On Thu, Sep 07, 2017 at 12:46:54 +, Qiming Jin (qimijin) wrote: > Hi all > Please help check an issue: You should report this on ffmpeg's issue tracker: https://trac.ffmpeg.org/ Also please include a command line and the command's complete, uncut console output, along with your other given ex

Re: [FFmpeg-devel] [PATCH] kmsgrab: fix build error when use old libdrm

2017-09-19 Thread Moritz Barsnick
On Thu, Sep 14, 2017 at 09:12:50 +0100, Mark Thompson wrote: > > DRM_FORMAT_R16 adding from libdrm 2.4.82, fix the build error > > when libdrm < 2.4.82. > Hmm, yeah. Thanks for noticing this - let me think about it a bit > further, I imagine there are more cases than just this one. (It isn't > au

Re: [FFmpeg-devel] [PATCH] avfilter: add starfield video source

2017-09-20 Thread Moritz Barsnick
On Thu, Sep 07, 2017 at 21:29:33 +0200, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol Works fine for me. > libavfilter/Makefile | 1 + > libavfilter/allfilters.c | 1 + > libavfilter/vsrc_starfield.c | 191 > +++ Missing some texi doc

Re: [FFmpeg-devel] [PATCH] pixdesc: Add API to map color property name to enum value

2017-09-20 Thread Moritz Barsnick
On Wed, Sep 20, 2017 at 14:23:32 +0200, Vittorio Giovara wrote: > +/** > + * @return the AVChromaLocation value for name or -1 if not found. > + */ You missed modifying the "-1" here. Moritz ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://f

[FFmpeg-devel] [PATCH 0/2] lavf: fixes for older GnuTLS

2017-09-26 Thread Moritz Barsnick
This series adds a fix for a regression for building with older GnuTLS [1/2] and a silencing of warnings for ancient GnuTLS [2/2]. Moritz Barsnick (2): lavf/tls_gnutls: fix compilation with GnuTLS 2.x lavf/tls_gnutls: fix warnings from version check libavformat/tls_gnutls.c | 6 ++ 1

[FFmpeg-devel] [PATCH 2/2] lavf/tls_gnutls: fix warnings from version check

2017-09-26 Thread Moritz Barsnick
BER" #if HAVE_THREADS && GNUTLS_VERSION_NUMBER <= 0x020b00 This adds a fallback to the older, deprecated LIBGNUTLS_VERSION_NUMBER macro. Signed-off-by: Moritz Barsnick --- libavformat/tls_gnutls.c | 4 1 file changed, 4 insertions(+) diff --git a/libavformat/tls_gnutls.c

[FFmpeg-devel] [PATCH 1/2] lavf/tls_gnutls: fix compilation with GnuTLS 2.x

2017-09-26 Thread Moritz Barsnick
Commit 598e41684066feba701d19ca7443d24b9e5efa77 added use of GNUTLS_E_PREMATURE_TERMINATION, which wasn't introduced to GnuTLS before 2.99.x / 3.x. This fixes compilation with older versions. Signed-off-by: Moritz Barsnick --- libavformat/tls_gnutls.c | 2 ++ 1 file changed, 2 inser

Re: [FFmpeg-devel] [PATCH] libavformat: Add format context parameter to ff_id3v2_read_dict

2017-09-29 Thread Moritz Barsnick
On Tue, Sep 26, 2017 at 08:49:44 +0200, Lukas Stabe wrote: > - * Chapters are not currently read by this variant. > + * Chapters are not currently only read by this variant when s is not NULL. I believe you forgot to drop the first "not" from that sentence. Moritz

Re: [FFmpeg-devel] [DEVEL][PATCH] ffmpeg: fix channel_layout bug on non-default layout

2017-10-04 Thread Moritz Barsnick
On Mon, Oct 02, 2017 at 21:50:50 +0200, pkv.stream wrote: > if (!ost->stream_copy) { > -char *sample_fmt = NULL; > + > + char *sample_fmt = NULL; > This is very obviously a patch which will not be accepted. > -MATCH_PER_STREAM_OPT(sample_fmts, str, sample_fmt,

Re: [FFmpeg-devel] [PATCH 3/3] avformat/hls: add http_keepalive option

2017-10-05 Thread Moritz Barsnick
On Wed, Oct 04, 2017 at 15:03:34 -0700, Aman Gupta wrote: > From: Aman Gupta > > This teaches the HLS demuxer to use the HTTP protocols > multiple_requests=1 option, to take advantage of "Connection: > Keep-Alive" when downloading playlists and segments from the HLS server. Nice. Quick test: A

Re: [FFmpeg-devel] [PATCH 3/3] avformat/hls: add http_keepalive option

2017-10-05 Thread Moritz Barsnick
On Thu, Oct 05, 2017 at 13:41:07 +0200, wm4 wrote: > I don't really see where this patch checks whether the host changes? > The minimal requirements for reusing the connection would be using > the same protocol and the same host. I *believe* it just tries to reuse the connection and falls back to

Re: [FFmpeg-devel] [PATCH 3/3] avformat/hls: add http_keepalive option

2017-10-05 Thread Moritz Barsnick
On Thu, Oct 05, 2017 at 22:21:09 +0200, Carl Eugen Hoyos wrote: > Could you remind me why this was useful? It never was to me. (Except at loglevel debug and above.) Moritz ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/l

Re: [FFmpeg-devel] [PATCHv2 0/2] avdevice/decklink: 10-bit video out and sources/sinks support

2017-10-06 Thread Moritz Barsnick
On Thu, Oct 05, 2017 at 15:32:04 -0400, Devin Heitmueller wrote: > This patch series incorporates feedback provided from Marton Balint. > Note that patch 4 in the previous patch series was consolidated into > patch 3 per Marton's suggestion. There's no patch 3 in the series you sent. And you missp

Re: [FFmpeg-devel] [PATCH 2/6] vaapi: Remove H.264 baseline profile

2017-10-09 Thread Moritz Barsnick
On Sun, Oct 08, 2017 at 16:49:58 +0100, Mark Thompson wrote: > switch (avctx->profile) { > +case FF_PROFILE_H264_BASELINE: > +av_log(avctx, AV_LOG_WARNING, "H.264 baseline profile is not " > + "supported, using constrained baseline profile instead.\n"); > +avc

Re: [FFmpeg-devel] [PATCH 09/20] lavc: Add h264_redundant_pps bitstream filter

2017-10-09 Thread Moritz Barsnick
On Sun, Oct 08, 2017 at 21:01:43 +0100, Mark Thompson wrote: > This applies a specific fixup to some Bluray streams which contain [...] > +This applies a specific fixup to some Bluray streams which contain Nit: Blu-ray Moritz ___ ffmpeg-devel mailing li

Re: [FFmpeg-devel] Mjpeg to RTP without re-encoding

2017-10-09 Thread Moritz Barsnick
On Mon, Oct 09, 2017 at 13:18:51 +0200, Louis-Paul CORDIER wrote: > I'm currently using ffmpeg API to send video stream through RTP. The codec > used in the RTP protocol is MJPEG. Below is my workflow: For questions regarding the use of the libav* libraries, please contact the libav-user mailing

Re: [FFmpeg-devel] [PATCH] avdevice/decklink_dec: Added SCTE104 message decode from VANC

2017-10-15 Thread Moritz Barsnick
On Fri, Oct 13, 2017 at 09:10:30 -0400, Devin Heitmueller wrote: > Video filters cannot create new streams No? I thought they could. (I'm not challenging any of your other statements. I wouldn't know.) Moritz ___ ffmpeg-devel mailing list ffmpeg-devel@

Re: [FFmpeg-devel] [PATCH] libavformat/cache: don't treat 0 as EOF libavformat/aviobuf: don't treat 0 as EOF libavformat/avio: retry_transfer_wrapper: don't treat 0 as EOF

2017-10-15 Thread Moritz Barsnick
On Sat, Oct 14, 2017 at 19:27:34 +0200, Daniel Kucera wrote: > Subject: [FFmpeg-devel] [PATCH] libavformat/cache: don't treat 0 as EOF > libavformat/aviobuf: don't treat 0 as EOF libavformat/avio: > retry_transfer_wrapper: don't treat 0 as EOF Something went wrong with your commit

Re: [FFmpeg-devel] [PATCH] libavdevice/decklink: 32 bit audio support

2017-10-17 Thread Moritz Barsnick
On Tue, Oct 17, 2017 at 09:22:27 -0400, Dave Rice wrote: > >> --- a/libavdevice/decklink_dec_c.c > >> +++ b/libavdevice/decklink_dec_c.c > >> @@ -72,6 +72,7 @@ static const AVOption options[] = { > >> { "wallclock", NULL, 0, > >> AV_OPT_TYPE_CONST, {

Re: [FFmpeg-devel] [PATCH] doc/filters: Add note on Flite thread safety and update URL

2017-10-17 Thread Moritz Barsnick
On Mon, Oct 09, 2017 at 11:19:45 +0530, Gyan Doshi wrote: > Version 2 of Flite, a speech synthesis library, was released towards the > end of 2014. Among the notes at the project site: "Thread safe (really > this time)". BTW, I have a patch flying around for support of flite 1.3. ffmpeg currentl

Re: [FFmpeg-devel] [PATCH] libavdevice/decklink: 32 bit audio support

2017-10-17 Thread Moritz Barsnick
On Tue, Oct 17, 2017 at 11:12:46 -0400, Dave Rice wrote: > Thanks for pointing me in the right direction. I am attaching an > updated patch below; however, after removing my 16/32 and using the > enumeration method (with the patch below), it accepts any value > between AUDIO_BITDEPTH_LOWEST and AU

Re: [FFmpeg-devel] decklink 24/32 bit question

2017-10-17 Thread Moritz Barsnick
Hi Doug, On Tue, Oct 03, 2017 at 20:39:49 -0700, Douglas Marsh wrote: > After digging around in places, made the following changes: [...] > It doesn't work (the audio capture is close but wrong), but believe it > is a step in the correct direction. Anybody have a clue? Saw several > names in cpp

Re: [FFmpeg-devel] [PATCH] lavc: drop support for OpenJPEG 1.3-2.0

2017-10-19 Thread Moritz Barsnick
On Wed, Oct 18, 2017 at 20:21:21 -0700, Michael Bradshaw wrote: > I've added a note to the Changelog. Let me know if there are additional > notices that should be made. It was remarked that pkg-config support was introduced with *2.0.1*, not *2.1(.0)*. James's comment: http://ffmpeg.org/pipermail

Re: [FFmpeg-devel] [PATCH] Fix for paletteuse to support transparency

2017-10-20 Thread Moritz Barsnick
On Thu, Oct 19, 2017 at 18:00:52 -0400, Bjorn Roche wrote: > +{ "threshold", "set the alpha threshold for transparency. Above this > threshold, pixels are considered opaque, below they are considered > transparent.", OFFSET(trans_thresh), AV_OPT_TYPE_INT, {.i64=128}, 0, 255, }, This seems a

Re: [FFmpeg-devel] fix minor leak in id3v2 parsing

2017-10-24 Thread Moritz Barsnick
On Tue, Oct 24, 2017 at 19:38:58 -0300, James Almer wrote: > > Subject: [PATCH] Fix minor ffmpeg memory leak in id3v2 parsing. > > > > Reviewed-on: https://chromium-review.googlesource.com/439405 > > Reviewed-by: Dale Curtis [...] > This doesn't seem to apply to git head, or even the recently cut

Re: [FFmpeg-devel] [BUMP][PATCH] avfilter/zscale: fix memory leak

2017-10-28 Thread Moritz Barsnick
On Sat, Oct 28, 2017 at 13:29:01 -0400, Dxfhgwet wrote: > From: dxfhgwet A patch should name a proper author. Whether you establish that name "dxfhgwet" used there instead of your real name is up to you, but the email address doesn't identify you at all. (This remark is also valid for your other

Re: [FFmpeg-devel] [PATCH] Fix signed integer overflow in mov_write_single_packet Detected with clang and -fsanitize=signed-integer-overflow

2017-10-29 Thread Moritz Barsnick
On Sat, Oct 28, 2017 at 21:36:10 -0700, Vitaly Buka wrote: > ping You didn't respond to Carl Eugen's review. Furthermore, the second line of your commit message ("Detected...") should be separated from the first with an empty line. Moritz ___ ffmpeg-de

Re: [FFmpeg-devel] [PATCH] avfilter/zscale: add explanation for error 3074

2017-10-29 Thread Moritz Barsnick
On Sat, Oct 28, 2017 at 20:54:02 -0400, Dxfhgwet wrote: -av_log(ctx, AV_LOG_ERROR, "code %d: %s\n", err_code, err_msg); +if (err_code == ZIMG_ERROR_NO_COLORSPACE_CONVERSION) { +av_log(ctx, AV_LOG_ERROR, "code %d: %s. Try specifying matrix/transfer/primaries.\n"; +} else { +

Re: [FFmpeg-devel] [PATCH] ffmpeg.c: fix calculation of input file duration in seek_to_start()

2017-10-29 Thread Moritz Barsnick
On Sun, Oct 29, 2017 at 12:08:05 +0100, Peter Große wrote: > } else duration = 1; For style/readability, the statement should be on a new line, perhaps even with brackets. (Not necessarily as part of this patch though.) Moritz ___ ffmpeg-de

Re: [FFmpeg-devel] haunted by "undefined reference to `vaUnmapBuffer'"

2017-10-31 Thread Moritz Barsnick
Hi Sampsa On Tue, Oct 31, 2017 at 21:38:42 +0200, Sampsa Riikonen wrote: > Dear List, > I am compiling a stripped-down, static versions of the libraries, i.e. : > > libavcodec.a libavformat.a libavutil.a libswscale.a libavfilter.a > libswresample.a > > and I'm "baking them in" into a custom sha

[FFmpeg-devel] [PATCH] lavf/vf_ocr: check ff_set_common_formats() return value

2017-10-31 Thread Moritz Barsnick
Signed-off-by: Moritz Barsnick --- The only remaining unchecked one I could find in lavf. Fixes a warning, obviously. libavfilter/vf_ocr.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/libavfilter/vf_ocr.c b/libavfilter/vf_ocr.c index e003982f05..abfff49438 100644

[FFmpeg-devel] [PATCH] lavfi/pan: better handling of negative gains

2016-10-08 Thread Moritz Barsnick
mplified by a factor of 50 (= 1/(-0.49+0.51)), which can lead to clipping with any non-related inputs, as the negative gain factor actually only inverts the input's phase, not its level. This is fixed in the first patch. Moritz Barsnick (2): lavfi/pan: renormalize negative gain coefficients p

[FFmpeg-devel] [PATCH] lavfi/pan: renormalize negative gain coefficients properly

2016-10-08 Thread Moritz Barsnick
The parser for the outdef will accept a negative value for the first named channel's gain. As negative values effectively only invert the phase of the signal, and not negate the level, the gains' absolute values must be used to correctly accumulate the levels. Signed-off-by: Morit

[FFmpeg-devel] [PATCH] lavfi/pan: allow negative gain parameters also for other inputs than the first named

2016-10-08 Thread Moritz Barsnick
Expands the parser to also accept the separator '-' in addition to '+', and take the negative sign into consideration. Signed-off-by: Moritz Barsnick --- doc/filters.texi | 2 +- libavfilter/af_pan.c | 8 +--- 2 files changed, 6 insertions(+), 4 deletions(

[FFmpeg-devel] [PATCH] doc: fix various typos and grammar errors

2016-10-09 Thread Moritz Barsnick
Signed-off-by: Moritz Barsnick --- doc/codecs.texi | 2 +- doc/demuxers.texi| 4 ++-- doc/ffmpeg.texi | 2 +- doc/fftools-common-opts.texi | 8 doc/filters.texi | 42 +- doc/formats.texi

[FFmpeg-devel] [PATCH 1/5] tools: fix grammar error

2016-10-09 Thread Moritz Barsnick
Signed-off-by: Moritz Barsnick --- tools/ismindex.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/ismindex.c b/tools/ismindex.c index 5917d42..c16e2f2 100644 --- a/tools/ismindex.c +++ b/tools/ismindex.c @@ -375,7 +375,7 @@ static int read_tfra(struct Tracks *tracks

[FFmpeg-devel] [PATCH 0/5] fix various typos and grammar errors

2016-10-09 Thread Moritz Barsnick
These can likely be squashed, or kept separately, as you like. Moritz Barsnick (5): tools: fix grammar error lavc: fix typos lavfi: fix typos lavf: fix typos cmdutils: fix typos cmdutils.c | 4 ++-- cmdutils.h | 4 ++-- libavcodec/asvenc.c | 2

[FFmpeg-devel] [PATCH 2/5] lavc: fix typos

2016-10-09 Thread Moritz Barsnick
Signed-off-by: Moritz Barsnick --- libavcodec/asvenc.c| 2 +- libavcodec/mpeg12dec.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/asvenc.c b/libavcodec/asvenc.c index ec98a0c..c4eca2a 100644 --- a/libavcodec/asvenc.c +++ b/libavcodec/asvenc.c @@ -61,7

[FFmpeg-devel] [PATCH 4/5] lavf: fix typos

2016-10-09 Thread Moritz Barsnick
Signed-off-by: Moritz Barsnick --- libavformat/hlsenc.c | 4 ++-- libavformat/oggparsevp8.c | 2 +- libavformat/swfdec.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index e0bb44b..9ca2df7 100644 --- a/libavformat

[FFmpeg-devel] [PATCH 3/5] lavfi: fix typos

2016-10-09 Thread Moritz Barsnick
Signed-off-by: Moritz Barsnick --- libavfilter/af_pan.c| 4 ++-- libavfilter/vf_blackframe.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/libavfilter/af_pan.c b/libavfilter/af_pan.c index 1eb102c..7c02f67 100644 --- a/libavfilter/af_pan.c +++ b/libavfilter

[FFmpeg-devel] [PATCH 5/5] cmdutils: fix typos

2016-10-09 Thread Moritz Barsnick
Signed-off-by: Moritz Barsnick --- cmdutils.c | 4 ++-- cmdutils.h | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/cmdutils.c b/cmdutils.c index 71b3b2f..469c2d5 100644 --- a/cmdutils.c +++ b/cmdutils.c @@ -2112,7 +2112,7 @@ static int print_device_sources(AVInputFormat

Re: [FFmpeg-devel] [PATCH] avformat/udp: deprecate local_port option

2016-10-09 Thread Moritz Barsnick
On Sun, Oct 09, 2016 at 20:25:39 +0800, Steven Liu wrote: > 2016-10-09 20:24 GMT+08:00 Steven Liu : > > > check newline with chrome+gmail > > > Shit! https://productforums.google.com/forum/#!topic/gmail/VUbNjK8mUbA So you'd probably get the patch marked as text/plain if you renamed it to .patch.

[FFmpeg-devel] [PATCH] doc: fix various typos and grammar errors

2016-10-09 Thread Moritz Barsnick
Signed-off-by: Moritz Barsnick --- doc/codecs.texi | 2 +- doc/demuxers.texi| 4 ++-- doc/ffmpeg.texi | 2 +- doc/fftools-common-opts.texi | 8 doc/filters.texi | 42 +- doc/formats.texi

Re: [FFmpeg-devel] [PATCH] lavfi/pan: allow negative gain parameters also for other inputs than the first named

2016-10-11 Thread Moritz Barsnick
On Mon, Oct 10, 2016 at 19:09:34 +0200, Nicolas George wrote: > Maybe I am missing something, but I do not see where sign is reset to 1 > before the next run of the loop. You are correct. Too stupid me, I must pay more attention. And improve my testing. ;-) New patch coming. Thanks for checking,

[FFmpeg-devel] [PATCH] lavfi/pan: allow negative gain parameters also for other inputs than the first named

2016-10-11 Thread Moritz Barsnick
Expands the parser to also accept the separator '-' in addition to '+', and take the negative sign into consideration. Signed-off-by: Moritz Barsnick --- doc/filters.texi | 2 +- libavfilter/af_pan.c | 11 --- 2 files changed, 9 insertions(+), 4 deletions(

Re: [FFmpeg-devel] [PATCH] lavf/movenc: suggest video_track_timescale for invalid timescale

2016-10-11 Thread Moritz Barsnick
On Tue, Oct 11, 2016 at 12:30:30 +0100, Josh de Kock wrote: > "WARNING codec timebase is very high. If duration is > too long,\n" > "file may not be playable by quicktime. Specify a > shorter timebase\n" > - "or choose differen

Re: [FFmpeg-devel] [PATCH] libavf: Auto-detect mjpeg 2000 in mpeg-ts

2016-10-11 Thread Moritz Barsnick
On Tue, Oct 11, 2016 at 15:52:33 +0200, Ståle kristoffersen wrote: > + * VC-1 demuxer > + * Copyright (c) 2016 Ståle Kristoffersen I don't think it's a VC-1 demuxer. ;-) Moritz ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mail

Re: [FFmpeg-devel] [PATCH] Apple Quicktime fix / MP4 and MOV Timebase

2016-10-11 Thread Moritz Barsnick
On Tue, Oct 11, 2016 at 19:32:14 +0100, Josh de Kock wrote: > On 11/10/2016 18:24, Alexey Eromenko wrote: > > *** BLURB HERE *** > > This commit message isn't very useful, it doesn't describe the change at > all. See: > https://www.ffmpeg.org/developer.html#Patches_002fCommitting That's the cove

Re: [FFmpeg-devel] [PATCH] avcodec/libx264: fix forced_idr logic

2016-10-12 Thread Moritz Barsnick
On Wed, Oct 12, 2016 at 21:57:16 +0200, Timo Rothenpieler wrote: > Currently, it forces IDR frames for both true and false. > Not entirely sure what the original idea behind the tri-state bool > option is. The option's default of -1 ("auto") doesn't seem useful either, since the code doesn't do an

Re: [FFmpeg-devel] [PATCH] lavf: add ffprobe demuxer

2016-10-13 Thread Moritz Barsnick
On Thu, Oct 13, 2016 at 19:46:41 +0200, Stefano Sabatini wrote: > +In particular, can be also used to inject data stream generated by ^ it can > +Unrecognized values are discarded (this allows the demuxer to accept > +the output generated by @command{ffprobe} without further > +m

Re: [FFmpeg-devel] [PATCH] avfilter/af_silenceremove: add optional tone when silence is removed

2016-10-14 Thread Moritz Barsnick
> enum SilenceMode { > -SILENCE_TRIM, > +SILENCE_TRIM = 0, > SILENCE_TRIM_FLUSH, > SILENCE_COPY, > SILENCE_COPY_FLUSH, > -SILENCE_STOP > +SILENCE_STOP, > +SILENCE_END_MARKER > +}; > + > +static const char* SILENCE_MODE_NAMES[] = { > +NULL_IF_CONFIG_SMALL("TRI

Re: [FFmpeg-devel] [PATCH] avfilter/af_silenceremove: add optional tone when silence is removed

2016-10-14 Thread Moritz Barsnick
On Fri, Oct 14, 2016 at 18:09:51 +, Greg Rowe wrote: > In the attached patch I've tried to make all of the changes you've > pointed out. I also renamed tone_hz to tone_frequency on Moritz > Barsnick's suggestion. You attached the old patch. ;-) > Is there a good way to generate the tone while

Re: [FFmpeg-devel] [PATCH 2/3] lavfi/loudnorm: add an internal libebur128 library

2016-10-17 Thread Moritz Barsnick
On Mon, Oct 17, 2016 at 17:09:15 +0200, wm4 wrote: > Does this copy parts of libebur128 to FFmpeg? > Why? There was a long discussion regarding this patch: http://lists.ffmpeg.org/pipermail/ffmpeg-devel/2016-April/192668.html (in summary: "please don't require yet another small external library,

Re: [FFmpeg-devel] comma at the end of enumerator lists

2016-10-18 Thread Moritz Barsnick
On Tue, Oct 18, 2016 at 00:21:42 +0200, Carl Eugen Hoyos wrote: > In any case, your second patch is acceptable, should not have > any adversary effects and we have significantly worse cosmetic > patches in our tree, so it is ok imo. I only see one patch - did I miss one? - , and if that's the one

Re: [FFmpeg-devel] comma at the end of enumerator lists

2016-10-18 Thread Moritz Barsnick
On Mon, Oct 17, 2016 at 23:23:31 +0200, Michael Behrisch wrote: > My main reason is that we are compiling with different compilers for > different platforms If you're trying to keep ffmpeg more portable, you could at least try the real-life thing and actually attempt to build with Sun Studio or ne

Re: [FFmpeg-devel] [PATCH] lavf: add ffprobe demuxer

2016-10-19 Thread Moritz Barsnick
On Tue, Oct 18, 2016 at 13:33:27 +0200, Stefano Sabatini wrote: > > Latest patch in attachment with ffprobe demuxer disabled by default, > > and extended documentation. (I'm also attaching the ff_get_line2 patch > > which is used by this new patch). > Updated, depends on the ff_get_line2() patch. [

Re: [FFmpeg-devel] [PATCH] vf_colorspace: don't spam console with warnings if range is unspecified.

2016-10-21 Thread Moritz Barsnick
On Thu, Oct 20, 2016 at 12:06:14 -0400, Ronald S. Bultje wrote: > +s->did_range_warn = 1; > +} > // fall-through > +} > case AVCOL_RANGE_MPEG: The fall-through comment seems misplaced now (both logically and probably for Coverity). Moritz

Re: [FFmpeg-devel] [PATCH] vf_colorspace: don't spam console with warnings if range is unspecified.

2016-10-22 Thread Moritz Barsnick
On Sat, Oct 22, 2016 at 08:43:26 -0400, Ronald S. Bultje wrote: > Is there documentation on what coverity expects? I found this: https://lost-contact.mit.edu/afs/cs.stanford.edu/pkg/prevent-4.3.1/i386_linux26/opt/prevent-linux-4.3.1/cgi-bin/doc/checker_ref.html#c_checker_MISSING_BREAK Moritz

Re: [FFmpeg-devel] doc/filters : add metadata info for blackframe filter

2016-10-23 Thread Moritz Barsnick
On Sat, Oct 22, 2016 at 22:06:50 +0200, Martin Vignali wrote: > +This filter export frame metadata @code{lavfi.blackframe.pblack}. ^s > +The value represent the percentage of pixels in the picture that ^s Moritz ___

Re: [FFmpeg-devel] [PATCH 09/13] avcodec/svq1dec: clear MMX state after MB decode loop

2016-10-25 Thread Moritz Barsnick
On Tue, Oct 25, 2016 at 14:28:38 +0200, u-9...@aetey.se wrote: > In a perfect world the user might be offered a build time choice: > either lose N% of the performance or take the consequences of not > following the ABI. That was exactly my thought too, assuming it doesn't pollute the code even mor

Re: [FFmpeg-devel] [PATCH] vf_colorspace: don't spam console with warnings if range is unspecified.

2016-10-25 Thread Moritz Barsnick
On Sat, Oct 22, 2016 at 22:02:15 -0400, Ronald S. Bultje wrote: > I was hoping for documentation on what it expects, not what can be changed > about it :) Anyway, I'll change it, I don't really care. I had found this to be quite clear: > End with a comment. The checker assumes that this comment is

Re: [FFmpeg-devel] is it possible that avfilter graph updates its setting in realtime?

2016-10-25 Thread Moritz Barsnick
On Tue, Oct 25, 2016 at 14:24:34 +0800, qw wrote: > I have one question about some rare usage for avfilter graph: Wrong list for usage. > Sometimes, I want to change the setting in avfilter graph. For > example, fps filter is used to set output frame rate, and it's > expected that fps can be chan

Re: [FFmpeg-devel] decode_slice_header error

2016-10-27 Thread Moritz Barsnick
On Thu, Oct 27, 2016 at 12:26:09 +, Stefano Carucci wrote: > I came across an issue while decoding the H264 elementary stream with the > following error: This is the development list, not the usage list. > [h264 @ 0x1851540] Found reference and non-reference fields in the > same frame, which

[FFmpeg-devel] [PATCH] lavfi/pan: allow negative gain parameters also for other inputs than the first named

2016-10-28 Thread Moritz Barsnick
Expands the parser to also accept the separator '-' in addition to '+', and take the negative sign into consideration. The optional sign for the first factor in the expression is already covered by parsing for an integer. Signed-off-by: Moritz Barsnick --- doc/f

Re: [FFmpeg-devel] [PATCH] lavfi/pan: allow negative gain parameters also for other inputs than the first named

2016-10-28 Thread Moritz Barsnick
On Thu, Oct 13, 2016 at 11:31:22 +0200, Nicolas George wrote: > Nit: inconsistent placement of the else clause. Not blocking. Fixed, and ping. Thanks, Moritz ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg

Re: [FFmpeg-devel] [PATCH] lavf/os_support: Add safe win32 dlopen/dlclose/dlsym functions.

2016-10-29 Thread Moritz Barsnick
On Sat, Oct 29, 2016 at 18:35:19 +1100, Matt Oliver wrote: > +#endif /* COMPAT_W32DLFCN_H */ > \ No newline at end of file This shouldn't happen. Moritz ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-dev

Re: [FFmpeg-devel] [PATCH v2] ffmpeg: parameters for filter thread counts

2016-10-29 Thread Moritz Barsnick
On Thu, Oct 27, 2016 at 10:45:10 -0400, DeHackEd wrote: > +@item -filter_threads @var{nb_thraeds} (@emph{global}) ^ threads > +Defines how many threads are used to process a filter_compltex graph. ^ complex

Re: [FFmpeg-devel] [PATCH] news: add final report for summer of code 2016

2016-10-30 Thread Moritz Barsnick
On Sun, Oct 30, 2016 at 01:57:58 -0700, reyna...@osg.samsung.com wrote: > +Without further ado, here's the silver-lining for each one of the > projects we sought to complete during this Summer of Code season: > + > + FFv1 (Mentor: Michael Nierdermayer) ^ Niede

Re: [FFmpeg-devel] [PATCH] mov: extract stsd vendor field in metadata.

2016-11-08 Thread Moritz Barsnick
On Mon, Nov 07, 2016 at 16:30:02 -0800, Zhenni Huang wrote: > -avio_rb32(pb); /* vendor */ > +video_vendor_id = avio_rb32(pb); /* vendor */ > avio_rb32(pb); /* temporal quality */ > avio_rb32(pb); /* spatial quality */ > > +/* set video_vendor_id */ > +video_vendor_id_bu

Re: [FFmpeg-devel] [PATCH 2/2] iocodec: add ico_read_close to fix leaking ico->images

2016-11-08 Thread Moritz Barsnick
On Wed, Nov 09, 2016 at 00:00:09 +0100, Andreas Cadhalpun wrote: > [PATCH 2/2] iocodec: add ico_read_close to fix leaking ico->images ^ icodec M. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffm

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/mpeg4videodec: Workaround interlaced mpeg4 edge MC bug

2016-11-12 Thread Moritz Barsnick
On Sat, Nov 12, 2016 at 13:34:02 +0100, Carl Eugen Hoyos wrote: > > +if ((ctx->lavc_build&0xFF) >= 100) { > (Do we guarantee that MICRO <= 255?) Most of the version macros in libavutil/version.h will not behave as expected if not, as they assume 8 bits. So, yes, that's an implicit requirem

[FFmpeg-devel] [PATCH] doc/bsfs: various improvements

2016-11-15 Thread Moritz Barsnick
: Moritz Barsnick --- I can also submit this as a series of smaller commits, if that's easier to review. My original local branch had 10 commits... doc/bitstream_filters.texi | 95 -- 1 file changed, 83 insertions(+), 12 deletions(-) diff --git

Re: [FFmpeg-devel] [PATCH] doc/bsfs: various improvements

2016-11-15 Thread Moritz Barsnick
On Tue, Nov 15, 2016 at 13:55:56 -0900, Lou Logan wrote: > Fixes ticket #3198, but you don't need to send a new patch to mention > that. Ah, I wasn't even aware. Feel free to amend the commit message. > LGTM, thanks. I'll wait a day or two if anyone else wants to comment > before I push it. I co

Re: [FFmpeg-devel] [PATCH] Added the interface for the Turing codec

2016-11-19 Thread Moritz Barsnick
On Fri, Nov 18, 2016 at 20:15:30 +0100, wm4 wrote: > This lib has a really weird API... I can't judge the algorithms or the development direction and stuff - I'm sure it's all state of the art. But the API sure gives me goosebumps, and I don't mean the sexy feelgood type. Sure, it has all the fle

Re: [FFmpeg-devel] [PATCH] NVENC: Better surface allocation alghoritm, fix rc_lookahead

2016-11-21 Thread Moritz Barsnick
On Mon, Nov 21, 2016 at 12:17:43 +0100, Miroslav Slugeň wrote: > + "Defined rc_lookahead require more surfaces, " Nit:^ requires Moritz ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http:/

Re: [FFmpeg-devel] libavcodec : add psd image file decoder

2016-11-21 Thread Moritz Barsnick
On Mon, Nov 21, 2016 at 21:44:55 +0100, Martin Vignali wrote: > +avpriv_request_sample(s->avctx, "ZIP without predictor compression"); > +return AVERROR_PATCHWELCOME; > +break; > +case 3: > +avpriv_request_sample(s->avctx, "ZIP with predictor compression"); > +

Re: [FFmpeg-devel] Help with adding new adpcm decoder

2016-11-22 Thread Moritz Barsnick
On Tue, Nov 22, 2016 at 15:04:46 +0100, Michael Niedermayer wrote: > On Tue, Nov 22, 2016 at 12:47:04PM +0100, James Darnley wrote: > > The file starts with a riff wave header that lies about being pcm and > > other values, but I can force the decoder with ffmpeg. In the data > > block (which has

Re: [FFmpeg-devel] [PATCH] Allow client to enable/disable openh264 load balancing.

2016-11-29 Thread Moritz Barsnick
On Mon, Nov 28, 2016 at 16:29:01 -0500, Gregory J. Wolfe wrote: > +#if OPENH264_VER_AT_LEAST(1, 6) > +{ "load_balancing", "enable/disable load balancing", > OFFSET(load_balancing), AV_OPT_TYPE_BOOL, { .i64 = 1 }, 0, 1, VE }, > +#endif This could use a documentation update. And since document

Re: [FFmpeg-devel] [PATCH] Allow client to enable/disable openh264 load balancing.

2016-12-03 Thread Moritz Barsnick
On Wed, Nov 30, 2016 at 16:44:40 +, Gregory J Wolfe wrote: > Not sure exactly what you mean by "documentation update". Some > comments in the code, or more verbosity than "enable/disable load > balancing"? Please elaborate. I was referring to doc/encoders.texi, but just noticed that libopenh

Re: [FFmpeg-devel] [PATCH 1/5] avformat/ffmdec: Remove some st->codec uses which set encoder parameters

2016-12-04 Thread Moritz Barsnick
On Sat, Dec 03, 2016 at 13:23:26 +0100, Michael Niedermayer wrote: > > Please add a comment like /* gop_size */ here and similar ones below. > > Otherwise it'll be rather mysterious what's the point of all these avio_rb* > > calls. > > done locally Are the remaining avio_rb*() calls good for any

Re: [FFmpeg-devel] [PATCH 1/3] omadec: fix overflows during bit rate calculation

2016-12-14 Thread Moritz Barsnick
On Wed, Dec 14, 2016 at 01:02:41 +0100, Andreas Cadhalpun wrote: > On 13.12.2016 08:11, Paul B Mahol wrote: > >> -st->codecpar->bit_rate= samplerate * framesize * 8 / 2048; > >> +st->codecpar->bit_rate= samplerate * framesize / 256; > > Why multiply with 8 when dividing by

Re: [FFmpeg-devel] [PATCH v3] Added Turing codec interface for ffmpeg

2016-12-14 Thread Moritz Barsnick
On Wed, Dec 14, 2016 at 14:23:05 +, Matteo Naccari wrote: > Ok, point taken on the av_* functions. On the handling bit, I was > thinking to flag the error via av_log and then call exit_program(1), > after, of course, having released the memory allocated up to that > point. Would that be ok? C

Re: [FFmpeg-devel] [PATCH 1/1] Updated version of patch 1840 (ticket 6021)

2016-12-21 Thread Moritz Barsnick
On Mon, Dec 19, 2016 at 03:05:18 +, Erik Bråthen Solem wrote: > Subject: [FFmpeg-devel] [PATCH 1/1] Updated version of patch 1840 (ticket > 6021) You need to give a proper commit message. Do have a look at other commits in the repo. The first line of the message (which is shown in this subj

Re: [FFmpeg-devel] libzvbi automatically obtain teletext durations

2016-07-13 Thread Moritz Barsnick
On Wed, Jul 13, 2016 at 15:31:54 +0300, Lukas wrote: > May we expect an update, which modifies libzvbi to have default > behaviour to obtain original durations from teletext? libzvbi is not an ffmpeg project. I believe this limitation is from said library, so you need to ask its developers. (ffmp

Re: [FFmpeg-devel] [PATCH] lavf/img2enc: mention -vframes in error output

2016-07-15 Thread Moritz Barsnick
On Mon, Jul 11, 2016 at 13:31:08 -0800, Lou Logan wrote: > On Mon, 11 Jul 2016 21:08:40 + (UTC), Carl Eugen Hoyos wrote: > > Lou Logan lrcd.com> writes: > > > or use -vframes 1 to output single image)\n", > > > > Since this is a muxer and -vframes is an ffmpeg option, > > I am not convince

Re: [FFmpeg-devel] [PATCH 1/2] refine the doc of hlsenc

2016-07-18 Thread Moritz Barsnick
Hi, generally speaking, should it also be mentioned how hls_flags are used (or at least that it takes the flags syntax)? On Tue, Jul 12, 2016 at 21:35:46 +0800, Steven Liu wrote: > [PATCH 1/2] refine the doc of hlsenc Should probably be: [PATCH ...] doc/muxers: improve hlsenc description > +@it

Re: [FFmpeg-devel] [PATCH] avformat: Add multi protocol

2016-07-18 Thread Moritz Barsnick
On Mon, Jul 18, 2016 at 14:42:22 +0200, Michael Niedermayer wrote: > \ No newline at end of file Not recommended, I guess. ;-) ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avformat/matroskaenc: Write duration early during mkv_write_header

2016-07-19 Thread Moritz Barsnick
On Tue, Jul 19, 2016 at 01:02:07 +, Soft Works wrote: > I apologize - I'm new to this project and have to get familiar with the > coding styles.. Before writing your first line of code, read other ffmpeg code as well as the developer guidelines. Those things mentioned in this thread are all n

Re: [FFmpeg-devel] [PATCH] avformat/fivdec: cached keyframes before video or audio stream was created

2016-07-20 Thread Moritz Barsnick
On Thu, Jul 21, 2016 at 00:06:44 +0800, zhangxinzheng wrote: > Subject: [FFmpeg-devel] [PATCH] avformat/fivdec: cached keyframes before > video or audio stream was created ^^^ flv > There has an error when seeking in a flv file, which key frames was > s

Re: [FFmpeg-devel] [PATCH 3/4] af_hdcd: Add counter for cdt expirations

2016-07-24 Thread Moritz Barsnick
Nitpicking: > Adds a counter for when the code detect timer expired without ^ detects > +int count_sustain_expired;/* occurances of code detect timer > expiring without detecting a code */ ^ occurrences > +if

Re: [FFmpeg-devel] libavcodec : add psd image file decoder

2016-07-24 Thread Moritz Barsnick
On Sun, Jul 24, 2016 at 15:21:00 +0200, Martin Vignali wrote: > Subject: [PATCH] libavcodec : add decoder for .psd image file. [...] > +- Psd Decoder [...] > +@item PSD @tab @tab X > +@tab Photoshop [...] > +.long_name = NULL_IF_CONFIG_SMALL("Photoshop file"), ".psd", "psd",

Re: [FFmpeg-devel] [PATCH] web/security: Add links to GPG keys, for people who want to send encrypted mail

2016-08-03 Thread Moritz Barsnick
On Wed, Aug 03, 2016 at 14:17:21 +0200, Michael Niedermayer wrote: > +If you wish to use PGP/GnuPG you can use. This sounds slightly strange. -> "If you wish to use PGP/GnuPG please do so." (Is this preferred by the list? Then that should be expressed.) ___

Re: [FFmpeg-devel] [PATCH] avfilter: add crystalizer filter.

2016-08-06 Thread Moritz Barsnick
On Sat, Aug 06, 2016 at 11:05:29 +0300, Остросаблин Виталий wrote: > +The filter accepts the following option: ^ options > +Sets the intensity of effect (default: 2.0). Must be in range between 0.0 ^ of the effect ^ ran

Re: [FFmpeg-devel] [PATCH 2/2] [RFC] avutil/version: Improve lib versioning sheme for release branches with the next major release

2016-08-06 Thread Moritz Barsnick
On Sat, Aug 06, 2016 at 12:52:54 +0200, Michael Niedermayer wrote: > + * Prior FFmpeg 3.2 point releases did not change any lib version number to ^ Prior to > + * a seperate MAJOR.MINOR that is not used on the master development branch ^ separate > + * that is if we branch a release

<    1   2   3   4   5   6   7   8   9   10   >