On Sat, Aug 06, 2016 at 11:05:29 +0300, Остросаблин Виталий wrote:
> +The filter accepts the following option:
^ options
> +Sets the intensity of effect (default: 2.0). Must be in range between 0.0
^ of the effect ^ range from
...
> +(unchanged sound) to 10.0 (maximum effect).
> +@item c
@item c @var{boolean}
(Just a suggestion, it seems it is not used everywhere.)
> +Enable clipping. By default is enabled.
^ Enabled by default.
> +static const AVOption crystalizer_options[] = {
> + { "i", "effect intensity", OFFSET(mult), AV_OPT_TYPE_FLOAT, {.dbl=2.0},
> 0, 10, A },
> + { "c", "enable clipping", OFFSET(clip), AV_OPT_TYPE_BOOL,
> {.i64=1}, 0, 1, A },
> + { NULL }
> +};
I would probably add aliases, such as
{ "intensity", "effect intensity", OFFSET(mult), AV_OPT_TYPE_FLOAT,
{.dbl=2.0}, 0, 10, A },
{ "i", "effect intensity", OFFSET(mult), AV_OPT_TYPE_FLOAT,
{.dbl=2.0}, 0, 10, A },
{ "clipping", "enable clipping", OFFSET(clip), AV_OPT_TYPE_BOOL,
{.i64=1}, 0, 1, A },
{ "c", "enable clipping", OFFSET(clip), AV_OPT_TYPE_BOOL,
{.i64=1}, 0, 1, A },
(same in docs) but that's quite cosmetic.
> REGISTER_FILTER(COMPAND, compand, af);
> + REGISTER_FILTER(CRYSTALIZER, crystalizer, af);
> REGISTER_FILTER(COMPENSATIONDELAY, compensationdelay, af);
Please stick to alphabetic order. ;-)
Moritz
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
