Hi Hendrik,
Thanks for working on it. Version needs to be updated as well:
https://github.com/FFmpeg/FFmpeg/blob/b905ba5bc18c89c7fccd862179575562ef19/libavformat/movenc.c#L1115.
Suggest moving it into ff_isom_write_vpcc function too.
-- KongQun Yang (KQ)
On Tue, Apr 18, 2017 at 7:30 AM
Correct. There is a mistake in the spec. I have created a pull request to
fix that earlier today: https://github.com/webmproject/vp9-dash/pull/69
-- KongQun Yang (KQ)
On Fri, Apr 21, 2017 at 2:52 PM, James Almer wrote:
> On 4/21/2017 6:47 PM, James Almer wrote:
>
>> On 4/21/
-- KongQun Yang (KQ)
On Fri, Apr 21, 2017 at 4:49 PM, Hendrik Leppkes
wrote:
> On Sat, Apr 22, 2017 at 1:25 AM, Hendrik Leppkes
> wrote:
> > This brings our generation of the vpcC box up to date to version 1.0
> > of the VP Codec ISO Media File Format Binding.
> >
MOVMuxContext *mov, MOVTrack *tr
mov_write_avcc_tag(pb, track);
if (track->mode == MODE_IPOD)
mov_write_uuid_tag_ipod(pb);
+} else if (track->par->codec_id == AV_CODEC_ID_VP9) {
+mov_write_vpcc_tag(pb, track);
} else if (track->par->co
log(s, AV_LOG_ERROR,
+ "VP9 in MP4 support is experimental, add "
+ "'-strict %d' if you want to use it.\n",
+ FF_COMPLIANCE_EXPERIMENTAL);
+ret = AVERROR_EXPERIMENTAL;
+
vc.
3. Use av_pix_fmt_desc_get(pixel_format)->comp[0].depth suggested by Ronald
to get bit depth
As for the comments on color space from James, the structure is
specific to "vp in mp4" specification, so we cannot reuse the code from
libavcodec or libvpx.
-- KongQun Yang (KQ)
On Mo
log(s, AV_LOG_ERROR,
+ "VP9 in MP4 support is experimental, add "
+ "'-strict %d' if you want to use it.\n",
+ FF_COMPLIANCE_EXPERIMENTAL);
+ret = AVERROR_EXPERIMENTAL;
+
e > FF_COMPLIANCE_EXPERIMENTAL) {
+av_log(s, AV_LOG_ERROR,
+ "VP9 in MP4 support is experimental, add "
+ "'-strict %d' if you want to use it.\n",
+ FF_COMPLIANCE_EXPE
e > FF_COMPLIANCE_EXPERIMENTAL) {
+av_log(s, AV_LOG_ERROR,
+ "VP9 in MP4 support is experimental, add "
+ "'-strict %d' if you want to use it.\n",
+ FF_COMPLIANCE_EXPE
Thanks for the review. Please see patchset v4 for the new change. (Please
ignore patchset v3 which is uploaded incorrectly)
-- KongQun Yang (KQ)
On Tue, Jun 14, 2016 at 1:11 PM, Ronald S. Bultje
wrote:
> Hi,
>
> On Mon, Jun 13, 2016 at 5:26 PM, Kongqun Yang
> wrote:
>>
>
liance > FF_COMPLIANCE_EXPERIMENTAL) {
+av_log(s, AV_LOG_ERROR,
+ "VP9 in MP4 support is experimental, add "
+ "'-strict %d' if you want to use it.\n",
+ FF_COMP
-- KongQun Yang (KQ)
On Tue, Jun 14, 2016 at 6:13 PM, Ronald S. Bultje
wrote:
> Hi,
>
> On Tue, Jun 14, 2016 at 7:34 PM, Hendrik Leppkes
> wrote:
>
> > On Wed, Jun 15, 2016 at 12:05 AM, Kongqun Yang
> > wrote:
> > > Implemented according to the draft spe
-- KongQun Yang (KQ)
On Tue, Jun 14, 2016 at 4:20 PM, Ronald S. Bultje
wrote:
> Hi,
>
> On Tue, Jun 14, 2016 at 6:05 PM, Kongqun Yang
> wrote:
>
>> +default:
>> +av_log(NULL, AV_LOG_ERROR, "Unsupported color space (%d)\n",
>> +
-- KongQun Yang (KQ)
On Tue, Jun 14, 2016 at 4:34 PM, Hendrik Leppkes
wrote:
> On Wed, Jun 15, 2016 at 12:05 AM, Kongqun Yang
> wrote:
> > Implemented according to the draft specification
> > "VP Codec ISO Media File Format Binding":
> >
> http://www.we
Please take a look at patchset v5. Thanks.
-- KongQun Yang (KQ)
On Tue, Jun 14, 2016 at 2:58 PM, Ronald S. Bultje
wrote:
> Hi,
>
> On Tue, Jun 14, 2016 at 5:52 PM, Kongqun Yang
> wrote:
>
>> +if (profile == FF_PROFILE_UNKNOWN) {
>> +
{
+if (s->strict_std_compliance > FF_COMPLIANCE_EXPERIMENTAL) {
+av_log(s, AV_LOG_ERROR,
+ "VP9 in MP4 support is experimental, add "
+ "'-strict %d' if you want to use it.\n",
+
Thanks for the review, uploaded patch v7 with two changes:
1. Use AVFormatContext as the logging context
2. Renamed the file from vpc.c/vpc.h to vpcc.c/vpcc.h
Please take another look.
-- KongQun Yang (KQ)
On Tue, Jun 14, 2016 at 11:27 PM, Hendrik Leppkes
wrote:
> On Wed, Jun 15, 2016 at 3
-- KongQun Yang (KQ)
On Wed, Jun 15, 2016 at 5:00 AM, Carl Eugen Hoyos wrote:
> Kongqun Yang gmail.com> writes:
>
> > +} else if (chroma_w == 0 && chroma_h == 0) {
> > +return VPX_SUBSAMPLING_444;
>
> Could you confirm that this fixes
-- KongQun Yang (KQ)
On Wed, Jun 15, 2016 at 3:08 PM, Ronald S. Bultje
wrote:
> Hi,
>
> On Wed, Jun 15, 2016 at 4:53 PM, Kongqun Yang
> wrote:
>
>> Implemented according to the draft specification
>> "VP Codec ISO Media File Format Binding":
>>
>&g
-- KongQun Yang (KQ)
On Fri, Jun 17, 2016 at 7:37 AM, Ronald S. Bultje
wrote:
> Hi,
>
> On Thu, Jun 16, 2016 at 9:06 AM, Ronald S. Bultje
> wrote:
>
>> Hi,
>>
>> On Wed, Jun 15, 2016 at 7:22 PM, KongQun Yang wrote:
>>
>>>
>>>
>>
Updated to the standard value 0xB1 defined in mp4ra.org.
Change-Id: I6260fb11ce275f0da12b0c92ecf670bfde28b4e5
---
libavformat/isom.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavformat/isom.c b/libavformat/isom.c
index 55221156f8..3a9b3baf96 100644
--- a/libavformat/is
21 matches
Mail list logo
