Thanks for the review, uploaded patch v7 with two changes:
1. Use AVFormatContext as the logging context
2. Renamed the file from vpc.c/vpc.h to vpcc.c/vpcc.h
Please take another look.
-- KongQun Yang (KQ)
On Tue, Jun 14, 2016 at 11:27 PM, Hendrik Leppkes <h.lepp...@gmail.com>
wrote:
> On Wed, Jun 15, 2016 at 3:25 AM, KongQun Yang
> <kqyang-at-google....@ffmpeg.org> wrote:
> > -- KongQun Yang (KQ)
> >
> > On Tue, Jun 14, 2016 at 4:20 PM, Ronald S. Bultje <rsbul...@gmail.com>
> > wrote:
> >
> >> Hi,
> >>
> >> On Tue, Jun 14, 2016 at 6:05 PM, Kongqun Yang <yangkong...@gmail.com>
> >> wrote:
> >>
> >>> + default:
> >>> + av_log(NULL, AV_LOG_ERROR, "Unsupported color space (%d)\n",
> >>> + color_space);
> >>> + return -1;
> >>>
> >> [..]
> >>
> >>> + default:
> >>> + av_log(NULL, AV_LOG_ERROR, "Unsupported pixel format (%d)\n",
> >>> + pixel_format);
> >>> + return -1;
> >>>
> >> [..]
> >>
> >>> + if (desc == NULL) {
> >>> + av_log(NULL, AV_LOG_ERROR, "Unsupported pixel format (%d)\n",
> >>> + pixel_format);
> >>> + return -1;
> >>>
> >>
> >> You're still logging without a context (first argument), can you please
> >> provide one so people know which muxer is complaining about these error
> >> messages?
> >>
> >
> > Are you ok with using "AVIOContext" as the context?
> >
>
> Thats an odd choice for logging.
> If there is no natural logging context, you should just add a "void*
> logctx" argument to the new function you introduced, its what is
> commonly done in other places. That way the mov muxer can then pass a
> reference to the AVFormatContext in there for more natural logging.
>
> - Hendrik
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
