-- KongQun Yang (KQ) On Tue, Jun 14, 2016 at 6:13 PM, Ronald S. Bultje <rsbul...@gmail.com> wrote:
> Hi, > > On Tue, Jun 14, 2016 at 7:34 PM, Hendrik Leppkes <h.lepp...@gmail.com> > wrote: > > > On Wed, Jun 15, 2016 at 12:05 AM, Kongqun Yang <yangkong...@gmail.com> > > wrote: > > > Implemented according to the draft specification > > > "VP Codec ISO Media File Format Binding": > > > > > > http://www.webmproject.org/vp9/#draft-vp-codec-iso-media-file-format-binding > > > > > > '-strict -2' is required to use this feature. > > > > > > > Not sure I really like the vpc name, when I read vpc I don't think of > > vp9, and the correlation to avc/hevc is also not really there, as > > those codecs are actually called that. AVC and HEVC, the C isn't added > > randomly. > > If anything, it should have been vp9.c then, but oh well. > > > > But anyway, if Ronald is ok with the name I won't complain. > > > > I think they intend to use it for vp10 also. > Correct. I don't want to limit it to vp9 only. I can use vpcc if Hendrik is more comfortable with that. > > > > > +static int get_vpx_transfer_function( > > > + enum AVColorTransferCharacteristic transfer) > > > +{ > > > + return !!(transfer == AVCOL_TRC_SMPTEST2084); > > > > This looks like an odd way to write it, if its ever extended to make > > use of more values, you'll have to change it entirely. > > But really just a style nit. > > > I think I agree, the == already makes the result 1/0, so the !! doesn't do > anything. > Ok, removed "!!". > > Ronald > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
