Re: [FFmpeg-devel] [PATCH] avcodec/h2645_sei: loosen up min luminance requirements

2024-05-25 Thread Kacper Michajlow
On Sat, 25 May 2024 at 13:36, Niklas Haas wrote: > > From: Niklas Haas > > The H.265 specification is quite clear on this case: > > > When min_display_mastering_luminance is not in the range of 1 to > > 5, the nominal maximum display luminance of the mastering display > > is unknown or unspec

Re: [FFmpeg-devel] [PATCH 3/6] avformat/matroskadec: export cropping values

2024-06-01 Thread Kacper Michajlow
On Wed, 29 May 2024 at 23:47, James Almer wrote: > > Signed-off-by: James Almer > --- > libavformat/matroskadec.c | 53 +++ > 1 file changed, 43 insertions(+), 10 deletions(-) > > diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c > index 2f07e

Re: [FFmpeg-devel] [PATCH] avcodec/vp9mvs: fix misaligned access when clearing VP9mv

2024-06-02 Thread Kacper Michajlow
On Sun, 2 Jun 2024 at 23:17, Ronald S. Bultje wrote: > > Hi, > > On Sun, Jun 2, 2024 at 9:12 AM James Almer wrote: > > > On 6/2/2024 10:06 AM, James Almer wrote: > > > On 6/2/2024 9:14 AM, Kacper Michajłow wrote: > > >> Fixes runtime error: member access within misaligned address > > >> for type

Re: [FFmpeg-devel] FFmpeg 7.0 blocking issues

2024-06-05 Thread Kacper Michajlow
On Mon, 3 Jun 2024 at 23:41, James Almer wrote: > > On 6/3/2024 6:32 PM, Michael Niedermayer wrote: > > On Sun, Jun 02, 2024 at 03:49:42PM +0200, Sebastian Ramacher wrote: > >> On 2024-03-03 09:55:15 +0100, Sebastian Ramacher wrote: > >>> On 2024-03-02 20:39:08 -0500, Sean McGovern wrote: > O

[FFmpeg-devel] [OSS-Fuzz] Have you considered enabling memory sanitizer?

2024-06-26 Thread Kacper Michajlow
Hi, Like in the topic. I think it would be useful to enable MSAN on OSS-Fuzz. We get some tiny issues and it would be probably good to have them tracked upstream. All infra is here, so enabling it is as simple as adding it to the project.yaml. Except libbz2.so and libz.so would have to be built in

Re: [FFmpeg-devel] [PATCH] avcodec/jpegxl_parser: check remaining data buffer size

2024-06-26 Thread Kacper Michajlow
On Wed, 26 Jun 2024 at 21:00, Andreas Rheinhardt wrote: > > Kacper Michajłow: > > Fixes use of uninitialized value, reported by MSAN. > > > > Found by OSS-Fuzz. > > > > Signed-off-by: Kacper Michajłow > > --- > > libavcodec/jpegxl_parser.c | 7 ++- > > 1 file changed, 6 insertions(+), 1 dele

Re: [FFmpeg-devel] [OSS-Fuzz] Have you considered enabling memory sanitizer?

2024-06-26 Thread Kacper Michajlow
On Thu, 27 Jun 2024 at 00:45, Michael Niedermayer wrote: > > On Wed, Jun 26, 2024 at 09:07:42PM +0200, Kacper Michajlow wrote: > > Hi, > > > > Like in the topic. I think it would be useful to enable MSAN on > > OSS-Fuzz. We get some tiny issues and it would be

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/jpegxl_parser: ensure input padding is zeroed

2024-06-27 Thread Kacper Michajlow
On Thu, 27 Jun 2024 at 02:55, Andreas Rheinhardt wrote: > > Kacper Michajłow: > > Fixes use of uninitialized value, reported by MSAN. > > > > Found by OSS-Fuzz. > > > > Signed-off-by: Kacper Michajłow > > --- > > libavcodec/jpegxl_parser.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff -

Re: [FFmpeg-devel] [PATCH] avcodec/amfenc: Fix for windows imprecise sleep

2023-10-17 Thread Kacper Michajlow
On Tue, 17 Oct 2023 at 19:34, Evgeny Pavlov wrote: > > The reason for using av_usleep() here is that AMF API doesn’t provide an > API for explicit wait. There are two modes to get output from encoder: > > 1. Polling with some sleep to avoid CPU thrashing – currently used in FFmpeg > > 2. Set timeo

Re: [FFmpeg-devel] [PATCH v4] avcodec/pngdec: read colorspace info when decoding with AVDISCARD_ALL

2023-12-10 Thread Kacper Michajlow
On Tue, 28 Feb 2023 at 20:46, Leo Izen wrote: > > On 2/27/23 11:34, Leo Izen wrote: > > On 2/21/23 17:35, Leo Izen wrote: > >> These chunks are lightweight and it's useful information to have when > >> running ffmpeg -i or ffprobe, for example. > >> --- > >> libavcodec/pngdec.c | 136 ++

Re: [FFmpeg-devel] [PATCH] avfilter/[vf_nnedi, vf_estdif]: Check interlaced flag on correct frame

2021-05-04 Thread Kacper Michajlow
On Tue, 4 May 2021 at 21:05, Kacper Michajłow wrote: > Fixes regression in vf_nnedi after > 24dc6d386c6f7edb8f6945319f53a7f0b1642bb8 and vf_estdif while at it. > > Signed-off-by: Kacper Michajłow > --- > libavfilter/vf_estdif.c | 2 +- > libavfilter/vf_nnedi.c | 2 +- > 2 files changed, 2 inse

Re: [FFmpeg-devel] [PATCH] configure: Fix DEF file post-processing with LTO enabled.

2017-09-06 Thread Kacper Michajlow
2017-08-22 21:26 GMT+02:00 Kacper Michajłow : > With LTO enabled exported symbol entry looks like: > av_audio_convert @3 DATA > > In order to maintain valid format we need to strip everything after @. > > This patch fixes linking libraries compiled with MinGW toolchain with LTO > enabled. > > Sign

Re: [FFmpeg-devel] [PATCH] configure: Fix DEF file post-processing with LTO enabled.

2017-09-23 Thread Kacper Michajlow
2017-09-08 2:52 GMT+02:00 Michael Niedermayer : > On Wed, Sep 06, 2017 at 08:03:18PM +0200, Kacper Michajlow wrote: > > 2017-08-22 21:26 GMT+02:00 Kacper Michajłow : > > > > > With LTO enabled exported symbol entry looks like: > > > av_audio_convert @3 DATA >

Re: [FFmpeg-devel] [PATCH] configure: disable the new optimizer in Visual Studio 2015 Update 3

2016-07-03 Thread Kacper Michajlow
2016-07-03 23:39 GMT+02:00 Hendrik Leppkes : > On Tue, Jun 28, 2016 at 12:01 PM, Hendrik Leppkes wrote: >> On Tue, Jun 28, 2016 at 11:48 AM, Hendrik Leppkes >> wrote: >>> Visual Studio 2015 Update 3 introduced a new SSA optimizer, however >>> it unfortunately causes miscompilations. Until it is

Re: [FFmpeg-devel] [PATCH] configure: disable the new optimizer in Visual Studio 2015 Update 3

2017-01-05 Thread Kacper Michajlow
2016-07-04 3:53 GMT+02:00 Kacper Michajlow : > 2016-07-03 23:39 GMT+02:00 Hendrik Leppkes : >> On Tue, Jun 28, 2016 at 12:01 PM, Hendrik Leppkes >> wrote: >>> On Tue, Jun 28, 2016 at 11:48 AM, Hendrik Leppkes >>> wrote: >>>> Visual Studio 2015 Upd

Re: [FFmpeg-devel] [PATCH] avformat/data_uri: Fix base64 decode buffer size calculation

2024-05-13 Thread Kacper Michajlow
On Sat, 11 May 2024 at 03:45, Michael Niedermayer wrote: > > On Thu, May 09, 2024 at 04:02:09PM +0200, Kacper Michajłow wrote: > > Also reject input if it is too short. > > > > Found by OSS-Fuzz. > > > > Signed-off-by: Kacper Michajłow > > --- > > libavformat/data_uri.c | 4 ++-- > > 1 file chan

Re: [FFmpeg-devel] [PATCH] vulkan: enable VK_KHR_cooperative_matrix

2023-08-12 Thread Kacper Michajlow
On Sat, 12 Aug 2023 at 16:45, Lynne wrote: > > It's of interest to API users, and of interest to us, > as a DCT/DST can be implemented via matrix multiplies. > > Bumps up the required header version to 1.3.255, released > 2 months ago, so it's had time to propagate. I would disagree, considering

Re: [FFmpeg-devel] [PATCH] vulkan: enable VK_KHR_cooperative_matrix

2023-08-26 Thread Kacper Michajlow
On Sat, 26 Aug 2023 at 23:19, Lynne wrote: > > Aug 13, 2023, 00:15 by kaspe...@gmail.com: > > > On Sat, 12 Aug 2023 at 16:45, Lynne wrote: > > > >> > >> It's of interest to API users, and of interest to us, > >> as a DCT/DST can be implemented via matrix multiplies. > >> > >> Bumps up the require

Re: [FFmpeg-devel] [PATCH 1/2] configure: don't force specific C++ standard library linking

2023-09-05 Thread Kacper Michajlow
On Wed, 6 Sept 2023 at 00:17, Hendrik Leppkes wrote: > > On Wed, Sep 6, 2023 at 12:14 AM Kacper Michajłow wrote: > > > > Other C++ standard libraries exist. Also, this is not a proper way to > > link the standard library anyway. Instead when a C++ dependency is > > detected, switch to the C++ com

Re: [FFmpeg-devel] [PATCH v2 1/2] configure: don't force specific C++ standard library linking

2023-09-06 Thread Kacper Michajlow
On Wed, 6 Sept 2023 at 12:15, Timo Rothenpieler wrote: > > On 06/09/2023 01:26, Kacper Michajłow wrote: > > Other C++ standard libraries exist. Also, this is not a proper way to > > link the standard library anyway. Instead when a C++ dependency is > > detected, switch to the C++ compiler driver t

Re: [FFmpeg-devel] [PATCH v2 1/2] configure: don't force specific C++ standard library linking

2023-09-06 Thread Kacper Michajlow
On Wed, 6 Sept 2023 at 19:09, Timo Rothenpieler wrote: > > On 06.09.2023 18:54, Kacper Michajlow wrote: > > On Wed, 6 Sept 2023 at 12:15, Timo Rothenpieler > > wrote: > >> > >> On 06/09/2023 01:26, Kacper Michajłow wrote: > >>> Other C++ standard

Re: [FFmpeg-devel] [PATCH v2 1/2] configure: don't force specific C++ standard library linking

2023-09-07 Thread Kacper Michajlow
On Thu, 7 Sept 2023 at 15:12, Derek Buitenhuis wrote: > > On 9/6/2023 6:31 PM, Kacper Michajlow wrote: > > What would be a downside of preferring CXX always if it exists? > > FFmpeg runs in a multitude of environments with a multitude of portability > requirements. N

Re: [FFmpeg-devel] [PATCH v2 1/2] configure: don't force specific C++ standard library linking

2023-09-08 Thread Kacper Michajlow
On Fri, 8 Sept 2023 at 00:11, Kieran Kunhya wrote: > > On Thu, 7 Sept 2023 at 22:39, Kacper Michajlow wrote: > > > On Thu, 7 Sept 2023 at 15:12, Derek Buitenhuis > > wrote: > > > > > > On 9/6/2023 6:31 PM, Kacper Michajlow wrote: > > > > What

Re: [FFmpeg-devel] [PATCH v2 1/2] configure: don't force specific C++ standard library linking

2023-09-08 Thread Kacper Michajlow
On Fri, 8 Sept 2023 at 01:35, Timo Rothenpieler via ffmpeg-devel wrote: > > On 07.09.2023 23:38, Kacper Michajlow wrote: > > On Thu, 7 Sept 2023 at 15:12, Derek Buitenhuis > > wrote: > >> > >> On 9/6/2023 6:31 PM, Kacper Michajlow wrote: > >>> What

Re: [FFmpeg-devel] [PATCH v2 1/2] configure: don't force specific C++ standard library linking

2023-09-08 Thread Kacper Michajlow
On Fri, 8 Sept 2023 at 20:46, Kieran Kunhya wrote: > > On Fri, 8 Sept 2023 at 19:42, Kacper Michajlow wrote: > > > On Fri, 8 Sept 2023 at 00:11, Kieran Kunhya wrote: > > > > > > On Thu, 7 Sept 2023 at 22:39, Kacper Michajlow > > wrote: > >

Re: [FFmpeg-devel] [PATCH] avcodec/decode: use avcodec_get_hw_config()

2024-07-08 Thread Kacper Michajlow
On Mon, 1 Jul 2024 at 12:16, Anton Khirnov wrote: > > Quoting Kacper Michajłow (2024-06-02 03:38:18) > > Fixes libavcodec/decode.c:1035:61: runtime error: member access within > > null pointer of type 'const struct AVCodecHWConfigInternal'. > > > > This can happen when hwaccel fails to initialize

Re: [FFmpeg-devel] [PATCH v2] avfilter/vf_scale: Cleanup some checks

2024-07-09 Thread Kacper Michajlow
On Tue, 9 Jul 2024 at 15:17, Anton Khirnov wrote: > > Quoting Michael Niedermayer (2024-07-09 13:37:11) > > Fixes: CID1513722 Operands don't affect result > > > > Sponsored-by: Sovereign Tech Fund > > Signed-off-by: Michael Niedermayer > > --- > > libavfilter/vf_scale.c | 6 ++ > > 1 file ch

Re: [FFmpeg-devel] [PATCH v2] avfilter/vf_scale: Cleanup some checks

2024-07-10 Thread Kacper Michajlow
On Tue, 9 Jul 2024 at 23:43, Michael Niedermayer wrote: > > On Tue, Jul 09, 2024 at 04:46:59PM +0200, Kacper Michajlow wrote: > > On Tue, 9 Jul 2024 at 15:17, Anton Khirnov wrote: > > > > > > Quoting Michael Niedermayer (2024-07-09 13:37:11) > > > > Fixe

Re: [FFmpeg-devel] [OSS-Fuzz] Have you considered enabling memory sanitizer?

2024-07-13 Thread Kacper Michajlow
On Thu, 27 Jun 2024 at 02:50, Kacper Michajlow wrote: > > On Thu, 27 Jun 2024 at 00:45, Michael Niedermayer > wrote: > > > > On Wed, Jun 26, 2024 at 09:07:42PM +0200, Kacper Michajlow wrote: > > > Hi, > > > > > > Like in the topic. I think it woul

Re: [FFmpeg-devel] [OSS-Fuzz] Have you considered enabling memory sanitizer?

2024-07-15 Thread Kacper Michajlow
On Sun, 14 Jul 2024 at 21:55, Michael Niedermayer wrote: > > On Sat, Jul 13, 2024 at 11:12:40PM +0200, Kacper Michajlow wrote: > > On Thu, 27 Jun 2024 at 02:50, Kacper Michajlow wrote: > > > > > > On Thu, 27 Jun 2024 at 00:45, Michael Niedermayer > > >

Re: [FFmpeg-devel] [OSS-Fuzz] Have you considered enabling memory sanitizer?

2024-07-16 Thread Kacper Michajlow
On Tue, 16 Jul 2024 at 14:14, Michael Niedermayer wrote: > > On Mon, Jul 15, 2024 at 01:32:20PM +0200, Kacper Michajlow wrote: > > On Sun, 14 Jul 2024 at 21:55, Michael Niedermayer > > wrote: > > > > > > On Sat, Jul 13, 2024 at 11:12:40PM +0200, Kacper Mic

Re: [FFmpeg-devel] avisynth as an internal filter, any objections?

2024-07-17 Thread Kacper Michajlow
On Wed, 17 Jul 2024 at 03:21, Roger Pack wrote: > > Hi all, just wondering, if I were to write a libavfilter that > basically "called out" to avisynth and had it process stuff, would > there be any ideological pushback, or would it possibly be accepted? > Cheers! Have you considered VapourSynth i

Re: [FFmpeg-devel] [PATCH] avformat/mov: add support for multiple decryption keys

2024-07-31 Thread Kacper Michajlow
On Mon, 13 Nov 2023 at 09:40, Adrien Guinet wrote: > > This commit introduces new options to support more than one decryption > keys: > * add a decryption_keys option to MOV, that supports a dictionnary of > KID=>key (in hex), using AV_OPT_TYPE_DICT > * add the corresponding cenc_decryption_keys

Re: [FFmpeg-devel] [PATCH 4/8] avcodec/parser: clear padding in combine frame

2024-08-04 Thread Kacper Michajlow
On Sun, 4 Aug 2024 at 22:53, Michael Niedermayer wrote: > > Fixes: use-of-uninitialized-value > Fixes: > 70852/clusterfuzz-testcase-minimized-ffmpeg_IO_DEMUXER_fuzzer-5179190066872320 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Sign

Re: [FFmpeg-devel] [PATCH 2/4] avformat/jpegxl_anim_dec: initialize bit buffer

2024-08-04 Thread Kacper Michajlow
On Sun, 4 Aug 2024 at 16:23, Michael Niedermayer wrote: > > Fixes: use-of-uninitialized-value > Fixes: > 70837/clusterfuzz-testcase-minimized-ffmpeg_dem_JPEGXL_ANIM_fuzzer-5089407768526848 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg >

Re: [FFmpeg-devel] [PATCH 3/8] avformat/img2dec: Clear padding data after EOF

2024-08-04 Thread Kacper Michajlow
On Sun, 4 Aug 2024 at 23:01, Michael Niedermayer wrote: > > Fixes: use-of-uninitialized-value > Fixes: > 70852/clusterfuzz-testcase-minimized-ffmpeg_IO_DEMUXER_fuzzer-5179190066872320 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Sign

Re: [FFmpeg-devel] [PATCH v2 1/3] avcodec/libaribb24: change new lines to \n in ASS header

2024-08-08 Thread Kacper Michajlow
On Fri, 9 Aug 2024 at 00:04, Jan Ekström wrote: > > On Fri, May 10, 2024 at 11:31 PM Kacper Michajłow wrote: > > > > Fixes remaining \r\n is ASS header after 57c545090d. > > > > Signed-off-by: Kacper Michajłow > > --- > > With an initial look this set looks good. If I understand correctly, > the

Re: [FFmpeg-devel] [PATCH 5/6] tools/target_dec_fuzzer: Use av_buffer_allocz() to avoid missing slices to have unpredictable content

2024-08-08 Thread Kacper Michajlow
On Fri, 9 Aug 2024 at 00:06, Michael Niedermayer wrote: > > On Thu, Aug 08, 2024 at 02:13:12PM -0300, James Almer wrote: > > On 8/6/2024 7:18 PM, Michael Niedermayer wrote: > > > Fixes: use of uninitialized values > > > Fixes: > > > 70885/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VP6F_fuz

Re: [FFmpeg-devel] [PATCH] avformat/vpk: fix divide by zero

2024-08-09 Thread Kacper Michajlow
On Fri, 9 Aug 2024 at 22:51, Michael Niedermayer wrote: > > On Wed, Aug 07, 2024 at 03:42:46PM +0200, Kacper Michajłow wrote: > > Can happen after calling avformat_find_stream_info() when the codec > > fails to open, but return value is 0 and subsequent uses of this context > > have zero value in

Re: [FFmpeg-devel] [PATCH] avformat/vpk: fix divide by zero

2024-08-10 Thread Kacper Michajlow
On Sat, 10 Aug 2024 at 11:25, Andreas Rheinhardt wrote: > > Kacper Michajlow: > > On Fri, 9 Aug 2024 at 22:51, Michael Niedermayer > > wrote: > >> > >> On Wed, Aug 07, 2024 at 03:42:46PM +0200, Kacper Michajłow wrote: > >>> Can happen after ca

Re: [FFmpeg-devel] [PATCH] tools/target_enc_fuzzer: Add slices and level for FFv1

2024-08-11 Thread Kacper Michajlow
On Sun, 11 Aug 2024 at 10:59, Michael Niedermayer wrote: > > Sponsored-by: Sovereign Tech Fund > Signed-off-by: Michael Niedermayer > --- > tools/target_enc_fuzzer.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/tools/target_enc_fuzzer.c b/tools/target_enc_fuzzer.c > index 059d78307

Re: [FFmpeg-devel] [PATCH] tools/target_enc_fuzzer: Add slices and level for FFv1

2024-08-11 Thread Kacper Michajlow
On Mon, 12 Aug 2024 at 02:06, Kacper Michajlow wrote: > > On Sun, 11 Aug 2024 at 10:59, Michael Niedermayer > wrote: > > > > Sponsored-by: Sovereign Tech Fund > > Signed-off-by: Michael Niedermayer > > --- > > tools/target_enc_fuzzer.c | 2 ++ > >

Re: [FFmpeg-devel] [PATCH 9/9] avformat/mov: Use int64_t in intermediate for corrected_dts

2024-08-14 Thread Kacper Michajlow
On Mon, 3 Jun 2024 at 04:16, Michael Niedermayer wrote: > > Fixes: CID1500312 Unintentional integer overflow > > Sponsored-by: Sovereign Tech Fund > Signed-off-by: Michael Niedermayer > --- > libavformat/mov.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavformat/m

Re: [FFmpeg-devel] [PATCH] avutil/timestamp: avoid using INFINITY for log10 result in av_ts_make_time_string2

2024-08-27 Thread Kacper Michajlow
On Tue, 27 Aug 2024 at 09:51, Rémi Denis-Courmont wrote: > > > > Le 27 août 2024 10:00:08 GMT+03:00, Marton Balint a écrit : > > >IMHO the patch itself is harmless (simple, easy to follow), and if it helps > >somebody (no matter how unupported its use-case is), then why the hell not. > >But I c

Re: [FFmpeg-devel] [PATCH] avutil/timestamp: avoid using INFINITY for log10 result in av_ts_make_time_string2

2024-08-28 Thread Kacper Michajlow
On Wed, Aug 28, 2024, 07:56 Rémi Denis-Courmont wrote: > > > Le 28 août 2024 06:29:30 GMT+03:00, Kacper Michajlow > a écrit : > >On Tue, 27 Aug 2024 at 09:51, Rémi Denis-Courmont > wrote: > >> > >> > >> > >> Le 27 août 2024 10:00:08

Re: [FFmpeg-devel] [PATCH 2/2] vulkan_decode: use ff_vk_init

2024-08-31 Thread Kacper Michajlow
On Sun, 1 Sept 2024 at 04:42, Lynne via ffmpeg-devel wrote: > > This solves the issue of an av_log function being called > with a context with invalid class. > > Most of the patch was written by Anton Khirnov. Does ffmpeg have conventions for such situations? I think most of the time `Co-Authored

Re: [FFmpeg-devel] [PATCH] avcodec/nellymoserenc: avoid wasteful pow

2015-12-18 Thread Kacper Michajlow
One minor nitpick about commit message. You could mention which compiler was used to generate code for benchmark. For example Clang 3.7 replaces pow(2,...) with exp2(...) call by itself. So you probably did use gcc. Anyway since it is already merged I guess take my reply as a hint for next time :)

Re: [FFmpeg-devel] [PATCH] avcodec/nellymoserenc: avoid wasteful pow

2015-12-18 Thread Kacper Michajlow
18 gru 2015 10:06 AM "Kacper Michajlow" napisał(a): > > One minor nitpick about commit message. You could mention which compiler was used to generate code for benchmark. For example Clang 3.7 replaces pow(2,...) with exp2(...) call by itself. So you probably did use gcc. An

Re: [FFmpeg-devel] [PATCH] all: Don't set AVClass.item_name to its default value

2023-12-24 Thread Kacper Michajlow
On Fri, 22 Dec 2023 at 14:57, Anton Khirnov wrote: > > Quoting Andreas Rheinhardt (2023-12-22 14:48:45) > > Avoids relocations. > > > > Signed-off-by: Andreas Rheinhardt > > --- > > Maybe mention that it's not needed after > acf63d5350adeae551d412db699f8ca03f7e76b9. This is not the only user of

Re: [FFmpeg-devel] [PATCH] all: Don't set AVClass.item_name to its default value

2023-12-27 Thread Kacper Michajlow
On Mon, 25 Dec 2023 at 11:48, Zhao Zhili wrote: > > > > > On Dec 25, 2023, at 18:21, Anton Khirnov wrote: > > > > Quoting Zhao Zhili (2023-12-25 10:27:59) > >> > >> > >>> On Dec 25, 2023, at 16:38, Anton Khirnov wrote: > >>> &

Re: [FFmpeg-devel] [PATCH] avcodec/vulkan_decode: Make Vulkan decode less spammy in verbose logs

2024-02-07 Thread Kacper Michajlow
On Wed, 7 Feb 2024 at 03:47, Lynne wrote: > > Feb 7, 2024, 03:11 by kaspe...@gmail.com: > > > Drop per frame decode messages to AV_LOG_TRACE level. > > > > Signed-off-by: Kacper Michajłow > > --- > > libavcodec/vulkan_av1.c | 2 +- > > libavcodec/vulkan_h264.c | 2 +- > > libavcodec/vulkan_hevc

Re: [FFmpeg-devel] [PATCH] configure: Fix Microsoft tools detection

2022-02-02 Thread Kacper Michajlow
On Wed, 26 Jan 2022 at 15:00, Martin Storsjö wrote: > > Hi, > > On Sat, 22 Jan 2022, Kacper Michajłow wrote: > > > LLVM tools print installation path upon execution. If one uses LLVM > > tools bundled with Microsoft Visual Studio installation, they would be > > incorrectly detected as Microsoft's

Re: [FFmpeg-devel] [PATCH v2] avformat/http: copy only mime type from Content-Type

2023-06-16 Thread Kacper Michajlow
On Thu, 1 Jun 2023 at 21:44, Kacper Michajłow wrote: > > Content-Type can include charset and boundary which is not a part of > mime type and shouldn't be copied as such. > > Fixes HLS playback when the Content-Type includes additional fields. > > Signed-off-by: Kacper Michajłow > --- > libavfor

Re: [FFmpeg-devel] [PATCH] lavu/vulkan: fix handle type for 32-bit targets

2023-03-07 Thread Kacper Michajlow
On Mon, 6 Mar 2023 at 10:00, Martin Storsjö wrote: > > On Thu, 2 Mar 2023, Kacper Michajłow wrote: > > > Fixes compilation with clang which errors out on Wint-conversion. > > > > Signed-off-by: Kacper Michajłow > > --- > > libavutil/hwcontext_vulkan.c | 2 +- > > libavutil/vulkan.h | 4 +

Re: [FFmpeg-devel] [PATCH] Revert "avformat/hls: fail on probing non hls/m3u8 file extensions"

2023-05-14 Thread Kacper Michajlow
On Sun, 14 May 2023 at 23:39, Michael Niedermayer wrote: > > On Sun, May 14, 2023 at 09:41:29PM +0200, Anton Khirnov wrote: > > This reverts commit 6b1f68ccb04d791f0250e05687c346a99ff47ea1, which > > broke many streams in the wild > > > > Fixes #10353. > > This change violates a SHOULD in rfc8216

Re: [FFmpeg-devel] [PATCH] Revert "avformat/hls: fail on probing non hls/m3u8 file extensions"

2023-05-14 Thread Kacper Michajlow
On Mon, 15 May 2023 at 01:06, Michael Niedermayer wrote: > > On Mon, May 15, 2023 at 12:40:50AM +0200, Kacper Michajlow wrote: > > On Sun, 14 May 2023 at 23:39, Michael Niedermayer > > wrote: > > > > > > On Sun, May 14, 2023 at 09:41:29PM +0200, Anton Khirno

Re: [FFmpeg-devel] [PATCH 3/3] avformat/hls: Try to implement RFC8216 playlist refusal

2023-05-15 Thread Kacper Michajlow
On Mon, 15 May 2023 at 02:06, Michael Niedermayer wrote: > > This is not well tested and can likely be improved, just a > hotfix for hls probe failures since 6b1f68ccb04d791f0250e05687c346a99ff47ea1 > > Should fix Ticket10353 (please test and report cases that still fail) > > Signed-off-by: Michae

Re: [FFmpeg-devel] Procedure to enable the Windows on ARM64 FFMPEG Libraries

2024-09-14 Thread Kacper Michajlow
On Thu, 12 Sept 2024 at 09:21, Niranjan Kshatriya (QUIC) wrote: > > Hi team, > > I am working on Windows on ARM application development and wants to execute > FFMPEG on my device. > On FFMPEG download page (Releases * BtbN/FFmpeg-Builds > (github.com)

Re: [FFmpeg-devel] [PATCH] avformat/vpk: fix divide by zero

2024-11-01 Thread Kacper Michajlow
On Sat, 10 Aug 2024 at 18:49, Kacper Michajlow wrote: > > On Sat, 10 Aug 2024 at 11:25, Andreas Rheinhardt > wrote: > > > > Kacper Michajlow: > > > On Fri, 9 Aug 2024 at 22:51, Michael Niedermayer > > > wrote: > > >> > > >> O

Re: [FFmpeg-devel] [PATCH] avformat/vpk: fix divide by zero

2024-11-01 Thread Kacper Michajlow
On Sat, 2 Nov 2024 at 01:54, Michael Niedermayer wrote: > > Hi > > On Fri, Nov 01, 2024 at 02:20:33PM +0100, Kacper Michajlow wrote: > > On Sat, 10 Aug 2024 at 18:49, Kacper Michajlow wrote: > > > > > > On Sat, 10 Aug 2024 at 11:25, Andreas Rheinhardt

Re: [FFmpeg-devel] [PATCH] avcodec/jpegxl_parser: fix reading lz77-pair as initial entropy symbol

2024-11-12 Thread Kacper Michajlow
On Thu, 7 Nov 2024 at 17:31, Leo Izen wrote: > > The JPEG XL parser has an entropy decoder inside, which supports LZ77 > length-distance pairs. If the first symbol from the entropy stream is an > LZ77 pair, the bitstream is invalid, so we should abort immediately rather > than attempt to read it a

Re: [FFmpeg-devel] [PATCH] avcodec/jpegxl_parser: clear window

2024-11-06 Thread Kacper Michajlow
e 4 bytes. > > > >> Fixes: 368725676/clusterfuzz-testcase-minimized- > >> fuzzer_protocol_file-6022251122589696-cut > >> Fixes: 42537758/clusterfuzz-testcase-minimized- > >> fuzzer_protocol_file-5818969469026304-cut > >> > >> Found-by: ossfuzz > &

Re: [FFmpeg-devel] [PATCH 2/2] avformat/rpl: Fix check for negative values

2024-12-28 Thread Kacper Michajlow
> > > a écrit : > > > > Fixes: signed integer overflow: 10 * -192326792533340 cannot be > > > > represented in type 'int64_t' (aka 'long') > > > > Fixes: > > > > 378891963/clusterfuzz-testcase-minimized-fuzzer_loa

Re: [FFmpeg-devel] [PATCH] avformat/mov: fix eof check after avio_skip()

2025-02-02 Thread Kacper Michajlow
On Mon, 3 Feb 2025 at 06:24, Kacper Michajłow wrote: > > This fix ensures that the loop stops early on EOF. The issue occurs > because mov_read_infe() performs a version check and skips unsupported > versions. The problem is that seeking within the stream clears the EOF > flag, causing avio_feof()

Re: [FFmpeg-devel] [PATCH 2/2] avformat/hls: .ts is always ok even if its a mov/mp4

2025-02-04 Thread Kacper Michajlow
On Tue, 28 Jan 2025 at 22:44, Michael Niedermayer wrote: > > Hi > > On Tue, Jan 28, 2025 at 10:12:30PM +0200, Jan Ekström wrote: > > On Tue, Jan 28, 2025 at 4:24 PM Michael Niedermayer > > wrote: > > > > > > Maybe fixes: 11435 > > > > > > > Do I understand correctly that the root issue that's bei

Re: [FFmpeg-devel] [PATCH] avformat/icodec: fix integer overflow with nb_pal

2024-11-21 Thread Kacper Michajlow
On Sun, 3 Nov 2024 at 11:24, Michael Niedermayer wrote: > > Fixes: runtime error: signed integer overflow > Fixes: > 42536949/clusterfuzz-testcase-minimized-fuzzer_loadfile-6199846684393472 > Found-by: ossfuzz > Reported-by: Kacper Michajlow > Tested-by: Kacper Michajlow >

Re: [FFmpeg-devel] [PATCH] avcodec/jpegxl_parse{, r}: fix integer overflow for some malformed files

2025-01-30 Thread Kacper Michajlow
ill > allow this to happen even if ctx->skip would overflow a signed int. > > Several other members are also changed to int64_t to avoid this problem > in other possible scenarios. > > Signed-off-by: Leo Izen > Reported-by: Kacper Michajlow > Fixes: clusterfuzz-testcase-m

Re: [FFmpeg-devel] [PATCH] avcodec/h263dec: Check against previous dimensions instead of coded

2025-01-30 Thread Kacper Michajlow
On Thu, 30 Jan 2025 at 02:57, Michael Niedermayer wrote: > > Fixes: out of array access > Fixes: crash-a41ef3db699013f669b076f02f36942925f5a98c > > Found-by: Kacper Michajlow > Signed-off-by: Michael Niedermayer > --- > libavcodec/h263dec.c | 13 + > 1

Re: [FFmpeg-devel] [PATCH v2] w32pthreads: add support for setting thread name

2025-04-13 Thread Kacper Michajlow
On Mon, 31 Mar 2025 at 02:50, softworkz . wrote: > > > > > -Original Message- > > From: ffmpeg-devel On Behalf Of Jan > > Ekström > > Sent: Montag, 31. März 2025 00:05 > > To: FFmpeg development discussions and patches > > Subject: Re: [FFmpeg-devel] [PATCH v2] w32pthreads: add support f

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/cri, tdsc, tiff: Use ff_mjpeg_decoder directly

2025-04-24 Thread Kacper Michajlow
On Mon, 21 Apr 2025 at 20:40, Andreas Rheinhardt wrote: > > Patches attached. Patches make sense to me. - Kacper ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, o

Re: [FFmpeg-devel] Misc mpegvideo patches

2025-03-09 Thread Kacper Michajlow
On Thu, 6 Mar 2025 at 14:31, Andreas Rheinhardt wrote: > > Andreas Rheinhardt: > > Ramiro Polla: > >> On Tue, Mar 4, 2025 at 6:05 PM Andreas Rheinhardt > >> wrote: > >>> Ramiro Polla: > > On 3/4/25 14:42, Andreas Rheinhardt wrote: > > (Mostly trivial) patches attached. A branch is a

Re: [FFmpeg-devel] [PATCH] w32pthreads: add support for setting thread name

2025-03-04 Thread Kacper Michajlow
On Tue, 4 Mar 2025 at 15:57, Kacper Michajlow wrote: > > On Tue, 4 Mar 2025 at 15:50, James Almer wrote: > > > > On 3/4/2025 9:52 AM, Kacper Michajłow wrote: > > > Signed-off-by: Kacper Michajłow > > > --- > > > compat/w32pthreads.h | 30 +++

Re: [FFmpeg-devel] [PATCH] w32pthreads: add support for setting thread name

2025-03-04 Thread Kacper Michajlow
On Tue, 4 Mar 2025 at 15:50, James Almer wrote: > > On 3/4/2025 9:52 AM, Kacper Michajłow wrote: > > Signed-off-by: Kacper Michajłow > > --- > > compat/w32pthreads.h | 30 ++ > > libavutil/thread.h | 2 ++ > > 2 files changed, 32 insertions(+) > > > > diff --git

Re: [FFmpeg-devel] Misc mpegvideo patches

2025-03-09 Thread Kacper Michajlow
On Sun, 9 Mar 2025 at 14:55, Andreas Rheinhardt wrote: > > Kacper Michajlow: > > On Thu, 6 Mar 2025 at 14:31, Andreas Rheinhardt > > wrote: > >> > >> Andreas Rheinhardt: > >>> Ramiro Polla: > >>>> On Tue, Mar 4, 2025 at

[FFmpeg-devel] Request for --disable-deprecated configure option

2025-04-03 Thread Kacper Michajlow
Hello, It would be nice to have configure time ability to disable all `FF_API_*` for testing purposes. As we know not all code can be marked to emit Wdeprecated. Specifically #defines doesn't emit any warning and it's easy to miss such depreciation before it's actually removed. The breakage of c

Re: [FFmpeg-devel] Request for --disable-deprecated configure option

2025-04-03 Thread Kacper Michajlow
On Thu, 3 Apr 2025 at 11:39, Martin Storsjö wrote: > > On Thu, 3 Apr 2025, Kacper Michajlow wrote: > > > Hello, > > > > It would be nice to have configure time ability to disable all > > `FF_API_*` for testing purposes. > > > > As we know n

Re: [FFmpeg-devel] [PATCH 1/2] avformat/demux: use io_close2 when closing avfromat

2025-05-17 Thread Kacper Michajlow
On Sat, 17 May 2025 at 15:03, Andreas Rheinhardt wrote: > > Andreas Rheinhardt: > > Kacper Michajłow: > >> It's not valid to call avio_close() on context that has not been open > >> with avio_open(). > >> > >> This fixes use of custom IO. (io_open / io_close2 callbacks) > >> > >> Note that by defa