Re: [FFmpeg-devel] [PATCH] avcodec/libvpxenc, cosmetics: prefer sizeof(var)

2020-01-06 Thread James Zern
On Fri, Jan 3, 2020 at 5:28 PM James Almer wrote: > > On 1/3/2020 10:16 PM, James Zern wrote: > > Signed-off-by: James Zern > > --- > > libavcodec/libvpxenc.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/libav

Re: [FFmpeg-devel] [PATCH v3 3/3] doc/encoders: add VP9 temporal scalability encoding option

2020-01-09 Thread James Zern
On Wed, Jan 8, 2020 at 3:00 PM Wonkap Jang wrote: > > Documentation change for adding support for encoding > with temporal scalability in VP9. > --- > doc/encoders.texi | 18 +++--- > 1 file changed, 15 insertions(+), 3 deletions(-) > This could be a part of the first patch in the se

Re: [FFmpeg-devel] [PATCH v4 1/2] avcodec/libvpxenc: add VP9 temporal scalability encoding option

2020-01-13 Thread James Zern
Hi, On Fri, Jan 10, 2020 at 9:59 AM Wonkap Jang wrote: > > This commit reuses the configuration options for VP8 that enables > temporal scalability for VP9. It also adds a way to enable three > preset temporal structures (refer to the documentation for more > detail) that can be used in offline e

Re: [FFmpeg-devel] [PATCH v4] avcodec/libvpxenc: add VP9 temporal scalability encoding option

2020-01-14 Thread James Zern
On Tue, Jan 14, 2020 at 11:07 AM Wonkap Jang wrote: > > This commit reuses the configuration options for VP8 that enables > temporal scalability for VP9. It also adds a way to enable three > preset temporal structures (refer to the documentation for more > detail) that can be used in offline encod

Re: [FFmpeg-devel] [PATCH v4] avcodec/libvpxenc: add VP9 temporal scalability encoding option

2020-01-17 Thread James Zern
On Wed, Jan 15, 2020 at 6:20 PM Wonkap Jang wrote: > > HI, > My comments are in-line. > > On Tue, Jan 14, 2020 at 8:55 PM James Zern > wrote: > > > On Tue, Jan 14, 2020 at 11:07 AM Wonkap Jang > > wrote: > > > [...] > > > + > > > +

Re: [FFmpeg-devel] [PATCH v4] avcodec/libvpxenc: add VP9 temporal scalability encoding option

2020-01-17 Thread James Zern
On Thu, Jan 16, 2020 at 11:04 AM Wonkap Jang wrote: > > James, > > On Thu, Jan 16, 2020 at 10:58 AM Wonkap Jang < > wonkap-at-google@ffmpeg.org> wrote: > > > This commit reuses the configuration options for VP8 that enables > > temporal scalability for VP9. It also adds a way to enable three >

Re: [FFmpeg-devel] [PATCH] Add a commandline option to control loop restoration for libaom

2020-01-17 Thread James Zern
On Mon, Dec 23, 2019 at 12:53 PM Wang Cao wrote: > > Signed-off-by: Wang Cao > --- > doc/encoders.texi | 3 +++ > libavcodec/libaomenc.c | 6 ++ > 2 files changed, 9 insertions(+) > lgtm. sorry for losing track of this. > [...] > +if (ctx->enable_restoration >= 0) > + codecct

Re: [FFmpeg-devel] [PATCH] Add a commandline option to control loop restoration for libaom

2020-01-17 Thread James Zern
On Fri, Jan 17, 2020 at 2:45 PM James Zern wrote: > > On Mon, Dec 23, 2019 at 12:53 PM Wang Cao wrote: > > > > Signed-off-by: Wang Cao > > --- > > doc/encoders.texi | 3 +++ > > libavcodec/libaomenc.c | 6 ++ > > 2 files changed, 9 insertions(

Re: [FFmpeg-devel] [PATCH v4] avcodec/libvpxenc: add VP9 temporal scalability encoding option

2020-01-21 Thread James Zern
On Fri, Jan 17, 2020 at 1:50 PM Wonkap Jang wrote: > > This commit reuses the configuration options for VP8 that enables > temporal scalability for VP9. It also adds a way to enable three > preset temporal structures (refer to the documentation for more > detail) that can be used in offline encodi

Re: [FFmpeg-devel] [PATCH] avcodec/libaomenc: add an option to set the encoder "usage"

2020-01-23 Thread James Zern
On Thu, Jan 23, 2020 at 2:26 AM James Almer wrote: > > This allows the user enable the realtime encoding speed mode > > Signed-off-by: James Almer > --- > The g_usage field is present since 1.0.0, but the AOM_USAGE_* defines were > introduced with the real time mode about a year ago. Builds befor

Re: [FFmpeg-devel] [PATCH v4] avcodec/libvpxenc: add VP9 temporal scalability encoding option

2020-01-28 Thread James Zern
On Fri, Jan 17, 2020 at 1:56 PM Wonkap Jang wrote: > > Hi James, > > On Fri, Jan 17, 2020 at 1:50 PM Wonkap Jang wrote: > > > This commit reuses the configuration options for VP8 that enables > > temporal scalability for VP9. It also adds a way to enable three > > preset temporal structures (refe

Re: [FFmpeg-devel] [PATCH v5 2/2] avcodec/libvpxenc: add a way to explicitly set temporal layer id

2020-02-03 Thread James Zern
On Mon, Feb 3, 2020 at 10:02 AM Wonkap Jang wrote: > > In order for rate control to correctly allocate bitrate to each temporal > layer, correct temporal layer id has to be set to each frame. This > commit provides the ability to set correct temporal layer id for each > frame. > --- > libavcodec/

Re: [FFmpeg-devel] [PATCH v5 1/2] avcodec/libvpxenc: add VP9 temporal scalability encoding option

2020-02-03 Thread James Zern
On Mon, Feb 3, 2020 at 10:02 AM Wonkap Jang wrote: > > This commit reuses the configuration options for VP8 that enables > temporal scalability for VP9. It also adds a way to enable three > preset temporal structures (refer to the documentation for more > detail) that can be used in offline encodi

Re: [FFmpeg-devel] [PATCH v5 2/2] avcodec/libvpxenc: add a way to explicitly set temporal layer id

2020-02-05 Thread James Zern
On Mon, Feb 3, 2020 at 5:45 PM Wonkap Jang wrote: > > Hi > > On Mon, Feb 3, 2020 at 12:45 PM James Zern > wrote: > > > On Mon, Feb 3, 2020 at 10:02 AM Wonkap Jang > > wrote: > > > > > > In order for rate control to correctly allocate bitrate to e

Re: [FFmpeg-devel] [PATCH v5 2/2] avcodec/libvpxenc: add a way to explicitly set temporal layer id

2020-02-06 Thread James Zern
On Thu, Feb 6, 2020 at 8:58 AM Wonkap Jang wrote: > > Hi James, > > On Wed, Feb 5, 2020 at 5:29 PM James Zern > wrote: > > > On Mon, Feb 3, 2020 at 5:45 PM Wonkap Jang > > wrote: > > > > > > Hi > > > > > > On Mon, Feb 3

Re: [FFmpeg-devel] [PATCH v6] avcodec/libvpxenc: add a way to explicitly set temporal layer id

2020-02-07 Thread James Zern
On Fri, Feb 7, 2020 at 10:44 AM Wonkap Jang wrote: > > Hi James, > > On Fri, Feb 7, 2020 at 10:36 AM Wonkap Jang wrote: > > > In order for rate control to correctly allocate bitrate to each temporal > > layer, correct temporal layer id has to be set to each frame. This > > commit provides the abi

Re: [FFmpeg-devel] [PATCH v7] avcodec/libvpxenc: add a way to explicitly set temporal layer id

2020-02-10 Thread James Zern
On Mon, Feb 10, 2020 at 10:30 AM Wonkap Jang wrote: > > In order for rate control to correctly allocate bitrate to each temporal > layer, correct temporal layer id has to be set to each frame. This > commit provides the ability to set correct temporal layer id for each > frame. > --- > doc/encode

Re: [FFmpeg-devel] [PATCH v7] avcodec/libvpxenc: add a way to explicitly set temporal layer id

2020-02-11 Thread James Zern
On Mon, Feb 10, 2020 at 12:58 PM James Zern wrote: > > On Mon, Feb 10, 2020 at 10:30 AM Wonkap Jang > wrote: > > > > In order for rate control to correctly allocate bitrate to each temporal > > layer, correct temporal layer id has to be set to each frame. This > &g

Re: [FFmpeg-devel] [PATCH] Pass the HDR10+ metadata to the packet side data in VP9 encoder

2021-04-23 Thread James Zern
Hi, On Fri, Apr 23, 2021 at 8:58 AM Mohammad Izadi wrote: > > HDR10+ metadata is stored in the bit stream for HEVC. The story is different > for VP9 and cannot store the metadata in the bit stream. HDR10+ should be > passed to packet side data an stored in the container (mkv) for VP9. > > This

Re: [FFmpeg-devel] [PATCH 30/34] avcodec/libvpxenc: Avoid copying packet data

2021-04-26 Thread James Zern
On Sun, Apr 25, 2021 at 3:39 PM Andreas Rheinhardt wrote: > > Here the packet size is known before allocating the packet because > the encoder provides said information (and works with internal buffers > itself), so one can pass this information to ff_alloc_packet2() to > avoid the implicit use of

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg: Restore DTS correction for VP9 copies

2021-05-14 Thread James Zern
Hi, On Wed, May 12, 2021 at 8:33 PM Danny Wu wrote: > > > Shouldn't google not produce invalid files? Also, can you link one of > > these videos to test this issue? > I filed a bug for this (b/188197059). ___ ffmpeg-devel mailing list ffmpeg-devel@ffmp

Re: [FFmpeg-devel] [PATCH 11/39] avcodec/libvpxenc: Avoid copying data, allow user-supplied buffers

2021-05-21 Thread James Zern
On Fri, May 21, 2021 at 2:19 AM Andreas Rheinhardt wrote: > > Here the packet size is known before allocating the packet because > the encoder provides said information (and works with internal buffers > itself), so one can use this information to avoid the implicit use of > another intermediate b

Re: [FFmpeg-devel] [PATCH 02/39] avcodec/libaomenc: Avoid copying data, allow user-supplied buffers

2021-05-21 Thread James Zern
On Fri, May 21, 2021 at 2:18 AM Andreas Rheinhardt wrote: > > Here the packet size is known before allocating the packet because > the encoder provides said information (and works with internal buffers > itself), so one can use this information to avoid the implicit use of > another intermediate b

Re: [FFmpeg-devel] [PATCH 12/39] avcodec/libvpxenc: Avoid one level of indentation

2021-05-21 Thread James Zern
On Fri, May 21, 2021 at 2:19 AM Andreas Rheinhardt wrote: > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/libvpxenc.c | 64 -- > 1 file changed, 31 insertions(+), 33 deletions(-) > lgtm. ___ ffmpeg-deve

Re: [FFmpeg-devel] [PATCH] avcodec: Pass the HDR10+ metadata to the packet side data in VP9 encoder

2021-05-26 Thread James Zern
On Wed, May 26, 2021 at 6:35 PM Mohammad Izadi wrote: > [...] > +static void add_hdr10_plus(AVFifoBuffer *fifo, struct FrameHDR10Plus *data) > +{ > +av_fifo_grow(fifo, sizeof(FrameHDR10Plus)); This return should be checked. > +av_fifo_generic_write(fifo, data, sizeof(FrameHDR10Plus), NUL

Re: [FFmpeg-devel] [PATCH] avcodec: Pass the HDR10+ metadata to the packet side data in VP9 encoder

2021-06-02 Thread James Zern
On Tue, Jun 1, 2021 at 6:47 PM Mohammad Izadi wrote: > [...] > +static av_cold int add_hdr10_plus(AVFifoBuffer *fifo, struct FrameHDR10Plus > *data) > +{ > +int err = av_fifo_grow(fifo, sizeof(FrameHDR10Plus)); Prefer sizeof(var) for these to match the rest of the code. _

Re: [FFmpeg-devel] [PATCH] avcodec: Pass the HDR10+ metadata to the packet side data in VP9 encoder

2021-06-02 Thread James Zern
On Tue, Jun 1, 2021 at 6:23 PM Mohammad Izadi wrote: > > On Fri, May 28, 2021 at 4:49 AM Michael Niedermayer > wrote: > > > On Thu, May 27, 2021 at 09:44:10AM -0700, Mohammad Izadi wrote: > > > HDR10+ metadata is stored in the bit stream for HEVC. The story is > > different for VP9 and cannot sto

Re: [FFmpeg-devel] [PATCH] avcodec: Pass the HDR10+ metadata to the packet side data in VP9 encoder

2021-06-04 Thread James Zern
Hi, On Wed, Jun 2, 2021 at 1:55 PM Valerii Zapodovnikov wrote: > > HDR10+ test bitstream https://www.webmproject.org/vp9/levels/ > > BTW, who knows what is Profile 4 VP9 (i.e. VP9.4)? > https://stackoverflow.com/questions/61413665 > This link is talking about a file with DRM. VP9 allows for 4 p

Re: [FFmpeg-devel] [PATCH v3] lavc/aomdec: Allow RGB decoding

2021-06-08 Thread James Zern
On Sat, Jun 5, 2021 at 10:16 PM Valerii Zapodovnikov wrote: > > Yes, RGB is signalled by Identity matrix if and only if XYZ is not > in transfer. XYZ primaries are just normal primaries that can be > used for normal RGB, no problem, so I do not check for them. > No need to test for sRGB primaries

Re: [FFmpeg-devel] [PATCH 1/2] lavc/libaomenc: Show encoder config as a warning in case of failed initialization

2021-06-14 Thread James Zern
On Sat, Jun 12, 2021 at 12:10 PM Thilo Borgmann wrote: > > Hi, > > if init fails, it's likely originating from the library's config. This and > 2/2 are for easier debugging in that case instead of having to run again with > loglevel DEBUG. > > --- > libavcodec/libaomenc.c | 10 ++ > 1

Re: [FFmpeg-devel] [PATCH 2/2] lavc/libvpxenc: Show encoder config as a warning in case

2021-06-14 Thread James Zern
On Sat, Jun 12, 2021 at 12:12 PM Thilo Borgmann wrote: > > $subject > > --- > libavcodec/libvpxenc.c | 10 ++ > 1 file changed, 6 insertions(+), 4 deletions(-) lgtm. Same comment for the else as for libaomenc.c ___ ffmpeg-devel mailing list ff

Re: [FFmpeg-devel] [PATCH] avcodec: Pass the HDR10+ metadata to the packet side data in VP9 encoder

2021-06-17 Thread James Zern
On Wed, Jun 16, 2021 at 3:53 PM Mohammad Izadi wrote: > > HDR10+ metadata is stored in the bit stream for HEVC. The story is different > for VP9 and cannot store the metadata in the bit stream. HDR10+ should be > passed to packet side data an stored in the container (mkv) for VP9. > > This CL is

Re: [FFmpeg-devel] [PATCH] lavf/webmdashenc.c: Allow AV1 video in WebM

2021-06-17 Thread James Zern
Hi, On Sun, Jun 13, 2021 at 12:46 PM Thilo Borgmann wrote: > > Hi, > > not sure about the spec backing this up, however the following site lists AV1 > support in WebM: > https://developer.mozilla.org/en-US/docs/Web/Media/Formats/Video_codecs > This should probably get a version bump. I think th

Re: [FFmpeg-devel] [PATCH] avcodec: Pass the HDR10+ metadata to the packet side data in VP9 encoder

2021-06-22 Thread James Zern
On Thu, Jun 17, 2021 at 10:21 PM Mohammad Izadi wrote: > > HDR10+ metadata is stored in the bit stream for HEVC. The story is different > for VP9 and cannot store the metadata in the bit stream. HDR10+ should be > passed to packet side data an stored in the container (mkv) for VP9. > > This CL i

Re: [FFmpeg-devel] [PATCH] avcodec: Pass the HDR10+ metadata to the packet side data in VP9 encoder

2021-06-24 Thread James Zern
On Tue, Jun 22, 2021 at 1:46 PM James Zern wrote: > > On Thu, Jun 17, 2021 at 10:21 PM Mohammad Izadi > wrote: > > > > HDR10+ metadata is stored in the bit stream for HEVC. The story is > > different for VP9 and cannot store the metadata in the bit stream. HDR10+ >

Re: [FFmpeg-devel] [PATCH] avcodec/libvpxenc: add VP8/9 sharpness config option

2018-12-19 Thread James Zern
On Wed, Dec 19, 2018 at 10:24 AM Rene Claus wrote: > > This commit adds configuration options to libvpxenc.c that can be used to > tune the sharpness parameter of the loop filter for VP8 and VP9. > > Signed-off-by: Rene Claus > --- > doc/encoders.texi | 4 > libavcodec/libvpxenc.c | 5

Re: [FFmpeg-devel] [PATCH] avcodec/libvpxenc: add VP8/9 sharpness config option

2018-12-19 Thread James Zern
On Wed, Dec 19, 2018 at 2:03 PM James Almer wrote: > > On 12/19/2018 6:52 PM, Rene Claus wrote: > > This commit adds configuration options to libvpxenc.c that can be used to > > tune the sharpness parameter for VP8 and VP9. > > > > Signed-off-by: Rene Claus > > --- > > doc/encoders.texi | 4

Re: [FFmpeg-devel] [PATCH] avcodec/libvpxenc: add VP8/9 sharpness config option

2018-12-21 Thread James Zern
On Thu, Dec 20, 2018 at 7:51 PM Rene Claus wrote: > > This commit adds configuration options to libvpxenc.c that can be used to > tune the sharpness parameter for VP8 and VP9. > > Signed-off-by: Rene Claus > --- > doc/encoders.texi | 4 > libavcodec/libvpxenc.c | 6 ++ > 2 files ch

Re: [FFmpeg-devel] [PATCH] avcodec/libvpxenc: add VP8/9 sharpness config option

2018-12-21 Thread James Zern
On Fri, Dec 21, 2018 at 1:36 PM Rene Claus wrote: > > This commit adds configuration options to libvpxenc.c that can be used to > tune the sharpness parameter for VP8 and VP9. > > Signed-off-by: Rene Claus > --- > doc/encoders.texi | 4 > libavcodec/libvpxenc.c | 6 ++ > 2 files ch

Re: [FFmpeg-devel] [PATCH] avcodec/libvpxenc: add VP8/9 sharpness config option

2018-12-21 Thread James Zern
On Fri, Dec 21, 2018 at 11:24 AM James Almer wrote: > > On 12/21/2018 1:09 PM, James Zern wrote: > > On Thu, Dec 20, 2018 at 7:51 PM Rene Claus > > wrote: > >> > >> This commit adds configuration options to libvpxenc.c that can be used to > >>

Re: [FFmpeg-devel] [PATCH] avcodec/libvpxenc: add VP8/9 sharpness config option

2018-12-24 Thread James Zern
On Fri, Dec 21, 2018 at 7:38 PM James Zern wrote: > > On Fri, Dec 21, 2018 at 1:36 PM Rene Claus > wrote: > > > > This commit adds configuration options to libvpxenc.c that can be used to > > tune the sharpness parameter for VP8 and VP9. > > > > Sign

Re: [FFmpeg-devel] lavc/libvpxenc: Deprecate lossless option

2019-02-11 Thread James Zern
On Sat, Feb 9, 2019 at 3:15 AM Carl Eugen Hoyos wrote: > > 2019-02-09 7:49 GMT+01:00, Gyan : > > > > > > On 09-02-2019 02:26 AM, Carl Eugen Hoyos wrote: > >> 2019-02-08 6:08 GMT+01:00, Gyan : > >>> > >>> On 08-02-2019 03:31 AM, Carl Eugen Hoyos wrote: > . > No strong opinion here, I hadn

Re: [FFmpeg-devel] [PATCH] avcodec/libvpxenc: add VP8 support for ROI-based encoding

2019-02-28 Thread James Zern
> > > > > +if (avctx->codec_id == AV_CODEC_ID_VP8) > > > +vp8_encode_set_roi(avctx, frame); > > > > The API only exists for VP8, or is this due to different quant scales or > > something? > > currently, VP9 ROI does not work, see my discussion at > https://groups.google.com/a/w

Re: [FFmpeg-devel] [PATCH] avcodec/libvpxenc: add VP8 support for ROI-based encoding

2019-03-01 Thread James Zern
On Fri, Mar 1, 2019 at 4:51 AM Derek Buitenhuis wrote: > > On 01/03/2019 03:18, Guo, Yejun wrote: > > yes, that's the reason I pending VP9 work. As for VP8 ROI, another thinking > > is to first push vp8 roi, since libvpx is an external dependency and we > > don't > > know the time when it is avai

Re: [FFmpeg-devel] [PATCH 2/2] configure: use vpx_codec_vp8_dx/cx for libvpx-vp8 checking

2019-03-06 Thread James Zern
On Mon, Mar 4, 2019 at 6:19 AM Guo, Yejun wrote: > > Signed-off-by: Guo, Yejun > --- > configure | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > lgtm. This is a remnant from when vp8 was the only codec in the library. ___ ffmpeg-devel ma

Re: [FFmpeg-devel] [PATCH V3] avcodec/libvpxenc: add VP8 support for ROI-based encoding

2019-03-07 Thread James Zern
On Thu, Feb 28, 2019 at 11:23 PM Guo, Yejun wrote: > > Signed-off-by: Guo, Yejun > --- > libavcodec/libvpxenc.c | 150 > + > 1 file changed, 150 insertions(+) > > diff --git a/libavcodec/libvpxenc.c b/libavcodec/libvpxenc.c > index c823b8a..fc9b1f

Re: [FFmpeg-devel] [PATCH V4] avcodec/libvpxenc: add VP8 support for ROI-based encoding

2019-03-12 Thread James Zern
On Fri, Mar 8, 2019 at 5:07 AM Guo, Yejun wrote: > > Signed-off-by: Guo, Yejun > --- > libavcodec/libvpxenc.c | 150 > + > 1 file changed, 150 insertions(+) > > [...] > +active_map.active_map = av_malloc(active_map.rows * active_map.cols); > +

Re: [FFmpeg-devel] [PATCH] webm_dash_manifest: Add option to specify bandwidth

2017-04-13 Thread James Zern
On Tue, Apr 11, 2017 at 9:33 PM, Vignesh Venkatasubramanian wrote: > Add an option to webm_dash_manifest demuxer to specify a value for > "bandwidth" field in the DASH manifest. The value is then used by > the muxer. Fixes an existing FIXME in the code. > > Signed-off-by: Vignesh Venkatasubramania

[FFmpeg-devel] [PATCH] libvpxenc: allow aq-mode 4 (equator360)

2017-04-13 Thread James Zern
this was added in 1.6.0 Signed-off-by: James Zern --- doc/encoders.texi | 2 +- libavcodec/libvpxenc.c | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/doc/encoders.texi b/doc/encoders.texi index 594c612b5a..f8f187664c 100644 --- a/doc/encoders.texi +++ b/doc

[FFmpeg-devel] [PATCH] doc/encoders.texi: document libvpxenc's -row-mt

2017-04-13 Thread James Zern
added in: 734d760e2f lavc/libvpxenc: add -row-mt option Signed-off-by: James Zern --- doc/encoders.texi | 2 ++ 1 file changed, 2 insertions(+) diff --git a/doc/encoders.texi b/doc/encoders.texi index 594c612b5a..7f4754d160 100644 --- a/doc/encoders.texi +++ b/doc/encoders.texi @@ -1679,6

Re: [FFmpeg-devel] [PATCH] webm_dash_manifest: Add option to specify bandwidth

2017-04-17 Thread James Zern
On Thu, Apr 13, 2017 at 6:20 PM, James Zern wrote: > On Tue, Apr 11, 2017 at 9:33 PM, Vignesh Venkatasubramanian > wrote: >> Add an option to webm_dash_manifest demuxer to specify a value for >> "bandwidth" field in the DASH manifest. The value is then used by >

Re: [FFmpeg-devel] [PATCH] doc/encoders.texi: document libvpxenc's -row-mt

2017-04-17 Thread James Zern
On Mon, Apr 17, 2017 at 5:06 PM, Michael Niedermayer wrote: > On Thu, Apr 13, 2017 at 06:53:26PM -0700, James Zern wrote: >> added in: >> 734d760e2f lavc/libvpxenc: add -row-mt option >> >> Signed-off-by: James Zern >> --- >> doc/encoders.texi | 2 ++ >&

Re: [FFmpeg-devel] [PATCH] libvpxenc: allow aq-mode 4 (equator360)

2017-04-20 Thread James Zern
On Thu, Apr 13, 2017 at 6:44 PM, James Zern wrote: > this was added in 1.6.0 > > Signed-off-by: James Zern > --- > doc/encoders.texi | 2 +- > libavcodec/libvpxenc.c | 3 ++- > 2 files changed, 3 insertions(+), 2 deletions(-) > I'll submit this soon

Re: [FFmpeg-devel] [PATCH] libvpxenc: allow aq-mode 4 (equator360)

2017-04-20 Thread James Zern
On Thu, Apr 20, 2017 at 1:42 PM, Ronald S. Bultje wrote: > Hi, > > On Thu, Apr 20, 2017 at 2:42 PM, James Zern > wrote: > >> On Thu, Apr 13, 2017 at 6:44 PM, James Zern wrote: >> > this was added in 1.6.0 >> > >> > Signed-off-by: James

Re: [FFmpeg-devel] [PATCH] libvpxenc: allow aq-mode 4 (equator360)

2017-04-28 Thread James Zern
On Thu, Apr 20, 2017 at 3:06 PM, James Zern wrote: > On Thu, Apr 20, 2017 at 1:42 PM, Ronald S. Bultje wrote: >> Hi, >> >> On Thu, Apr 20, 2017 at 2:42 PM, James Zern >> wrote: >> >>> On Thu, Apr 13, 2017 at 6:44 PM, James Zern wrote: >>>

Re: [FFmpeg-devel] [PATCH 1/2] avformat/matroskaenc: also write chapters when output is WebM

2017-06-01 Thread James Zern
On Thu, Jun 1, 2017 at 7:51 PM, James Almer wrote: > WebM supports a subset of elements from the Chapters master. > See https://www.webmproject.org/docs/container/#chapters > > Addresses ticket #6425 > > Signed-off-by: James Almer > --- > libavformat/matroskaenc.c | 29 --

[FFmpeg-devel] [PATCH] lavc/libvpxenc: add tune-content option

2017-11-13 Thread James Zern
Signed-off-by: James Zern --- doc/encoders.texi | 2 ++ libavcodec/libvpxenc.c | 20 2 files changed, 22 insertions(+) diff --git a/doc/encoders.texi b/doc/encoders.texi index 431777c457..23451b7b92 100644 --- a/doc/encoders.texi +++ b/doc/encoders.texi @@ -1681,6

Re: [FFmpeg-devel] [PATCH] lavc/libvpxenc: add tune-content option

2017-11-13 Thread James Zern
On Mon, Nov 13, 2017 at 4:43 PM, James Almer wrote: > On 11/13/2017 9:01 PM, James Zern wrote: >> Signed-off-by: James Zern >> --- >> doc/encoders.texi | 2 ++ >> libavcodec/libvpxenc.c | 20 >> 2 files changed, 22 insertions(+) >&

Re: [FFmpeg-devel] [PATCH] lavc/libvpxenc: add tune-content option

2017-11-14 Thread James Zern
On Mon, Nov 13, 2017 at 6:05 PM, James Zern wrote: > On Mon, Nov 13, 2017 at 4:43 PM, James Almer wrote: >> On 11/13/2017 9:01 PM, James Zern wrote: >>> Signed-off-by: James Zern >>> --- >>> doc/encoders.texi | 2 ++ >>> libavcodec/libvp

Re: [FFmpeg-devel] [PATCH] lavc/libvpxenc: add tune-content option

2017-11-16 Thread James Zern
On Nov 14, 2017 18:53, "James Zern" wrote: On Mon, Nov 13, 2017 at 6:05 PM, James Zern wrote: > On Mon, Nov 13, 2017 at 4:43 PM, James Almer wrote: >> On 11/13/2017 9:01 PM, James Zern wrote: >>> Signed-off-by: James Zern >>> --- >>> doc/encoders

Re: [FFmpeg-devel] [PATCH] lavc/libvpxenc: add tune-content option

2017-11-17 Thread James Zern
On Mon, Nov 13, 2017 at 4:01 PM, James Zern wrote: > Signed-off-by: James Zern > --- > doc/encoders.texi | 2 ++ > libavcodec/libvpxenc.c | 20 > 2 files changed, 22 insertions(+) > Applied with an additional note in the commit message about the

[FFmpeg-devel] [PATCH 2/4] libvpx: remove pre-1.4.0 checks

2017-11-17 Thread James Zern
Signed-off-by: James Zern --- libavcodec/libvpx.c | 12 +--- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/libavcodec/libvpx.c b/libavcodec/libvpx.c index 1eca97a081..36f915a8e5 100644 --- a/libavcodec/libvpx.c +++ b/libavcodec/libvpx.c @@ -40,9 +40,7 @@ static const enum

[FFmpeg-devel] [PATCH 4/4] libvpxenc: remove pre-1.4.0 checks

2017-11-17 Thread James Zern
Signed-off-by: James Zern --- libavcodec/libvpxenc.c | 25 +++-- 1 file changed, 3 insertions(+), 22 deletions(-) diff --git a/libavcodec/libvpxenc.c b/libavcodec/libvpxenc.c index fbb842499b..0258396d08 100644 --- a/libavcodec/libvpxenc.c +++ b/libavcodec/libvpxenc.c

[FFmpeg-devel] [PATCH 3/4] libvpxdec: remove pre-1.4.0 checks

2017-11-17 Thread James Zern
Signed-off-by: James Zern --- libavcodec/libvpxdec.c | 25 - 1 file changed, 25 deletions(-) diff --git a/libavcodec/libvpxdec.c b/libavcodec/libvpxdec.c index ad0ea3b02a..2ae29d202a 100644 --- a/libavcodec/libvpxdec.c +++ b/libavcodec/libvpxdec.c @@ -70,7 +70,6

[FFmpeg-devel] [PATCH 1/4] configure: require libvpx-1.4.0 for vp[89] support

2017-11-17 Thread James Zern
this will simplify libvpxenc/dec.c and ensure more stable versions of the codecs are present. Signed-off-by: James Zern --- configure | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/configure b/configure index c8e2e35192..bfb1d9ab3a 100755 --- a

Re: [FFmpeg-devel] [PATCH 1/4] configure: require libvpx-1.4.0 for vp[89] support

2017-11-20 Thread James Zern
On Sun, Nov 19, 2017 at 6:03 AM, James Almer wrote: > On 11/17/2017 10:50 PM, James Zern wrote: >> this will simplify libvpxenc/dec.c and ensure more stable versions of >> the codecs are present. >> >> Signed-off-by: James Zern >> --- >> configure | 20

Re: [FFmpeg-devel] [PATCH 2/4] libvpx: remove pre-1.4.0 checks

2017-11-20 Thread James Zern
On Sun, Nov 19, 2017 at 5:57 AM, James Almer wrote: > On 11/17/2017 10:50 PM, James Zern wrote: >> Signed-off-by: James Zern >> --- >> libavcodec/libvpx.c | 12 +--- >> 1 file changed, 1 insertion(+), 11 deletions(-) >> >> diff --git a/libavcodec/

Re: [FFmpeg-devel] [PATCH 1/4] configure: require libvpx-1.4.0 for vp[89] support

2017-11-20 Thread James Zern
On Mon, Nov 20, 2017 at 11:17 AM, James Zern wrote: > On Sun, Nov 19, 2017 at 6:03 AM, James Almer wrote: >> On 11/17/2017 10:50 PM, James Zern wrote: >>> this will simplify libvpxenc/dec.c and ensure more stable versions of >>> the codecs are present. >&g

Re: [FFmpeg-devel] [PATCH 1/4] configure: require libvpx-1.4.0 for vp[89] support

2017-11-20 Thread James Zern
On Mon, Nov 20, 2017 at 11:51 AM, James Almer wrote: > On 11/20/2017 4:38 PM, James Zern wrote: >> On Mon, Nov 20, 2017 at 11:17 AM, James Zern wrote: >>> On Sun, Nov 19, 2017 at 6:03 AM, James Almer wrote: >>>> On 11/17/2017 10:50 PM, James Zern wrote: >>&g

Re: [FFmpeg-devel] [PATCH 2/4] libvpx: remove pre-1.4.0 checks

2017-11-20 Thread James Zern
On Fri, Nov 17, 2017 at 5:50 PM, James Zern wrote: > Signed-off-by: James Zern > --- > libavcodec/libvpx.c | 12 +--- > 1 file changed, 1 insertion(+), 11 deletions(-) > applied. ___ ffmpeg-devel mailing list ffmpeg-devel@

Re: [FFmpeg-devel] [PATCH 4/4] libvpxenc: remove pre-1.4.0 checks

2017-11-20 Thread James Zern
On Fri, Nov 17, 2017 at 5:50 PM, James Zern wrote: > Signed-off-by: James Zern > --- > libavcodec/libvpxenc.c | 25 +++-- > 1 file changed, 3 insertions(+), 22 deletions(-) > applied. ___ ffmpeg-devel mailing li

Re: [FFmpeg-devel] [PATCH 3/4] libvpxdec: remove pre-1.4.0 checks

2017-11-20 Thread James Zern
On Fri, Nov 17, 2017 at 5:50 PM, James Zern wrote: > Signed-off-by: James Zern > --- > libavcodec/libvpxdec.c | 25 - > 1 file changed, 25 deletions(-) > applied. ___ ffmpeg-devel mailing list ffmpeg-devel@

[FFmpeg-devel] [PATCH] libvpxenc, vp9: add corpus-complexity option

2017-11-20 Thread James Zern
Corpus VBR mode is a variant of standard VBR where the complexity distribution midpoint is passed in rather than calculated for a specific clip or chunk. The valid range is [0, 1]. 0 (default) uses standard VBR. Signed-off-by: James Zern --- doc/encoders.texi | 5 + libavcodec

Re: [FFmpeg-devel] [PATCH] libvpxenc, vp9: add corpus-complexity option

2017-11-27 Thread James Zern
On Mon, Nov 20, 2017 at 5:36 PM, James Zern wrote: > Corpus VBR mode is a variant of standard VBR where the complexity > distribution midpoint is passed in rather than calculated for a specific > clip or chunk. > > The valid range is [0, 1]. 0 (default) uses standard VBR. &g

Re: [FFmpeg-devel] [PATCH] libvpxenc, vp9: add corpus-complexity option

2017-11-28 Thread James Zern
On Mon, Nov 27, 2017 at 10:55 AM, James Zern wrote: > On Mon, Nov 20, 2017 at 5:36 PM, James Zern wrote: >> Corpus VBR mode is a variant of standard VBR where the complexity >> distribution midpoint is passed in rather than calculated for a specific >> clip or chunk. >&g

Re: [FFmpeg-devel] [PATCH] avcodec/vp9: mark frame as finished on decode_tiles() failure

2017-12-13 Thread James Zern
b6-.ivf > Fixes: ducks_take_off_444_720p50.y4m.vp9.webm.ivf.s107375_r01-05_b6-.ivf > > Reported-by: James Zern > Signed-off-by: Michael Niedermayer > --- > libavcodec/vp9.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > lgtm. t

Re: [FFmpeg-devel] [PATCH 2/4] lavc: add vp8/vp9 mediacodec decoders

2016-10-12 Thread James Zern
On Wed, Oct 12, 2016 at 6:22 AM, Matthieu Bouron wrote: > From: Matthieu Bouron > > --- > configure| 4 +++ > libavcodec/Makefile | 2 ++ > libavcodec/allcodecs.c | 4 +++ > libavcodec/mediacodecdec.c | 14 > libavcodec/mediacodec

[FFmpeg-devel] [PATCH] ffmpeg_cleanup: fix crash with unrecognized codec

2016-10-14 Thread James Zern
since: 3e5e5bd Merge commit '398f015f077c6a2406deffd9e37ff34b9c7bb3bc' Signed-off-by: James Zern --- ffmpeg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ffmpeg.c b/ffmpeg.c index 693981f..af8ed76 100644 --- a/ffmpeg.c +++ b/ffmpeg.c @@ -533,7 +533,7 @@ s

Re: [FFmpeg-devel] [PATCH] vp9: change order of operations in adapt_prob().

2016-10-14 Thread James Zern
Ronald, On Fri, Oct 14, 2016 at 10:01 AM, Ronald S. Bultje wrote: > This is intended to workaround bug "665 Integer Divide Instruction May > Cause Unpredictable Behavior" on some early AMD CPUs, which causes a > div-by-zero in this codepath, such as reported in Mozilla bug #1293996. > > Note that

Re: [FFmpeg-devel] [PATCH] vp9: change order of operations in adapt_prob().

2016-10-14 Thread James Zern
On Fri, Oct 14, 2016 at 11:31 AM, Michael Niedermayer wrote: > On Fri, Oct 14, 2016 at 08:29:37PM +0200, Michael Niedermayer wrote: >> On Fri, Oct 14, 2016 at 11:09:30AM -0700, James Zern wrote: >> > Ronald, >> > >> > On Fri, Oct 14, 2016 at 10:01 AM, Ronald S.

Re: [FFmpeg-devel] [PATCH] vp9: change order of operations in adapt_prob().

2016-10-14 Thread James Zern
On Fri, Oct 14, 2016 at 11:54 AM, Ronald S. Bultje wrote: > Hi Michael, > > On Fri, Oct 14, 2016 at 2:31 PM, Michael Niedermayer > wrote: > >> On Fri, Oct 14, 2016 at 08:29:37PM +0200, Michael Niedermayer wrote: >> > On Fri, Oct 14, 2016 at 11:09:30AM -0700, J

Re: [FFmpeg-devel] [PATCH] lavc/libvpxenc: fix -auto-alt-ref option type

2016-10-20 Thread James Zern
On Thu, Oct 20, 2016 at 8:31 AM, Kagami Hiiragi wrote: > vp9_cx_iface actually allows values in range [0..2]. > This fixes ticket #5894. > > Signed-off-by: Kagami Hiiragi > --- > libavcodec/libvpxenc.c | 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) > This is all right in the sens

Re: [FFmpeg-devel] [PATCH] lavc/libvpxenc: fix -auto-alt-ref option type

2016-10-20 Thread James Zern
On Thu, Oct 20, 2016 at 11:51 AM, Rostislav Pehlivanov wrote: > On 20 October 2016 at 16:31, Kagami Hiiragi wrote: > >> vp9_cx_iface actually allows values in range [0..2]. >> This fixes ticket #5894. >> >> Signed-off-by: Kagami Hiiragi >> --- >> libavcodec/libvpxenc.c | 7 ++- >> 1 file ch

Re: [FFmpeg-devel] [PATCH] lavc/libvpxenc: fix -auto-alt-ref option type

2016-10-21 Thread James Zern
On Fri, Oct 21, 2016 at 1:14 AM, Kagami Hiiragi wrote: > On 21/10/16 06:14, James Zern wrote: >> On Thu, Oct 20, 2016 at 8:31 AM, Kagami Hiiragi wrote: >>> vp9_cx_iface actually allows values in range [0..2]. >>> This fixes ticket #5894. >>&g

Re: [FFmpeg-devel] [PATCH] lavc/libvpxenc: fix -auto-alt-ref option type

2016-10-21 Thread James Zern
On Fri, Oct 21, 2016 at 1:22 AM, James Zern wrote: > On Fri, Oct 21, 2016 at 1:14 AM, Kagami Hiiragi wrote: >> On 21/10/16 06:14, James Zern wrote: >>> On Thu, Oct 20, 2016 at 8:31 AM, Kagami Hiiragi >>> wrote: >>>> vp9_cx_iface actually allows values

Re: [FFmpeg-devel] [PATCH] lavc/libvpxenc: fix -auto-alt-ref option type

2016-10-21 Thread James Zern
On Fri, Oct 21, 2016 at 4:55 AM, Ronald S. Bultje wrote: > Hi, > > On Thu, Oct 20, 2016 at 11:14 PM, James Zern > wrote: > >> On Thu, Oct 20, 2016 at 8:31 AM, Kagami Hiiragi >> wrote: >> > vp9_cx_iface actually allows values in range [0..2]. >> > Thi

[FFmpeg-devel] [PATCH] lavc/libvpxenc: fix -auto-alt-ref option type

2016-10-21 Thread James Zern
From: Kagami Hiiragi vp9_cx_iface actually allows values in range [0..2]. This fixes ticket #5894. Signed-off-by: Kagami Hiiragi --- libavcodec/libvpxenc.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libavcodec/libvpxenc.c b/libavcodec/libvpxenc.c index 2db87f7..68

Re: [FFmpeg-devel] [PATCH] lavc/libvpxenc: fix -auto-alt-ref option type

2016-10-21 Thread James Zern
On Fri, Oct 21, 2016 at 3:10 PM, Kagami Hiiragi wrote: > On 22/10/16 01:06, James Zern wrote: >> From: Kagami Hiiragi >> >> vp9_cx_iface actually allows values in range [0..2]. >> This fixes ticket #5894. >> >> Signed-off-by: Kagami Hiiragi >> --- &g

Re: [FFmpeg-devel] [PATCH] avformat/matroskadec: fix DiscardPadding element parsing

2016-11-07 Thread James Zern
On Sat, Nov 5, 2016 at 1:50 PM, James Almer wrote: > If the value is negative then it means padding at the start of the packet > instead of at the end. > > Based on a patch by Hendrik Leppkes. > > Signed-off-by: James Almer > --- > libavformat/matroskadec.c | 12 +--- > 1 file changed, 9

Re: [FFmpeg-devel] [PATCH 1/2] libvpxenc: Support targeting a VP9 level

2016-11-18 Thread James Zern
On Fri, Nov 18, 2016 at 2:01 PM, Alex Converse wrote: > Levels are specified at https://www.webmproject.org/vp9/levels/ > --- > libavcodec/libvpxenc.c | 10 ++ > 1 file changed, 10 insertions(+) > lgtm > diff --git a/libavcodec/libvpxenc.c b/libavcodec/libvpxenc.c > index 68f25a4..51f42

Re: [FFmpeg-devel] [PATCH 2/2] libvpxenc: Report encoded VP9 level

2016-11-22 Thread James Zern
On Fri, Nov 18, 2016 at 2:01 PM, Alex Converse wrote: > Report the actual level of the encoded output if a level is > targeted or the level is passively tracked with a target of 0. > --- > libavcodec/libvpxenc.c | 31 +++ > 1 file changed, 31 insertions(+) > lgtm. I d

Re: [FFmpeg-devel] [PATCH 2/2] libvpxenc: Report encoded VP9 level

2016-11-22 Thread James Zern
On Tue, Nov 22, 2016 at 12:04 PM, James Zern wrote: > On Fri, Nov 18, 2016 at 2:01 PM, Alex Converse > wrote: >> Report the actual level of the encoded output if a level is >> targeted or the level is passively tracked with a target of 0. >> --- >>

Re: [FFmpeg-devel] [PATCH 2/2] libvpxenc: Report encoded VP9 level

2016-11-22 Thread James Zern
On Tue, Nov 22, 2016 at 12:08 PM, James Zern wrote: > On Tue, Nov 22, 2016 at 12:04 PM, James Zern wrote: >> On Fri, Nov 18, 2016 at 2:01 PM, Alex Converse >> wrote: >>> Report the actual level of the encoded output if a level is >>> targeted or the level is p

Re: [FFmpeg-devel] [PATCH 2/2] libvpxenc: Report encoded VP9 level

2016-11-28 Thread James Zern
On Mon, Nov 28, 2016 at 10:32 AM, Alex Converse wrote: > On Tue, Nov 22, 2016 at 3:10 PM, James Zern wrote: >> On Tue, Nov 22, 2016 at 12:08 PM, James Zern wrote: >>> On Tue, Nov 22, 2016 at 12:04 PM, James Zern wrote: >>>> On Fri, Nov 18, 2016 at 2:01

Re: [FFmpeg-devel] [PATCH] libvpxenc: Report encoded VP9 level

2016-11-28 Thread James Zern
On Mon, Nov 28, 2016 at 10:34 AM, Alex Converse wrote: > Report the actual level of the encoded output if a level is > targeted or the level is passively tracked with a target of 0. > --- > libavcodec/libvpxenc.c | 32 > 1 file changed, 32 insertions(+) > lgtm __

Re: [FFmpeg-devel] [PATCH] libvpxenc: Don't spam level errors for VP8 encodes

2016-12-12 Thread James Zern
On Mon, Dec 12, 2016 at 12:12 PM, Alex Converse wrote: > Fixes "Failed to set VP9E_GET_LEVEL codec control: Codec does not > implement requested capability" log messages on VP8 encodes. > --- > libavcodec/libvpxenc.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > lgtm __

Re: [FFmpeg-devel] [PATCH] libvpx: Enable vp9 alpha encoding

2016-07-12 Thread James Zern
On Tue, Jul 12, 2016 at 11:49 AM, Vignesh Venkatasubramanian wrote: >>> > Alright, i have a working patch for the decoder locally (i will push >>> > that to the ML shortly). >>> >>> Here it is: http://ffmpeg.org/pipermail/ffmpeg-devel/2016-July/196403.html >> >> >> Thanks, that resolves my concern

Re: [FFmpeg-devel] [PATCH] libvpx: Enable vp9 alpha encoding

2016-07-12 Thread James Zern
On Thu, Jun 30, 2016 at 4:16 PM, Vignesh Venkatasubramanian wrote: > Chrome canary now supports decoding of VP9 streams with alpha > channel [1]. Add support to ffmpeg for creating such files. > > [1] https://codereview.chromium.org/2096813002/ > > Signed-off-by: Vignesh Venkatasubramanian > ---

Re: [FFmpeg-devel] [PATCH] libavcodec/libvpx: Add VPx alpha decode support

2016-07-14 Thread James Zern
On Tue, Jul 12, 2016 at 11:48 AM, Vignesh Venkatasubramanian wrote: > On Mon, Jul 11, 2016 at 5:55 PM, James Zern > wrote: >> On Thu, Jul 7, 2016 at 11:43 AM, Vignesh Venkatasubramanian >> wrote: >> >>> [...] >>> -av_image_copy(pictur

Re: [FFmpeg-devel] [PATCH] libavcodec/libvpx: Add VPx alpha decode support

2016-07-14 Thread James Zern
On Thu, Jul 14, 2016 at 12:15 PM, Vignesh Venkatasubramanian wrote: > +ret = vpx_init( > +avctx, > +(avctx->codec_id == AV_CODEC_ID_VP8) ? > +&vpx_codec_vp8_dx_algo : &vpx_codec_vp9_dx_algo, > +1);

<    1   2   3   4   5   >