On Thu, Apr 13, 2017 at 6:20 PM, James Zern <jz...@google.com> wrote: > On Tue, Apr 11, 2017 at 9:33 PM, Vignesh Venkatasubramanian > <vigneshv-at-google....@ffmpeg.org> wrote: >> Add an option to webm_dash_manifest demuxer to specify a value for >> "bandwidth" field in the DASH manifest. The value is then used by >> the muxer. Fixes an existing FIXME in the code. >> >> Signed-off-by: Vignesh Venkatasubramanian <vigne...@google.com> >> --- >> libavformat/matroskadec.c | 19 ++++++++++++++++++- >> libavformat/webmdashenc.c | 11 ++++++++--- >> tests/fate/vpx.mak | 3 +++ >> tests/ref/fate/webm-dash-manifest-live-bandwidth | 24 >> ++++++++++++++++++++++++ >> 4 files changed, 53 insertions(+), 4 deletions(-) >> create mode 100644 tests/ref/fate/webm-dash-manifest-live-bandwidth >> > > lgtm. I'll submit this soon if there aren't any comments. > >> [...] >> - // FIXME: For live, This should be obtained from the input file or as >> an AVOption. >> - avio_printf(s->pb, " bandwidth=\"%s\"", >> - w->is_live ? (stream->codecpar->codec_type == >> AVMEDIA_TYPE_AUDIO ? "128000" : "1000000") : bandwidth->value); >> + // if bandwidth for live was not provied, use a default > > provided. fixed locally.
applied. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
