Re: [FFmpeg-devel] [PATCH 01/10 v4] avutil/stereo3d: add a Monoscopic view enum value

2024-06-24 Thread James Almer
On 6/22/2024 8:15 PM, James Almer wrote: We need a way to signal the frame has a single view that doesn't map to any particular eye, and it should be the default one. Signed-off-by: James Almer --- libavutil/stereo3d.c | 1 + libavutil/stereo3d.h | 5 + 2 files changed, 6 inser

Re: [FFmpeg-devel] [PATCH 1/2 v2] fftools/ffmpeg: support applying container level cropping

2024-06-25 Thread James Almer
On 6/25/2024 7:25 AM, Anton Khirnov wrote: Quoting James Almer (2024-05-31 01:22:51) @@ -1000,11 +1001,21 @@ int ist_filter_add(InputStream *ist, InputFilter *ifilter, int is_simple, ist->filters[ist->nb_filters - 1] = ifilter; if (ist->par->codec_type == AVMEDI

Re: [FFmpeg-devel] [PATCH 18/18] avcodec/vvcdec: alf, support virtual boundaries

2024-06-25 Thread James Almer
On 6/25/2024 8:53 AM, Nuo Mi wrote: On Sat, Jun 22, 2024 at 2:24 PM Nuo Mi wrote: see https://ieeexplore.ieee.org/stamp/stamp.jsp?tp=&arnumber=9503377 passed files: GDR_A_ERICSSON_2.bit GDR_B_NOKIA_2.bit GDR_C_NOKIA_2.bit VIRTUAL_A_MediaTek_3.bit VIRTUAL_B_MediaTek_3.

Re: [FFmpeg-devel] [PATCH 1/6] avcodec/packet: add a decoded frame cropping side data type

2024-06-25 Thread James Almer
On 6/25/2024 3:13 PM, Andreas Rheinhardt wrote: James Almer: Signed-off-by: James Almer --- libavcodec/packet.h | 14 ++ 1 file changed, 14 insertions(+) diff --git a/libavcodec/packet.h b/libavcodec/packet.h index a9a41576da..9dee035690 100644 --- a/libavcodec/packet.h +++ b

Re: [FFmpeg-devel] [PATCH 02/10] avutil/stereo3d: add a Stereo3D type to signal that the packing is unspecified

2024-06-25 Thread James Almer
On 6/25/2024 3:30 PM, Vittorio Giovara wrote: On Sun, Jun 23, 2024 at 1:16 AM James Almer wrote: Given that a video stream/frame may have only one or both views coded with the packing information being unavailable, this commit adds a new type value AV_STEREO3D_UNSPEC for this purpose. not

Re: [FFmpeg-devel] [PATCH 02/10] avutil/stereo3d: add a Stereo3D type to signal that the packing is unspecified

2024-06-25 Thread James Almer
On 6/25/2024 4:10 PM, Anton Khirnov wrote: Quoting James Almer (2024-06-23 01:15:12) Given that a video stream/frame may have only one or both views coded with the packing information being unavailable, this commit adds a new type value AV_STEREO3D_UNSPEC for this purpose. The most common case

Re: [FFmpeg-devel] [PATCH 02/10] avutil/stereo3d: add a Stereo3D type to signal that the packing is unspecified

2024-06-25 Thread James Almer
On 6/25/2024 4:39 PM, Anton Khirnov wrote: Quoting James Almer (2024-06-25 21:14:01) On 6/25/2024 4:10 PM, Anton Khirnov wrote: Quoting James Almer (2024-06-23 01:15:12) Given that a video stream/frame may have only one or both views coded with the packing information being unavailable, this

Re: [FFmpeg-devel] [PATCH] add tools/target_swr_fuzzer

2024-06-26 Thread James Almer
On 6/26/2024 8:40 AM, Michael Niedermayer wrote: Signed-off-by: Michael Niedermayer --- Makefile | 2 + tools/Makefile| 3 + tools/target_swr_fuzzer.c | 161 ++ 3 files changed, 166 insertions(+) create mode 100644 tools

[FFmpeg-devel] [PATCH 1/5] avfilter/vf_showinfo: print more Stereo 3D fields

2024-06-26 Thread James Almer
Signed-off-by: James Almer --- libavfilter/vf_showinfo.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/libavfilter/vf_showinfo.c b/libavfilter/vf_showinfo.c index 28d8ea76e9..9790c202f5 100644 --- a/libavfilter/vf_showinfo.c +++ b/libavfilter/vf_showinfo.c @@ -121,6 +121,16

[FFmpeg-devel] [PATCH 2/5] avfilter/vf_showinfo: don't use sizeof(AVStereo3D)

2024-06-26 Thread James Almer
It's not part of the libavutil ABI. Signed-off-by: James Almer --- libavfilter/vf_showinfo.c | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/libavfilter/vf_showinfo.c b/libavfilter/vf_showinfo.c index 9790c202f5..fdcf9210e7 100644 --- a/libavfilter/vf_showi

[FFmpeg-devel] [PATCH 3/5] avfilter/vf_showinfo: use av_spherical_projection_name()

2024-06-26 Thread James Almer
Signed-off-by: James Almer --- libavfilter/vf_showinfo.c | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/libavfilter/vf_showinfo.c b/libavfilter/vf_showinfo.c index fdcf9210e7..98c5632d52 100644 --- a/libavfilter/vf_showinfo.c +++ b/libavfilter/vf_showinfo.c

[FFmpeg-devel] [PATCH 4/5] avfilter/vf_showinfo: only print yaw, pitch, and roll if set

2024-06-26 Thread James Almer
Signed-off-by: James Almer --- libavfilter/vf_showinfo.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavfilter/vf_showinfo.c b/libavfilter/vf_showinfo.c index 98c5632d52..72b91329d2 100644 --- a/libavfilter/vf_showinfo.c +++ b/libavfilter/vf_showinfo.c @@ -80,10 +80,12 @@ static void

[FFmpeg-devel] [PATCH 5/5] avfilter/vf_showinfo: don't use sizeof(AVSphericalMapping)

2024-06-26 Thread James Almer
It's not part of the libavutil ABI. Signed-off-by: James Almer --- libavfilter/vf_showinfo.c | 5 - 1 file changed, 5 deletions(-) diff --git a/libavfilter/vf_showinfo.c b/libavfilter/vf_showinfo.c index 72b91329d2..c21dc0a10b 100644 --- a/libavfilter/vf_showinfo.c +++ b/libavf

[FFmpeg-devel] [PATCH 1/2] avcodec/cbs_sei: add support for Frame Packing Arrangement SEI parsing

2024-06-26 Thread James Almer
Signed-off-by: James Almer --- libavcodec/cbs_h264.h | 20 libavcodec/cbs_h2645.c| 22 + libavcodec/cbs_h264_syntax_template.c | 34 +++ libavcodec/cbs_sei.h | 20

[FFmpeg-devel] [PATCH 2/2] avcodec/cbs_h266: move decoded_picture_hash to CBS SEI

2024-06-26 Thread James Almer
It's defined in H.274 as a common SEI message type and not in H.266 Signed-off-by: James Almer --- libavcodec/cbs_h2645.c| 12 ++-- libavcodec/cbs_h266.h | 10 -- libavcodec/cbs_h266_syntax_template.c | 28 --- libav

[FFmpeg-devel] [PATCH 1/3 v5] avutil/stereo3d: add a Stereo3D type to signal that the packing is unspecified

2024-06-26 Thread James Almer
defined at the bitstream level. Signed-off-by: James Almer --- libavutil/stereo3d.c | 1 + libavutil/stereo3d.h | 5 + 2 files changed, 6 insertions(+) diff --git a/libavutil/stereo3d.c b/libavutil/stereo3d.c index 7ea3dceb33..647f9a952a 100644 --- a/libavutil/stereo3d.c +++ b/libavutil

[FFmpeg-devel] [PATCH 2/3] avutil/stereo3d: add a Stereo3D view to signal that the view is unspecified

2024-06-26 Thread James Almer
Signed-off-by: James Almer --- libavutil/stereo3d.c | 1 + libavutil/stereo3d.h | 5 + 2 files changed, 6 insertions(+) diff --git a/libavutil/stereo3d.c b/libavutil/stereo3d.c index 647f9a952a..d6de476532 100644 --- a/libavutil/stereo3d.c +++ b/libavutil/stereo3d.c @@ -81,6 +81,7 @@ static

[FFmpeg-devel] [PATCH 3/3] avformat/mov: set Stereo3D type when parsing eyes box

2024-06-26 Thread James Almer
If view is defined in the child stri box, then the type must be set to unspecified, as these boxes don't carry packing information. Signed-off-by: James Almer --- libavformat/mov.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/libavformat/mov.c b/libavformat/

Re: [FFmpeg-devel] [PATCH 1/3] avformat/cafdec: sanity check channels and bps

2024-06-26 Thread James Almer
On 3/22/2024 8:08 PM, Michael Niedermayer wrote: Fixes: Timeout Fixes: 67044/clusterfuzz-testcase-minimized-ffmpeg_dem_CAF_fuzzer-5791144363491328 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libav

[FFmpeg-devel] [PATCH 3/3] avformat/mov: set Stereo3D type when parsing eyes box

2024-06-27 Thread James Almer
If view is defined in the child stri box, then the type must be set to unspecified, as these boxes don't carry packing information. Also, don't attach a useless Stereo 3D side data if the stream is monoscopic. Signed-off-by: James Almer --- libavformat/mov.c | 10 +- 1 file

Re: [FFmpeg-devel] [PATCH 1/5] avfilter/vf_showinfo: print more Stereo 3D fields

2024-06-28 Thread James Almer
On 6/26/2024 11:10 AM, James Almer wrote: Signed-off-by: James Almer --- libavfilter/vf_showinfo.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/libavfilter/vf_showinfo.c b/libavfilter/vf_showinfo.c index 28d8ea76e9..9790c202f5 100644 --- a/libavfilter/vf_showinfo.c +++ b

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/cbs_sei: add support for Frame Packing Arrangement SEI parsing

2024-06-28 Thread James Almer
On 6/26/2024 8:12 PM, James Almer wrote: Signed-off-by: James Almer --- libavcodec/cbs_h264.h | 20 libavcodec/cbs_h2645.c| 22 + libavcodec/cbs_h264_syntax_template.c | 34 +++ libavcodec/cbs_sei.h

Re: [FFmpeg-devel] [PATCH 1/3 v5] avutil/stereo3d: add a Stereo3D type to signal that the packing is unspecified

2024-06-28 Thread James Almer
On 6/26/2024 8:30 PM, James Almer wrote: Given that a video stream/frame may have only one view or both views coded with the packing information being unavailable, this commit adds a new type value AV_STEREO3D_UNSPEC for this purpose. The most common case for this is container level signaling of

[FFmpeg-devel] [PATCH 1/2] avformat/mov: check that sample and chunk count is 1 for HEIF

2024-06-28 Thread James Almer
Fixes NULL pointer dereference in broken/fuzzed streams. Signed-off-by: James Almer --- libavformat/mov.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/mov.c b/libavformat/mov.c index 14f43bf906..ba5f85e7e3 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -9904,6

[FFmpeg-devel] [PATCH 2/2] avformat/mov: check that child boxes of trak are only present inside it

2024-06-28 Thread James Almer
Based on the check done for the stco box. Signed-off-by: James Almer --- libavformat/mov.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/libavformat/mov.c b/libavformat/mov.c index ba5f85e7e3..a2e187ff2f 100644 --- a/libavformat/mov.c +++ b/libavformat

Re: [FFmpeg-devel] [PATCH 1/3] avformat/cafdec: sanity check channels and bps

2024-06-30 Thread James Almer
On 6/29/2024 8:37 PM, Michael Niedermayer wrote: On Wed, Jun 26, 2024 at 09:52:44PM -0300, James Almer wrote: On 3/22/2024 8:08 PM, Michael Niedermayer wrote: Fixes: Timeout Fixes: 67044/clusterfuzz-testcase-minimized-ffmpeg_dem_CAF_fuzzer-5791144363491328 Found-by: continuous fuzzing

[FFmpeg-devel] [PATCH 1/4] avformat/mov: check that iloc offset values fit on an int64_t

2024-06-30 Thread James Almer
Signed-off-by: James Almer --- libavformat/mov.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index a2e187ff2f..fd78d5f59c 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -8388,7 +8388,7 @@ static int mov_read_SAND

[FFmpeg-devel] [PATCH 2/4] avformat/mov: check extent_offset calculation for overflow

2024-06-30 Thread James Almer
Signed-off-by: James Almer --- libavformat/mov.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index fd78d5f59c..3aa2398386 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -8482,7 +8482,8 @@ static int mov_read_iloc

[FFmpeg-devel] [PATCH 3/4] avformat/mov: check for EOF inside the infe list parsing loop

2024-06-30 Thread James Almer
Signed-off-by: James Almer --- libavformat/mov.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/mov.c b/libavformat/mov.c index 3aa2398386..9f6752b492 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -8580,6 +8580,8 @@ static int mov_read_iinf(MOVContext *c

[FFmpeg-devel] [PATCH 4/4] avformat/mov: add more checks for infe atom size

2024-06-30 Thread James Almer
Signed-off-by: James Almer --- libavformat/mov.c | 4 1 file changed, 4 insertions(+) diff --git a/libavformat/mov.c b/libavformat/mov.c index 9f6752b492..ba33e52086 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -8510,6 +8510,8 @@ static int mov_read_infe(MOVContext *c

Re: [FFmpeg-devel] [PATCH, v2] avformat/mov: get heif image rotation from irot box

2024-07-01 Thread James Almer
On 5/27/2024 12:22 PM, Hacene Bouaroua wrote: parse irot box to get the transformative heif item rotation angle. Signed-off-by: Hacene Bouaroua --- libavformat/avformat.h | 5 + libavformat/isom.h | 1 + libavformat/mov.c | 25 + 3 files changed, 31 i

[FFmpeg-devel] [PATCH] avcodec/mjpegdec: remove unused parameter from ff_mjpeg_decode_frame_from_buf

2024-07-01 Thread James Almer
Signed-off-by: James Almer --- libavcodec/mjpegdec.c | 4 ++-- libavcodec/mjpegdec.h | 2 +- libavcodec/sp5xdec.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/libavcodec/mjpegdec.c b/libavcodec/mjpegdec.c index 7daec649bc..ace25af90e 100644 --- a/libavcodec/mjpegdec.c

Re: [FFmpeg-devel] [PATCH 1/3] avformat/cafdec: sanity check channels and bps

2024-07-01 Thread James Almer
On 7/1/2024 8:42 PM, Michael Niedermayer wrote: On Sun, Jun 30, 2024 at 08:07:28PM -0300, James Almer wrote: On 6/29/2024 8:37 PM, Michael Niedermayer wrote: On Wed, Jun 26, 2024 at 09:52:44PM -0300, James Almer wrote: On 3/22/2024 8:08 PM, Michael Niedermayer wrote: Fixes: Timeout Fixes

Re: [FFmpeg-devel] [PATCH] avutil/utils: Remove racy check from avutil_version()

2021-09-26 Thread James Almer
On 9/26/2021 6:46 AM, Andreas Rheinhardt wrote: avutil_version() currently performs several checks before just returning the version. There is a static int that aims to ensure that these tests are run only once. The reason is that there used to be a slightly expensive check, but it has been remov

Re: [FFmpeg-devel] [PATCH] avformat/aacdec: enable probesize-sized resyncs mid-file

2021-09-27 Thread James Almer
On 9/27/2021 6:31 PM, Jan Ekström wrote: Before adts_aac_resync would always bail out after probesize amount of bytes had been progressed from the start of the input. Add an argument for the start position, and set it to zero when reading the header (which should happen in the beginning) to mimi

[FFmpeg-devel] [PATCH] fate/checkasm: add missing tests to FATE

2021-09-27 Thread James Almer
Signed-off-by: James Almer --- tests/fate/checkasm.mak | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/fate/checkasm.mak b/tests/fate/checkasm.mak index cec6d28286..6e7edbe655 100644 --- a/tests/fate/checkasm.mak +++ b/tests/fate/checkasm.mak @@ -18,6 +18,7 @@ FATE_CHECKASM = fate

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/siren: Check available bits at frame start

2021-09-27 Thread James Almer
On 9/27/2021 7:37 PM, Michael Niedermayer wrote: Fixes: Timeout Fixes: 39089/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MSNSIREN_fuzzer-6677219854909440 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/siren: Check available bits at frame start

2021-09-28 Thread James Almer
On 9/28/2021 3:03 PM, Michael Niedermayer wrote: On Tue, Sep 28, 2021 at 09:44:01PM +1000, Peter Ross wrote: On Tue, Sep 28, 2021 at 12:07:49AM -0300, James Almer wrote: On 9/27/2021 7:37 PM, Michael Niedermayer wrote: Fixes: Timeout Fixes: 39089/clusterfuzz-testcase-minimized

Re: [FFmpeg-devel] [PATCH v4 03/10] qsv: remove mfx/ prefix from mfx headers

2021-09-28 Thread James Almer
On 9/23/2021 3:28 AM, Haihao Xiang wrote: The following Cflags has been added to libmfx.pc, so mfx/ prefix is no longer needed when including mfx headers in FFmpeg. Cflags: -I${includedir} -I${includedir}/mfx Some old versions of libmfx have the following Cflags in libmfx.pc Cflags: -I${

Re: [FFmpeg-devel] [PATCH v4 09/10] qsv: use a new method to create mfx session when using oneVPL

2021-09-28 Thread James Almer
On 9/23/2021 3:28 AM, Haihao Xiang wrote: In oneVPL, MFXLoad() and MFXCreateSession() are required to create a workable mfx session[1] Add AccelerationMode config filter for D3D9/D3D11 session (galinart) The default device is changed to d3d11va for oneVPL when both d3d11va and dxva2 are enabled

Re: [FFmpeg-devel] [PATCH v2] avformat/aacdec: enable probesize-sized resyncs mid-stream

2021-09-28 Thread James Almer
On 9/27/2021 7:47 PM, Jan Ekström wrote: Before adts_aac_resync would always bail out after probesize amount of bytes had been progressed from the start of the input. Now just query the current position when entering resync, and at most advance probesize amount of data from that start position.

Re: [FFmpeg-devel] [PATCH v2 1/1] avfilter/frames: Ensure frames are writable when processing in-place

2021-09-28 Thread James Almer
On 9/28/2021 4:54 PM, Soft Works wrote: Signed-off-by: softworkz --- v2: Reduced to cases without AVFILTERPAD_FLAG_NEEDS_WRITABLE Can't this flag used in these filters? libavfilter/vf_cover_rect.c | 7 +-- libavfilter/vf_floodfill.c | 5 + libavfilter/vf_vflip.c | 7 ++

Re: [FFmpeg-devel] [PATCH v4 10/10] configure: add --enable-libvpl option

2021-09-28 Thread James Almer
On 9/23/2021 3:28 AM, Haihao Xiang wrote: This allows user to build FFmpeg against Intel oneVPL. oneVPL 2.2 is the required minimum version when building Intel oneVPL code. It will fail to run configure script if both libmfx and libvpl are enabled. It is recommended to use oneVPL for new work,

Re: [FFmpeg-devel] [PATCH v2 1/1] avfilter/frames: Ensure frames are writable when processing in-place

2021-09-28 Thread James Almer
On 9/28/2021 6:00 PM, Soft Works wrote: -Original Message- From: ffmpeg-devel On Behalf Of James Almer Sent: Tuesday, 28 September 2021 22:08 To: ffmpeg-devel@ffmpeg.org Subject: Re: [FFmpeg-devel] [PATCH v2 1/1] avfilter/frames: Ensure frames are writable when processing in-place

Re: [FFmpeg-devel] [PATCH v2 1/1] avfilter/frames: Ensure frames are writable when processing in-place

2021-09-28 Thread James Almer
On 9/28/2021 6:22 PM, Soft Works wrote: -Original Message- From: ffmpeg-devel On Behalf Of James Almer Sent: Tuesday, 28 September 2021 23:19 To: ffmpeg-devel@ffmpeg.org Subject: Re: [FFmpeg-devel] [PATCH v2 1/1] avfilter/frames: Ensure frames are writable when processing in-place

Re: [FFmpeg-devel] [PATCH v2 1/1] avfilter/frames: Ensure frames are writable when processing in-place

2021-09-28 Thread James Almer
On 9/28/2021 4:54 PM, Soft Works wrote: Signed-off-by: softworkz --- v2: Reduced to cases without AVFILTERPAD_FLAG_NEEDS_WRITABLE libavfilter/vf_cover_rect.c | 7 +-- libavfilter/vf_floodfill.c | 5 + libavfilter/vf_vflip.c | 7 ++- 3 files changed, 16 insertions(+), 3 de

Re: [FFmpeg-devel] [PATCH v2 1/1] avfilter/frames: Ensure frames are writable when processing in-place

2021-09-28 Thread James Almer
On 9/28/2021 7:00 PM, Soft Works wrote: -Original Message- From: ffmpeg-devel On Behalf Of James Almer Sent: Tuesday, 28 September 2021 23:50 To: ffmpeg-devel@ffmpeg.org Subject: Re: [FFmpeg-devel] [PATCH v2 1/1] avfilter/frames: Ensure frames are writable when processing in-place

[FFmpeg-devel] [PATCH] avfilter/vf_floodfill: constify the AVFrame parameter in is_same() and pick_pixel() functions

2021-09-28 Thread James Almer
Signed-off-by: James Almer --- libavfilter/vf_floodfill.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/libavfilter/vf_floodfill.c b/libavfilter/vf_floodfill.c index 21741cdb4f..5f2a4f4392 100644 --- a/libavfilter/vf_floodfill.c +++ b

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/siren: Check available bits at frame start

2021-09-28 Thread James Almer
On 9/28/2021 7:28 PM, Michael Niedermayer wrote: Fixes: Timeout Fixes: 39089/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MSNSIREN_fuzzer-6677219854909440 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Suggested-by: James Almer Signed

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/siren: Check available bits at frame start

2021-09-29 Thread James Almer
On 9/29/2021 12:31 PM, Michael Niedermayer wrote: On Tue, Sep 28, 2021 at 10:19:48PM -0300, James Almer wrote: On 9/28/2021 7:28 PM, Michael Niedermayer wrote: Fixes: Timeout Fixes: 39089/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MSNSIREN_fuzzer-6677219854909440 Found-by: continuous

Re: [FFmpeg-devel] [PATCH v5 3/7] libavformat/asfdec: Fix type of value_len

2021-09-29 Thread James Almer
On 9/29/2021 11:58 PM, Soft Works wrote: The value_len is an uint32 not an int32 per spec. That value must not be truncated, neither by casting to int, nor by any conditional checks, because at the end of get_tag, this value is needed to move forward in parsing. When the len value gets modified,

Re: [FFmpeg-devel] [PATCH] avcodec/amr_parser: passthrough if channels is unknown

2021-10-05 Thread James Almer
On 10/5/2021 5:51 PM, Michael Niedermayer wrote: Fixes: division by 0 Fixes: 39562/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_AMRWB_fuzzer-5448834960982016 Fixes: 39589/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_AMRWB_fuzzer-6119205334810624 Found-by: continuous fuzzing process

Re: [FFmpeg-devel] next release

2021-10-06 Thread James Almer
On 10/6/2021 6:57 AM, Michael Niedermayer wrote: Hi Should the next release be called "LTS"? Should the next release be 4.5 or 5.0 ? 5.0. The major bump removed old core API, so it needs to be reflected in more ways than just soname. Should it be made in december 2021 ? (as was suggested i

Re: [FFmpeg-devel] point releases

2021-10-07 Thread James Almer
On 10/6/2021 6:35 AM, Michael Niedermayer wrote: Hi all I do plan to make releases from 4.4, 4.2, 4.1, 4.0, 3.4, 3.2, 2.8 branches why ? they are used by maintained distributions as listed on https://trac.ffmpeg.org/wiki/Downstreams (hint, please keep this page updated so release work is targete

Re: [FFmpeg-devel] point releases

2021-10-07 Thread James Almer
On 10/7/2021 9:58 AM, James Almer wrote: On 10/6/2021 6:35 AM, Michael Niedermayer wrote: Hi all I do plan to make releases from 4.4, 4.2, 4.1, 4.0, 3.4, 3.2, 2.8 branches why ? they are used by maintained distributions as listed on https://trac.ffmpeg.org/wiki/Downstreams (hint, please keep

Re: [FFmpeg-devel] point releases

2021-10-07 Thread James Almer
On 10/7/2021 10:07 AM, Jean-Baptiste Kempf wrote: Hello, On Wed, 6 Oct 2021, at 11:35, Michael Niedermayer wrote: I do plan to make releases from 4.4, 4.2, 4.1, 4.0, 3.4, 3.2, 2.8 branches why ? I think this is too many to maintain. I would argue you should only support: 2.8, 3.2, 3.4, 4.1 a

Re: [FFmpeg-devel] point releases

2021-10-07 Thread James Almer
On 10/7/2021 10:29 AM, Jean-Baptiste Kempf wrote: On Thu, 7 Oct 2021, at 15:23, James Almer wrote: On 10/7/2021 10:07 AM, Jean-Baptiste Kempf wrote: Hello, On Wed, 6 Oct 2021, at 11:35, Michael Niedermayer wrote: I do plan to make releases from 4.4, 4.2, 4.1, 4.0, 3.4, 3.2, 2.8 branches

Re: [FFmpeg-devel] point releases

2021-10-07 Thread James Almer
On 10/7/2021 11:23 AM, Michael Niedermayer wrote: On Thu, Oct 07, 2021 at 10:34:12AM -0300, James Almer wrote: On 10/7/2021 10:29 AM, Jean-Baptiste Kempf wrote: On Thu, 7 Oct 2021, at 15:23, James Almer wrote: On 10/7/2021 10:07 AM, Jean-Baptiste Kempf wrote: Hello, On Wed, 6 Oct 2021, at

Re: [FFmpeg-devel] point releases

2021-10-07 Thread James Almer
On 10/7/2021 11:32 AM, Michael Niedermayer wrote: On Thu, Oct 07, 2021 at 10:23:44AM -0300, James Almer wrote: On 10/7/2021 10:07 AM, Jean-Baptiste Kempf wrote: Hello, On Wed, 6 Oct 2021, at 11:35, Michael Niedermayer wrote: I do plan to make releases from 4.4, 4.2, 4.1, 4.0, 3.4, 3.2, 2.8

Re: [FFmpeg-devel] [PATCH 14/20] tests/fate-run: Set bitexact flag for output, too

2021-10-07 Thread James Almer
On 10/1/2021 6:08 PM, Andreas Rheinhardt wrote: Signed-off-by: Andreas Rheinhardt --- One could also do this more generically in the ffmpeg function. tests/fate-run.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/fate-run.sh b/tests/fate-run.sh index bc1efa22d7..

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg, ffmpeg_opt: Allocate (In|Out)putStream.pkt early

2021-10-08 Thread James Almer
On 10/8/2021 8:49 AM, Andreas Rheinhardt wrote: Avoids checks lateron in the hot path. Signed-off-by: Andreas Rheinhardt --- fftools/ffmpeg.c | 16 +--- fftools/ffmpeg_opt.c | 4 ++-- 2 files changed, 3 insertions(+), 17 deletions(-) diff --git a/fftools/ffmpeg.c b/fftools

Re: [FFmpeg-devel] [PATCH 14/20] tests/fate-run: Set bitexact flag for output, too

2021-10-08 Thread James Almer
On 10/7/2021 12:47 PM, Andreas Rheinhardt wrote: Andreas Rheinhardt: James Almer: On 10/1/2021 6:08 PM, Andreas Rheinhardt wrote: Signed-off-by: Andreas Rheinhardt --- One could also do this more generically in the ffmpeg function.   tests/fate-run.sh | 2 +-   1 file changed, 1 insertion

Re: [FFmpeg-devel] [PATCH 4/4] fftools/ffmpeg: Remove unnecessary av_packet_unref()

2021-10-08 Thread James Almer
On 10/8/2021 5:14 AM, Andreas Rheinhardt wrote: avcodec_receive_packet() already unreferences the packet on its own. Signed-off-by: Andreas Rheinhardt --- fftools/ffmpeg.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index 0e38d6d185..14611480f1 1

[FFmpeg-devel] [PATCH] configure: export pkg-config includedir variable

2021-10-08 Thread James Almer
Some packages may not define custom cflags, in which case a simple "pkg-config --cflags" call will return an empty string. This change will be useful to get a valid include path that can be used in library checks. Signed-off-by: James Almer --- configure | 5 - 1 file changed, 4

Re: [FFmpeg-devel] [PATCH] configure: export pkg-config includedir variable

2021-10-08 Thread James Almer
On 10/8/2021 11:57 AM, Timo Rothenpieler wrote: On 08.10.2021 15:32, James Almer wrote: Some packages may not define custom cflags, in which case a simple "pkg-config --cflags" call will return an empty string. This change will be useful to get a valid include path that can be used

Re: [FFmpeg-devel] [PATCH] configure: export pkg-config includedir variable

2021-10-09 Thread James Almer
On 10/9/2021 12:07 AM, Xiang, Haihao wrote: On Fri, 2021-10-08 at 10:32 -0300, James Almer wrote: Some packages may not define custom cflags, in which case a simple "pkg-config --cflags" call will return an empty string. This change will be useful to get a valid include path that can

Re: [FFmpeg-devel] [PATCH 2/3] avformat/mux: Avoid overhead of packet list in case of single streams

2021-10-09 Thread James Almer
On 10/9/2021 12:14 PM, Andreas Rheinhardt wrote: Signed-off-by: Andreas Rheinhardt --- libavformat/internal.h | 7 +++ libavformat/mux.c | 11 ++- 2 files changed, 17 insertions(+), 1 deletion(-) diff --git a/libavformat/internal.h b/libavformat/internal.h index 223befdbc0

Re: [FFmpeg-devel] [PATCH 1/2] avformat/argo_asf: pass name through as metadata

2021-10-11 Thread James Almer
On 10/11/2021 8:25 AM, Zane van Iperen wrote: Signed-off-by: Zane van Iperen --- libavformat/argo_asf.c | 5 + libavformat/argo_asf.h | 3 ++- tests/ref/acodec/adpcm-argo | 2 +- 3 files changed, 8 insertions(+), 2 deletions(-) diff --git a/libavformat/argo_asf.c b/libavforma

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/speexdec: Check frames_per_packet more completely

2021-10-14 Thread James Almer
On 10/14/2021 7:13 PM, Michael Niedermayer wrote: Fixes: signed integer overflow: 2105344 * 539033345 cannot be represented in type 'int' Fixes: out of array write Fixes: 39956/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SPEEX_fuzzer-4766419250708480 Found-by: continuous fuzzing process

Re: [FFmpeg-devel] [PATCH 07/10] avcodec/libdav1d: Don't leak side-data-only packets

2021-10-15 Thread James Almer
On 10/11/2021 12:36 PM, Andreas Rheinhardt wrote: Signed-off-by: Andreas Rheinhardt --- libavcodec/libdav1d.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavcodec/libdav1d.c b/libavcodec/libdav1d.c index 2807210e50..2d5fccec71 100644 --- a/libavcodec/libdav1d.c +++ b/libavcodec/l

Re: [FFmpeg-devel] [PATCH 1/8] avfilter/af_replaygain: use fabsf() instead of fabs()

2021-10-16 Thread James Almer
On 10/14/2021 10:08 AM, lance.lmw...@gmail.com wrote: From: Limin Wang Signed-off-by: Limin Wang --- libavfilter/af_replaygain.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavfilter/af_replaygain.c b/libavfilter/af_replaygain.c index 4bf2763..da5c196 100644 --

Re: [FFmpeg-devel] [PATCH v5 1/9] cbs_av1: fix incorrect data type

2021-10-16 Thread James Almer
On 10/14/2021 11:04 PM, Wang, Fei W wrote: On Tue, 2021-10-12 at 16:23 +0800, Fei Wang wrote: Since order_hint_bits_minus_1 range is 0~7, cur_frame_hint can be most 128. And similar return value for cbs_av1_get_relative_dist. So if plus them and use int8_t for the result may lose its precision.

Re: [FFmpeg-devel] [PATCH] web/(old)download: Move FFmpeg 4.0 to olddownloads

2021-10-17 Thread James Almer
On 10/17/2021 5:03 PM, Michael Niedermayer wrote: It seems no actively maintained distribution is using 4.0 anymore Signed-off-by: Michael Niedermayer --- src/download| 37 - src/olddownload | 37 + 2 files changed,

Re: [FFmpeg-devel] [FFmpeg-cvslog] libavcodec/libx264: add user data unregistered SEI encoding

2021-10-18 Thread James Almer
On 10/18/2021 7:34 PM, Derek Buitenhuis wrote: On 10/18/2021 11:05 PM, Michael Niedermayer wrote: This code breaks bitexact mode for some files, i have not looked into this any deeper yet. [23:18] <@jamrial_> Daemon404: that libx264 patch conflicts with the closed caption code. it overwrites

Re: [FFmpeg-devel] [FFmpeg-cvslog] libavcodec/libx264: add user data unregistered SEI encoding

2021-10-18 Thread James Almer
On 10/18/2021 7:38 PM, James Almer wrote: On 10/18/2021 7:34 PM, Derek Buitenhuis wrote: On 10/18/2021 11:05 PM, Michael Niedermayer wrote: This code breaks bitexact mode for some files, i have not looked into this any deeper yet. [23:18] <@jamrial_> Daemon404: that libx264 patch con

Re: [FFmpeg-devel] [FFmpeg-cvslog] libavcodec/libx264: add user data unregistered SEI encoding

2021-10-19 Thread James Almer
On 10/18/2021 11:29 PM, Brad Hards wrote: On Tuesday, 19 October 2021 9:53:50 AM AEDT James Almer wrote: On 10/18/2021 7:38 PM, James Almer wrote: On 10/18/2021 7:34 PM, Derek Buitenhuis wrote: On 10/18/2021 11:05 PM, Michael Niedermayer wrote: This code breaks bitexact mode for some files

Re: [FFmpeg-devel] [PATCH 1/2] fftools/ffmpeg: exit application when decoding returns AVERROR_EXIT

2021-10-19 Thread James Almer
On 10/19/2021 2:07 AM, Soft Works wrote: -Original Message- From: ffmpeg-devel On Behalf Of Gyan Doshi Sent: Tuesday, October 19, 2021 6:51 AM To: ffmpeg-devel@ffmpeg.org Subject: Re: [FFmpeg-devel] [PATCH 1/2] fftools/ffmpeg: exit application when decoding returns AVERROR_EXIT On

Re: [FFmpeg-devel] [PATCH 1/2] fftools/ffmpeg: exit application when decoding returns AVERROR_EXIT

2021-10-19 Thread James Almer
On 10/19/2021 4:51 PM, Paul B Mahol wrote: Feel free to keep hacks for yourself. No need to send it to us, it is considered as spam as more useful patches are forgotten this way. No, you keep this kind of reply to yourself. Don't badmouth contributors. _

Re: [FFmpeg-devel] [PATCH 1/2] fftools/ffmpeg: exit application when decoding returns AVERROR_EXIT

2021-10-19 Thread James Almer
On 10/19/2021 3:59 PM, Soft Works wrote: -Original Message- From: ffmpeg-devel On Behalf Of James Almer Sent: Tuesday, October 19, 2021 4:39 PM To: ffmpeg-devel@ffmpeg.org Subject: Re: [FFmpeg-devel] [PATCH 1/2] fftools/ffmpeg: exit application when decoding returns AVERROR_EXIT On

Re: [FFmpeg-devel] [PATCH 1/2] swscale/utils: Set all threads to the same colorspace even on failure

2021-10-22 Thread James Almer
On 10/22/2021 6:45 PM, Michael Niedermayer wrote: Fixes: ./ffplay dav.y4m -vf "scale=hd1080:threads=4" Found-by: Paul Signed-off-by: Michael Niedermayer --- libswscale/utils.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libswscale/utils.c b/libswscale/utils.c inde

Re: [FFmpeg-devel] [PATCH 2/2] swscale/utils: Improve return codes of sws_setColorspaceDetails()

2021-10-22 Thread James Almer
On 10/22/2021 6:45 PM, Michael Niedermayer wrote: Signed-off-by: Michael Niedermayer --- libswscale/utils.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libswscale/utils.c b/libswscale/utils.c index 3752c3ec38c..632f6fd4648 100644 --- a/libswscale/utils.c +++ b/libs

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/hevcdec: Export Dolby Vision RPUs as side data

2021-10-23 Thread James Almer
On 10/21/2021 10:48 AM, Derek Buitenhuis wrote: Signed-off-by: Derek Buitenhuis --- * The NAL reordering approach is a result of discussions with Anton and James a few months ago. * I've put the NAL reordering in ff_h2645_packet_split, rather than a bitstream filter for a few reasons:

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/hevcdec: Export Dolby Vision RPUs as side data

2021-10-23 Thread James Almer
On 10/23/2021 2:52 PM, Derek Buitenhuis wrote: On 10/23/2021 3:18 PM, James Almer wrote: 0x7c01 is just the NAL header that signals type 62, nuh_layer_id 0 and nuh_temporal_id 0. forbidden_zero_bit= 0 nal_unit_type = 10 nuh_layer_id = 00 nuh_temporal_id_plus1

Re: [FFmpeg-devel] [PATCH 2/2] swscale/swscale: Improve *ColorspaceDetails() doxy

2021-10-25 Thread James Almer
On 10/23/2021 5:12 AM, Michael Niedermayer wrote: Signed-off-by: Michael Niedermayer --- libswscale/swscale.h | 8 1 file changed, 8 insertions(+) diff --git a/libswscale/swscale.h b/libswscale/swscale.h index 59610d03426..daa53dc01ee 100644 --- a/libswscale/swscale.h +++ b/libswsca

Re: [FFmpeg-devel] [PATCH 2/2] swscale/swscale: Improve *ColorspaceDetails() doxy

2021-10-25 Thread James Almer
On 10/25/2021 10:20 AM, Michael Niedermayer wrote: On Mon, Oct 25, 2021 at 10:13:32AM -0300, James Almer wrote: On 10/23/2021 5:12 AM, Michael Niedermayer wrote: Signed-off-by: Michael Niedermayer --- libswscale/swscale.h | 8 1 file changed, 8 insertions(+) diff --git a

Re: [FFmpeg-devel] [PATCH 1/2] fftools/ffmpeg: exit application when decoding returns AVERROR_EXIT

2021-10-25 Thread James Almer
On 10/20/2021 12:00 PM, Soft Works wrote: -Original Message- From: ffmpeg-devel On Behalf Of Nicolas George Sent: Wednesday, October 20, 2021 4:57 PM To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH 1/2] fftools/ffmpeg: exit application when decoding

Re: [FFmpeg-devel] [PATCH 6/6][BROKEN] avfilter/vf_nlmeans: add x86 SIMD

2021-10-25 Thread James Almer
On 10/24/2021 5:25 PM, Paul B Mahol wrote: Signed-off-by: Paul B Mahol --- libavfilter/vf_nlmeans.c | 3 ++ libavfilter/vf_nlmeans.h | 1 + libavfilter/x86/Makefile | 2 + libavfilter/x86/vf_nlmeans.asm | 89 ++ 4 files changed, 95 inser

Re: [FFmpeg-devel] [PATCH] avformat/demux: preserve AV_PKT_FLAG_CORRUPT in parse_packet

2021-10-25 Thread James Almer
On 10/21/2021 1:21 PM, Alex Shumsky wrote: If original packet is corrupted, then parsed packet is probably corrupted too. Let the application decide what to do. Signed-off-by: Alex Shumsky --- libavformat/demux.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat

Re: [FFmpeg-devel] [PATCH 1/2] fftools/ffmpeg: exit application when decoding returns AVERROR_EXIT

2021-10-26 Thread James Almer
On 10/26/2021 12:33 AM, Soft Works wrote: -Original Message- From: ffmpeg-devel On Behalf Of James Almer Sent: Monday, October 25, 2021 5:33 PM To: ffmpeg-devel@ffmpeg.org Subject: Re: [FFmpeg-devel] [PATCH 1/2] fftools/ffmpeg: exit application when decoding returns AVERROR_EXIT On

Re: [FFmpeg-devel] [PATCH 02/10] avcodec/binkaudio: Properly flush the decoder

2021-10-27 Thread James Almer
On 10/27/2021 7:04 AM, Paul B Mahol wrote: Will this get applied anytime soon? Or should I do it? Andreas seems to be away, so if you don't want to wait for him to do it then imo push the any patch you think is ok. ___ ffmpeg-devel mailing list ffm

Re: [FFmpeg-devel] [PATCH 1/7] avfilter/vf_nlmeans: use more friendlier 'for (int ...'

2021-10-29 Thread James Almer
On 10/29/2021 12:18 PM, Paul B Mahol wrote: Signed-off-by: Paul B Mahol --- libavfilter/vf_nlmeans.c | 33 - 1 file changed, 12 insertions(+), 21 deletions(-) You could just use "reduce scope of some variables" for the subject instead. ___

Re: [FFmpeg-devel] [PATCH 7/7] avfilter/vf_nlmeans: add x86 SIMD

2021-10-29 Thread James Almer
On 10/29/2021 12:19 PM, Paul B Mahol wrote: Signed-off-by: Paul B Mahol --- libavfilter/vf_nlmeans.c | 3 + libavfilter/vf_nlmeans.h | 1 + libavfilter/x86/Makefile | 2 + libavfilter/x86/vf_nlmeans.asm| 92 +++ libavfilter/x86/

Re: [FFmpeg-devel] [PATCH] libaom: Dont use aom_codec_av1_dx_algo.

2021-10-29 Thread James Almer
On 10/29/2021 11:43 PM, Matt Oliver wrote: lgtm. Thanks, I will push this assuming no other comments. Does this compile and link with libaom 1.0.0? We unfortunately still support that version (despite being unusable speed wise) because distros like Debian still ship it. _

[FFmpeg-devel] [PATCH] avcodec/libaomdec: use intermediate arrays for plane pointers and strides

2021-10-30 Thread James Almer
Fixes -Wstringop-overflow warnings with libaom >= 2.0.0, where the unused alpha plane was removed from aom_image. Signed-off-by: James Almer --- libavcodec/libaomdec.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/libavcodec/libaomdec.c b/libavcodec/libaomde

Re: [FFmpeg-devel] [PATCH 2/2] avutil/hwcontext_videotoolbox: fix use of unknown builtin '__builtin_available'

2021-10-31 Thread James Almer
On 10/19/2021 11:52 AM, lance.lmw...@gmail.com wrote: From: Limin Wang OSX version: 10.11.6 Apple LLVM version 8.0.0 (clang-800.0.42.1) Target: x86_64-apple-darwin15.6.0 Signed-off-by: Limin Wang --- libavutil/hwcontext_videotoolbox.c | 12 1 file changed, 12 insertions(+) di

Re: [FFmpeg-devel] [PATCH 2/2] avutil/hwcontext_videotoolbox: fix use of unknown builtin '__builtin_available'

2021-10-31 Thread James Almer
On 10/31/2021 10:32 AM, James Almer wrote: On 10/19/2021 11:52 AM, lance.lmw...@gmail.com wrote: From: Limin Wang OSX version: 10.11.6 Apple LLVM version 8.0.0 (clang-800.0.42.1) Target: x86_64-apple-darwin15.6.0 Signed-off-by: Limin Wang ---   libavutil/hwcontext_videotoolbox.c | 12

Re: [FFmpeg-devel] [PATCH 3/5] avformat/imf: Demuxer implementation

2021-10-31 Thread James Almer
On 10/31/2021 3:34 PM, Pierre-Anthony Lemieux wrote: The functions are not static and are defined in imf_internal.h. They are used in both libavformat/imfdec.c and the tests at libavformat/tests/imf.c. Ok? If they are used in libavformat only it should be static. AFAIK static functions are onl

Re: [FFmpeg-devel] libavformat/tls_mbedtls.c: Accommodating to mbedtls v3.0.0 API changes

2021-11-01 Thread James Almer
On 11/1/2021 2:30 AM, omer yacine wrote: Hello, Let me ping this patch since I got no response after 4 days. Thanks, I don't see the patch in the mailing list archive. Could you resend it? --Omar On Thu, Oct 28, 2021 at 8:11 PM meryacine wrote: There were breaking API changes in mbedt

Re: [FFmpeg-devel] [PATCH] libavformat/tls_mbedtls.c: Accommodating to mbedtls v3.0.0 API changes

2021-11-01 Thread James Almer
On 11/1/2021 2:42 PM, meryacine wrote: There were breaking API changes in mbedtls from v2.27.0 to v3.0.0. This patch accounts for these changes. Changes: - mbedtls/certs.h is no longer imported. See https://github.com/ARMmbed/mbedtls/pull/4119. - mbedtls/config.h is replaced with mbedtls/build

[FFmpeg-devel] [PATCH] avcodec/libx264: fix sei payload leaks on error

2021-11-01 Thread James Almer
Signed-off-by: James Almer --- libavcodec/libx264.c | 23 +++ 1 file changed, 19 insertions(+), 4 deletions(-) diff --git a/libavcodec/libx264.c b/libavcodec/libx264.c index 21f434d06d..0766b4a950 100644 --- a/libavcodec/libx264.c +++ b/libavcodec/libx264.c @@ -293,6 +293,18

<    1   2   3   4   5   6   7   8   9   10   >