[FFmpeg-devel] fbdetile - detile framebuffer layout using cpu

2020-06-27 Thread C Hanish Menon
Hi, Recently I was trying to capture screen in wayland using kmsgrab and noticed that the output is mangled/tiled. When one does kmsgrab and hwdownload, as the data could be tiled many a times, I have implemented a simple cpu based detiling logic to convert them into linear layout, so that it is p

Re: [FFmpeg-devel] [PATCH v2] fbdetile cpu based framebuffer layout detiling v02

2020-06-27 Thread C Hanish Menon
Hi, It is a new video filter which I created to do detailing of the Intel Tile-X and Tile-Y framebuffer layouts into linear layout using a logic which runs on the cpu. It can be used if one uses kmsgrab and hwdownload to capture screen on a Intel GPU based system, so that one can get proper screen

Re: [FFmpeg-devel] [PATCH v2] fbdetile cpu based framebuffer layout detiling v02

2020-06-28 Thread C Hanish Menon
shKVC On Sun, Jun 28, 2020 at 2:55 PM Paul B Mahol wrote: > On 6/27/20, C Hanish Menon wrote: > > Hi, > > > > It is a new video filter which I created to do detailing of the Intel > > Tile-X and Tile-Y framebuffer layouts into linear layout using a logic > > wh

Re: [FFmpeg-devel] [PATCH v2] fbdetile cpu based framebuffer layout detiling v02

2020-06-28 Thread C Hanish Menon
Hi Mark, hwdownload vs separate filter True, for kmsgrab use-case one could potentially do this transform as part of the drm_transfer_data logic (which currently mmaps and does a linear copy, if even I remember correctly). But like what I had mentioned in my previous email, as this is done

Re: [FFmpeg-devel] [PATCH v2] fbdetile cpu based framebuffer layout detiling v02

2020-06-28 Thread C Hanish Menon
, while for the more intricate tiled layouts use the flexible | configurable generic detile logic. On Mon, Jun 29, 2020 at 3:10 AM C Hanish Menon wrote: > Hi Mark, > > hwdownload vs separate filter > > True, for kmsgrab use-case one could potentially do this transform a

Re: [FFmpeg-devel] [PATCH v2] fbdetile cpu based framebuffer layout detiling v02

2020-06-29 Thread C Hanish Menon
Hi Lynne, Thanks for your thoughts. My thoughts I have embedded below On Mon, Jun 29, 2020 at 6:32 PM Lynne wrote: > Jun 28, 2020, 22:40 by hanish...@gmail.com: > > > Hi Mark, > > > > hwdownload vs separate filter > > > > True, for kmsgrab use-case one could potentially do this transform a

Re: [FFmpeg-devel] [PATCH v3] fbdetile cpu based detiling of framebuffers v03

2020-07-01 Thread C Hanish Menon
Hi Lynne, On Wed, Jul 1, 2020 at 3:37 PM Lynne wrote: > Jun 29, 2020, 18:58 by hanish...@gmail.com: > > > v03-20200629IST2208 fbdetile > > > > Added a generic detiling logic, which can be easily configured to > > detile many different tiling schemes. > > > > The same is inturn used to detile Int

Re: [FFmpeg-devel] [PATCH v04] fbdetile cpu based detiling of framebuffers v04

2020-07-02 Thread C Hanish Menon
Hi Michael, Thanks for the input, I had forgotten to disable/undef DEBUG_PERF, which I was using to get a rough idea of the time taken by the logic using the processor performance counter on x86. The logic doesnt use x86intrinsic for any other purpose, so disabling DEBUG_PERF will fix it. I can r

Re: [FFmpeg-devel] [PATCH v05] fbdetile cpu based detiling of framebuffer v05

2020-07-02 Thread C Hanish Menon
Hi Lynne, On Fri, Jul 3, 2020 at 4:17 AM Lynne wrote: > Jul 2, 2020, 22:51 by hanish...@gmail.com: > > > v05-20200703IST0255, fbdetile, hwdownload, kmsgrab, plus > > > > Moved the core detiling logic into libavutil/fbtile.[c|h] > > > > Please integrate this into hwcontext_drm. No stray files, n

Re: [FFmpeg-devel] [PATCH v06 2/5] fbtile helperRoutines cpu based framebuffer detiling

2020-07-04 Thread C Hanish Menon
Hi Lynne, On Sun, 5 Jul, 2020, 00:53 Lynne, wrote: > Jul 4, 2020, 14:17 by hanish...@gmail.com: > > > Add helper routines which can be used to detile tiled framebuffer > > layouts into a linear layout, using the cpu. > > > > Currently it supports Legacy Intel Tile-X, Legacy Intel Tile-Y and > >

Re: [FFmpeg-devel] [PATCH v06 1/5] KMSGrab: getfb2 format_modifier if user doesnt specify

2020-07-05 Thread C Hanish Menon
Hi Don't apply this patch, I will try and use ioctl directly instead of using xf86's GetFB2. Based on the reported compile issue with initialising global const for the fbtile patch when using older versions of gcc, I was checking the same using Ubuntu 16.04 setup, and realised that the older xf86

Re: [FFmpeg-devel] [PATCH v06 3/5] hwcontext_drm detile non linear layout, if possible

2020-07-05 Thread C Hanish Menon
Hi Lynne, Am confused? Please look at this patch again. I directly detile from mmaped hardware framebuffer into specified output buffer. Only if the tile layout format is not supported, it falls back to the original frame copy. I am assuming you have misread the patch. On Sun, 5 Jul, 2020, 00:5

Re: [FFmpeg-devel] [PATCH v06 4/5] hwdownload detile framebuffer, if requested by user

2020-07-05 Thread C Hanish Menon
Hi Lynne, On Sun, 5 Jul, 2020, 00:59 Lynne, wrote: > Jul 4, 2020, 14:17 by hanish...@gmail.com: > > > Added logic to support detiling of framebuffer. > > > > By default this is disabled. Only if requested by the user, the > > logic will be triggered. > > > > It uses the fbtile helper routines to

Re: [FFmpeg-devel] [PATCH v08 2/3] fbtile tile/detile, hwcontext_drm detile NonLinear

2020-07-11 Thread C Hanish Menon
Hi Lynne, On Sat, Jul 11, 2020 at 5:20 PM Lynne wrote: > Jul 11, 2020, 08:52 by hanish...@gmail.com: > > > ** fbtile cpu based framebuffer tile/detile helpers > > > > Add helper routines which can be used to tile/detile framebuffer > > layouts between linear and specified tile layout, using the

Re: [FFmpeg-devel] [PATCH v06 2/5] fbtile helperRoutines cpu based framebuffer detiling

2020-07-11 Thread C Hanish Menon
Hi Mark, On Mon, Jul 6, 2020 at 4:18 AM Mark Thompson wrote: > On 04/07/2020 14:17, hanishkvc wrote: > > Add helper routines which can be used to detile tiled framebuffer > > layouts into a linear layout, using the cpu. > > > > Currently it supports Legacy Intel Tile-X, Legacy Intel Tile-Y and >

Re: [FFmpeg-devel] [PATCH v08 2/3] fbtile tile/detile, hwcontext_drm detile NonLinear

2020-07-11 Thread C Hanish Menon
Hi Lynne, On Sat, 11 Jul, 2020, 20:31 C Hanish Menon, wrote: > Hi Lynne, > > On Sat, Jul 11, 2020 at 5:20 PM Lynne wrote: > >> Jul 11, 2020, 08:52 by hanish...@gmail.com: >> >> > ** fbtile cpu based framebuffer tile/detile helpers >> > >> > A

Re: [FFmpeg-devel] [PATCH v08 2/3] fbtile tile/detile, hwcontext_drm detile NonLinear

2020-07-12 Thread C Hanish Menon
Hi Mortiz, On Sun, 12 Jul, 2020, 18:31 Moritz Barsnick, wrote: > On Sat, Jul 11, 2020 at 20:31:40 +0530, C Hanish Menon wrote: > > > Also fix the changelog. > > > > Sorry I didn't understand this fully. Can I assume that you don't want to > > mention abo