Hi Mortiz, On Sun, 12 Jul, 2020, 18:31 Moritz Barsnick, <barsn...@gmx.net> wrote:
> On Sat, Jul 11, 2020 at 20:31:40 +0530, C Hanish Menon wrote: > > > Also fix the changelog. > > > > Sorry I didn't understand this fully. Can I assume that you don't want to > > mention about the fbtile helpers as an entry in the changelog, because > its > > not a public api? > > I believe what Lynne meant is: > > Changelog entries are added at the bottom, not at the top of the list. > You can how other commits did something, before making assumptions. > Thanks for the input. > > Thanks for suggesting the same (as previously mentioned, I haven't worked > > on ffmpeg before so am not aware of all the ffmpeg helper routines, > > Just have a look around the code and observe the mailing list. to learn > about the conventions. > Sure agree and I have tried to explore some of the related code to get things going. Wrt the specific suggestion that Lynne had given wrt av_frame_ref, for which I was responding there, like what I had mentioned in my previous email, I am not sure that is the right thing in that situation for two reasons A) to do with hardware mmaped memory being one of the buffers in question, like what I had mentioned And also because B) the logic is mainly called where previously av_frame_copy would have got called so also the fall back should be av_frame_copy rather than av_frame_ref. > Moritz > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
