On 27.10.2016 23:39, James Almer wrote:
> On 10/27/2016 5:38 PM, Andreas Cadhalpun wrote:
>> libavcodec/pngenc.c | 4
>> libavformat/apngenc.c | 27 ---
>> 2 files changed, 28 insertions(+), 3 deletions(-)
>>
>> diff --git a
Also test the fallback to png creation for a single frame.
Signed-off-by: Andreas Cadhalpun
---
Obviously, the patch fixing this has to be applied first.
---
tests/fate/avformat.mak | 1 +
tests/lavf-regression.sh | 9 +
tests/ref/lavf/apng | 6 ++
3 files changed, 16
On 28.10.2016 01:33, James Almer wrote:
> On 10/27/2016 7:43 PM, Andreas Cadhalpun wrote:
>> To avoid confusion and for lack of a better name I called the variables in
>> the encoder/muxer
>> contexts extra_side_data*.
>
> extra_data* (with an underscore so it
On 28.10.2016 02:14, James Almer wrote:
> On 10/27/2016 8:45 PM, Andreas Cadhalpun wrote:
>> Also test the fallback to png creation for a single frame.
>>
>> Signed-off-by: Andreas Cadhalpun
>> ---
>>
>> Obviously, the patch fixing this has to be
On 26.10.2016 02:07, Michael Niedermayer wrote:
> On Wed, Oct 26, 2016 at 01:35:34AM +0200, Andreas Cadhalpun wrote:
>> On 26.10.2016 01:26, Michael Niedermayer wrote:
>>> On Wed, Oct 26, 2016 at 01:16:13AM +0200, Andreas Cadhalpun wrote:
>>>> configure |7 +
On 28.10.2016 03:40, Philip Langdale wrote:
> This avoids it getting picked by default, which is generally
> undesirable and can break test runs.
>
> Signed-off-by: Philip Langdale
> ---
> libavcodec/allcodecs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavcodec
Signed-off-by: Andreas Cadhalpun
---
doc/filters.texi | 2 +-
doc/formats.texi | 2 +-
libavcodec/4xm.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/doc/filters.texi b/doc/filters.texi
index c37fa29..1ebf251 100644
--- a/doc/filters.texi
+++ b/doc/filters.texi
On 29.10.2016 12:03, Clément Bœsch wrote:
> On Mon, Oct 24, 2016 at 11:05:06PM +0200, Clément Bœsch wrote:
>> ---
>> Not sure if the chunk is even needed
I'm not sure either.
>> ---
>> ffmpeg.c | 5 ++---
>> 1 file changed, 2 insertions(+), 3 deletions(-)
>>
>> diff --git a/ffmpeg.c b/ffmpeg.c
>
On 28.10.2016 19:31, compn wrote:
> On Thu, 27 Oct 2016 15:42:22 -0300 James Almer wrote:
>> On 10/27/2016 3:36 PM, Reynaldo H. Verdejo Pinochet wrote:
>>> On 10/27/2016 11:25 AM, James Almer wrote:
This is not how things were agreed.
>>> I haven't agreed to this.
>> You could have shown your
Hi Reynaldo,
On 28.10.2016 20:41, Reynaldo H. Verdejo Pinochet wrote:
> I'm already working on what I think it's a proper transition in
> line with the idea presented on my first reply to this thread.
>
> My impression from today's discussion on IRC is that James
> and Rostislav are willing to gi
On 29.10.2016 20:12, Lou Logan wrote:
> On Sat, Oct 29, 2016, at 06:57 AM, Andreas Cadhalpun wrote:
>> Signed-off-by: Andreas Cadhalpun
>> ---
>> doc/filters.texi | 2 +-
>> doc/formats.texi | 2 +-
>> libavcodec/4xm.c | 2 +-
>> 3 files changed, 3 insertio
This fixes a heap buffer overflow.
Signed-off-by: Andreas Cadhalpun
---
libavformat/mov.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavformat/mov.c b/libavformat/mov.c
index 357d800..95b546e 100644
--- a/libavformat/mov.c
+++ b/libavformat/mov.c
@@ -3028,7 +3028,7
This fixes out-of-bounds reads.
Signed-off-by: Andreas Cadhalpun
---
libavcodec/interplayacm.c | 12
1 file changed, 12 insertions(+)
diff --git a/libavcodec/interplayacm.c b/libavcodec/interplayacm.c
index 0fd3501..0486e00 100644
--- a/libavcodec/interplayacm.c
+++ b/libavcodec
This fixes out-of-bounds reads by the bitstream reader.
Signed-off-by: Andreas Cadhalpun
---
libavcodec/interplayacm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavcodec/interplayacm.c b/libavcodec/interplayacm.c
index 0486e00..f4a3446 100644
--- a/libavcodec
The number of channels is used as divisor in decode_frame, so it must
not be zero to avoid SIGFPE crashes.
Signed-off-by: Andreas Cadhalpun
---
libavcodec/interplayacm.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/libavcodec/interplayacm.c b/libavcodec/interplayacm.c
index f4a3446
On 30.10.2016 22:18, Paul B Mahol wrote:
> On 10/30/16, Andreas Cadhalpun wrote:
>> This fixes out-of-bounds reads by the bitstream reader.
>>
>> Signed-off-by: Andreas Cadhalpun
>> ---
>> libavcodec/interplayacm.c | 2 +-
>> 1 file changed, 1 inserti
On 30.10.2016 22:15, Paul B Mahol wrote:
> On 10/30/16, Andreas Cadhalpun wrote:
>> The number of channels is used as divisor in decode_frame, so it must
>> not be zero to avoid SIGFPE crashes.
>>
>> Signed-off-by: Andreas Cadhalpun
>> ---
>> libavco
On 30.10.2016 22:16, Paul B Mahol wrote:
> On 10/30/16, Andreas Cadhalpun wrote:
>> This fixes out-of-bounds reads.
>>
>> Signed-off-by: Andreas Cadhalpun
>> ---
>> libavcodec/interplayacm.c | 12
>> 1 file changed, 12 insertions(+)
>>
-mov
Signed-off-by: Andreas Cadhalpun
---
Just disabling the checkasm_check_pixblockdsp test for ppc64be,
as was done in commit e5d434 for release/3.1, does not make much sense,
as the altivec functions actually don't work...
---
libavcodec/ppc/pixblockdsp.c | 2 +-
1 file changed, 1 inse
On 31.10.2016 08:33, Paul B Mahol wrote:
> On 10/30/16, Andreas Cadhalpun wrote:
>> On 30.10.2016 22:18, Paul B Mahol wrote:
>>> On 10/30/16, Andreas Cadhalpun wrote:
>>>> This fixes out-of-bounds reads by the bitstream reader.
>>>
erflow, which is obviously
too late.
Best regards,
Andreas
>From 634682d0628d02a2941140800e901611bfee2d0c Mon Sep 17 00:00:00 2001
From: Andreas Cadhalpun
Date: Tue, 1 Nov 2016 01:05:01 +0100
Subject: [PATCH] mov: immediately return from mov_fix_index without old index
entries
If there are no index entries, e_ol
On 01.11.2016 02:04, Michael Niedermayer wrote:
> On Tue, Nov 01, 2016 at 12:27:00AM +0100, Andreas Cadhalpun wrote:
>> The checkasm test fails, see trac ticket 5508.
>>
>> Also, the following tests fail due to this:
>> fate-vsynth1-dnxhd-2k-hr-hq fate-vsynth1-dnxhd-edg
On 01.11.2016 05:09, James Almer wrote:
> On 10/31/2016 11:32 PM, James Almer wrote:
>> Fixes remuxing apng streams coming from the apng demuxer.
>> This is a regression since 97792e85c338d129342f5812e2a52048373e57d6.
>>
>> Signed-off-by: James Almer
>> ---
>> libavformat/apngenc.c | 7 +++
>>
On 01.11.2016 17:06, James Almer wrote:
> On 11/1/2016 12:54 PM, Andreas Cadhalpun wrote:
>> What I like about the approach of using the private extra_data context
>> buffer is
>> that is is quite obvious where it is set. On the other hand the codecpar
>> extradata
Fixes remuxing apng streams coming from the apng demuxer.
This is a regression since 940b8908b94404a65f9f55e33efb4ccc6c81383c.
Found-by: James Almer
Signed-off-by: Andreas Cadhalpun
---
libavcodec/pngdec.c | 23 ++--
libavformat/apngdec.c | 73
Signed-off-by: Andreas Cadhalpun
---
To be applied after the fix.
---
tests/lavf-regression.sh | 3 +++
tests/ref/lavf/apng | 3 +++
2 files changed, 6 insertions(+)
diff --git a/tests/lavf-regression.sh b/tests/lavf-regression.sh
index 941f4d1..12954d5 100755
--- a/tests/lavf
On 01.11.2016 06:32, Sasi Inguva wrote:
> patch looks good to me. Thanks for the fix.
Pushed.
Best regards,
Andreas
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
On 01.11.2016 18:26, James Almer wrote:
> On 11/1/2016 1:18 PM, Andreas Cadhalpun wrote:
>> Fixes remuxing apng streams coming from the apng demuxer.
>> This is a regression since 940b8908b94404a65f9f55e33efb4ccc6c81383c.
>>
>> Found-by: James Almer
>>
On 01.11.2016 18:27, James Almer wrote:
> On 11/1/2016 1:42 PM, Andreas Cadhalpun wrote:
>> Signed-off-by: Andreas Cadhalpun
>> ---
>>
>> To be applied after the fix.
>>
>> ---
>>
>> tests/lavf-regression.sh | 3 +++
>> tests/ref
On 01.11.2016 23:10, Hendrik Leppkes wrote:
> Am 01.11.2016 17:17 schrieb "Andreas Cadhalpun" <
> andreas.cadhal...@googlemail.com>:
>> Not again, but instead, as the extradata is then only transferred as side
>> data.
>> That way it is again consistent b
On 02.11.2016 21:10, Hendrik Leppkes wrote:
> On Wed, Nov 2, 2016 at 8:13 PM, Andreas Cadhalpun
> wrote:
>> On 01.11.2016 23:10, Hendrik Leppkes wrote:
>>> Am 01.11.2016 17:17 schrieb "Andreas Cadhalpun" <
>>> andreas.cadhal...@googlemail.com>:
&g
On 02.11.2016 11:31, Michael Niedermayer wrote:
> On Wed, Nov 02, 2016 at 01:40:01AM +0100, Carl Eugen Hoyos wrote:
>> 2016-11-01 0:27 GMT+01:00 Andreas Cadhalpun
>> :
>>
>>> -#if HAVE_ALTIVEC
>>> +#if HAVE_ALTIVEC && !(ARCH_PPC64 && HAV
-dnxhd-edge3-hr
fate-vsynth3-dnxhd-hr-sq-mov fate-vsynth3-dnxhd-hr-hq-mov
Fixes trac ticket #5508.
Signed-off-by: Andreas Cadhalpun
---
Tested with qemu on ppc32be and ppc64be.
---
libavcodec/ppc/pixblockdsp.c | 17 ++---
1 file changed, 10 insertions(+), 7 deletions(-)
diff --git a
On 02.11.2016 13:07, Michael Niedermayer wrote:
> On Sat, Oct 22, 2016 at 01:16:00AM +0200, Andreas Cadhalpun wrote:
>> utils.c | 12
>> 1 file changed, 12 insertions(+)
>> ffefc22756b774cb7652587207ae66cfbf681be3
>> 0001-avformat-close-parser-if-
On 26.10.2016 21:44, Andreas Cadhalpun wrote:
> On 26.10.2016 20:15, Paul B Mahol wrote:
>> On 10/25/16, Michael Niedermayer wrote:
>>> On Tue, Oct 25, 2016 at 07:45:25PM +0200, Andreas Cadhalpun wrote:
>>>> On 25.10.2016 12:58, Paul B Mahol wrote:
>>>>&
On 03.11.2016 00:42, Michael Niedermayer wrote:
> On Wed, Nov 02, 2016 at 10:30:30PM +0100, Andreas Cadhalpun wrote:
>> On 02.11.2016 13:07, Michael Niedermayer wrote:
>>> On Sat, Oct 22, 2016 at 01:16:00AM +0200, Andreas Cadhalpun wrote:
>>>> utils.c | 12 +++
This fixes probing dts/eac3/mp2 in hls.
The problem was introduced in commit 04964ac311abe670fb3b60290a330f2067544b13.
Also update the fate reference for the fate-segment-mp4-to-ts test.
Signed-off-by: Andreas Cadhalpun
---
I've no idea why the fate reference changes, but this also ha
On 27.10.2016 22:31, Andreas Cadhalpun wrote:
> On 27.10.2016 21:30, Hendrik Leppkes wrote:
>> On Thu, Oct 27, 2016 at 9:20 PM, Andreas Cadhalpun
>> wrote:
>>> This fixes probing dts/eac3/mp2 in hls.
>>>
>>> This partly reverts commit 04964ac311abe6
On 02.11.2016 23:41, Carl Eugen Hoyos wrote:
> 2016-11-02 21:34 GMT+01:00 Andreas Cadhalpun
> :
>> This was broken by the following Libav commit:
>> 4c387c7 ppc: dsputil: do unaligned block accesses correctly
>>
>> The following tests fail due to this:
>> fate-
Hi,
On 03.11.2016 11:18, Anssi Hannula wrote:
> Andreas Cadhalpun kirjoitti 2016-11-03 02:12:
>> This fixes probing dts/eac3/mp2 in hls.
>>
>> The problem was introduced in commit
>> 04964ac311abe670fb3b60290a330f2067544b13.
>>
>> Also update the fate r
On 03.11.2016 09:52, Hendrik Leppkes wrote:
> Hence my point about trying to stick to a common behavior scheme
> without looking at what *OUR* decoder needs - there could be others,
> after all.
> Its common to write extradata into codecpar if its present. You can
> try to dispute that as long as y
On 03.11.2016 19:53, Hendrik Leppkes wrote:
> Since you want docs, I even found one extremely specific to this
> particular case:
> https://ffmpeg.org/ffmpeg-formats.html#apng
>
> "All headers, but the PNG signature, up to (but not including) the
> first fcTL chunk are transmitted as extradata."
>
On 03.11.2016 20:03, James Almer wrote:
> On 11/3/2016 4:00 PM, Andreas Cadhalpun wrote:
>> On 03.11.2016 19:53, Hendrik Leppkes wrote:
>>> Since you want docs, I even found one extremely specific to this
>>> particular case:
>>> https://ffmpeg.org/ffmpeg-fo
On 03.11.2016 11:07, Michael Niedermayer wrote:
> On Thu, Nov 03, 2016 at 01:04:21AM +0100, Andreas Cadhalpun wrote:
>> Yes, but it's not clear that the parser internal state is still correct
>> after a change of the codec id.
>
> what exact case are we talking
On 03.11.2016 11:30, Michael Niedermayer wrote:
> Signed-off-by: Michael Niedermayer
> ---
> libavcodec/ac3dec.c | 4
> 1 file changed, 4 insertions(+)
>
> diff --git a/libavcodec/ac3dec.c b/libavcodec/ac3dec.c
> index a95c204..499971a 100644
> --- a/libavcodec/ac3dec.c
> +++ b/libavcodec/a
This fixes a double-free detected by AddressSanitizer.
The problem was introduced in commit
dcad4677d637cd2f701917e38361fa96b8c9a418.
Signed-off-by: Andreas Cadhalpun
---
libavcodec/diracdec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavcodec/diracdec.c b
Otherwise it can be non-zero next time decode_lowdelay is called, causing
slice_params_buf not to be allocated, leading to a NULL pointer dereference.
The problem was introduced in commit
dcad4677d637cd2f701917e38361fa96b8c9a418.
Signed-off-by: Andreas Cadhalpun
---
libavcodec/diracdec.c | 1
If it fails, buffers aren't allocated, causing NULL pointer dereferencing.
Signed-off-by: Andreas Cadhalpun
---
libavcodec/diracdec.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/libavcodec/diracdec.c b/libavcodec/diracdec.c
index bb314d0..e0604af 100644
On 04.11.2016 20:07, Rostislav Pehlivanov wrote:
> On 4 November 2016 at 18:10, Andreas Cadhalpun <
> andreas.cadhal...@googlemail.com> wrote:
>
>> This fixes a double-free detected by AddressSanitizer.
>>
>> The problem was introduced in commit
>> d
Otherwise the codec context and codecpar might disagree on the codec id,
triggering asserts in av_parser_parse2.
Signed-off-by: Andreas Cadhalpun
---
libavformat/oggparsetheora.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/libavformat/oggparsetheora.c b/libavformat/oggparsetheora.c
Otherwise the codec context and codecpar might disagree on the codec id,
triggering asserts in av_parser_parse2.
Signed-off-by: Andreas Cadhalpun
---
libavformat/flvdec.c | 16
1 file changed, 12 insertions(+), 4 deletions(-)
diff --git a/libavformat/flvdec.c b/libavformat
This fixes heap-use-after-free detected by AddressSanitizer.
Signed-off-by: Andreas Cadhalpun
---
libavcodec/lzf.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/libavcodec/lzf.c b/libavcodec/lzf.c
index 409a7ff..5b7526e 100644
--- a/libavcodec/lzf.c
+++ b/libavcodec/lzf.c
@@ -53,6 +53,7
Metadata streams have priv_data set to NULL.
Signed-off-by: Andreas Cadhalpun
---
libavformat/mxfdec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c
index d2166ee..a1a79ce 100644
--- a/libavformat/mxfdec.c
+++ b/libavformat
On 05.11.2016 17:38, Anssi Hannula wrote:
> Signed-off-by: Anssi Hannula
> ---
> libavformat/hls.c | 18 +++---
> 1 file changed, 11 insertions(+), 7 deletions(-)
>
> diff --git a/libavformat/hls.c b/libavformat/hls.c
> index 3c09dd8..6fb652c 100644
> --- a/libavformat/hls.c
> +++ b/
On 05.11.2016 17:39, Anssi Hannula wrote:
> Commit 04964ac311abe670f ("avformat/hls: Fix missing streams in some
> cases with MPEG TS") caused a regression where subdemuxer streams that
> use probing (e.g. dts/eac3/mp2 in mpegts) no longer get probed properly.
>
> This is because the codec paramet
On 05.11.2016 18:47, Andreas Cadhalpun wrote:
> On 05.11.2016 17:39, Anssi Hannula wrote:
>> @@ -1981,6 +1986,11 @@ static int hls_read_packet(AVFormatContext *s,
>> AVPacket *pkt)
>>
>> pls->ctx->streams[
On 05.11.2016 01:36, Luca Barbato wrote:
> On 04/11/2016 23:33, Andreas Cadhalpun wrote:
>> This fixes heap-use-after-free detected by AddressSanitizer.
>>
>> Signed-off-by: Andreas Cadhalpun
>> ---
>> libavcodec/lzf.c | 2 ++
>> 1 file changed, 2 inse
On 05.11.2016 02:09, Michael Niedermayer wrote:
> On Sat, Nov 05, 2016 at 12:20:21AM +0100, Andreas Cadhalpun wrote:
>> Metadata streams have priv_data set to NULL.
>>
>> Signed-off-by: Andreas Cadhalpun
>> ---
>> libavformat/mxfdec.c | 2 +-
>> 1 f
On 06.11.2016 22:44, Anssi Hannula wrote:
> Signed-off-by: Anssi Hannula
> ---
>
> libavformat/hls.c | 18 +++---
> 1 file changed, 11 insertions(+), 7 deletions(-)
>
> diff --git a/libavformat/hls.c b/libavformat/hls.c
> index 3c09dd8..6fb652c 100644
> --- a/libavformat/hls.c
> +++
On 06.11.2016 22:44, Anssi Hannula wrote:
> Commit 04964ac311abe670f ("avformat/hls: Fix missing streams in some
> cases with MPEG TS") caused a regression where subdemuxer streams that
> use probing (e.g. dts/eac3/mp2 in mpegts) no longer get probed properly.
>
> This is because the codec paramet
On 06.11.2016 22:44, Anssi Hannula wrote:
> Signed-off-by: Anssi Hannula
> ---
> libavformat/hls.c | 18 ++
> 1 file changed, 14 insertions(+), 4 deletions(-)
>
This misses checking the return code of the other occurrence of
set_stream_info_from_input_stream in hls_read_packet.
On 06.11.2016 23:52, Anssi Hannula wrote:
> Signed-off-by: Anssi Hannula
> ---
>
> 07.11.2016, 00:35, Andreas Cadhalpun kirjoitti:
>> On 06.11.2016 22:44, Anssi Hannula wrote:
>>> Signed-off-by: Anssi Hannula
>>> ---
>>> libavformat/hls.c |
Use the hls_close function to reduce code duplication.
Signed-off-by: Andreas Cadhalpun
---
libavformat/hls.c | 30 ++
1 file changed, 14 insertions(+), 16 deletions(-)
diff --git a/libavformat/hls.c b/libavformat/hls.c
index 2bf86fa..3ae3c7c 100644
--- a
On 02.11.2016 23:09, Andreas Cadhalpun wrote:
> In the absence of further comments, I intend to push this set in a few days.
I've pushed this now.
Best regards,
Andreas
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org
The API does not allow returning AVERROR codes.
It triggers an assert in av_parser_parse2.
Signed-off-by: Andreas Cadhalpun
---
libavcodec/mpegaudio_parser.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavcodec/mpegaudio_parser.c b/libavcodec/mpegaudio_parser.c
index
On 07.11.2016 10:23, Michael Niedermayer wrote:
> On Mon, Nov 07, 2016 at 01:21:01AM +0100, Andreas Cadhalpun wrote:
>> The API does not allow returning AVERROR codes.
>>
>> It triggers an assert in av_parser_parse2.
>>
>> Signed-off-by: Andreas Cadhalpun
>>
On 07.11.2016 16:20, Michael Niedermayer wrote:
> On Mon, Nov 07, 2016 at 12:11:25AM +0100, Andreas Cadhalpun wrote:
>> Use the hls_close function to reduce code duplication.
>>
>> Signed-off-by: Andreas Cadhalpun
>> ---
>> libavformat/hls.c | 30 ++--
On 04.11.2016 21:16, Michael Niedermayer wrote:
> diff --git a/libavutil/opt.c b/libavutil/opt.c
> index cd16bd1..1b8dae2 100644
> --- a/libavutil/opt.c
> +++ b/libavutil/opt.c
> @@ -1992,3 +1992,15 @@ int av_opt_serialize(void *obj, int opt_flags, int
> flags, char **buffer,
> av_bprint_fina
This fixes a heap-buffer-overflow in ff_er_frame_end when decoding mss2 with
coded_width/coded_height larger than width/height.
Signed-off-by: Andreas Cadhalpun
---
libavcodec/mpegpicture.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/libavcodec/mpegpicture.c
On 07.11.2016 20:26, James Almer wrote:
> ffserver is being dropped from the project, as announced in the news page.
>
> Reynaldo however wants to have a working copy somewhere so he's moving it to
> an external repo and for that he's making it work without internal API, with
> some help from Mich
On 07.11.2016 22:52, Luca Barbato wrote:
> On 07/11/2016 22:32, Andreas Cadhalpun wrote:
>> This fixes a heap-buffer-overflow in ff_er_frame_end when decoding mss2 with
>> coded_width/coded_height larger than width/height.
>>
>> Signed-off-by: Andreas Cadhalpun
>>
Signed-off-by: Andreas Cadhalpun
---
libavformat/mpegts.c | 4
1 file changed, 4 insertions(+)
diff --git a/libavformat/mpegts.c b/libavformat/mpegts.c
index fad10c6..77d63f2 100644
--- a/libavformat/mpegts.c
+++ b/libavformat/mpegts.c
@@ -2692,6 +2692,10 @@ static int mpegts_read_header
The code assumes that s->streams[0] is valid.
Signed-off-by: Andreas Cadhalpun
---
libavformat/matroskadec.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c
index 32f5e49..130d92e 100644
--- a/libavformat/matroskadec.c
++
On 08.11.2016 00:54, Michael Niedermayer wrote:
> On Mon, Nov 07, 2016 at 11:49:52PM +0100, Andreas Cadhalpun wrote:
>> Signed-off-by: Andreas Cadhalpun
>> ---
>> libavformat/mpegts.c | 4
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/liba
On 08.11.2016 01:12, Michael Niedermayer wrote:
> On Tue, Nov 08, 2016 at 12:44:56AM +0100, Andreas Cadhalpun wrote:
>> The code assumes that s->streams[0] is valid.
>>
>> Signed-off-by: Andreas Cadhalpun
>> ---
>> libavformat/matroskadec.c | 5 ++
On 08.11.2016 21:09, Michael Niedermayer wrote:
> On Tue, Nov 08, 2016 at 07:47:02PM +0100, Andreas Cadhalpun wrote:
>> On 08.11.2016 00:54, Michael Niedermayer wrote:
>>> On Mon, Nov 07, 2016 at 11:49:52PM +0100, Andreas Cadhalpun wrote:
>>>> Si
On 08.11.2016 22:12, Michael Niedermayer wrote:
> On Tue, Nov 08, 2016 at 09:38:49PM +0100, Andreas Cadhalpun wrote:
>> On 08.11.2016 21:09, Michael Niedermayer wrote:
>>> On Tue, Nov 08, 2016 at 07:47:02PM +0100, Andreas Cadhalpun wrote:
>>>> On 08.11.2016 00
: Andreas Cadhalpun
---
libavcodec/dvbsubdec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavcodec/dvbsubdec.c b/libavcodec/dvbsubdec.c
index e9f4765..31898ea 100644
--- a/libavcodec/dvbsubdec.c
+++ b/libavcodec/dvbsubdec.c
@@ -810,7 +810,7 @@ static void compute_default_clut
It can read less than the requested amount, in which case buf contains
uninitialized data, causing problems like segmentation faults later on.
Signed-off-by: Andreas Cadhalpun
---
libavformat/icodec.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libavformat/icodec.c b
Signed-off-by: Andreas Cadhalpun
---
libavformat/icodec.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/libavformat/icodec.c b/libavformat/icodec.c
index aad1416..becbc0f 100644
--- a/libavformat/icodec.c
+++ b/libavformat/icodec.c
@@ -174,8 +174,10 @@ static int
Signed-off-by: Andreas Cadhalpun
---
libavformat/icodec.c | 8
1 file changed, 8 insertions(+)
diff --git a/libavformat/icodec.c b/libavformat/icodec.c
index becbc0f..1d8e383 100644
--- a/libavformat/icodec.c
+++ b/libavformat/icodec.c
@@ -199,6 +199,13 @@ static int read_packet
On 09.11.2016 00:28, Moritz Barsnick wrote:
> On Wed, Nov 09, 2016 at 00:00:09 +0100, Andreas Cadhalpun wrote:
>> [PATCH 2/2] iocodec: add ico_read_close to fix leaking ico->images
> ^ icodec
Fixed locally.
Best r
It causes a cb_depth of 32, leading to assertion failures in get_bits.
Signed-off-by: Andreas Cadhalpun
---
libavcodec/escape124.c | 4
1 file changed, 4 insertions(+)
diff --git a/libavcodec/escape124.c b/libavcodec/escape124.c
index b872b3a..c3174ce 100644
--- a/libavcodec/escape124.c
Otherwise put_bits can be called with a value that doesn't fit in the
sample_len, causing an assertion failure.
---
libavcodec/pnmdec.c | 4
1 file changed, 4 insertions(+)
diff --git a/libavcodec/pnmdec.c b/libavcodec/pnmdec.c
index ca97cc3..0381ea6 100644
--- a/libavcodec/pnmdec.c
+++ b/li
On 09.11.2016 02:27, Michael Niedermayer wrote:
> On Tue, Nov 08, 2016 at 10:36:01PM +0100, Andreas Cadhalpun wrote:
>> Since the loop goes down to i = 0 the number of iterations (variable
>> count) is the original i, not i - 1.
>> In the case of i originally being 1, this mi
On 09.11.2016 02:31, Michael Niedermayer wrote:
> On Tue, Nov 08, 2016 at 11:36:58PM +0100, Andreas Cadhalpun wrote:
>> It can read less than the requested amount, in which case buf contains
>> uninitialized data, causing problems like segmentation faults later on.
>>
>
On 09.11.2016 11:10, Michael Niedermayer wrote:
> On Wed, Nov 09, 2016 at 01:11:29AM +0100, Andreas Cadhalpun wrote:
>> Otherwise put_bits can be called with a value that doesn't fit in the
>> sample_len, causing an assertion failure.
>> ---
>> libavcodec/pnmdec.
On 09.11.2016 11:12, Michael Niedermayer wrote:
> On Wed, Nov 09, 2016 at 12:42:16AM +0100, Andreas Cadhalpun wrote:
>> It causes a cb_depth of 32, leading to assertion failures in get_bits.
>>
>> Signed-off-by: Andreas Cadhalpun
>> ---
>> libavcodec/escape124
On 09.11.2016 17:25, Michael Niedermayer wrote:
> On Tue, Nov 08, 2016 at 11:59:45PM +0100, Andreas Cadhalpun wrote:
>> Signed-off-by: Andreas Cadhalpun
>> ---
>> libavformat/icodec.c | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> should be o
On 09.11.2016 17:27, Michael Niedermayer wrote:
> On Wed, Nov 09, 2016 at 12:00:09AM +0100, Andreas Cadhalpun wrote:
>> Signed-off-by: Andreas Cadhalpun
>> ---
>> libavformat/icodec.c | 8
>> 1 file changed, 8 insertions(+)
>
> LGTM with te typo
On 09.11.2016 21:55, Michael Niedermayer wrote:
> On Wed, Nov 09, 2016 at 09:05:17PM +0100, Andreas Cadhalpun wrote:
>> On 09.11.2016 11:10, Michael Niedermayer wrote:
>>> On Wed, Nov 09, 2016 at 01:11:29AM +0100, Andreas Cadhalpun wrote:
>>>> Otherwise put_bits c
Rects with positive w/h/linesize but no data are invalid.
Signed-off-by: Andreas Cadhalpun
---
libavcodec/pgssubdec.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/libavcodec/pgssubdec.c b/libavcodec/pgssubdec.c
index cef477d..b50b37b 100644
--- a/libavcodec
The implicit checks via v_data_size and a_data_size don't work in the case
'(hdr_size > 7) && !ctx->alpha_info'.
This fixes segmentation faults due to invalid reads.
This problem was introduced in commit
547c2f002a87f4412a83c23b0d60364be5e7ce58.
Signed-off-by: Andre
On 10.11.2016 02:26, Michael Niedermayer wrote:
> On Wed, Nov 09, 2016 at 10:46:03PM +0100, Andreas Cadhalpun wrote:
>> pnmdec.c |4
>> 1 file changed, 4 insertions(+)
>> a970cb981be02ea692d0bf2e68976077f14f2de3
>> 0001-pnmdec-make-sure-v-is-cap
From 'man ppm': The maximum color value (Maxval), again in ASCII decimal.
Must be less than 65536.
Signed-off-by: Andreas Cadhalpun
---
libavcodec/pnm.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/libavcodec/pnm.c b/libavcodec/pnm.c
ind
On 10.11.2016 14:38, Michael Niedermayer wrote:
> On Wed, Nov 09, 2016 at 11:56:36PM +0100, Andreas Cadhalpun wrote:
>> The implicit checks via v_data_size and a_data_size don't work in the case
>> '(hdr_size > 7) && !ctx->alpha_info'.
>>
>
On 10.11.2016 17:42, Michael Niedermayer wrote:
> On Wed, Nov 09, 2016 at 08:52:54PM +0100, Andreas Cadhalpun wrote:
>> dvbsubdec.c |2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>> 10b117a15971daf75d61efe486b961d3cc59d480
>> 0001-dvbsub
On 10.11.2016 21:14, Michael Niedermayer wrote:
> On Wed, Nov 09, 2016 at 08:56:00PM +0100, Andreas Cadhalpun wrote:
>> icodec.c |8 ++--
>> 1 file changed, 6 insertions(+), 2 deletions(-)
>> 04c12ac83fea7b911f4050c547b77d1c48e9228b
>> 0001-icodec-corre
This fixes a heap-buffer-overflow detected by AddressSanitizer.
Signed-off-by: Andreas Cadhalpun
---
libavcodec/smvjpegdec.c | 4
1 file changed, 4 insertions(+)
diff --git a/libavcodec/smvjpegdec.c b/libavcodec/smvjpegdec.c
index 9057e86..e319e57 100644
--- a/libavcodec/smvjpegdec.c
Signed-off-by: Andreas Cadhalpun
---
libavformat/sbgdec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavformat/sbgdec.c b/libavformat/sbgdec.c
index bb020d7..cbedd12 100644
--- a/libavformat/sbgdec.c
+++ b/libavformat/sbgdec.c
@@ -927,7 +927,7 @@ static void
101 - 200 of 1524 matches
Mail list logo
