Re: [FFmpeg-devel] [PATCH 01/11] avdevice/audiotoolbox: fix mixed declaration and code

2024-07-15 Thread Zhao Zhili
> On Jul 12, 2024, at 23:44, Marvin Scholz wrote: > > Fix a bunch of "mixing declarations and code is incompatible with > standards before C99" warnings. Rather than fix the warning, can we disable the check for object-c as it's a different language? > --- > libavdevice/audiotoolbox.m | 9 +++

[FFmpeg-devel] [PATCH 1/4] avcodec/amfenc: Fixes the color information in the output.

2024-07-15 Thread Araz Iusubov
added 10 bit support for amf hevc. before: command - ffmpeg.exe -hide_banner -y -hwaccel d3d11va -hwaccel_output_format d3d11 -i test_10bit_file.mkv -an -c:v h264_amf res.dx11_hw_h264.mkv output - Format of input frames context (p010le) is not supported by AMF. command - ffmpeg.exe -hide_banner

[FFmpeg-devel] [PATCH 2/4] avcodec/amfenc: HDR metadata.

2024-07-15 Thread Araz Iusubov
v2: fixes for indentation --- libavcodec/amfenc.c | 83 + 1 file changed, 83 insertions(+) diff --git a/libavcodec/amfenc.c b/libavcodec/amfenc.c index 0bd15dd812..068bb53002 100644 --- a/libavcodec/amfenc.c +++ b/libavcodec/amfenc.c @@ -36,6 +36,57 @@

[FFmpeg-devel] [PATCH 3/4] avcodec/amfenc: add 10 bit encoding in av1_amf

2024-07-15 Thread Araz Iusubov
v2: refactored after review Signed-off-by: Evgeny Pavlov Co-authored-by: Dmitrii Ovchinnikov --- libavcodec/amfenc.c | 2 ++ libavcodec/amfenc_av1.c | 27 +++ 2 files changed, 29 insertions(+) diff --git a/libavcodec/amfenc.c b/libavcodec/amfenc.c index 068bb53002.

[FFmpeg-devel] [PATCH 4/4] avcodec/amfenc: GPU driver version check

2024-07-15 Thread Araz Iusubov
Implemented gpu driver check. 10-bit patch works incorrectly on driver version lower than 23.30. --- libavcodec/amfenc_av1.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/amfenc_av1.c b/libavcodec/amfenc_av1.c index a8629d74b0..cfa319f933 100644 --- a/libavcodec/amfenc_av1.c +++

Re: [FFmpeg-devel] [PATCH] ffmpeg: don't truncate getmaxrss value

2024-07-15 Thread Gyan Doshi
On 2024-07-14 02:14 pm, Gyan Doshi wrote: On 2024-07-11 02:52 pm, Gyan Doshi wrote: Can lead to printing of nonsensical negative memory usage Plan to push in 24h. Pushed as 350146a1ea9d2d0220cc8d024125b77240e3e98d Regards, Gyan ___ ffmpeg-de

Re: [FFmpeg-devel] [PATCH] avutil/imgutils: av_image_check_size2() ensure width and height fit in 32bit

2024-07-15 Thread Vittorio Giovara
On Tue, Jul 9, 2024 at 1:44 PM Michael Niedermayer wrote: > on "INT is 64bit" systems they may have been false > > Signed-off-by: Michael Niedermayer > --- > libavutil/imgutils.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavutil/imgutils.c b/libavutil/imgutils.c

Re: [FFmpeg-devel] [OSS-Fuzz] Have you considered enabling memory sanitizer?

2024-07-15 Thread Kacper Michajlow
On Sun, 14 Jul 2024 at 21:55, Michael Niedermayer wrote: > > On Sat, Jul 13, 2024 at 11:12:40PM +0200, Kacper Michajlow wrote: > > On Thu, 27 Jun 2024 at 02:50, Kacper Michajlow wrote: > > > > > > On Thu, 27 Jun 2024 at 00:45, Michael Niedermayer > > > wrote: > > > > > > > > On Wed, Jun 26, 2024

Re: [FFmpeg-devel] [OSS-Fuzz] Have you considered enabling memory sanitizer?

2024-07-15 Thread Vittorio Giovara
On Sun, Jul 14, 2024 at 9:55 PM Michael Niedermayer wrote: > On Sat, Jul 13, 2024 at 11:12:40PM +0200, Kacper Michajlow wrote: > > On Thu, 27 Jun 2024 at 02:50, Kacper Michajlow > wrote: > > > > > > On Thu, 27 Jun 2024 at 00:45, Michael Niedermayer > > > wrote: > > > > > > > > On Wed, Jun 26, 2

[FFmpeg-devel] [PATCH 0/1] Make "File exists" exit w/ non-zero status

2024-07-15 Thread Dabrien 'Dabe' Murphy
I'm not sure if it was by design or just an oversight, but it seems "unexpected" that ffmpeg (without `-y`) to an existing file calls `exit(0)`, even though it prints a "fatal" error... The attached patch itself is trivial, but like I say, maybe there was a reason for the current behavior that I'

[FFmpeg-devel] [PATCH 1/1] fftools/ffmpeg_opt: Exit with non-zero status when destination exists

2024-07-15 Thread Dabrien 'Dabe' Murphy
--- fftools/ffmpeg_opt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fftools/ffmpeg_opt.c b/fftools/ffmpeg_opt.c index 2c201c74b2..dddf7c6475 100644 --- a/fftools/ffmpeg_opt.c +++ b/fftools/ffmpeg_opt.c @@ -604,13 +604,13 @@ int assert_file_overwrite(const char *filena

Re: [FFmpeg-devel] [OSS-Fuzz] Have you considered enabling memory sanitizer?

2024-07-15 Thread epirat07
On 14 Jul 2024, at 21:55, Michael Niedermayer wrote: > On Sat, Jul 13, 2024 at 11:12:40PM +0200, Kacper Michajlow wrote: >> On Thu, 27 Jun 2024 at 02:50, Kacper Michajlow wrote: >>> >>> On Thu, 27 Jun 2024 at 00:45, Michael Niedermayer >>> wrote: On Wed, Jun 26, 2024 at 09:07:42PM +0

Re: [FFmpeg-devel] [PATCH 1/1] fftools/ffmpeg_opt: Exit with non-zero status when destination exists

2024-07-15 Thread Gyan Doshi
On 2024-07-15 06:26 pm, Dabrien 'Dabe' Murphy wrote: ---  fftools/ffmpeg_opt.c | 4 ++--  1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fftools/ffmpeg_opt.c b/fftools/ffmpeg_opt.c index 2c201c74b2..dddf7c6475 100644 --- a/fftools/ffmpeg_opt.c +++ b/fftools/ffmpeg_opt.c @@ -604,13

Re: [FFmpeg-devel] [PATCH v4 1/3] avcodec/jpeg2000dec: Add support for CAP and CPF markers

2024-07-15 Thread Tomas Härdin
fre 2024-07-12 klockan 12:51 -0700 skrev Pierre-Anthony Lemieux: > On Thu, Jul 11, 2024 at 10:28 PM Tomas Härdin wrote: > > > > > +    if (s->in_tile_headers == 1 && s->isHT && (!s- > > > > Ccap15_b11)) > > > +    av_log(s->avctx, AV_LOG_WARNING, "COD marker is > > > found in

Re: [FFmpeg-devel] [PATCH v3] avformat/hls: Fixed incorrect behaviour of default

2024-07-15 Thread Steven Liu
CoderVenkat 于2024年7月15日周一 00:07写道: > > Apologies > Correct file attached in this > mail.___ I need more time look at the deep for and if logic. Thanks Steven ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg

Re: [FFmpeg-devel] [PATCH 1/7] avcodec/utils: apply the same alignment to YUV410 as we do to YUV420 when motion estimation is used

2024-07-15 Thread Michael Niedermayer
On Tue, Jun 18, 2024 at 07:28:18PM +0200, Andreas Rheinhardt wrote: > Michael Niedermayer: > > The snow encoder uses block based motion estimation which can read out of > > array if > > insufficient alignment is used > > > > Fixes: out of array access > > Fixes: > > 68963/clusterfuzz-testcase-mi

Re: [FFmpeg-devel] [PATCH 3/7] avcodec/ratecontrol: Handle wanted bits overflow

2024-07-15 Thread Michael Niedermayer
On Tue, Jun 18, 2024 at 03:48:22PM +0200, Michael Niedermayer wrote: > Fixes: 5.92611e+20 is outside the range of representable values of type > 'unsigned long' > Fixes: > 68984/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SNOW_fuzzer-5155755073273856 > > Found-by: continuous fuzzing proces

Re: [FFmpeg-devel] [PATCH 5/5] avformat/iamf: Check substreams in ff_iamf_free_audio_element()

2024-07-15 Thread Michael Niedermayer
On Mon, Jun 24, 2024 at 01:01:37AM +0200, Michael Niedermayer wrote: > Fixes: member access within null pointer of type 'IAMFSubStream' (aka 'struct > IAMFSubStream') > Fixes: > 69795/clusterfuzz-testcase-minimized-ffmpeg_dem_IAMF_fuzzer-6216287009701888 > > Found-by: continuous fuzzing process

[FFmpeg-devel] [PATCH v2] avcodec/hevc/hevcdec: Do not allow slices to depend on failed slices

2024-07-15 Thread Michael Niedermayer
An alternative would be to leave the context unchanged on failure of hls_slice_header() Fixes: out of array access Fixes: NULL pointer dereference Fixes: 69584/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_HEVC_fuzzer-5931086299856896 Fixes: 69724/clusterfuzz-testcase-minimized-ffmpeg_AV_CO

[FFmpeg-devel] [PATCH] avutil/error: Provide better feedback about unknown error codes

2024-07-15 Thread Andrew Sayers
AVERROR messages should always be less than zero, and are usually based on three or four ASCII characters. For error codes that aren't explicitly handled by error.c (e.g. FFERROR_REDO), print the ASCII code so the user has a little more information. If a non-negative number somehow gets passed to

Re: [FFmpeg-devel] [PATCH 5/5] avformat/iamf: Check substreams in ff_iamf_free_audio_element()

2024-07-15 Thread James Almer
On 6/23/2024 8:01 PM, Michael Niedermayer wrote: Fixes: member access within null pointer of type 'IAMFSubStream' (aka 'struct IAMFSubStream') Fixes: 69795/clusterfuzz-testcase-minimized-ffmpeg_dem_IAMF_fuzzer-6216287009701888 Found-by: continuous fuzzing process https://github.com/google/oss

Re: [FFmpeg-devel] [PATCH] avutil/error: Provide better feedback about unknown error codes

2024-07-15 Thread Marton Balint
On Mon, 15 Jul 2024, Andrew Sayers wrote: AVERROR messages should always be less than zero, and are usually based on three or four ASCII characters. For error codes that aren't explicitly handled by error.c (e.g. FFERROR_REDO), print the ASCII code so the user has a little more information.

Re: [FFmpeg-devel] [PATCH] avutil/error: Provide better feedback about unknown error codes

2024-07-15 Thread Andrew Sayers
On Mon, Jul 15, 2024 at 05:45:24PM +0200, Marton Balint wrote: > > > On Mon, 15 Jul 2024, Andrew Sayers wrote: > > > AVERROR messages should always be less than zero, > > and are usually based on three or four ASCII characters. > > > > For error codes that aren't explicitly handled by error.c (

[FFmpeg-devel] [PATCH] avcodec/vvc: Add aarch64 neon optimization for ALF

2024-07-15 Thread Zhao Zhili
From: Zhao Zhili vvc_alf_filter_chroma_4x4_8_c: 3.0 vvc_alf_filter_chroma_4x4_8_neon: 1.0 vvc_alf_filter_chroma_4x4_10_c: 2.7 vvc_alf_filter_chroma_4x4_10_neon: 1.0 vvc_alf_filter_chroma_4x4_12_c: 2.7 vvc_alf_filter_chroma_4x4_12_neon: 1.0 vvc_alf_filter_chroma_8x8_8_c: 10.2 vvc_alf_filter_chroma

Re: [FFmpeg-devel] [PATCH] avcodec/h264_mp4toannexb: Prepend SPS/PPS to buffering period SEI

2024-07-15 Thread Josh Allmann
On Tue, 9 Jul 2024 at 12:06, Josh Allmann wrote: > > Encoders may emit a buffering period SEI without a corresponding > SPS/PPS if the SPS/PPS is carried out-of-band, eg with avcc. > > During Annex B conversion, this may result in the SPS/PPS being > inserted *after* the buffering period SEI but b

Re: [FFmpeg-devel] [PATCH] avcodec/h264_mp4toannexb: Prepend SPS/PPS to buffering period SEI

2024-07-15 Thread Josh Allmann
On Mon, 15 Jul 2024 at 10:48, Josh Allmann wrote: > > On Tue, 9 Jul 2024 at 12:06, Josh Allmann wrote: > > > > Encoders may emit a buffering period SEI without a corresponding > > SPS/PPS if the SPS/PPS is carried out-of-band, eg with avcc. > > > > During Annex B conversion, this may result in th

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/cbs_h265: fix range of sps_max_sub_layers_minus1

2024-07-15 Thread James Almer
On 7/13/2024 11:58 AM, James Almer wrote: The VPS referenced by the SPS must always be present as the max value for sps_max_sub_layers_minus1 is vps_max_sub_layers_minus1. This replaces a buggy custom range check for the aforementioned field. Also, add the missing conformance check for sps_tempor

[FFmpeg-devel] [PATCH] lavc/h264dsp: R-V V high-depth idct_add{, intra}16, idct8_add4

2024-07-15 Thread Rémi Denis-Courmont
As with 8-bit, this tends to be faster, but results are all over the place due to the variable distribution of non-zero coefficients. --- libavcodec/riscv/h264dsp_init.c | 77 + libavcodec/riscv/h264idct_rvv.S | 147 +--- 2 files changed, 154 insertions

Re: [FFmpeg-devel] [PATCH] avutil/error: Provide better feedback about unknown error codes

2024-07-15 Thread Marton Balint
On Mon, 15 Jul 2024, Andrew Sayers wrote: On Mon, Jul 15, 2024 at 05:45:24PM +0200, Marton Balint wrote: On Mon, 15 Jul 2024, Andrew Sayers wrote: AVERROR messages should always be less than zero, and are usually based on three or four ASCII characters. For error codes that aren't expli

Re: [FFmpeg-devel] [PATCH] libavformat/tls_mbedtls: Changes the return code handling of mbedtls_x509_crt_parse_file

2024-07-15 Thread Mohit Gupta
Could do. What level were you thinking? WARN? On 14/07/2024 17:29, Marth64 wrote: av_log(h, AV_LOG_DEBUG, "mbedtls_x509_crt_parse_file skipped %d certificate(s)\n", ret); Is it worth it making this a higher log level? Or is it too much noise? Thinking if it’s important security information to

Re: [FFmpeg-devel] [PATCH] libavformat/tls_mbedtls: Changes the return code handling of mbedtls_x509_crt_parse_file

2024-07-15 Thread Marth64
> Could do. What level were you thinking? WARN? How about, ``` av_log(h, AV_LOG_WARNING, "Failed to process %d certificate(s) from the CA bundle, ignoring these certificates\n", ret); ``` Thank you, ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

[FFmpeg-devel] [PATCH v3] fate/png: add mDCv and cLLi read and write test

2024-07-15 Thread Leo Izen
This test confirms that we can write mDCv and cLLi chunks and read them back via the png decoder. It uses an HEVC conformance sample with this metadata as the base source for the side data in the frames. Signed-off-by: Leo Izen Reported-by: Jan Ekström Reviewed-by: Jan Ekström Reviewed-by: Andr

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/png: more informative error message for invalid sBIT size

2024-07-15 Thread Leo Izen
On 7/12/24 3:03 PM, Leo Izen wrote: If the sBIT chunk size is invalid, we should print a more informative error message rather than return an error and print nothing. Signed-off-by: Leo Izen --- libavcodec/pngdec.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) Will merge soon.

[FFmpeg-devel] [PATCH 1/2] avcodec/vvc: Remove NOP condition check in alf_filter_luma

2024-07-15 Thread Zhao Zhili
From: Zhao Zhili If (y + i == vb_above) or (y + i == vb_below), the if body has no operation. --- libavcodec/vvc/filter_template.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/vvc/filter_template.c b/libavcodec/vvc/filter_template.c index 9b3a0e46f7..3277745

[FFmpeg-devel] [PATCH 2/2] avcodec/vvc: Remove write-only assignments in alf_filter_chroma

2024-07-15 Thread Zhao Zhili
From: Zhao Zhili --- libavcodec/vvc/filter_template.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/libavcodec/vvc/filter_template.c b/libavcodec/vvc/filter_template.c index 32777452b7..6dd7310089 100644 --- a/libavcodec/vvc/filter_template.c +++ b/libavcodec/vvc/filter_template

Re: [FFmpeg-devel] [PATCH 1/1] fftools/ffmpeg_opt: Exit with non-zero status when destination exists

2024-07-15 Thread Marth64
Gyan: > The former is not an error. The user was asked and the application > behaved as per their reply. Could it make sense to only return the AVERROR(EEXIST) if -nostdin is passed (otherwise current behavior)? I have observed this behavior too and think it's strange only in the -nostdin case. ___

[FFmpeg-devel] [PATCH] configure: remove TILE-Gx and TILE-Pro due to lack of compiler support

2024-07-15 Thread Sean McGovern
GCC removed support for them in versions >= 13.0, and there was never any acceleration or compat code generated for these targets. --- configure | 5 - 1 file changed, 5 deletions(-) diff --git a/configure b/configure index f84fefeaab..6777fc038f 100755 --- a/configure +++ b/configure @@ -214

Re: [FFmpeg-devel] [PATCH 1/1] fftools/ffmpeg_opt: Exit with non-zero status when destination exists

2024-07-15 Thread Gyan Doshi
On 2024-07-16 09:40 am, Marth64 wrote: Gyan: The former is not an error. The user was asked and the application behaved as per their reply. Could it make sense to only return the AVERROR(EEXIST) if -nostdin is passed (otherwise current behavior)? Agreed. Regards, Gyan ___