Re: [FFmpeg-devel] [PATCH] libavformat/vapoursynth: Update to API version 4, load library at runtime

2024-06-22 Thread Stefan Oltmanns via ffmpeg-devel
Am 22.06.24 um 08:27 schrieb Stephen Hutchinson: On 6/21/24 9:37 PM, Stefan Oltmanns via ffmpeg-devel wrote: The current VapourSynth implementation is rarely used, as it links the VapourSynth library at build time, making the resulting build unable to run when VapourSynth is not installed. There

[FFmpeg-devel] [RFC]] swscale modernization proposal

2024-06-22 Thread Niklas Haas
Hey, As some of you know, I got contracted (by STF 2024) to work on improving swscale, over the course of the next couple of months. I want to share my current plans and gather feedback + measure sentiment. ## Problem statement The two issues I'd like to focus on for now are: 1. Lack of support

[FFmpeg-devel] [PATCH] avfilter/af_afade: fix opt_type for nb_samples/ns

2024-06-22 Thread Andrew Sayers
The actual value is an int64_t, and is accessed elsewhere as AV_OPT_TYPE_INT64. Accessing it as INT will likely cause bugs on some 32-bit architectures. --- libavfilter/af_afade.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavfilter/af_afade.c b/libavfilter/af_afade

Re: [FFmpeg-devel] [PATCH] avfilter/af_afade: fix opt_type for nb_samples/ns

2024-06-22 Thread Andreas Rheinhardt
Andrew Sayers: > The actual value is an int64_t, and is accessed elsewhere as > AV_OPT_TYPE_INT64. > > Accessing it as INT will likely cause bugs on some 32-bit architectures. Whether this works or not will depend upon endianness, not on whether the architecture is 32-bit (as long as int is 32bi

Re: [FFmpeg-devel] [PATCH] avfilter/af_afade: fix opt_type for nb_samples/ns

2024-06-22 Thread Andrew Sayers
On Sat, Jun 22, 2024 at 03:20:52PM +0200, Andreas Rheinhardt wrote: > Andrew Sayers: > > The actual value is an int64_t, and is accessed elsewhere as > > AV_OPT_TYPE_INT64. > > > > Accessing it as INT will likely cause bugs on some 32-bit architectures. > > Whether this works or not will depend

Re: [FFmpeg-devel] [RFC]] swscale modernization proposal

2024-06-22 Thread Andrew Sayers
On Sat, Jun 22, 2024 at 03:13:34PM +0200, Niklas Haas wrote: [...] > > ## Comments / feedback? > > Does the above approach seem reasonable? How do people feel about introducing > a new API vs. trying to hammer the existing API into the shape I want it to > be? > > I've attached an example of wh

Re: [FFmpeg-devel] [RFC]] swscale modernization proposal

2024-06-22 Thread Niklas Haas
On Sat, 22 Jun 2024 15:23:22 +0100 Andrew Sayers wrote: > On Sat, Jun 22, 2024 at 03:13:34PM +0200, Niklas Haas wrote: > [...] > > > > ## Comments / feedback? > > > > Does the above approach seem reasonable? How do people feel about > > introducing > > a new API vs. trying to hammer the existi

[FFmpeg-devel] [PATCH 1/8 v3] avutil/stereo3d add a Monoscopic view enum value

2024-06-22 Thread James Almer
We need a way to signal the frame has a single view that doesn't map to any particular eye, and it should be the default one. Signed-off-by: James Almer --- Now updating all the fate test... The 3D ones will be updated again in the following commits once ffprobe is adapted to properly handle the

[FFmpeg-devel] [PATCH 2/8 v2] avutil/stereo3d: add a Stereo3D type to signal that the packing is defined by the view field

2024-06-22 Thread James Almer
Given that a video stream/frame may have only one view coded, or both packed in an undefined way, and as the values of AVStereo3DView and AVStereo3DType may clash (namely if type is AV_STEREO3D_2D, then AV_STEREO3D_VIEW_PACKED would be invalid, and if it's anything other than it, then only AV_STERE

[FFmpeg-devel] [PATCH 4/8 v2] avformat/dump: print Stereo3D view only when type is view defined

2024-06-22 Thread James Almer
Signed-off-by: James Almer --- libavformat/dump.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/libavformat/dump.c b/libavformat/dump.c index 61a2c6a29f..33d72b7e18 100644 --- a/libavformat/dump.c +++ b/libavformat/dump.c @@ -259,9 +259,10 @@ static void dump_stereo3d

[FFmpeg-devel] [PATCH 5/8 v2] fftools/ffprobe: infer AVStereo3D.view when it's not explicit

2024-06-22 Thread James Almer
Signed-off-by: James Almer --- Better infer it than not printing it, following the logic from 5140d8334e3b. fftools/ffprobe.c | 6 +- tests/ref/fate/matroska-stereo_mode | 8 2 files changed, 9 insertions(+), 5 deletions(-) diff --git a/fftools/ffprobe.c b/fftools

[FFmpeg-devel] [PATCH 6/8 v2] avutil/stereo3d: add a new allocator function that returns a size

2024-06-22 Thread James Almer
av_stereo3d_alloc() is not useful in scenarios where you need to know the runtime size of AVStereo3D. Signed-off-by: James Almer --- libavutil/stereo3d.c | 8 libavutil/stereo3d.h | 8 2 files changed, 16 insertions(+) diff --git a/libavutil/stereo3d.c b/libavutil/stereo3d.c i

[FFmpeg-devel] [PATCH 7/8 v2] avformat/mov: don't use sizeof(AVStereo3D)

2024-06-22 Thread James Almer
It's not part of the libavutil ABI. Signed-off-by: James Almer --- libavformat/isom.h | 1 + libavformat/mov.c | 10 +- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/libavformat/isom.h b/libavformat/isom.h index 35b767a52c..a0498f45e5 100644 --- a/libavformat/isom.h ++

[FFmpeg-devel] [PATCH 8/8 v2] avformat/matroskadec: don't use sizeof(AVStereo3D)

2024-06-22 Thread James Almer
It's not part of the libavutil ABI. Signed-off-by: James Almer --- libavformat/matroskadec.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c index 6bc5fa621e..d1a135ed63 100644 --- a/libavformat/matroskadec.c +++ b/li

[FFmpeg-devel] [PATCH 3/8 v2] avformat/mov: default to Monoscopic view when parsing eyes box

2024-06-22 Thread James Almer
Signed-off-by: James Almer --- libavformat/mov.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index f08fec3fb6..9b2ce1f167 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -6546,7 +6546,8 @@ static int mov_read_eyes(MOVCo

[FFmpeg-devel] [PATCH 4/4] lavc/vp8dsp: R-V V loop_filter

2024-06-22 Thread uk7b
From: sunyuechi C908 X60 vp8_loop_filter8uv_v_c : 13.7 11.7 vp8_loop_filter8uv_v_rvv_i32 :7.76.2 vp8_loop_filter16y_h_c : 12.2 11.2 vp8_loop_filter1

[FFmpeg-devel] [PATCH 2/4] lavc/vp8dsp: R-V V loop_filter_simple

2024-06-22 Thread uk7b
From: sunyuechi C908 X60 vp8_loop_filter_simple_h_c :7.06.0 vp8_loop_filter_simple_h_rvv_i32 :3.22.7 vp8_loop_filter_simple_v_c :7.26.5 vp8_loop_filter_

[FFmpeg-devel] [PATCH 1/4] lavc/vp8dsp: R-V V 256 bilin,epel

2024-06-22 Thread uk7b
From: sunyuechi X60 new vp8_put_bilin16_h_c: 42.542.5 vp8_put_bilin16_h_rvv_i32 :4.7 3.2 vp8_put_bilin16_hv_c : 71.571.7 vp8_put_bili

[FFmpeg-devel] [PATCH 3/4] lavc/vp8dsp: R-V V loop_filter_inner

2024-06-22 Thread uk7b
From: sunyuechi C908 X60 vp8_loop_filter8uv_inner_v_c : 12.5 11.0 vp8_loop_filter8uv_inner_v_rvv_i32 :7.76.2 vp8_loop_filter16y_inner_h_c : 11.7 10.2 vp8_loop_filter1

Re: [FFmpeg-devel] [PATCH] libavformat/vapoursynth: Update to API version 4, load library at runtime

2024-06-22 Thread Stephen Hutchinson
On 6/22/24 6:02 AM, Stefan Oltmanns via ffmpeg-devel wrote: I don't know the extact reason, but VapourSynth is not just a library like avisynth, but an application that uses Python, meaning a lot of dependencies. If we want to be technical, then yes, VapourSynth is just a library, with bindings

Re: [FFmpeg-devel] [PATCH] libavformat/vapoursynth: Update to API version 4, load library at runtime

2024-06-22 Thread Stefan Oltmanns via ffmpeg-devel
Am 22.06.24 um 20:23 schrieb Stephen Hutchinson: On 6/22/24 6:02 AM, Stefan Oltmanns via ffmpeg-devel wrote: I don't know the extact reason, but VapourSynth is not just a library like avisynth, but an application that uses Python, meaning a lot of dependencies. If we want to be technical, then

Re: [FFmpeg-devel] [RFC]] swscale modernization proposal

2024-06-22 Thread Michael Niedermayer
On Sat, Jun 22, 2024 at 05:10:28PM +0200, Niklas Haas wrote: > On Sat, 22 Jun 2024 15:23:22 +0100 Andrew Sayers > wrote: > > On Sat, Jun 22, 2024 at 03:13:34PM +0200, Niklas Haas wrote: > > [...] > > > > > > ## Comments / feedback? > > > > > > Does the above approach seem reasonable? How do peo

Re: [FFmpeg-devel] [PATCH 1/8 v3] avutil/stereo3d add a Monoscopic view enum value

2024-06-22 Thread James Almer
On 6/22/2024 12:31 PM, James Almer wrote: We need a way to signal the frame has a single view that doesn't map to any particular eye, and it should be the default one. Signed-off-by: James Almer --- Now updating all the fate test... The 3D ones will be updated again in the following commits on

Re: [FFmpeg-devel] [PATCH 2/8 v2] avutil/stereo3d: add a Stereo3D type to signal that the packing is defined by the view field

2024-06-22 Thread James Almer
On 6/22/2024 12:31 PM, James Almer wrote: Given that a video stream/frame may have only one view coded, or both packed in an undefined way, and as the values of AVStereo3DView and AVStereo3DType may clash (namely if type is AV_STEREO3D_2D, then AV_STEREO3D_VIEW_PACKED would be invalid, and if it'

[FFmpeg-devel] [PATCH] lavu/stereo3d: change baseline and horizontal FOV to rationals

2024-06-22 Thread Lynne via ffmpeg-devel
This avoids hardcoding any implementation-specific limitiations as part of the API, and allows for future expandability. This also allows API users to more conveniently convert the values into floats without hardcoding specific conversion constants. The draft implementation of this mechanism for

Re: [FFmpeg-devel] [PATCH] lavu/stereo3d: change baseline and horizontal FOV to rationals

2024-06-22 Thread James Almer
On 6/22/2024 5:11 PM, Lynne via ffmpeg-devel wrote: This avoids hardcoding any implementation-specific limitiations as part of the API, and allows for future expandability. This also allows API users to more conveniently convert the values into floats without hardcoding specific conversion const

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mov: default to Monoscopic view when parsing eyes box

2024-06-22 Thread Michael Niedermayer
On Fri, Jun 21, 2024 at 10:25:31PM -0300, James Almer wrote: > Signed-off-by: James Almer > --- > libavformat/mov.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) doesnt apply automatically with "git am" with the v2 Applying: avformat/mov: default to Monoscopic view when parsing eyes b

Re: [FFmpeg-devel] [PATCH] lavu/stereo3d: change baseline and horizontal FOV to rationals

2024-06-22 Thread Lynne via ffmpeg-devel
On 22/06/2024 22:19, James Almer wrote: On 6/22/2024 5:11 PM, Lynne via ffmpeg-devel wrote: This avoids hardcoding any implementation-specific limitiations as part of the API, and allows for future expandability. This also allows API users to more conveniently convert the values into floats wit

Re: [FFmpeg-devel] [PATCH] lavu/stereo3d: change baseline and horizontal FOV to rationals

2024-06-22 Thread James Almer
On 6/22/2024 6:26 PM, Lynne via ffmpeg-devel wrote: On 22/06/2024 22:19, James Almer wrote: On 6/22/2024 5:11 PM, Lynne via ffmpeg-devel wrote: This avoids hardcoding any implementation-specific limitiations as part of the API, and allows for future expandability. This also allows API users to

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mov: default to Monoscopic view when parsing eyes box

2024-06-22 Thread James Almer
On 6/22/2024 6:25 PM, Michael Niedermayer wrote: On Fri, Jun 21, 2024 at 10:25:31PM -0300, James Almer wrote: Signed-off-by: James Almer --- libavformat/mov.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) doesnt apply automatically with "git am" with the v2 Applying: avformat/mov:

Re: [FFmpeg-devel] [PATCH] lavu/stereo3d: change baseline and horizontal FOV to rationals

2024-06-22 Thread Lynne via ffmpeg-devel
On 22/06/2024 23:30, James Almer wrote: On 6/22/2024 6:26 PM, Lynne via ffmpeg-devel wrote: On 22/06/2024 22:19, James Almer wrote: On 6/22/2024 5:11 PM, Lynne via ffmpeg-devel wrote: This avoids hardcoding any implementation-specific limitiations as part of the API, and allows for future expa

Re: [FFmpeg-devel] [RFC]] swscale modernization proposal

2024-06-22 Thread Vittorio Giovara
On Sat, Jun 22, 2024 at 3:22 PM Niklas Haas wrote: > Hey, > > As some of you know, I got contracted (by STF 2024) to work on improving > swscale, over the course of the next couple of months. I want to share my > current plans and gather feedback + measure sentiment. > > ## Problem statement > >

Re: [FFmpeg-devel] [RFC]] swscale modernization proposal

2024-06-22 Thread Niklas Haas
On Sat, 22 Jun 2024 21:52:42 +0200 Michael Niedermayer wrote: > On Sat, Jun 22, 2024 at 05:10:28PM +0200, Niklas Haas wrote: > > On Sat, 22 Jun 2024 15:23:22 +0100 Andrew Sayers > > wrote: > > > On Sat, Jun 22, 2024 at 03:13:34PM +0200, Niklas Haas wrote: > > > [...] > > > > > > > > ## Comment

Re: [FFmpeg-devel] [RFC]] swscale modernization proposal

2024-06-22 Thread Niklas Haas
On Sun, 23 Jun 2024 00:19:13 +0200 Vittorio Giovara wrote: > On Sat, Jun 22, 2024 at 3:22 PM Niklas Haas wrote: > > > Hey, > > > > As some of you know, I got contracted (by STF 2024) to work on improving > > swscale, over the course of the next couple of months. I want to share my > > current p

Re: [FFmpeg-devel] [PATCH 1/8 v3] avutil/stereo3d add a Monoscopic view enum value

2024-06-22 Thread Vittorio Giovara
On Sat, Jun 22, 2024 at 9:57 PM James Almer wrote: > On 6/22/2024 12:31 PM, James Almer wrote: > > We need a way to signal the frame has a single view that doesn't map to > any > > particular eye, and it should be the default one. > > > > Signed-off-by: James Almer > > --- > > Now updating all t

[FFmpeg-devel] [PATCH 01/10 v4] avutil/stereo3d: add a Monoscopic view enum value

2024-06-22 Thread James Almer
We need a way to signal the frame has a single view that doesn't map to any particular eye, and it should be the default one. Signed-off-by: James Almer --- libavutil/stereo3d.c | 1 + libavutil/stereo3d.h | 5 + 2 files changed, 6 insertions(+) diff --git a/libavutil/stereo3d.c b/libavutil

[FFmpeg-devel] [PATCH 02/10] avutil/stereo3d: add a Stereo3D type to signal that the packing is unspecified

2024-06-22 Thread James Almer
Given that a video stream/frame may have only one or both views coded with the packing information being unavailable, this commit adds a new type value AV_STEREO3D_UNSPEC for this purpose. The most common case for this is container level signaling of Stereo3D video where the specifics are defined a

[FFmpeg-devel] [PATCH 03/10 v3] avformat/mov: default to Monoscopic view when parsing eyes and st3d boxes

2024-06-22 Thread James Almer
Signed-off-by: James Almer --- libavformat/mov.c | 16 ++-- tests/ref/fate/mov-spherical-mono | 2 +- 2 files changed, 15 insertions(+), 3 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index f08fec3fb6..b0930b2936 100644 --- a/libavformat/mov.c +++

[FFmpeg-devel] [PATCH 04/10] avcodec/h2645_sei: set Monoscopic view for 2D projection

2024-06-22 Thread James Almer
packed view (current default) is obviously not correct. Signed-off-by: James Almer --- libavcodec/h2645_sei.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/h2645_sei.c b/libavcodec/h2645_sei.c index 7c83747cd0..b30d2c1ca8 100644 --- a/libavcodec/h2645_sei.c +++ b/libavcodec/h264

[FFmpeg-devel] [PATCH 05/10] avcodec/mjpegdec: set Monoscopic view for 2D projection

2024-06-22 Thread James Almer
Signed-off-by: James Almer --- libavcodec/mjpegdec.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/mjpegdec.c b/libavcodec/mjpegdec.c index 1481a7f285..ec16186532 100644 --- a/libavcodec/mjpegdec.c +++ b/libavcodec/mjpegdec.c @@ -2019,6 +2019,7 @@ static int mjpeg_decode_app(MJ

[FFmpeg-devel] [PATCH 08/10 v3] avutil/stereo3d: add a new allocator function that returns a size

2024-06-22 Thread James Almer
av_stereo3d_alloc() is not useful in scenarios where you need to know the runtime size of AVStereo3D. Signed-off-by: James Almer --- libavutil/stereo3d.c | 8 libavutil/stereo3d.h | 8 2 files changed, 16 insertions(+) diff --git a/libavutil/stereo3d.c b/libavutil/stereo3d.c i

[FFmpeg-devel] [PATCH 06/10] avcodec/mpeg12dec: set Monoscopic view for 2D projection

2024-06-22 Thread James Almer
Signed-off-by: James Almer --- libavcodec/mpeg12dec.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/mpeg12dec.c b/libavcodec/mpeg12dec.c index 7485b7c65f..fad79aa018 100644 --- a/libavcodec/mpeg12dec.c +++ b/libavcodec/mpeg12dec.c @@ -2125,6 +2125,7 @@ static void mpeg_decode_use

[FFmpeg-devel] [PATCH 09/10 v3] avformat/mov: don't use sizeof(AVStereo3D)

2024-06-22 Thread James Almer
It's not part of the libavutil ABI. Signed-off-by: James Almer --- libavformat/isom.h | 1 + libavformat/mov.c | 10 +- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/libavformat/isom.h b/libavformat/isom.h index 35b767a52c..a0498f45e5 100644 --- a/libavformat/isom.h ++

[FFmpeg-devel] [PATCH 07/10] avformat/matroska: set Monoscopic view for 2D projection

2024-06-22 Thread James Almer
Signed-off-by: James Almer --- libavformat/matroska.h | 36 libavformat/matroskadec.c| 6 ++-- libavformat/matroskaenc.c| 8 ++--- tests/ref/fate/matroska-spherical-mono | 2 +- tests/ref/fate/matroska-sph

[FFmpeg-devel] [PATCH 10/10 v3] avformat/matroskadec: don't use sizeof(AVStereo3D)

2024-06-22 Thread James Almer
It's not part of the libavutil ABI. Signed-off-by: James Almer --- libavformat/matroskadec.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c index e6437ac68f..f090d8d798 100644 --- a/libavformat/matroskadec.c +++ b/li

[FFmpeg-devel] [PATCH] aarch64: Add OpenBSD runtime detection of dotprod and i8mm using sysctl

2024-06-22 Thread Brad Smith
[PATCH] aarch64: Add OpenBSD runtime detection of dotprod and i8mm using sysctl Signed-off-by: Brad Smith --- libavutil/aarch64/cpu.c | 35 +++ 1 file changed, 35 insertions(+) diff --git a/libavutil/aarch64/cpu.c b/libavutil/aarch64/cpu.c index 196bdaf6b0..40fcc

Re: [FFmpeg-devel] [PATCH v13 06/15] avcodec/vaapi_encode: move the dpb logic from VAAPI to base layer

2024-06-22 Thread Wu Tong
>From: ffmpeg-devel On Behalf Of Tong >Wu >Sent: 2024年6月16日 0:06 >To: FFmpeg development discussions and patches de...@ffmpeg.org> >Cc: Lynne >Subject: Re: [FFmpeg-devel] [PATCH v13 06/15] avcodec/vaapi_encode: move >the dpb logic from VAAPI to base layer > >> >> From: ffmpeg-devel On Behalf Of