Andrew Sayers:
> The actual value is an int64_t, and is accessed elsewhere as
> AV_OPT_TYPE_INT64.
>
> Accessing it as INT will likely cause bugs on some 32-bit architectures.
Whether this works or not will depend upon endianness, not on whether
the architecture is 32-bit (as long as int is 32bits, which is mostly
true for 64-bit architectures).
> ---
> libavfilter/af_afade.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/libavfilter/af_afade.c b/libavfilter/af_afade.c
> index 3a45873460..c79271ec92 100644
> --- a/libavfilter/af_afade.c
> +++ b/libavfilter/af_afade.c
> @@ -452,8 +452,8 @@ const AVFilter ff_af_afade = {
> #if CONFIG_ACROSSFADE_FILTER
>
> static const AVOption acrossfade_options[] = {
> - { "nb_samples", "set number of samples for cross fade duration",
> OFFSET(nb_samples), AV_OPT_TYPE_INT, {.i64 = 44100}, 1, INT32_MAX/10,
> FLAGS },
> - { "ns", "set number of samples for cross fade duration",
> OFFSET(nb_samples), AV_OPT_TYPE_INT, {.i64 = 44100}, 1, INT32_MAX/10,
> FLAGS },
> + { "nb_samples", "set number of samples for cross fade duration",
> OFFSET(nb_samples), AV_OPT_TYPE_INT64, {.i64 = 44100}, 1, INT32_MAX/10,
> FLAGS },
> + { "ns", "set number of samples for cross fade duration",
> OFFSET(nb_samples), AV_OPT_TYPE_INT64, {.i64 = 44100}, 1, INT32_MAX/10,
> FLAGS },
> { "duration", "set cross fade duration",
> OFFSET(duration), AV_OPT_TYPE_DURATION, {.i64 = 0 }, 0, 60000000, FLAGS
> },
> { "d", "set cross fade duration",
> OFFSET(duration), AV_OPT_TYPE_DURATION, {.i64 = 0 }, 0, 60000000, FLAGS
> },
> { "overlap", "overlap 1st stream end with 2nd stream start",
> OFFSET(overlap), AV_OPT_TYPE_BOOL, {.i64 = 1 }, 0, 1, FLAGS },
LGTM. How did you find this?
- Andreas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
