Re: [FFmpeg-devel] [PATCH] avcodec: add farbfeld encoder

2024-06-04 Thread Andreas Rheinhardt
Rémi Denis-Courmont: > > > Le 4 juin 2024 00:56:21 GMT+03:00, Andreas Rheinhardt > a écrit : >> Rémi Denis-Courmont: >>> Le maanantaina 3. kesäkuuta 2024, 22.29.13 EEST marcus a écrit : > Bogus cast / aliasing violation. I thought qualifiers don't affect aliasing rules in C. Am I

Re: [FFmpeg-devel] [RFC] STF 2025

2024-06-04 Thread Vittorio Giovara
On Tue, Jun 4, 2024 at 8:55 AM Paul B Mahol wrote: > On Tue, Jun 4, 2024 at 8:53 AM Vittorio Giovara < > vittorio.giov...@gmail.com> > wrote: > > > On Tue, Jun 4, 2024 at 3:01 AM Cosmin Stejerean via ffmpeg-devel < > > ffmpeg-devel@ffmpeg.org> wrote: > > > > > > Reposting my question/comment here

Re: [FFmpeg-devel] FFmpeg 7.0 blocking issues

2024-06-04 Thread Vittorio Giovara
On Tue, Jun 4, 2024 at 3:16 AM Michael Niedermayer wrote: > > Breakages are expected when you remove API. > > Are Breakages also expected when you do not remove API ? > If a tree falls in a forest and no one is around to hear it, does it make a sound? -- Vittorio ___

Re: [FFmpeg-devel] [PATCH] avcodec: add farbfeld encoder

2024-06-04 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Rémi Denis-Courmont: >> >> >> Le 4 juin 2024 00:56:21 GMT+03:00, Andreas Rheinhardt >> a écrit : >>> Rémi Denis-Courmont: Le maanantaina 3. kesäkuuta 2024, 22.29.13 EEST marcus a écrit : >> Bogus cast / aliasing violation. > > I thought qualifiers don't affe

Re: [FFmpeg-devel] FFmpeg 7.0 blocking issues

2024-06-04 Thread Anton Khirnov
Quoting Michael Niedermayer (2024-06-04 03:16:11) > > The real question is > > why so many projects wait until the old API is gone to migrate. What we > > removed in 7.0 has had its replacement in place for a couple years, since > > 5.1. > > Because few need or want to migrate to a new API every y

Re: [FFmpeg-devel] FFmpeg 7.0 blocking issues

2024-06-04 Thread Andrew Sayers
On Mon, Jun 03, 2024 at 11:32:37PM +0200, Michael Niedermayer wrote: > On Sun, Jun 02, 2024 at 03:49:42PM +0200, Sebastian Ramacher wrote: [...] > > Just as a FYI: ffmpeg 7.0 breaks close to 70 reverse dependencies in > > Debian. The list is available at [1]. So if you want ffmpeg X to be in > > De

Re: [FFmpeg-devel] FFmpeg 7.0 blocking issues

2024-06-04 Thread Sebastian Ramacher
On 2024-06-03 23:32:37 +0200, Michael Niedermayer wrote: > On Sun, Jun 02, 2024 at 03:49:42PM +0200, Sebastian Ramacher wrote: > > On 2024-03-03 09:55:15 +0100, Sebastian Ramacher wrote: > > > On 2024-03-02 20:39:08 -0500, Sean McGovern wrote: > > > > On Sat, Mar 2, 2024, 18:19 Michael Niedermayer

Re: [FFmpeg-devel] [PATCH v4 1/1] avcodec: add external enc libvvenc for H266/VVC

2024-06-04 Thread Anton Khirnov
Quoting Christian Bartnik (2024-05-28 18:26:29) > +static const AVOption options[] = { > +{ "passlogfile", "Filename for 2 pass stats", OFFSET(stats), > AV_OPT_TYPE_STRING, {.str = NULL}, 0, 0, VE}, > +{ "stats","Filename for 2 pass stats", OFFSET(stats), > AV_OPT_TYPE_STRING, {.

Re: [FFmpeg-devel] FFmpeg 7.0 blocking issues

2024-06-04 Thread Sebastian Ramacher
On 2024-06-04 09:31:38 +0300, Rémi Denis-Courmont wrote: > > > Le 4 juin 2024 00:41:03 GMT+03:00, James Almer a écrit : > >Well, no. Breakages are expected when you remove API. The real question is > >why so many projects wait until the old API is gone to migrate. What we > >removed in 7.0 has

Re: [FFmpeg-devel] [RFC] STF 2025

2024-06-04 Thread Paul B Mahol
On Tue, Jun 4, 2024 at 9:09 AM Vittorio Giovara wrote: > On Tue, Jun 4, 2024 at 8:55 AM Paul B Mahol wrote: > > > On Tue, Jun 4, 2024 at 8:53 AM Vittorio Giovara < > > vittorio.giov...@gmail.com> > > wrote: > > > > > On Tue, Jun 4, 2024 at 3:01 AM Cosmin Stejerean via ffmpeg-devel < > > > ffmpeg

Re: [FFmpeg-devel] [PATCH v3] avcodec: add farbfeld encoder

2024-06-04 Thread Paul B Mahol
Encoder without decoder? ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v2 1/6] lavf/tls_mbedtls: handle more error codes for

2024-06-04 Thread sfan5
Am 03.06.24 um 22:08 schrieb Jan Ekström: On Wed, May 29, 2024 at 2:05 PM sfan5 wrote: Did an initial tired look at the set, and in general it looks alright and the wrapper still builds with Fedora's mbedtls 2.28.8. (Of course then it fails to link due to unchecked usage of `mbedtls_x509_crt_{i

[FFmpeg-devel] [PATCH v3 1/6] lavf/tls_mbedtls: handle more error codes for

2024-06-04 Thread sfan5
From 7024782ebac9471194761fba9f60834ed7769efd Mon Sep 17 00:00:00 2001 From: sfan5 Date: Mon, 13 May 2024 20:22:44 +0200 Subject: [PATCH v3 1/6] lavf/tls_mbedtls: handle more error codes for human-readable messages Signed-off-by: sfan5 --- libavformat/tls_mbedtls.c | 9 + 1 file change

[FFmpeg-devel] [PATCH v3 5/6] lavf/tls_mbedtls: handle session ticket error code as

2024-06-04 Thread sfan5
From c8d7f937f5d8f1cf001aec510d4f6f28c5d9fc59 Mon Sep 17 00:00:00 2001 From: sfan5 Date: Mon, 13 May 2024 20:29:10 +0200 Subject: [PATCH v3 5/6] lavf/tls_mbedtls: handle session ticket error code as no-op When TLSv1.3 and session tickets are enabled mbedtls_ssl_read() will return an error code t

[FFmpeg-devel] [PATCH v3 2/6] lavf/tls_mbedtls: add missing call to psa_crypto_init

2024-06-04 Thread sfan5
From 8b2cab9a0ad225fc2b13850ff1bafb45d3d8ebaa Mon Sep 17 00:00:00 2001 From: sfan5 Date: Mon, 13 May 2024 20:24:43 +0200 Subject: [PATCH v3 2/6] lavf/tls_mbedtls: add missing call to psa_crypto_init This is mandatory depending on configuration or at least with mbedTLS 3.6.0. Signed-off-by: sfan5

[FFmpeg-devel] [PATCH v3 6/6] lavf/tls_mbedtls: add workaround for TLSv1.3 vs.

2024-06-04 Thread sfan5
From 9df718654e45eb02c1f2b3f29b4554a6a90900ef Mon Sep 17 00:00:00 2001 From: sfan5 Date: Fri, 17 May 2024 10:06:42 +0200 Subject: [PATCH v3 6/6] lavf/tls_mbedtls: add workaround for TLSv1.3 vs. verify=0 As of mbedTLS 3.6.0 TLSv1.3 is enabled by default and certificate verification is now mandato

[FFmpeg-devel] [PATCH v3 3/6] lavf/tls_mbedtls: hook up debug message callback

2024-06-04 Thread sfan5
From 9e5993cf104cdc1b7c4eabe173f9ab3e8f0cfeca Mon Sep 17 00:00:00 2001 From: sfan5 Date: Mon, 13 May 2024 20:26:16 +0200 Subject: [PATCH v3 3/6] lavf/tls_mbedtls: hook up debug message callback Unfortunately this won't work out-of-the-box because mbedTLS only provides a global (not per-context) d

[FFmpeg-devel] [PATCH v3 4/6] lavf/tls_mbedtls: fix handling of certification

2024-06-04 Thread sfan5
From 2cfdd92e8b323a41b65e3d6be2fc9c7641bb26c0 Mon Sep 17 00:00:00 2001 From: sfan5 Date: Mon, 13 May 2024 20:27:17 +0200 Subject: [PATCH v3 4/6] lavf/tls_mbedtls: fix handling of certification validation failures We manually check the verification status after the handshake has completed using m

Re: [FFmpeg-devel] [RFC] STF 2025

2024-06-04 Thread Vittorio Giovara
On Tue, Jun 4, 2024 at 12:09 PM Paul B Mahol wrote: > On Tue, Jun 4, 2024 at 9:09 AM Vittorio Giovara < > vittorio.giov...@gmail.com> > wrote: > > > On Tue, Jun 4, 2024 at 8:55 AM Paul B Mahol wrote: > > > > > On Tue, Jun 4, 2024 at 8:53 AM Vittorio Giovara < > > > vittorio.giov...@gmail.com> >

Re: [FFmpeg-devel] [RFC] STF 2025

2024-06-04 Thread Paul B Mahol
On Tue, Jun 4, 2024 at 12:59 PM Vittorio Giovara wrote: > On Tue, Jun 4, 2024 at 12:09 PM Paul B Mahol wrote: > > > On Tue, Jun 4, 2024 at 9:09 AM Vittorio Giovara < > > vittorio.giov...@gmail.com> > > wrote: > > > > > On Tue, Jun 4, 2024 at 8:55 AM Paul B Mahol wrote: > > > > > > > On Tue, Jun

[FFmpeg-devel] [PATCH v2 1/5] avcodec/vvcdec: refact, remove emulated_edge_dmvr and emulated_edge_bilinear to simplify code

2024-06-04 Thread Nuo Mi
--- libavcodec/vvc/inter.c | 146 + 1 file changed, 46 insertions(+), 100 deletions(-) diff --git a/libavcodec/vvc/inter.c b/libavcodec/vvc/inter.c index e1011b4fa1..0843c99eb6 100644 --- a/libavcodec/vvc/inter.c +++ b/libavcodec/vvc/inter.c @@ -44,112 +44,

[FFmpeg-devel] [PATCH v2 2/5] avcodec/vvcdec: misc, move src offset inside emulated_edge

2024-06-04 Thread Nuo Mi
--- libavcodec/vvc/inter.c | 16 ++-- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/libavcodec/vvc/inter.c b/libavcodec/vvc/inter.c index 0843c99eb6..07b55c4bac 100644 --- a/libavcodec/vvc/inter.c +++ b/libavcodec/vvc/inter.c @@ -57,6 +57,8 @@ static void emulated_edge

[FFmpeg-devel] [PATCH v2 3/5] avcodec/vvcdec: refact out emulated_edge_no_wrap

2024-06-04 Thread Nuo Mi
prepare for refrence wraparound --- libavcodec/vvc/inter.c | 91 -- 1 file changed, 61 insertions(+), 30 deletions(-) diff --git a/libavcodec/vvc/inter.c b/libavcodec/vvc/inter.c index 07b55c4bac..aacd5d8da0 100644 --- a/libavcodec/vvc/inter.c +++ b/libavco

[FFmpeg-devel] [PATCH v2 4/5] avcodec/vvcdec: misc, reindent inter.c

2024-06-04 Thread Nuo Mi
--- libavcodec/vvc/inter.c | 278 - 1 file changed, 139 insertions(+), 139 deletions(-) diff --git a/libavcodec/vvc/inter.c b/libavcodec/vvc/inter.c index aacd5d8da0..09575eb2b4 100644 --- a/libavcodec/vvc/inter.c +++ b/libavcodec/vvc/inter.c @@ -127,14 +12

[FFmpeg-devel] [PATCH v2 5/5] avcodec/vvcdec: support mv wraparound

2024-06-04 Thread Nuo Mi
A 360 video specific tool see https://ieeexplore.ieee.org/stamp/stamp.jsp?arnumber=9503377 passed files: DMVR_A_Huawei_3.bit WRAP_D_InterDigital_4.bit WRAP_A_InterDigital_4.bit WRAP_B_InterDigital_4.bit WRAP_C_InterDigital_4.bit ERP_A_MediaTek_3.bit --- libavcodec/vvc/inte

Re: [FFmpeg-devel] [PATCH 5/5] avcodec/vvcdec: support mv wraparound

2024-06-04 Thread Nuo Mi
On Tue, Jun 4, 2024 at 8:41 AM Michael Niedermayer wrote: > On Mon, Jun 03, 2024 at 08:51:16PM +0800, Nuo Mi wrote: > > A 360 video specific tool > > see https://ieeexplore.ieee.org/stamp/stamp.jsp?arnumber=9503377 > > > > passed files: > > DMVR_A_Huawei_3.bit > > WRAP_D_InterDigital_4.bi

Re: [FFmpeg-devel] [PATCH] lavc/vvc: Reallocate pixel buffers if pixel shift changes

2024-06-04 Thread Nuo Mi
On Mon, Jun 3, 2024 at 9:06 PM Frank Plowman wrote: > Allocations in the following lines depend on the pixel shift, and so > these buffers must be reallocated if the pixel shift changes. Patch > fixes segmentation faults in fuzzed bitstreams. > > Signed-off-by: Frank Plowman > --- > libavcodec

Re: [FFmpeg-devel] [RFC] STF 2025

2024-06-04 Thread Vittorio Giovara
On Tue, Jun 4, 2024 at 2:02 PM Paul B Mahol wrote: > On Tue, Jun 4, 2024 at 12:59 PM Vittorio Giovara < > vittorio.giov...@gmail.com> > wrote: > > > On Tue, Jun 4, 2024 at 12:09 PM Paul B Mahol wrote: > > > > > On Tue, Jun 4, 2024 at 9:09 AM Vittorio Giovara < > > > vittorio.giov...@gmail.com> >

Re: [FFmpeg-devel] [PATCH] libavcodec/libxvid: code cleanup (replace magic numbers)

2024-06-04 Thread Ramiro Polla
On Thu, May 30, 2024 at 11:24 PM Sean McGovern wrote: > On Thu, May 30, 2024 at 5:20 PM Ramiro Polla wrote: > > > > --- > > libavcodec/libxvid.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/libavcodec/libxvid.c b/libavcodec/libxvid.c > > index b9ac39429d..a4

Re: [FFmpeg-devel] [PATCH 1/2] ffplay: add -scaling_quality option for SDL

2024-06-04 Thread Ramiro Polla
On Thu, May 30, 2024 at 11:36 PM Ramiro Polla wrote: > > --- > doc/ffplay.texi | 2 ++ > fftools/ffplay.c | 6 +- > 2 files changed, 7 insertions(+), 1 deletion(-) > > diff --git a/doc/ffplay.texi b/doc/ffplay.texi > index 93f77eeece..60f883e159 100644 > --- a/doc/ffplay.texi > +++ b/doc/ffp

[FFmpeg-devel] [PATCH] avcodec/mpegvideo_enc: give magic number a name

2024-06-04 Thread Ramiro Polla
--- libavcodec/mpegvideo_enc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/mpegvideo_enc.c b/libavcodec/mpegvideo_enc.c index 73a9082265..82bab43e14 100644 --- a/libavcodec/mpegvideo_enc.c +++ b/libavcodec/mpegvideo_enc.c @@ -562,7 +562,7 @@ av_cold int ff_mpv_en

[FFmpeg-devel] [PATCH] libswscale/x86/yuv_2_rgb: fix some comments

2024-06-04 Thread Ramiro Polla
--- libswscale/x86/yuv_2_rgb.asm | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libswscale/x86/yuv_2_rgb.asm b/libswscale/x86/yuv_2_rgb.asm index e3470fd9ad..a1f9134e08 100644 --- a/libswscale/x86/yuv_2_rgb.asm +++ b/libswscale/x86/yuv_2_rgb.asm @@ -195,15 +195,15 @@ c

[FFmpeg-devel] [PATCH 3/5] avutil/aarch64: Skip define AV_READ_TIME for apple

2024-06-04 Thread Zhao Zhili
From: Zhao Zhili It will fallback to mach_absolute_time inside libavutil/timer.h --- libavutil/aarch64/timer.h | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/libavutil/aarch64/timer.h b/libavutil/aarch64/timer.h index 8b28fd354c..fadc9568f8 100644 --- a/libavutil/aarc

[FFmpeg-devel] [PATCH 1/5] checkasm/sw_rgb: test rgb24 to yuv

2024-06-04 Thread Zhao Zhili
From: Zhao Zhili --- tests/checkasm/sw_rgb.c | 103 1 file changed, 103 insertions(+) diff --git a/tests/checkasm/sw_rgb.c b/tests/checkasm/sw_rgb.c index 7cd815e5be..cc9b957461 100644 --- a/tests/checkasm/sw_rgb.c +++ b/tests/checkasm/sw_rgb.c @@ -24,6

[FFmpeg-devel] [PATCH 5/5] avutil/aarch64: Fallback to clock_gettime as timer on Android

2024-06-04 Thread Zhao Zhili
From: Zhao Zhili The inline asm doesn't work on Android. --- libavutil/aarch64/timer.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavutil/aarch64/timer.h b/libavutil/aarch64/timer.h index fadc9568f8..13a58b48e4 100644 --- a/libavutil/aarch64/timer.h +++ b/libavutil/aar

[FFmpeg-devel] [PATCH 4/5] avutil/timer: Add clock_gettime as a fallback of AV_READ_TIME

2024-06-04 Thread Zhao Zhili
From: Zhao Zhili --- libavutil/timer.h | 5 + 1 file changed, 5 insertions(+) diff --git a/libavutil/timer.h b/libavutil/timer.h index 2cd299eca3..74c4d84e69 100644 --- a/libavutil/timer.h +++ b/libavutil/timer.h @@ -46,6 +46,8 @@ #include "macos_kperf.h" #elif HAVE_MACH_ABSOLUTE_TIME #i

[FFmpeg-devel] [PATCH 2/5] swscale/aarch64: Add rgb24 to yuv implementation

2024-06-04 Thread Zhao Zhili
From: Zhao Zhili Test on Apple M1: rgb24_to_uv_1080_c: 7.2 rgb24_to_uv_1080_neon: 5.5 rgb24_to_uv_1280_c: 8.2 rgb24_to_uv_1280_neon: 6.2 rgb24_to_uv_1920_c: 12.5 rgb24_to_uv_1920_neon: 9.5 rgb24_to_uv_half_540_c: 6.5 rgb24_to_uv_half_540_neon: 3.0 rgb24_to_uv_half_640_c: 7.5 rgb24_to_uv_half_64

Re: [FFmpeg-devel] [PATCH 1/5] checkasm/sw_rgb: test rgb24 to yuv

2024-06-04 Thread James Almer
On 6/4/2024 10:55 AM, Zhao Zhili wrote: From: Zhao Zhili --- tests/checkasm/sw_rgb.c | 103 1 file changed, 103 insertions(+) diff --git a/tests/checkasm/sw_rgb.c b/tests/checkasm/sw_rgb.c index 7cd815e5be..cc9b957461 100644 --- a/tests/checkasm/sw_r

Re: [FFmpeg-devel] [PATCH 1/5] checkasm/sw_rgb: test rgb24 to yuv

2024-06-04 Thread Zhao Zhili
> On Jun 4, 2024, at 21:58, James Almer wrote: > > On 6/4/2024 10:55 AM, Zhao Zhili wrote: >> From: Zhao Zhili >> --- >> tests/checkasm/sw_rgb.c | 103 >> 1 file changed, 103 insertions(+) >> diff --git a/tests/checkasm/sw_rgb.c b/tests/checkasm/sw_rg

Re: [FFmpeg-devel] [PATCH v4 1/1] avcodec: add external enc libvvenc for H266/VVC

2024-06-04 Thread Christian
> On 4. Jun 2024, at 11:21, Anton Khirnov wrote: > > Quoting Christian Bartnik (2024-05-28 18:26:29) >> +static const AVOption options[] = { >> +{ "passlogfile", "Filename for 2 pass stats", OFFSET(stats), >> AV_OPT_TYPE_STRING, {.str = NULL}, 0, 0, VE}, >> +{ "stats","Filenam

[FFmpeg-devel] [PATCH] bsf: Fix memory leak by adding vp9_raw_reorder_frame_free()

2024-06-04 Thread Jiasheng Jiang
Add vp9_raw_reorder_frame_free() before "ctx->next_frame = NULL;" to avoid memory leak. Fixes: 887a7817b6 ("lavc: move bitstream filters into bsf/ subdir") Signed-off-by: Jiasheng Jiang --- libavcodec/bsf/vp9_raw_reorder.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/bsf/vp9_r

[FFmpeg-devel] [PATCH v6 0/4] doc: Explain what "context" means

2024-06-04 Thread Andrew Sayers
I'm making a list of little documentation patches to submit as a set once this patchset is done. I've put Sw{r,s}Context on the list, and will think about their relationship to other opaque AVOptions-enabled structs as part of that. I don't see anything in that discussion that affects this patchse

[FFmpeg-devel] [PATCH v6 1/4] doc: Explain what "context" means

2024-06-04 Thread Andrew Sayers
Derived from explanations kindly provided by Stefano Sabatini and others: https://ffmpeg.org/pipermail/ffmpeg-devel/2024-April/325903.html --- doc/context.md | 430 + 1 file changed, 430 insertions(+) create mode 100644 doc/context.md diff --git a/

[FFmpeg-devel] [PATCH v6 2/4] lavu: Clarify relationship between AVClass, AVOption and context

2024-06-04 Thread Andrew Sayers
--- libavutil/log.h | 16 +--- libavutil/opt.h | 26 +- 2 files changed, 34 insertions(+), 8 deletions(-) diff --git a/libavutil/log.h b/libavutil/log.h index ab7ceabe22..88b35897c6 100644 --- a/libavutil/log.h +++ b/libavutil/log.h @@ -59,9 +59,19 @@ typedef e

[FFmpeg-devel] [PATCH v6 3/4] all: Link to "context" from all public contexts with documentation

2024-06-04 Thread Andrew Sayers
The goal of putting these links in "@see" blocks is to provide hooks for future developers to add links to other useful parts of the codebase. --- libavcodec/avcodec.h | 3 +++ libavcodec/bsf.h | 3 +++ libavcodec/d3d11va.h | 3 +++ libavcodec/mediacodec.h

[FFmpeg-devel] [PATCH v6 4/4] all: Rewrite documentation for contexts

2024-06-04 Thread Andrew Sayers
Make their documentation more readable and similar to each other, (hopefully) without changing the meaning. --- libavcodec/aac/aacdec.h | 2 +- libavcodec/aacenc.h | 2 +- libavcodec/ac3enc.h | 2 +- libavcodec/amfenc.h | 2 +- libavcodec/atrac.h

Re: [FFmpeg-devel] [RFC] STF 2025

2024-06-04 Thread Andrew Sayers
On Fri, May 17, 2024 at 03:49:58PM +0200, Michael Niedermayer wrote: > Hi all > > Before this is forgotten again, better start some dicsussion too early than > too late Unless there's a better place to put these, I plan to reply to this message whenever I notice someone bring up something that s

Re: [FFmpeg-devel] [RFC] STF 2025

2024-06-04 Thread Cosmin Stejerean via ffmpeg-devel
> On Jun 3, 2024, at 11:53 PM, Vittorio Giovara > wrote: > > On Tue, Jun 4, 2024 at 3:01 AM Cosmin Stejerean via ffmpeg-devel < > ffmpeg-devel@ffmpeg.org> wrote: > >>> Reposting my question/comment here since Thilo hasn't had a chance to >>> respond, but shouldn't these kinds of requests go t

Re: [FFmpeg-devel] [PATCH] x86/aacencdsp: add SSE2 and AVX versions of quantize_bands

2024-06-04 Thread James Almer
On 6/4/2024 3:37 AM, Rémi Denis-Courmont wrote: Le 4 juin 2024 04:23:43 GMT+03:00, James Almer a écrit : quant_bands_signed_sse2: 417.0 quant_bands_signed_avx: 202.0 What about unsigned? Pretty much the same. Will add them before pushing. ___ ff

Re: [FFmpeg-devel] [RFC] STF 2025

2024-06-04 Thread Paul B Mahol
On Tue, Jun 4, 2024 at 2:53 PM Vittorio Giovara wrote: > On Tue, Jun 4, 2024 at 2:02 PM Paul B Mahol wrote: > > > On Tue, Jun 4, 2024 at 12:59 PM Vittorio Giovara < > > vittorio.giov...@gmail.com> > > wrote: > > > > > On Tue, Jun 4, 2024 at 12:09 PM Paul B Mahol wrote: > > > > > > > On Tue, Jun

[FFmpeg-devel] [PATCH] avfilter/trim: flag trim filter as metadata only

2024-06-04 Thread Gyan Doshi
Similar to select filter for video - it can only pass through or drop frames --- libavfilter/trim.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavfilter/trim.c b/libavfilter/trim.c index 4c1a2b4f48..4afc4c74bb 100644 --- a/libavfilter/trim.c +++ b/libavfilter/trim.c @@ -364,6 +364,7 @@

Re: [FFmpeg-devel] [RFC] STF 2025

2024-06-04 Thread Vittorio Giovara
On Tue, Jun 4, 2024 at 7:39 PM Paul B Mahol wrote: > On Tue, Jun 4, 2024 at 2:53 PM Vittorio Giovara < > vittorio.giov...@gmail.com> > wrote: > > > On Tue, Jun 4, 2024 at 2:02 PM Paul B Mahol wrote: > > > > > On Tue, Jun 4, 2024 at 12:59 PM Vittorio Giovara < > > > vittorio.giov...@gmail.com> >

Re: [FFmpeg-devel] [RFC] STF 2025

2024-06-04 Thread Vittorio Giovara
On Tue, Jun 4, 2024 at 5:47 PM Cosmin Stejerean via ffmpeg-devel < ffmpeg-devel@ffmpeg.org> wrote: > > > > On Jun 3, 2024, at 11:53 PM, Vittorio Giovara < > vittorio.giov...@gmail.com> wrote: > > > > On Tue, Jun 4, 2024 at 3:01 AM Cosmin Stejerean via ffmpeg-devel < > > ffmpeg-devel@ffmpeg.org> wr

Re: [FFmpeg-devel] [PATCH 01/10, v3] avutil: add hwcontext_amf.

2024-06-04 Thread Mark Thompson
On 30/05/2024 14:08, Dmitrii Ovchinnikov wrote: > Adds hwcontext_amf, which allows to use shared AMF > context for the encoder, decoder and AMF-based filters, > without copy to the host memory. > It will also allow you to use some optimisations in > the interaction of components (for example, SAV)

[FFmpeg-devel] [PATCHv2 1/4] lavc/vc1dsp: R-V V vc1_inv_trans_8x8

2024-06-04 Thread Rémi Denis-Courmont
T-Head C908 (cycles): vc1dsp.vc1_inv_trans_8x8_c: 871.7 vc1dsp.vc1_inv_trans_8x8_rvv_i32: 286.7 --- Changes since version 1: - Use fixed-point rounding instead of adding 4 or 64 explicitly. --- libavcodec/riscv/vc1dsp_init.c | 2 + libavcodec/riscv/vc1dsp_rvv.S | 110 +++

[FFmpeg-devel] [PATCHv2 2/4] lavc/vc1dsp: R-V V vc1_inv_trans_8x4

2024-06-04 Thread Rémi Denis-Courmont
T-Head C908 (cycles): vc1dsp.vc1_inv_trans_8x4_c: 626.2 vc1dsp.vc1_inv_trans_8x4_rvv_i32: 215.2 --- Changes since version 1: - Properly set VXRM (callee-clobbered). --- libavcodec/riscv/vc1dsp_init.c | 2 + libavcodec/riscv/vc1dsp_rvv.S | 73 ++ 2 files ch

[FFmpeg-devel] [PATCHv2 3/4] lavc/vc1dsp: R-V V vc1_inv_trans_4x8

2024-06-04 Thread Rémi Denis-Courmont
T-Head C908 (cycles): vc1dsp.vc1_inv_trans_4x8_c: 653.2 vc1dsp.vc1_inv_trans_4x8_rvv_i32: 234.0 --- libavcodec/riscv/vc1dsp_init.c | 2 + libavcodec/riscv/vc1dsp_rvv.S | 77 ++ 2 files changed, 79 insertions(+) diff --git a/libavcodec/riscv/vc1dsp_init.c b/libavc

[FFmpeg-devel] [PATCHv2 4/4] lavc/vc1dsp: R-V V vc1_inv_trans_4x4

2024-06-04 Thread Rémi Denis-Courmont
T-Head C908 (cycles): vc1dsp.vc1_inv_trans_4x4_c: 310.7 vc1dsp.vc1_inv_trans_4x4_rvv_i32: 120.0 We could use 1 `vlseg4e64.v` instead of 4 `vle16.v`, but that seems to be about 7% slower. --- libavcodec/riscv/vc1dsp_init.c | 2 ++ libavcodec/riscv/vc1dsp_rvv.S | 47 ++

[FFmpeg-devel] [PATCH] swscale/x86/input: add AVX2 optimized RGB24 to YUV functions

2024-06-04 Thread James Almer
rgb24_to_uv_8_c: 39.3 rgb24_to_uv_8_sse2: 14.3 rgb24_to_uv_8_ssse3: 13.3 rgb24_to_uv_8_avx: 12.8 rgb24_to_uv_8_avx2: 14.3 rgb24_to_uv_128_c: 582.8 rgb24_to_uv_128_sse2: 127.3 rgb24_to_uv_128_ssse3: 107.3 rgb24_to_uv_128_avx: 111.3 rgb24_to_uv_128_avx2: 62.3 rgb24_to_uv_1080_c: 4981.3 rgb24_to_uv_10

Re: [FFmpeg-devel] [PATCH] avfilter/trim: flag trim filter as metadata only

2024-06-04 Thread Stefano Sabatini
On date Tuesday 2024-06-04 23:41:05 +0530, Gyan Doshi wrote: > Similar to select filter for video - it can only pass through or drop frames > --- > libavfilter/trim.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavfilter/trim.c b/libavfilter/trim.c > index 4c1a2b4f48..4afc4c74bb 10

Re: [FFmpeg-devel] [PATCH 02/10, v3] avcodec: add amfdec.

2024-06-04 Thread Mark Thompson
On 30/05/2024 14:08, Dmitrii Ovchinnikov wrote: > From: Evgeny Pavlov > > Added AMF based h264, hevc, av1 decoders. > Co-authored-by: Dmitrii Ovchinnikov > v2: added encoder reinitialisation > v3: use AMF_SURFACE_UNKNOWN to int decoder(ctx->output_format before) > --- > libavcodec/Makefile|

Re: [FFmpeg-devel] [PATCH] swscale/x86/input: add AVX2 optimized RGB24 to YUV functions

2024-06-04 Thread Andreas Rheinhardt
James Almer: > rgb24_to_uv_8_c: 39.3 > rgb24_to_uv_8_sse2: 14.3 > rgb24_to_uv_8_ssse3: 13.3 > rgb24_to_uv_8_avx: 12.8 > rgb24_to_uv_8_avx2: 14.3 Worse than avx and ssse3 > rgb24_to_uv_128_c: 582.8 > rgb24_to_uv_128_sse2: 127.3 > rgb24_to_uv_128_ssse3: 107.3 > rgb24_to_uv_128_avx: 111.3 Worse tha

Re: [FFmpeg-devel] [PATCH] swscale/x86/input: add AVX2 optimized RGB24 to YUV functions

2024-06-04 Thread James Almer
On 6/4/2024 4:25 PM, Andreas Rheinhardt wrote: James Almer: rgb24_to_uv_8_c: 39.3 rgb24_to_uv_8_sse2: 14.3 rgb24_to_uv_8_ssse3: 13.3 rgb24_to_uv_8_avx: 12.8 rgb24_to_uv_8_avx2: 14.3 Worse than avx and ssse3 Can't be disabled for small sizes. rgb24_to_uv_128_c: 582.8 rgb24_to_uv_128_sse2:

Re: [FFmpeg-devel] [PATCH] swscale/x86/input: add AVX2 optimized RGB24 to YUV functions

2024-06-04 Thread Andreas Rheinhardt
James Almer: > On 6/4/2024 4:25 PM, Andreas Rheinhardt wrote: >> James Almer: >>> rgb24_to_uv_8_c: 39.3 >>> rgb24_to_uv_8_sse2: 14.3 >>> rgb24_to_uv_8_ssse3: 13.3 >>> rgb24_to_uv_8_avx: 12.8 >>> rgb24_to_uv_8_avx2: 14.3 >> >> Worse than avx and ssse3 > > Can't be disabled for small sizes. > Why

Re: [FFmpeg-devel] [PATCH] swscale/x86/input: add AVX2 optimized RGB24 to YUV functions

2024-06-04 Thread James Almer
On 6/4/2024 4:32 PM, Andreas Rheinhardt wrote: James Almer: On 6/4/2024 4:25 PM, Andreas Rheinhardt wrote: James Almer: rgb24_to_uv_8_c: 39.3 rgb24_to_uv_8_sse2: 14.3 rgb24_to_uv_8_ssse3: 13.3 rgb24_to_uv_8_avx: 12.8 rgb24_to_uv_8_avx2: 14.3 Worse than avx and ssse3 Can't be disabled for s

[FFmpeg-devel] [PATCH 1/1] sws/input: add R-V V rgb24ToY

2024-06-04 Thread Rémi Denis-Courmont
T-Head C908: rgb24_to_y_8_c:2.0 rgb24_to_y_8_rvv_i32: 3.0 rgb24_to_y_128_c: 26.2 rgb24_to_y_128_rvv_i32: 10.5 rgb24_to_y_1080_c: 235.7 rgb24_to_y_1080_rvv_i32: 102.0 rgb24_to_y_1280_c: 260.0 rgb24_to_y_1280_rvv_i32: 100.2 rgb24_to_y_1920_c: 405.7 rgb24_t

[FFmpeg-devel] [PATCHv2 1/1] sws/input: add R-V V rgb24ToY

2024-06-04 Thread Rémi Denis-Courmont
T-Head C908: rgb24_to_y_8_c:2.0 rgb24_to_y_8_rvv_i32: 2.7 rgb24_to_y_128_c: 26.2 rgb24_to_y_128_rvv_i32:9.2 rgb24_to_y_1080_c: 219.5 rgb24_to_y_1080_rvv_i32: 76.2 rgb24_to_y_1280_c: 276.2 rgb24_to_y_1280_rvv_i32: 89.7 rgb24_to_y_1920_c: 389.7 rgb24_t

Re: [FFmpeg-devel] [PATCH 5/5] avutil/aarch64: Fallback to clock_gettime as timer on Android

2024-06-04 Thread Martin Storsjö
On Tue, 4 Jun 2024, Zhao Zhili wrote: From: Zhao Zhili The inline asm doesn't work on Android. Using pmccntr_el0 doen't work, no, but instead of falling back to clock_gettime, you may want to use cntvct_el0 instead of pmccntr_el0. IIRC that works on Android, at least it worked a number of

Re: [FFmpeg-devel] [RFC] STF 2025

2024-06-04 Thread Michael Niedermayer
On Tue, Jun 04, 2024 at 08:24:57PM +0200, Vittorio Giovara wrote: > On Tue, Jun 4, 2024 at 5:47 PM Cosmin Stejerean via ffmpeg-devel < > ffmpeg-devel@ffmpeg.org> wrote: > > > > > > > > On Jun 3, 2024, at 11:53 PM, Vittorio Giovara < > > vittorio.giov...@gmail.com> wrote: > > > > > > On Tue, Jun 4,

Re: [FFmpeg-devel] [RFC] STF 2025

2024-06-04 Thread Vittorio Giovara
On Tue, Jun 4, 2024 at 11:22 PM Michael Niedermayer wrote: > > Sure I'm happy to work on this with you! Let's talk offline about it > > Why should discussions about a FFmpeg booth be offline ? > That's a great question, CC-ing Thilo about it. -- Vittorio

[FFmpeg-devel] New CC member: Steven Liu

2024-06-04 Thread Ronald S. Bultje
Hi all, Anton resigned from the CC [1], leaving an empty spot. The remaining members of the CC agreed it would be best to fill the spot with the next runner-up from the last CC Elections. The last CC election results [2] had Steven Liu as next runner-up, so we've asked him to fill Anton's spot for

Re: [FFmpeg-devel] [PATCH v6 2/2] lavc/dxvenc: migrate DXT1 encoder to lavu hashtable

2024-06-04 Thread Michael Niedermayer
On Mon, Jun 03, 2024 at 10:39:04PM -0700, Connor Worley wrote: > Offers a modest performance gain due to the switch from naive linear > probling to robin hood. > > Signed-off-by: Connor Worley > --- > libavcodec/dxvenc.c | 119 > 1 file changed, 32 in

Re: [FFmpeg-devel] [PATCH] avcodec/mpegvideo_enc: give magic number a name

2024-06-04 Thread Michael Niedermayer
On Tue, Jun 04, 2024 at 03:05:35PM +0200, Ramiro Polla wrote: > --- > libavcodec/mpegvideo_enc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) LGTM thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Into a blind darkness they enter who follow after

Re: [FFmpeg-devel] [PATCH] Add extra const to FF_PFNGLSHADERSOURCEPROC.

2024-06-04 Thread Billy O'Neal (VC AIR) via ffmpeg-devel
Makes sense. I'm validating that a patch with the #ifdef succeeds and will attempt to add it as a reply if that works. I apologize for my misunderstanding of the situation, and the horrible Outlook signature. (And in advance if my git format-patch use afterwards accidentally makes a new thread r

[FFmpeg-devel] [PATCH 4/4] lavc: bump minor and add APIchanges entry for new USAC profile

2024-06-04 Thread Lynne via ffmpeg-devel
--- doc/APIchanges | 3 +++ libavcodec/version.h | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/doc/APIchanges b/doc/APIchanges index e36a01336c..d9bec790a3 100644 --- a/doc/APIchanges +++ b/doc/APIchanges @@ -2,6 +2,9 @@ The last version increases of all libraries wer

[FFmpeg-devel] [PATCH 1/4] mpeg4audio: rename AOT_USAC_NOSBR to AOT_USAC

2024-06-04 Thread Lynne via ffmpeg-devel
The issue is that AOT 45 isn't defined anywhere, and looking at the git blame, it seems to have sprung up through a reordering of the enum, and adding a hole. The spec does not define an explicit AOT for SBR and no SBR, and only uses AOT 42 (previously AOT_USAC_NOSBR), so just rename AOT_USAC to i

[FFmpeg-devel] [PATCH 3/4] aac: define a new profile for USAC

2024-06-04 Thread Lynne via ffmpeg-devel
This allows users to determine whether a stream is USAC or not. --- libavcodec/aac/aacdec_usac.c | 4 libavcodec/avcodec.h | 1 + libavcodec/defs.h| 1 + libavcodec/profiles.c| 1 + libavcodec/profiles.h| 1 + 5 files changed, 8 insertions(+) diff --git a/

[FFmpeg-devel] [PATCH 2/4] mpeg4audio: explicitly define each AOT

2024-06-04 Thread Lynne via ffmpeg-devel
This makes it far easier to figure out which AOT belongs to which profile. Also, explicitly highlight the holes. --- libavcodec/mpeg4audio.h | 82 + 1 file changed, 42 insertions(+), 40 deletions(-) diff --git a/libavcodec/mpeg4audio.h b/libavcodec/mpeg4aud

Re: [FFmpeg-devel] [PATCH] Add extra const to FF_PFNGLSHADERSOURCEPROC.

2024-06-04 Thread Billy O'Neal (VC AIR) via ffmpeg-devel
Resolves the following compiler error on macOS 14.5: ```console /Library/Developer/CommandLineTools/SDKs/MacOSX14.4.sdk/System/Library/Frameworks/OpenGL.framework/Headers/gl3.h:1891:21: note: 'glShaderSource' has been explicitly marked deprecated here GLAPI void APIENTRY glShaderSource (GLuint sh

Re: [FFmpeg-devel] [PATCH 3/4] aac: define a new profile for USAC

2024-06-04 Thread Andreas Rheinhardt
Lynne via ffmpeg-devel: > This allows users to determine whether a stream is USAC or not. > --- > libavcodec/aac/aacdec_usac.c | 4 > libavcodec/avcodec.h | 1 + > libavcodec/defs.h| 1 + > libavcodec/profiles.c| 1 + > libavcodec/profiles.h| 1 + > 5 files

Re: [FFmpeg-devel] [PATCH 2/5] swscale/aarch64: Add rgb24 to yuv implementation

2024-06-04 Thread Rémi Denis-Courmont
Le 4 juin 2024 16:55:01 GMT+03:00, Zhao Zhili a écrit : >From: Zhao Zhili > >Test on Apple M1: > >rgb24_to_uv_1080_c: 7.2 >rgb24_to_uv_1080_neon: 5.5 >rgb24_to_uv_1280_c: 8.2 >rgb24_to_uv_1280_neon: 6.2 >rgb24_to_uv_1920_c: 12.5 >rgb24_to_uv_1920_neon: 9.5 > >rgb24_to_uv_half_540_c: 6.5 >rgb24_

Re: [FFmpeg-devel] [PATCH 2/5] swscale/aarch64: Add rgb24 to yuv implementation

2024-06-04 Thread Zhao Zhili
> On Jun 5, 2024, at 14:29, Rémi Denis-Courmont wrote: > > > > Le 4 juin 2024 16:55:01 GMT+03:00, Zhao Zhili > a écrit : >> From: Zhao Zhili >> >> Test on Apple M1: >> >> rgb24_to_uv_1080_c: 7.2 >> rgb24_to_uv_1080_neon: 5.5 >> rgb24_to_uv_1280_c: 8.2 >> rgb