Re: [FFmpeg-devel] [PATCH] lavfi/vaapi: Don't use fixed-size frame pools

2024-02-26 Thread Xiang, Haihao
On Ma, 2024-02-26 at 06:11 +, Xiang, Haihao wrote: > On So, 2024-02-25 at 19:51 +, Mark Thompson wrote: > > Since e0da916b8f5b079a4865eef7f64863f50785463d the ffmpeg utility has > > held multiple frames output by the filter graph in internal queues > > without telling the filter which creat

Re: [FFmpeg-devel] [PATCH v5 4/9] avcodec/vaapi_encode: extract rc parameter configuration to base layer

2024-02-26 Thread Wu, Tong1
>-Original Message- >From: ffmpeg-devel On Behalf Of Mark >Thompson >Sent: Friday, February 23, 2024 3:22 AM >To: ffmpeg-devel@ffmpeg.org >Subject: Re: [FFmpeg-devel] [PATCH v5 4/9] avcodec/vaapi_encode: extract rc >parameter configuration to base layer > >On 22/02/2024 10:10, Wu, Tong1 wr

Re: [FFmpeg-devel] [PATCH v2] avcodec/h2645_sei: validate Mastering Display Colour Volume SEI values

2024-02-26 Thread Niklas Haas
On Sun, 25 Feb 2024 03:17:55 +0100 Kacper Michajłow wrote: > -av_log(avctx, AV_LOG_DEBUG, "Mastering Display Metadata:\n"); > -av_log(avctx, AV_LOG_DEBUG, > - "r(%5.4f,%5.4f) g(%5.4f,%5.4f) b(%5.4f %5.4f) wp(%5.4f, > %5.4f)\n", > - av_q2d(metadata->disp

[FFmpeg-devel] [PATCH v3] avcodec/h2645_sei: validate Mastering Display Colour Volume SEI values

2024-02-26 Thread Kacper Michajłow
As we can read in ST 2086: Values outside the specified ranges of luminance and chromaticity values are not reserved by SMPTE, and can be used for purposes outside the scope of this standard. This is further acknowledged by ITU-T H.264 and ITU-T H.265. Which says that values out of range are unkn

[FFmpeg-devel] [PATCH] avfilter/ff_filter_frame_framed: Fix setting up filter frame

2024-02-26 Thread Hanna Ciebiera
Up to now filter_frame was incorrectly set up to dst->filter_frame in if statement. It was causing conversion failure during the transcoding. Now, when condition in if statement is met filter_frame is set up to default_filter_frame. Signed-off-by: Hanna Ciebiera --- libavfilter/avfilter.c | 2

Re: [FFmpeg-devel] [PATCH] avfilter/ff_filter_frame_framed: Fix setting up filter frame

2024-02-26 Thread Nicolas George
Hanna Ciebiera (12024-02-26): > Up to now filter_frame was incorrectly set up to dst->filter_frame in > if statement. It was causing conversion failure during the > transcoding. > Now, when condition in if statement is met filter_frame is set up to > default_filter_frame. > > Signed-off-by: Hanna

Re: [FFmpeg-devel] [PATCH] avcodec/x86/hevc: fix luma 12b overflow

2024-02-26 Thread J. Dekker
"Ronald S. Bultje" writes: > > New version attached. > Thanks for the help, pushed this along with the test. -- jd ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link abov

Re: [FFmpeg-devel] [RFC] fateserver

2024-02-26 Thread Michael Niedermayer
Hi On Sun, Feb 25, 2024 at 06:21:14PM -0600, Marth64 wrote: > Thank you Michael, for the opportunity. I have some initial questions > while others add the remaining detail. > [...] > 2) Are you open to Docker containerization (with rootless)? In this way, > the application is jailed and can rest

Re: [FFmpeg-devel] [PATCH v2 1/3] checkasm/hevc_deblock: add luma and chroma full

2024-02-26 Thread J. Dekker
"J. Dekker" writes: > Signed-off-by: J. Dekker > --- > tests/checkasm/hevc_deblock.c | 246 +- > 1 file changed, 215 insertions(+), 31 deletions(-) Pushed this along with Ronald's patch to fix x86. Have some minor improvements for the 12bit arm64 version local

[FFmpeg-devel] [PATCH 1/4] avcodec/aom_film_grain: add AOM film grain synthesis

2024-02-26 Thread Niklas Haas
From: Niklas Haas Implementation copied wholesale from dav1d, sans SIMD, under permissive license. This implementation was extensively verified to be bit-exact, so it serves as a much better starting point than trying to re-engineer this from scratch for no reason. (I also authored the original i

[FFmpeg-devel] [PATCH 2/4] avcodec/aom_film_grain: implement AFGS1

2024-02-26 Thread Niklas Haas
From: Niklas Haas Based on the AOMedia Film Grain Synthesis 1 (AFGS1) spec: https://aomediacodec.github.io/afgs1-spec/ The parsing has been changed substantially relative to the AV1 film grain OBU. In particular: 1. There is the possibility of maintaining multiple independent film grain pa

[FFmpeg-devel] [PATCH 3/4] avcodec/h2645_sei: decode AFGS1 T.35 SEI

2024-02-26 Thread Niklas Haas
From: Niklas Haas I restricted this SEI to HEVC for now, until I see a H.264 sample. --- libavcodec/Makefile| 2 +- libavcodec/h2645_sei.c | 38 ++ libavcodec/h2645_sei.h | 3 +++ 3 files changed, 42 insertions(+), 1 deletion(-) diff --git a/libavcodec/

[FFmpeg-devel] [PATCH 4/4] avcodec/hevcdec: apply AOM film grain synthesis

2024-02-26 Thread Niklas Haas
From: Niklas Haas Following the usual logic for H.274 film grain. --- libavcodec/Makefile | 2 +- libavcodec/hevcdec.c | 24 2 files changed, 21 insertions(+), 5 deletions(-) diff --git a/libavcodec/Makefile b/libavcodec/Makefile index d86b4018405..440179ac797 100644

Re: [FFmpeg-devel] [PATCH 6/8] avcodec/aacsbr_template: Avoid using AACDecContext; pass logctx directly

2024-02-26 Thread Lynne
Feb 26, 2024, 02:25 by andreas.rheinha...@outlook.com: > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/aacsbr_template.c | 131 ++- > 1 file changed, 66 insertions(+), 65 deletions(-) > > diff --git a/libavcodec/aacsbr_template.c b/libavcodec/aacsbr_template.

Re: [FFmpeg-devel] [PATCH v2 1/2] avdevice: deprecate opengl outdev

2024-02-26 Thread Anton Khirnov
Quoting Lynne (2024-02-21 13:32:19) > Feb 21, 2024, 12:34 by j...@itanimul.li: > > > Signed-off-by: J. Dekker > > --- > > doc/outdevs.texi| 2 +- > > libavdevice/opengl_enc.c| 11 +++ > > libavdevice/version_major.h | 2 ++ > > 3 files changed, 14 insertions(+), 1 delet

Re: [FFmpeg-devel] [PATCH v10 2/5] libavcodec/webp: add support for animated WebP

2024-02-26 Thread Thilo Borgmann via ffmpeg-devel
Am 19.02.24 um 19:01 schrieb Andreas Rheinhardt: James Almer: On 2/19/2024 1:50 PM, Andreas Rheinhardt wrote: a) Use the receive frame callback for this decoder. This will necessitate changes to pthread_frame.c (which currently can't handle receive_frame decoders) There's a patch for this tha

Re: [FFmpeg-devel] [PATCH v10 2/5] libavcodec/webp: add support for animated WebP

2024-02-26 Thread Thilo Borgmann via ffmpeg-devel
Hi, Am 19.02.24 um 17:50 schrieb Andreas Rheinhardt: Thilo Borgmann via ffmpeg-devel: From: Josef Zlomek Fixes: 4907 Adds support for decoding of animated WebP. The WebP decoder adds the animation related features according to the specs: https://developers.google.com/speed/webp/docs/riff_co

[FFmpeg-devel] [PATCH 1/3] lavc/vp9dsp: R-V V ipred vert

2024-02-26 Thread flow gg
From 54d784dfd5d0d04456164f250766a3620d42c8c2 Mon Sep 17 00:00:00 2001 From: sunyuechi Date: Mon, 26 Feb 2024 14:42:17 +0800 Subject: [PATCH 1/3] lavc/vp9dsp: R-V V ipred vert C908 vp9_vert_16x16_8bpp_c: 80.2 vp9_vert_16x16_8bpp_rvv_i32: 55.7 vp9_vert_32x32_8bpp_c: 308.2 vp9_vert_32x32_8bpp_rvv_

[FFmpeg-devel] [PATCH 2/3] lavc/vp9dsp: R-V V ipred hor

2024-02-26 Thread flow gg
From e791fada3a4777fae87dec806c0b46b595d265db Mon Sep 17 00:00:00 2001 From: sunyuechi Date: Tue, 27 Feb 2024 00:06:25 +0800 Subject: [PATCH 2/3] lavc/vp9dsp: R-V V ipred hor C908: vp9_hor_4x4_8bpp_c: 37.7 vp9_hor_4x4_8bpp_rvv_i32: 33.7 vp9_hor_8x8_8bpp_c: 82.7 vp9_hor_8x8_8bpp_rvv_i32: 51.5 vp9

[FFmpeg-devel] [PATCH 3/3] lavc/vp9dsp: R-V V ipred dc dc_left dc_top

2024-02-26 Thread flow gg
From 1a83f04530e3c299b28bd56dd10694aaa6b963d7 Mon Sep 17 00:00:00 2001 From: sunyuechi Date: Tue, 27 Feb 2024 00:07:08 +0800 Subject: [PATCH 3/3] lavc/vp9dsp: R-V V ipred dc dc_left dc_top C908: vp9_dc_16x16_8bpp_c: 117.0 vp9_dc_16x16_8bpp_rvv_i32: 81.7 vp9_dc_32x32_8bpp_c: 373.2 vp9_dc_32x32_8b

Re: [FFmpeg-devel] [RFC] clarifying the TC conflict of interest rule

2024-02-26 Thread Anton Khirnov
Quoting Ronald S. Bultje (2024-02-23 20:36:11) > Hi Nicolas > > On Fri, Feb 23, 2024 at 2:56 AM Nicolas George wrote: > > > Anton Khirnov (12024-02-22): > > > In my updated proposal, based on comments by Niklas and Rémi, I'm > > > leaving it up to the TC member in question, based on the assumpti

Re: [FFmpeg-devel] [PATCH v2 1/2] avdevice: deprecate opengl outdev

2024-02-26 Thread Jan Ekström
On Wed, Feb 21, 2024 at 1:34 PM J. Dekker wrote: > > Signed-off-by: J. Dekker > --- > doc/outdevs.texi| 2 +- > libavdevice/opengl_enc.c| 11 +++ > libavdevice/version_major.h | 2 ++ > 3 files changed, 14 insertions(+), 1 deletion(-) As during FOSDEM there seemed to b

Re: [FFmpeg-devel] [RFC] clarifying the TC conflict of interest rule

2024-02-26 Thread Anton Khirnov
Hi Michael, Quoting Michael Niedermayer (2024-02-24 00:27:08) > On Thu, Feb 22, 2024 at 10:14:20PM +0100, Anton Khirnov wrote: > > Quoting Niklas Haas (2024-02-20 21:50:33) > > > On Tue, 20 Feb 2024 09:50:33 +0100 Anton Khirnov > > > wrote: > > > > + Each TC member must vote on such decision acco

Re: [FFmpeg-devel] [PATCH] avutil/mem: limit alignment to maximum simd align

2024-02-26 Thread Timo Rothenpieler
On 11/02/2024 18:40, Timo Rothenpieler wrote: FFmpeg has instances of DECLARE_ALIGNED(32, ...) in a lot of structs, which then end up heap-allocated. By declaring any variable in a struct, or tree of structs, to be 32 byte aligned, it allows the compiler to safely assume the entire struct itself

Re: [FFmpeg-devel] [PATCH 16/38] lavc: add a decoder option for configuring side data preference

2024-02-26 Thread Anton Khirnov
Quoting James Almer (2024-02-23 19:34:51) > Actually no, it'd be 32 since _FLAGS expects an unsigned int. And we currently have 36 packet side data types. Now this option can only apply to some of them, but then we'd have to introduce some kind a of a complicated mapping scheme, and we still end

Re: [FFmpeg-devel] [PATCH 15/38] lavu/opt: add array options

2024-02-26 Thread Anton Khirnov
Quoting Marton Balint (2024-02-23 20:05:06) > > > On Fri, 23 Feb 2024, Anton Khirnov wrote: > > > AVOption.array_max_size is added before AVOption.unit to avoid > > increasing sizeof(AVOption). > > --- > > doc/APIchanges| 3 + > > libavutil/opt.c | 344

Re: [FFmpeg-devel] [PATCH 15/38] lavu/opt: add array options

2024-02-26 Thread Andreas Rheinhardt
Anton Khirnov: > Quoting Marton Balint (2024-02-23 20:05:06) >> >> >> On Fri, 23 Feb 2024, Anton Khirnov wrote: >> >>> AVOption.array_max_size is added before AVOption.unit to avoid >>> increasing sizeof(AVOption). >>> --- >>> doc/APIchanges| 3 + >>> libavutil/opt.c | 344 ++

Re: [FFmpeg-devel] [PATCH 15/38] lavu/opt: add array options

2024-02-26 Thread James Almer
On 2/26/2024 2:14 PM, Anton Khirnov wrote: Quoting Marton Balint (2024-02-23 20:05:06) On Fri, 23 Feb 2024, Anton Khirnov wrote: AVOption.array_max_size is added before AVOption.unit to avoid increasing sizeof(AVOption). --- doc/APIchanges| 3 + libavutil/opt.c | 344 +

Re: [FFmpeg-devel] [RFC] clarifying the TC conflict of interest rule

2024-02-26 Thread Ronald S. Bultje
Hi, On Mon, Feb 26, 2024 at 11:34 AM Anton Khirnov wrote: > Quoting Ronald S. Bultje (2024-02-23 20:36:11) > > Hi Nicolas > > > > On Fri, Feb 23, 2024 at 2:56 AM Nicolas George wrote: > > > > > Anton Khirnov (12024-02-22): > > > > In my updated proposal, based on comments by Niklas and Rémi, I'

[FFmpeg-devel] [PATCH] avformat/webvttdec: Skip more parts of header to let parsing continue

2024-02-26 Thread Kristoffer Brånemyr via ffmpeg-devel
Hi, Here is a short patch to skip more parts of the header for the WebVTT subtitle format. Without this the parser seems to stop and no subtitles are produced for the user.You can find the WebVTT specification here: WebVTT: The Web Video Text Tracks Format | | | | | | | | | | | WebV

Re: [FFmpeg-devel] [RFC] clarifying the TC conflict of interest rule

2024-02-26 Thread Anton Khirnov
Quoting Ronald S. Bultje (2024-02-26 19:12:45) > That's essentially what I was suggesting: run a GA vote on your proposed > amendment, and then run a separate GA vote on Nicolas' proposed amendment. They don't seem orthogonal to me though, they both replace the same disputed line and seem pretty m

Re: [FFmpeg-devel] [PATCH 15/38] lavu/opt: add array options

2024-02-26 Thread Marton Balint
On Mon, 26 Feb 2024, Anton Khirnov wrote: Quoting Marton Balint (2024-02-23 20:05:06) On Fri, 23 Feb 2024, Anton Khirnov wrote: AVOption.array_max_size is added before AVOption.unit to avoid increasing sizeof(AVOption). --- doc/APIchanges| 3 + libavutil/opt.c | 344 ++

Re: [FFmpeg-devel] [RFC] clarifying the TC conflict of interest rule

2024-02-26 Thread Ronald S. Bultje
Hi, On Mon, Feb 26, 2024 at 2:17 PM Anton Khirnov wrote: > Quoting Ronald S. Bultje (2024-02-26 19:12:45) > > That's essentially what I was suggesting: run a GA vote on your proposed > > amendment, and then run a separate GA vote on Nicolas' proposed > amendment. > > They don't seem orthogonal t

Re: [FFmpeg-devel] [RFC] clarifying the TC conflict of interest rule

2024-02-26 Thread Anton Khirnov
Quoting Ronald S. Bultje (2024-02-26 20:48:03) > Hi, > > On Mon, Feb 26, 2024 at 2:17 PM Anton Khirnov wrote: > > > Quoting Ronald S. Bultje (2024-02-26 19:12:45) > > > That's essentially what I was suggesting: run a GA vote on your proposed > > > amendment, and then run a separate GA vote on Ni

Re: [FFmpeg-devel] [RFC] clarifying the TC conflict of interest rule

2024-02-26 Thread Rémi Denis-Courmont
Le maanantaina 26. helmikuuta 2024, 21.48.03 EET Ronald S. Bultje a écrit : > Hi, > > On Mon, Feb 26, 2024 at 2:17 PM Anton Khirnov wrote: > > Quoting Ronald S. Bultje (2024-02-26 19:12:45) > > > > > That's essentially what I was suggesting: run a GA vote on your proposed > > > amendment, and th

Re: [FFmpeg-devel] [RFC] clarifying the TC conflict of interest rule

2024-02-26 Thread Nicolas George
Ronald S. Bultje (12024-02-23): > I think you and Anton are trying to fix different issues. Indeed. In fact, our proposals are exactly opposite. Anton's proposal defangs the rule completely, emptying it from all authority, allowing members of the TC to boss other developers around. My proposal s

Re: [FFmpeg-devel] FFmpeg 7.0 blocking issues

2024-02-26 Thread Michael Niedermayer
On Sun, Feb 25, 2024 at 08:20:13PM -0300, James Almer wrote: > On 2/25/2024 8:18 PM, Michael Niedermayer wrote: > > Hi all > > > > about a month has passed > > wanted to remind that we seem to have 2 blocking issues on trac > > > > #10826 Short trim inside filter_complex leads to empty outpu

[FFmpeg-devel] [PATCH 1/2] avformat/mov: Don't zero twice

2024-02-26 Thread Andreas Rheinhardt
Redundant since eee3b7e2fb0664b889e58c03f76e19ef23e4d1d8. Signed-off-by: Andreas Rheinhardt --- libavformat/mov.c | 4 1 file changed, 4 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index effa46120f..d81e34d100 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -4

[FFmpeg-devel] [PATCH 2/2] avformat/mov: Don't use entry[-1] in pointer arithmetic

2024-02-26 Thread Andreas Rheinhardt
It is undefined behaviour. Fixes many failed tests with UBSan and GCC 13 like "src/libavformat/mov.c:4229:44: runtime error: store to address 0x5572abe20f80 with insufficient space for an object of type 'struct MOVIndexRange'" (The line number does not refer to the line where &entry[-1] is assigned

Re: [FFmpeg-devel] [PATCH 1/2] avformat/mov: Don't zero twice

2024-02-26 Thread James Almer
On 2/26/2024 6:45 PM, Andreas Rheinhardt wrote: Redundant since eee3b7e2fb0664b889e58c03f76e19ef23e4d1d8. Signed-off-by: Andreas Rheinhardt --- libavformat/mov.c | 4 1 file changed, 4 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index effa46120f..d81e34d100 100644 -

Re: [FFmpeg-devel] [PATCH] avformat/mov: avoid seeking back to 0 on HEVC open GOP files

2024-02-26 Thread llyyr
On 9/23/23 16:40, llyyr wrote: ab77b878f1 attempted to fix the issue of broken packets being sent to the decoder by implementing logic that kept attempting to PTS-step backwards until it reached a valid point, however applying this heuristic meant that in files that had no valid points (such as H

[FFmpeg-devel] [PATCH v2 1/2] Revert "avformat/mov: zero initialize the index ranges buffer"

2024-02-26 Thread Andreas Rheinhardt
This reverts commit eee3b7e2fb0664b889e58c03f76e19ef23e4d1d8. It has been made in an attempt to fix UBSan test failures with GCC 13 (see e.g. [1]), but it did not help at all. So revert it, but use av_malloc_array() instead of going back to av_malloc(). [1]: https://fate.ffmpeg.org/report.cgi?slo

Re: [FFmpeg-devel] [PATCH v2 1/2] Revert "avformat/mov: zero initialize the index ranges buffer"

2024-02-26 Thread James Almer
On 2/26/2024 7:11 PM, Andreas Rheinhardt wrote: This reverts commit eee3b7e2fb0664b889e58c03f76e19ef23e4d1d8. It has been made in an attempt to fix UBSan test failures with GCC 13 (see e.g. [1]), but it did not help at all. So revert it, but use av_malloc_array() instead of going back to av_mallo

[FFmpeg-devel] [PATCH v2 2/2] avformat/mov: Don't use entry[-1] in pointer arithmetic

2024-02-26 Thread Andreas Rheinhardt
It is undefined behaviour. Fixes many failed tests with UBSan and GCC 13 like "src/libavformat/mov.c:4229:44: runtime error: store to address 0x5572abe20f80 with insufficient space for an object of type 'struct MOVIndexRange'" (The line number does not refer to the line where &entry[-1] is assigned

Re: [FFmpeg-devel] [PATCH 2/4] swresample/resample: rework resample_one function to work the same way as the others

2024-02-26 Thread Michael Niedermayer
On Mon, Feb 26, 2024 at 01:45:23AM +0100, Marton Balint wrote: > This also fixes resampling with filter_size=1 and phase_shift=0, depending on > input chunk size noticable corrpution was hearable with this command line: > > ffplay -f lavfi -i > "sine=440:r=8000:samples_per_frame=32,aresample=2400

Re: [FFmpeg-devel] [PATCH v4 0/4] Fix some active sequences in subtitles

2024-02-26 Thread Oneric
ping I forgot to again add a description to v4 so: These small patches fix several mis-conversions for subtitles (and additionally one cde cleanup in avcodec/ass.c): - WebVTT files no longer get their BiDi marks stripped (which mangled BiDi text) - backslashes are no longer duplicated for no

Re: [FFmpeg-devel] [PATCH v2 2/2] avformat/mov: Don't use entry[-1] in pointer arithmetic

2024-02-26 Thread James Almer
On 2/26/2024 7:15 PM, Andreas Rheinhardt wrote: It is undefined behaviour. Fixes many failed tests with UBSan and GCC 13 like "src/libavformat/mov.c:4229:44: runtime error: store to address 0x5572abe20f80 with insufficient space for an object of type 'struct MOVIndexRange'" (The line number does

[FFmpeg-devel] [PATCH] avcodec/intrax8: Fix assert

2024-02-26 Thread Andreas Rheinhardt
Commit 900ce6f8c3526f27173057bb955f54f4f4f41246 replaced IntraX8Context.ac_vlc by IntraX8Context.ac_vlc_table, but forgot to update an av_assert2()*. cf7ed01938a4d8b2ccd28f1fadacd79103e54eed then replaced this with a check for j_ac_vlc[mode], but this makes no sense as j_ac_vlc is of type const VLC

[FFmpeg-devel] [PATCH 1/3] doc/community: Vote in the interest of the project (first part of Antons proposal)

2024-02-26 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- doc/community.texi | 2 ++ 1 file changed, 2 insertions(+) diff --git a/doc/community.texi b/doc/community.texi index 90d2b6f366..8a38c6aca0 100644 --- a/doc/community.texi +++ b/doc/community.texi @@ -82,6 +82,8 @@ The TC has 2 modes of operation: a RFC on

[FFmpeg-devel] [PATCH 2/3] doc/community: Conflict of interest recusal requirement (Similar to mid part of Antons proposal)

2024-02-26 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- doc/community.texi | 3 +++ 1 file changed, 3 insertions(+) diff --git a/doc/community.texi b/doc/community.texi index 8a38c6aca0..fc22a8fa61 100644 --- a/doc/community.texi +++ b/doc/community.texi @@ -84,6 +84,9 @@ If the TC thinks it needs the input from

[FFmpeg-devel] [PATCH 3/3] doc/community: presumed conflict of interest (similar to antons last part of his proposal)

2024-02-26 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- doc/community.texi | 3 +++ 1 file changed, 3 insertions(+) diff --git a/doc/community.texi b/doc/community.texi index fc22a8fa61..aa68b5f97b 100644 --- a/doc/community.texi +++ b/doc/community.texi @@ -87,6 +87,9 @@ Each TC member must vote on such decisio

Re: [FFmpeg-devel] [RFC] clarifying the TC conflict of interest rule

2024-02-26 Thread Michael Niedermayer
On Mon, Feb 26, 2024 at 05:52:56PM +0100, Anton Khirnov wrote: > Hi Michael, > Quoting Michael Niedermayer (2024-02-24 00:27:08) > > On Thu, Feb 22, 2024 at 10:14:20PM +0100, Anton Khirnov wrote: > > > Quoting Niklas Haas (2024-02-20 21:50:33) > > > > On Tue, 20 Feb 2024 09:50:33 +0100 Anton Khirno

[FFmpeg-devel] [PATCH v3] avformat/mov: Don't use entry[-1] in pointer arithmetic

2024-02-26 Thread Andreas Rheinhardt
It is undefined behaviour. Fixes many failed tests with UBSan and GCC 13 like "src/libavformat/mov.c:4229:44: runtime error: store to address 0x5572abe20f80 with insufficient space for an object of type 'struct MOVIndexRange'" (The line number does not refer to the line where &entry[-1] is assigned

Re: [FFmpeg-devel] [PATCH 6/8] avcodec/aacsbr_template: Avoid using AACDecContext; pass logctx directly

2024-02-26 Thread Andreas Rheinhardt
Lynne: > Feb 26, 2024, 02:25 by andreas.rheinha...@outlook.com: > >> Signed-off-by: Andreas Rheinhardt >> --- >> libavcodec/aacsbr_template.c | 131 ++- >> 1 file changed, 66 insertions(+), 65 deletions(-) >> >> diff --git a/libavcodec/aacsbr_template.c b/libavcodec

[FFmpeg-devel] [PATCH] avcodec/dxvenc: Use proper alignment, write endian-independent output

2024-02-26 Thread Andreas Rheinhardt
Fixes the dxv3enc-dxt1 FATE test with UBSan. Signed-off-by: Andreas Rheinhardt --- I have not actually tested whether the output is actually wrong on BE systems. Would be nice if someone could. libavcodec/dxvenc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcode

Re: [FFmpeg-devel] [PATCH v3] avformat/mov: Don't use entry[-1] in pointer arithmetic

2024-02-26 Thread James Almer
On 2/26/2024 8:27 PM, Andreas Rheinhardt wrote: It is undefined behaviour. Fixes many failed tests with UBSan and GCC 13 like "src/libavformat/mov.c:4229:44: runtime error: store to address 0x5572abe20f80 with insufficient space for an object of type 'struct MOVIndexRange'" (The line number does

[FFmpeg-devel] [PATCH] mov: parse track-based udta name tags

2024-02-26 Thread Водянников А . В . via ffmpeg-devel
>From 1833111ec9fe0350e9cf206bb33ca573b6b8c4b5 Mon Sep 17 00:00:00 2001 From: Aleksoid Date: Sun, 25 Feb 2024 11:59:03 +1000 Subject: [PATCH] mov: parse track-based udta name tags Signed-off-by: Aleksoid --- libavformat/mov.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-

Re: [FFmpeg-devel] [PATCH v2 1/2] avdevice: deprecate opengl outdev

2024-02-26 Thread Zhao Zhili
> 在 2024年2月27日,上午12:47,Jan Ekström 写道: > > On Wed, Feb 21, 2024 at 1:34 PM J. Dekker wrote: >> >> Signed-off-by: J. Dekker >> --- >> doc/outdevs.texi| 2 +- >> libavdevice/opengl_enc.c| 11 +++ >> libavdevice/version_major.h | 2 ++ >> 3 files changed, 14 insertions(+)

[FFmpeg-devel] [PATCH 1/2] avcodec/vaapi_encode_h264: use is_reference to fill reference_pic_flag

2024-02-26 Thread tong1 . wu-at-intel . com
From: Tong Wu This codec supports FLAG_B_PICTURE_REFERENCES. We need to correctly fill the reference_pic_flag with is_reference variable instead of 0 for B frames. Signed-off-by: Tong Wu --- libavcodec/vaapi_encode_h264.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/liba

[FFmpeg-devel] [PATCH 2/2] avcodec/vaapi_encode_h265: use is_reference to fill reference_pic_flag

2024-02-26 Thread tong1 . wu-at-intel . com
From: Tong Wu This codec supports FLAG_B_PICTURE_REFERENCES. We need to fill reference_pic_flag with pic->is_reference. Signed-off-by: Tong Wu --- libavcodec/vaapi_encode_h265.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavcodec/vaapi_encode_h265.c b/libavco

Re: [FFmpeg-devel] [PATCH] lavc/qsvenc: update the selection of bitrate control method

2024-02-26 Thread Xiang, Haihao
On Do, 2024-02-08 at 15:39 +0800, Xiang, Haihao wrote: > From: Haihao Xiang > > The default method is changed to CQP > > Signed-off-by: Haihao Xiang > --- >  Changelog |  1 + >  doc/encoders.texi |  7 +++-- >  libavcodec/qsvenc.c   | 59 +++---

Re: [FFmpeg-devel] [PATCH] lavc/vvc: Correct sps_num_subpics_minus1 minimum

2024-02-26 Thread Nuo Mi
On Mon, Feb 26, 2024 at 5:20 AM Frank Plowman wrote: > On 25/02/2024 19:50, James Almer wrote: > > On 2/25/2024 2:51 PM, Frank Plowman wrote: > >> The spec says "the value of sps_num_subpics_minus1 shall be in the > >> range of 0 to MaxSlicesPerAu − 1, inclusive." > >> > >> Signed-off-by: Frank P

Re: [FFmpeg-devel] Add protocol for Android content providers

2024-02-26 Thread Matthieu Bouron
On Sat, Feb 24, 2024 at 12:29:24PM +0100, Matthieu Bouron wrote: > On Thu, Feb 15, 2024 at 10:13:03AM +0100, Matthieu Bouron wrote: > > Le jeu. 15 févr. 2024, 9:46 AM, Zhao Zhili a > > écrit : > > > > > > > > > 在 2024年2月15日,下午3:57,Matthieu Bouron 写道: > > > > > > > > On Thu, Feb 15, 2024 at 12:1

Re: [FFmpeg-devel] [RFC] clarifying the TC conflict of interest rule

2024-02-26 Thread Anton Khirnov
Quoting Michael Niedermayer (2024-02-26 23:47:20) > > Look at the 3 patches i just posted. > I suspect we can move alot closer to what you suggest without a vote but > simply by consensus Your patches use a 'must' wording, while multiple people would prefer a 'should'. But even more importantly,