Lynne: > Feb 26, 2024, 02:25 by andreas.rheinha...@outlook.com: > >> Signed-off-by: Andreas Rheinhardt <andreas.rheinha...@outlook.com> >> --- >> libavcodec/aacsbr_template.c | 131 ++++++++++++++++++----------------- >> 1 file changed, 66 insertions(+), 65 deletions(-) >> >> diff --git a/libavcodec/aacsbr_template.c b/libavcodec/aacsbr_template.c >> index ce3834e2dc..72bec96d2c 100644 >> --- a/libavcodec/aacsbr_template.c >> +++ b/libavcodec/aacsbr_template.c >> @@ -237,15 +237,15 @@ static int array_min_int16(const int16_t *array, int >> nel) >> return min; >> } >> > > Patchset LGTM, except this commit. Would you mind leaving > AACDecContext usage here? SBR is still technically part of the decoder, > and it has been useful for 2 of my unmerged patches to have > access to the header.
Ok, applied the set without this patch. Thanks for the review. > I think SBR went too hard on abstracting itself, maybe for a hypothetical > sbr mp3 reuse. +1 - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
