ping I forgot to again add a description to v4 so: These small patches fix several mis-conversions for subtitles (and additionally one cde cleanup in avcodec/ass.c):
- WebVTT files no longer get their BiDi marks stripped
(which mangled BiDi text)
- backslashes are no longer duplicated for no reason
- ffmpeg’s attempt at escaping curly braces no longer
severly breaks in standard ASS renderers
v1 was posted over 2 years ago, would be great
if someone could finally look at this
On Mon, Feb 19, 2024 at 22:42:23 +0100, Oneric wrote:
> Changes from v3:
> - None. Just rebased ontop of master to allow
> Patchwork to properly process the series now
> that 99d33cc661fbd04e8657831 was merged.
>
> Changes from v2:
> - rebased ontop of the recently pushed eol normalisation.
> As a result no more CRLFs in here and Patchwork should be happy
> - added a fourth cosmetic commit adjusting
> explicit linebreaks to the new normalisation
>
> Changes from v1:
> - ff_ass_bprint_text_event now only inserts a word-joiner
> if there isn’t already one anyway
> - added a third commit improving the handling of
> curly brackets for standard ASS renderers
>
> Oneric (4):
> avcodec/webvttdec: honour bidi marks
> avcodec/{ass,webvttdec}: fix handling of backslashes
> avcodec/{ass,webvttdec}: more portable curly brace escapes
> avocdec/ass: simplify linebreaks
>
> libavcodec/ass.c | 47 +++++++++++++++++++++++---------------
> libavcodec/webvttdec.c | 4 ++--
> tests/ref/fate/sub-webvtt | 2 +-
> tests/ref/fate/sub-webvtt2 | 2 +-
> 4 files changed, 33 insertions(+), 22 deletions(-)
signature.asc
Description: PGP signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
