Re: [FFmpeg-devel] FFmpeg patch to add idr_interval option to libavcodec/qsvenc_mpeg2.c

On Tue, 2022-06-28 at 15:26 +, Greg Stewart wrote: > Hello, > > Please find attached a base64 encoded patch. This patch exposes the > "idr_interval" option to the mpeg2_qsv encoder (libavcodec/qsvenc_mpeg2.c) > identically to how was done for the h264_qsv encoder > (libavcodec/qsvenc_h264.c).

[FFmpeg-devel] [PATCH 1/7] avcodec/iff: Split extract_header into extradata and packet part

183132872a1d8bc8a32e7fd8f994fa2f1b2d6bfc made the iff demuxer output extradata and made the decoder parse said extradata. To make this extradata extensible, it came with its own internal length field (containing the offset of the palette at the end of the extradata). Furthermore, in order to suppor

[FFmpeg-devel] [PATCH 2/7] avcodec/iff: Avoid redundant frees

This code is only called once during init, so none of the buffers here have been allocated already. Signed-off-by: Andreas Rheinhardt --- libavcodec/iff.c | 13 ++--- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/libavcodec/iff.c b/libavcodec/iff.c index 4abbed8dfb..f146

[FFmpeg-devel] [PATCH 3/7] avcodec/iff: Return early when possible

It allows to save one level of indentation. Signed-off-by: Andreas Rheinhardt --- libavcodec/iff.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/libavcodec/iff.c b/libavcodec/iff.c index f14644471b..13912e9133 100644 --- a/libavcodec/iff.c +++ b/libavcodec/iff.c

[FFmpeg-devel] [PATCH 4/7] avcodec/iff: Pass extradata and extradata_size explicitly

This might be useful in case this decoder were changed to support new extradata passed via side-data. Signed-off-by: Andreas Rheinhardt --- libavcodec/iff.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/libavcodec/iff.c b/libavcodec/iff.c index 13912e9133..4

[FFmpeg-devel] [PATCH 5/7] avcodec/iff: Reindent after the previous commits

Signed-off-by: Andreas Rheinhardt --- libavcodec/iff.c | 260 +++ 1 file changed, 128 insertions(+), 132 deletions(-) diff --git a/libavcodec/iff.c b/libavcodec/iff.c index 453e910982..00d0105be3 100644 --- a/libavcodec/iff.c +++ b/libavcodec/iff.c @@

[FFmpeg-devel] [PATCH 6/7] avcodec/iff: Remove transient objects from the context

This avoids keeping invalid pointers in the context. Signed-off-by: Andreas Rheinhardt --- libavcodec/iff.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/libavcodec/iff.c b/libavcodec/iff.c index 00d0105be3..ad96bd9191 100644 --- a/libavcodec/iff.c +++ b/libavcodec/i

[FFmpeg-devel] [PATCH 7/7] avcodec/iff: Use unsigned to avoid compiler warning

GCC 12 apparently believes that negative palette sizes are possible (they are not, as this has already been checked during init) and therefore emits a -Wstringop-overflow= for the memcpy. Using unsigned avoids this. (To be honest, there might be a compiler bug involved.) Signed-off-by: Andreas Rhe

Re: [FFmpeg-devel] Error in input

On Tue, Jul 12, 2022, 13:02 Abhishek Gorecha wrote: > Hi, When we try to give rtp stream as input we are not able to process. > Can anyone help us out here > > > > Wrong list. Post on ffmpeg-user. Also provide full details, like this no > one can help you of course __

Re: [FFmpeg-devel] [PATCH v2 1/6] fflcms2: move to libavcodec

On Wed, 06 Jul 2022 16:18:21 +0200 Andreas Rheinhardt wrote: > Niklas Haas: > > From: Niklas Haas > > > > We will need this helper inside libavcodec in the future, so move it > > there, leaving behind an #include to the raw source file in its old > > location in libvfilter. This approach is ins

Re: [FFmpeg-devel] [PATCH 3/8] avutil/mem: Add av_fast_realloc_array()

Andreas Rheinhardt: > From: Andreas Rheinhardt > > This is an array-equivalent of av_fast_realloc(). Its advantages > compared to using av_fast_realloc() for allocating arrays are as > follows: > > a) It performs its own overflow checks for the multiplication that is > implicit in array allocati

[FFmpeg-devel] [PATCH] avfilter/vf_xfade: fixed slideleft/slideright/slideup/slidedown bug

zx and zy comparison were wrong when zx=0 or zy=0. This resulted in the wrong column/row being chosen. This can be seen best when using xfade on streams with transparency. For example: in case of a slideleft transition, the first column from the first input will overwrite the first column of th

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mov: Support parsing of still AVIF Alpha Channel

On Tue, Jul 5, 2022 at 9:54 AM Anton Khirnov wrote: > > Quoting Vignesh Venkatasubramanian (2022-07-02 23:15:35) > > > As for encoding, not fully sure how it should be integrated, if any > > > encoders actually at this moment do proper alpha coding, or do all API > > > clients have to separately e

[FFmpeg-devel] Request: make framepool visible externally

Hi all I'm using Libav libraries (version 4.1.6) to make operations on audio/video AVFrame: conversions, decoding, encoding, etc. To improve performances I'd like to use framepool. So I need to include "libavfilter/framepool.h", but I cannot, because this file is not exported.  Should be possibl

Re: [FFmpeg-devel] Request: make framepool visible externally

On 12.07.2022 18:28, Marco Vianini wrote: Hi all I'm using Libav libraries (version 4.1.6) to make operations on audio/video AVFrame: conversions, decoding, encoding, etc. That is a really old version, and you should desperately update. To improve performances I'd like to use framepool. So I

Re: [FFmpeg-devel] Request: make framepool visible externally

On 7/12/2022 1:28 PM, Marco Vianini wrote: Hi all I'm using Libav libraries (version 4.1.6) to make operations on audio/video AVFrame: conversions, decoding, encoding, etc. To improve performances I'd like to use framepool. So I need to include "libavfilter/framepool.h", but I cannot, because t

Re: [FFmpeg-devel] [EXTERNAL] [PATCH] [PATCH] libavformat/mov: Expose Quicktime poster_time value as metadata TAG.

Hello, Can someone please have a look at this patch request? Thank you in advance. Bryce Bryce Chester Newman | Principal Developer p: +12069255045 | From: Bryce Chester Newman Date: Wednesday, February 2, 2022 at 4:22 PM To: ffmpeg-devel@ffmpeg.org Cc: Bryce Newman , Bryce Newma

Re: [FFmpeg-devel] [PATCH] avformat/mov: h264 cenc entryption file decryption_key failed

On Sat, 9 Jul 2022, Marton Balint wrote: On Sat, 9 Jul 2022, lishuangxi wrote: Please help review it, thanks. You should describe why the old logic of encrypting in 16 byte chunks is uneeded in the commit message. Applied with fixed commit message. Thanks, Marton Code proces

Re: [FFmpeg-devel] [PATCH 3/3] tools/target_dec_fuzzer: Adjust threshold for ANM

On Mon, Jul 11, 2022 at 11:44:17PM +0200, Michael Niedermayer wrote: > Fixes: Timeout > Fixes: > 48923/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ANM_fuzzer-6391662321991680 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/ffv1dec_template: Fix indention

On Sun, Jul 03, 2022 at 04:18:08PM +0200, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavcodec/ffv1dec_template.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) will apply [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787

Re: [FFmpeg-devel] [PATCH 1/3] tools/target_dec_fuzzer: Adjust threshold for CFHD

On Tue, Jul 05, 2022 at 12:30:32AM +0200, Michael Niedermayer wrote: > Fixes: Timeout > Fixes: > 46504/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_CFHD_fuzzer-6376835606249472 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed

Re: [FFmpeg-devel] [PATCH 2/3] tools/target_dec_fuzzer: Adjust threshold for MVC2

On Tue, Jul 05, 2022 at 12:30:33AM +0200, Michael Niedermayer wrote: > Fixes: Timeout > Fixes: > 48689/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MVC2_fuzzer-6436301427048448 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed

Re: [FFmpeg-devel] [PATCH 3/3] avformat/iff: simplify duration calculation

On Tue, Jul 05, 2022 at 12:30:34AM +0200, Michael Niedermayer wrote: > Fixes: signed integer overflow: 315680096256 * 134215943 cannot be > represented in type 'long long' > Fixes: > 48713/clusterfuzz-testcase-minimized-ffmpeg_dem_IFF_fuzzer-5886272312311808 > > Found-by: continuous fuzzing proc

Re: [FFmpeg-devel] [PATCH 2/6] tools/target_dec_fuzzer: Adjust threshold for WCMV

On Sun, Jul 03, 2022 at 02:31:48AM +0200, Michael Niedermayer wrote: > Fixes: Timeout > Fixes: > 48377/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WCMV_fuzzer-5053331682230272 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed

Re: [FFmpeg-devel] [PATCH 5/6] tools/target_dec_fuzzer: Adjust threshold for ylc

On Sun, Jul 03, 2022 at 02:31:51AM +0200, Michael Niedermayer wrote: > Fixes: timeout > Fixes: > 48523/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_YLC_fuzzer-5779666425741312 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-

Re: [FFmpeg-devel] [PATCH 6/6] tools/target_dec_fuzzer: Adjust threshold for LOCO

On Sun, Jul 03, 2022 at 02:31:52AM +0200, Michael Niedermayer wrote: > Fixes: Timeout > Fixes: > 48584/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_LOCO_fuzzer-5741269015461888 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed

Re: [FFmpeg-devel] [PATCH] avformat/aaxdec: Check for empty segments

On Tue, Jun 28, 2022 at 09:28:30PM +0200, Michael Niedermayer wrote: > On Tue, Jun 28, 2022 at 08:26:54AM -0300, James Almer wrote: > > > > > > On 6/28/2022 2:21 AM, Anton Khirnov wrote: > > > Quoting Michael Niedermayer (2022-06-27 10:43:47) > > > > Fixes: Timeout > > > > Fixes: > > > > 48154/c

Re: [FFmpeg-devel] [PATCH] avcodec/qpeldsp: copy less for the mc0x cases

On Mon, Jun 27, 2022 at 02:40:04PM +0200, Michael Niedermayer wrote: > On Mon, Jun 27, 2022 at 07:57:06AM +0200, Andreas Rheinhardt wrote: > > Michael Niedermayer: > > > Fixes: out of array access > > > Fixes: > > > 47936/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MPEG4_fuzzer-5745039940124

Re: [FFmpeg-devel] [PATCH 3/3] tools/target_dec_fuzzer: adjust threshold for cinepak

On Sat, Jul 02, 2022 at 02:22:50PM +0200, Michael Niedermayer wrote: > Fixes: Timeout > Fixes: > 48158/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_CINEPAK_fuzzer-5986526573494272 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Sig

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/tiff: Check pixel format types for dng

On Fri, Jul 01, 2022 at 09:25:53PM +0200, Michael Niedermayer wrote: > Fixes: out of array access > Fixes: > 48271/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_TIFF_fuzzer-6149705769287680 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffm

Re: [FFmpeg-devel] [PATCH 4/4] tools/target_dec_fuzzer: Adjust threshold for AASC

On Sat, Jun 18, 2022 at 09:16:37PM +0200, Michael Niedermayer wrote: > Fixes: Timeout > Fixes: > 47919/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_AASC_fuzzer-5176435830030336 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/hevcdsp_template: stay within tables in sao_band_filter()

On Thu, Jun 09, 2022 at 11:37:40PM +0200, Michael Niedermayer wrote: > Fixes: out of array read > Fixes: > 47875/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_HEVC_fuzzer-5719393113341952 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpe

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/bink: disallow odd positioned scaled blocks

On Tue, Jun 14, 2022 at 12:09:59AM +0200, Michael Niedermayer wrote: > On Tue, Jun 14, 2022 at 12:01:14AM +0200, Paul B Mahol wrote: > > On Mon, Jun 13, 2022 at 11:55 PM Michael Niedermayer > > > > wrote: > > > > > On Mon, Jun 13, 2022 at 10:02:24AM +0200, Paul B Mahol wrote: > > > > Have you ch

Re: [FFmpeg-devel] [PATCH 2/2] avformat/rtsp: break on unknown protocols

On Fri, May 20, 2022 at 01:43:12AM +0200, Michael Niedermayer wrote: > This function needs more cleanup and it lacks error handling > > Fixes: use of uninitialized memory > Fixes: CID700776 > > Signed-off-by: Michael Niedermayer > --- > libavformat/rtsp.c | 2 ++ > 1 file changed, 2 insertions(

Re: [FFmpeg-devel] [PATCH 2/2] avfilter/vf_signature: Fix integer overflow in filter_frame()

On Wed, May 18, 2022 at 05:55:05PM +0200, Michael Niedermayer wrote: > Fixes: CID1403233 > > The second of the 2 changes may be unneeded but will help coverity > > Signed-off-by: Michael Niedermayer > --- > libavfilter/vf_signature.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-)

Re: [FFmpeg-devel] [PATCH] avcodec/pixlet: consider minimum plane header in the minimal packet size

On Sun, May 01, 2022 at 03:37:58PM +0200, Michael Niedermayer wrote: > Fixes: Timeout > Fixes: > 46956/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_PIXLET_fuzzer-5698161106092032 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Sign

Re: [FFmpeg-devel] [PATCH] avcodec/sbrdsp_fixed: Fix integer overflows in sbr_qmf_deint_neg_c()

On Mon, May 02, 2022 at 05:07:39PM +0200, Michael Niedermayer wrote: > Fixes: signed integer overflow: 2147483645 + 16 cannot be represented in type > 'int' > Fixes: > 46993/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_AAC_FIXED_fuzzer-4759025234870272 > > Found-by: continuous fuzzing proce

Re: [FFmpeg-devel] [PATCH] avcodec/h264dec: Skip late SEI

On Thu, Apr 28, 2022 at 08:25:52PM +0200, Michael Niedermayer wrote: > Fixes: Race condition > Fixes: > clusterfuzz-testcase-minimized-mediasource_MP2T_AVC_pipeline_integration_fuzzer-6282675434094592 > > Found-by: google ClusterFuzz > Tested-by: Dan Sanders > Signed-off-by: Michael Niedermayer

[FFmpeg-devel] [PATCH 3/3] avformat/flvdec: Check for EOF in index reading

Fixes: Timeout Fixes: 47992/clusterfuzz-testcase-minimized-ffmpeg_dem_LIVE_FLV_fuzzer-6020443879899136 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavformat/flvdec.c | 2 ++ 1 file changed, 2 inser

[FFmpeg-devel] [PATCH 1/3] avcodec/lagarith: Check dst/src in zero run code

Fixes: out of array access Fixes: 48799/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_LAGARITH_fuzzer-4764457825337344 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/lagarith.c | 3 +++ 1

[FFmpeg-devel] [PATCH 2/3] avformat/nutdec: Check get_packetheader() in mainheader

Fixes; Timeout Fixes: 48794/clusterfuzz-testcase-minimized-ffmpeg_dem_NUT_fuzzer-6524604713140224 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavformat/nutdec.c | 2 ++ 1 file changed, 2 insertions

Re: [FFmpeg-devel] [PATCH] swscale: add NV16 input/output

Le ven. 1 juil. 2022, 10:08, Matthieu Bouron a écrit : > On Sat, Jun 11, 2022 at 5:35 PM Michael Niedermayer < > mich...@niedermayer.cc> wrote: > >> On Fri, Jun 10, 2022 at 04:11:10PM +0200, Matthieu Bouron wrote: >> > On Thu, Jun 2, 2022 at 9:13 PM Michael Niedermayer < >> mich...@niedermayer.cc

[FFmpeg-devel] Tags in video

Is it possible to allow ffmpeg to read tags off from videos? Tags were manually inputted in Windows 10. https://emby.media/community/index.php?/topic/110246-allow-scan-media-to-detect-tags-in-videos/#comment-1162342 ___ ffmpeg-devel mailing list ffmpeg-

[FFmpeg-devel] [PATCH v2 1/2] avformat: refactor ff_stream_encode_params_copy() to ff_stream_params_copy()

From: Pierre-Anthony Lemieux As discussed at https://ffmpeg.org/pipermail/ffmpeg-devel/2022-July/298491.html --- libavformat/avformat.c | 38 ++ libavformat/fifo.c | 2 +- libavformat/internal.h | 9 + libavformat/mux.h| 9 ---

[FFmpeg-devel] [PATCH v2 2/2] avformat/imfdec: preserve stream information

From: Pierre-Anthony Lemieux As discussed at https://trac.ffmpeg.org/ticket/9818, the IMF demuxer does not currently preserve stream information such as language in the case of audio streams. --- libavformat/imfdec.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/lib

[FFmpeg-devel] [PATCH] ffprobe: use pkt->dts to compute interval ts when pts is missing

For some samples the pkt->pts is always missing, use the pkt->dts instead. Fix trac issue http://trac.ffmpeg.org/ticket/4427. --- fftools/ffprobe.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c index f156663019..8824b1c044 100644 --