Hello,
Can someone please have a look at this patch request?
Thank you in advance.
Bryce
Bryce Chester Newman | Principal Developer
p: +12069255045 |
From: Bryce Chester Newman <ffmpegag...@gmail.com>
Date: Wednesday, February 2, 2022 at 4:22 PM
To: ffmpeg-devel@ffmpeg.org <ffmpeg-devel@ffmpeg.org>
Cc: Bryce Newman <bryce.new...@gettyimages.com>, Bryce Newman
<bryce.new...@gettyimages.com>
Subject: [EXTERNAL] [PATCH] [PATCH] libavformat/mov: Expose Quicktime
poster_time value as metadata TAG.
From: Bryce Chester Newman <bryce.new...@gettyimages.com>
I need the ability to derive the poster time found in the mvhd, so I can
use that value to create a thumbnail from ffmpeg. More details can be
found here
https://www.mail-archive.com/ffmpeg-user@ffmpeg.org/msg30003.html
Signed-off-by: Bryce Chester Newman <bryce.new...@gettyimages.com>
---
libavformat/mov: Expose Quicktime poster_time value as metadata TAG.
I need the ability to derive the poster time found in the mvhd, so I can
use that value to create a thumbnail from ffmpeg. More details can be
found here
https://www.mail-archive.com/ffmpeg-user@ffmpeg.org/msg30003.html
Signed-off-by: Bryce Chester Newman bryce.new...@gettyimages.com
Published-As:
https://github.com/ffstaging/FFmpeg/releases/tag/pr-ffstaging-21%2Fbrycechesternewman%2Fpatch-poster-time-tag-v1
Fetch-It-Via: git fetch https://github.com/ffstaging/FFmpeg
pr-ffstaging-21/brycechesternewman/patch-poster-time-tag-v1
Pull-Request: https://github.com/ffstaging/FFmpeg/pull/21
libavformat/mov.c | 12 +++++++++++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/libavformat/mov.c b/libavformat/mov.c
index a80fcc1606..3d36f6563f 100644
--- a/libavformat/mov.c
+++ b/libavformat/mov.c
@@ -1487,6 +1487,7 @@ static int mov_read_mvhd(MOVContext *c, AVIOContext *pb,
MOVAtom atom)
{
int i;
int64_t creation_time;
+ int32_t poster_time;
int version = avio_r8(pb); /* version */
avio_rb24(pb); /* flags */
@@ -1525,12 +1526,21 @@ static int mov_read_mvhd(MOVContext *c, AVIOContext
*pb, MOVAtom atom)
avio_rb32(pb); /* preview time */
avio_rb32(pb); /* preview duration */
- avio_rb32(pb); /* poster time */
+ poster_time = avio_rb32(pb); /* poster time */
avio_rb32(pb); /* selection time */
avio_rb32(pb); /* selection duration */
avio_rb32(pb); /* current time */
avio_rb32(pb); /* next track ID */
+ av_log(c->fc, AV_LOG_TRACE, "poster_time = %i, time_scale = %i\n",
poster_time, c->time_scale);
+ if(poster_time && c->time_scale && c->time_scale > 0) {
+ char buffer[32];
+ float poster_time_location = (float)poster_time / c->time_scale;
+ snprintf(buffer, sizeof(buffer), "%.2f", poster_time_location);
+ /* This will appear as a TAG in the format section of FFProbe output
using -show_format */
+ av_dict_set(&c->fc->metadata, "poster_time", buffer, 0);
+ }
+
return 0;
}
base-commit: 2e82c610553efd69b4d9b6c359423a19c2868255
--
ffmpeg-codebot
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
