Re: [FFmpeg-devel] [PATCH] libavcodec/mpegvideo_enc: Fix a chroma mb size error in sse_mb()

2022-07-01 Thread Xiang, Haihao
On Fri, 2022-07-01 at 13:34 +0800, Wenbin Chen wrote: > For 422 frames we should not use hard coded 8 to calculate mb size for > uv plane. Chroma shift should be taken into consideration to be > compatiple with different sampling format. > > The error is reported by fate test when av_cpu_max_align

Re: [FFmpeg-devel] [PATCH] swscale: add NV16 input/output

2022-07-01 Thread Matthieu Bouron
On Sat, Jun 11, 2022 at 5:35 PM Michael Niedermayer wrote: > On Fri, Jun 10, 2022 at 04:11:10PM +0200, Matthieu Bouron wrote: > > On Thu, Jun 2, 2022 at 9:13 PM Michael Niedermayer < > mich...@niedermayer.cc> > > wrote: > > > > > On Wed, Jun 01, 2022 at 10:33:37PM +0200, Matthieu Bouron wrote: >

Re: [FFmpeg-devel] [PATCH] libavcodec/mpegvideo_enc: Fix a chroma mb size error in sse_mb()

2022-07-01 Thread Paul B Mahol
On Fri, Jul 1, 2022 at 10:00 AM Xiang, Haihao < haihao.xiang-at-intel@ffmpeg.org> wrote: > On Fri, 2022-07-01 at 13:34 +0800, Wenbin Chen wrote: > > For 422 frames we should not use hard coded 8 to calculate mb size for > > uv plane. Chroma shift should be taken into consideration to be > > co

Re: [FFmpeg-devel] [PATCH] libavcodec/mpegvideo_enc: Fix a chroma mb size error in sse_mb()

2022-07-01 Thread Chen, Wenbin
> On Fri, Jul 1, 2022 at 10:00 AM Xiang, Haihao < > haihao.xiang-at-intel@ffmpeg.org> wrote: > > > On Fri, 2022-07-01 at 13:34 +0800, Wenbin Chen wrote: > > > For 422 frames we should not use hard coded 8 to calculate mb size for > > > uv plane. Chroma shift should be taken into consideration

Re: [FFmpeg-devel] [PATCH] libavcodec/mpegvideo_enc: Fix a chroma mb size error in sse_mb()

2022-07-01 Thread Paul B Mahol
On Fri, Jul 1, 2022 at 10:47 AM Chen, Wenbin < wenbin.chen-at-intel@ffmpeg.org> wrote: > > On Fri, Jul 1, 2022 at 10:00 AM Xiang, Haihao < > > haihao.xiang-at-intel@ffmpeg.org> wrote: > > > > > On Fri, 2022-07-01 at 13:34 +0800, Wenbin Chen wrote: > > > > For 422 frames we should not use h

Re: [FFmpeg-devel] [PATCH 1/3] Provided support for MPEG-5 EVC (Essential Video Coding) codec

2022-07-01 Thread Anton Khirnov
Quoting Dawid Kozinski (2022-06-22 08:48:55) > Prerequisites that must be met before adding new codec > - Added new entry to codec IDs list > - Added new entry to the codec descriptor list > - Bumped libavcodec minor version > - Changes in Changelog and MAINTAINERS files > > Signed-off-by: Dawid K

[FFmpeg-devel] [PATCH] avcodec: add PHM decoder and encoder

2022-07-01 Thread Paul B Mahol
Hello, patch attached. From cec6259e75fa56a4b064f7d5a0823449d19f3b47 Mon Sep 17 00:00:00 2001 From: Paul B Mahol Date: Fri, 1 Jul 2022 10:06:15 +0200 Subject: [PATCH] avcodec: add PHM decoder and encoder Signed-off-by: Paul B Mahol --- libavcodec/Makefile | 2 + libavcodec/allcodecs.c |

Re: [FFmpeg-devel] [PATCH 2/3] Provided support for MPEG-5 EVC (Essential Video Coding) codec

2022-07-01 Thread Anton Khirnov
Quoting Dawid Kozinski (2022-06-22 08:49:04) > - Added xeve encoder wrapper > - Added xevd dencoder wrapper > - Added documentation for xeve and xevd wrappers > - Added parser for EVC format > - Changes in project configuration file and libavcodec Makefile > > Signed-off-by: Dawid Kozinski > ---

Re: [FFmpeg-devel] [PATCH v2 1/2] avformat: add AVFormatContext.first_pkt_wallclock

2022-07-01 Thread Anton Khirnov
Quoting Gyan Doshi (2022-06-28 08:40:58) > > > On 2022-06-28 10:43 am, Anton Khirnov wrote: > > Quoting Gyan Doshi (2022-06-25 10:29:50) > >> Stores wallclock time for the first packet received. > >> Used for crude sync offset among inputs. > >> --- > >> doc/APIchanges | 3 +++ > >> l

Re: [FFmpeg-devel] [PATCH v2 2/2] ffmpeg: add option -isync

2022-07-01 Thread Anton Khirnov
Quoting Gyan Doshi (2022-06-25 10:29:51) > This is a per-file input option that adjusts an input's timestamps > with reference to another input, so that emitted packet timestamps > account for the difference between the start times of the two inputs. > > Typical use case is to sync two or more liv

Re: [FFmpeg-devel] [PATCH v2 2/2] ffmpeg: add option -isync

2022-07-01 Thread Gyan Doshi
On 2022-07-01 03:33 pm, Anton Khirnov wrote: Quoting Gyan Doshi (2022-06-25 10:29:51) This is a per-file input option that adjusts an input's timestamps with reference to another input, so that emitted packet timestamps account for the difference between the start times of the two inputs. Ty

[FFmpeg-devel] [PATCH 1/2] avcodec/cbs: Add specialization for ff_cbs_(read|write)_unsigned()

2022-07-01 Thread Andreas Rheinhardt
These functions allow not only to read and write unsigned values, but also to check ranges and to emit trace output which can be beautified when processing arrays (indices like "[i]" are replaced by their actual numbers). Yet lots of callers actually only need something simpler: Their range is onl

Re: [FFmpeg-devel] [PATCH v2 01/18] avcodec/pthread_slice: Don't reinitialise initialised mutex

2022-07-01 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2022-06-30 23:48:00) > It results in undefined behaviour. Instead initialize the mutexes > and condition variables once during init (and check these > initializations). > > Also combine the corresponding mutex and condition variable > into one structure so that one can

[FFmpeg-devel] [PATCH 2/2] avcodec/cbs: Mark init and close functions as av_cold

2022-07-01 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/cbs.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/libavcodec/cbs.c b/libavcodec/cbs.c index 8bd63aa831..0a9fda8469 100644 --- a/libavcodec/cbs.c +++ b/libavcodec/cbs.c @@ -73,8 +73,8 @@ const enum AVCodecID ff_cbs

Re: [FFmpeg-devel] [PATCH v2 1/2] avformat: add AVFormatContext.first_pkt_wallclock

2022-07-01 Thread Gyan Doshi
On 2022-07-01 03:20 pm, Anton Khirnov wrote: Quoting Gyan Doshi (2022-06-28 08:40:58) On 2022-06-28 10:43 am, Anton Khirnov wrote: Quoting Gyan Doshi (2022-06-25 10:29:50) Stores wallclock time for the first packet received. Used for crude sync offset among inputs. --- doc/APIchanges

Re: [FFmpeg-devel] [PATCH 07/18] avcodec/hevc_mvs: Pass HEVCLocalContext when slice-threading

2022-07-01 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2022-07-01 00:29:38) > The HEVC decoder has both HEVCContext and HEVCLocalContext > structures. The latter is supposed to be the structure > containing the per-slicethread state. > > Yet that is not how it is handled in practice: Each HEVCLocalContext > has a unique HEV

Re: [FFmpeg-devel] [PATCH 17/18] avcodec/pthread_slice: Reuse buffer if possible

2022-07-01 Thread Paul B Mahol
On Fri, Jul 1, 2022 at 12:32 AM Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/pthread_slice.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/pthread_slice.c b/libavcodec/pthread_slice.

Re: [FFmpeg-devel] [PATCH 09/18] avcodec/hevcdec: Add stat_coeffs to HEVCABACState

2022-07-01 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2022-07-01 00:29:40) > diff --git a/libavcodec/hevcdec.h b/libavcodec/hevcdec.h > index e2dba54f26..b97b7d1354 100644 > --- a/libavcodec/hevcdec.h > +++ b/libavcodec/hevcdec.h > @@ -226,6 +226,11 @@ enum ScanType { > SCAN_VERT, > }; > > +typedef struct HEVCCABACS

Re: [FFmpeg-devel] [PATCH 17/18] avcodec/pthread_slice: Reuse buffer if possible

2022-07-01 Thread Tomas Härdin
fre 2022-07-01 klockan 00:29 +0200 skrev Andreas Rheinhardt: > Signed-off-by: Andreas Rheinhardt > --- >  libavcodec/pthread_slice.c | 6 -- >  1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/pthread_slice.c b/libavcodec/pthread_slice.c > index 756cc59dbf..a4d31c6f4

Re: [FFmpeg-devel] [PATCH v2 01/18] avcodec/pthread_slice: Don't reinitialise initialised mutex

2022-07-01 Thread Tomas Härdin
tor 2022-06-30 klockan 23:48 +0200 skrev Andreas Rheinhardt: > It results in undefined behaviour. Instead initialize the mutexes > and condition variables once during init (and check these > initializations). > > Also combine the corresponding mutex and condition variable > into one structure so t

Re: [FFmpeg-devel] [PATCH v4 0/4] add ARIB caption decoder using libaribcaption

2022-07-01 Thread Mao Hata
In aribcaption_close() (libaribcaption.c): ``` if (ctx->renderer) { aribcc_renderer_free(ctx->renderer); ctx->decoder = NULL; } ``` This should be `ctx->renderer = NULL;`. In set_ass_header() (libaribcaption.c): ``` if (fonts && *fonts) { font_name = av_get_token(&fonts, ","); if (

[FFmpeg-devel] [PATCH 1/2] avutil/channel_layout: av_channel_layout_describe_bprint: Check for buffer end

2022-07-01 Thread Michael Niedermayer
Fixes: Timeout printing a billion channels Fixes: 48099/clusterfuzz-testcase-minimized-ffmpeg_dem_MATROSKA_fuzzer-6754782204788736 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavutil/channel_layout

[FFmpeg-devel] [PATCH 2/2] avcodec/tiff: Check pixel format types for dng

2022-07-01 Thread Michael Niedermayer
Fixes: out of array access Fixes: 48271/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_TIFF_fuzzer-6149705769287680 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/tiff.c | 3 +++ 1 file ch

Re: [FFmpeg-devel] [PATCH 1/2] avutil/channel_layout: av_channel_layout_describe_bprint: Check for buffer end

2022-07-01 Thread James Almer
On 7/1/2022 4:25 PM, Michael Niedermayer wrote: Fixes: Timeout printing a billion channels Fixes: 48099/clusterfuzz-testcase-minimized-ffmpeg_dem_MATROSKA_fuzzer-6754782204788736 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by:

Re: [FFmpeg-devel] [PATCH 2/2] fftools/ffmpeg_filter: Fix audio_drift_threshold check

2022-07-01 Thread Michael Niedermayer
On Thu, Jun 30, 2022 at 10:55:46AM +0200, Anton Khirnov wrote: > Variant 2 is less bad, but the whole check seems hacky to me, since it > seems to make assumptions about swr defaults > > Won't setting this unconditionally have the same effect? it has the same effect but its not so nice to the use

Re: [FFmpeg-devel] [PATCH] libavcodec/mpegvideo_enc: Fix a chroma mb size error in sse_mb()

2022-07-01 Thread Michael Niedermayer
On Fri, Jul 01, 2022 at 01:34:34PM +0800, Wenbin Chen wrote: > For 422 frames we should not use hard coded 8 to calculate mb size for > uv plane. Chroma shift should be taken into consideration to be > compatiple with different sampling format. > > The error is reported by fate test when av_cpu_ma

[FFmpeg-devel] [PATCH v5 0/6] Implement SEI parsing for QSV decoders

2022-07-01 Thread ffmpegagent
Missing SEI information has always been a major drawback when using the QSV decoders. I used to think that there's no chance to get at the data without explicit implementation from the MSDK side (or doing something weird like parsing in parallel). It turned out that there's a hardly known api metho

[FFmpeg-devel] [PATCH v5 4/6] avcodec/hevcdec: make set_side_data() accessible

2022-07-01 Thread softworkz
From: softworkz Signed-off-by: softworkz --- libavcodec/hevcdec.c | 117 +-- libavcodec/hevcdec.h | 9 2 files changed, 67 insertions(+), 59 deletions(-) diff --git a/libavcodec/hevcdec.c b/libavcodec/hevcdec.c index e84c30dd13..b4d8db8c6b 100644

[FFmpeg-devel] [PATCH v5 5/6] avcodec/h264dec: make h264_export_frame_props() accessible

2022-07-01 Thread softworkz
From: softworkz Signed-off-by: softworkz --- libavcodec/h264_slice.c | 98 + libavcodec/h264dec.h| 2 + 2 files changed, 52 insertions(+), 48 deletions(-) diff --git a/libavcodec/h264_slice.c b/libavcodec/h264_slice.c index d56722a5c2..f2a4c1c657 10

[FFmpeg-devel] [PATCH v5 1/6] avutil/frame: Add av_frame_copy_side_data() and av_frame_remove_all_side_data()

2022-07-01 Thread softworkz
From: softworkz Signed-off-by: softworkz Signed-off-by: Anton Khirnov --- doc/APIchanges | 4 +++ libavutil/frame.c | 67 +++-- libavutil/frame.h | 32 ++ libavutil/version.h | 2 +- 4 files changed, 78 insertions(+), 27 de

[FFmpeg-devel] [PATCH v5 2/6] avcodec/vpp_qsv: Copy side data from input to output frame

2022-07-01 Thread softworkz
From: softworkz Signed-off-by: softworkz --- libavfilter/qsvvpp.c | 6 ++ libavfilter/vf_overlay_qsv.c | 19 +++ 2 files changed, 21 insertions(+), 4 deletions(-) diff --git a/libavfilter/qsvvpp.c b/libavfilter/qsvvpp.c index 954f882637..f4bf628073 100644 --- a/lib

[FFmpeg-devel] [PATCH v5 6/6] avcodec/qsvdec: Implement SEI parsing for QSV decoders

2022-07-01 Thread softworkz
From: softworkz Signed-off-by: softworkz --- libavcodec/Makefile | 6 +- libavcodec/hevcdsp.c | 4 + libavcodec/qsvdec.c | 234 +++ 3 files changed, 243 insertions(+), 1 deletion(-) diff --git a/libavcodec/Makefile b/libavcodec/Makefile index 3b8f7

[FFmpeg-devel] [PATCH v5 3/6] avcodec/mpeg12dec: make mpeg_decode_user_data() accessible

2022-07-01 Thread softworkz
From: softworkz Signed-off-by: softworkz --- libavcodec/mpeg12.h| 28 libavcodec/mpeg12dec.c | 40 +--- 2 files changed, 33 insertions(+), 35 deletions(-) diff --git a/libavcodec/mpeg12.h b/libavcodec/mpeg12.h index e0406b32d

Re: [FFmpeg-devel] [PATCH] avfilter: add remap_opencl filter

2022-07-01 Thread Michael Niedermayer
On Thu, Jun 30, 2022 at 08:59:53AM +0200, Paul B Mahol wrote: > Updated. > libavfilter/Makefile |2 > libavfilter/allfilters.c |1 > libavfilter/opencl/remap.cl | 69 > libavfilter/opencl_source.h |1 > libavfilter/vf_remap_opencl.c | 362 > ++

Re: [FFmpeg-devel] [PATCH] libavcodec/mpegvideo_enc: Fix a chroma mb size error in sse_mb()

2022-07-01 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Wenbin Chen > Sent: Friday, July 1, 2022 7:35 AM > To: ffmpeg-devel@ffmpeg.org > Subject: [FFmpeg-devel] [PATCH] libavcodec/mpegvideo_enc: Fix a > chroma mb size error in sse_mb() > > For 422 frames we should not use hard coded 8

Re: [FFmpeg-devel] [PATCH 14/18] avcodec/hevcdec: Don't allocate redundant HEVCContexts

2022-07-01 Thread Michael Niedermayer
On Fri, Jul 01, 2022 at 12:29:45AM +0200, Andreas Rheinhardt wrote: > The HEVC decoder has both HEVCContext and HEVCLocalContext > structures. The latter is supposed to be the structure > containing the per-slicethread state. > > Yet up until now that is not how it is handled in practice: > Each H

Re: [FFmpeg-devel] [PATCH] avfilter: add remap_opencl filter

2022-07-01 Thread Paul B Mahol
On Fri, Jul 1, 2022 at 11:04 PM Michael Niedermayer wrote: > On Thu, Jun 30, 2022 at 08:59:53AM +0200, Paul B Mahol wrote: > > Updated. > > > libavfilter/Makefile |2 > > libavfilter/allfilters.c |1 > > libavfilter/opencl/remap.cl | 69 > > libavfilter/opencl_

[FFmpeg-devel] [PATCH] avformat/isom: support 16:9 DV in QuickTime

2022-07-01 Thread Brion Vibber
Attached patch adds input support for 16:9 DV video in QuickTime. I found some old files produced by Adobe Premiere and Radius SoftDV which were affected by this: 4:3 files were marked as type 'dvc ' which already worked; 16:9 files as 'dvl ' which was missing. PAL uses 'p' in place of the ' ' spa

Re: [FFmpeg-devel] [PATCH 14/18] avcodec/hevcdec: Don't allocate redundant HEVCContexts

2022-07-01 Thread Andreas Rheinhardt
Michael Niedermayer: > On Fri, Jul 01, 2022 at 12:29:45AM +0200, Andreas Rheinhardt wrote: >> The HEVC decoder has both HEVCContext and HEVCLocalContext >> structures. The latter is supposed to be the structure >> containing the per-slicethread state. >> >> Yet up until now that is not how it is ha

Re: [FFmpeg-devel] [PATCH] avfilter: add remap_opencl filter

2022-07-01 Thread Paul B Mahol
New version: Added docs, and more cleanups and fixes. From 22716c9f853d33769c1e63f7e010a5540a2e455b Mon Sep 17 00:00:00 2001 From: Paul B Mahol Date: Wed, 29 Jun 2022 19:12:24 +0200 Subject: [PATCH] avfilter: add remap opencl filter Signed-off-by: Paul B Mahol --- configure