Re: [FFmpeg-devel] [PATCH v2 1/1] return value check for init_get_bits in vc1dec.c

2021-08-15 Thread Maryam Ebrahimzadeh
Ping. > On Aug 13, 2021, at 1:23 AM, maryam ebrahimzadeh wrote: > > --- > libavcodec/vc1dec.c | 11 --- > 1 file changed, 8 insertions(+), 3 deletions(-) > > diff --git a/libavcodec/vc1dec.c b/libavcodec/vc1dec.c > index 1fb1950ade..bc76a07ca6 100644 > --- a/libavcodec/vc1dec.c > +++ b/l

Re: [FFmpeg-devel] [PATCH v1] lavfi: add nlmeans CUDA filter

2021-08-15 Thread Dylan Fernando
On Sat, Aug 14, 2021 at 1:03 PM Timo Rothenpieler wrote: > On 14.08.2021 07:49, Dylan Fernando wrote: > > On Sat, Aug 14, 2021 at 9:11 AM Timo Rothenpieler > > > wrote: > > > >> On 13.08.2021 10:42, Dylan Fernando wrote: > >>> Any update on this? > >>> > >>> Kind Regards, > >>> Dylan > >> > >> A

[FFmpeg-devel] [PATCH] avcodec: add SMC encoder

2021-08-15 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavcodec/Makefile| 1 + libavcodec/allcodecs.c | 1 + libavcodec/smcenc.c| 561 + 3 files changed, 563 insertions(+) create mode 100644 libavcodec/smcenc.c diff --git a/libavcodec/Makefile b/libavcodec/Makefil

[FFmpeg-devel] [PATCH] avfilter: add dewobble_opencl filter

2021-08-15 Thread Daniel Playfair Cal
All of the existing filters for video stabilization use an affine model (or a limited version of it) to represent the movement of the camera. When used with cameras with a very wide field of view and/or where the camera shaking is severe, the corrections result in significant geometric distortion (

Re: [FFmpeg-devel] [PATCH] avfilter: add dewobble_opencl filter

2021-08-15 Thread Paul B Mahol
Non native filters can not be named like this. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v2 1/1] return value check for init_get_bits in vc1dec.c

2021-08-15 Thread Paul B Mahol
Please always keep style consistent, use space between else{ ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "u

Re: [FFmpeg-devel] [PATCH] Handle AV_PIX_FMT_PAL8

2021-08-15 Thread Nicolas George
Ray (12021-08-15): > Subject: Re: [FFmpeg-devel] [PATCH] Handle AV_PIX_FMT_PAL8 Context missing. Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/l

Re: [FFmpeg-devel] [PATCH] Handle AV_PIX_FMT_PAL8

2021-08-15 Thread Nicolas George
> Subject: Re: [FFmpeg-devel] [PATCH] Handle AV_PIX_FMT_PAL8 Context missing again. -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel T

Re: [FFmpeg-devel] [PATCH] Handle AV_PIX_FMT_PAL8

2021-08-15 Thread Nicolas George
Ray (12021-08-15): > --- > libavformat/riffenc.c | 9 - > 1 file changed, 8 insertions(+), 1 deletion(-) Context still missing. Please send related patches in the same thread. -- Nicolas George signature.asc Description: PGP signature ___

[FFmpeg-devel] [PATCH] doc/git-howto: be more strict about commit message formatting.

2021-08-15 Thread Nicolas George
Explain the format of the first line: "context: summary". Add examples and explain bad practices. Make it a section, so that we can link to it. Signed-off-by: Nicolas George --- doc/git-howto.texi | 38 ++ 1 file changed, 34 insertions(+), 4 deletions(-) Jam

Re: [FFmpeg-devel] [PATCH] avfilter: add dewobble_opencl filter

2021-08-15 Thread Daniel Playfair Cal
On Sun, Aug 15, 2021 at 6:18 PM Paul B Mahol wrote: > Non native filters can not be named like this. OK, how would you suggest to name it - just "dewobble"? My thinking was that since the user must ensure that the input/output is OpenCL hardware frames (e.g. using hwupload/hwmap), the "_opencl"

Re: [FFmpeg-devel] [PATCH] Handle AV_PIX_FMT_PAL8

2021-08-15 Thread Nicolas George
一滴水 (12021-08-15): > what's mean? should i commit my changes based on last commit of  master > branch? See: https://ffmpeg.org/pipermail/ffmpeg-devel/2021-August/283780.html Do not top-post in the future; if you do not know what it means, look it up. Do not send e-mails full of bogus HTML entit

[FFmpeg-devel] Patchwork hook for bad commit messages

2021-08-15 Thread Nicolas George
Is it possible to add hooks in Patchwork to warn people automatically when their commit message does not match standards? If it is possible, I volunteer to write it. Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-de

Re: [FFmpeg-devel] [PATCH] [fateserver] Cleanup and security strengthening

2021-08-15 Thread Nicolas George
Nicolas George (12021-08-08): > Here is a patch series for fateserver, to fix warnings and enable Perl's > taint checks, thus protecting against a whole class of security issues. I would appreciate somebody looks at the code before I deploy it and we re-enable the server. Regards, -- Nicolas

[FFmpeg-devel] [PATCH 01/10] fftools/cmdutils: Use avfilter_pad_count() for AVFilter's number of pads

2021-08-15 Thread Andreas Rheinhardt
Besides being nicer code this also has the advantage of not making assumptions about the internal implementation: While it is documented that the AVFilter.inputs and AVFilter.outputs arrays are terminated by a zeroed sentinel, one is not allowed to infer that one can just check avfilter_pad_get_nam

Re: [FFmpeg-devel] Patchwork hook for bad commit messages

2021-08-15 Thread Michael Niedermayer
On Sun, Aug 15, 2021 at 11:17:26AM +0200, Nicolas George wrote: > Is it possible to add hooks in Patchwork to warn people automatically > when their commit message does not match standards? > > If it is possible, I volunteer to write it. We could also add a fate test that checks the commit messag

[FFmpeg-devel] [PATCH 03/10] avfilter/avfilter: Add avfilter_filter_pad_count()

2021-08-15 Thread Andreas Rheinhardt
It is intended as replacement for avfilter_pad_count(). In contrast to the latter, it avoids a loop. Signed-off-by: Andreas Rheinhardt --- Missing APIchanges entry and version bump. libavfilter/avfilter.c | 5 + libavfilter/avfilter.h | 5 + 2 files changed, 10 insertions(+) diff --git

[FFmpeg-devel] [PATCH 04/10] fftools/cmdutils: Switch to avfilter_filter_pad_count()

2021-08-15 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- fftools/cmdutils.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/fftools/cmdutils.c b/fftools/cmdutils.c index 96d38803df..2dd035a7cf 100644 --- a/fftools/cmdutils.c +++ b/fftools/cmdutils.c @@ -1713,7 +1713,7 @@ int show_filters(v

[FFmpeg-devel] [PATCH 05/10] avfilter/avfilter: Deprecate avfilter_pad_count()

2021-08-15 Thread Andreas Rheinhardt
It is unnecessary as the number of static inputs and outputs can now be directly read via AVFilter.nb_(in|out)puts. Signed-off-by: Andreas Rheinhardt --- libavfilter/avfilter.h | 5 + libavfilter/version.h | 3 +++ 2 files changed, 8 insertions(+) diff --git a/libavfilter/avfilter.h b/liba

[FFmpeg-devel] [PATCH 06/10] avfilter/vf_coreimage: Simplify query_formats

2021-08-15 Thread Andreas Rheinhardt
Using ff_set_common_formats_from_list() avoids using different functions depending upon how many inputs the filter has. Signed-off-by: Andreas Rheinhardt --- Untested as I don't have a mac. libavfilter/vf_coreimage.m | 37 ++--- 1 file changed, 2 insertions(+), 3

[FFmpeg-devel] [PATCH 07/10] avfilter/vf_fieldorder: Simplify setting common pixel formats

2021-08-15 Thread Andreas Rheinhardt
by using ff_set_common_formats(). Signed-off-by: Andreas Rheinhardt --- libavfilter/vf_fieldorder.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/libavfilter/vf_fieldorder.c b/libavfilter/vf_fieldorder.c index c045d1634d..d34119c920 100644 --- a/libavfilter/vf_fieldorder

[FFmpeg-devel] [PATCH 08/10] avfilter/formats: Avoid redundant counter

2021-08-15 Thread Andreas Rheinhardt
The ff_set_common_(formats|channel_layouts|samplerates) have to free their list in case it doesn't have an owner; therefore they tracked whether they attached it to an owner. But the list's refcount already contains such a counter, so we don't have to keep track of whether we have attached the list

[FFmpeg-devel] [PATCH 09/10] avfilter/formats: Don't set samplerate or channel count on video links

2021-08-15 Thread Andreas Rheinhardt
This currently happens by accident in a few filters that use ff_set_common_(samplerates|channel_layouts) like afir (if the response option is set) or agraphmonitor (due to the default code in avfiltergraph.c). So change those functions to make sure it does no longer happen. Signed-off-by: Andreas

[FFmpeg-devel] [PATCH 10/10] avfilter/avfiltergraph: Remove dead checks

2021-08-15 Thread Andreas Rheinhardt
These checks emit warnings in case the channel layouts lists are inconsistent; yet since 69f5f6ea375950b4845b241ee27054bfc8f00343 a function that is called earlier errors out if they are inconsistent. Signed-off-by: Andreas Rheinhardt --- This relies on no audio parts being set for video links, b

Re: [FFmpeg-devel] [PATCH 07/10] avfilter/vf_fieldorder: Simplify setting common pixel formats

2021-08-15 Thread Paul B Mahol
LGTM ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 05/10] avfilter/avfilter: Deprecate avfilter_pad_count()

2021-08-15 Thread Paul B Mahol
and what about dynamic number of pads? ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 05/10] avfilter/avfilter: Deprecate avfilter_pad_count()

2021-08-15 Thread Andreas Rheinhardt
Paul B Mahol: > and what about dynamic number of pads? > Dynamic pads are counted in AVFilterContext.nb_(input|output). Notice that avfilter_pad_count() is not usable with them at all, because these arrays are not zero-terminated. avfilter_pad_count() is only usable with AVFilter.inputs and AVFilt

Re: [FFmpeg-devel] [PATCH] avfilter: add dewobble_opencl filter

2021-08-15 Thread Lynne
15 Aug 2021, 11:13 by daniel.playfair@gmail.com: > On Sun, Aug 15, 2021 at 6:18 PM Paul B Mahol wrote: > >> Non native filters can not be named like this. >> > > OK, how would you suggest to name it - just "dewobble"? > > My thinking was that since the user must ensure that the input/output >

[FFmpeg-devel] [PATCH v3 1/1] return value check for init_get_bits in vc1dec.c

2021-08-15 Thread maryam ebrahimzadeh
--- libavcodec/vc1dec.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/libavcodec/vc1dec.c b/libavcodec/vc1dec.c index 1fb1950ade..0f7c07f2e8 100644 --- a/libavcodec/vc1dec.c +++ b/libavcodec/vc1dec.c @@ -444,7 +444,9 @@ static av_cold int vc1_decode_init(AVCodecCo

Re: [FFmpeg-devel] [PATCH v3 1/1] return value check for init_get_bits in vc1dec.c

2021-08-15 Thread Maryam Ebrahimzadeh
As the second argument for init_get_bits (avctx and bus ) can be crafted, a return value check for this function call is necessary so replace init_get_bits with init_get_bits8. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/

Re: [FFmpeg-devel] [PATCH v3 1/1] return value check for init_get_bits in vc1dec.c

2021-08-15 Thread Nicolas George
maryam ebrahimzadeh (12021-08-15): > --- > libavcodec/vc1dec.c | 11 --- > 1 file changed, 8 insertions(+), 3 deletions(-) See: https://ffmpeg.org/pipermail/ffmpeg-devel/2021-August/283780.html for commit message formatting. Regards, -- Nicolas George signature.asc Description: PGP

Re: [FFmpeg-devel] Patchwork hook for bad commit messages

2021-08-15 Thread Lynne
15 Aug 2021, 11:49 by mich...@niedermayer.cc: > On Sun, Aug 15, 2021 at 11:17:26AM +0200, Nicolas George wrote: > >> Is it possible to add hooks in Patchwork to warn people automatically >> when their commit message does not match standards? >> >> If it is possible, I volunteer to write it. >> > >

Re: [FFmpeg-devel] Patchwork hook for bad commit messages

2021-08-15 Thread Nicolas George
Lynne (12021-08-15): > Could you acknowledge that at least some commits do not deserve > mandatory 3-line vapid comments? I have no idea what you are talking about. The hook I am suggesting would catch: - cases without "context:" on the first line, like: [FFmpeg-devel] [PATCH] Handle AV_PIX_FM

Re: [FFmpeg-devel] Patchwork hook for bad commit messages

2021-08-15 Thread Nicolas George
Michael Niedermayer (12021-08-15): > We could also add a fate test that checks the commit messages between > master (if == HEAD) and origin > iam not sure if people want this but it could eliminate some bad messages > before even reaching the mailing list (if the developer did run make fate) I am

[FFmpeg-devel] [PATCH] add color table for 8-bit gray scale raw image data

2021-08-15 Thread Ray
From: unknown <2010263...@qq.com> --- libavformat/riffenc.c | 9 + 1 file changed, 9 insertions(+) diff --git a/libavformat/riffenc.c b/libavformat/riffenc.c index c04d55c423..e33bcdb339 100644 --- a/libavformat/riffenc.c +++ b/libavformat/riffenc.c @@ -242,6 +242,15 @@ void ff_put_bmp_h

[FFmpeg-devel] [PATCH] add color table for 8-bit gray scale raw image data

2021-08-15 Thread ??????
From: RaydroidX <229135...@qq.com> ---  libavformat/riffenc.c | 9 +  1 file changed, 9 insertions(+) diff --git a/libavformat/riffenc.c b/libavformat/riffenc.c index c04d55c423..e33bcdb339 100644 --- a/libavformat/riffenc.c +++ b/libavformat/riffenc.c @@ -242,6 +242,15 @@ void ff_put_bmp_

Re: [FFmpeg-devel] Patchwork hook for bad commit messages

2021-08-15 Thread Andreas Rheinhardt
Nicolas George: > Michael Niedermayer (12021-08-15): >> We could also add a fate test that checks the commit messages between >> master (if == HEAD) and origin >> iam not sure if people want this but it could eliminate some bad messages >> before even reaching the mailing list (if the developer did

[FFmpeg-devel] [PATCH v3 1/1] return value check for init_get_bits in vc1dec.c

2021-08-15 Thread maryam ebrahimzadeh
Return value check: return value check for init_get_bits in vc1dec.c As the second argument for init_get_bits(avctx and buf) can be crafted, a return value check for this function call is necessary so replace init_get_bits with init_get_bits8. --- libavcodec/vc1dec.c | 11 --- 1 file c

Re: [FFmpeg-devel] [PATCH v3 1/1] return value check for init_get_bits in vc1dec.c

2021-08-15 Thread Nicolas George
maryam ebrahimzadeh (12021-08-15): > Return value check: return value check for init_get_bits in vc1dec.c See: https://ffmpeg.org/pipermail/ffmpeg-devel/2021-August/283780.html Regards, -- Nicolas George signature.asc Description: PGP signature _

Re: [FFmpeg-devel] Patchwork hook for bad commit messages

2021-08-15 Thread Andriy Gelman
On Sun, 15. Aug 11:17, Nicolas George wrote: > Is it possible to add hooks in Patchwork to warn people automatically > when their commit message does not match standards? > > If it is possible, I volunteer to write it. > Yes, nice idea. If the commit message is invalid I could add a warning sim

Re: [FFmpeg-devel] [PATCH v3 1/1] return value check for init_get_bits in vc1dec.c

2021-08-15 Thread Paul B Mahol
Please make patch subject like: avcodec/vc1dec: return value check for .. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org w

Re: [FFmpeg-devel] Patchwork hook for bad commit messages

2021-08-15 Thread Nicolas George
Andriy Gelman (12021-08-15): > Yes, nice idea. > > If the commit message is invalid I could add a warning similar to: > https://patchwork.ffmpeg.org/project/ffmpeg/patch/20210809102919.387-1-an...@khirnov.net/ > and trigger an automated email to the author. > > Feel free to send me the parsing pa

Re: [FFmpeg-devel] Patchwork hook for bad commit messages

2021-08-15 Thread Andriy Gelman
On Sun, 15. Aug 14:22, Nicolas George wrote: > Andriy Gelman (12021-08-15): > > Yes, nice idea. > > > > If the commit message is invalid I could add a warning similar to: > > https://patchwork.ffmpeg.org/project/ffmpeg/patch/20210809102919.387-1-an...@khirnov.net/ > > and trigger an automated emai

[FFmpeg-devel] [PATCH] avcodec/options_table: Treat (request_)channel_layout as channel layout

2021-08-15 Thread Andreas Rheinhardt
Also adapt some FATE tests to already cover this. Signed-off-by: Andreas Rheinhardt --- libavcodec/options_table.h | 4 ++-- tests/fate/ac3.mak | 9 - tests/fate/dca.mak | 5 +++-- tests/fate/truehd.mak | 2 +- 4 files changed, 10 insertions(+), 10 deletions(-) diff

Re: [FFmpeg-devel] [PATCH] avcodec/options_table: Treat (request_)channel_layout as channel layout

2021-08-15 Thread Paul B Mahol
lgtm ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH] Handle AV_PIX_FMT_PAL8

2021-08-15 Thread Ray
--- libavformat/riffenc.c | 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/libavformat/riffenc.c b/libavformat/riffenc.c index 971c4a7eb8..69761431da 100644 --- a/libavformat/riffenc.c +++ b/libavformat/riffenc.c @@ -250,15 +250,6 @@ void ff_put_bmp_header(AVIOC

[FFmpeg-devel] [PATCH v4 1/1] avcodec/vc1dec: return value check for init_get_bits

2021-08-15 Thread maryam ebrahimzadeh
avcodec/vc1dec: return value check for init_get_bits As the second argument for init_get_bits(avctx and buf) can be crafted, a return value check for this function call is necessary so replace init_get_bits with init_get_bits8. --- libavcodec/vc1dec.c | 11 --- 1 file changed, 8 inser

[FFmpeg-devel] [PATCH] Handle AV_PIX_FMT_PAL8

2021-08-15 Thread Ray
--- libavformat/riffenc.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/libavformat/riffenc.c b/libavformat/riffenc.c index c04d55c423..3171c152f0 100644 --- a/libavformat/riffenc.c +++ b/libavformat/riffenc.c @@ -255,6 +255,13 @@ void ff_put_bmp_header(AVIOContext *pb, AVCodecParamet

[FFmpeg-devel] [PATCH] Handle AV_PIX_FMT_PAL8

2021-08-15 Thread Ray
--- libavformat/riffenc.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/libavformat/riffenc.c b/libavformat/riffenc.c index 971c4a7eb8..6926fbf060 100644 --- a/libavformat/riffenc.c +++ b/libavformat/riffenc.c @@ -271,7 +271,14 @@ void ff_put_bmp_header(AVIOContext *p

Re: [FFmpeg-devel] Patchwork hook for bad commit messages

2021-08-15 Thread Lynne
15 Aug 2021, 13:39 by geo...@nsup.org: > Lynne (12021-08-15): > >> Could you acknowledge that at least some commits do not deserve >> mandatory 3-line vapid comments? >> > > I have no idea what you are talking about. > > The hook I am suggesting would catch: > > - cases without "context:" on the f

Re: [FFmpeg-devel] Patchwork hook for bad commit messages

2021-08-15 Thread Nicolas George
Lynne (12021-08-15): > Oh, that's all fine. I was talking about the change to the developer manual, > about adding patch descriptions. Sometimes, you just don't need any. The change I proposed says: "then if necessary a body with details". Do you think it would be better if the "if necessary" par

Re: [FFmpeg-devel] [PATCH] Handle AV_PIX_FMT_PAL8

2021-08-15 Thread ??????
what's mean?? should i commit my changes based on last commit of  master branch?? -- Original -- From: "ffmpeg-devel"

[FFmpeg-devel] [PATCH] Handle AV_PIX_FMT_PAL8

2021-08-15 Thread ??????
Signed-off-by: Ray <229135...@qq.com> ---  libavformat/riffenc.c | 9 -  1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/libavformat/riffenc.c b/libavformat/riffenc.c index 971c4a7eb8..6926fbf060 100644 --- a/libavformat/riffenc.c +++ b/libavformat/riffenc.c @@ -271,7 +271,14 @@

[FFmpeg-devel] Optimised math functions in FFMPEG?

2021-08-15 Thread Paul Buxton
Hi, I have my filter working nicely but it is a little slow. I have parallelised it where possible, but it is still a bit heavy. I am wondering if there are any optimised implementations/approximations of some math functions built in that I should use instead of the standard library implementation

Re: [FFmpeg-devel] Optimised math functions in FFMPEG?

2021-08-15 Thread Nicolas George
Paul Buxton (12021-08-15): > I have my filter working nicely but it is a little slow. I have > parallelised it where possible, but it is still a bit heavy. I am wondering > if there are any optimised implementations/approximations of some math > functions built in that I should use instead of the s

Re: [FFmpeg-devel] Optimised math functions in FFMPEG?

2021-08-15 Thread Paul B Mahol
On Sun, Aug 15, 2021 at 3:27 PM Nicolas George wrote: > Paul Buxton (12021-08-15): > > I have my filter working nicely but it is a little slow. I have > > parallelised it where possible, but it is still a bit heavy. I am > wondering > > if there are any optimised implementations/approximations of

Re: [FFmpeg-devel] Optimised math functions in FFMPEG?

2021-08-15 Thread Paul Buxton
Thanks both. I have implemented the algorithm in this paper https://www.researchgate.net/publication/275213614_A_New_Color_Correction_Method_for_Underwater_Imaging Which basically converts to an L A B (not CIELAB) colorspace, subtracts the average value of the frame from each pixel and converts b

Re: [FFmpeg-devel] Patchwork hook for bad commit messages

2021-08-15 Thread Nicolas George
Andriy Gelman (12021-08-15): > That sounds fine. See the attached code. I have tested it against the 2721 commits I have since the beginning of the year, it finds 56 to object, about half of them real problems, a few with unusually long context (I set the limit at the last percentile) and admitt

Re: [FFmpeg-devel] [PATCH v4 1/1] avcodec/vc1dec: return value check for init_get_bits

2021-08-15 Thread Paul B Mahol
why are there whitespaces before text in the commit log? ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsub

[FFmpeg-devel] avformat/hlsplaylist: Support FRAME-RATE attribute

2021-08-15 Thread Arzet Ro
https://datatracker.ietf.org/doc/html/rfc8216#page-31 Signed-off-by: Arzet Ro --- libavformat/hlsplaylist.c | 25 - 1 file changed, 24 insertions(+), 1 deletion(-) diff --git a/libavformat/hlsplaylist.c b/libavformat/hlsplaylist.c index 0e1dcc087f..c3ec86f2ab 100644 ---

Re: [FFmpeg-devel] Optimised math functions in FFMPEG?

2021-08-15 Thread Paul B Mahol
On Sun, Aug 15, 2021 at 3:43 PM Paul Buxton wrote: > Thanks both. > > I have implemented the algorithm in this paper > > https://www.researchgate.net/publication/275213614_A_New_Color_Correction_Method_for_Underwater_Imaging > > Which basically converts to an L A B (not CIELAB) colorspace, subtra

Re: [FFmpeg-devel] Patchwork hook for bad commit messages

2021-08-15 Thread Michael Niedermayer
On Sun, Aug 15, 2021 at 08:18:17AM -0400, Andriy Gelman wrote: > On Sun, 15. Aug 11:17, Nicolas George wrote: > > Is it possible to add hooks in Patchwork to warn people automatically > > when their commit message does not match standards? > > > > If it is possible, I volunteer to write it. > > >

Re: [FFmpeg-devel] Optimised math functions in FFMPEG?

2021-08-15 Thread Paul Buxton
So construct filtergraph with 1. zscale with a linear transfer function 2. color correction filter (I am calling it underwater correction, but nothing it does is actually specific to underwater images, it is simply a grey world based algorithm for whitebalance). 3. zscale with desir

Re: [FFmpeg-devel] Optimised math functions in FFMPEG?

2021-08-15 Thread Paul B Mahol
On Sun, Aug 15, 2021 at 6:05 PM Paul Buxton wrote: > So construct filtergraph with > >1. zscale with a linear transfer function >2. color correction filter (I am calling it underwater correction, but >nothing it does is actually specific to underwater images, it is simply > a >gre

Re: [FFmpeg-devel] Optimised math functions in FFMPEG?

2021-08-15 Thread Ronald S. Bultje
Hi Paul, On Sun, Aug 15, 2021 at 9:25 AM Paul Buxton wrote: > Specifically any of > pow() > exp() > log() > pow(a, b) = exp(log(a) * b), so you only need exp/log. As for exp/log optimized versions, there's two approaches that may work for you. First, integer operation is critical (e.g. 16-bit

Re: [FFmpeg-devel] [PATCH v4 1/1] avcodec/vc1dec: return value check for init_get_bits

2021-08-15 Thread Maryam Ebrahimzadeh
Paul B Mahol mailto:one...@gmail.com>> wrote: why are there whitespaces before text in the commit log? Sorry, which do you mean? — Maryam Ebrahimzadeh ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-de

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/h264dec: apply H.274 film grain

2021-08-15 Thread Michael Niedermayer
On Sat, Aug 14, 2021 at 01:36:20PM +0200, Niklas Haas wrote: > From: Niklas Haas > > Because we need access to ref frames without film grain applied, we have > to add an extra AVFrame to H264Picture to avoid messing with the > original. This requires some amount of overhead to make the reference

Re: [FFmpeg-devel] [PATCH v3] avcodec/frame_thread_encoder: Free AVCodecContext structure on error during init

2021-08-15 Thread Andreas Rheinhardt
Michael Niedermayer: > Fixes: MemLeak > Fixes: 8281 > Fixes: PoC_option158.jpg > Fixes: CVE-2020-22037 > > Signed-off-by: Michael Niedermayer > --- > libavcodec/frame_thread_encoder.c | 11 +++ > libavcodec/frame_thread_encoder.h | 4 > 2 files changed, 11 insertions(+), 4 deletion

Re: [FFmpeg-devel] Patchwork hook for bad commit messages

2021-08-15 Thread Andriy Gelman
On Sun, 15. Aug 17:15, Michael Niedermayer wrote: > On Sun, Aug 15, 2021 at 08:18:17AM -0400, Andriy Gelman wrote: > > On Sun, 15. Aug 11:17, Nicolas George wrote: > > > Is it possible to add hooks in Patchwork to warn people automatically > > > when their commit message does not match standards? >

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/snowdec: Cleanup avmv on errors

2021-08-15 Thread Michael Niedermayer
On Sun, Aug 15, 2021 at 04:15:25AM +0200, Andreas Rheinhardt wrote: > Marton Balint: > > > > > > On Sun, 15 Aug 2021, "zhilizhao(赵志立)" wrote: > > > >> > >> > >>> On Aug 14, 2021, at 11:52 PM, Michael Niedermayer > >>> wrote: > >>> > >>> On Sat, Aug 14, 2021 at 11:45:59PM +0800, "zhilizhao(赵志立)"

Re: [FFmpeg-devel] Patchwork hook for bad commit messages

2021-08-15 Thread Andriy Gelman
On Sun, 15. Aug 16:04, Nicolas George wrote: > Andriy Gelman (12021-08-15): > > That sounds fine. > > See the attached code. > > I have tested it against the 2721 commits I have since the beginning of > the year, it finds 56 to object, about half of them real problems, a few > with unusually lon

[FFmpeg-devel] [PATCH 1/4] libavcodec/adts_header: add frame_length field and avpriv function to parse AAC ADTS header

2021-08-15 Thread Nachiket Tarate
These will be used by HLS demuxer in case of sample decryption. Signed-off-by: Nachiket Tarate --- libavcodec/adts_header.c | 1 + libavcodec/adts_header.h | 14 ++ libavcodec/adts_parser.c | 32 3 files changed, 47 insertions(+) diff --git a/libavc

[FFmpeg-devel] [PATCH 2/4] libavformat/mov: add support for 'cens', 'cbc1' and 'cbcs' encryption schemes specified in Common Encryption (CENC) standard

2021-08-15 Thread Nachiket Tarate
correct implementation of 'cenc' encryption scheme to support decryption of partial cipher blocks at the end of subsamples https://www.iso.org/standard/68042.html Signed-off-by: Nachiket Tarate --- libavformat/isom.h | 2 + libavformat/mov.c | 246 +++

[FFmpeg-devel] [PATCH 3/4] libavformat/hls: add support for decryption of HLS media segments encrypted using SAMPLE-AES encryption method

2021-08-15 Thread Nachiket Tarate
Apple HTTP Live Streaming Sample Encryption: https://developer.apple.com/library/ios/documentation/AudioVideo/Conceptual/HLS_Sample_Encryption Signed-off-by: Nachiket Tarate --- libavformat/Makefile| 2 +- libavformat/hls.c | 128 +++-- libavformat/hls_sa

[FFmpeg-devel] [PATCH 4/4] libavformat/hls: correct indentation

2021-08-15 Thread Nachiket Tarate
Signed-off-by: Nachiket Tarate --- libavformat/hls.c | 34 +- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/libavformat/hls.c b/libavformat/hls.c index 022dae0391..7e457281f4 100644 --- a/libavformat/hls.c +++ b/libavformat/hls.c @@ -2051,23 +2051

Re: [FFmpeg-devel] [PATCH 2/6] avfilter/vf_paletteuse: Remove redundant freeing code

2021-08-15 Thread Andreas Rheinhardt
Andreas Rheinhardt: > AVFilter.uninit is called automatically if init fails. > > Signed-off-by: Andreas Rheinhardt > --- > libavfilter/vf_paletteuse.c | 5 + > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/libavfilter/vf_paletteuse.c b/libavfilter/vf_paletteuse.c > index f

[FFmpeg-devel] [PATCH] avcodec/snowdec: Maintain avmv buffer

2021-08-15 Thread Michael Niedermayer
This avoids reallocating per frame Fixes: Assertion failure Fixes: 36359/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SNOW_fuzzer-6733238591684608 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- li

Re: [FFmpeg-devel] [PATCH v4 4/4] avdevice/decklink: support for more duplex mode for Decklink 8K Pro

2021-08-15 Thread Marton Balint
On Fri, 13 Aug 2021, lance.lmw...@gmail.com wrote: From: Limin Wang Reviewed-by: Marton Balint Signed-off-by: Limin Wang --- doc/indevs.texi | 16 +++- doc/outdevs.texi| 16 +++- libavdevice/decklink_common.cpp | 8 ++-- libavdevic

Re: [FFmpeg-devel] [PATCH v2 1/5] libavfilter/x86/vf_gblur: add ff_postscale_slice_avx512()

2021-08-15 Thread Wu, Jianhua
Paul B Mahol Wrote: > will apply if nobody complains. Hi Paul, It seemed that there is no more objection to the patches. Is it able to get to the next step? Feel free to let me know if there is any other problem. Best regards. Jianhua ___ ffmpeg-dev

Re: [FFmpeg-devel] [PATCH v4 4/4] avdevice/decklink: support for more duplex mode for Decklink 8K Pro

2021-08-15 Thread lance . lmwang
On Mon, Aug 16, 2021 at 12:23:40AM +0200, Marton Balint wrote: > > > On Fri, 13 Aug 2021, lance.lmw...@gmail.com wrote: > > > From: Limin Wang > > > > Reviewed-by: Marton Balint > > Signed-off-by: Limin Wang > > --- > > doc/indevs.texi | 16 +++- > > doc/outdevs.te

Re: [FFmpeg-devel] [PATCH 1/4] libavcodec/adts_header: add frame_length field and avpriv function to parse AAC ADTS header

2021-08-15 Thread Steven Liu
> 2021年8月16日 上午2:25,Nachiket Tarate 写道: > > These will be used by HLS demuxer in case of sample decryption. > > Signed-off-by: Nachiket Tarate > --- > libavcodec/adts_header.c | 1 + > libavcodec/adts_header.h | 14 ++ > libavcodec/adts_parser.c | 32 +++

Re: [FFmpeg-devel] [PATCH 01/23] avfilter/vf_(guided|program_opencl): Add missing dynamic inputs flag

2021-08-15 Thread Andreas Rheinhardt
Andreas Rheinhardt: > The code for inserting inpads can't be reached by ff_vsrc_openclsrc > (unsurprising given that it is a source filter), so it didn't get > the flag. > > Signed-off-by: Andreas Rheinhardt > --- > libavfilter/vf_guided.c | 3 ++- > libavfilter/vf_program_opencl.c | 1 +

Re: [FFmpeg-devel] [PATCH 1/4] libavcodec/adts_header: add frame_length field and avpriv function to parse AAC ADTS header

2021-08-15 Thread zhilizhao(赵志立)
> On Aug 16, 2021, at 2:25 AM, Nachiket Tarate > wrote: > > These will be used by HLS demuxer in case of sample decryption. > > Signed-off-by: Nachiket Tarate > --- > libavcodec/adts_header.c | 1 + > libavcodec/adts_header.h | 14 ++ > libavcodec/adts_parser.c | 32 ++

Re: [FFmpeg-devel] [PATCH 1/4] libavcodec/adts_header: add frame_length field and avpriv function to parse AAC ADTS header

2021-08-15 Thread James Almer
On 8/16/2021 12:08 AM, "zhilizhao(赵志立)" wrote: On Aug 16, 2021, at 2:25 AM, Nachiket Tarate wrote: These will be used by HLS demuxer in case of sample decryption. Signed-off-by: Nachiket Tarate --- libavcodec/adts_header.c | 1 + libavcodec/adts_header.h | 14 ++ libavcodec/adt

Re: [FFmpeg-devel] [PATCH 1/4] libavcodec/adts_header: add frame_length field and avpriv function to parse AAC ADTS header

2021-08-15 Thread zhilizhao(赵志立)
> On Aug 16, 2021, at 11:19 AM, James Almer wrote: > > On 8/16/2021 12:08 AM, "zhilizhao(赵志立)" wrote: >>> On Aug 16, 2021, at 2:25 AM, Nachiket Tarate >>> wrote: >>> >>> These will be used by HLS demuxer in case of sample decryption. >>> >>> Signed-off-by: Nachiket Tarate >>> --- >>> libav

Re: [FFmpeg-devel] [PATCH 1/4] libavcodec/adts_header: add frame_length field and avpriv function to parse AAC ADTS header

2021-08-15 Thread Andreas Rheinhardt
"zhilizhao(赵志立)": > > >> On Aug 16, 2021, at 11:19 AM, James Almer wrote: >> >> On 8/16/2021 12:08 AM, "zhilizhao(赵志立)" wrote: On Aug 16, 2021, at 2:25 AM, Nachiket Tarate wrote: These will be used by HLS demuxer in case of sample decryption. Signed-off-by: Nachik