Re: [FFmpeg-devel] [PATCH 2/3] libavformat/hls: add support for decryption of HLS streams in MPEG-TS format protected using SAMPLE-AES encryption

2021-03-08 Thread Nachiket Tarate
On Wed, Mar 3, 2021 at 11:15 AM Nachiket Tarate wrote: > > On Mon, Mar 1, 2021 at 1:05 PM Steven Liu wrote: > > > > > > > > > 2021年3月1日 下午3:22,Nachiket Tarate 写道: > > > > > > On Mon, Mar 1, 2021 at 11:30 AM Steven Liu wrote: > > >> > > >> > > >> > > >>> 2021年3月1日 下午12:55,Nachiket Tarate 写道: >

Re: [FFmpeg-devel] [PATCH]lavf/sga: Fix several format specifiers

2021-03-08 Thread Anton Khirnov
Quoting Carl Eugen Hoyos (2021-03-04 22:47:57) > Am Do., 4. März 2021 um 22:23 Uhr schrieb Moritz Barsnick : > > > > On Thu, Mar 04, 2021 at 20:37:26 +0100, Carl Eugen Hoyos wrote: > > > attached patch fixes a few warnings when compiling for 32bit. > > > > > av_log(s, AV_LOG_DEBUG, "START %s\n

Re: [FFmpeg-devel] [PATCH 2/3] libavformat/hls: add support for decryption of HLS streams in MPEG-TS format protected using SAMPLE-AES encryption

2021-03-08 Thread Steven Liu
> 2021年3月8日 下午3:15,Nachiket Tarate 写道: >> >> Your understanding of SAMPLE-AES is absolutely correct. >> >> I am insisting that let us add support for it in 2 phases as >> completely 2 different specifications have been used. >> >> Phase 1 : Media segments in MPEG-TS, AAC, AC-3 and Enhanced AC

Re: [FFmpeg-devel] [PATCH V5 3/5] libavutil: add side data AV_FRAME_DATA_BOUNDING_BOXES

2021-03-08 Thread Anton Khirnov
Quoting Guo, Yejun (2021-03-08 06:05:20) > Signed-off-by: Guo, Yejun > --- > doc/APIchanges| 2 ++ > libavutil/frame.c | 1 + > libavutil/frame.h | 5 + > 3 files changed, 8 insertions(+) > > diff --git a/doc/APIchanges b/doc/APIchanges > index 4027d599e7..b83409a412 100644 > --- a/doc/A

[FFmpeg-devel] [PATCH] cmdutils: replace strncpy() with equivalent memcpy()

2021-03-08 Thread Anton Khirnov
Fixes truncation warnings, such as warning: ‘strncpy’ output truncated before terminating nul copying 3 bytes from a string of the same length [-Wstringop-truncation] in gcc 10.2.0 --- fftools/cmdutils.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fftools/cmdutils.c b/

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/mediacodec_wrapper: use MediaCodecInfo.isSoftwareOnly() when available

2021-03-08 Thread Matthieu Bouron
On Wed, Feb 17, 2021 at 04:51:09PM +0100, sfan5 wrote: > > From 22ebde779f61fb030633a881ef320264ea446b6b Mon Sep 17 00:00:00 2001 > From: sfan5 > Date: Thu, 11 Feb 2021 20:48:54 +0100 > Subject: [PATCH 2/2] avcodec/mediacodec_wrapper: use > MediaCodecInfo.isSoftwareOnly() when available > > Ad

Re: [FFmpeg-devel] [PATCH v4 2/2] avformat/gopher: Add support for Gopher over TLS.

2021-03-08 Thread Ivan J.
Bump for review. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH]lavf/sga: Fix several format specifiers

2021-03-08 Thread Paul B Mahol
On Mon, Mar 8, 2021 at 9:22 AM Anton Khirnov wrote: > Quoting Carl Eugen Hoyos (2021-03-04 22:47:57) > > Am Do., 4. März 2021 um 22:23 Uhr schrieb Moritz Barsnick < > barsn...@gmx.net>: > > > > > > On Thu, Mar 04, 2021 at 20:37:26 +0100, Carl Eugen Hoyos wrote: > > > > attached patch fixes a few

[FFmpeg-devel] Re: [PATCH 4/7] avcodec/h261dec: Remove parse_context cruft

2021-03-08 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2020-12-25 16:47:21) > The H.261 decoder doesn't use the ParseContext of its > MpegEncContext since e7316976650b429345da619c3acff38004aaf6b8. > > Signed-off-by: Andreas Rheinhardt > --- Looks good, please push. > Does actually anybody use the AV_CODEC_FLAG_TRUNCATED

[FFmpeg-devel] [PATCH] mobiclip: fix copyright headers

2021-03-08 Thread Florian Nouwt
0001-mobiclip-fix-copyright-headers.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with s

[FFmpeg-devel] [PATCH 1/2] lavc: deprecate AV_CODEC_FLAG_TRUNCATED

2021-03-08 Thread Anton Khirnov
It is supported only by two decoders and is entirely redundant with parsers. --- doc/APIchanges | 3 +++ libavcodec/avcodec.h | 4 libavcodec/decode.c| 6 +- libavcodec/h263dec.c | 10 -- libavcodec/mpeg12dec.c | 12 +++- libavcodec/m

[FFmpeg-devel] [PATCH 2/2] Revert "fate: Add test for ticket 6024, truncated decoding mode"

2021-03-08 Thread Anton Khirnov
This reverts commit 47cd8effea343e71c4010929ed3fb10dd3dca4b1. AV_CODEC_FLAG_TRUNCATED is now deprecated. --- tests/fate/video.mak| 3 --- tests/ref/fate/mpeg2-ticket6024 | 27 --- 2 files changed, 30 deletions(-) delete mode 100644 tests/ref/fate/mpeg2-ticket6

[FFmpeg-devel] [PATCH] avutil/hwcontext_d3d11va: Support DXGI_FORMAT_B8G8R8A8_UNORM encoding

2021-03-08 Thread you74674
From: you74674 Support using DXGI_FORMAT_B8G8R8A8_UNORM format ID3D11Texture2D texture as AVCodecContext->hw_frames_ctx for encoding. AV_PIX_FMT_0RGB32 is used here because in libavcodec/nvenc.c, it is mapped to NV_ENC_BUFFER_FORMAT_ARGB, which is mapped to DXGI_FORMAT_B8G8R8A8_UNORM in sample co

[FFmpeg-devel] [PATCH] mobiclip: fix copyright headers

2021-03-08 Thread Florian Nouwt
The Mobiclip related code was based on Mobius (https://github.com/adibsurani/Mobius), which was based on my original reverse engineering efforts (https://github.com/Gericom/MobiclipDecoder). This commit adds the appropriate copyright headers on the related files. Signed-off-by: Florian Nouwt -

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/mediacodec_wrapper: clean up ff_AMediaCodecList_getCodecNameByType a bit

2021-03-08 Thread Matthieu Bouron
On Wed, Feb 17, 2021 at 04:50:00PM +0100, sfan5 wrote: > Hi, > > while looking into mediacodec for unrelated reasons I saw some room for > improvement. > > Therefore, here's a series with two small patches. > > From cadd2b2d4a5ffbb4dcc34faf2d3e139e1d4d608b Mon Sep 17 00:00:00 2001 > From: sfan5

Re: [FFmpeg-devel] [PATCH 1/2] lavc: deprecate AV_CODEC_FLAG_TRUNCATED

2021-03-08 Thread Andreas Rheinhardt
Anton Khirnov: > It is supported only by two decoders and is entirely redundant with > parsers. Just because it is only used in two files doesn't mean it is only used by two decoders: Six decoders have the AV_CODEC_CAP_TRUNCATED (which you forgot to deprecate) set. (fftools/cmdutils.c checks for

Re: [FFmpeg-devel] [PATCH] cmdutils: replace strncpy() with equivalent memcpy()

2021-03-08 Thread Andreas Rheinhardt
Anton Khirnov: > Fixes truncation warnings, such as > warning: ‘strncpy’ output truncated before terminating nul copying 3 bytes > from a string of the same length [-Wstringop-truncation] > in gcc 10.2.0 > --- > fftools/cmdutils.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > d

Re: [FFmpeg-devel] [PATCH 1/2] lavc: deprecate AV_CODEC_FLAG_TRUNCATED

2021-03-08 Thread James Almer
On 3/8/2021 9:24 AM, Andreas Rheinhardt wrote: Anton Khirnov: It is supported only by two decoders and is entirely redundant with parsers. Just because it is only used in two files doesn't mean it is only used by two decoders: Six decoders have the AV_CODEC_CAP_TRUNCATED (which you forgot to d

Re: [FFmpeg-devel] [PATCH V5 3/5] libavutil: add side data AV_FRAME_DATA_BOUNDING_BOXES

2021-03-08 Thread Lynne
Mar 8, 2021, 09:33 by an...@khirnov.net: > Quoting Guo, Yejun (2021-03-08 06:05:20) > >> Signed-off-by: Guo, Yejun <>> yejun@intel.com>> > >> --- >> doc/APIchanges| 2 ++ >> libavutil/frame.c | 1 + >> libavutil/frame.h | 5 + >> 3 files changed, 8 insertions(+) >> >> diff --git a/doc

Re: [FFmpeg-devel] [FFmpeg-web][PATCH] web/download: add signing key and verification instructions

2021-03-08 Thread Thilo Borgmann
Am 24.02.21 um 17:53 schrieb Thilo Borgmann: > Am 24.02.21 um 05:06 schrieb Zane van Iperen: >> As per discussion at [1]. Patches attached. >> >> Patch 1/3 adds /node_modules/ to .gitignore >> >> Patch 2/3 adds the actual key and verification instructions >> >> Patch 3/3 adds a prominent download l

Re: [FFmpeg-devel] [PATCH V5 3/5] libavutil: add side data AV_FRAME_DATA_BOUNDING_BOXES

2021-03-08 Thread Anton Khirnov
Quoting Lynne (2021-03-08 14:18:15) > Mar 8, 2021, 09:33 by an...@khirnov.net: > > > Quoting Guo, Yejun (2021-03-08 06:05:20) > > > >> Signed-off-by: Guo, Yejun <>> yejun@intel.com>> > > >> --- > >> doc/APIchanges| 2 ++ > >> libavutil/frame.c | 1 + > >> libavutil/frame.h | 5 + > >>

[FFmpeg-devel] FFmpeg dev meeting

2021-03-08 Thread Jean-Baptiste Kempf
Hello, As discussed on the framadate poll, the next developer meeting for FFmpeg is next Saturday: Saturday 13 March 16:00 UTC (17:00 Berlin Time) Will be probably on jitsi and on IRC like last time. Agenda will probably be related to TC/CC and about next major release. Please send other agend

Re: [FFmpeg-devel] [PATCH] [RFC][v4] Tech Resolution Process

2021-03-08 Thread Jean-Baptiste Kempf
Hello, This is a reminder about the vote. This is closing soon, and most of you have not voted yet! Best, On Mon, 1 Mar 2021, at 15:29, Jean-Baptiste Kempf wrote: > Hello, > > If you are a voter part of the FFmpeg General Assembly, you should have > received an email to allow you to vote on t

[FFmpeg-devel] Re: [PATCH 1/2] lavc: deprecate AV_CODEC_FLAG_TRUNCATED

2021-03-08 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2021-03-08 13:24:32) > Anton Khirnov: > > It is supported only by two decoders and is entirely redundant with > > parsers. > > Just because it is only used in two files doesn't mean it is only used > by two decoders: Six decoders have the AV_CODEC_CAP_TRUNCATED (which y

[FFmpeg-devel] [PATCH] avcodec/h264_slice: properly handle missing reference frames with hwaccels

2021-03-08 Thread James Almer
Unlike av_image_copy(), av_frame_copy() supports hardware pixel formats. Based on a patch by Hendrik Leppkes. Signed-off-by: James Almer --- libavcodec/h264_slice.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/libavcodec/h264_slice.c b/libavcodec/h264_slice.c i

[FFmpeg-devel] [PATCH v7 2/9] avcodec/vvc: add shared header for vvc

2021-03-08 Thread Nuo Mi
--- libavcodec/vvc.h | 142 +++ 1 file changed, 142 insertions(+) create mode 100644 libavcodec/vvc.h diff --git a/libavcodec/vvc.h b/libavcodec/vvc.h new file mode 100644 index 00..586934a7bf --- /dev/null +++ b/libavcodec/vvc.h @@ -0,0 +1,142

[FFmpeg-devel] [PATCH v7 9/9] avcodec: add vvc metadata bsf

2021-03-08 Thread Nuo Mi
You can download vtm 12 clips at https://www.itu.int/wftp3/av-arch/jvet-site/bitstream_exchange/VVC/under_test/VTM-12.0/ We run following command with all 267 VTM-12.0 clips: ffmpeg -i in.bit -c:v copy -bsf vvc_metadata -f vvc out.bit The output bitstream can get same yuv as original. --- confi

[FFmpeg-devel] [PATCH v7 6/9] avcodec: add vvc parser

2021-03-08 Thread Nuo Mi
--- configure | 1 + libavcodec/Makefile | 1 + libavcodec/parsers.c| 1 + libavcodec/vvc_parser.c | 571 4 files changed, 574 insertions(+) create mode 100644 libavcodec/vvc_parser.c diff --git a/configure b/configure index f1

[FFmpeg-devel] [PATCH v7 3/9] avformat: add vvc raw demux

2021-03-08 Thread Nuo Mi
--- libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/vvcdec.c | 61 3 files changed, 63 insertions(+) create mode 100644 libavformat/vvcdec.c diff --git a/libavformat/Makefile b/libavformat/Makefile index 0504f47f88..af642

[FFmpeg-devel] [PATCH v7 5/9] avcodec/h2645_parse: add nal header parser for h266/vvc

2021-03-08 Thread Nuo Mi
--- libavcodec/h2645_parse.c | 74 ++-- 1 file changed, 71 insertions(+), 3 deletions(-) diff --git a/libavcodec/h2645_parse.c b/libavcodec/h2645_parse.c index 6fbe97ad4a..7712ee9b1a 100644 --- a/libavcodec/h2645_parse.c +++ b/libavcodec/h2645_parse.c @@ -1,5 +

[FFmpeg-devel] [PATCH v7 0/9] add vvc raw demuxer, muxer, parser, metadata bsf

2021-03-08 Thread Nuo Mi
Changes since v6: Major changes: vvcparser: combine to AU instead of PU cbs_h266: Hide picture header in CodedBitstreamH266Context, user should not touch it. cbs_h266: When sh_picture_header_in_slice_header_flag is true, do not copy picture header from slice header to CodedBitstreamH266Context Up

[FFmpeg-devel] [PATCH v7 8/9] avcodec/cbs_h2645: vvc, do not skip nals for nuh_layer_id > 0

2021-03-08 Thread Nuo Mi
--- libavcodec/cbs_h2645.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/cbs_h2645.c b/libavcodec/cbs_h2645.c index 6e3b706813..c08a76e734 100644 --- a/libavcodec/cbs_h2645.c +++ b/libavcodec/cbs_h2645.c @@ -493,8 +493,9 @@ static int cbs_h2645_fragment_add_nals

Re: [FFmpeg-devel] [PATCH v6 1/9] cbs_h2645: refact, use cbs_h2645_replace_ps to replace cbs_h26*_replace_*ps

2021-03-08 Thread Andreas Rheinhardt
Nuo Mi: > From: Mark Thompson > > --- > libavcodec/cbs_h2645.c | 167 +++-- > 1 file changed, 126 insertions(+), 41 deletions(-) > > diff --git a/libavcodec/cbs_h2645.c b/libavcodec/cbs_h2645.c > index 6005d46e0d..57c419aa05 100644 > --- a/libavcodec/cbs_h264

[FFmpeg-devel] [PATCH v7 1/9] cbs_h2645: refact, use cbs_h2645_replace_ps to replace cbs_h26*_replace_*ps

2021-03-08 Thread Nuo Mi
From: Mark Thompson --- libavcodec/cbs_h2645.c | 162 ++--- 1 file changed, 121 insertions(+), 41 deletions(-) diff --git a/libavcodec/cbs_h2645.c b/libavcodec/cbs_h2645.c index 6005d46e0d..9e4a12c421 100644 --- a/libavcodec/cbs_h2645.c +++ b/libavcodec/cbs_h

Re: [FFmpeg-devel] [PATCH v6 1/9] cbs_h2645: refact, use cbs_h2645_replace_ps to replace cbs_h26*_replace_*ps

2021-03-08 Thread Nuo Mi
On Mon, Mar 8, 2021 at 10:28 PM Andreas Rheinhardt < andreas.rheinha...@gmail.com> wrote: > Nuo Mi: > > From: Mark Thompson > > > > --- > > libavcodec/cbs_h2645.c | 167 +++-- > > 1 file changed, 126 insertions(+), 41 deletions(-) > > > > diff --git a/libavcod

[FFmpeg-devel] [PATCH v7 7/9] avformat: add h266/vvc muxer

2021-03-08 Thread Nuo Mi
--- libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/rawenc.c | 25 + 3 files changed, 27 insertions(+) diff --git a/libavformat/Makefile b/libavformat/Makefile index af6428541d..d5aa0cc843 100644 --- a/libavformat/Makefile +++ b/libavforma

[FFmpeg-devel] [PATCH 1/5] avcodec/ylc: Remove write-only variable

2021-03-08 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/ylc.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/libavcodec/ylc.c b/libavcodec/ylc.c index f68fcf0bba..a200d04acd 100644 --- a/libavcodec/ylc.c +++ b/libavcodec/ylc.c @@ -58,7 +58,6 @@ static av_cold int decode_init(AVCodecContext *avctx

[FFmpeg-devel] [PATCH 2/5] avcodec/ylc: Only use one temporary buffer

2021-03-08 Thread Andreas Rheinhardt
The effective lifetime of the buffer used to build the VLCs and the buffer containing the bitstream is disjoint, so that one can use a common buffer for both. Signed-off-by: Andreas Rheinhardt --- libavcodec/ylc.c | 44 ++-- 1 file changed, 18 insertions(+

[FFmpeg-devel] [PATCH 3/5] avcodec/ylc: Avoid code duplication when creating and freeing VLCs

2021-03-08 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/ylc.c | 23 +++ 1 file changed, 7 insertions(+), 16 deletions(-) diff --git a/libavcodec/ylc.c b/libavcodec/ylc.c index 6dc3e60fec..793d8846b5 100644 --- a/libavcodec/ylc.c +++ b/libavcodec/ylc.c @@ -38,7 +38,7 @@ typedef st

[FFmpeg-devel] [PATCH 4/5] avcodec/ylc: Reindent after previous commit

2021-03-08 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/ylc.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/libavcodec/ylc.c b/libavcodec/ylc.c index 793d8846b5..ab1f8958f3 100644 --- a/libavcodec/ylc.c +++ b/libavcodec/ylc.c @@ -326,15 +326,15 @@ static int decode_fra

[FFmpeg-devel] [PATCH 5/5] avformat/rawenc: Use init instead of write_header function

2021-03-08 Thread Andreas Rheinhardt
force_one_stream() does not write anything. Signed-off-by: Andreas Rheinhardt --- Is it it actually intended that the mp2 muxer does not use force_one_stream at all? And is it intended that force_one_stream does only check codec_type and not the actual codec? And wouldn't it be better to inform t

Re: [FFmpeg-devel] [PATCH V5 3/5] libavutil: add side data AV_FRAME_DATA_BOUNDING_BOXES

2021-03-08 Thread Nicolas George
Anton Khirnov (12021-03-08): > I see no reason to believe the format will become more public-worthy > with time. Just the fact that as months pass, the likelihood we notice something that requires a deep change decreases. Do you have any actual argument against internal side data, beyond "I do no

[FFmpeg-devel] [PATCH] mailmap: add entry for myself

2021-03-08 Thread Linjie Fu
Signed-off-by: Linjie Fu --- .mailmap | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.mailmap b/.mailmap index 3bd1a85c3c..ba072f38c8 100644 --- a/.mailmap +++ b/.mailmap @@ -10,7 +10,8 @@ - + + -- 2.25.1 __

Re: [FFmpeg-devel] [PATCH] mailmap: add entry for myself

2021-03-08 Thread Thilo Borgmann
Hi, Am 08.03.21 um 16:12 schrieb Linjie Fu: > Signed-off-by: Linjie Fu > --- > .mailmap | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/.mailmap b/.mailmap > index 3bd1a85c3c..ba072f38c8 100644 > --- a/.mailmap > +++ b/.mailmap > @@ -10,7 +10,8 @@ > > > > -

Re: [FFmpeg-devel] [PATCH 3/5] avcodec/ylc: Avoid code duplication when creating and freeing VLCs

2021-03-08 Thread Paul B Mahol
all ylc patches lgtm. On Mon, Mar 8, 2021 at 4:30 PM Andreas Rheinhardt < andreas.rheinha...@gmail.com> wrote: > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/ylc.c | 23 +++ > 1 file changed, 7 insertions(+), 16 deletions(-) > > diff --git a/libavcodec/ylc.c b/libavc

[FFmpeg-devel] [PATCH][RFC - DO NOT MERGE] Revert "mov: Discard invalid CTTS."

2021-03-08 Thread Derek Buitenhuis
This reverts commit 4093220029a4d77f272c491e9299680480a08c00. Signed-off-by: Derek Buitenhuis --- I have CC'd Michael here, as he is the original author here and the "soltuion" is nor clear. To explain this RFC: We (Vimeo) have started seeing an uptick in broken MP4 files (what creates them i

Re: [FFmpeg-devel] [PATCH] mobiclip: fix copyright headers

2021-03-08 Thread Paul B Mahol
OK, assuming you are really that person. On Mon, Mar 8, 2021 at 12:02 PM Florian Nouwt wrote: > The Mobiclip related code was based on Mobius ( > https://github.com/adibsurani/Mobius), which was based on my original > reverse engineering efforts (https://github.com/Gericom/MobiclipDecoder). > Th

Re: [FFmpeg-devel] [PATCH][RFC - DO NOT MERGE] Revert "mov: Discard invalid CTTS."

2021-03-08 Thread Derek Buitenhuis
On 08/03/2021 15:55, Derek Buitenhuis wrote: > So the options are: > * Revert 1fb9efbda0149c3491529ea5fa92cfdcb8cebfaa and detect them as I > was already. Copy-paste fail. This should say 4093220029a4d77f272c491e9299680480a08c00. - Derek ___ ffmpeg

Re: [FFmpeg-devel] [PATCH] mobiclip: fix copyright headers

2021-03-08 Thread Florian Nouwt
If you need some confirmation, you can see on this commit that I used the same email address at least: https://github.com/Gericom/MobiclipDecoder/commit/32eb908f134f9140782e0585e2871ef2569ae23c.patch The author of Mobius can also confirm, I discussed it with him yesterday. Op ma 8 mrt. 2021 17:08

Re: [FFmpeg-devel] [PATCH][RFC - DO NOT MERGE] Revert "mov: Discard invalid CTTS."

2021-03-08 Thread Michael Niedermayer
On Mon, Mar 08, 2021 at 03:55:19PM +, Derek Buitenhuis wrote: > This reverts commit 4093220029a4d77f272c491e9299680480a08c00. > > Signed-off-by: Derek Buitenhuis > --- > I have CC'd Michael here, as he is the original author here and the > "soltuion" is nor clear. > > To explain this RFC: >

Re: [FFmpeg-devel] [PATCH] avutils/opt: fix discarded-qualifiers compiler warning

2021-03-08 Thread Chad Fraleigh
On 2/14/2021 10:12 AM, Nuo Mi wrote: On Mon, Feb 15, 2021 at 2:08 AM Andreas Rheinhardt < andreas.rheinha...@gmail.com> wrote: Nuo Mi: --- libavutil/opt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavutil/opt.c b/libavutil/opt.c index 590146b5fb..c554e9c063 10064

Re: [FFmpeg-devel] [PATCH V5 3/5] libavutil: add side data AV_FRAME_DATA_BOUNDING_BOXES

2021-03-08 Thread Anton Khirnov
Quoting Nicolas George (2021-03-08 16:32:08) > Anton Khirnov (12021-03-08): > > I see no reason to believe the format will become more public-worthy > > with time. > > Just the fact that as months pass, the likelihood we notice something > that requires a deep change decreases. > As does the lik

Re: [FFmpeg-devel] [PATCH v2] avcodec: add a get_encoder_buffer() callback to AVCodecContext

2021-03-08 Thread James Almer
On 2/22/2021 7:27 PM, James Almer wrote: On 2/21/2021 6:04 PM, James Almer wrote: On 2/21/2021 5:29 PM, Mark Thompson wrote: On 21/02/2021 20:00, James Almer wrote: On 2/21/2021 4:13 PM, Mark Thompson wrote: On 21/02/2021 17:35, James Almer wrote: This callback is functionally the same as get

Re: [FFmpeg-devel] [PATCH 2/2] avformat/swfdec: Check outlen before allocation

2021-03-08 Thread Michael Niedermayer
On Sun, Jan 24, 2021 at 02:05:17PM +0100, Anton Khirnov wrote: > Quoting Michael Niedermayer (2021-01-23 23:34:19) > > On Sat, Jan 23, 2021 at 03:29:38PM +0100, Anton Khirnov wrote: > > > Quoting Michael Niedermayer (2021-01-22 15:09:47) > > > > Fixes: Timeout (too long -> 241ms) > > > > Fixes: >

Re: [FFmpeg-devel] [PATCH v2] avcodec: add a get_encoder_buffer() callback to AVCodecContext

2021-03-08 Thread Lynne
Mar 8, 2021, 21:31 by jamr...@gmail.com: > On 2/22/2021 7:27 PM, James Almer wrote: > >> >> Looked at bit into this. AVCodec->encode2() based encoders don't support >> returning EAGAIN at all, as it completely breaks the frame threading logic. >> It would require a considerable rewrite in order

Re: [FFmpeg-devel] [PATCH 2/5] avcodec/aacdec_template: Avoid undefined negation in imdct_and_windowing_eld()

2021-03-08 Thread Michael Niedermayer
On Thu, Jan 21, 2021 at 01:03:43AM +0100, Michael Niedermayer wrote: > Fixes: negation of -2147483648 cannot be represented in type 'INTFLOAT' (aka > 'int'); cast to an unsigned type to negate this value to itself > Fixes: > 29057/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_AAC_FIXED_fuzzer

Re: [FFmpeg-devel] [PATCH 5/5] tools/target_dec_fuzzer: Adjust flv1 threshold

2021-03-08 Thread Michael Niedermayer
On Thu, Jan 21, 2021 at 01:03:46AM +0100, Michael Niedermayer wrote: > Fixes: Timeout (long -> 95ms) > Fixes: > 29068/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_FLV_fuzzer-6509662832820224 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/f

Re: [FFmpeg-devel] [PATCH 3/3] avformat/paf: Check for EOF before allocation in read_header()

2021-03-08 Thread Michael Niedermayer
On Wed, Jan 20, 2021 at 12:32:23AM +0100, Michael Niedermayer wrote: > Fixes: OOM > Fixes: > 26584/clusterfuzz-testcase-minimized-ffmpeg_dem_PAF_fuzzer-5172661183053824 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Mich

Re: [FFmpeg-devel] [PATCH v2] avcodec: add a get_encoder_buffer() callback to AVCodecContext

2021-03-08 Thread James Almer
On 3/8/2021 5:48 PM, Lynne wrote: Mar 8, 2021, 21:31 by jamr...@gmail.com: On 2/22/2021 7:27 PM, James Almer wrote: Looked at bit into this. AVCodec->encode2() based encoders don't support returning EAGAIN at all, as it completely breaks the frame threading logic. It would require a consid

Re: [FFmpeg-devel] [PATCH] avformat/flvdec: Check double before cast in parse_keyframes_index()

2021-03-08 Thread Michael Niedermayer
On Tue, Jan 26, 2021 at 05:08:39PM +0100, Michael Niedermayer wrote: > Fixes: -2.21166e+304 is outside the range of representable values of type > 'long' > Fixes: > 29169/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-5725452796821504 > > Found-by: continuous fuzzing process > https://git

Re: [FFmpeg-devel] [PATCH] fftools/ffplay: do not write out of rdft visualization texture

2021-03-08 Thread Marton Balint
On Sun, 7 Mar 2021, Michael Niedermayer wrote: On Wed, Mar 03, 2021 at 11:27:22PM +0100, Marton Balint wrote: If the window is resized it was possible that xpos pointed outside the visualization texture. By rearranging the overflow check we make sure this (and a crash) does not happen. We

Re: [FFmpeg-devel] [PATCH] fftools/ffplay: do not write out of rdft visualization texture

2021-03-08 Thread Michael Niedermayer
On Mon, Mar 08, 2021 at 09:56:38PM +0100, Marton Balint wrote: > > > On Sun, 7 Mar 2021, Michael Niedermayer wrote: > > > On Wed, Mar 03, 2021 at 11:27:22PM +0100, Marton Balint wrote: > > > If the window is resized it was possible that xpos pointed outside the > > > visualization texture. By re

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/dcadsp: Fix integer overflow in dmix_add_c()

2021-03-08 Thread Michael Niedermayer
On Sat, Jan 30, 2021 at 08:28:24PM +0100, Michael Niedermayer wrote: > Fixes: signed integer overflow: 1515225320 + 759416059 cannot be represented > in type 'int' > Fixes: > 29256/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_DCA_fuzzer-5719088561258496 > > Found-by: continuous fuzzing proc

Re: [FFmpeg-devel] [PATCH] libavformat/movenc: Support encryption of H265 stream in AnnexB format

2021-03-08 Thread Вадим Бездушный
Ping. This change is quite simple and should be quick to review. Feel free to ask any questions On Mon, 1 Mar 2021, 14:54 Vadym Bezdushnyi, wrote: > Add an ability to accept H265 AnnexB stream at encryption > similar to how its done for H264 AnnexB stream. > > Steps to test: > > 1. Create h265

Re: [FFmpeg-devel] [PATCH] mailmap: add entry for myself

2021-03-08 Thread Linjie Fu
On Mon, Mar 8, 2021 at 11:58 PM Thilo Borgmann wrote: > > Hi, > > Am 08.03.21 um 16:12 schrieb Linjie Fu: > > Signed-off-by: Linjie Fu > > --- > > .mailmap | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/.mailmap b/.mailmap > > index 3bd1a85c3c..ba072f38c8 100644

[FFmpeg-devel] [PATCH] avcodec/h264_slice: don't copy frame data during error concealment

2021-03-08 Thread James Almer
In addition to the fact that av_image_copy() cannot handle hardware pixel formats, h->short_ref[0]->f may not even be writable at this point. Based on a patch by Hendrik Leppkes. Signed-off-by: James Almer --- This is an alternative to "avcodec/h264_slice: properly handle missing reference frame

[FFmpeg-devel] [PATCH v1] avformat/rtsp: RTP support buffer_size&pkt_size option

2021-03-08 Thread gaojiangjie
From: Jiangjie Gao And forward it to udp. issue: https://trac.ffmpeg.org/ticket/7517 Signed-off-by: Jiangjie Gao --- libavformat/rtsp.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c index 9a2933346e..25bdf475b3 100644 --- a/liba

Re: [FFmpeg-devel] [PATCH] avcodec/h264_slice: don't copy frame data during error concealment

2021-03-08 Thread Hendrik Leppkes
On Tue, Mar 9, 2021 at 3:39 AM James Almer wrote: > > In addition to the fact that av_image_copy() cannot handle hardware pixel > formats, h->short_ref[0]->f may not even be writable at this point. > > Based on a patch by Hendrik Leppkes. > > Signed-off-by: James Almer > --- > This is an alternat