Anton Khirnov:
> Fixes truncation warnings, such as
> warning: ‘strncpy’ output truncated before terminating nul copying 3 bytes
> from a string of the same length [-Wstringop-truncation]
> in gcc 10.2.0
> ---
> fftools/cmdutils.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fftools/cmdutils.c b/fftools/cmdutils.c
> index 8cfca22564..505006cd8b 100644
> --- a/fftools/cmdutils.c
> +++ b/fftools/cmdutils.c
> @@ -1163,13 +1163,13 @@ static void print_buildconf(int flags, int level)
> // Change all the ' --' strings to '~--' so that
> // they can be identified as tokens.
> while ((conflist = strstr(str, " --")) != NULL) {
> - strncpy(conflist, "~--", 3);
> + memcpy(conflist, "~--", 3);
> }
>
> // Compensate for the weirdness this would cause
> // when passing 'pkg-config --static'.
> while ((remove_tilde = strstr(str, "pkg-config~")) != NULL) {
> - strncpy(remove_tilde, "pkg-config ", 11);
> + memcpy(remove_tilde, "pkg-config ", 11);
> }
>
> splitconf = strtok(str, "~");
>
Wouldn't it be more natural to just use "conflist[0] = '~'" when
changing only one character?
- Andreas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
