[FFmpeg-devel] [PATCH 1/4] lavf: matroska subtitle muxer

2020-05-28 Thread rcombs
--- configure | 1 + libavformat/allformats.c | 1 + libavformat/matroskaenc.c | 30 ++ libavformat/version.h | 2 +- 4 files changed, 33 insertions(+), 1 deletion(-) diff --git a/configure b/configure index 8569a60bf8..9929c29006 100755 --- a/c

[FFmpeg-devel] [PATCH 3/4] lavf/matroskadec: support standard (non-WebM) WebVTT formatting

2020-05-28 Thread rcombs
Fixes ticket #5641 --- libavformat/matroska.c| 11 ++-- libavformat/matroskadec.c | 111 -- 2 files changed, 77 insertions(+), 45 deletions(-) diff --git a/libavformat/matroska.c b/libavformat/matroska.c index 7c56aba403..962fa496f4 100644 --- a/libavforma

[FFmpeg-devel] [PATCH 4/4] lavf/matroskaenc: mux WebVTT using standard (non-WebM) formatting

2020-05-28 Thread rcombs
--- libavformat/matroskaenc.c | 33 + 1 file changed, 25 insertions(+), 8 deletions(-) diff --git a/libavformat/matroskaenc.c b/libavformat/matroskaenc.c index 1f7a9528de..d34a47e646 100644 --- a/libavformat/matroskaenc.c +++ b/libavformat/matroskaenc.c @@ -1351,7

[FFmpeg-devel] [PATCH 2/4] lavf/webvtt: preserve comments

2020-05-28 Thread rcombs
--- libavcodec/avpacket.c | 1 + libavcodec/packet.h | 6 ++ libavformat/webvttdec.c | 25 ++--- libavformat/webvttenc.c | 10 -- 4 files changed, 37 insertions(+), 5 deletions(-) diff --git a/libavcodec/avpacket.c b/libavcodec/avpacket.c index 033f2d8f26..

Re: [FFmpeg-devel] aubmit Verisilicon VPE hardware codec implementation

2020-05-28 Thread Nicolas George
myp...@gmail.com (12020-05-28): > I guess it is based on https://github.com/VeriSilicon/VPI, but I just > find some so library There is no license. I do not think we could consider supporting this until the external part is solid enough. Regards, -- Nicolas George signature.asc Description

Re: [FFmpeg-devel] [PATCH 1/4] lavf: matroska subtitle muxer

2020-05-28 Thread Nicolas George
rcombs (12020-05-28): > --- > configure | 1 + > libavformat/allformats.c | 1 + > libavformat/matroskaenc.c | 30 ++ > libavformat/version.h | 2 +- > 4 files changed, 33 insertions(+), 1 deletion(-) Was this not rejected two months ago as doin

[FFmpeg-devel] [PATCH] libavfilter/vf_drawtext.c:add support to generte ms level

2020-05-28 Thread 黄思远
0001-libavfilter-vf_drawtext.c-add-support-to-generte-ms-.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ

Re: [FFmpeg-devel] [PATCH] libavfilter/vf_drawtext.c:add support to generte ms level

2020-05-28 Thread Gyan Doshi
If the patch isn't inlined in the email, please add a descriptive body. Docs entry missing. Gyan On 28-05-2020 02:01 pm, 黄思远 wrote: ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe

Re: [FFmpeg-devel] [PATCH 3/4] avfilter: add ff_inlink_peek_samples and ff_inlink_skip samples

2020-05-28 Thread Paul B Mahol
Will apply soon. On 5/24/20, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libavfilter/avfilter.c | 61 +- > libavfilter/filters.h | 17 > 2 files changed, 72 insertions(+), 6 deletions(-) > __

[FFmpeg-devel] [PATCH 4/4] lavf/matroskaenc: mux WebVTT using standard (non-WebM) formatting

2020-05-28 Thread rcombs
--- libavformat/matroskaenc.c | 29 +++-- 1 file changed, 23 insertions(+), 6 deletions(-) diff --git a/libavformat/matroskaenc.c b/libavformat/matroskaenc.c index 1f7a9528de..61b0fe9f51 100644 --- a/libavformat/matroskaenc.c +++ b/libavformat/matroskaenc.c @@ -2117,20 +21

[FFmpeg-devel] [PATCH 3/4] lavf/matroskadec: support standard (non-WebM) WebVTT formatting

2020-05-28 Thread rcombs
Fixes ticket #5641 --- libavformat/matroska.c| 11 ++-- libavformat/matroskadec.c | 111 -- 2 files changed, 77 insertions(+), 45 deletions(-) diff --git a/libavformat/matroska.c b/libavformat/matroska.c index 7c56aba403..962fa496f4 100644 --- a/libavforma

[FFmpeg-devel] [PATCH 1/4] lavf: matroska subtitle muxer

2020-05-28 Thread rcombs
--- configure | 1 + libavformat/allformats.c | 1 + libavformat/matroskaenc.c | 30 ++ libavformat/version.h | 2 +- 4 files changed, 33 insertions(+), 1 deletion(-) diff --git a/configure b/configure index 8569a60bf8..9929c29006 100755 --- a/c

[FFmpeg-devel] [PATCH 2/4] lavf/webvtt: preserve comments

2020-05-28 Thread rcombs
--- libavcodec/avpacket.c | 1 + libavcodec/packet.h | 6 ++ libavformat/webvttdec.c | 25 ++--- libavformat/webvttenc.c | 10 -- 4 files changed, 37 insertions(+), 5 deletions(-) diff --git a/libavcodec/avpacket.c b/libavcodec/avpacket.c index 033f2d8f26..

Re: [FFmpeg-devel] [PATCH 2/4] tools/target_dec_fuzzer: Do not test AV_CODEC_FLAG2_FAST with AV_CODEC_ID_H264

2020-05-28 Thread Jean-Baptiste Kempf
On Thu, May 28, 2020, at 00:08, Kieran Kunhya wrote: > On Wed, 27 May 2020 at 22:53, Michael Niedermayer > wrote: > > > On Sun, Mar 15, 2020 at 10:20:56PM +0100, Michael Niedermayer wrote: > > > This combination skips allocating large padding which can read out of > > array > > > > > > Fixes: > >

[FFmpeg-devel] [PATCH] libavfilter/vf_drawtext.c:add support to generte ms level

2020-05-28 Thread 黄思远
___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] libavfilter/vf_drawtext.c:add support to generte ms level

2020-05-28 Thread Paul B Mahol
No patch received at all. On 5/28/20, 黄思远 wrote: > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject

Re: [FFmpeg-devel] 答复: 答复: aubmit Verisilicon VPE hardware codec implementation

2020-05-28 Thread Hendrik Leppkes
On Thu, May 28, 2020 at 4:58 AM Zhang, Guiyong wrote: > > Hi softworkz, > > Currently no- but similar module maybe possible in further. > Support for proprietary hardware only deployed by Facebook seems like it doesn't really benefit the FFmpeg ecosystem as a whole. - Hendrik ___

Re: [FFmpeg-devel] [PATCH v2 1/2] lavfi/afir: fix vpad.name leak

2020-05-28 Thread myp...@gmail.com
On Mon, May 25, 2020 at 4:17 PM Jun Zhao wrote: > > From: Jun Zhao > > Fix vpad.name leak in error path, move the vpad related operation > only if enabled show IR frequency response. > > Signed-off-by: Jun Zhao > --- > libavfilter/af_afir.c | 14 ++ > 1 file changed, 6 insertions(+)

Re: [FFmpeg-devel] [PATCH v2 4/4] lavf/mpegtsenc: misc style fixes

2020-05-28 Thread myp...@gmail.com
On Wed, May 27, 2020 at 2:58 PM Marton Balint wrote: > > > > On Wed, 27 May 2020, Jun Zhao wrote: > > > From: Jun Zhao > > > > commit 32aeba12755 missed coding style fix. > > > > Signed-off-by: Jun Zhao > > --- > > libavformat/mpegtsenc.c | 24 > > 1 file changed, 12 inse

[FFmpeg-devel] [PATCH v2] avformat/oggenc: Add partial support for OggPCM muxing

2020-05-28 Thread A G
This adds partial support for OggPCM muxing. Heavily based on the work here: https://ffmpeg.org/pipermail/ffmpeg-devel/2013-July/145556.html and here: http://www.on2.com/media/gpl/mplayer/ --- libavformat/oggenc.c | 86 1 file changed, 80 insertions(+)

Re: [FFmpeg-devel] [PATCH v2] avformat/oggenc: Add partial support for OggPCM muxing

2020-05-28 Thread A G
Apologies for the previous patch (v1), the commit message was incorrect and I failed to add the requested change. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above,

Re: [FFmpeg-devel] [PATCH] x86: cabac: Disable the inline asm on clang on windows on i386

2020-05-28 Thread Martin Storsjö
On Mon, 25 May 2020, Martin Storsjö wrote: On Sun, 24 May 2020, Carl Eugen Hoyos wrote: Am So., 24. Mai 2020 um 21:53 Uhr schrieb Martin Storsjö : configure --enable-gpl --arch=i686 --cc=clang-cl --ld=lld-link --target-os=win32 --toolchain=msvc --enable-cross-compile --ar=llvm-ar --nm=llvm

Re: [FFmpeg-devel] aubmit Verisilicon VPE hardware codec implementation

2020-05-28 Thread Steven Liu
Zhang, Guiyong 于2020年5月28日周四 上午10:12写道: > > > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsu

Re: [FFmpeg-devel] [PATCH v2] avformat/oggenc: Add partial support for OggPCM muxing

2020-05-28 Thread A G
> +static const struct ogg_pcm_codec { > +uint32_t codec_id; > +uint32_t format_id; > +} ogg_pcm_codecs[] = { > +{ AV_CODEC_ID_PCM_S8,0x00 }, > +{ AV_CODEC_ID_PCM_U8,0x01 }, > +{ AV_CODEC_ID_PCM_S16LE, 0x02 }, > +{ AV_CODEC_ID_PCM_S16BE, 0x03 }, > +{ AV_CODEC_ID_

Re: [FFmpeg-devel] [PATCH 1/4] avformat/hlsplaylist: Add const where appropriate

2020-05-28 Thread Andreas Rheinhardt
Steven Liu: > > >> 2020年5月26日 上午3:42,Andreas Rheinhardt 写道: >> >> Signed-off-by: Andreas Rheinhardt >> --- >> libavformat/hlsplaylist.c | 27 --- >> libavformat/hlsplaylist.h | 23 +-- >> 2 files changed, 29 insertions(+), 21 deletions(-) >> >> diff --g

Re: [FFmpeg-devel] [PATCH 3/4] avfilter: add ff_inlink_peek_samples and ff_inlink_skip samples

2020-05-28 Thread Nicolas George
Paul B Mahol (12020-05-28): > Will apply soon. I will hurry looking at it. -- Nicolas George ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-dev

[FFmpeg-devel] [PATCH 2/2] avcodec/mpeg12dec: Fix got_output

2020-05-28 Thread Michael Niedermayer
Fixes: assertion failure Fixes: 22178/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MPEG1VIDEO_fuzzer-5664234440753152 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/mpeg12dec.c | 2 +- 1

[FFmpeg-devel] [PATCH 1/2] avcodec/adpcm_data: extend ff_adpcm_ima_cunning_index_table

2020-05-28 Thread Michael Niedermayer
Fixes: overread by 1 Fixes: 21880/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ADPCM_IMA_CUNNING_fuzzer-5717917221257216.fuzz Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/adpcm_data.c

Re: [FFmpeg-devel] [PATCH 2/4] tools/target_dec_fuzzer: Do not test AV_CODEC_FLAG2_FAST with AV_CODEC_ID_H264

2020-05-28 Thread Michael Niedermayer
On Thu, May 28, 2020 at 11:14:15AM +0200, Jean-Baptiste Kempf wrote: > On Thu, May 28, 2020, at 00:08, Kieran Kunhya wrote: > > On Wed, 27 May 2020 at 22:53, Michael Niedermayer > > wrote: > > > > > On Sun, Mar 15, 2020 at 10:20:56PM +0100, Michael Niedermayer wrote: > > > > This combination skip

Re: [FFmpeg-devel] [PATCH 3/4] avfilter: add ff_inlink_peek_samples and ff_inlink_skip samples

2020-05-28 Thread Nicolas George
Paul B Mahol (12020-05-24): > Signed-off-by: Paul B Mahol > --- > libavfilter/avfilter.c | 61 +- > libavfilter/filters.h | 17 > 2 files changed, 72 insertions(+), 6 deletions(-) I am against this. It adds quite a lot of complexity in commo

Re: [FFmpeg-devel] [PATCH 1/4] lavf: matroska subtitle muxer

2020-05-28 Thread Ridley Combs
> On May 28, 2020, at 03:26, Nicolas George wrote: > > rcombs (12020-05-28): >> --- >> configure | 1 + >> libavformat/allformats.c | 1 + >> libavformat/matroskaenc.c | 30 ++ >> libavformat/version.h | 2 +- >> 4 files changed, 33 insertions(+),

Re: [FFmpeg-devel] [PATCH 2/4] tools/target_dec_fuzzer: Do not test AV_CODEC_FLAG2_FAST with AV_CODEC_ID_H264

2020-05-28 Thread Michael Niedermayer
On Thu, May 28, 2020 at 02:23:34PM +0200, Michael Niedermayer wrote: > On Thu, May 28, 2020 at 11:14:15AM +0200, Jean-Baptiste Kempf wrote: > > On Thu, May 28, 2020, at 00:08, Kieran Kunhya wrote: > > > On Wed, 27 May 2020 at 22:53, Michael Niedermayer > > > wrote: > > > > > > > On Sun, Mar 15, 2

[FFmpeg-devel] [PATCH 1/7] avcodec/h264dec: cosmetics

2020-05-28 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/h264dec.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libavcodec/h264dec.c b/libavcodec/h264dec.c index e463fde..7c7a63c 100644 --- a/libavcodec/h264dec.c +++ b/libavcodec/h264dec.c @@ -253,8 +253,7 @@ int ff_h2

[FFmpeg-devel] [PATCH 2/7] avcodec/h264dec: store count of slice_table_base with local variable

2020-05-28 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/h264dec.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libavcodec/h264dec.c b/libavcodec/h264dec.c index 7c7a63c..b03e6ed 100644 --- a/libavcodec/h264dec.c +++ b/libavcodec/h264dec.c @@ -182,6 +182,7 @@ int ff

[FFmpeg-devel] [PATCH 4/7] avcodec/h264dec: prefer to use variable instead of type for sizeof

2020-05-28 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/h264dec.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/libavcodec/h264dec.c b/libavcodec/h264dec.c index 974d324..d5b3df3 100644 --- a/libavcodec/h264dec.c +++ b/libavcodec/h264dec.c

[FFmpeg-devel] [PATCH 3/7] avcodec/h264dec: replace FF_ALLOCZ{_ARRAY}_OR_GOTO with av_mallocz_array()

2020-05-28 Thread lance . lmwang
From: Limin Wang remove the fail goto label and return AVERROR(ENOMEM) directly Signed-off-by: Limin Wang --- libavcodec/h264dec.c | 60 +++- 1 file changed, 17 insertions(+), 43 deletions(-) diff --git a/libavcodec/h264dec.c b/libavcodec/h264de

[FFmpeg-devel] [PATCH 5/7] avcodec/h264dec: define and use FF_ALLOCZ_TYPED_ARRAY helper macro

2020-05-28 Thread lance . lmwang
From: Limin Wang The macro will help to short the long lines and avoid split them. Signed-off-by: Limin Wang --- libavcodec/h264dec.c | 30 +++--- libavutil/internal.h | 2 ++ 2 files changed, 17 insertions(+), 15 deletions(-) diff --git a/libavcodec/h264dec.c b/libav

[FFmpeg-devel] [PATCH 7/7] avcodec/adpcmenc: remove gotos and error label

2020-05-28 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/adpcmenc.c | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/libavcodec/adpcmenc.c b/libavcodec/adpcmenc.c index bcb6783..52f0f67 100644 --- a/libavcodec/adpcmenc.c +++ b/libavcodec/adpcmenc.c @@ -65,7 +6

[FFmpeg-devel] [PATCH 6/7] avcodec/adpcmenc: remove FF_ALLOC_OR_GOTO macros for gotos will be removed

2020-05-28 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/adpcmenc.c | 25 + libavutil/internal.h | 1 + 2 files changed, 14 insertions(+), 12 deletions(-) diff --git a/libavcodec/adpcmenc.c b/libavcodec/adpcmenc.c index d5fbc0b..bcb6783 100644 --- a/libavcodec/adpcme

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/adpcm_data: extend ff_adpcm_ima_cunning_index_table

2020-05-28 Thread Zane van Iperen
On Thu, 28 May 2020 14:12:33 +0200 "Michael Niedermayer" wrote: > > Fixes: overread by 1 > Fixes: > 21880/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ADPCM_IMA_CUNNING_fuzzer-5717917221257216.fuzz > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/pr

Re: [FFmpeg-devel] [PATCH v7 1/3] avfilter/graphdump: support for the graph2dot function

2020-05-28 Thread lance . lmwang
On Mon, May 25, 2020 at 07:50:24AM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavfilter/Makefile| 1 - > libavfilter/graphdump.c | 89 + > tools/graph2dot.c | 204 > ---

Re: [FFmpeg-devel] [PATCH v7 1/3] avfilter/graphdump: support for the graph2dot function

2020-05-28 Thread Nicolas George
lance.lmw...@gmail.com (12020-05-28): > will apply the patchset tomorrow if no further comments. Please give me time to look carefully. This is not urgent. Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailin

Re: [FFmpeg-devel] [PATCH 4/7] avcodec/h264dec: prefer to use variable instead of type for sizeof

2020-05-28 Thread myp...@gmail.com
On Thu, May 28, 2020 at 9:58 PM wrote: > > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavcodec/h264dec.c | 28 ++-- > 1 file changed, 14 insertions(+), 14 deletions(-) > > diff --git a/libavcodec/h264dec.c b/libavcodec/h264dec.c > index 974d324..d5b3df3 100

Re: [FFmpeg-devel] [PATCH v7 1/3] avfilter/graphdump: support for the graph2dot function

2020-05-28 Thread lance . lmwang
On Thu, May 28, 2020 at 04:14:27PM +0200, Nicolas George wrote: > lance.lmw...@gmail.com (12020-05-28): > > will apply the patchset tomorrow if no further comments. > > Please give me time to look carefully. This is not urgent. Of course, thanks for review, anytime is OK, stay tune. > > Regards

Re: [FFmpeg-devel] [PATCH v2] avformat/oggenc: Add partial support for OggPCM muxing

2020-05-28 Thread Lynne
May 28, 2020, 11:34 by oreo...@outlook.com: > This adds partial support for OggPCM muxing. > > +static inline uint32_t ogg_get_pcm_format_id(uint32_t codec_id) > use enum AVCodecID instead of uint32_t. Also use that in ogg_pcm_codec for the codec IDs. > +{ > +int i; > + > +for (i = 0;

Re: [FFmpeg-devel] [PATCH 4/7] avcodec/h264dec: prefer to use variable instead of type for sizeof

2020-05-28 Thread lance . lmwang
On Thu, May 28, 2020 at 10:18:09PM +0800, myp...@gmail.com wrote: > On Thu, May 28, 2020 at 9:58 PM wrote: > > > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > libavcodec/h264dec.c | 28 ++-- > > 1 file changed, 14 insertions(+), 14 deletions(-) > > > >

Re: [FFmpeg-devel] [PATCH 3/4] avfilter: add ff_inlink_peek_samples and ff_inlink_skip samples

2020-05-28 Thread Paul B Mahol
On 5/28/20, Nicolas George wrote: > Paul B Mahol (12020-05-24): >> Signed-off-by: Paul B Mahol >> --- >> libavfilter/avfilter.c | 61 +- >> libavfilter/filters.h | 17 >> 2 files changed, 72 insertions(+), 6 deletions(-) > > I am against this

Re: [FFmpeg-devel] [PATCH 3/7] avcodec/h264dec: replace FF_ALLOCZ{_ARRAY}_OR_GOTO with av_mallocz_array()

2020-05-28 Thread lance . lmwang
On Thu, May 28, 2020 at 09:57:26PM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > remove the fail goto label and return AVERROR(ENOMEM) directly > > Signed-off-by: Limin Wang > --- > libavcodec/h264dec.c | 60 > +++- > 1 file change

[FFmpeg-devel] [PATCH 1/2] avcodec: Add AV_CODEC_FLAG2_FAST_UNSAFE, move unsafe uses of FAST to it

2020-05-28 Thread Michael Niedermayer
TODO: Bump Signed-off-by: Michael Niedermayer --- doc/APIchanges | 3 +++ doc/codecs.texi| 2 ++ libavcodec/avcodec.h | 6 ++ libavcodec/h264dec.c | 2 +- libavcodec/options_table.h | 1 + tools/target_dec_fuzzer.c | 2 +- 6 files changed, 14 insertions(+

[FFmpeg-devel] [PATCH 2/2] avcodec/lzf: Consider the needed size in reallocation

2020-05-28 Thread Michael Niedermayer
Fixes: NULL pointer dereference Fixes: 22381/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_NOTCHLC_fuzzer-5659879921680384.fuzz Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/lzf.c | 4 ++

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/adpcm_data: extend ff_adpcm_ima_cunning_index_table

2020-05-28 Thread Michael Niedermayer
On Thu, May 28, 2020 at 02:06:32PM +, Zane van Iperen wrote: > On Thu, 28 May 2020 14:12:33 +0200 > "Michael Niedermayer" wrote: > > > > > Fixes: overread by 1 > > Fixes: > > 21880/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ADPCM_IMA_CUNNING_fuzzer-5717917221257216.fuzz > > > > Found

Re: [FFmpeg-devel] [PATCH 1/2] avcodec: Add AV_CODEC_FLAG2_FAST_UNSAFE, move unsafe uses of FAST to it

2020-05-28 Thread James Almer
On 5/28/2020 1:20 PM, Michael Niedermayer wrote: > TODO: Bump > > Signed-off-by: Michael Niedermayer > --- > doc/APIchanges | 3 +++ > doc/codecs.texi| 2 ++ > libavcodec/avcodec.h | 6 ++ > libavcodec/h264dec.c | 2 +- > libavcodec/options_table.h | 1 + >

Re: [FFmpeg-devel] [PATCH 3/4] avfilter: add ff_inlink_peek_samples and ff_inlink_skip samples

2020-05-28 Thread Nicolas George
Paul B Mahol (12020-05-28): > Will apply in 5 minutes. No. This code is unnecessary and complicates things. -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/

Re: [FFmpeg-devel] [PATCH 3/4] avfilter: add ff_inlink_peek_samples and ff_inlink_skip samples

2020-05-28 Thread Paul B Mahol
On 5/28/20, Nicolas George wrote: > Paul B Mahol (12020-05-28): >> Will apply in 5 minutes. > > No. This code is unnecessary and complicates things. You can say whatever you want. I simply do not care. You could block it months ago instead of requesting me to lose all my precious time on your re

Re: [FFmpeg-devel] [PATCH 3/4] avfilter: add ff_inlink_peek_samples and ff_inlink_skip samples

2020-05-28 Thread Nicolas George
Paul B Mahol (12020-05-28): > You can say whatever you want. I simply do not care. > > You could block it months ago instead of requesting me to lose all my > precious time on your requested changes. This is not about you, it is about the code. I did not notice the problem then, I notice it now.

[FFmpeg-devel] [PATCH] Replace 'FontName' with 'Fontname' in the documentation.

2020-05-28 Thread Joe Ratterman
This is the only use of 'FontName' with that capitalization, as both source-code and tests use 'Fontname'. Having consistent capitalization makes it easier to find the relevant source from the docs. See these examples for other uses: libavcodec/ass_split.c:68 tests/ref/fate/sub-cc:9 --- d

Re: [FFmpeg-devel] [PATCH 3/4] avfilter: add ff_inlink_peek_samples and ff_inlink_skip samples

2020-05-28 Thread Paul B Mahol
On 5/28/20, Nicolas George wrote: > Paul B Mahol (12020-05-28): >> You can say whatever you want. I simply do not care. >> >> You could block it months ago instead of requesting me to lose all my >> precious time on your requested changes. > > This is not about you, it is about the code. I did not

Re: [FFmpeg-devel] [PATCH 1/2] avcodec: Add AV_CODEC_FLAG2_FAST_UNSAFE, move unsafe uses of FAST to it

2020-05-28 Thread Michael Niedermayer
On Thu, May 28, 2020 at 01:43:17PM -0300, James Almer wrote: > On 5/28/2020 1:20 PM, Michael Niedermayer wrote: > > TODO: Bump > > > > Signed-off-by: Michael Niedermayer > > --- > > doc/APIchanges | 3 +++ > > doc/codecs.texi| 2 ++ > > libavcodec/avcodec.h | 6

Re: [FFmpeg-devel] [PATCH 1/2] avcodec: Add AV_CODEC_FLAG2_FAST_UNSAFE, move unsafe uses of FAST to it

2020-05-28 Thread Anton Khirnov
Quoting Lynne (2020-05-28 18:26:44) > May 28, 2020, 17:20 by mich...@niedermayer.cc: > > > TODO: Bump > > > > */ > > #define AV_CODEC_FLAG2_FAST (1 << 0) > > + > > +/** > > + * Allow speedups tricks which can read out of array on non compliant > > streams. > > + */ > > +#define AV_CO

Re: [FFmpeg-devel] [PATCH 1/2] avcodec: Add AV_CODEC_FLAG2_FAST_UNSAFE, move unsafe uses of FAST to it

2020-05-28 Thread Anton Khirnov
Quoting Michael Niedermayer (2020-05-28 20:09:15) > > h264 is a specific use of this flag, and that might not be the only > place it could be used in > > But about h264 What this is about if i remember it correctly, is > that the maximum input any crafted bitstream of a block can require is X, >

Re: [FFmpeg-devel] [PATCH 1/2] avcodec: Add AV_CODEC_FLAG2_FAST_UNSAFE, move unsafe uses of FAST to it

2020-05-28 Thread Michael Niedermayer
On Thu, May 28, 2020 at 08:09:15PM +0200, Michael Niedermayer wrote: > On Thu, May 28, 2020 at 01:43:17PM -0300, James Almer wrote: > > On 5/28/2020 1:20 PM, Michael Niedermayer wrote: > > > TODO: Bump > > > > > > Signed-off-by: Michael Niedermayer > > > --- > > > doc/APIchanges | 3

[FFmpeg-devel] [RFC PATCH] libavcodec/jpeg2000_parser: Add jpeg2000 parser

2020-05-28 Thread gautamramk
From: Gautam Ramakrishnan I have attempted to write a JPEG2000 Parser. Have tested by generating a file containing 14 frames, as mentioned by Micheal. Have also tried testing with various packet sizes by setting -frame_size option. Need feedback on the code and on further testing. --- libavcodec

Re: [FFmpeg-devel] [PATCH 1/2] avcodec: Add AV_CODEC_FLAG2_FAST_UNSAFE, move unsafe uses of FAST to it

2020-05-28 Thread Michael Niedermayer
On Thu, May 28, 2020 at 08:30:16PM +0200, Anton Khirnov wrote: > Quoting Michael Niedermayer (2020-05-28 20:09:15) > > > > h264 is a specific use of this flag, and that might not be the only > > place it could be used in > > > > But about h264 What this is about if i remember it correctly, is > >

Re: [FFmpeg-devel] [PATCH 3/5] [mov] Check if DTS is AV_NOPTS_VALUE in mov_find_next_sample().

2020-05-28 Thread Dale Curtis
Bump now that the saturated math operations have landed. Thanks! - dale On Thu, May 14, 2020 at 3:31 PM Dale Curtis wrote: > > Signed-off-by: Dale Curtis > --- > libavformat/mov.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > ___ ffmpe

Re: [FFmpeg-devel] [PATCH 4/5] [utils, mathematics] Fix overflow in compute_pkt_fields().

2020-05-28 Thread Dale Curtis
Bump now that the saturated math operations have landed. Thanks! - dale On Thu, May 14, 2020 at 3:31 PM Dale Curtis wrote: > Fixes one issue in the function itself and one in the dependent > function av_add_stable() which wasn't checking for NaN. > > Signed-off-by: Dale Curtis > --- > libav

Re: [FFmpeg-devel] [PATCH 2/5] [oggparsetheora] Use av_sat_sub64() when updating pts by duration.

2020-05-28 Thread Dale Curtis
Bump now that the saturated math operations have landed. Thanks! - dale On Thu, May 14, 2020 at 3:31 PM Dale Curtis wrote: > Signed-off-by: Dale Curtis > --- > libavformat/oggparsetheora.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >

Re: [FFmpeg-devel] [PATCH 1/5] Use av_sat_add64() when updating start_time by skip_samples.

2020-05-28 Thread Dale Curtis
Bump now that the saturated math operations have landed. Thanks! - dale On Thu, May 14, 2020 at 3:31 PM Dale Curtis wrote: > Avoids overflow from fuzzed skip_samples values. > > Signed-off-by: Dale Curtis > --- > libavformat/utils.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-)

Re: [FFmpeg-devel] [PATCH] libavfilter/vf_drawtext.c:add support to generte ms level

2020-05-28 Thread Michael Niedermayer
On Thu, May 28, 2020 at 04:31:58PM +0800, 黄思远 wrote: > ea327ff8f5deb8958062cf9dc0d5c4acbb47111d > 0001-libavfilter-vf_drawtext.c-add-support-to-generte-ms-.patch > From 94cf5f13eaf565ea230ca3628119029caf07d2c5 Mon Sep 17 00:00:00 2001 > From: SiyuanHuang > Date: Thu, 28 May 2020 13:42:01 +0800

Re: [FFmpeg-devel] [PATCH] avcodec/libaomenc: remove the experimental flag when using libaom 2.0.0 or newer

2020-05-28 Thread James Almer
On 5/27/2020 2:46 PM, James Zern wrote: > On Tue, May 26, 2020 at 6:40 PM James Almer wrote: >> >> Signed-off-by: James Almer >> --- >> Alternatively, we could remove support for libaom 1.0.0, since it's pretty >> much >> unusable. But unfortunately both current Debian Stable and latest Ubuntu L

[FFmpeg-devel] [PATCH 05/17] lavu/opt: add a more general child class iteration API

2020-05-28 Thread Anton Khirnov
Use opaque iteration state instead of the previous child class. This mirrors similar changes done in lavf/lavc. Deprecate the av_opt_child_class_next() API. --- libavutil/log.h | 13 + libavutil/opt.c | 24 ++-- libavutil/opt.h | 31

[FFmpeg-devel] [PATCH 01/17] Remove unnecessary use of avcodec_close().

2020-05-28 Thread Anton Khirnov
Replace it with avcodec_free_context() or drop it completely as appropriate. --- libavcodec/avrndec.c | 3 +-- libavcodec/smvjpegdec.c| 3 +-- libavcodec/tests/options.c | 1 - libavfilter/vf_subtitles.c | 1 - libavfilter/vf_uspp.c | 6 ++ tests/api/api-band-test.c | 1 -

[FFmpeg-devel] [PATCH 09/17] af_aresample: switch to child_class_iterate()

2020-05-28 Thread Anton Khirnov
--- libavfilter/af_aresample.c | 12 1 file changed, 12 insertions(+) diff --git a/libavfilter/af_aresample.c b/libavfilter/af_aresample.c index ef10621c35..fb10bd1c33 100644 --- a/libavfilter/af_aresample.c +++ b/libavfilter/af_aresample.c @@ -293,10 +293,19 @@ static int request_fr

[FFmpeg-devel] [PATCH 03/17] lavf/dump: schedule use of deprecated API for removal

2020-05-28 Thread Anton Khirnov
--- libavformat/dump.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/libavformat/dump.c b/libavformat/dump.c index 06bafc272d..117c68145c 100644 --- a/libavformat/dump.c +++ b/libavformat/dump.c @@ -500,6 +500,8 @@ static void dump_stream_format(AVFormatContext *ic, int i,

[FFmpeg-devel] [PATCH 06/17] fftools: switch to the new child class iteration API

2020-05-28 Thread Anton Khirnov
--- fftools/cmdutils.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/fftools/cmdutils.c b/fftools/cmdutils.c index a948d478d5..e7ceed1c38 100644 --- a/fftools/cmdutils.c +++ b/fftools/cmdutils.c @@ -202,13 +202,14 @@ void show_help_options(const OptionDef *options, const

[FFmpeg-devel] [PATCH 14/17] vf_spp: switch to child_class_iterate()

2020-05-28 Thread Anton Khirnov
--- libavfilter/vf_spp.c | 12 1 file changed, 12 insertions(+) diff --git a/libavfilter/vf_spp.c b/libavfilter/vf_spp.c index a83b1195c0..4bcc6429e0 100644 --- a/libavfilter/vf_spp.c +++ b/libavfilter/vf_spp.c @@ -44,10 +44,19 @@ enum mode { NB_MODES }; +#if FF_API_CHILD_CLA

[FFmpeg-devel] [PATCH 13/17] vf_scale: switch to child_class_iterate()

2020-05-28 Thread Anton Khirnov
--- libavfilter/vf_scale.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/libavfilter/vf_scale.c b/libavfilter/vf_scale.c index 0348f19d33..f92529e7c8 100644 --- a/libavfilter/vf_scale.c +++ b/libavfilter/vf_scale.c @@ -882,10 +882,19 @@ static int process_command(AVFilterCon

[FFmpeg-devel] [PATCH 10/17] af_resample: switch to child_class_iterate()

2020-05-28 Thread Anton Khirnov
--- libavfilter/af_resample.c | 12 1 file changed, 12 insertions(+) diff --git a/libavfilter/af_resample.c b/libavfilter/af_resample.c index e3c6a20696..785cd0c7f4 100644 --- a/libavfilter/af_resample.c +++ b/libavfilter/af_resample.c @@ -306,10 +306,19 @@ fail: return ret; }

[FFmpeg-devel] [PATCH 16/17] AVIOContext: switch to child_class_iterate()

2020-05-28 Thread Anton Khirnov
--- libavformat/aviobuf.c | 12 1 file changed, 12 insertions(+) diff --git a/libavformat/aviobuf.c b/libavformat/aviobuf.c index eb0387bdf7..5ba5de01c6 100644 --- a/libavformat/aviobuf.c +++ b/libavformat/aviobuf.c @@ -48,10 +48,19 @@ static void *ff_avio_child_next(void *obj, void

[FFmpeg-devel] [PATCH 17/17] AVFormatContext: switch to child_class_iterate()

2020-05-28 Thread Anton Khirnov
--- libavformat/options.c | 64 +++ 1 file changed, 64 insertions(+) diff --git a/libavformat/options.c b/libavformat/options.c index e14510504f..3160904fda 100644 --- a/libavformat/options.c +++ b/libavformat/options.c @@ -21,6 +21,7 @@ #include "avio_int

[FFmpeg-devel] [PATCH 12/17] framesync: switch to child_class_iterate()

2020-05-28 Thread Anton Khirnov
--- libavfilter/framesync.c | 7 +++ libavfilter/framesync.h | 3 +++ 2 files changed, 10 insertions(+) diff --git a/libavfilter/framesync.c b/libavfilter/framesync.c index b32a5cba6c..04119d686c 100644 --- a/libavfilter/framesync.c +++ b/libavfilter/framesync.c @@ -53,6 +53,13 @@ static cons

[FFmpeg-devel] [PATCH 04/17] lavu/mem: move the DECLARE_ALIGNED macro family to mem_internal on next bump

2020-05-28 Thread Anton Khirnov
They are not properly namespaced and not intended for public use. --- libavutil/mem.h | 6 libavutil/mem_internal.h | 70 libavutil/version.h | 4 ++- 3 files changed, 79 insertions(+), 1 deletion(-) diff --git a/libavutil/mem.h b/liba

[FFmpeg-devel] [PATCH 11/17] avflter: switch to child_class_iterate()

2020-05-28 Thread Anton Khirnov
--- libavfilter/avfilter.c | 16 1 file changed, 16 insertions(+) diff --git a/libavfilter/avfilter.c b/libavfilter/avfilter.c index 394811916d..dd8074e462 100644 --- a/libavfilter/avfilter.c +++ b/libavfilter/avfilter.c @@ -583,6 +583,7 @@ static void *filter_child_next(void *ob

[FFmpeg-devel] [PATCH 07/17] bsf: switch to child_class_iterate()

2020-05-28 Thread Anton Khirnov
--- libavcodec/bitstream_filters.c | 14 ++ libavcodec/bsf.c | 3 +++ libavcodec/bsf_internal.h | 4 3 files changed, 21 insertions(+) diff --git a/libavcodec/bitstream_filters.c b/libavcodec/bitstream_filters.c index a7aa5dca65..b26d6a910e 100644 --- a/libav

[FFmpeg-devel] [PATCH 08/17] AVCodecContext: switch to child_class_iterate()

2020-05-28 Thread Anton Khirnov
--- libavcodec/options.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/libavcodec/options.c b/libavcodec/options.c index 7706a03297..ff16e2cbfd 100644 --- a/libavcodec/options.c +++ b/libavcodec/options.c @@ -53,6 +53,7 @@ static void *codec_child_next(void *obj, void *prev)

[FFmpeg-devel] [PATCH 02/17] avdevice: deprecate av_*_device_next()

2020-05-28 Thread Anton Khirnov
These functions rely on deprecated libavformat APIs and apparently have zero users outside of cmdutils. Since the functionality they provide is apparently not useful to anyone, deprecate them without replacement. --- doc/APIchanges | 4 fftools/cmdutils.c | 2 +- fftools/cmdutils.

[FFmpeg-devel] [PATCH 15/17] URLContext: switch to child_class_iterate()

2020-05-28 Thread Anton Khirnov
--- libavformat/avio.c | 3 +++ libavformat/protocols.c | 16 libavformat/url.h | 4 3 files changed, 23 insertions(+) diff --git a/libavformat/avio.c b/libavformat/avio.c index 237966c303..3886ed7a90 100644 --- a/libavformat/avio.c +++ b/libavformat/avio.c @@ -

Re: [FFmpeg-devel] [PATCH 1/2] avcodec: Add AV_CODEC_FLAG2_FAST_UNSAFE, move unsafe uses of FAST to it

2020-05-28 Thread Lynne
May 28, 2020, 17:20 by mich...@niedermayer.cc: > TODO: Bump > > */ > #define AV_CODEC_FLAG2_FAST (1 << 0) > + > +/** > + * Allow speedups tricks which can read out of array on non compliant > streams. > + */ > +#define AV_CODEC_FLAG2_FAST_UNSAFE(1 << 1) > That's a bug. We shoul

Re: [FFmpeg-devel] [PATCH] Don't adjust start time for MP3 files; packets are not adjusted.

2020-05-28 Thread Michael Niedermayer
On Wed, May 27, 2020 at 11:57:13AM -0700, Dale Curtis wrote: > On Wed, May 27, 2020 at 8:29 AM Michael Niedermayer > wrote: > > > what id like to point out here is that the audio stream no > > longer starts at the same time as the video > > also the duration from adding the durations before is >

Re: [FFmpeg-devel] [PATCH 1/2] avcodec: Add AV_CODEC_FLAG2_FAST_UNSAFE, move unsafe uses of FAST to it

2020-05-28 Thread Kieran Kunhya
> > More generally though (outside this unsafe flag case) > i do disagree with your argument a bit, performance does matter. > Iam regularly reminded of that for example, so much software becomes > slower on each upgrade with few if any features added the real users > care about. Just to pick one,

Re: [FFmpeg-devel] [FFmpeg-cvslog] lavfi/vulkan: use all enabled queues in the queue family

2020-05-28 Thread Michael Niedermayer
On Sat, May 23, 2020 at 06:09:06PM +, Lynne wrote: > ffmpeg | branch: master | Lynne | Thu May 14 00:37:21 2020 > +0100| [727cac88b8c4b1facd93a3c863ef7e7072feda36] | committer: Lynne > > lavfi/vulkan: use all enabled queues in the queue family > > This should significantly improve the perfo

Re: [FFmpeg-devel] [PATCH v5 4/4] avformat: add kvag muxer

2020-05-28 Thread Michael Niedermayer
On Sat, May 16, 2020 at 11:53:51AM +, Zane van Iperen wrote: > Signed-off-by: Zane van Iperen > --- > Changelog| 1 + > libavformat/Makefile | 1 + > libavformat/allformats.c | 1 + > libavformat/kvag.c | 84 +++- > libavformat/

Re: [FFmpeg-devel] [PATCH 02/17] avdevice: deprecate av_*_device_next()

2020-05-28 Thread Josh de Kock
On 28/05/2020 21:15, Anton Khirnov wrote: These functions rely on deprecated libavformat APIs and apparently have zero users outside of cmdutils. Since the functionality they provide is apparently not useful to anyone, deprecate them without replacement. --- doc/APIchanges | 4 ff

Re: [FFmpeg-devel] [RFC PATCH] libavcodec/jpeg2000_parser: Add jpeg2000 parser

2020-05-28 Thread Michael Niedermayer
On Fri, May 29, 2020 at 12:33:01AM +0530, gautamr...@gmail.com wrote: > From: Gautam Ramakrishnan > > I have attempted to write a JPEG2000 Parser. Have tested > by generating a file containing 14 frames, as mentioned > by Micheal. Have also tried testing with various packet > sizes by setting -fr

[FFmpeg-devel] [PATCH] libavfilter/vf_drawtext.c:add support to generte ms level

2020-05-28 Thread 黄思远
___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH] libavformat/dashenc.c:make a sample Latency element

2020-05-28 Thread 黄思远
___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH] libavformat/dashenc.c:add mimetype

2020-05-28 Thread 黄思远
___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH] libavformat/dashenc.c:add support to change update interval

2020-05-28 Thread 黄思远
___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH] libavformat/dashenc.c:keep same with streaming , when live end

2020-05-28 Thread 黄思远
___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH] avformat/hls: check segment duration value of EXTINF

2020-05-28 Thread Steven Liu
fix ticket: 8673 set the default EXTINF duration to 1ms if duration is smaller than 1ms Signed-off-by: Steven Liu --- libavformat/hls.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/libavformat/hls.c b/libavformat/hls.c index 3e35d157ad..8c4126b880 100644 --- a/lib

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/adpcm_data: extend ff_adpcm_ima_cunning_index_table

2020-05-28 Thread Zane van Iperen
On Thu, 28 May 2020 18:44:55 +0200 "Michael Niedermayer" wrote: > > The index table should only ever be indexed between [0,7], so this > > looks like a bug in adpcm_ima_cunning_expand_nibble() instead. > > maybe it should be only 0..7 but abs(-8 .. 7) needs a 8th entrty or a > check > > > >

  1   2   >