On 5/28/20, Nicolas George <geo...@nsup.org> wrote: > Paul B Mahol (12020-05-24): >> Signed-off-by: Paul B Mahol <one...@gmail.com> >> --- >> libavfilter/avfilter.c | 61 +++++++++++++++++++++++++++++++++++++----- >> libavfilter/filters.h | 17 ++++++++++++ >> 2 files changed, 72 insertions(+), 6 deletions(-) > > I am against this. > > It adds quite a lot of complexity in common code. > > This complexity is not needed: in patch 4/4, you always peek > s->window_size samples and skip s->hop_size, constants: just allocate a > permanent buffer with size s->window_size and roll by s->hop_size in it. > It will be more efficient (less copying around, less allocations) and > simpler. >
Your arrogance means nothing to me. Will apply in 5 minutes. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
