On Wed, May 27, 2020 at 11:57:13AM -0700, Dale Curtis wrote: > On Wed, May 27, 2020 at 8:29 AM Michael Niedermayer <mich...@niedermayer.cc> > wrote: > > > what id like to point out here is that the audio stream no > > longer starts at the same time as the video > > also the duration from adding the durations before is > > exact but not afterwards > > > > I'm not sure about the duration issue, I'd assume it's just an accounting > error since the change only affects start_time. As noted in the change > description, if you want to keep start_time adjusted for skip samples all > packet timestamps need to be changed too. Doing that broke many test cases > at the time, so we opted to just revert the patch. I.e., basically every > mp3 changes to having its first PTS be ~26ms due to the common 1152 skip > sample amount.
I dont really have an oppinion about start_time, its more the change in timestamps & duratiion on the output side which is whats user vissible and that looked worse for the testcase thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB He who knows, does not speak. He who speaks, does not know. -- Lao Tsu
signature.asc
Description: PGP signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
