Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: compute segment duration use current pts minus last segment end pts

2020-04-29 Thread myp...@gmail.com
On Wed, Apr 29, 2020 at 12:44 PM Steven Liu wrote: > > segment duration is using vs duration which compute by frame per second, > that can not fix problem of VFR video stream, so compute the duration > when split the segment, set the segment target duration use > current packet pts minus the prev

Re: [FFmpeg-devel] [PATCH v2] lavf/mp3enc: fix ID3v1 year metadata setting issue

2020-04-29 Thread myp...@gmail.com
On Sun, Apr 26, 2020 at 10:20 PM myp...@gmail.com wrote: > > On Wed, Apr 22, 2020 at 3:57 PM Jun Zhao wrote: > > > > From: Jun Zhao > > > > Follow the http://id3.org/ID3v1, setting the year metadata > > for ID3v1. > > > > fix #8623 > > > > Signed-off-by: Jun Zhao > > --- > > libavformat/mp3enc

[FFmpeg-devel] [PATCH v1] avcodec/v4l2_m2m_enc: Set bitrate mode to cbr by default

2020-04-29 Thread Ming Qian
Without this setting, bitrate may have no effect if the default value of bitrate mode is VBR. Signed-off-by: Ming Qian --- libavcodec/v4l2_m2m_enc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/v4l2_m2m_enc.c b/libavcodec/v4l2_m2m_enc.c index 8454e2326c..6296ad88c6 1006

[FFmpeg-devel] [PATCH] avformat/utils: change the duration to int64_t for update_initial_durations

2020-04-29 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavformat/utils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/utils.c b/libavformat/utils.c index 3b53f97bee..44109d866d 100644 --- a/libavformat/utils.c +++ b/libavformat/utils.c @@ -1174,7 +1174,7 @@ static v

Re: [FFmpeg-devel] [PATCH v6 1/5] lavc/libopenh264enc: Add qmin/qmax support

2020-04-29 Thread Martin Storsjö
On Wed, 29 Apr 2020, Linjie Fu wrote: Clip iMinQp/iMaxQp to (1, 51) for user specified qp range. If not set, leave iMinQp/iMaxQp untouched and use the values (0, 51) initialized in FillDefault(), and the QP range would be adjusted to the defaults inside libopenh264 library according to the iUsa

Re: [FFmpeg-devel] [PATCH v6 2/5] lavc/libopenh264enc: add default gop size and bit rate

2020-04-29 Thread Martin Storsjö
On Wed, 29 Apr 2020, Linjie Fu wrote: It would be 200kbps bitrate with gop size = 12 by default which generated too many IDR frames in rather low bit rate. The quality would be poor. Set these default values to -1 to check whether it's specified by user explicitly. Use 2Mbps bitrate as nvenc s

Re: [FFmpeg-devel] [PATCH v6 3/5] lavc/libopenh264enc: add bit rate control select support

2020-04-29 Thread Martin Storsjö
On Wed, 29 Apr 2020, Linjie Fu wrote: RC_BITRATE_MODE: set BITS_EXCEEDED to iCurrentBitsLevel and allows QP adjust in RcCalculatePictureQp(). RC_BUFFERBASED_MODE: use buffer status to adjust the video quality. RC_TIMESTAMP_MODE: bit rate control based on timestamp, introduced in re

Re: [FFmpeg-devel] [PATCH v6 4/5] lavc/libopenh264enc: prompt slice number changing inside libopenh264

2020-04-29 Thread Martin Storsjö
On Wed, 29 Apr 2020, Linjie Fu wrote: Libopenh264enc would set the slice according to the number of cpu cores if uiSliceNum equals to 0 (auto) in SM_FIXEDSLCNUM_SLICE mode. Prompt a warning for user to catch this. Signed-off-by: Linjie Fu --- libavcodec/libopenh264enc.c | 2 ++ 1 file changed,

Re: [FFmpeg-devel] [PATCH v6 5/5] lavc/libopenh264enc: set slice_mode option to deprecated

2020-04-29 Thread Martin Storsjö
On Wed, 29 Apr 2020, Linjie Fu wrote: "slice mode" option seems to be unnecessary since it could be determined by -slices/max_nal_size. default:SM_FIXEDSLCNUM_SLICE mode with cpu-number slices. -slices N: SM_FIXEDSLCNUM_SLICE mode with N slices. -max_nal_size: SM_SIZELIMITED_SLICE

[FFmpeg-devel] [PATCH] avformat/srtenc: split write time into function for better readability

2020-04-29 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavformat/srtenc.c | 24 ++-- 1 file changed, 18 insertions(+), 6 deletions(-) diff --git a/libavformat/srtenc.c b/libavformat/srtenc.c index d811a4da0e..ca127354ed 100644 --- a/libavformat/srtenc.c +++ b/libavformat/srtenc.c

Re: [FFmpeg-devel] [PATCH] avformat/srtenc: split write time into function for better readability

2020-04-29 Thread Andreas Rheinhardt
lance.lmw...@gmail.com: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavformat/srtenc.c | 24 ++-- > 1 file changed, 18 insertions(+), 6 deletions(-) > > diff --git a/libavformat/srtenc.c b/libavformat/srtenc.c > index d811a4da0e..ca127354ed 100644 > --- a/lib

Re: [FFmpeg-devel] [PATCH] avformat/srtenc: split write time into function for better readability

2020-04-29 Thread lance . lmwang
On Wed, Apr 29, 2020 at 11:12:21AM +0200, Andreas Rheinhardt wrote: > lance.lmw...@gmail.com: > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > libavformat/srtenc.c | 24 ++-- > > 1 file changed, 18 insertions(+), 6 deletions(-) > > > > diff --git a/libavfo

[FFmpeg-devel] [PATCH v2] avformat/srtenc: split write time into function for better readability

2020-04-29 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavformat/srtenc.c | 24 ++-- 1 file changed, 18 insertions(+), 6 deletions(-) diff --git a/libavformat/srtenc.c b/libavformat/srtenc.c index d811a4da0e..c53b227313 100644 --- a/libavformat/srtenc.c +++ b/libavformat/srtenc.c

[FFmpeg-devel] [PATCH] tools: fix const specifier for AVInputFormat

2020-04-29 Thread Josh de Kock
Signed-off-by: Josh de Kock --- tools/probetest.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Small fix for compiler warning caused by my earlier change. diff --git a/tools/probetest.c b/tools/probetest.c index cfa309cabd..6f0e002b74 100644 --- a/tools/probetest.c +++ b/tools/probete

Re: [FFmpeg-devel] [PATCH] avformat/hls: disable persistent HTTP connections by default w/ schannel

2020-04-29 Thread Josh de Kock
On 26/04/2020 20:43, Jan Ekström wrote: This TLS implementation has always had issues with the way that libavformat implemented persistency, yet nobody seemed to be able to figure out why. It currently can lead to completely stuck playback, so disable it by default. Additionally, update the docu

Re: [FFmpeg-devel] [PATCH] fate: Skip the dnxhd-uhd-hr-sq tests of large tests are disabled

2020-04-29 Thread Josh de Kock
On 23/04/2020 08:14, Martin Storsjö wrote: These tests are also in the same size range as the previously skipped 2k and 4k tests. --- tests/fate/vcodec.mak | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tests/fate/vcodec.mak b/tests/fate/vcodec.mak index fc27da5456..e

Re: [FFmpeg-devel] [PATCH] Add general_assembly_bootstrap.pl

2020-04-29 Thread Josh de Kock
On 24/04/2020 11:44, Josh de Kock wrote: On 24/04/2020 11:29, Nicolas George wrote: Josh de Kock (12020-04-24): This script aims to extract contributors who are eligible for the general assembly. Signed-off-by: Josh de Kock ---   Better late than never, this patch will continue to put in pla

Re: [FFmpeg-devel] [PATCH 0/2] fix for seeking in HLS with TS/FMP4 media

2020-04-29 Thread Josh de Kock
On 25/04/2020 22:42, Carl Eugen Hoyos wrote: Am Fr., 24. Apr. 2020 um 17:21 Uhr schrieb vectronic : I am resubmitting a patch which fixes the following two tickets: Do you not want to commit with your name rather than a handle here? https://trac.ffmpeg.org/ticket/7359 https://trac.ffmpeg.o

Re: [FFmpeg-devel] [PATCH, v4] lavc/vp9: fix reference frame dimensions check for SINGLE_REFERENCE mode

2020-04-29 Thread Fu, Linjie
> From: ffmpeg-devel On Behalf Of Fu, > Linjie > Sent: Friday, March 20, 2020 09:49 > To: Ronald S. Bultje ; FFmpeg development > discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH, v4] lavc/vp9: fix reference frame > dimensions check for SINGLE_REFERENCE mode > > > From: Ronald S. Bul

Re: [FFmpeg-devel] [PATCH] tests/api/api-h264-slice-test: remove unused bool header

2020-04-29 Thread Fu, Linjie
> From: ffmpeg-devel On Behalf Of > Carl Eugen Hoyos > Sent: Thursday, April 2, 2020 03:23 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH] tests/api/api-h264-slice-test: remove > unused bool header > > Am Mi., 1. Apr. 2020 um 06:58 Uhr sch

Re: [FFmpeg-devel] [PATCH] tests/api/api-h264-slice-test: remove unused bool header

2020-04-29 Thread Josh de Kock
On 29/04/2020 13:11, Fu, Linjie wrote: From: ffmpeg-devel On Behalf Of Carl Eugen Hoyos Sent: Thursday, April 2, 2020 03:23 To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH] tests/api/api-h264-slice-test: remove unused bool header Am Mi., 1. Apr. 2020 um 06:58

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: compute segment duration use current pts minus last segment end pts

2020-04-29 Thread Steven Liu
> 2020年4月29日 下午3:07,myp...@gmail.com 写道: > > On Wed, Apr 29, 2020 at 12:44 PM Steven Liu wrote: >> >> segment duration is using vs duration which compute by frame per second, >> that can not fix problem of VFR video stream, so compute the duration >> when split the segment, set the segment tar

[FFmpeg-devel] [PATCH v2] avformat/hlsenc: compute segment duration use current pts minus last segment end pts

2020-04-29 Thread Steven Liu
segment duration is using vs duration which compute by frame per second, that can not fix problem of VFR video stream, so compute the duration when split the segment, set the segment target duration use current packet pts minus the prev segment end pts.. Reported-by: Zhao Jun Signed-off-by: Steve

Re: [FFmpeg-devel] [PATCH] Add general_assembly_bootstrap.pl

2020-04-29 Thread Anton Khirnov
Quoting Nicolas George (2020-04-24 12:29:23) > Josh de Kock (12020-04-24): > > This script aims to extract contributors who are eligible for the > > general assembly. > > > > Signed-off-by: Josh de Kock > > --- > > > > Better late than never, this patch will continue to put in place the > > vo

Re: [FFmpeg-devel] [PATCH v2] avfilter/vf_v360: adjustment out_pad and in_pad maximum value to 1/10

2020-04-29 Thread Josh de Kock
On 26/04/2020 15:43, Steven Liu wrote: 2020年4月21日 下午10:54,Steven Liu 写道: Because not every user know about in_pad and out_pad reasonable value range so maybe try to set 1.0, but setting 1.0 is so hugh to get an fatal error. Suggested-by: Paul B Mahol Signed-off-by: Steven Liu --- doc/filt

Re: [FFmpeg-devel] [PATCH] Add general_assembly_bootstrap.pl

2020-04-29 Thread Nicolas George
Anton Khirnov (12020-04-29): > > > Better late than never, this patch will continue to put in place the > > > voting systems for FFmpeg discussed at VDD 2019 and FOSDEM 2020. > > > There is probably a better way to do this, but the aim is just to > > > 'bootstrap' and kickstart the process and

Re: [FFmpeg-devel] [PATCH] Add general_assembly_bootstrap.pl

2020-04-29 Thread Josh de Kock
On 29/04/2020 14:00, Nicolas George wrote: Anton Khirnov (12020-04-29): Better late than never, this patch will continue to put in place the voting systems for FFmpeg discussed at VDD 2019 and FOSDEM 2020. There is probably a better way to do this, but the aim is just to 'bootstrap' and

Re: [FFmpeg-devel] [PATCH] Add general_assembly_bootstrap.pl

2020-04-29 Thread Nicolas George
Josh de Kock (12020-04-29): > To add to this: > > We could decide to use this every time, but that would have to be done by a > vote. But we can't vote on that with nothing, so hence we have this to begin > somewhere. > > The community and technical committees will be decided by the bootstrapped

Re: [FFmpeg-devel] [PATCH 1/3] avformat/fifo: add option to delay output

2020-04-29 Thread Nicolas George
leozhang (12020-04-29): > Signed-off-by: leozhang > --- > doc/muxers.texi| 3 +++ > libavformat/fifo.c | 7 +++ > 2 files changed, 10 insertions(+) > > diff --git a/doc/muxers.texi b/doc/muxers.texi > index cb2bb42..a74cbc4 100644 > --- a/doc/muxers.texi > +++ b/doc/muxers.texi > @@ -227

Re: [FFmpeg-devel] [PATCH v6 1/5] lavc/libopenh264enc: Add qmin/qmax support

2020-04-29 Thread Fu, Linjie
> From: Martin Storsjö > Sent: Wednesday, April 29, 2020 16:52 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Cc: Fu, Linjie > Subject: Re: [FFmpeg-devel] [PATCH v6 1/5] lavc/libopenh264enc: Add > qmin/qmax support > > On Wed, 29 Apr 2020, Linjie Fu wrote: > > > Clip iMin

Re: [FFmpeg-devel] [PATCH 2/3] avformat/fifo: add option to write packets in paced way

2020-04-29 Thread Nicolas George
leozhang (12020-04-29): > Signed-off-by: leozhang > --- > doc/muxers.texi| 3 +++ > libavformat/fifo.c | 19 +++ > 2 files changed, 22 insertions(+) > > diff --git a/doc/muxers.texi b/doc/muxers.texi > index a74cbc4..5140c00 100644 > --- a/doc/muxers.texi > +++ b/doc/muxers.

Re: [FFmpeg-devel] [PATCH v2] avformat/srtenc: split write time into function for better readability

2020-04-29 Thread Nicolas George
lance.lmw...@gmail.com (12020-04-29): > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavformat/srtenc.c | 24 ++-- > 1 file changed, 18 insertions(+), 6 deletions(-) > > diff --git a/libavformat/srtenc.c b/libavformat/srtenc.c > index d811a4da0e..c53b227313 1006

Re: [FFmpeg-devel] [PATCH 2/3] oggdec: verify page checksum

2020-04-29 Thread Michael Niedermayer
On Tue, Apr 28, 2020 at 07:22:08PM +0200, Lynne wrote: > Apr 28, 2020, 16:07 by d...@lynne.ee: > > > Apr 28, 2020, 15:59 by mattias.wad...@gmail.com: > > > >> > >> > > Well, I consider CRC checking a part of correctly parsing ogg, so I think > > its best to leave it on > > all the time. > > > >

Re: [FFmpeg-devel] [PATCH v1] MAINTAINERS: add myself to the general developers list

2020-04-29 Thread Michael Niedermayer
On Sun, Apr 26, 2020 at 06:50:09PM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > I have actively contributed to FFmpeg in the past year and should be familiar > with the entire code base and the rules of the developers. Up to now, more > than > on

Re: [FFmpeg-devel] [PATCH v2] avformat/srtenc: split write time into function for better readability

2020-04-29 Thread Limin Wang
On Wed, Apr 29, 2020 at 04:38:42PM +0200, Nicolas George wrote: > lance.lmw...@gmail.com (12020-04-29): > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > libavformat/srtenc.c | 24 ++-- > > 1 file changed, 18 insertions(+), 6 deletions(-) > > > > diff --git

[FFmpeg-devel] [PATCH 3/5] avformat/matroskaenc: reindent after the previous commit

2020-04-29 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavformat/matroskaenc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavformat/matroskaenc.c b/libavformat/matroskaenc.c index f0474da44f..41446c3825 100644 --- a/libavformat/matroskaenc.c +++ b/libavformat/matroska

[FFmpeg-devel] [PATCH 2/5] avformat/matroskaenc: fix invalid pointer access if avio_get_dyn_buf failed

2020-04-29 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavformat/matroskaenc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavformat/matroskaenc.c b/libavformat/matroskaenc.c index 784973a951..f0474da44f 100644 --- a/libavformat/matroskaenc.c +++ b/libavformat/matroskaenc.c @@ -374,9 +37

[FFmpeg-devel] [PATCH 1/5] avformat/dashenc: fix invalid pointer access if avio_get_dyn_buf failed

2020-04-29 Thread lance . lmwang
From: Limin Wang If an error occurs, avio_get_dyn_buf() will return 0 and buf is NULL, so it's necessary to check the return value for the following code will access the buf pointer with index. In addition, the buf len should be greater than written_len to avoid the buffer overflow access. Si

[FFmpeg-devel] [PATCH 4/5] avformat/movenc: check the return value of avio_get_dyn_buf()

2020-04-29 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavformat/movenc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index 32e8109268..1a97e7c883 100644 --- a/libavformat/movenc.c +++ b/libavformat/movenc.c @@ -5251,10 +5251,11 @@

[FFmpeg-devel] [PATCH 5/5] avformat/movenc: reindent after the previous commit

2020-04-29 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavformat/movenc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index 1a97e7c883..ad04143f14 100644 --- a/libavformat/movenc.c +++ b/libavformat/movenc.c @@ -5252,9 +5252,9

Re: [FFmpeg-devel] [PATCH 1/5] avformat/dashenc: fix invalid pointer access if avio_get_dyn_buf failed

2020-04-29 Thread Nicolas George
lance.lmw...@gmail.com (12020-04-29): > From: Limin Wang > > If an error occurs, avio_get_dyn_buf() will return 0 and buf is NULL, so it's > necessary to check > the return value for the following code will access the buf pointer with > index. In addition, > the buf len should be greater than w

Re: [FFmpeg-devel] [PATCH 2/5] avformat/matroskaenc: fix invalid pointer access if avio_get_dyn_buf failed

2020-04-29 Thread Nicolas George
lance.lmw...@gmail.com (12020-04-29): > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavformat/matroskaenc.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/libavformat/matroskaenc.c b/libavformat/matroskaenc.c > index 784973a951..f0474da44f 100644 > --- a/libavformat/m

Re: [FFmpeg-devel] [PATCH 4/5] avformat/movenc: check the return value of avio_get_dyn_buf()

2020-04-29 Thread Nicolas George
lance.lmw...@gmail.com (12020-04-29): > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavformat/movenc.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/libavformat/movenc.c b/libavformat/movenc.c > index 32e8109268..1a97e7c883 100644 > --- a/libavformat/m

Re: [FFmpeg-devel] [PATCH v2] avformat/srtenc: split write time into function for better readability

2020-04-29 Thread Nicolas George
Limin Wang (12020-04-29): > Sorry, the idea is coming from webvtt_write_time() Well, I do not like Matthew Heaney's style. Everybody can use their preferred style in their own files, of course. Regards, -- Nicolas George signature.asc Description: PGP signature _

Re: [FFmpeg-devel] [PATCH 1/5] avformat/dashenc: fix invalid pointer access if avio_get_dyn_buf failed

2020-04-29 Thread Limin Wang
On Wed, Apr 29, 2020 at 05:18:18PM +0200, Nicolas George wrote: > lance.lmw...@gmail.com (12020-04-29): > > From: Limin Wang > > > > If an error occurs, avio_get_dyn_buf() will return 0 and buf is NULL, so > > it's necessary to check > > the return value for the following code will access the bu

Re: [FFmpeg-devel] [PATCH 1/5] avformat/dashenc: fix invalid pointer access if avio_get_dyn_buf failed

2020-04-29 Thread Nicolas George
Limin Wang (12020-04-29): > yes, avio_write can process zero len with NULL pointer, but here it'll use > buf+written_len, so > it's invalid access I think. So what's the broken? Maybe I haven't catch your > point. What's broken is that the code is supposed to do something, and with your change i

Re: [FFmpeg-devel] [PATCH 1/5] avformat/dashenc: fix invalid pointer access if avio_get_dyn_buf failed

2020-04-29 Thread lance . lmwang
On Wed, Apr 29, 2020 at 05:39:36PM +0200, Nicolas George wrote: > Limin Wang (12020-04-29): > > yes, avio_write can process zero len with NULL pointer, but here it'll use > > buf+written_len, so > > it's invalid access I think. So what's the broken? Maybe I haven't catch > > your point. > > What

Re: [FFmpeg-devel] [PATCH 0/3] Patch set to delay output live stream

2020-04-29 Thread Marton Balint
On Wed, 29 Apr 2020, leozhang wrote: In some applications, it is required to add delay to live streaming. In what applications? And if you do this, why not run sleep 20; ffmpeg I don't see how this is useful at all. And what is -paced? What it is used for? Isn't it the same as using

[FFmpeg-devel] [PATCH 1/1] ensure closed caption info which is visible in default stream dump is also available in results when -show_streams is used

2020-04-29 Thread vectronic
Signed-off-by: vectronic --- doc/ffprobe.xsd | 1 + fftools/ffprobe.c | 2 ++ tests/ref/fate/concat-demuxer-extended-lavf-mxf | 2 +- tests/ref/fate/concat-demuxer-extended-lavf-mxf_d10 | 2 +- tests

[FFmpeg-devel] [PATCH V4 0/1] ffprobe add closed caption output to stream info

2020-04-29 Thread vectronic
ensure closed caption info which is visible in default stream dump is also available in results when -show_streams is used and update test references for closed_caption output in ffprobe stream results changes from last version: - ffprobe modifications are correctly within existing FF_API_LAVF_AV

Re: [FFmpeg-devel] [PATCH] avutil/opt: only skip evaluation for rational options

2020-04-29 Thread Marton Balint
On Sat, 18 Apr 2020, Marton Balint wrote: Fixes problems when non-rational options were set using rational expressions, causing rounding errors and the option range limits not to be enforced properly. ffmpeg -f lavfi -i "sine=r=96000/2" This caused an assertion failure with assert level 2.

[FFmpeg-devel] [PATCH] ppc: configure: Support Power ISA 3.0

2020-04-29 Thread Trung Le
POWER 9 supports VSX-3 Signed-off-by: Trung Le --- configure | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/configure b/configure index 080d93a129..33045f5989 100755 --- a/configure +++ b/configure @@ -419,6 +419,7 @@ Optimization options (experts only): --disab

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: add support for microseconds since epoch based sequence number

2020-04-29 Thread Marton Balint
On Sat, 18 Apr 2020, Marton Balint wrote: Sequence numbers of segments should be unique, if an encoder is using shorter than 1 second segments and it is restarted, then future segments will be using already used sequence numbers if initial sequence number is based on the number of seconds sinc

Re: [FFmpeg-devel] [PATCH 1/5] avformat/dashenc: fix invalid pointer access if avio_get_dyn_buf failed

2020-04-29 Thread Nicolas George
lance.lmw...@gmail.com (12020-04-29): > Thanks, I catch your point now. Most of existing code haven't return ERROR, > so I > choose the same way to process it. If you think it's not OK, we'll change more > code I think. Maybe the other code needs to be fixed the same way. Maybe the other code nee

Re: [FFmpeg-devel] [PATCH] ppc: configure: Support Power ISA 3.0

2020-04-29 Thread Carl Eugen Hoyos
Am Mi., 29. Apr. 2020 um 18:27 Uhr schrieb Trung Le : > > POWER 9 supports VSX-3 Shouldn't --disable-power8 also disable power9 (assuming there is a difference)? Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman

Re: [FFmpeg-devel] [PATCH] tools: fix const specifier for AVInputFormat

2020-04-29 Thread Michael Niedermayer
On Wed, Apr 29, 2020 at 12:00:23PM +0100, Josh de Kock wrote: > Signed-off-by: Josh de Kock > --- > tools/probetest.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > Small fix for compiler warning caused by my earlier change. LGTM thx [...] -- Michael GnuPG fingerprint: 9FF2

Re: [FFmpeg-devel] [PATCH] avformat/utils: change the duration to int64_t for update_initial_durations

2020-04-29 Thread Michael Niedermayer
On Wed, Apr 29, 2020 at 04:01:29PM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavformat/utils.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) LGTM thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0

Re: [FFmpeg-devel] [PATCH 0/3] Patch set to delay output live stream

2020-04-29 Thread Tao Zhang
Marton Balint 于2020年4月30日周四 上午12:03写道: > > > > On Wed, 29 Apr 2020, leozhang wrote: > > > In some applications, it is required to add delay to live streaming. > > In what applications? And if you do this, why not run > > sleep 20; ffmpeg In live streaming applications, someone wouldn't want b

Re: [FFmpeg-devel] [PATCH 0/3] Patch set to delay output live stream

2020-04-29 Thread Marton Balint
On Thu, 30 Apr 2020, Tao Zhang wrote: Marton Balint 于2020年4月30日周四 上午12:03写道: On Wed, 29 Apr 2020, leozhang wrote: > In some applications, it is required to add delay to live streaming. In what applications? And if you do this, why not run sleep 20; ffmpeg In live streaming applic

Re: [FFmpeg-devel] [PATCH 2/3] libswscale: add output support for AV_PIX_FMT_GBRAPF32

2020-04-29 Thread Michael Niedermayer
On Tue, Apr 28, 2020 at 08:02:34PM -0700, mindm...@gmail.com wrote: > From: Mark Reid > > --- > libswscale/output.c | 82 > libswscale/slice.c | 28 > libswscale/swscale_unscaled.c| 33 ++ > libswsca

Re: [FFmpeg-devel] [PATCH 2/3] libswscale: add output support for AV_PIX_FMT_GBRAPF32

2020-04-29 Thread Michael Niedermayer
On Wed, Apr 29, 2020 at 11:19:56PM +0200, Michael Niedermayer wrote: > On Tue, Apr 28, 2020 at 08:02:34PM -0700, mindm...@gmail.com wrote: > > From: Mark Reid > > > > --- > > libswscale/output.c | 82 > > libswscale/slice.c | 28

[FFmpeg-devel] [PATCH 1/2] avcodec/v4l2_context: Drop empty packet while draining

2020-04-29 Thread Andriy Gelman
From: Andriy Gelman v4l2_m2m devices may send an empty packet/frame while draining to indicate that all capture buffers have been flushed. Currently, the empty packet/frame is not handled correctly: When encoding, the empty packet is forwarded to the muxer, usually creating warnings. When decodi

Re: [FFmpeg-devel] [PATCH 3/4] avcodec/svq1dec: Check that there is data left after the hader

2020-04-29 Thread Michael Niedermayer
On Mon, Feb 24, 2020 at 12:39:15AM +0100, Moritz Barsnick wrote: > On Wed, Feb 19, 2020 at 00:59:18 +0100, Michael Niedermayer wrote: > > Subject: [FFmpeg-devel] [PATCH 3/4] avcodec/svq1dec: Check that there is > > data left after the hader > > Nit: hader -> header will apply with that fixed th

Re: [FFmpeg-devel] [PATCH 2/4] avcodec/txd: Check for input size against the header size.

2020-04-29 Thread Michael Niedermayer
On Wed, Feb 19, 2020 at 12:59:17AM +0100, Michael Niedermayer wrote: > Fixes: Timeout (21sec -> 80ms) > Fixes: > 20673/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_TXD_fuzzer-5177453863763968 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/

[FFmpeg-devel] [PATCH 2/2] avcodec/v4l2_context: Finish draining if V4L2_BUF_FLAG_LAST is set

2020-04-29 Thread Andriy Gelman
From: Andriy Gelman V4L2 api can indicate that flushing of the capture buffers is completed by setting the V4L2_BUF_FLAG_LAST flag. Use guards because the flag was only defined in Linux v4.2. Reference: linux/Documentation/media/uapi/v4l/dev-decoder.rst "The client must continue to handle b

Re: [FFmpeg-devel] [PATCH 2/3] libswscale: add output support for AV_PIX_FMT_GBRAPF32

2020-04-29 Thread Mark Reid
On Wed, Apr 29, 2020 at 2:22 PM Michael Niedermayer wrote: > On Wed, Apr 29, 2020 at 11:19:56PM +0200, Michael Niedermayer wrote: > > On Tue, Apr 28, 2020 at 08:02:34PM -0700, mindm...@gmail.com wrote: > > > From: Mark Reid > > > > > > --- > > > libswscale/output.c | 82 +++

[FFmpeg-devel] [PATCH 2/6] avformat/matroskaenc: Unify writing level 1 elements preliminarily

2020-04-29 Thread Andreas Rheinhardt
The Matroska muxer updates several header elements when the output is seekable; if unseekable, the buffer containing the contents of the element is immediately freed after writing. Before this commit, there were three places doing exactly the same: Checking whether the output is seekable and callin

[FFmpeg-devel] [PATCH 1/6] avformat/matroskaenc: Move adding SeekEntry into end_ebml_master_crc32()

2020-04-29 Thread Andreas Rheinhardt
Up until now, SeekEntries were already added before start_ebml_master_crc32() was even called and before we were actually sure that we really write the element the SeekHead references; after all, we might also error out later; and given that the allocations implicit in dynamic buffers should be che

[FFmpeg-devel] [PATCH 4/6] avformat/matroskaenc: Simplify writing buffer

2020-04-29 Thread Andreas Rheinhardt
If one already has the contents of a master elements in a buffer of known size, then writing a EBML master element is no different from writing an EBML binary element. It is overtly complicated to use start/end_ebml_master() as these functions first write an unkown-length size field of the appropri

[FFmpeg-devel] [PATCH 5/6] avformat/matroskaenc: Check allocations implicit in dynamic buffers

2020-04-29 Thread Andreas Rheinhardt
Failures of the allocations that happen under the hood when using dynamic buffers are usually completely unchecked and the Matroska muxer is no exception to this. The API has its part in this, because there is no documented way to actually check for errors: The return value of both avio_get_dyn_bu

[FFmpeg-devel] [PATCH 3/6] avformat/matroskaenc: Avoid dynamic buffer when writing Colour

2020-04-29 Thread Andreas Rheinhardt
There is a good upper bound for the maximum length of the Colour master element; it is therefore unnecessary to use a dynamic buffer for it. A simple buffer on the stack is enough. This commit implements this. Signed-off-by: Andreas Rheinhardt --- libavformat/matroskaenc.c | 26 -

[FFmpeg-devel] [PATCH 6/6] avformat/matroskaenc: Cosmetics

2020-04-29 Thread Andreas Rheinhardt
Mainly reindentation. Signed-off-by: Andreas Rheinhardt --- libavformat/matroskaenc.c | 42 +++ 1 file changed, 21 insertions(+), 21 deletions(-) diff --git a/libavformat/matroskaenc.c b/libavformat/matroskaenc.c index 12c22184a3..d5c69d8d77 100644 --- a/liba

Re: [FFmpeg-devel] [PATCH 2/5] avformat/matroskaenc: fix invalid pointer access if avio_get_dyn_buf failed

2020-04-29 Thread Andreas Rheinhardt
lance.lmw...@gmail.com: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavformat/matroskaenc.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/libavformat/matroskaenc.c b/libavformat/matroskaenc.c > index 784973a951..f0474da44f 100644 > --- a/libavformat/matroskaenc.c >

Re: [FFmpeg-devel] [PATCH 2/5] avformat/matroskaenc: fix invalid pointer access if avio_get_dyn_buf failed

2020-04-29 Thread Nicolas George
Andreas Rheinhardt (12020-04-30): > I sent a patch containing proper checks for this and other allocations > in this muxer here [1]. Thanks. > PS: avio_close_dyn_buf() is even worse: Besides the design flaw of > freeing a resource without setting the pointer to it to NULL, it returns > a size of

Re: [FFmpeg-devel] [PATCH 1/6] avformat/matroskaenc: Move adding SeekEntry into end_ebml_master_crc32()

2020-04-29 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Up until now, SeekEntries were already added before > start_ebml_master_crc32() was even called and before we were actually > sure that we really write the element the SeekHead references; after > all, we might also error out later; and given that the allocations > implicit in

Re: [FFmpeg-devel] [PATCH 0/3] Patch set to delay output live stream

2020-04-29 Thread Tao Zhang
Marton Balint 于2020年4月30日周四 上午4:55写道: > > > > On Thu, 30 Apr 2020, Tao Zhang wrote: > > > Marton Balint 于2020年4月30日周四 上午12:03写道: > >> > >> > >> > >> On Wed, 29 Apr 2020, leozhang wrote: > >> > >> > In some applications, it is required to add delay to live streaming. > >> > >> In what applications

[FFmpeg-devel] [PATCH 1/3 v2] avcodec/cbs_h265: rename H265RawPSExtensionData to H265RawExtensionData

2020-04-29 Thread James Almer
So that NAL types other than Parameter Set ones may use it. Signed-off-by: James Almer --- No difference compared to v1. libavcodec/cbs_h265.h | 10 +- libavcodec/cbs_h265_syntax_template.c | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/libavcode

[FFmpeg-devel] [PATCH 2/3 v3] avcodec/cbs_h265: move the payload_extension_present check into its own function

2020-04-29 Thread James Almer
Will be reused in the following patch. Signed-off-by: James Almer --- Moved the comment for the function to its new place, but otherwise, no difference compared to v2. libavcodec/cbs_h2645.c| 10 ++ libavcodec/cbs_h265_syntax_template.c | 9 +++-- 2 files changed, 1

[FFmpeg-devel] [PATCH 3/3 v3] avcodec/cbs_h265: add missing support for reserved_payload_extension_data SEI bits

2020-04-29 Thread James Almer
Fixes ticket #8622 Signed-off-by: James Almer --- In writing scenarios, it will now ensure bit_equal_to_one is also always written when currently defined extension data (like in Buffering Period) is present, and not just when unknown extension data is. libavcodec/cbs_h2645.c| 1

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/cbs_h265: fix writing extension_data bits

2020-04-29 Thread James Almer
On 4/20/2020 6:45 PM, James Almer wrote: > We only care about the right most bit. > > Signed-off-by: James Almer > --- > Fixes handling files like > https://trac.ffmpeg.org/attachment/ticket/7965/puppets_with_alpha_hevc.mov > Without this patch, parsing works but passing the VPS through > hevc_m

Re: [FFmpeg-devel] [PATCH 1/5] avformat/dashenc: fix invalid pointer access if avio_get_dyn_buf failed

2020-04-29 Thread lance . lmwang
On Wed, Apr 29, 2020 at 06:55:33PM +0200, Nicolas George wrote: > lance.lmw...@gmail.com (12020-04-29): > > Thanks, I catch your point now. Most of existing code haven't return ERROR, > > so I > > choose the same way to process it. If you think it's not OK, we'll change > > more > > code I think.

[FFmpeg-devel] [PATCH] MAINTAINERS: Add myself to libopenh264enc

2020-04-29 Thread Linjie Fu
Reviewed-by: Martin Storsjö Signed-off-by: Linjie Fu --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 06956f8..96654f1 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -194,6 +194,7 @@ Codecs: libdavs2.cHuiwen Ren

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: add support for microseconds since epoch based sequence number

2020-04-29 Thread Steven Liu
> 2020年4月30日 上午12:29,Marton Balint 写道: > > > > On Sat, 18 Apr 2020, Marton Balint wrote: > >> Sequence numbers of segments should be unique, if an encoder is using shorter >> than 1 second segments and it is restarted, then future segments will be >> using >> already used sequence numbers i

Re: [FFmpeg-devel] [EXT] [PATCH 1/2] avcodec/v4l2_context: Drop empty packet while draining

2020-04-29 Thread Ming Qian
> From: Andriy Gelman > > v4l2_m2m devices may send an empty packet/frame while draining to indicate > that all capture buffers have been flushed. > > Currently, the empty packet/frame is not handled correctly: > When encoding, the empty packet is forwarded to the muxer, usually creating > warni

Re: [FFmpeg-devel] [EXT] [PATCH 2/2] avcodec/v4l2_context: Finish draining if V4L2_BUF_FLAG_LAST is set

2020-04-29 Thread Ming Qian
> From: Andriy Gelman > > V4L2 api can indicate that flushing of the capture buffers is completed by > setting the V4L2_BUF_FLAG_LAST flag. > Use guards because the flag was only defined in Linux v4.2. > > Reference: > linux/Documentation/media/uapi/v4l/dev-decoder.rst > > "The client must

Re: [FFmpeg-devel] 回复: [EXT] Re: [PATCH] avcodec/v4l2_buffers: don't prevent enqueue capture buffer to driver

2020-04-29 Thread Andriy Gelman
On Sun, 26. Apr 23:50, Andriy Gelman wrote: > On Thu, 09. Apr 00:27, Andriy Gelman wrote: > > On Thu, 09. Apr 02:14, Ming Qian wrote: > > > Did you try increasing the -num_capture_buffers option? It may solve your > > > problem. > > > 1. We can't increase the num_capture_buffers indefinitely. > >

Re: [FFmpeg-devel] [PATCH] ppc: configure: Support Power ISA 3.0

2020-04-29 Thread Trung Lê
On Thu, Apr 30, 2020 at 3:16 AM Carl Eugen Hoyos wrote: > Shouldn't --disable-power8 also disable power9 (assuming there is a > difference)? > No it should not. From my understanding, the `--enable-power8` flag is used to determine if the version `altivec.h` supports the macro `_ARCH_PWR8` or no

Re: [FFmpeg-devel] [PATCH 1/3] avformat/fifo: add option to delay output

2020-04-29 Thread Tao Zhang
Nicolas George 于2020年4月29日周三 下午9:31写道: > > leozhang (12020-04-29): > > Signed-off-by: leozhang > > --- > > doc/muxers.texi| 3 +++ > > libavformat/fifo.c | 7 +++ > > 2 files changed, 10 insertions(+) > > > > diff --git a/doc/muxers.texi b/doc/muxers.texi > > index cb2bb42..a74cbc4 10064

Re: [FFmpeg-devel] [PATCH v1] avcodec/v4l2_m2m_enc: Set bitrate mode to cbr by default

2020-04-29 Thread Andriy Gelman
On Wed, 29. Apr 16:14, Ming Qian wrote: > Without this setting, bitrate may have no effect > if the default value of bitrate mode is VBR. > > Signed-off-by: Ming Qian > --- > libavcodec/v4l2_m2m_enc.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavcodec/v4l2_m2m_enc.c b/l

Re: [FFmpeg-devel] [PATCH 2/3] closed caption decoder: add new parameter to allow output to avoid repeated lines

2020-04-29 Thread Roger Pack
On Tue, Apr 28, 2020 at 1:46 AM Hendrik Leppkes wrote: > > On Tue, Apr 28, 2020 at 8:19 AM Roger Pack wrote: > > > > I didn't actually *need* this but thought the functionality was very > > nice to have, so here's my contribution. > > > > It allows for forcing "rollup" style closed captions to ou

Re: [FFmpeg-devel] [PATCH 0/3] Patch set to delay output live stream

2020-04-29 Thread Andreas Rheinhardt
Tao Zhang: > Marton Balint 于2020年4月30日周四 上午4:55写道: >> >> >> >> On Thu, 30 Apr 2020, Tao Zhang wrote: >> >>> Marton Balint 于2020年4月30日周四 上午12:03写道: On Wed, 29 Apr 2020, leozhang wrote: > In some applications, it is required to add delay to live streaming. In

Re: [FFmpeg-devel] [EXT] Re: [PATCH v1] avcodec/v4l2_m2m_enc: Set bitrate mode to cbr by default

2020-04-29 Thread Ming Qian
> On Wed, 29. Apr 16:14, Ming Qian wrote: > > Without this setting, bitrate may have no effect > > if the default value of bitrate mode is VBR. > > > > Signed-off-by: Ming Qian > > --- > > libavcodec/v4l2_m2m_enc.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/libavcode

Re: [FFmpeg-devel] [PATCH 0/3] Patch set to delay output live stream

2020-04-29 Thread Tao Zhang
Andreas Rheinhardt 于2020年4月30日周四 下午1:45写道: > > Tao Zhang: > > Marton Balint 于2020年4月30日周四 上午4:55写道: > >> > >> > >> > >> On Thu, 30 Apr 2020, Tao Zhang wrote: > >> > >>> Marton Balint 于2020年4月30日周四 上午12:03写道: > > > > On Wed, 29 Apr 2020, leozhang wrote: > > > In some

Re: [FFmpeg-devel] [PATCH 1/3] closed caption decoder: accept and decode a new codec type of 'raw 608 byte pairs'

2020-04-29 Thread Roger Pack
> > c9153590e5f167e41910d867639eb887164e28d2 > > 0001-closed-caption-decoder-accept-and-decode-a-new-codec.patch > > From bf29fe5330e83e37cf064b18918185c6b00d9b9f Mon Sep 17 00:00:00 2001 > > From: rogerdpack > > Date: Tue, 28 Apr 2020 05:15:15 + > > Subject: [PATCH 1/3] closed caption decod