> From: Martin Storsjö <mar...@martin.st> > Sent: Wednesday, April 29, 2020 16:52 > To: FFmpeg development discussions and patches <ffmpeg- > de...@ffmpeg.org> > Cc: Fu, Linjie <linjie...@intel.com> > Subject: Re: [FFmpeg-devel] [PATCH v6 1/5] lavc/libopenh264enc: Add > qmin/qmax support > > On Wed, 29 Apr 2020, Linjie Fu wrote: > > > Clip iMinQp/iMaxQp to (1, 51) for user specified qp range. > > > > If not set, leave iMinQp/iMaxQp untouched and use the values (0, 51) > > initialized in FillDefault(), and the QP range would be adjusted to the > > defaults inside libopenh264 library according to the iUsageType, (12, 42) > > for iUsageType == CAMERA_VIDEO_REAL_TIME which is default. > > > > > <https://github.com/cisco/openh264/blob/master/codec/encoder/core/src/ > encoder_ext.cpp#L375> > > > > Signed-off-by: Linjie Fu <linjie...@intel.com> > > --- > > libavcodec/libopenh264enc.c | 11 +++++++++++ > > 1 file changed, 11 insertions(+) > > LGTM > Thanks for your review for the whole set, hope it would be merge soon: )
- Linjie _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
