Re: [FFmpeg-devel] [PATCH] Complete rewrite of the "fps" video filter section. More accurate.

2020-04-27 Thread Marton Balint
On Sun, 26 Apr 2020, list+ffmpeg-...@jdlh.com wrote: From: Jim DeLaHunt This is a complete rewrite of the documentation for the "fps" video filter. It describes the filter's behaviour more clearly and accurately. I based the rewrite on reading the source code in vf_fps.c closely. IMHO it i

Re: [FFmpeg-devel] [PATCH v3] libavformat/flacdec: Workaround for truncated metadata picture size

2020-04-27 Thread Mattias Wadman
Hi again, looks ok? On Fri, Apr 24, 2020 at 12:54 PM Mattias Wadman wrote: > > lavf flacenc could previously write truncated metadata picture size if > the picture data did not fit in 24 bits. Detect this by truncting the > size found inside the picture block and if it matches the block size > us

Re: [FFmpeg-devel] [PATCH] Complete rewrite of the "fps" video filter section. More accurate.

2020-04-27 Thread Jim DeLaHunt
On 2020-04-27 01:04, Marton Balint wrote: On Sun, 26 Apr 2020, list+ffmpeg-...@jdlh.com wrote: From: Jim DeLaHunt This is a complete rewrite of the documentation for the "fps" video filter. It describes the filter's behaviour more clearly and accurately. I based the rewrite on reading the s

[FFmpeg-devel] [PATCH] libavformat/url: check url root node when rel include double dot

2020-04-27 Thread Steven Liu
fix ticket: 8625 Signed-off-by: Steven Liu --- libavformat/url.c | 22 -- 1 file changed, 20 insertions(+), 2 deletions(-) diff --git a/libavformat/url.c b/libavformat/url.c index 596fb49cfc..e5003f795a 100644 --- a/libavformat/url.c +++ b/libavformat/url.c @@ -81,6 +81,8 @@

Re: [FFmpeg-devel] [PATCH] libavformat/url: check url root node when rel include double dot

2020-04-27 Thread Martin Storsjö
On Mon, 27 Apr 2020, Steven Liu wrote: fix ticket: 8625 Signed-off-by: Steven Liu --- libavformat/url.c | 22 -- 1 file changed, 20 insertions(+), 2 deletions(-) diff --git a/libavformat/url.c b/libavformat/url.c index 596fb49cfc..e5003f795a 100644 --- a/libavformat/url.c +

Re: [FFmpeg-devel] [PATCH] libavformat/url: check url root node when rel include double dot

2020-04-27 Thread Steven Liu
> 2020年4月27日 下午6:30,Martin Storsjö 写道: > > On Mon, 27 Apr 2020, Steven Liu wrote: > >> fix ticket: 8625 >> >> Signed-off-by: Steven Liu >> --- >> libavformat/url.c | 22 -- >> 1 file changed, 20 insertions(+), 2 deletions(-) >> >> diff --git a/libavformat/url.c b/libavfor

[FFmpeg-devel] [PATCH v2] avformat/url: check url root node when rel include double dot

2020-04-27 Thread Steven Liu
fix ticket: 8625 and add testcase into url for double dot corner case Suggested-by: Martin Storsjö Signed-off-by: Steven Liu --- libavformat/tests/url.c | 3 +++ libavformat/url.c | 21 +++-- 2 files changed, 22 insertions(+), 2 deletions(-) diff --git a/libavformat/test

Re: [FFmpeg-devel] [PATCH v2] avformat/url: check url root node when rel include double dot

2020-04-27 Thread Nicolas George
Steven Liu (12020-04-27): > and add testcase into url for double dot corner case Did you run FATE? Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman

Re: [FFmpeg-devel] [PATCH v2] avformat/url: check url root node when rel include double dot

2020-04-27 Thread Steven Liu
> 2020年4月27日 下午6:54,Nicolas George 写道: > > Steven Liu (12020-04-27): >> and add testcase into url for double dot corner case > > Did you run FATE? Haha, Patchwork returned it, will fix that. > > Regards, > > -- > Nicolas George Thanks Steven Liu ___

Re: [FFmpeg-devel] [PATCH v2] avformat/url: check url root node when rel include double dot

2020-04-27 Thread Nicolas George
Steven Liu (12020-04-27): > Haha, Patchwork returned it, will fix that. Please run FATE yourself before submitting patches. Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org h

Re: [FFmpeg-devel] [PATCH v2] avformat/url: check url root node when rel include double dot

2020-04-27 Thread Nicolas George
Nicolas George (12020-04-27): > Please run FATE yourself before submitting patches. And please heed reply-to headers. It's already annoying enough to have you twice in Cc, it's REALLY annoying to get CCed when I explicitly asked not to in the proper technical way. (Seriously, people, if you want

Re: [FFmpeg-devel] [PATCH v2] avformat/url: check url root node when rel include double dot

2020-04-27 Thread lance . lmwang
On Mon, Apr 27, 2020 at 06:51:47PM +0800, Steven Liu wrote: > fix ticket: 8625 > and add testcase into url for double dot corner case I think you need update ./tests/ref/fate/url also. make fate-url SAMPLES=../fate-suite > > Suggested-by: Martin Storsjö > Signed-off-by: Steven Liu > --- > l

Re: [FFmpeg-devel] [PATCH v2] avformat/url: check url root node when rel include double dot

2020-04-27 Thread Steven Liu
> 2020年4月27日 下午7:04,lance.lmw...@gmail.com 写道: > > On Mon, Apr 27, 2020 at 06:51:47PM +0800, Steven Liu wrote: >> fix ticket: 8625 >> and add testcase into url for double dot corner case > > I think you need update ./tests/ref/fate/url also. > > make fate-url SAMPLES=../fate-suite Yes, the fat

Re: [FFmpeg-devel] [PATCH v2] avformat/url: check url root node when rel include double dot

2020-04-27 Thread Steven Liu
> 2020年4月27日 下午7:05,Nicolas George 写道: > > Nicolas George (12020-04-27): >> Please run FATE yourself before submitting patches. > > And please heed reply-to headers. It's already annoying enough to have > you twice in Cc, it's REALLY annoying to get CCed when I explicitly > asked not to in the

Re: [FFmpeg-devel] [PATCH v2] avformat/url: check url root node when rel include double dot

2020-04-27 Thread Nicolas George
Steven Liu (12020-04-27): > Do you mean you don’t want in the cc list? > I think can remove you from cc list if you don’t want in it. I want you to do exactly as the headers direct you to do. Regards, -- Nicolas George signature.asc Description: PGP signature ___

[FFmpeg-devel] [PATCH v3] avformat/url: check url root node when rel include double dot

2020-04-27 Thread Steven Liu
fix ticket: 8625 and add testcase into url for double dot corner case Signed-off-by: Steven Liu --- libavformat/tests/url.c | 3 +++ libavformat/url.c | 21 +++-- tests/ref/fate/url | 3 +++ 3 files changed, 25 insertions(+), 2 deletions(-) diff --git a/libavformat/

Re: [FFmpeg-devel] [PATCH v2] avformat/url: check url root node when rel include double dot

2020-04-27 Thread Steven Liu
> 2020年4月27日 下午7:10,Nicolas George 写道: > > Steven Liu (12020-04-27): >> Do you mean you don’t want in the cc list? >> I think can remove you from cc list if you don’t want in it. > > I want you to do exactly as the headers direct you to do. Inner peace. Thanks Steven Liu ___

Re: [FFmpeg-devel] [PATCH v3] avformat/url: check url root node when rel include double dot

2020-04-27 Thread Nicolas George
Steven Liu (12020-04-27): > fix ticket: 8625 > and add testcase into url for double dot corner case > > Signed-off-by: Steven Liu > --- > libavformat/tests/url.c | 3 +++ > libavformat/url.c | 21 +++-- > tests/ref/fate/url | 3 +++ > 3 files changed, 25 insertions(+

Re: [FFmpeg-devel] [PATCH v3] avformat/url: check url root node when rel include double dot

2020-04-27 Thread Steven Liu
> 2020年4月27日 下午7:14,Nicolas George 写道: > > Steven Liu (12020-04-27): >> fix ticket: 8625 >> and add testcase into url for double dot corner case >> >> Signed-off-by: Steven Liu >> --- >> libavformat/tests/url.c | 3 +++ >> libavformat/url.c | 21 +++-- >> tests/ref/fate/u

Re: [FFmpeg-devel] [PATCH v3] avformat/url: check url root node when rel include double dot

2020-04-27 Thread Nicolas George
Steven Liu (12020-04-27): > /../../../../../other/url, this is the absolute path, so just concat and > don’t process, > Or what do you want to say? This is not an absolute path, since it contains "..". I think it is a problem that the output of ff_make_absolute_url() is not, you know, absolute.

Re: [FFmpeg-devel] [PATCH v3] avformat/url: check url root node when rel include double dot

2020-04-27 Thread Steven Liu
> 2020年4月27日 下午7:22,Nicolas George 写道: > > Steven Liu (12020-04-27): >> /../../../../../other/url, this is the absolute path, so just concat and >> don’t process, >> Or what do you want to say? > > This is not an absolute path, since it contains "..". I think it is a > problem that the outpu

Re: [FFmpeg-devel] [PATCH v3] avformat/url: check url root node when rel include double dot

2020-04-27 Thread Steven Liu
> 2020年4月27日 下午7:35,Nicolas George 写道: > > Steven Liu (12020-04-27): >> I need one example to understand about the security issue after this patch. > > Use ff_make_absolute_url() on a trusted base and an un-trusted path; > check the result starts with the allowed prefix. Let an attacker escape

Re: [FFmpeg-devel] [PATCH v3] avformat/url: check url root node when rel include double dot

2020-04-27 Thread Nicolas George
Steven Liu (12020-04-27): > I need one example to understand about the security issue after this patch. Use ff_make_absolute_url() on a trusted base and an un-trusted path; check the result starts with the allowed prefix. Let an attacker escape because the result contains ../. Regards, -- Nic

Re: [FFmpeg-devel] [PATCH v3] avformat/url: check url root node when rel include double dot

2020-04-27 Thread Nicolas George
Steven Liu (12020-04-27): > Command line? There is none. -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link a

Re: [FFmpeg-devel] [PATCH] libavutil: add clean aperture (CLAP) side data.

2020-04-27 Thread Lynne
Apr 27, 2020, 05:27 by neil.birkb...@gmail.com: > The clean aperature represents a cropping of the stored image data used to > relate the image data to a canonical video system and exists as container > metadata (see 'clap' section in > https://developer.apple.com/library/archive/documentation/Qu

[FFmpeg-devel] [PATCH] avformat/oggdec: Add page CRC verification

2020-04-27 Thread Mattias Wadman
Fixes seek issue with ogg files that have segment data that happens to be encoded as a "OggS" page syncword. Very unlikely but seems to happen. Have been observed to happen with ffmpeg+libvorbis and oggenc encoding to 441khz stereo at 160kbps. --- libavformat/oggdec.c | 96 +++

Re: [FFmpeg-devel] [PATCH, v2 1/2] lavc/qsvdec: add decode support for HEVC 4:2:2 8-bit and 10-bit

2020-04-27 Thread Artem Galin
On Wed, 15 Apr 2020 at 05:02, Fu, Linjie wrote: > > From: Zhong Li > > Sent: Wednesday, April 15, 2020 09:58 > > To: FFmpeg development discussions and patches > de...@ffmpeg.org> > > Cc: Fu, Linjie > > Subject: Re: [FFmpeg-devel] [PATCH, v2 1/2] lavc/qsvdec: add decode > > support for HEVC 4:

[FFmpeg-devel] [PATCH] avfilter: add asubboost filter

2020-04-27 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- doc/filters.texi | 31 ++ libavfilter/Makefile | 1 + libavfilter/af_asubboost.c | 210 + libavfilter/allfilters.c | 1 + 4 files changed, 243 insertions(+) create mode 100644 libavfilter/af_asubboost.

Re: [FFmpeg-devel] [PATCH] swscale/vscale: Increase type strictness

2020-04-27 Thread Michael Niedermayer
On Sun, Apr 26, 2020 at 09:49:57AM +0200, Andreas Rheinhardt wrote: > libswscale/vscale.c makes extensive use of function pointers and in > doing so it converts these function pointers to and from a pointer to > void. Yet this is actually against the C standard: > C90 only guarantees that one can c

Re: [FFmpeg-devel] [PATCH v10 2/2] avformat: add demuxer for Pro Pinball Series' Soundbanks

2020-04-27 Thread Michael Niedermayer
On Sun, Apr 26, 2020 at 11:49:00PM +, Zane van Iperen wrote: > On Sun, 26 Apr 2020 00:07:52 +0200 > "Michael Niedermayer" wrote: > > > > > also iam not sure it makes sense or if it goes to far but the probe > > code could check all tracks which are within the buffer > > all these low 10 scor

Re: [FFmpeg-devel] [PATCH v4 1/9] lavc/libopenh264enc: Add default qmin/qmax support

2020-04-27 Thread Martin Storsjö
On Wed, 15 Apr 2020, Linjie Fu wrote: Set default QP range to (1, 51) instead of (2, 32). QP = 0 is not well supported currently in libopenh264. If iMaxQp/iMinQp equals 0, the QP range would be changed unexpectedly inside libopenh264 with a warning: Warning:Change QP Range from(0,51) to (12,42

Re: [FFmpeg-devel] [PATCH v4 2/9] lavc/libopenh264enc: add default gop size and bit rate

2020-04-27 Thread Martin Storsjö
On Wed, 15 Apr 2020, Linjie Fu wrote: It would be 200kbps bitrate with gop size = 12 by default which generated too many IDR frames in rather low bit rate. The quality would be poor. Set these default values according to vaapi encoder, and use 2Mbps bitrate if user doesn't set it explicitly as

Re: [FFmpeg-devel] [PATCH v4 3/9] lavc/libopenh264enc: add bit rate control select support

2020-04-27 Thread Martin Storsjö
On Wed, 15 Apr 2020, Linjie Fu wrote: RC_BITRATE_MODE: set BITS_EXCEEDED to iCurrentBitsLevel and allows QP adjust in RcCalculatePictureQp(). RC_BUFFERBASED_MODE: use buffer status to adjust the video quality. RC_TIMESTAMP_MODE: bit rate control based on timestamp. Default to use

Re: [FFmpeg-devel] [PATCH v4 4/9] lavc/libopenh264enc: prompt slice number changing inside libopenh264

2020-04-27 Thread Martin Storsjö
On Wed, 15 Apr 2020, Linjie Fu wrote: Libopenh264enc would set the slice according to the number of cpu cores if uiSliceNum equals to 0 (auto) in SM_FIXEDSLCNUM_SLICE mode. Prompt a warning for user to catch this. Signed-off-by: Linjie Fu --- libavcodec/libopenh264enc.c | 2 ++ 1 file changed,

Re: [FFmpeg-devel] [PATCH v4 5/9] lavc/libopenh264enc: set slice_mode option to deprecated

2020-04-27 Thread Martin Storsjö
On Wed, 15 Apr 2020, Linjie Fu wrote: "slice mode" option seems to be unnecessary since it could be determined by -slices/max_nal_size. default:SM_FIXEDSLCNUM_SLICE mode with cpu-number slices. -slices N: SM_FIXEDSLCNUM_SLICE mode with N slices. -max_nal_size: SM_SIZELIMITED_SLICE

Re: [FFmpeg-devel] [PATCH v4 6/9] lavc/libopenh264enc: separate svc_encode_init() into several functions

2020-04-27 Thread Martin Storsjö
On Wed, 15 Apr 2020, Linjie Fu wrote: Separate the initialization procedure into different functions. Make it more readable and easier to be extended. Signed-off-by: Linjie Fu --- libavcodec/libopenh264enc.c | 283 +++- 1 file changed, 174 insertions(+),

Re: [FFmpeg-devel] [PATCH v4 7/9] lavc/libopenh264enc: add profile high option support

2020-04-27 Thread Martin Storsjö
On Wed, 15 Apr 2020, Linjie Fu wrote: Add support for PRO_HIGH/PRO_BASELINE in SVC Encoding extention mode, which determined by iEntropyCodingModeFlag in ParamTranscode(). Signed-off-by: Linjie Fu --- liba

Re: [FFmpeg-devel] [PATCH v3 5/6] avcodec/pcm_rechunk_bsf: add bitstream filter to rechunk pcm audio

2020-04-27 Thread Marton Balint
On Sun, 26 Apr 2020, Andreas Rheinhardt wrote: Marton Balint: Signed-off-by: Marton Balint --- Changelog | 1 + doc/bitstream_filters.texi | 30 ++ libavcodec/Makefile| 1 + libavcodec/bitstream_filters.c | 1 + libavcodec/pcm_rechunk_bsf.c |

Re: [FFmpeg-devel] [PATCH v4 8/9] lavc/libopenh264enc: allow specifying the profile through AVCodecContext

2020-04-27 Thread Martin Storsjö
On Wed, 15 Apr 2020, Linjie Fu wrote: Signed-off-by: Linjie Fu --- libavcodec/libopenh264enc.c | 16 1 file changed, 16 insertions(+) diff --git a/libavcodec/libopenh264enc.c b/libavcodec/libopenh264enc.c index 0fe8cf4..4d337d2 100644 --- a/libavcodec/libopenh264enc.c +++ b/lib

Re: [FFmpeg-devel] [PATCH v4 9/9] lavc/libopenh264enc: Add coder option to replace cabac

2020-04-27 Thread Martin Storsjö
On Wed, 15 Apr 2020, Linjie Fu wrote: Set DEPRECATED flag to option cabac, replace with coder. Change the default option to -1 and allow the default cabac to be determined by profile. Add FF_API_OPENH264_CABAC macro for cabac to remove this option after LIBAVCODEC_VERSION_MAJOR = 59. Signed-o

Re: [FFmpeg-devel] [PATCH 5/8] lavc/nvenc: Add hardware config metadata

2020-04-27 Thread Timo Rothenpieler
On 13.04.2020 17:33, Mark Thompson wrote: NOT TESTED. Fails to build: In file included from libavcodec/nvenc_hevc.c:24: libavcodec/nvenc.h:220:14: error: unknown type name ‘AVCodecHWConfigInternal’ 220 | extern const AVCodecHWConfigInternal *ff_nvenc_hw_configs[]; | ^~~~

Re: [FFmpeg-devel] [EXT] [PATCH 2/2] avcodec/v4l2_context: Log warning when all capture buffers are in userspace

2020-04-27 Thread Andriy Gelman
Hi Ming, Thanks for looking over the patch. On Thu, 09. Apr 07:13, Ming Qian wrote: > Lgtm, > > But if don't prevent enqueue frame buffer of capture port, unlikely to happen > this case. The problem happens when all the capture packets/frames are buffered internally by ffmpeg (i.e. the buffer

Re: [FFmpeg-devel] [PATCH] avformat/oggdec: Add page CRC verification

2020-04-27 Thread Michael Niedermayer
On Mon, Apr 27, 2020 at 05:19:49PM +0200, Mattias Wadman wrote: > Fixes seek issue with ogg files that have segment data that happens to be > encoded as a "OggS" page syncword. Very unlikely but seems to happen. > > Have been observed to happen with ffmpeg+libvorbis and oggenc encoding > to 441khz

Re: [FFmpeg-devel] [PATCH 5/8] lavc/nvenc: Add hardware config metadata

2020-04-27 Thread Timo Rothenpieler
fixed version applied ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v2 6/6] avformat/audiointerleave: only keep the retime functionality of the audio interleaver

2020-04-27 Thread Marton Balint
On Sun, 26 Apr 2020, Andreas Rheinhardt wrote: Marton Balint: And rename it to retimeinterleave, use the pcm_rechunk bitstream filter for rechunking. By seperating the two functions we hopefully get cleaner code. Signed-off-by: Marton Balint --- configure

Re: [FFmpeg-devel] [EXT] Re: [PATCH v4 1/3] avcodec/v4l2_m2m_enc: Reduce log verbosity for some params

2020-04-27 Thread Andriy Gelman
On Thu, 09. Apr 07:17, Ming Qian wrote: > lgtm Thanks, will apply this later this evening if no one objects. -- Andriy > > > > Best regards, > Ming Qian > Tel#:86-512-6805-6630 > > > -Original Message- > From: ffmpeg-devel On Behalf Of Andriy > Gelman > Sent: Saturday, March 14, 2

Re: [FFmpeg-devel] [PATCH] swscale/vscale: Increase type strictness

2020-04-27 Thread Andreas Rheinhardt
Michael Niedermayer: > On Sun, Apr 26, 2020 at 09:49:57AM +0200, Andreas Rheinhardt wrote: >> libswscale/vscale.c makes extensive use of function pointers and in >> doing so it converts these function pointers to and from a pointer to >> void. Yet this is actually against the C standard: >> C90 onl

Re: [FFmpeg-devel] [PATCH v4 2/3] avcodec/v4l2_m2m_enc: Enable frame level rate control by default

2020-04-27 Thread Andriy Gelman
On Sun, 23. Feb 13:47, Andriy Gelman wrote: > From: Andriy Gelman > > Without this setting, bitrate and qmin/qmax options have no > affect on the s5p-mfc hardware encoder. > > Signed-off-by: Andriy Gelman > --- > libavcodec/v4l2_m2m_enc.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git

Re: [FFmpeg-devel] [PATCH v3 5/6] avcodec/pcm_rechunk_bsf: add bitstream filter to rechunk pcm audio

2020-04-27 Thread Marton Balint
On Mon, 27 Apr 2020, Marton Balint wrote: On Sun, 26 Apr 2020, Andreas Rheinhardt wrote: [...] And this filter does more than just repacketizing the samples: It also discards the timing of its input and makes up completely new timestamps and durations. This needs to be documented. Ok,

Re: [FFmpeg-devel] [PATCH v3 5/6] avcodec/pcm_rechunk_bsf: add bitstream filter to rechunk pcm audio

2020-04-27 Thread Andreas Rheinhardt
Marton Balint: > > > On Mon, 27 Apr 2020, Marton Balint wrote: > >> >> On Sun, 26 Apr 2020, Andreas Rheinhardt wrote: >> > > [...] > >>> >>> And this filter does more than just repacketizing the samples: It also >>> discards the timing of its input and makes up completely new timestamps >>> an

[FFmpeg-devel] [PATCH 1/2] avformat/vividas: simplify, use av_rescale_q() instead

2020-04-27 Thread lance . lmwang
From: Limin Wang note it'll cause a small difference in accuracy for the pts, please see the testing result below: $ wget http://samples.ffmpeg.org/archive/all/unknown+unknown+unknown+unknown+5029_paramount_en_1250.viv $ ./ffmpeg -t 0.04 -i ./unknown+unknown+unknown+unknown+5029_paramount_en

[FFmpeg-devel] [PATCH 2/2] avformat/wavenc: simplify, use av_rescale_q() instead

2020-04-27 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavformat/wavenc.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/libavformat/wavenc.c b/libavformat/wavenc.c index f6f5710802..1027f107ee 100644 --- a/libavformat/wavenc.c +++ b/libavformat/wavenc.c @@ -434,10 +434,9

Re: [FFmpeg-devel] [PATCH v4 1/9] lavc/libopenh264enc: Add default qmin/qmax support

2020-04-27 Thread Fu, Linjie
> From: Martin Storsjö > Sent: Tuesday, April 28, 2020 03:27 > > If qmax/qmin < 0, i.e. wasn't specified by the user, wouldn't it be better > to not touch param.iMax/MinQp at all (and use the default value of the > library, which may change between versions), instead of overriding it with > a val

Re: [FFmpeg-devel] [PATCH v4 1/9] lavc/libopenh264enc: Add default qmin/qmax support

2020-04-27 Thread Martin Storsjö
On Tue, 28 Apr 2020, Fu, Linjie wrote: From: Martin Storsjö Sent: Tuesday, April 28, 2020 03:27 If qmax/qmin < 0, i.e. wasn't specified by the user, wouldn't it be better to not touch param.iMax/MinQp at all (and use the default value of the library, which may change between versions), instead

[FFmpeg-devel] [PATCH 2/3] closed caption decoder: add new parameter to allow output to avoid repeated lines

2020-04-27 Thread Roger Pack
I didn't actually *need* this but thought the functionality was very nice to have, so here's my contribution. It allows for forcing "rollup" style closed captions to output one line at a time (basically, when there is a carriage return, it outputs a line), so there is never any duplication in the

[FFmpeg-devel] [PATCH 1/3] closed caption decoder: accept and decode a new codec type of 'raw 608 byte pairs'

2020-04-27 Thread Roger Pack
I needed this in order to be able to parse raw analog TV closed caption byte pairs (analog line 21 CC's). 0001-closed-caption-decoder-accept-and-decode-a-new-codec.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http

Re: [FFmpeg-devel] [PATCH v4 2/9] lavc/libopenh264enc: add default gop size and bit rate

2020-04-27 Thread Fu, Linjie
> From: Martin Storsjö > Sent: Tuesday, April 28, 2020 03:28 > > static const AVCodecDefault svc_enc_defaults[] = { > > +{ "b", "0" }, > > +{ "g", "120" }, > > { "qmin", "-1"}, > > Why do you hardcode a value for g here, but put the default bitrate value

Re: [FFmpeg-devel] [PATCH v4 1/9] lavc/libopenh264enc: Add default qmin/qmax support

2020-04-27 Thread Fu, Linjie
> From: Martin Storsjö > Sent: Tuesday, April 28, 2020 14:19 > To: Fu, Linjie > Cc: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: RE: [FFmpeg-devel] [PATCH v4 1/9] lavc/libopenh264enc: Add > default qmin/qmax support > > On Tue, 28 Apr 2020, Fu, Linjie wrote: > > >> F

Re: [FFmpeg-devel] [PATCH v4 2/9] lavc/libopenh264enc: add default gop size and bit rate

2020-04-27 Thread Martin Storsjö
On Tue, 28 Apr 2020, Fu, Linjie wrote: From: Martin Storsjö Sent: Tuesday, April 28, 2020 03:28 static const AVCodecDefault svc_enc_defaults[] = { +{ "b", "0" }, +{ "g", "120" }, { "qmin", "-1"}, Why do you hardcode a value for g here, but put the d

Re: [FFmpeg-devel] [PATCH v4 1/9] lavc/libopenh264enc: Add default qmin/qmax support

2020-04-27 Thread Martin Storsjö
On Tue, 28 Apr 2020, Fu, Linjie wrote: From: Martin Storsjö Sent: Tuesday, April 28, 2020 14:19 To: Fu, Linjie Cc: FFmpeg development discussions and patches Subject: RE: [FFmpeg-devel] [PATCH v4 1/9] lavc/libopenh264enc: Add default qmin/qmax support On Tue, 28 Apr 2020, Fu, Linjie wrote:

Re: [FFmpeg-devel] How to satisfy two codecs with one decoder?

2020-04-27 Thread Roger Pack
On Fri, Apr 17, 2020 at 4:53 PM James Almer wrote: > > On 4/17/2020 7:40 PM, Roger Pack wrote: > > I want to add to the closed caption libavcodec/ccaption_dec.c decoder > > to be able to handle both 608 "over CEA 708" (which it already does) > > and also "raw EIA 608 byte pairs" which it doesn't.

[FFmpeg-devel] [PATCH 3/3] directshow: add ability to read closed caption raw byte pairs from VBI pin

2020-04-27 Thread Roger Pack
Here's the final piece (to actually use the new codec), where we allow to read raw CC 608 byte pairs from analog directshow TV capture devices ("read" in a loose sense of the term, it requires an intermediate dshow filter to extract the CC raw bytes from the VBI incoming stream, but anyway it works

Re: [FFmpeg-devel] [PATCH v4 1/9] lavc/libopenh264enc: Add default qmin/qmax support

2020-04-27 Thread Fu, Linjie
> From: ffmpeg-devel On Behalf Of > Martin Storsjö > Sent: Tuesday, April 28, 2020 14:31 > To: Fu, Linjie > Cc: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH v4 1/9] lavc/libopenh264enc: Add > default qmin/qmax support > > On Tue, 28 Apr 2020,