On Wed, 15 Apr 2020 at 05:02, Fu, Linjie <linjie...@intel.com> wrote:
> > From: Zhong Li <lizhong1...@gmail.com> > > Sent: Wednesday, April 15, 2020 09:58 > > To: FFmpeg development discussions and patches <ffmpeg- > > de...@ffmpeg.org> > > Cc: Fu, Linjie <linjie...@intel.com> > > Subject: Re: [FFmpeg-devel] [PATCH, v2 1/2] lavc/qsvdec: add decode > > support for HEVC 4:2:2 8-bit and 10-bit > > > > Linjie Fu <linjie...@intel.com> 于2020年2月26日周三 下午4:43写道： > > > > > > Enables HEVC Range Extension decoding support (Linux) for 4:2:2 8/10 > bit > > > on ICL+ (gen11 +) platform. > > > > > > Signed-off-by: Linjie Fu <linjie...@intel.com> > > > --- > > > [v2]: restrict to support on Linux. > > > > > > libavcodec/qsv.c | 16 ++++++++++++++++ > > > libavutil/hwcontext_qsv.c | 24 ++++++++++++++++++++++++ > > > 2 files changed, 40 insertions(+) > > > > > > diff --git a/libavcodec/qsv.c b/libavcodec/qsv.c > > > index db98c75..171a8d6 100644 > > > --- a/libavcodec/qsv.c > > > +++ b/libavcodec/qsv.c > > > @@ -195,6 +195,12 @@ enum AVPixelFormat ff_qsv_map_fourcc(uint32_t > > fourcc) > > > case MFX_FOURCC_NV12: return AV_PIX_FMT_NV12; > > > case MFX_FOURCC_P010: return AV_PIX_FMT_P010; > > > case MFX_FOURCC_P8: return AV_PIX_FMT_PAL8; > > > +#if CONFIG_VAAPI > LGTM. CONFIG_VAAPI is not needed here because crash does not related to these changes. Full support MFX_FOURCC_YUY2 is WIP for Windows. > > > + case MFX_FOURCC_YUY2: return AV_PIX_FMT_YUYV422; > > > > There is no VAAPI structures here, so should not use CONFIG_VAAPI to > > disable them. > > > > This is pointed out in [1] that D3D code doesn't support YUYV format, and > indeed > It leads to unexpected crash in windows.(instead of working or reporting > unsupported > On ICL- platform) > > Hence this patch restricted to add support on linux only. > > And I admit the best solution should be get this fully supported on both > linux and windows. > (I believe Max and Artem is helping on windows side) > > Thanks for the review, > Linjie > > [1] > https://patchwork.ffmpeg.org/project/ffmpeg/patch/1582596080-1035-1-git-send-email-linjie...@intel.com/ > > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
