On Wed, 15 Apr 2020, Linjie Fu wrote:

Separate the initialization procedure into different functions.

Make it more readable and easier to be extended.

Signed-off-by: Linjie Fu <linjie...@intel.com>
---
libavcodec/libopenh264enc.c | 283 +++++++++++++++++++++++++++-----------------
1 file changed, 174 insertions(+), 109 deletions(-)

I honestly don't see the point here. Yes, the init function is long, but you're moving code around and making it even 65 lines longer in total...

In which way is this easier to extend than the previous form?

// Martin

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Reply via email to