[FFmpeg-devel] [PATCH 0/2] Ubisoft Rayman 2 APM demuxer + decoder.

2020-02-17 Thread Zane van Iperen
Hi all, This patchset adds support for the APM files used by Rayman 2. It has been tested against all *.apm files in the game folder. Zane Zane van Iperen (2): avcodec: add decoder for Rayman 2's ADPCM variant avformat: add demuxer for Rayman 2's APM format libavcodec/Makefile | 1

[FFmpeg-devel] [PATCH 2/2] avformat: add demuxer for Rayman 2's APM format

2020-02-17 Thread Zane van Iperen
Adds support for the APM file format used by Ubisoft's Rayman 2. Signed-off-by: Zane van Iperen --- libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/apm.c| 171 +++ libavformat/version.h| 2 +- 4 files changed, 174

[FFmpeg-devel] [PATCH 1/2] avcodec: add decoder for Rayman 2's ADPCM variant

2020-02-17 Thread Zane van Iperen
Adds support for the ADPCM variant used in Rayman 2's files. Signed-off-by: Zane van Iperen --- libavcodec/Makefile | 1 + libavcodec/adpcm.c | 24 libavcodec/allcodecs.c | 1 + libavcodec/avcodec.h| 1 + libavcodec/codec_desc.c | 7 +++ libavcodec/

Re: [FFmpeg-devel] [PATCH 1/2] avcodec: add decoder for Rayman 2's ADPCM variant

2020-02-17 Thread Paul B Mahol
On 2/17/20, Zane van Iperen wrote: > Adds support for the ADPCM variant used in Rayman 2's files. > > Signed-off-by: Zane van Iperen > --- > libavcodec/Makefile | 1 + > libavcodec/adpcm.c | 24 > libavcodec/allcodecs.c | 1 + > libavcodec/avcodec.h| 1 +

Re: [FFmpeg-devel] [PATCH 2/2] avformat: add demuxer for Rayman 2's APM format

2020-02-17 Thread Paul B Mahol
On 2/17/20, Zane van Iperen wrote: > Adds support for the APM file format used by Ubisoft's Rayman 2. > > Signed-off-by: Zane van Iperen > --- > libavformat/Makefile | 1 + > libavformat/allformats.c | 1 + > libavformat/apm.c| 171 +++ > libav

Re: [FFmpeg-devel] [PATCH 2/2] avformat: add demuxer for Rayman 2's APM format

2020-02-17 Thread Zane van Iperen
On 17/2/20 7:26 pm, Paul B Mahol wrote: > > On 2/17/20, Zane van Iperen wrote: >> Adds support for the APM file format used by Ubisoft's Rayman 2. >> >> Signed-off-by: Zane van Iperen >> --- >> libavformat/Makefile | 1 + >> libavformat/allformats.c | 1 + >> libavformat/apm.c

[FFmpeg-devel] Fragmented MP4 cenc support

2020-02-17 Thread Valentin Schweitzer
Hi, I'm starting to work on a patch to add encryption support for fragmented MP4 following the cenc scheme to FFmpeg. I'm writing to ask if anyone had already started or planned such a patch, to avoid duplicate work or to step on anyone's toes. The goal would be to extend the current support for

[FFmpeg-devel] [PATCH 1/2] lavd/opengl_enc: use proper context for logging.

2020-02-17 Thread Nicolas George
Log as [opengl @ 0xaddress] instead of [opengl outdev @ 0xaddress]. Signed-off-by: Nicolas George --- libavdevice/opengl_enc.c | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/libavdevice/opengl_enc.c b/libavdevice/opengl_enc.c index fd0bb177d9..fa94345a7c

[FFmpeg-devel] [PATCH 2/2] lavd/opengl_enc: check strings before parsing them.

2020-02-17 Thread Nicolas George
Fix a segfault if OpenGL was not initialized before calling write_header(). Signed-off-by: Nicolas George --- libavdevice/opengl_enc.c | 4 1 file changed, 4 insertions(+) diff --git a/libavdevice/opengl_enc.c b/libavdevice/opengl_enc.c index fa94345a7c..3d60f7d068 100644 --- a/libavdevice

Re: [FFmpeg-devel] Fragmented MP4 cenc support

2020-02-17 Thread Steven Liu
> 2020年2月17日 下午8:23,Valentin Schweitzer 写道: > > Hi, > > I'm starting to work on a patch to add encryption support for > fragmented MP4 following the cenc scheme to FFmpeg. I'm writing > to ask if anyone had already started or planned such a patch, > to avoid duplicate work or to step on anyone

[FFmpeg-devel] dvbsub.c, change segment order to be in line with spec

2020-02-17 Thread Alen Vrečko
Hello, everyone. I'd like to request a change in order of DVB segments to be in line with ETSI 300 743. Basically Region Composition Segment should come before CLUT segment. This caused problems on legacy STBs namely Amino A110. In the ETSI EN 300 743 V1.6.1 (2018-10) section 4.4 it is written

[FFmpeg-devel] [PATCH] lavf/http: accept both GET and POST in read-write mode.

2020-02-17 Thread Nicolas George
Signed-off-by: Nicolas George --- libavformat/http.c | 19 ++- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/libavformat/http.c b/libavformat/http.c index c9415578aa..135b533203 100644 --- a/libavformat/http.c +++ b/libavformat/http.c @@ -903,11 +903,19 @@ static

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg_filter: add -autoscale to disable/enable the default scale

2020-02-17 Thread Fu, Linjie
> -Original Message- > From: Fu, Linjie > Sent: Sunday, February 16, 2020 00:13 > To: ffmpeg-devel@ffmpeg.org > Cc: Fu, Linjie ; Eoff, Ullysses A > > Subject: [PATCH] fftools/ffmpeg_filter: add -autoscale to disable/enable the > default scale > > Currently, ffmpeg inserts scale filter by

Re: [FFmpeg-devel] [PATCH 5/7] avformat/segafilmenc: Remove redundant checks

2020-02-17 Thread Andreas Rheinhardt
Andreas Rheinhardt: > If an audio stream is present, the Sega FILM muxer checks for its > compability with the container during init, so that the very same check > needn't be repeated during writing the trailer. > > Essentially the same is true for the presence of a video stream: It has > already

Re: [FFmpeg-devel] [PATCH] lavc/qsvenc: add support for external bitrate control for HEVC

2020-02-17 Thread Fu, Linjie
> -Original Message- > From: ffmpeg-devel On Behalf Of Fu, > Linjie > Sent: Saturday, February 15, 2020 16:31 > To: Zhong Li ; FFmpeg development discussions > and patches > Subject: Re: [FFmpeg-devel] [PATCH] lavc/qsvenc: add support for external > bitrate control for HEVC > > > -Or

Re: [FFmpeg-devel] [PATCH 2/9] swscale: Add swscale input support for Y210LE

2020-02-17 Thread Fu, Linjie
> -Original Message- > From: ffmpeg-devel On Behalf Of > Kieran Kunhya > Sent: Monday, January 20, 2020 07:21 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH 2/9] swscale: Add swscale input support > for Y210LE > > > > > > > Am Do.,

Re: [FFmpeg-devel] [PATCH 2/9] swscale: Add swscale input support for Y210LE

2020-02-17 Thread Paul B Mahol
On 1/20/20, Kieran Kunhya wrote: >> >> > > Am Do., 16. Jan. 2020 um 07:49 Uhr schrieb Fu, Linjie < >> linjie...@intel.com>: >> > > > >> > > > > -Original Message- >> > > > > From: ffmpeg-devel On Behalf Of >> > > > > Carl Eugen Hoyos >> > > > > Sent: Thursday, January 16, 2020 02:30 >> >

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg_filter: add -autoscale to disable/enable the default scale

2020-02-17 Thread Nicolas George
Fu, Linjie (12020-02-17): > After several reviews, ping for this patch. I only had concerns with the length of the help, they were addressed. I have no more remarks. Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-de

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg_filter: add -autoscale to disable/enable the default scale

2020-02-17 Thread Gyan Doshi
On 17-02-2020 09:13 pm, Fu, Linjie wrote: -Original Message- From: Fu, Linjie Sent: Sunday, February 16, 2020 00:13 To: ffmpeg-devel@ffmpeg.org Cc: Fu, Linjie ; Eoff, Ullysses A Subject: [PATCH] fftools/ffmpeg_filter: add -autoscale to disable/enable the default scale Currently, ffmp

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg_filter: add -autoscale to disable/enable the default scale

2020-02-17 Thread Fu, Linjie
> -Original Message- > From: ffmpeg-devel On Behalf Of > Gyan Doshi > Sent: Tuesday, February 18, 2020 00:53 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg_filter: add -autoscale > to disable/enable the default scale > > > > On 17-02-2020 09:13 pm, Fu

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg_filter: add -autoscale to disable/enable the default scale

2020-02-17 Thread Gyan Doshi
On 17-02-2020 10:57 pm, Fu, Linjie wrote: -Original Message- From: ffmpeg-devel On Behalf Of Gyan Doshi Sent: Tuesday, February 18, 2020 00:53 To: ffmpeg-devel@ffmpeg.org Subject: Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg_filter: add -autoscale to disable/enable the default scale On

Re: [FFmpeg-devel] [PATCH 2/2] avformat: add demuxer for Rayman 2's APM format

2020-02-17 Thread Carl Eugen Hoyos
Am 17.02.2020 um 10:49 schrieb Zane van Iperen : >> >> Also add probe function. > > > There's no real "magic" fields to look for, hence why I set the `extensions` > field. What would a probe function do in this case? I cannot look at the files right now: Is there nothing that allows to disti

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg_filter: add -autoscale to disable/enable the default scale

2020-02-17 Thread Fu, Linjie
> -Original Message- > From: ffmpeg-devel On Behalf Of > Gyan Doshi > Sent: Tuesday, February 18, 2020 01:33 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg_filter: add -autoscale > to disable/enable the default scale > > > > On 17-02-2020 10:57 pm, Fu

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg_filter: add -autoscale to disable/enable the default scale

2020-02-17 Thread Gyan Doshi
On 17-02-2020 11:07 pm, Fu, Linjie wrote: -Original Message- From: ffmpeg-devel On Behalf Of Gyan Doshi Sent: Tuesday, February 18, 2020 01:33 To: ffmpeg-devel@ffmpeg.org Subject: Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg_filter: add -autoscale to disable/enable the default scale On

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg_filter: add -autoscale to disable/enable the default scale

2020-02-17 Thread Fu, Linjie
> -Original Message- > From: ffmpeg-devel On Behalf Of > Gyan Doshi > Sent: Tuesday, February 18, 2020 01:44 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg_filter: add -autoscale > to disable/enable the default scale > > > > On 17-02-2020 11:07 pm, Fu

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg_filter: add -autoscale to disable/enable the default scale

2020-02-17 Thread Gyan Doshi
On 17-02-2020 11:29 pm, Fu, Linjie wrote: -Original Message- From: ffmpeg-devel On Behalf Of Gyan Doshi Sent: Tuesday, February 18, 2020 01:44 To: ffmpeg-devel@ffmpeg.org Subject: Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg_filter: add -autoscale to disable/enable the default scale On

Re: [FFmpeg-devel] dvbsub.c, change segment order to be in line with spec

2020-02-17 Thread Carl Eugen Hoyos
> Am 17.02.2020 um 16:10 schrieb Alen Vrečko : > > Hello, everyone. > > I'd like to request a change in order of DVB segments to be in line with ETSI > 300 743. Basically Region Composition Segment should come before CLUT > segment. This caused problems on legacy STBs namely Amino A110. > >

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg_filter: add -autoscale to disable/enable the default scale

2020-02-17 Thread Nicolas George
Gyan Doshi (12020-02-17): > The flag should be added first, then this patch updated to check and abort > if encoder doesn't have the capability. Why? The described behavior seems quite fine. Aborting the encoding process a little earlier would be fine, but it's hardly a critical issue. Regards,

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg_filter: add -autoscale to disable/enable the default scale

2020-02-17 Thread Fu, Linjie
> -Original Message- > From: ffmpeg-devel On Behalf Of > Gyan Doshi > Sent: Tuesday, February 18, 2020 02:10 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg_filter: add -autoscale > to disable/enable the default scale > > > > On 17-02-2020 11:29 pm, Fu

Re: [FFmpeg-devel] [PATCH, v2 2/4] avc/avcodec: add AV_CODEC_CAP_VARIABLE_DIMENSIONS flag

2020-02-17 Thread Fu, Linjie
> -Original Message- > From: ffmpeg-devel On Behalf Of Fu, > Linjie > Sent: Thursday, October 10, 2019 14:46 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH, v2 2/4] avc/avcodec: add > AV_CODEC_CAP_VARIABLE_DIMENSIONS flag > > > ---

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg_filter: add -autoscale to disable/enable the default scale

2020-02-17 Thread Fu, Linjie
> -Original Message- > From: ffmpeg-devel On Behalf Of > Nicolas George > Sent: Tuesday, February 18, 2020 00:44 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg_filter: add -autoscale > to disable/enable the default s

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg_filter: add -autoscale to disable/enable the default scale

2020-02-17 Thread Gyan Doshi
On 17-02-2020 11:50 pm, Nicolas George wrote: Gyan Doshi (12020-02-17): The flag should be added first, then this patch updated to check and abort if encoder doesn't have the capability. Why? The described behavior seems quite fine. Aborting the encoding process a little earlier would be fine

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg_filter: add -autoscale to disable/enable the default scale

2020-02-17 Thread Nicolas George
Gyan Doshi (12020-02-18): > There are dozens of video encoders - can we be sure that no encoder will > crash or read out of bounds if frame res is different than expected If they do, that's a serious problem by itself, and a protection in the command-line tool will only hide it. Regards, -- N

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg_filter: add -autoscale to disable/enable the default scale

2020-02-17 Thread Gyan Doshi
On 18-02-2020 12:20 am, Nicolas George wrote: Gyan Doshi (12020-02-18): There are dozens of video encoders - can we be sure that no encoder will crash or read out of bounds if frame res is different than expected If they do, that's a serious problem by itself, and a protection in the command-

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg_filter: add -autoscale to disable/enable the default scale

2020-02-17 Thread Nicolas George
Gyan Doshi (12020-02-18): > Protection in the command line tool will help steer the user towards > choosing an accommodating encoder, which is possible once the flag and a > check is added. True, but minor and should not block the patch. Regards, -- Nicolas George signature.asc Description:

Re: [FFmpeg-devel] [PATCH] lavf/http: accept both GET and POST in read-write mode.

2020-02-17 Thread Nicolas George
Nicolas George (12020-02-17): > Signed-off-by: Nicolas George > --- > libavformat/http.c | 19 ++- > 1 file changed, 14 insertions(+), 5 deletions(-) Disregard: the client will be in write mode even for a POST, and reading on it will not work. Regards, -- Nicolas George si

Re: [FFmpeg-devel] Status and Plans for Subtitle Filters

2020-02-17 Thread Nicolas George
Soft Works (12020-02-14): > I am looking for some guidance regarding future plans about processing > subtitle streams in filter graphs. > > Please correct me where I'm wrong - this is the situation as I've > understood it so far: > > - Currently, ffmpeg filter graphs do not support processing sub

Re: [FFmpeg-devel] Status and Plans for Subtitle Filters

2020-02-17 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Nicolas George > Sent: Monday, February 17, 2020 8:37 PM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] Status and Plans for Subtitle Filters > > Soft Works (12020-02-14): > > I am

Re: [FFmpeg-devel] [PATCH, v2 2/4] avc/avcodec: add AV_CODEC_CAP_VARIABLE_DIMENSIONS flag

2020-02-17 Thread Michael Niedermayer
On Mon, Feb 17, 2020 at 06:28:23PM +, Fu, Linjie wrote: > > -Original Message- > > From: ffmpeg-devel On Behalf Of Fu, > > Linjie > > Sent: Thursday, October 10, 2019 14:46 > > To: FFmpeg development discussions and patches > de...@ffmpeg.org> > > Subject: Re: [FFmpeg-devel] [PATCH, v

Re: [FFmpeg-devel] [PATCH 2/2] avformat: add demuxer for Rayman 2's APM format

2020-02-17 Thread Moritz Barsnick
On Mon, Feb 17, 2020 at 18:34:34 +0100, Carl Eugen Hoyos wrote: > Am 17.02.2020 um 10:49 schrieb Zane van Iperen : > > There's no real "magic" fields to look for, hence why I set the `extensions` > > field. What would a probe function do in this case? > > I cannot look at the files right now: > Is

Re: [FFmpeg-devel] [PATCH 2/2] avformat: add demuxer for Rayman 2's APM format

2020-02-17 Thread Zane van Iperen
On 18/2/20 8:54 am, Moritz Barsnick wrote: > > On Mon, Feb 17, 2020 at 18:34:34 +0100, Carl Eugen Hoyos wrote: >> Am 17.02.2020 um 10:49 schrieb Zane van Iperen : >>> There's no real "magic" fields to look for, hence why I set the `extensions` >>> field. What would a probe function do in this case

Re: [FFmpeg-devel] [PATCH] Escape braces in a regex, fixing warnings with newer perl

2020-02-17 Thread myp...@gmail.com
On Mon, Feb 17, 2020 at 3:46 PM Martin Storsjö wrote: > > Perl 5.28 warns about this, saying it will be fatal in Perl 5.32. > > Signed-off-by: Martin Storsjö > --- > gas-preprocessor.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gas-preprocessor.pl b/gas-preprocesso

[FFmpeg-devel] [PATCH] ansi: process ESC[3m italics attribute

2020-02-17 Thread Peter Ross
squelch unknown escape code warnings --- libavcodec/ansi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/ansi.c b/libavcodec/ansi.c index 5e1035ffd0..516d07db69 100644 --- a/libavcodec/ansi.c +++ b/libavcodec/ansi.c @@ -34,6 +34,7 @@ #define ATTR_BOLD

[FFmpeg-devel] [PATCH] libavformat/webvttenc: Allow (but discard) additional streams

2020-02-17 Thread Soft Works
This allows having a video stream as reference stream when using the segment muxer: The video stream serves as a kind of 'heartbeat' to ensure that VTT segments are generated regularly, even when there aren't any subtitle packets for a while. Example: ffmpeg -i INPUT -map 0:3 -c:0 webvtt -ma

Re: [FFmpeg-devel] [PATCH 1/3] avutil/frame: add use_last_roi

2020-02-17 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of > James Almer > Sent: Friday, February 14, 2020 9:33 PM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH 1/3] avutil/frame: add use_last_roi > > On 2/14/2020 5:33 AM, Hendrik

[FFmpeg-devel] [PATCH] Print out numeric values of option constants

2020-02-17 Thread Soft Works
It's often not obvious how option constants relate to numerical values. Defaults are sometimes printed as numbers and from/to are always printed as numbers. Printing the numeric values of options constants avoids this confusion. It also allows to see which constants are equivalent. Before this pa

Re: [FFmpeg-devel] [PATCH 1/3] avutil/frame: add use_last_roi

2020-02-17 Thread Guo, Yejun
> -Original Message- > From: Guo, Yejun > Sent: Tuesday, February 18, 2020 10:35 AM > To: Guo, Yejun > Subject: RE: [FFmpeg-devel] [PATCH 1/3] avutil/frame: add use_last_roi > > > > From: Ronald S. Bultje [mailto:rsbul...@gmail.com] > Sent: Friday, February 14, 2020 11:02 PM > To: FFm

Re: [FFmpeg-devel] [PATCH 1/3] avutil/frame: add use_last_roi

2020-02-17 Thread myp...@gmail.com
On Tue, Feb 18, 2020 at 11:06 AM Guo, Yejun wrote: > > > > > -Original Message- > > From: Guo, Yejun > > Sent: Tuesday, February 18, 2020 10:35 AM > > To: Guo, Yejun > > Subject: RE: [FFmpeg-devel] [PATCH 1/3] avutil/frame: add use_last_roi > > > > > > > > From: Ronald S. Bultje [mailto:r

Re: [FFmpeg-devel] [PATCH 2/2] avformat: add demuxer for Rayman 2's APM format

2020-02-17 Thread Carl Eugen Hoyos
> Am 18.02.2020 um 00:20 schrieb Zane van Iperen : > > So, something like this? > > #define APM_TAG_VS12 MKTAG('v', 's', '1', '2') > #define APM_TAG_DATA MKTAG('D', 'A', 'T', 'A') > > static int apm_probe(const AVProbeData *p) > { > if (p->buf_size < 100) > return 0; > > if