Limin Wang (12019-12-23):
> But It's not my code, I'm a code reviewer.
Then review that ret needs to be returned ;-) It needs more change, not
less.
And the commit message needs to be explicit. CID may not be available
everywhere or everywhen.
Regards,
--
Nicolas George
signature.asc
Descr
On Mon, 23 Dec 2019, alexandre.schm...@gmail.com wrote:
not sure why i just now realize it but
Storing the source path is problematic privacy and security wise
Thanks
What does this means? That it won't be applied?
It only means that you may have to only activate this (or at least the
On Mon, Dec 23, 2019 at 12:19:21AM +, alexandre.schm...@gmail.com wrote:
> >
> > not sure why i just now realize it but
> >
> > Storing the source path is problematic privacy and security wise
> >
> > Thanks
> >
>
> What does this means? That it won't be applied?
>
> Can you give an example o
On Sun, 2019-12-22 at 18:44:01 +0100, Michael Niedermayer wrote:
> a reference to a VCS should include the version
> similarly for wikipedia some revission of the page should be mentioned in
> the commit message
Heh, this is already a defunct standard, I doubt it will ever change
again. I've updat
TODO changelog and version bump
Signed-off-by: Nicolas George
---
doc/filters.texi | 48 +++
libavfilter/Makefile | 1 +
libavfilter/af_mbfequalizer.c | 567 ++
libavfilter/allfilters.c | 1 +
4 files changed, 617 insertions(+)
cre
Ping x2
On 20-12-2019 11:24 am, Gyan wrote:
Ping for this and remaining patches in set.
On 17-12-2019 02:55 pm, Gyan wrote:
On 17-12-2019 01:44 am, Michael Niedermayer wrote:
On Sun, Dec 15, 2019 at 10:36:58PM +0530, Gyan wrote:
3rd of 5 factorized patches; supersedes
https://patchwork.ffm
Nicolas George (12019-12-17):
> I will push these five patches soon unless somebody object.
Pushed.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailma
myp...@gmail.com (12019-12-12):
> LGTM, but need to wait next release cycle?
What do you mean? There is all the necessary code to let the option
disappear automatically at the next release.
I shall push soon, unless you point something I have missed.
Regards,
--
Nicolas George
signature.a
Nicolas George 于2019年12月23日周一 下午5:00写道：
>
> Limin Wang (12019-12-23):
> > But It's not my code, I'm a code reviewer.
>
> Then review that ret needs to be returned ;-) It needs more change, not
> less.
Could specify what "more change" is needed?
___
ffmp
Zhong Li (12019-12-23):
> > Then review that ret needs to be returned ;-) It needs more change, not
> > less.
>
> Could specify what "more change" is needed?
See above, I underlined it.
Regards,
--
Nicolas George
signature.asc
Description: PGP
James Almer 于2019年12月22日周日 下午11:29写道：
>
> On 12/22/2019 12:26 PM, Zhong Li wrote:
> > Signed-off-by: Zhong Li
> > ---
> > libavcodec/midivid.c | 9 ++---
> > 1 file changed, 6 insertions(+), 3 deletions(-)
> >
> > diff --git a/libavcodec/midivid.c b/libavcodec/midivid.c
> > index 38465c5..3d
On 12/22/19, Zhong Li wrote:
> Signed-off-by: Zhong Li
> ---
> libavcodec/midivid.c | 9 ++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/libavcodec/midivid.c b/libavcodec/midivid.c
> index 38465c5..3dac3f1 100644
> --- a/libavcodec/midivid.c
> +++ b/libavcodec/midivi
On 12/23/2019 9:31 AM, Zhong Li wrote:
> James Almer 于2019年12月22日周日 下午11:29写道：
>>
>> On 12/22/2019 12:26 PM, Zhong Li wrote:
>>> Signed-off-by: Zhong Li
>>> ---
>>> libavcodec/midivid.c | 9 ++---
>>> 1 file changed, 6 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/libavcodec/midivid.c b
On 12/23/2019 8:17 AM, Nicolas George wrote:
> TODO changelog and version bump
>
> Signed-off-by: Nicolas George
> ---
> doc/filters.texi | 48 +++
> libavfilter/Makefile | 1 +
> libavfilter/af_mbfequalizer.c | 567 ++
> libavfilter/allfi
Thanks for the comment.
James Almer (12019-12-23):
> > +frame_out = ff_get_audio_buffer(ctx->outputs[0],
> > frame->nb_samples);
> Can't you use av_frame_make_writable() instead to simplify this?
No, because it does not use ff_get_audio_buffer(), and therefore does
not allow direct rend
James Almer 于2019年12月23日周一 下午9:09写道：
>
> On 12/23/2019 9:31 AM, Zhong Li wrote:
> > James Almer 于2019年12月22日周日 下午11:29写道：
> >>
> >> On 12/22/2019 12:26 PM, Zhong Li wrote:
> >>> Signed-off-by: Zhong Li
> >>> ---
> >>> libavcodec/midivid.c | 9 ++---
> >>> 1 file changed, 6 insertions(+), 3
On 12/23/2019 10:25 AM, Nicolas George wrote:
> Thanks for the comment.
>
> James Almer (12019-12-23):
>>> +frame_out = ff_get_audio_buffer(ctx->outputs[0],
>>> frame->nb_samples);
>
>> Can't you use av_frame_make_writable() instead to simplify this?
>
> No, because it does not use ff_g
Fix CID 1456088
Signed-off-by: Zhong Li
---
libavcodec/midivid.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/libavcodec/midivid.c b/libavcodec/midivid.c
index 38465c5..bb5105b 100644
--- a/libavcodec/midivid.c
+++ b/libavcodec/midivid.c
@@ -63,7 +63,7 @@ static int
Tomas Härdin (12019-12-09):
> As far as I can tell this is OK, and it passes FATE. But it just looks
> very very wrong. Why does this function even exist if all it
> effectively does is return the integers from 0..count-1?
For some time, there were gaps in the list of pixel formats, the task of
th
From: Limin Wang
Signed-off-by: Limin Wang
---
libavutil/frame.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/libavutil/frame.c b/libavutil/frame.c
index 1d0faec687..0a1ba877cc 100644
--- a/libavutil/frame.c
+++ b/libavutil/frame.c
@@ -696,11 +696,8 @@ AVFrameSideD
On Fri, Dec 20, 2019 at 04:55:12PM +0530, Gyan wrote:
>
> Regards,
> Gyan
> From fbbd221b089f3b272cfd712c3d4824dd86b4eac0 Mon Sep 17 00:00:00 2001
> From: Gyan Doshi
> Date: Fri, 20 Dec 2019 16:39:32 +0530
> Subject: [PATCH] avformat/mpegtsenc: warn users if codec isn't supported
>
> The MPEG-T
On 23-12-2019 08:45 pm, Limin Wang wrote:
On Fri, Dec 20, 2019 at 04:55:12PM +0530, Gyan wrote:
Regards,
Gyan
From fbbd221b089f3b272cfd712c3d4824dd86b4eac0 Mon Sep 17 00:00:00 2001
From: Gyan Doshi
Date: Fri, 20 Dec 2019 16:39:32 +0530
Subject: [PATCH] avformat/mpegtsenc: warn users if codec
On Sat, 23. Nov 06:18, Andriy Gelman wrote:
> On Tue, 12. Nov 22:46, Andriy Gelman wrote:
> > From: Andriy Gelman
> >
> > Fixes #8079
> >
> > During initialization of a v4l2m2m device, the configured pix_fmt can be
> > different to the pix_fmt of the encoder (i.e. avctx->pix_fmt).
> >
> > For e
---
libavfilter/vf_drawtext.c | 12 +++-
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/libavfilter/vf_drawtext.c b/libavfilter/vf_drawtext.c
index 8f4badbdb5..aea17b6793 100644
--- a/libavfilter/vf_drawtext.c
+++ b/libavfilter/vf_drawtext.c
@@ -829,6 +829,7 @@ static int co
zhilizhao (12019-12-06):
> > + * with the parameters args. opaque is ignored currently.
>
> It should be 'parameter args’. I will wait for more comments first.
I fixed it myself, swapped "currently ignored", added a precision in the
commit message of the first patch and pushed.
Thanks.
Regards,
quinkbl...@foxmail.com (12019-12-04):
> From: Zhao Zhili
>
> !(c->pix_fmt != AV_PIX_FMT_NONE || c->got_format_from_params)
>
> equals
>
> (c->pix_fmt == AV_PIX_FMT_NONE) && !c->got_format_from_params
>
> 1. When (c->pix_fmt == AV_PIX_FMT_NONE) is true, got_format_from_params is
> always false,
This enables DX11 support for QSV with higher priority than DX9.
In case of multiple GPUs configuration, DX9 API does not allow to get
access to QSV device in some cases - headless.
Implementation based on DX11 resolves that restriction by enumerating list of
available GPUs and finding device with
On Mon, Dec 23, 2019 at 7:40 PM Artem Galin wrote:
>
> This enables DX11 support for QSV with higher priority than DX9.
> In case of multiple GPUs configuration, DX9 API does not allow to get
> access to QSV device in some cases - headless.
> Implementation based on DX11 resolves that restriction
On Mon, Dec 23, 2019 at 04:11:53PM +0100, Nicolas George wrote:
> Tomas Härdin (12019-12-09):
> > As far as I can tell this is OK, and it passes FATE. But it just looks
> > very very wrong. Why does this function even exist if all it
> > effectively does is return the integers from 0..count-1?
>
>
On Mon, Dec 23, 2019 at 11:05:04AM -0500, Andriy Gelman wrote:
> On Sat, 23. Nov 06:18, Andriy Gelman wrote:
> > On Tue, 12. Nov 22:46, Andriy Gelman wrote:
> > > From: Andriy Gelman
> > >
> > > Fixes #8079
> > >
> > > During initialization of a v4l2m2m device, the configured pix_fmt can be
> >
Signed-off-by: Wang Cao
---
doc/encoders.texi | 3 +++
libavcodec/libaomenc.c | 6 ++
2 files changed, 9 insertions(+)
diff --git a/doc/encoders.texi b/doc/encoders.texi
index 4ee518a124..56b36c156b 100644
--- a/doc/encoders.texi
+++ b/doc/encoders.texi
@@ -1587,6 +1587,9 @@ Enable row
On Mon, 23. Dec 21:42, Michael Niedermayer wrote:
> On Mon, Dec 23, 2019 at 11:05:04AM -0500, Andriy Gelman wrote:
> > On Sat, 23. Nov 06:18, Andriy Gelman wrote:
> > > On Tue, 12. Nov 22:46, Andriy Gelman wrote:
> > > > From: Andriy Gelman
> > > >
> > > > Fixes #8079
> > > >
> > > > During init
Hi,
I'm trying to add support for AAC to PulseAudio with regard to Bluetooth
A2DP. I'm using libavcodec to encode AAC content and then packetize it
into RTP MP4-LATM packets, as required by A2DP spec. My current
implementation allows to switch between libfdk-aac and built-in AAC
encoder backe
On Tue, Dec 17, 2019 at 02:55:06PM +0530, Gyan wrote:
>
[...]
> @@ -127,6 +204,22 @@ static av_cold int init_dict(AVFilterContext *ctx,
> AVDictionary **opts)
> if (!scale->h_expr)
> av_opt_set(scale, "h", "ih", 0);
>
> +ret = av_expr_parse(&scale->w_pexpr, scale->w_expr,
> +
On Mon, Dec 23, 2019 at 09:46:39PM +0530, Gyan Doshi wrote:
> ---
> libavfilter/vf_drawtext.c | 12 +++-
> 1 file changed, 7 insertions(+), 5 deletions(-)
LGTM
thx
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
The real ebay dictionary, page 2
"100% p
On Mon, Dec 23, 2019 at 10:48:13PM +0800, lance.lmw...@gmail.com wrote:
> From: Limin Wang
>
> Signed-off-by: Limin Wang
> ---
> libavutil/frame.c | 7 ++-
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/libavutil/frame.c b/libavutil/frame.c
> index 1d0faec687..0a1ba877c
On Mon, Dec 23, 2019 at 11:43:10AM +0100, Ulrich Spörlein wrote:
> On Sun, 2019-12-22 at 18:44:01 +0100, Michael Niedermayer wrote:
> > a reference to a VCS should include the version
> > similarly for wikipedia some revission of the page should be mentioned in
> > the commit message
>
> Heh, this
From: Limin Wang
Signed-off-by: Limin Wang
---
libavutil/frame.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/libavutil/frame.c b/libavutil/frame.c
index e4038096c2..1a67eda91d 100644
--- a/libavutil/frame.c
+++ b/libavutil/frame.c
@@ -693,14 +693,11 @@ AVFrameSi
On Tue, Dec 24, 2019 at 12:32:07AM +0100, Michael Niedermayer wrote:
> On Mon, Dec 23, 2019 at 10:48:13PM +0800, lance.lmw...@gmail.com wrote:
> > From: Limin Wang
> >
> > Signed-off-by: Limin Wang
> > ---
> > libavutil/frame.c | 7 ++-
> > 1 file changed, 2 insertions(+), 5 deletions(-)
>
Andreas Rheinhardt:
> Andreas Rheinhardt:
>> Andreas Rheinhardt:
>>> Andreas Rheinhardt:
When vobsub_read_packet() reads a packet, it uses a dedicated AVPacket
to get the subtitle timing and position from an FFDemuxSubtitlesQueue
(which has been filled with this data during reading t
From: Limin Wang
Signed-off-by: Limin Wang
---
libavcodec/decode.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libavcodec/decode.c b/libavcodec/decode.c
index cd275bacc4..1ebbca4724 100644
--- a/libavcodec/decode.c
+++ b/libavcodec/decode.c
@@ -227,13 +227,13 @@ int
On Thu, Nov 28, 2019 at 11:06:52PM -0300, James Almer wrote:
> Defined in ITU-T H.264 (06/2019)
LGTM
>
> Signed-off-by: James Almer
> ---
> This is basically a copy paste of the H.265 implementation, both here and in
> the spec.
>
> libavcodec/cbs_h264.h | 6 ++
> libavc
On Thu, Nov 28, 2019 at 09:34:18AM +0800, lance.lmw...@gmail.com wrote:
> From: Limin Wang
>
> Signed-off-by: Limin Wang
> ---
> libavfilter/vf_yadif.c | 147 +++--
> 1 file changed, 54 insertions(+), 93 deletions(-)
>
> diff --git a/libavfilter/vf_yadif.c b
On Wed, Nov 27, 2019 at 06:46:50PM +0800, lance.lmw...@gmail.com wrote:
> From: Limin Wang
>
> Signed-off-by: Limin Wang
> ---
> libavfilter/vf_colormatrix.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/libavfilter/vf_colormatrix.c b/libavfilter/vf_colormatrix.c
> index 3a02e2b86e.
On 12/23/2019 8:32 PM, Michael Niedermayer wrote:
> On Mon, Dec 23, 2019 at 10:48:13PM +0800, lance.lmw...@gmail.com wrote:
>> From: Limin Wang
>>
>> Signed-off-by: Limin Wang
>> ---
>> libavutil/frame.c | 7 ++-
>> 1 file changed, 2 insertions(+), 5 deletions(-)
>>
>> diff --git a/libavutil
On Mon, Dec 23, 2019 at 10:20:37PM -0300, James Almer wrote:
> On 12/23/2019 8:32 PM, Michael Niedermayer wrote:
> > On Mon, Dec 23, 2019 at 10:48:13PM +0800, lance.lmw...@gmail.com wrote:
> >> From: Limin Wang
> >>
> >> Signed-off-by: Limin Wang
> >> ---
> >> libavutil/frame.c | 7 ++-
> >>
Limin Wang:
> On Mon, Dec 23, 2019 at 10:20:37PM -0300, James Almer wrote:
>> On 12/23/2019 8:32 PM, Michael Niedermayer wrote:
>>> On Mon, Dec 23, 2019 at 10:48:13PM +0800, lance.lmw...@gmail.com wrote:
From: Limin Wang
Signed-off-by: Limin Wang
---
libavutil/frame.c |
On Tue, Dec 24, 2019 at 01:46:00AM +, Andreas Rheinhardt wrote:
> Limin Wang:
> > On Mon, Dec 23, 2019 at 10:20:37PM -0300, James Almer wrote:
> >> On 12/23/2019 8:32 PM, Michael Niedermayer wrote:
> >>> On Mon, Dec 23, 2019 at 10:48:13PM +0800, lance.lmw...@gmail.com wrote:
> From: Limin
thank you，I learned
At 2019-12-16 06:17:33, "Martin Storsjö" wrote:
>On Tue, 10 Dec 2019, manuelyuan wrote:
>
>> I opened a ticket in https://trac.ffmpeg.org/ticket/8420
>> my patch may be not absolutely right, but this problem should get your
>> attention, thank you
>
>I sent a patch that doesn
> On Dec 24, 2019, at 4:32 AM, Michael Niedermayer
> wrote:
>
> On Mon, Dec 23, 2019 at 04:11:53PM +0100, Nicolas George wrote:
>> Tomas Härdin (12019-12-09):
>>> As far as I can tell this is OK, and it passes FATE. But it just looks
>>> very very wrong. Why does this function even exist if al
On 24-12-2019 04:52 am, Michael Niedermayer wrote:
On Mon, Dec 23, 2019 at 09:46:39PM +0530, Gyan Doshi wrote:
---
libavfilter/vf_drawtext.c | 12 +++-
1 file changed, 7 insertions(+), 5 deletions(-)
LGTM
Pushed as 287620f59c5e5b3d65855f71048a8fe7db142451
Thanks,
Gyan
__
On 24-12-2019 04:50 am, Michael Niedermayer wrote:
On Tue, Dec 17, 2019 at 02:55:06PM +0530, Gyan wrote:
[...]
@@ -127,6 +204,22 @@ static av_cold int init_dict(AVFilterContext *ctx,
AVDictionary **opts)
if (!scale->h_expr)
av_opt_set(scale, "h", "ih", 0);
+ret = av_exp
"VAProcFilterParameterBufferHDRToneMapping" was defined in libva 2.4.1, which
will lead to
build failure for the filter tonemap_vaapi for libva 2.3.0 with current check.
This patch
is to fix this build error.
Signed-off-by: Xinpeng Sun
---
configure | 4 ++--
1 file changed, 2 insertions(+), 2
> -Original Message-
> From: ffmpeg-devel On Behalf Of Marton
> Balint
> Sent: Monday, December 23, 2019 5:15 AM
> To: FFmpeg development discussions and patches
> Cc: Sun, Xinpeng
> Subject: Re: [FFmpeg-devel] [PATCH V4] avfilter: Add tonemap vaapi filter for
> H2S
>
>
>
> On Thu, 1
54 matches
Mail list logo
