On Tue, Dec 24, 2019 at 12:32:07AM +0100, Michael Niedermayer wrote: > On Mon, Dec 23, 2019 at 10:48:13PM +0800, lance.lmw...@gmail.com wrote: > > From: Limin Wang <lance.lmw...@gmail.com> > > > > Signed-off-by: Limin Wang <lance.lmw...@gmail.com> > > --- > > libavutil/frame.c | 7 ++----- > > 1 file changed, 2 insertions(+), 5 deletions(-) > > > > diff --git a/libavutil/frame.c b/libavutil/frame.c > > index 1d0faec687..0a1ba877cc 100644 > > --- a/libavutil/frame.c > > +++ b/libavutil/frame.c > > @@ -696,11 +696,8 @@ AVFrameSideData > > *av_frame_new_side_data_from_buf(AVFrame *frame, > > if (!buf) > > return NULL; > > > > - if (frame->nb_side_data > INT_MAX / sizeof(*frame->side_data) - 1) > > - return NULL; > > - > > - tmp = av_realloc(frame->side_data, > > - (frame->nb_side_data + 1) * > > sizeof(*frame->side_data)); > > + tmp = av_realloc_array(frame->side_data, > > + (frame->nb_side_data + 1), sizeof(*frame->side_data)); > > does something prevent "frame->nb_side_data + 1" from overflowing ?
no, I have add the check for the overflow and update the patch. > > thx > > [...] > -- > Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB > > Many things microsoft did are stupid, but not doing something just because > microsoft did it is even more stupid. If everything ms did were stupid they > would be bankrupt already. > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
