Re: [FFmpeg-devel] [PATCH V1] lavfi/concat: fix logic error in framerate check

2019-09-09 Thread Paul B Mahol
lgtm On 9/9/19, Jun Zhao wrote: > From: Jun Zhao > > fix logic error in framerate check, it's introduced by commit > 3ad5d4df9ce794d3eeb0f526c5f3e446bf97c616 > > Signed-off-by: Jun Zhao > --- > libavfilter/avf_concat.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --gi

Re: [FFmpeg-devel] [PATCH] avfilter/vf_fps: Avoid inlink fifo build up.

2019-09-09 Thread Paul B Mahol
lgtm On 8/29/19, Nikolas Bowe wrote: > When duplicating frames we need to schedule for activation again, otherwise > frames can build up in the inlink fifo. > --- > libavfilter/vf_fps.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavfilter/vf_fps.c b/libavfilter/vf

Re: [FFmpeg-devel] [PATCH] configure: check for a sufficiently recent enough AMF version

2019-09-09 Thread Hendrik Leppkes
On Mon, Sep 9, 2019 at 4:30 AM James Almer wrote: > > On 9/8/2019 7:51 PM, Hendrik Leppkes wrote: > > Due to the recent addition of Vulkan support to AMF, we require more > > recent headers that include the new structures, which have been > > available since AMF 1.4.9 released in September 2018. >

Re: [FFmpeg-devel] [PATCH V1] lavfi/concat: fix logic error in framerate check

2019-09-09 Thread myp...@gmail.com
On Mon, Sep 9, 2019 at 3:21 PM Paul B Mahol wrote: > > lgtm > Will apply, Thanks > On 9/9/19, Jun Zhao wrote: > > From: Jun Zhao > > > > fix logic error in framerate check, it's introduced by commit > > 3ad5d4df9ce794d3eeb0f526c5f3e446bf97c616 > > > > Signed-off-by: Jun Zhao > > --- > > libav

[FFmpeg-devel] Please allow specific starting frame to be selected.

2019-09-09 Thread Ben Hutchinson
I have an MP4 video, and I'm trying to extract 100 frames starting from frame number 271. As of right now I can select duration by time using -t or by frame count by using -frames. And I can also select starting point by time by using -ss. However, I believe that as of now there is no command line

Re: [FFmpeg-devel] [PATCH] avcodec/webp: avoid trying to decode trailing junk in bitstreams

2019-09-09 Thread Pascal Massimino
Michael, On Fri, Sep 6, 2019 at 6:21 PM Michael Niedermayer wrote: > On Fri, Sep 06, 2019 at 01:11:50PM +0200, Pascal Massimino wrote: > > Michael, > > > > On Thu, Sep 5, 2019 at 6:20 PM Michael Niedermayer > > > wrote: > > > > > On Wed, Sep 04, 2019 at 07:43:15AM +0200, Pascal Massimino wrote:

Re: [FFmpeg-devel] [PATCH V1] lavfi/concat: fix logic error in framerate check

2019-09-09 Thread Nicolas George
Jun Zhao (12019-09-09): > From: Jun Zhao > > fix logic error in framerate check, it's introduced by commit > 3ad5d4df9ce794d3eeb0f526c5f3e446bf97c616 > > Signed-off-by: Jun Zhao > --- > libavfilter/avf_concat.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) Of course, thanks. S

Re: [FFmpeg-devel] [PATCH 1/2] lavu/pixfmt: add AYUV pixel format

2019-09-09 Thread Fu, Linjie
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Carl Eugen Hoyos > Sent: Sunday, September 1, 2019 01:57 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH 1/2] lavu/pixfmt: add AYUV pixe

Re: [FFmpeg-devel] [PATCH, v2 2/2] lavc/vaapi_decode: recreate hw_frames_ctx for vp9 without destroy va_context

2019-09-09 Thread Fu, Linjie
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Fu, Linjie > Sent: Friday, August 30, 2019 16:05 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH, v2 2/2] lavc/vaapi_decode: recreate >

[FFmpeg-devel] [PATCH] libsrt: add password ACL support using new streamID specification

2019-09-09 Thread Aaron Boxer
Hello! SRT has added a new stream ID specification allowing extraction of various fields from the user password. This patch adds support for using an ACL to check user credentials - base on this Haivision sample code: https://github.com/Haivision/srt/blob/master/testing/srt-test-live.cpp Thanks, A

Re: [FFmpeg-devel] [PATCH] libavfilter/vf_drawtext: Avoid undefined behavior from GET_UTF8

2019-09-09 Thread Michael Niedermayer
On Sat, Jul 27, 2019 at 07:58:48AM -0700, Aaron Boushley wrote: > The vf_drawtext filter uses the GET_UTF8 macro in multiple locations. > Each of these use `continue;` as the error handler. However the > documentation for the GET_UTF8 macro states "ERROR should not contain > a loop control statemen

Re: [FFmpeg-devel] [PATCH v3 1/2] swscale/swscale: delete unwanted assignments

2019-09-09 Thread Michael Niedermayer
On Sun, Sep 08, 2019 at 09:12:14PM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libswscale/swscale.c | 2 -- > 1 file changed, 2 deletions(-) will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The

Re: [FFmpeg-devel] [PATCH] tests: Fix bash errors in lavf_container tests.

2019-09-09 Thread Michael Niedermayer
On Sun, Sep 08, 2019 at 06:45:30PM +0800, Limin Wang wrote: > On Sun, Sep 08, 2019 at 12:46:25AM +0300, Andrey Semashev wrote: > > On 2019-09-07 18:32, Limin Wang wrote: > > >On Sat, Sep 07, 2019 at 05:19:55PM +0200, Michael Niedermayer wrote: > > >>On Wed, Aug 28, 2019 at 06:32:37PM +0300, Andrey

[FFmpeg-devel] [PATCH] cmdutils: promote report level if loglevel is higher

2019-09-09 Thread Gyan
From 9581ee61d2eaeac1cf2a0262d010e95d316228db Mon Sep 17 00:00:00 2001 From: Gyan Doshi Date: Mon, 9 Sep 2019 23:37:08 +0530 Subject: [PATCH] cmdutils: promote report level if loglevel is higher --- fftools/cmdutils.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --gi

Re: [FFmpeg-devel] [PATCH 3/4] avcodec/dxv: Check op_offset in both directions

2019-09-09 Thread Michael Niedermayer
On Fri, Jul 19, 2019 at 09:53:34PM +0200, Michael Niedermayer wrote: > On Fri, Jul 19, 2019 at 03:36:43PM +0200, Paul B Mahol wrote: > > On 7/19/19, Michael Niedermayer wrote: > > > On Thu, Jun 27, 2019 at 09:32:44AM +0200, Paul B Mahol wrote: > > >> On 6/27/19, Michael Niedermayer wrote: > > >>

[FFmpeg-devel] [PATCH 1/2] avcodec/g2meet: Check if adjusted pixel was on the stack

2019-09-09 Thread Michael Niedermayer
This basically checks if a pixel that was coded with prediction and residual could have been stored using a previous case. This avoids basically a string of 0 symbols stored in less than 50 bytes to hit a O(n²) codepath. Fixes: Timeout (too slow to wait -> immedeatly) Fixes: 8668/clusterfuzz-test

[FFmpeg-devel] [PATCH 2/2] avcodec/g2meet: Check for end of input in jpg_decode_block()

2019-09-09 Thread Michael Niedermayer
Fixes: Timeout (100sec -> 0.7sec) Fixes: 8668/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_G2M_fuzzer-5174143888130048 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/g2meet.c | 3 +++ 1

[FFmpeg-devel] [RFC PATCH] avfilter/fastdeint: import simple cpu-optimized deinterlacing algorithms from VLC

2019-09-09 Thread Aman Gupta
From: Aman Gupta These are simple algorithms which can be run efficiently on low powered devices to produce deinteraced images. Signed-off-by: Aman Gupta --- doc/filters.texi | 27 ++ libavfilter/Makefile | 1 + libavfilter/aarch64/Makefile | 1 + libavfilt

Re: [FFmpeg-devel] [PATCH 3/4] avcodec/dxv: Check op_offset in both directions

2019-09-09 Thread Paul B Mahol
On 9/9/19, Michael Niedermayer wrote: > On Fri, Jul 19, 2019 at 09:53:34PM +0200, Michael Niedermayer wrote: >> On Fri, Jul 19, 2019 at 03:36:43PM +0200, Paul B Mahol wrote: >> > On 7/19/19, Michael Niedermayer wrote: >> > > On Thu, Jun 27, 2019 at 09:32:44AM +0200, Paul B Mahol wrote: >> > >> On

Re: [FFmpeg-devel] [RFC PATCH] avfilter/fastdeint: import simple cpu-optimized deinterlacing algorithms from VLC

2019-09-09 Thread James Almer
On 9/9/2019 5:12 PM, Aman Gupta wrote: > From: Aman Gupta > > These are simple algorithms which can be run efficiently > on low powered devices to produce deinteraced images. > > Signed-off-by: Aman Gupta > --- > doc/filters.texi | 27 ++ > libavfilter/Makefile |

Re: [FFmpeg-devel] [RFC PATCH] avfilter/fastdeint: import simple cpu-optimized deinterlacing algorithms from VLC

2019-09-09 Thread Paul B Mahol
On 9/9/19, Aman Gupta wrote: > From: Aman Gupta > > These are simple algorithms which can be run efficiently > on low powered devices to produce deinteraced images. > > Signed-off-by: Aman Gupta > --- > doc/filters.texi | 27 ++ > libavfilter/Makefile | 1 + > lib

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/hevcdec: Fix memleak of a53_caption

2019-09-09 Thread Michael Niedermayer
On Mon, Jul 01, 2019 at 07:11:50PM -0300, James Almer wrote: > On 7/1/2019 11:24 AM, Michael Niedermayer wrote: > > On Sun, Jun 30, 2019 at 11:18:55PM -0300, James Almer wrote: > >> On 6/30/2019 10:43 PM, James Almer wrote: > >>> On 6/30/2019 7:16 PM, Michael Niedermayer wrote: > Fixes: > >>>

Re: [FFmpeg-devel] [PATCH 3/6] tools/target_dec_fuzzer: Adjust threshold for LSCR

2019-09-09 Thread Michael Niedermayer
On Sun, Aug 25, 2019 at 08:41:55PM +0200, Michael Niedermayer wrote: > Fixes: Timeout (12sec -> 3sec) > Fixes: > 15327/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_LSCR_fuzzer-5702887719567360 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/g2meet: Check if adjusted pixel was on the stack

2019-09-09 Thread Tomas Härdin
mån 2019-09-09 klockan 22:16 +0200 skrev Michael Niedermayer: > This basically checks if a pixel that was coded with prediction > and residual could have been stored using a previous case. > This avoids basically a string of 0 symbols stored in less than > 50 bytes to hit a O(n²) codepath. > > Fix

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/g2meet: Check for end of input in jpg_decode_block()

2019-09-09 Thread Tomas Härdin
mån 2019-09-09 klockan 22:16 +0200 skrev Michael Niedermayer: > Fixes: Timeout (100sec -> 0.7sec) > Fixes: > 8668/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_G2M_fuzzer-5174143888130048 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpe

Re: [FFmpeg-devel] [RFC PATCH] avfilter/fastdeint: import simple cpu-optimized deinterlacing algorithms from VLC

2019-09-09 Thread Carl Eugen Hoyos
Am Mo., 9. Sept. 2019 um 22:19 Uhr schrieb Aman Gupta : > > From: Aman Gupta > > These are simple algorithms which can be run efficiently > on low powered devices to produce deinteraced images. Please provide some numbers about the performance (and subjective visual quality) of the new C code in

Re: [FFmpeg-devel] [RFC PATCH] avfilter/fastdeint: import simple cpu-optimized deinterlacing algorithms from VLC

2019-09-09 Thread Aman Gupta
On Mon, Sep 9, 2019 at 2:47 PM Carl Eugen Hoyos wrote: > Am Mo., 9. Sept. 2019 um 22:19 Uhr schrieb Aman Gupta : > > > > From: Aman Gupta > > > > These are simple algorithms which can be run efficiently > > on low powered devices to produce deinteraced images. > > Please provide some numbers abo

Re: [FFmpeg-devel] [PATCH v2 5/8] avformat/utils: Fix memleaks II

2019-09-09 Thread Andreas Rheinhardt
Andriy Gelman: > Andreas, > > On Mon, 19. Aug 23:56, Andreas Rheinhardt wrote: >> Up until now, avformat_find_stream_info had a potential for memleaks: >> When everything is fine, it read packets and (depending upon whether >> AVFMT_FLAG_NOBUFFER was set) put them in a packet list or unreferenced

Re: [FFmpeg-devel] [RFC PATCH] avfilter/fastdeint: import simple cpu-optimized deinterlacing algorithms from VLC

2019-09-09 Thread Hendrik Leppkes
On Tue, Sep 10, 2019 at 12:00 AM Aman Gupta wrote: > > On Mon, Sep 9, 2019 at 2:47 PM Carl Eugen Hoyos wrote: > > > Am Mo., 9. Sept. 2019 um 22:19 Uhr schrieb Aman Gupta : > > > > > > From: Aman Gupta > > > > > > These are simple algorithms which can be run efficiently > > > on low powered devic

Re: [FFmpeg-devel] [PATCH v2 7/8] avformat/utils: Remove unnecessary packet copies

2019-09-09 Thread Andreas Rheinhardt
Andriy Gelman: > On Mon, 19. Aug 23:56, Andreas Rheinhardt wrote: >> Up until now, read_frame_internal in avformat/utils.c uses a spare >> packet on the stack that serves no real purpose: At no point in this >> function is there a need for another packet besides the packet destined >> for output: >

Re: [FFmpeg-devel] [RFC PATCH] avfilter/fastdeint: import simple cpu-optimized deinterlacing algorithms from VLC

2019-09-09 Thread Carl Eugen Hoyos
Am Di., 10. Sept. 2019 um 00:00 Uhr schrieb Aman Gupta : > > On Mon, Sep 9, 2019 at 2:47 PM Carl Eugen Hoyos wrote: > > > Am Mo., 9. Sept. 2019 um 22:19 Uhr schrieb Aman Gupta : > > > > > > From: Aman Gupta > > > > > > These are simple algorithms which can be run efficiently > > > on low powered

[FFmpeg-devel] [PATCH v3 7/8] avformat/utils: Remove unnecessary packet copies

2019-09-09 Thread Andreas Rheinhardt
Up until now, read_frame_internal in avformat/utils.c uses a spare packet on the stack that serves no real purpose: At no point in this function is there a need for another packet besides the packet destined for output: 1. If the packet doesn't need a parser, but is output as is, the content of the

Re: [FFmpeg-devel] [RFC PATCH] avfilter/fastdeint: import simple cpu-optimized deinterlacing algorithms from VLC

2019-09-09 Thread Aman Gupta
On Mon, Sep 9, 2019 at 3:19 PM Hendrik Leppkes wrote: > On Tue, Sep 10, 2019 at 12:00 AM Aman Gupta wrote: > > > > On Mon, Sep 9, 2019 at 2:47 PM Carl Eugen Hoyos > wrote: > > > > > Am Mo., 9. Sept. 2019 um 22:19 Uhr schrieb Aman Gupta >: > > > > > > > > From: Aman Gupta > > > > > > > > These

[FFmpeg-devel] [PATCH 2/3] avcodec/pnm_parser: Use memchr() in pnm_parse()

2019-09-09 Thread Michael Niedermayer
Fixes: Timeout (45sec -> 0.5sec) Fixes: 16942/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_PPM_fuzzer-5085393073995776 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/pnm_parser.c | 7 +++

[FFmpeg-devel] [PATCH 3/3] avcodec/vc1: Check for excessive resolution

2019-09-09 Thread Michael Niedermayer
Fixes: overflow in aspect ratio calculation Fixes: signed integer overflow: 393215 * 14594 cannot be represented in type 'int' Fixes: 15728/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WMV3IMAGE_fuzzer-5661588893204480 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz

[FFmpeg-devel] [PATCH 1/3] avcodec/hevc_cabac: Tighten the limit on k in ff_hevc_cu_qp_delta_abs()

2019-09-09 Thread Michael Niedermayer
Values larger would fail subsequent tests. Fixes: signed integer overflow: 5 + 2147483646 cannot be represented in type 'int' Fixes: 16966/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_HEVC_fuzzer-5695709549953024 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree

Re: [FFmpeg-devel] [PATCH] libavfilter/vf_drawtext: Avoid undefined behavior from GET_UTF8

2019-09-09 Thread Aaron Boushley
I'm open to suggestions of alternatives. I want sure if I could do a goto if there was no code at that location so I chose to add a log statement figuring that would be helpful if you had problems. I chose debug because previously the character was completely ignored, so didn't want to go from no

Re: [FFmpeg-devel] [PATCH, v2 2/2] lavc/vaapi_decode: recreate hw_frames_ctx for vp9 without destroy va_context

2019-09-09 Thread Mark Thompson
On 09/09/2019 16:40, Fu, Linjie wrote: >> -Original Message- >> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf >> Of Fu, Linjie >> Sent: Friday, August 30, 2019 16:05 >> To: FFmpeg development discussions and patches > de...@ffmpeg.org> >> Subject: Re: [FFmpeg-devel]

Re: [FFmpeg-devel] [PATCH] avcodec/h2645_parse: simplify memset call

2019-09-09 Thread Limin Wang
On Sat, Sep 07, 2019 at 03:55:51PM -0400, Andriy Gelman wrote: > From: Andriy Gelman > > Removed (new_size - pkt->nals_allocated) because this value is always 1 > during the call. > --- > libavcodec/h2645_parse.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/libavco

[FFmpeg-devel] [PATCH v1] avcodec/h2645_parse: fix for the realloc size

2019-09-09 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/h2645_parse.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/h2645_parse.c b/libavcodec/h2645_parse.c index 307e8643e6..403acd2ee1 100644 --- a/libavcodec/h2645_parse.c +++ b/libavcodec/h2645_parse.c @@ -4

Re: [FFmpeg-devel] [PATCH v1] avcodec/h2645_parse: fix for the realloc size

2019-09-09 Thread James Almer
On 9/9/2019 10:18 PM, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavcodec/h2645_parse.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/h2645_parse.c b/libavcodec/h2645_parse.c > index 307e8643e6..403acd2ee1 1006

[FFmpeg-devel] [PATCH] avformat/dashdec: add startNumber parser for segmentlist

2019-09-09 Thread Steven Liu
and get start_number for compute current segment number. fix ticket: 7976 Signed-off-by: Steven Liu --- libavformat/dashdec.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/libavformat/dashdec.c b/libavformat/dashdec.c index a6f75514f6..4f725ba09a 100644 --- a/lib

Re: [FFmpeg-devel] [PATCH v1] avcodec/h2645_parse: fix for the realloc size

2019-09-09 Thread Limin Wang
On Mon, Sep 09, 2019 at 10:53:53PM -0300, James Almer wrote: > On 9/9/2019 10:18 PM, lance.lmw...@gmail.com wrote: > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > libavcodec/h2645_parse.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/libavcod

Re: [FFmpeg-devel] [PATCH v1] avcodec/h2645_parse: fix for the realloc size

2019-09-09 Thread James Almer
On 9/9/2019 11:51 PM, Limin Wang wrote: > On Mon, Sep 09, 2019 at 10:53:53PM -0300, James Almer wrote: >> On 9/9/2019 10:18 PM, lance.lmw...@gmail.com wrote: >>> From: Limin Wang >>> >>> Signed-off-by: Limin Wang >>> --- >>> libavcodec/h2645_parse.c | 2 +- >>> 1 file changed, 1 insertion(+), 1

Re: [FFmpeg-devel] [PATCH v1] avcodec/h2645_parse: fix for the realloc size

2019-09-09 Thread Limin Wang
On Tue, Sep 10, 2019 at 12:03:14AM -0300, James Almer wrote: > On 9/9/2019 11:51 PM, Limin Wang wrote: > > On Mon, Sep 09, 2019 at 10:53:53PM -0300, James Almer wrote: > >> On 9/9/2019 10:18 PM, lance.lmw...@gmail.com wrote: > >>> From: Limin Wang > >>> > >>> Signed-off-by: Limin Wang > >>> --- >

[FFmpeg-devel] [PATCH v2] avcodec/h2645_parse: refine the code for better readiablity

2019-09-09 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/h2645_parse.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/libavcodec/h2645_parse.c b/libavcodec/h2645_parse.c index 307e8643e6..f077900617 100644 --- a/libavcodec/h2645_parse.c +++ b/libavcodec/h2645_pa