Re: [FFmpeg-devel] [PATCH] libavformat/mpegtsenc: fix incorrect PCR with multiple programs

2019-07-25 Thread Andreas Håkon
Ping ‐‐‐ Original Message ‐‐‐ On Monday, 22 de July de 2019 14:22, Andreas Håkon wrote: > Hi, > > Based on the discussion of my previous patch > https://patchwork.ffmpeg.org/patch/13487/ > Here I publish a first part of the patch that only addresses the PCR problem. > > This supersedes

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/assdec: undefined use of memcpy()

2019-07-25 Thread Paul B Mahol
On 7/24/19, Michael Niedermayer wrote: > Fixes: null pointer passed as argument 2, which is declared to never be null > Fixes: > 16008/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SSA_fuzzer-5650582821404672 > (this is a separate issue found in this testcase) > > Found-by: continuous fuzzing

Re: [FFmpeg-devel] Patch for IPC SHM

2019-07-25 Thread Paul B Mahol
On 7/23/19, aran.clau...@wwu.edu wrote: > From: Chad Fraleigh >> >> On 7/22/2019 11:14 AM, aran.clau...@wwu.edu wrote: >> >>> +static void rm_shmid(AVFormatContext *s) { >>> +XCBGrabContext *c = s->priv_data; >>> +if(c->shmid != -1) { >>> + shmctl(c->shmid, IPC_RMID, 0); >>> + c

[FFmpeg-devel] IRC disrupts (was: avcodec/rl2: set dimensions)

2019-07-25 Thread Nicolas George
Lynne (12019-07-23): > IRC. Each time I ask where something horrible that causes a flamewar between developers had been said, I get the same answer: IRC. I am starting to believe that the problem is IRC. Has IRC ever been useful for the development of FFmpeg? I do not know if it has, but I am p

Re: [FFmpeg-devel] [PATCH v5 1/2] lavc/mjpegdec: Decode Huffman-coded lossless JPEGs embedded in DNGs

2019-07-25 Thread Michael Niedermayer
On Wed, Jul 24, 2019 at 01:20:13PM +0300, velocit...@gmail.com wrote: > From: Nick Renieris > > Main image data in DNGs is usually comprised of tiles, each of which is a > Huffman-encoded lossless JPEG. > > Tested for ljpeg regressions with: > `ffmpeg -f lavfi -i testsrc=d=1 -vcodec ljpeg test.

[FFmpeg-devel] [PATCH v6 2/2] lavc/tiff: Decode embedded JPEGs in DNG images

2019-07-25 Thread velocityra
From: Nick Renieris Used a technique similar to lavc/tdsc.c for invoking the MJPEG decoder. This commit adds support for: - DNG tiles - DNG tile huffman lossless JPEG decoding - DNG 8-bpp ("packed" as dcraw calls it) decoding - DNG color scaling [1] - LinearizationTable tag - BlackLevel tag

[FFmpeg-devel] [PATCH v6 1/2] lavc/mjpegdec: Decode Huffman-coded lossless JPEGs embedded in DNGs

2019-07-25 Thread velocityra
From: Nick Renieris Main image data in DNGs is usually comprised of tiles, each of which is a Huffman-encoded lossless JPEG. Tested for ljpeg regressions with: `ffmpeg -f lavfi -i testsrc=d=1 -vcodec ljpeg test.avi` `ffmpeg test.avi out.avi` The modified code in ljpeg_decode_rgb_scan runs witho

Re: [FFmpeg-devel] Patch for IPC SHM

2019-07-25 Thread Moritz Barsnick
On Tue, Jul 23, 2019 at 19:23:12 +, aran.clau...@wwu.edu wrote: Some style nits for a first time contributer: > +if(c->shmid != -1) { ^ Please stick to the style "if (" (whitespace). > -id = shmget(IPC_PRIVATE, size, IPC_CREAT | 0777); > + > +id = shmget(IPC_PRIVATE, size,

Re: [FFmpeg-devel] [PATCH v6 2/2] lavc/tiff: Decode embedded JPEGs in DNG images

2019-07-25 Thread Moritz Barsnick
On Thu, Jul 25, 2019 at 15:12:53 +0300, velocit...@gmail.com wrote: Nit: > tiff_decoder_suggest="zlib lzma" > tiff_encoder_suggest="zlib" > +tiff_decoder_select="mjpeg_decoder" > truehd_decoder_select="mlp_parser" You should pair the new decoder line with the other decoder line, not place it

Re: [FFmpeg-devel] [PATCH v6 1/2] lavc/mjpegdec: Decode Huffman-coded lossless JPEGs embedded in DNGs

2019-07-25 Thread Moritz Barsnick
On Thu, Jul 25, 2019 at 15:12:52 +0300, velocit...@gmail.com wrote: > From: Nick Renieris Nit: > -if (s->nb_components != 3 && s->nb_components != 4) > +if (s->nb_components <= 0 || s->nb_components > 4) > return AVERROR_INVALIDDATA; > + > if (s->v_max != 1 || s->h_max != 1

[FFmpeg-devel] [PATCH] avcodec/adpcm: add support for 5.1 adpcm ms

2019-07-25 Thread Paul B Mahol
Hi, patches attached. 0001-avcodec-adpcm-add-support-for-5.1-ADPCM-MS.patch Description: Binary data 0002-avcodec-adpcm-reindent-after-last-commit.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org

Re: [FFmpeg-devel] [PATCH] avcodec/adpcm: add support for 5.1 adpcm ms

2019-07-25 Thread Moritz Barsnick
On Thu, Jul 25, 2019 at 16:19:19 +0200, Paul B Mahol wrote: > patches attached. > if (block_predictor > 6) { > -av_log(avctx, AV_LOG_ERROR, "ERROR: block_predictor[1] = > %d\n", > +av_log(avctx, AV_LOG_ERROR, "ERROR: block_predictor[0] = > %d\n", >

Re: [FFmpeg-devel] [PATCH] avcodec/adpcm: add support for 5.1 adpcm ms

2019-07-25 Thread Paul B Mahol
On 7/25/19, Moritz Barsnick wrote: > On Thu, Jul 25, 2019 at 16:19:19 +0200, Paul B Mahol wrote: >> patches attached. > >> if (block_predictor > 6) { >> -av_log(avctx, AV_LOG_ERROR, "ERROR: block_predictor[1] = >> %d\n", >> +av_log(avctx, AV_LOG_ERROR,

[FFmpeg-devel] AAC LC playback issue

2019-07-25 Thread Philippe Normand
hing report log for git master. Philippe ffplay started on 2019-07-25 at 16:17:05 Report written to "ffplay-20190725-161705.log" Command line: ./ffplay /tmp/SourceBuffer-1-audio-0.mp4 ffplay version N-94387-g923d5c489f-1 Copyright (c) 2003-2019 the FFmpeg developers built with gcc 8 (D

[FFmpeg-devel] [PATCH v7 1/2] lavc/mjpegdec: Decode Huffman-coded lossless JPEGs embedded in DNGs

2019-07-25 Thread velocityra
From: Nick Renieris Main image data in DNGs is usually comprised of tiles, each of which is a Huffman-encoded lossless JPEG. Tested for ljpeg regressions with: `ffmpeg -f lavfi -i testsrc=d=1 -vcodec ljpeg test.avi` `ffmpeg test.avi out.avi` The modified code in ljpeg_decode_rgb_scan runs witho

[FFmpeg-devel] [PATCH v7 2/2] lavc/tiff: Decode embedded JPEGs in DNG images

2019-07-25 Thread velocityra
From: Nick Renieris Used a technique similar to lavc/tdsc.c for invoking the MJPEG decoder. This commit adds support for: - DNG tiles - DNG tile huffman lossless JPEG decoding - DNG 8-bpp ("packed" as dcraw calls it) decoding - DNG color scaling [1] - LinearizationTable tag - BlackLevel tag

Re: [FFmpeg-devel] avcodec: add a WavPack DSD decoder

2019-07-25 Thread Lynne
Jul 25, 2019, 6:12 AM by da...@wavpack.com: >>> +    crc += (crc << 1) + code; >>> >> Don't NIH CRCs, we have av_crc in lavu. See below how to use it. >> > > It's not a standard crc, but more of a recirculating checksum, so the NIH > code is required. > Could you not call it a CRC then? "che

Re: [FFmpeg-devel] [PATCH v6 2/2] lavc/tiff: Decode embedded JPEGs in DNG images

2019-07-25 Thread Nick Renieris
Thanks for the review Moritz, pushed fixes. "outputted" is a word actually :) https://forum.wordreference.com/threads/is-outputted-a-word.2707379 Στις Πέμ, 25 Ιουλ 2019 στις 4:57 μ.μ., ο/η Moritz Barsnick έγραψε: > > On Thu, Jul 25, 2019 at 15:12:53 +0300, velocit...@gmail.com wrote: > > Nit: >

Re: [FFmpeg-devel] [PATCH] avcodec/rl2: set dimensions

2019-07-25 Thread Michael Niedermayer
On Wed, Jul 24, 2019 at 02:42:24PM +0200, Lynne wrote: > Jul 24, 2019, 11:08 AM by mich...@niedermayer.cc: > > > > > What did you expect ? IIRC you have asked for whole classes of security > > issues to be not fixed. > > > > Something like that would require a vote and majority of developers. > >

Re: [FFmpeg-devel] [PATCH] avcodec/rl2: set dimensions

2019-07-25 Thread Paul B Mahol
On 7/25/19, Michael Niedermayer wrote: > On Wed, Jul 24, 2019 at 02:42:24PM +0200, Lynne wrote: >> Jul 24, 2019, 11:08 AM by mich...@niedermayer.cc: >> >> > >> > What did you expect ? IIRC you have asked for whole classes of security >> > issues to be not fixed. >> > >> > Something like that would

Re: [FFmpeg-devel] IRC disrupts (was: avcodec/rl2: set dimensions)

2019-07-25 Thread Paul B Mahol
On 7/25/19, Nicolas George wrote: > Lynne (12019-07-23): >> IRC. > > Each time I ask where something horrible that causes a flamewar between > developers had been said, I get the same answer: IRC. > > I am starting to believe that the problem is IRC. I'm starting to believe its problem in certain

Re: [FFmpeg-devel] [PATCH] avcodec/rl2: set dimensions

2019-07-25 Thread Lynne
Jul 25, 2019, 4:47 PM by mich...@niedermayer.cc: > On Wed, Jul 24, 2019 at 02:42:24PM +0200, Lynne wrote: > >> Jul 24, 2019, 11:08 AM by mich...@niedermayer.cc: >> >> > >> > What did you expect ? IIRC you have asked for whole classes of security >> > issues to be not fixed. >> > >> > Something lik

Re: [FFmpeg-devel] [PATCH] Setup for extracting quantization parameters from encoded streams

2019-07-25 Thread Juan De León
I submitted another patch in a new email thread addressing your concerns, apologies for the confusion. The subject is "[PATCH] Extract QP from h264 encoded videos". Here is the link to the archive http://ffmpeg.org/pipermail/ffmpeg-devel/2019-July/247037.html ___

Re: [FFmpeg-devel] [PATCH] avcodec/adpcm: add support for 5.1 adpcm ms

2019-07-25 Thread Moritz Barsnick
> > This is not a reindent. ;-) > It is. Look more carefully. > You need brain to look too. Sorry, I see it now. The indent, I mean, not the brain, which is not there. Moritz ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailm

Re: [FFmpeg-devel] [PATCH] Extract QP from h264 encoded videos

2019-07-25 Thread Michael Niedermayer
On Wed, Jul 24, 2019 at 12:18:59PM -0700, Juan De León wrote: > --- > libavcodec/avcodec.h| 1 + > libavcodec/h264dec.c| 37 > libavcodec/options_table.h | 1 + > libavutil/Makefile | 2 + > libavutil/frame.h | 6 ++ >

Re: [FFmpeg-devel] [PATCH v8] Fix integer parameters size check in SDP fmtp line

2019-07-25 Thread Michael Niedermayer
On Wed, Jul 24, 2019 at 10:20:14AM +0200, Olivier Maignial wrote: > === PROBLEM === > > I was trying to record h264 + aac streams from an RTSP server to mp4 file. > using this command line: > ffmpeg -v verbose -y -i "rtsp:///my_resources" -codec copy -bsf:a > aac_adtstoasc test.mp4 > > FFmp

[FFmpeg-devel] [PATCH] lafv/wavdec: Fail bext parsing on incomplete reads

2019-07-25 Thread Matthew Wolenetz
From 7966786250d9581891e0859f769a63f35a5c2729 Mon Sep 17 00:00:00 2001 From: Matt Wolenetz Date: Thu, 25 Jul 2019 15:54:49 -0700 Subject: [PATCH] lafv/wavdec: Fail bext parsing on incomplete reads avio_read can successfully return even when less than the requested amount of input was read. wavde

Re: [FFmpeg-devel] [PATCH v7 2/2] lavc/tiff: Decode embedded JPEGs in DNG images

2019-07-25 Thread Reimar Döffinger
On 25.07.2019, at 17:35, velocit...@gmail.com wrote: > +// Lookup table lookup > +if (lut) > +value = lut[value]; As this function is in the innermost loop, doing the if here instead of having 2 different implementations is likely not ideal speed-wise. > +// Color scaling >

Re: [FFmpeg-devel] [PATCH v2] avutil/mips: Avoid instruction exception caused by gssqc1/gslqc1.

2019-07-25 Thread Reimar Döffinger
Is there a mips maintainer? otherwise: On 24.07.2019, at 08:46, Shiyou Yin wrote: > Ensure the address accesed by gssqc1/gslqc1 are 16-bits memory-aligned. > --- > libavcodec/mips/simple_idct_mmi.c | 2 +- > libavutil/mips/mmiutils.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/vp3: Check that theora is theora

2019-07-25 Thread Reimar Döffinger
On 24.07.2019, at 14:37, Michael Niedermayer wrote: > On Mon, Jul 22, 2019 at 07:07:57AM +0200, Reimar Döffinger wrote: >> >> >> On 22.07.2019, at 01:25, Michael Niedermayer wrote: >> >>> Fixes: Timeout (2min -> 100ms) >>> Fixes: >>> 15366/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_

[FFmpeg-devel] [PATCH] avcodec/vqavideo: Set video size

2019-07-25 Thread Michael Niedermayer
Fixes: out of array access Fixes: 15919/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VQA_fuzzer-5657368257363968 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/vqavideo.c | 2 +- 1 file

Re: [FFmpeg-devel] [PATCH V1 1/3] lavf/hls: remove redundancy reset_packet() after av_packet_unref()

2019-07-25 Thread myp...@gmail.com
On Thu, Jul 25, 2019 at 2:00 PM Steven Liu wrote: > > Jun Zhao 于2019年7月21日周日 下午10:55写道: > > > > From: Jun Zhao > > > > av_packet_unref have reseted the AVPacket, so don't need to call > > reset_packet after that. > > > > Signed-off-by: Jun Zhao > > --- > > libavformat/hls.c |4 > > 1

Re: [FFmpeg-devel] [PATCH V1 3/3] lavf/hls: replace the same code logic with ensure_playlist()

2019-07-25 Thread myp...@gmail.com
On Thu, Jul 25, 2019 at 2:06 PM Steven Liu wrote: > > Jun Zhao 于2019年7月21日周日 下午10:32写道: > > > > From: vacingfang > > > > Replace the same code logic with ensure_playlist(), it's will > > help reusable blocks of code. > > > > Reviewed-by: Jun Zhao > > Signed-off-by: vacingfang > > --- > > liba

[FFmpeg-devel] [PATCH v2] libavfilter: Update derain filter doc.

2019-07-25 Thread Xuewei Meng
Add the usage of tensorflow model in derain filter. Training scripts as well as scripts for tf/native model generation are provided in the repository at https://github.com/XueweiMeng/derain_filter.git. Signed-off-by: Xuewei Meng --- doc/filters.texi | 16 1 file changed, 12 inse

Re: [FFmpeg-devel] [PATCH v2] avutil/mips: Avoid instruction exception caused by gssqc1/gslqc1.

2019-07-25 Thread Shiyou Yin
>-Original Message- >From: ffmpeg-devel-boun...@ffmpeg.org [mailto:ffmpeg-devel-boun...@ffmpeg.org] >On Behalf Of >Reimar D?ffinger >Sent: Friday, July 26, 2019 7:28 AM >To: FFmpeg development discussions and patches >Subject: Re: [FFmpeg-devel] [PATCH v2] avutil/mips: Avoid instruction >

[FFmpeg-devel] [PATCH v3] avutil/mips: Avoid instruction exception caused by gssqc1/gslqc1.

2019-07-25 Thread Shiyou Yin
Ensure the address accesed by gssqc1/gslqc1 are 16-bits memory-aligned. --- libavcodec/mips/simple_idct_mmi.c | 2 +- libavutil/mips/mmiutils.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/mips/simple_idct_mmi.c b/libavcodec/mips/simple_idct_mmi.c inde

Re: [FFmpeg-devel] [PATCH] lafv/wavdec: Fail bext parsing on incomplete reads

2019-07-25 Thread Michael Niedermayer
On Thu, Jul 25, 2019 at 04:09:35PM -0700, Matthew Wolenetz wrote: > > wavdec.c | 12 +++- > 1 file changed, 7 insertions(+), 5 deletions(-) > 3e8d230a42a4a12aaf1c375f5a064924238992f9 > 0001-lafv-wavdec-Fail-bext-parsing-on-incomplete-reads.patch > From 7966786250d9581891e0859f769a63f