Re: [FFmpeg-devel] [PATCH 2/2] vaapi_encode_h265: Insert mastering display colour colume if needed

2018-04-23 Thread Xiang, Haihao
> On 20/04/18 08:27, Haihao Xiang wrote: > > '-sei xxx' is added to control SEI insertion, so far only mastering > > display colour colume is available for testing. Another patch is > > required to change mastering display settings later. > > > > Signed-off-by: Haihao Xiang > > --- > > libavcod

Re: [FFmpeg-devel] [PATCH v2 1/2] lavf: make overlay_qsv work based on framesync

2018-04-23 Thread Song, Ruiling
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of > Mark Thompson > Sent: Sunday, April 22, 2018 3:21 AM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v2 1/2] lavf: make overlay_qsv work based > on framesync > > On 03/04/

Re: [FFmpeg-devel] [PATCH] avcodec/vc1_block: simplify ac_val computation

2018-04-23 Thread Paul B Mahol
On 4/23/18, Michael Niedermayer wrote: > also fixes: runtime error: index 1456 out of bounds for type 'int16_t [16]' > > Found-by: durandal_1707 > > Signed-off-by: Michael Niedermayer > --- > libavcodec/vc1_block.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > LGTM ___

Re: [FFmpeg-devel] [PATCH 1/6] reitnerlace - tinterlace-like filter under LGPL

2018-04-23 Thread Vasile Toncu
This patch is still corrupted by your mailer, by introducing line breaks. Please attach it as a file, or use "git send-email" Moritz ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel Hello, I have a

Re: [FFmpeg-devel] fate/hap : add test for hap encoding

2018-04-23 Thread Carl Eugen Hoyos
2018-03-14 7:31 GMT+01:00, Martin Vignali : > In that case we can let the test using "none" > compression (bypass the snappy part) These tests are also broken, please fix or remove them: https://buildd.debian.org/status/fetch.php?pkg=ffmpeg&arch=i386&ver=7%3A4.0-1&stamp=152218&raw=0 ("Error 1

Re: [FFmpeg-devel] [PATCH] libavformat: add mbedTLS based TLS

2018-04-23 Thread Thomas Volkert
On 22.04.2018 20:03, Carl Eugen Hoyos wrote: > 2018-04-22 20:00 GMT+02:00, Nicolas George : >> Carl Eugen Hoyos (2018-04-22): >>> How do you detect that this is not the "current version" of mbed? >> Is it really our responsibility? > We try to always do it and I believe that allowing LGPL makes > m

Re: [FFmpeg-devel] lavf/os_support: Only compile inet_aton() if getaddrinfo() is needed

2018-04-23 Thread Carl Eugen Hoyos
2018-04-22 0:52 GMT+02:00, Reino Wijnsma : > On 16-4-2018 1:33, Carl Eugen Hoyos wrote: >> Attached patch is supposed to silence a user-reported warning when >> inet_aton() is missing but getaddrinfo() is supported. >> Untested. >> >> Please review, Carl Eugen > $ make libavformat/os_support.o > C

Re: [FFmpeg-devel] [PATCH v2 1/3] avformat/vpcc: Calculate VP9 level from Luma's Sample rate and Picture size

2018-04-23 Thread Ronald S. Bultje
Hi, On Mon, Apr 23, 2018 at 2:10 AM, Karthick J wrote: > -int level = par->level == FF_LEVEL_UNKNOWN ? 0 : par->level; > +int level = par->level == FF_LEVEL_UNKNOWN ? > +get_vp9_level(par, frame_rate) : par->level; After this change, how will I create a file without a level?

Re: [FFmpeg-devel] [PATCH] libavformat: add mbedTLS based TLS

2018-04-23 Thread Rostislav Pehlivanov
On 23 April 2018 at 10:27, Thomas Volkert wrote: > On 22.04.2018 20:03, Carl Eugen Hoyos wrote: > > 2018-04-22 20:00 GMT+02:00, Nicolas George : > >> Carl Eugen Hoyos (2018-04-22): > >>> How do you detect that this is not the "current version" of mbed? > >> Is it really our responsibility? > > We

Re: [FFmpeg-devel] [V2 PATCH 2/4] Add muxing/demuxing of RMHD

2018-04-23 Thread Carl Eugen Hoyos
2018-02-02 3:43 GMT+01:00, Thilo Borgmann : > Does not add a new demuxer anymore. Good, now please split the patches, the demuxer patches look relatively easy to review. > For the muxer I'm not sure it should be done - would require more logic to > check for valid codec ids for both cases I think

Re: [FFmpeg-devel] [V3 PATCH 3/3] Add docs and Changelog

2018-04-23 Thread Carl Eugen Hoyos
2018-04-22 23:16 GMT+02:00, Thilo Borgmann : Why is this a separate patch? Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [V3 PATCH 2/3] Add codec wrapper for librv11

2018-04-23 Thread Carl Eugen Hoyos
2018-04-22 23:16 GMT+02:00, Thilo Borgmann : > +#include Why is this include needed? Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH v2 1/3] avformat/vpcc: Calculate VP9 level from Luma's Sample rate and Picture size

2018-04-23 Thread James Almer
On 4/23/2018 8:58 AM, Ronald S. Bultje wrote: > Hi, > > On Mon, Apr 23, 2018 at 2:10 AM, Karthick J wrote: > >> -int level = par->level == FF_LEVEL_UNKNOWN ? 0 : par->level; >> +int level = par->level == FF_LEVEL_UNKNOWN ? >> +get_vp9_level(par, frame_rate) : par->level; > > >

[FFmpeg-devel] [PATCH v2] mov: Properly abide by the track's media duration

2018-04-23 Thread Derek Buitenhuis
The track's media duration from the mdhd atom takes precedence over both the stts and elst atom for calculating and setting the track's total duraion. Technically, we shouldn't be using the stts atom at all for calculating stream durations. This fixes incorrect stream and final packet durations o

Re: [FFmpeg-devel] [PATCH] Support for Ambisonics and OpusProjection* API.

2018-04-23 Thread Drew Allen
Hi Rostislav, Here is my feedback: I am sorry, I don't agree that this should be merged quite yet. First of all, the draft upon which how the channel family is interpreted (draft-ietf-codec-ambisonics-04) isn't finalized yet. What if it changes after we make a release? We can't really change it.

[FFmpeg-devel] Feeling Ecstatic for Getting selected in GSOC

2018-04-23 Thread Gagandeep Singh
Hi Guys, I am really happy for your trust in me to handle the project, and for giving me the opportunity by approving the project for GSOC. I will try to do my best for the same. Kierank and Durandal_1707, special thanks for the support throughout. Sincerely, Gagandeep Singh ___

Re: [FFmpeg-devel] [PATCH 3/5] reitnerlace - tinterlace-like filter under LGPL

2018-04-23 Thread Vasile Toncu
Hello, Here is patch 3. Please review. Thank you, Vasile >From 180d0b61ca2d835bdc58a17db07d4c79532b1b1e Mon Sep 17 00:00:00 2001 From: Vasile Toncu Date: Mon, 23 Apr 2018 18:59:52 +0300 Subject: [PATCH] Patch3 Signed-off-by: Vasile Toncu --- configure | 1 - lib

Re: [FFmpeg-devel] [PATCH 2/5] reitnerlace - tinterlace-like filter under LGPL

2018-04-23 Thread Vasile Toncu
Hello, Here is patches 2. Please review. Thank you, Vasile Toncu >From cb12fbb6de88acfb3f7f54bd83b91661063e92ff Mon Sep 17 00:00:00 2001 From: Vasile Toncu Date: Mon, 23 Apr 2018 18:10:18 +0300 Subject: [PATCH] Patch2 Signed-off-by: Vasile Toncu --- libavfilter/Makefile |

[FFmpeg-devel] libavutil/encryption_info: Allow multiple init info.

2018-04-23 Thread Jacob Trimble
While integrating my encryption info changes, I noticed a problem with the init info structs. I implemented them as side-data on the Stream. But this means there can only be one per stream. However, there can be multiple 'pssh' atoms in a single stream (e.g. for key rotation or multiple key syste

Re: [FFmpeg-devel] [PATCHv2 3/4] avutil/pixdesc: add AV_PIX_FMT_FLAG_ALPHA to AV_PIX_FMT_PAL8

2018-04-23 Thread Marton Balint
On Sun, 22 Apr 2018, wm4 wrote: On Sun, 22 Apr 2018 13:24:11 +0200 (CEST) Marton Balint wrote: On Fri, 20 Apr 2018, wm4 wrote: > On Thu, 19 Apr 2018 23:25:03 +0200 > Marton Balint wrote: > >> Signed-off-by: Marton Balint >> --- >> doc/APIchanges| 3 +++ >> libavutil/pixdes

Re: [FFmpeg-devel] [V3 PATCH 2/3] Add codec wrapper for librv11

2018-04-23 Thread Thilo Borgmann
Am 23.04.18 um 14:21 schrieb Carl Eugen Hoyos: > 2018-04-22 23:16 GMT+02:00, Thilo Borgmann : > >> +#include > > Why is this include needed? Not anymore, will remove locally. -Thilo ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg

Re: [FFmpeg-devel] [V3 PATCH 3/3] Add docs and Changelog

2018-04-23 Thread Thilo Borgmann
Am 23.04.18 um 14:18 schrieb Carl Eugen Hoyos: > 2018-04-22 23:16 GMT+02:00, Thilo Borgmann : > > Why is this a separate patch? To make the git-work a bit easier - do you want it to be merged into the others, would it be sufficient to do that before pushing? -Thilo _

Re: [FFmpeg-devel] [V3 PATCH 0/3] Codec wrapper for librv11 and RMHD muxer/demuxer

2018-04-23 Thread Thilo Borgmann
Am 23.04.18 um 03:36 schrieb James Almer: > On 4/22/2018 6:43 PM, Paul B Mahol wrote: >> On 4/22/18, Thilo Borgmann wrote: >>> Hi, >>> >>> V3 drops the MLTI part, no idea how it survived >>> 02fff499362daedcdcb0a9cdd517257843600563 on our side... >>> Also dropped audio override, could not get a sa

Re: [FFmpeg-devel] [V2 PATCH 2/4] Add muxing/demuxing of RMHD

2018-04-23 Thread Thilo Borgmann
Am 23.04.18 um 14:17 schrieb Carl Eugen Hoyos: > 2018-02-02 3:43 GMT+01:00, Thilo Borgmann : >> Does not add a new demuxer anymore. > > Good, now please split the patches, the demuxer patches > look relatively easy to review. > >> For the muxer I'm not sure it should be done - would require more

Re: [FFmpeg-devel] [V3 PATCH 1/3] Add muxing/demuxing of RMHD

2018-04-23 Thread Thilo Borgmann
Am 22.04.18 um 23:44 schrieb Paul B Mahol: > On 4/22/18, Thilo Borgmann wrote: >> -Thilo >> > > To many changes, hard to track. I assume this means you also prefer a more splitted patch? -Thilo ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org htt

[FFmpeg-devel] [PATCH 02/14] avcodec/vc1: change to using v->block instead of s->block for P frames

2018-04-23 Thread Jerome Borsboom
The new overlap smooting filter smoothes image pixels stored in v->block. Switch to v->block instead of s->block for storing decoded image pixels for P frames. Additionally, we must take incrementing *_blk_idx out of the vc1_put_signed_blocks_clamped function. Signed-off-by: Jerome Borsboom ---

[FFmpeg-devel] [PATCH 01/14] avcodec/vc1: re-implement and expand VC-1 overlap smooting

2018-04-23 Thread Jerome Borsboom
The existing implementation did overlap smoothing for progressive frames only. This rewritten version implements overlap smoothing for all applicable frame types for both progessive and frame/field-interlace. Signed-off-by: Jerome Borsboom --- This patch-set improves the VC-1 software decoder to

Re: [FFmpeg-devel] [PATCH] avcodec/vaapi: do not parse MVMODE for VC-1 interlaced frame pictures

2018-04-23 Thread Jerome Borsboom
On 29-3-2018 13:43, Jerome Borsboom wrote: > Interlaced frame pictures do not contain the MVMODE or MVMODE2 bitstream > element. Trying to parse this element and passing a nonzero value to the > hardware decoder results in small inaccuracies in the decoded picture. > > Signed-off-by: Jerome Borsbo

[FFmpeg-devel] [PATCH 03/14] avcodec/vc1: re-implement and expand VC-1 loop filtering

2018-04-23 Thread Jerome Borsboom
The existing implementation did loop filtering for progressive frames only. This rewritten version implements loop filtering for all applicable frame types for both progessive and frame/field-interlace. Signed-off-by: Jerome Borsboom --- libavcodec/vc1.h|4 + libavcodec/vc1_loopf

[FFmpeg-devel] [PATCH 05/14] avcodec/vc1: store color-difference reference field type

2018-04-23 Thread Jerome Borsboom
The loop filter for P interlace field pictures needs the reference field type. For luma, the reference field type was already available. Store the reference field type for color-difference as well. Signed-off-by: Jerome Borsboom --- libavcodec/vc1_mc.c | 8 1 file changed, 8 insertions(

[FFmpeg-devel] [PATCH 04/14] avcodec/vc1: store additional bitstream elements during MB decoding

2018-04-23 Thread Jerome Borsboom
The new loop filter needs additional MB properties to make its filtering decisions. Signed-off-by: Jerome Borsboom --- libavcodec/vc1_block.c | 58 +- libavcodec/vc1dec.c| 16 +++--- 2 files changed, 51 insertions(+), 23 deletions(-) d

[FFmpeg-devel] [PATCH 06/14] avcodec/vc1: correct ff_vc1_mbmode_intfrp

2018-04-23 Thread Jerome Borsboom
According to VC-1 spec 10.7.3.4, FIELDTX shall be set to the same type as the motion vector for zero-coded blocks. Signed-off-by: Jerome Borsboom --- libavcodec/vc1data.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavcodec/vc1data.c b/libavcodec/vc1data.c index f

[FFmpeg-devel] [PATCH 07/14] avcodec/vc1: correct ff_vc1_dqscale

2018-04-23 Thread Jerome Borsboom
According to VC-1 spec table 74, the last value in ff_vc1_dqscale should be 0x1041 instead of 0x1000. Signed-off-by: Jerome Borsboom --- libavcodec/vc1data.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/vc1data.c b/libavcodec/vc1data.c index 0df7d4d666..19f1cad4

[FFmpeg-devel] [PATCH 08/14] avcodec/vc1: implement interlaced out-of-bounds reference pixel replication

2018-04-23 Thread Jerome Borsboom
The existing implementation did out-of-bounds reference pixel replication for progressive reference frames. In interlaced reference frames both the even and odd line on the horizontal edges need to be replicated. Signed-off-by: Jerome Borsboom --- libavcodec/vc1_mc.c | 376 ++

[FFmpeg-devel] [PATCH 09/14] avcodec/vc1: re-implement vc1_put_signed_blocks_clamped

2018-04-23 Thread Jerome Borsboom
The existing implementation only used vc1_put_signed_blocks_clamped for I and BI frames. This rewritten version is also applicable to P frame both progressive and frame/field-interlace. Signed-off-by: Jerome Borsboom --- libavcodec/vc1_block.c | 116 --

[FFmpeg-devel] [PATCH 13/14] avcodec/vc1: correct AC inverse quantization scaling

2018-04-23 Thread Jerome Borsboom
HALFQP should only be added to the inverse quantizer when the block is coded with PQUANT. See 8.1.3.8 in VC-1 spec. Signed-off-by: Jerome Borsboom --- libavcodec/vc1_block.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/vc1_block.c b/libavcodec/vc1_block.c index

[FFmpeg-devel] [PATCH 11/14] avcodec/vc1: remove unused overlap smooting and loop filter

2018-04-23 Thread Jerome Borsboom
remove unused overlap smooting and loop filter Signed-off-by: Jerome Borsboom --- libavcodec/vc1.h| 3 - libavcodec/vc1_loopfilter.c | 297 2 files changed, 300 deletions(-) diff --git a/libavcodec/vc1.h b/libavcodec/vc1.h index 0dfdef7

[FFmpeg-devel] [PATCH 10/14] avcodec/vc1: add overlap smooting and loop filter for frame/field-interlace

2018-04-23 Thread Jerome Borsboom
Add previously omitted overlap smooting and loop filtering for frame/field-interlace pictures. For progressive pictures switch to the re-implemented versions of overlap smooting and loop filtering. Signed-off-by: Jerome Borsboom --- libavcodec/vc1_block.c | 111 +++--

[FFmpeg-devel] [PATCH 14/14] avcodec/vc1: correct forgotten v->blocks_off

2018-04-23 Thread Jerome Borsboom
correct forgotten v->blocks_off Signed-off-by: Jerome Borsboom --- libavcodec/vc1_pred.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/vc1_pred.c b/libavcodec/vc1_pred.c index 3a52a22bc6..de736ec775 100644 --- a/libavcodec/vc1_pred.c +++ b/libavcodec/vc1_pred.c @

[FFmpeg-devel] [PATCH 12/14] avcodec/vc1: correct mspel for field-interlace B frames

2018-04-23 Thread Jerome Borsboom
mspel indicates the use of bicubic interpolation. The check wrongly included MVMODE MV_PMODE_1MV_HPEL as using bilinear interpolation. Signed-off-by: Jerome Borsboom --- libavcodec/vc1.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/vc1.c b/libavcodec/vc1.c index

Re: [FFmpeg-devel] [PATCHv2 3/4] avutil/pixdesc: add AV_PIX_FMT_FLAG_ALPHA to AV_PIX_FMT_PAL8

2018-04-23 Thread wm4
On Mon, 23 Apr 2018 20:25:40 +0200 (CEST) Marton Balint wrote: > On Sun, 22 Apr 2018, wm4 wrote: > > > On Sun, 22 Apr 2018 13:24:11 +0200 (CEST) > > Marton Balint wrote: > > > >> On Fri, 20 Apr 2018, wm4 wrote: > >> > >> > On Thu, 19 Apr 2018 23:25:03 +0200 > >> > Marton Balint wrote: > >

Re: [FFmpeg-devel] [PATCH] libavformat: add mbedTLS based TLS

2018-04-23 Thread James Almer
On 4/23/2018 6:27 AM, Thomas Volkert wrote: > On 22.04.2018 20:03, Carl Eugen Hoyos wrote: >> 2018-04-22 20:00 GMT+02:00, Nicolas George : >>> Carl Eugen Hoyos (2018-04-22): How do you detect that this is not the "current version" of mbed? >>> Is it really our responsibility? >> We try to alwa

Re: [FFmpeg-devel] [PATCH] libavformat: add mbedTLS based TLS

2018-04-23 Thread Thomas Volkert
On 23.04.2018 14:08, Rostislav Pehlivanov wrote: > On 23 April 2018 at 10:27, Thomas Volkert wrote: > >> On 22.04.2018 20:03, Carl Eugen Hoyos wrote: >>> 2018-04-22 20:00 GMT+02:00, Nicolas George : Carl Eugen Hoyos (2018-04-22): > How do you detect that this is not the "current version"

Re: [FFmpeg-devel] [V3 PATCH 0/3] Codec wrapper for librv11 and RMHD muxer/demuxer

2018-04-23 Thread Ronald S. Bultje
Hi Thilo, not expressing specific agreement or disagreement. On Mon, Apr 23, 2018 at 2:43 PM, Thilo Borgmann wrote: > Am 23.04.18 um 03:36 schrieb James Almer: > > On 4/22/2018 6:43 PM, Paul B Mahol wrote: > >> On 4/22/18, Thilo Borgmann wrote: > >>> Hi, > >>> > >>> V3 drops the MLTI part, no

Re: [FFmpeg-devel] [PATCH] libavformat: add mbedTLS based TLS

2018-04-23 Thread Thomas Volkert
On 23.04.2018 11:27, Thomas Volkert wrote: > On 22.04.2018 20:03, Carl Eugen Hoyos wrote: >> 2018-04-22 20:00 GMT+02:00, Nicolas George : >>> Carl Eugen Hoyos (2018-04-22): How do you detect that this is not the "current version" of mbed? >>> Is it really our responsibility? >> We try to alwa

Re: [FFmpeg-devel] [PATCH] libavformat: add mbedTLS based TLS

2018-04-23 Thread wm4
On Mon, 23 Apr 2018 21:09:09 +0200 Thomas Volkert wrote: > On 23.04.2018 14:08, Rostislav Pehlivanov wrote: > > On 23 April 2018 at 10:27, Thomas Volkert wrote: > > > >> On 22.04.2018 20:03, Carl Eugen Hoyos wrote: > >>> 2018-04-22 20:00 GMT+02:00, Nicolas George : > Carl Eugen Hoyos

Re: [FFmpeg-devel] [PATCH] Support for Ambisonics and OpusProjection* API.

2018-04-23 Thread Rostislav Pehlivanov
On 23 April 2018 at 17:02, Drew Allen wrote: > We have spent the past 2 years with the draft relatively unchanged aside > from minor edits on the draft. It is headed to a working group for > finalization very soon and no one has yet raised a single issue regarding > any proposed changes that this

Re: [FFmpeg-devel] [V3 PATCH 0/3] Codec wrapper for librv11 and RMHD muxer/demuxer

2018-04-23 Thread Paul B Mahol
On 4/23/18, Thilo Borgmann wrote: > Am 23.04.18 um 03:36 schrieb James Almer: >> On 4/22/2018 6:43 PM, Paul B Mahol wrote: >>> On 4/22/18, Thilo Borgmann wrote: Hi, V3 drops the MLTI part, no idea how it survived 02fff499362daedcdcb0a9cdd517257843600563 on our side... Als

Re: [FFmpeg-devel] [PATCH] libavformat: add mbedTLS based TLS

2018-04-23 Thread Rostislav Pehlivanov
On 23 April 2018 at 20:16, Thomas Volkert wrote: > > On 23.04.2018 11:27, Thomas Volkert wrote: > > On 22.04.2018 20:03, Carl Eugen Hoyos wrote: > >> 2018-04-22 20:00 GMT+02:00, Nicolas George : > >>> Carl Eugen Hoyos (2018-04-22): > How do you detect that this is not the "current version" o

Re: [FFmpeg-devel] [V3 PATCH 0/3] Codec wrapper for librv11 and RMHD muxer/demuxer

2018-04-23 Thread Rostislav Pehlivanov
On 23 April 2018 at 20:32, Paul B Mahol wrote: > On 4/23/18, Thilo Borgmann wrote: > > Am 23.04.18 um 03:36 schrieb James Almer: > >> On 4/22/2018 6:43 PM, Paul B Mahol wrote: > >>> On 4/22/18, Thilo Borgmann wrote: > Hi, > > V3 drops the MLTI part, no idea how it survived >

Re: [FFmpeg-devel] [PATCH 08/14] avcodec/vc1: implement interlaced out-of-bounds reference pixel replication

2018-04-23 Thread Paul B Mahol
On 4/23/18, Jerome Borsboom wrote: > The existing implementation did out-of-bounds reference pixel replication > for > progressive reference frames. In interlaced reference frames both the even > and > odd line on the horizontal edges need to be replicated. > > Signed-off-by: Jerome Borsboom > --

Re: [FFmpeg-devel] [V3 PATCH 0/3] Codec wrapper for librv11 and RMHD muxer/demuxer

2018-04-23 Thread Thilo Borgmann
Hi, > not expressing specific agreement or disagreement. > > On Mon, Apr 23, 2018 at 2:43 PM, Thilo Borgmann > wrote: > >> Am 23.04.18 um 03:36 schrieb James Almer: >>> On 4/22/2018 6:43 PM, Paul B Mahol wrote: On 4/22/18, Thilo Borgmann wrote: > Hi, > > V3 drops the MLTI part

Re: [FFmpeg-devel] [V3 PATCH 0/3] Codec wrapper for librv11 and RMHD muxer/demuxer

2018-04-23 Thread Paul B Mahol
On 4/23/18, Thilo Borgmann wrote: > Hi, > >> not expressing specific agreement or disagreement. >> >> On Mon, Apr 23, 2018 at 2:43 PM, Thilo Borgmann >> wrote: >> >>> Am 23.04.18 um 03:36 schrieb James Almer: On 4/22/2018 6:43 PM, Paul B Mahol wrote: > On 4/22/18, Thilo Borgmann wrote:

Re: [FFmpeg-devel] [V3 PATCH 0/3] Codec wrapper for librv11 and RMHD muxer/demuxer

2018-04-23 Thread Thilo Borgmann
Am 23.04.18 um 22:47 schrieb Paul B Mahol: > On 4/23/18, Thilo Borgmann wrote: >> Hi, >> >>> not expressing specific agreement or disagreement. >>> >>> On Mon, Apr 23, 2018 at 2:43 PM, Thilo Borgmann >>> wrote: >>> Am 23.04.18 um 03:36 schrieb James Almer: > On 4/22/2018 6:43 PM, Paul B

Re: [FFmpeg-devel] [V3 PATCH 0/3] Codec wrapper for librv11 and RMHD muxer/demuxer

2018-04-23 Thread Paul B Mahol
On 4/23/18, Thilo Borgmann wrote: > Am 23.04.18 um 22:47 schrieb Paul B Mahol: >> On 4/23/18, Thilo Borgmann wrote: >>> Hi, >>> not expressing specific agreement or disagreement. On Mon, Apr 23, 2018 at 2:43 PM, Thilo Borgmann wrote: > Am 23.04.18 um 03:36 schrieb Ja

Re: [FFmpeg-devel] [V3 PATCH 0/3] Codec wrapper for librv11 and RMHD muxer/demuxer

2018-04-23 Thread Nicolas George
Paul B Mahol (2018-04-23): > It is big threat. Will you please give arguments instead of repeating the same things endlessly? I think I intuitively agree with your position, but as it is, you objection is worthless, and Thilo would be entitled to just ignore it. Regards, -- Nicolas George

Re: [FFmpeg-devel] [V3 PATCH 0/3] Codec wrapper for librv11 and RMHD muxer/demuxer

2018-04-23 Thread Paul B Mahol
On 4/23/18, Nicolas George wrote: > Paul B Mahol (2018-04-23): >> It is big threat. > > Will you please give arguments instead of repeating the same things > endlessly? > > I think I intuitively agree with your position, but as it is, you > objection is worthless, and Thilo would be entitled to ju

Re: [FFmpeg-devel] [V3 PATCH 0/3] Codec wrapper for librv11 and RMHD muxer/demuxer

2018-04-23 Thread Ronald S. Bultje
Hi Thilo, On Mon, Apr 23, 2018 at 4:45 PM, Thilo Borgmann wrote: > From the users perspective I don't see why we don't have wrappers for a > commercial codec. Right, that's the core thing. Why doesn't FFmpeg "promote" the use of this closed-source software? Maybe it's because some of us cont

Re: [FFmpeg-devel] [PATCH] Add system and real time to benchmarking.

2018-04-23 Thread Mark Wachsler
Ping. On Fri, Apr 20, 2018 at 4:21 PM, Mark Wachsler wrote: > The -benchmark and -benchmark_all options now show user, system, and real > time, > instead of just user time. > --- > fftools/ffmpeg.c | 50 ++-- > 1 file changed, 36 insertions(+), 14 del

Re: [FFmpeg-devel] [PATCH 1/6] reitnerlace - tinterlace-like filter under LGPL

2018-04-23 Thread Paul B Mahol
On 4/23/18, Vasile Toncu wrote: >> This patch is still corrupted by your mailer, by introducing line >> breaks. Please attach it as a file, or use "git send-email" >> >> Moritz >> ___ >> ffmpeg-devel mailing list >> ffmpeg-devel@ffmpeg.org >> http://ffmp

Re: [FFmpeg-devel] [PATCH 2/5] reitnerlace - tinterlace-like filter under LGPL

2018-04-23 Thread Paul B Mahol
On 4/23/18, Vasile Toncu wrote: > Hello, > > Here is patches 2. Please review. > > Thank you, > Vasile Toncu > Please fix those two patches. They must have proper short description. Looks like it is missing pix formats in query_formats, and thus cannot be compiled as is. ___

Re: [FFmpeg-devel] [PATCH] avcodec/vaapi: do not parse MVMODE for VC-1 interlaced frame pictures

2018-04-23 Thread Mark Thompson
On 23/04/18 19:58, Jerome Borsboom wrote: > On 29-3-2018 13:43, Jerome Borsboom wrote: >> Interlaced frame pictures do not contain the MVMODE or MVMODE2 bitstream >> element. Trying to parse this element and passing a nonzero value to the >> hardware decoder results in small inaccuracies in the dec

Re: [FFmpeg-devel] [PATCH v2 1/2] lavf: make overlay_qsv work based on framesync

2018-04-23 Thread Mark Thompson
On 23/04/18 08:22, Song, Ruiling wrote: >> -Original Message- >> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of >> Mark Thompson >> Sent: Sunday, April 22, 2018 3:21 AM >> To: ffmpeg-devel@ffmpeg.org >> Subject: Re: [FFmpeg-devel] [PATCH v2 1/2] lavf: make overlay_

Re: [FFmpeg-devel] [PATCH 1/2] cbs_h265: read/write HEVC PREFIX SEI

2018-04-23 Thread Mark Thompson
On 23/04/18 06:55, Xiang, Haihao wrote: > >> On 20/04/18 08:27, Haihao Xiang wrote: >>> Similar to cbs_h264, cbs_h265_{read, write}_nal_unit() can handle HEVC >>> prefix SEI NAL units now. Currently mastering display colour volume SEI >>> message is added only, we may add more SEI message if neede

Re: [FFmpeg-devel] [V3 PATCH 0/3] Codec wrapper for librv11 and RMHD muxer/demuxer

2018-04-23 Thread Marton Balint
On Mon, 23 Apr 2018, Ronald S. Bultje wrote: Hi Thilo, On Mon, Apr 23, 2018 at 4:45 PM, Thilo Borgmann wrote: From the users perspective I don't see why we don't have wrappers for a commercial codec. Right, that's the core thing. Why doesn't FFmpeg "promote" the use of this closed-sour

Re: [FFmpeg-devel] [PATCH 2/2] vaapi_encode_h265: Insert mastering display colour colume if needed

2018-04-23 Thread Mark Thompson
On 23/04/18 08:08, Xiang, Haihao wrote:>> On 20/04/18 08:27, Haihao Xiang wrote: >>> '-sei xxx' is added to control SEI insertion, so far only mastering >>> display colour colume is available for testing. Another patch is >>> required to change mastering display settings later. >>> >>> Signed-off-b

Re: [FFmpeg-devel] [PATCH 10/26] vaapi_encode: Choose profiles dynamically

2018-04-23 Thread Mark Thompson
On 23/04/18 03:54, Michael Niedermayer wrote: > On Sun, Apr 22, 2018 at 04:29:05PM +0100, Mark Thompson wrote: >> Previously there was one fixed choice for each codec (e.g. H.265 -> Main >> profile), and using anything else then required an explicit option from >> the user. This changes to selecti

Re: [FFmpeg-devel] [PATCH] avcodec/ffv1enc: Check that the crc + version combination is supported

2018-04-23 Thread Michael Niedermayer
On Sat, Apr 21, 2018 at 10:19:31PM +0200, Michael Niedermayer wrote: > The crc flag is only stored since version 3 thus before this crcs do not > work. We increase the version as needed same as we do with pix_fmts > > Signed-off-by: Michael Niedermayer > --- > libavcodec/ffv1enc.c | 4 > 1

Re: [FFmpeg-devel] [V3 PATCH 0/3] Codec wrapper for librv11 and RMHD muxer/demuxer

2018-04-23 Thread Hendrik Leppkes
On Tue, Apr 24, 2018 at 12:47 AM, Marton Balint wrote: > > > On Mon, 23 Apr 2018, Ronald S. Bultje wrote: > >> Hi Thilo, >> >> On Mon, Apr 23, 2018 at 4:45 PM, Thilo Borgmann >> wrote: >> >>> From the users perspective I don't see why we don't have wrappers for a >>> commercial codec. >> >> >> >>

Re: [FFmpeg-devel] [V3 PATCH 0/3] Codec wrapper for librv11 and RMHD muxer/demuxer

2018-04-23 Thread Jan Ekström
On Tue, Apr 24, 2018 at 1:47 AM, Marton Balint wrote: > > That's fine, I even understand and relate to that. However, as a user, I > utterly don't care about it, as a I user I want to use the best tool > available today, let it be free or not, open source or not. If you are > making it harder for

Re: [FFmpeg-devel] [PATCH 2/4] avfilter/avfiltergraph: fix has_alpha in pick_format

2018-04-23 Thread Michael Niedermayer
On Mon, Apr 23, 2018 at 04:50:54AM +0200, Marton Balint wrote: > > > On Mon, 23 Apr 2018, Michael Niedermayer wrote: > > >On Sun, Apr 22, 2018 at 01:44:19PM +0200, Marton Balint wrote: > >> > >> > >>On Fri, 20 Apr 2018, Michael Niedermayer wrote: > >> > >>>On Thu, Apr 19, 2018 at 09:32:19PM +020

Re: [FFmpeg-devel] [PATCH 2/4] avfilter/avfiltergraph: fix has_alpha in pick_format

2018-04-23 Thread Michael Niedermayer
On Tue, Apr 24, 2018 at 02:10:53AM +0200, Michael Niedermayer wrote: > On Mon, Apr 23, 2018 at 04:50:54AM +0200, Marton Balint wrote: > > > > > > On Mon, 23 Apr 2018, Michael Niedermayer wrote: > > > > >On Sun, Apr 22, 2018 at 01:44:19PM +0200, Marton Balint wrote: > > >> > > >> > > >>On Fri, 20

Re: [FFmpeg-devel] [V3 PATCH 0/3] Codec wrapper for librv11 and RMHD muxer/demuxer

2018-04-23 Thread Michael Niedermayer
On Mon, Apr 23, 2018 at 11:15:17PM +0200, Paul B Mahol wrote: > On 4/23/18, Nicolas George wrote: > > Paul B Mahol (2018-04-23): > >> It is big threat. > > > > Will you please give arguments instead of repeating the same things > > endlessly? > > > > I think I intuitively agree with your position,

Re: [FFmpeg-devel] [PATCH 23/26] lavc/cbs: Add JPEG support

2018-04-23 Thread James Almer
On 4/22/2018 12:29 PM, Mark Thompson wrote: > +static int cbs_jpeg_split_fragment(CodedBitstreamContext *ctx, > + CodedBitstreamFragment *frag, > + int header) > +{ > +uint8_t *unit_data; > +size_t unit_size; > +int uni

[FFmpeg-devel] [PATCH] avcodec/cbs_mpeg2: use existing buffer reference if available when splitting fragments

2018-04-23 Thread James Almer
Signed-off-by: James Almer --- libavcodec/cbs_mpeg2.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/libavcodec/cbs_mpeg2.c b/libavcodec/cbs_mpeg2.c index bfb64a0851..086d08ed64 100644 --- a/libavcodec/cbs_mpeg2.c +++ b/libavcodec/cbs_mpeg2.c @@ -146,14 +146,1

[FFmpeg-devel] [PATCH] avcodec/cbs_mpeg2: use memcpy when assembling fragments

2018-04-23 Thread James Almer
before: 419022 decicycles in assemble_fragment,2047 runs, 1 skips after: 104621 decicycles in assemble_fragment,2045 runs, 3 skips Benched with a 2 minutes long 720x480 DVD mpeg2 sample. Signed-off-by: James Almer --- libavcodec/cbs_mpeg2.c | 6 +++--- 1 file changed, 3 inser

Re: [FFmpeg-devel] [PATCH] libavformat: add mbedTLS based TLS

2018-04-23 Thread Thomas Volkert
On 23.04.2018 21:02, James Almer wrote: > On 4/23/2018 6:27 AM, Thomas Volkert wrote: >> On 22.04.2018 20:03, Carl Eugen Hoyos wrote: >>> 2018-04-22 20:00 GMT+02:00, Nicolas George : Carl Eugen Hoyos (2018-04-22): > How do you detect that this is not the "current version" of mbed? Is

Re: [FFmpeg-devel] [PATCH] libavformat: add mbedTLS based TLS

2018-04-23 Thread Thomas Volkert
On 23.04.2018 21:33, Rostislav Pehlivanov wrote: > On 23 April 2018 at 20:16, Thomas Volkert wrote: > >> On 23.04.2018 11:27, Thomas Volkert wrote: >>> On 22.04.2018 20:03, Carl Eugen Hoyos wrote: 2018-04-22 20:00 GMT+02:00, Nicolas George : > Carl Eugen Hoyos (2018-04-22): >> How do

Re: [FFmpeg-devel] [PATCH] avcodec/h264_slice: use the new SAR early when setting the decoder

2018-04-23 Thread Steve Lhomme
ping ? Le 19/01/2018 à 13:01, Steve Lhomme a écrit : If we don't do that get_format might not be called for a while and the proper SAR not used. See the sample mentioned here: https://trac.videolan.org/vlc/ticket/19435 --- libavcodec/h264_slice.c | 4 +++- 1 file changed, 3 insertions(+), 1

Re: [FFmpeg-devel] [PATCH] avcodec/h264_slice: use the new SAR early when setting the decoder

2018-04-23 Thread Hendrik Leppkes
On Fri, Jan 19, 2018 at 1:01 PM, Steve Lhomme wrote: > If we don't do that get_format might not be called for a while and the proper > SAR not used. > > See the sample mentioned here: https://trac.videolan.org/vlc/ticket/19435 > --- > libavcodec/h264_slice.c | 4 +++- > 1 file changed, 3 insertio

Re: [FFmpeg-devel] [PATCH v2 1/3] avformat/vpcc: Calculate VP9 level from Luma's Sample rate and Picture size

2018-04-23 Thread Jeyapal, Karthick
>From: "Ronald S. Bultje" >Hi, > >On Mon, Apr 23, 2018 at 2:10 AM, Karthick J wrote: >>-    int level = par->level == FF_LEVEL_UNKNOWN ? 0 : par->level; >>+    int level = par->level == FF_LEVEL_UNKNOWN ? >+        get_vp9_level(par, frame_rate) : par->level; > > >Af