Re: [FFmpeg-devel] [PATCH] Support signaling of last segment number

2018-03-23 Thread M M
Thanks. I have re-submitted the patch with changes. On Wed, Mar 21, 2018 at 1:24 PM, Carl Eugen Hoyos wrote: > 2018-03-21 16:33 GMT+01:00, sanilraut : > > > +if(pls->last_seq_no == 0){ > > Please add a space to avoid mixing styles: "if (" > We usually use "if (!pls->last_seq_no)", same abov

Re: [FFmpeg-devel] [PATCH 1/1] Add Sega FILM muxer

2018-03-23 Thread Paul B Mahol
On 3/22/18, mi...@brew.sh wrote: > From: Misty De Meo > > --- > Changelog | 1 + > libavformat/Makefile | 1 + > libavformat/allformats.c | 1 + > libavformat/segafilmenc.c | 380 > ++ > 4 files changed, 383 insertions(+) >

Re: [FFmpeg-devel] [PATCH] avfilter: add hrtfm filter

2018-03-23 Thread Paul B Mahol
On 3/22/18, Aurelien Jacobs wrote: > On Mon, Mar 19, 2018 at 10:49:28PM -0800, Lou Logan wrote: >> On Fri, Mar 16, 2018, at 11:44 AM, Paul B Mahol wrote: >> > Signed-off-by: Paul B Mahol >> > --- >> > doc/filters.texi | 60 ++ >> > libavfilter/Makefile | 1 + >> > libavfilter/

Re: [FFmpeg-devel] [PATCH v4 3/7] cmdutils: use new iteration APIs

2018-03-23 Thread Nicolas George
Josh de Kock (2018-03-22): > move lavd avinputformats and avoutputformats into lavf > > delete lavd Possibly ok in principle for me, but see below. > write new lavd aimed at actual devices There are already such libraries, we do not need another. The basic devices with a (de)muxer API are quite

Re: [FFmpeg-devel] [PATCH] lavfi: Add OpenCL avgblur filter

2018-03-23 Thread Carl Eugen Hoyos
2018-03-21 14:09 GMT+01:00, Dylan Fernando : > What information should I put in my GSoC application? How should I > structure it? Should I give a rough timeline detailing exactly which color > conversion and scaling algorithms I’ll be implementing? If so, which files > should I look at to see the

[FFmpeg-devel] [PATCH] AMF Encoder: fix issue with frame corruption if encoder connected directly to decoder

2018-03-23 Thread Kravchenko, Alexander
Hello, I am collaborating with AMD to integrate and support AMF integration FFmpeg This patch solves issue with frame corruption if encoder connected directly to decoder Solution: storing frame reference while it is used during encoding From 0fae3679bae8e121ed7b997d7eabd533deb113fb Mon Sep 17 00

Re: [FFmpeg-devel] [PATCH] AMF Encoder: fix issue with frame corruption if encoder connected directly to decoder

2018-03-23 Thread Carl Eugen Hoyos
2018-03-23 11:20 GMT+01:00, Kravchenko, Alexander : > Subject: [PATCH] AMF Encoder: fix issue with frame corruption if encoder > connected directly to decoder. Solution: storing frame reference while it > is used during encoding The commit message should start with something similar to "lavc/amf

Re: [FFmpeg-devel] [PATCH v4 3/7] cmdutils: use new iteration APIs

2018-03-23 Thread Josh de Kock
On 2018/03/23 10:05, Nicolas George wrote: Josh de Kock (2018-03-22): move lavd avinputformats and avoutputformats into lavf delete lavd Possibly ok in principle for me, but see below. I personally think this will fix a lot of the weird interactions between the two libraries, and should b

Re: [FFmpeg-devel] [PATCH] libavfilter: Add OpenCL convolution filter v0.2

2018-03-23 Thread Carl Eugen Hoyos
2018-03-22 23:52 GMT+01:00, Danil Iashchenko : > --- /dev/null > +++ b/libavfilter/opencl/convolution.cl > @@ -0,0 +1,40 @@ > +/* > + * This file is part of FFmpeg. Any reason why you don't put your name here? To state the obvious: There are now two probably qualified students that are intereste

[FFmpeg-devel] [PATCH] lavc/amfenc: Reference to input AVFrame (hwaccel) is retained during the encoding process

2018-03-23 Thread Kravchenko, Alexander
An additional reference to input AVFrame (hwaccel) is retained during the encoding process. This postpone reusing frames by decoder while they are used by encoder and prevents frame corruption Issue with frame corruption was reproduced using: ffmpeg.exe -y -hwaccel d3d11va -hwaccel_output_format

Re: [FFmpeg-devel] Type mismatch in ADPCM

2018-03-23 Thread Carlo Bramini
Hello everyone, > Il 11 marzo 2018 alle 11.42 Carl Eugen Hoyos ha scritto: > > 2018-03-11 11:27 GMT+01:00 Carlo Bramini : > > > Hello, > > I see. I expected that adding that could be considered out of the coding > > guidelines. > > You misunderstand: > The issue is not (afaict) the coding gui

Re: [FFmpeg-devel] [PATCH 0/1] Add Sega FILM muxer

2018-03-23 Thread wm4
On Thu, 22 Mar 2018 08:11:03 -0700 Misty De Meo wrote: > On Thu, Mar 22, 2018 at 3:43 AM, wm4 wrote: > > Why? > > Mainly to modify existing videos or encode new videos for Saturn > games. It's particularly useful for fan translation - to mux in new > audio, or encode new video for things like

Re: [FFmpeg-devel] [PATCH 0/1] Add Sega FILM muxer

2018-03-23 Thread Paul B Mahol
On 3/23/18, wm4 wrote: > On Thu, 22 Mar 2018 08:11:03 -0700 > Misty De Meo wrote: > >> On Thu, Mar 22, 2018 at 3:43 AM, wm4 wrote: >> > Why? >> >> Mainly to modify existing videos or encode new videos for Saturn >> games. It's particularly useful for fan translation - to mux in new >> audio, or

Re: [FFmpeg-devel] [PATCH 0/1] Add Sega FILM muxer

2018-03-23 Thread Paul B Mahol
On 3/23/18, Paul B Mahol wrote: > On 3/23/18, wm4 wrote: >> On Thu, 22 Mar 2018 08:11:03 -0700 >> Misty De Meo wrote: >> >>> On Thu, Mar 22, 2018 at 3:43 AM, wm4 wrote: >>> > Why? >>> >>> Mainly to modify existing videos or encode new videos for Saturn >>> games. It's particularly useful for fa

Re: [FFmpeg-devel] Type mismatch in ADPCM

2018-03-23 Thread Carl Eugen Hoyos
2018-03-23 12:35 GMT+01:00, Carlo Bramini : > Hello everyone, > >> Il 11 marzo 2018 alle 11.42 Carl Eugen Hoyos ha >> scritto: >> >> 2018-03-11 11:27 GMT+01:00 Carlo Bramini : >> >> > Hello, >> > I see. I expected that adding that could be considered out of the coding >> > guidelines. >> >> You mi

Re: [FFmpeg-devel] [DISCUSSION] New iteration APIs, lavf and lavd

2018-03-23 Thread Nicolas F.
Nicolas George >Your summary of the API changes is not detailed enough for somebody who >was not involved in the previous discussions. Please be more detailed >and start from scratch. Thankfully, you are always involved in every long and drawn-out discussion, which is a very handy coincidence, so

[FFmpeg-devel] [PATCH] libavfilter: Add OpenCL convolution filter v0.2: add name

2018-03-23 Thread Danil Iashchenko
Thanks, fixed! --- libavfilter/opencl/convolution.cl | 2 ++ libavfilter/vf_convolution_opencl.c | 2 ++ 2 files changed, 4 insertions(+) diff --git a/libavfilter/opencl/convolution.cl b/libavfilter/opencl/convolution.cl index aa1db97..c0748cc 100644 --- a/libavfilter/opencl/convolution.cl ++

Re: [FFmpeg-devel] [PATCH] avfilter: add hrtfm filter

2018-03-23 Thread Aurelien Jacobs
On Fri, Mar 23, 2018 at 10:18:47AM +0100, Paul B Mahol wrote: > On 3/22/18, Aurelien Jacobs wrote: > > On Mon, Mar 19, 2018 at 10:49:28PM -0800, Lou Logan wrote: > >> On Fri, Mar 16, 2018, at 11:44 AM, Paul B Mahol wrote: > >> > Signed-off-by: Paul B Mahol > >> > --- > >> > doc/filters.texi

Re: [FFmpeg-devel] [PATCH 01/11] avformat/dashenc: renamed 'min_seg_duration' to 'seg_duration'

2018-03-23 Thread Aurelien Jacobs
On Fri, Mar 23, 2018 at 02:32:30PM +0800, Steven Liu wrote: > > > > On 23 Mar 2018, at 13:20, vdi...@akamai.com wrote: > > > > From: Vishwanath Dixit > > > > --- > > doc/muxers.texi | 2 +- > > libavformat/dashenc.c | 10 +- > > 2 files changed, 6 insertions(+), 6 deletions(-) > >

Re: [FFmpeg-devel] [PATCH] libavfilter: Add OpenCL convolution filter v0.2

2018-03-23 Thread Mark Thompson
On 22/03/18 22:52, Danil Iashchenko wrote: > Hi there! > Thank you for advices, I have fixed the problem when per plane matrices > application was incorrect. Now it works as expected and behaves like the > existing vf_convolution filter. > > Tested for yuv and nv12 formats. > The following filter

Re: [FFmpeg-devel] [DISCUSSION] New iteration APIs, lavf and lavd

2018-03-23 Thread Nicolas George
Nicolas F. (2018-03-23): > Thankfully, you are always involved in every long and drawn-out > discussion, which is a very handy coincidence, so if someone has > questions about the summary of the API changes, I believe it could be > incredibly helpful if you already just went ahead and filled in > e

[FFmpeg-devel] Moving enum AVFieldOrder to libavutil?

2018-03-23 Thread Devin Heitmueller
Hello, I am in the process of reworking libavfilter to pass along the field order across links. For the moment I followed the model found in AVFrame where there are two int fields: “interlaced_frame” and “top_field_first”. However it seems like it would be more appropriate to use the enum AVF

Re: [FFmpeg-devel] [PATCH][GSoC] srcnn - an image super resolution filter using CNN

2018-03-23 Thread Pedro Arthur
Hi, It seems git refuses to apply your patch. Also as I already explained, you should multiply your bias by 255 as the weights expect the input in the range [0,1]. Please, before sending the patch make sure it works as expected for all inputs. 2018-03-22 15:42 GMT-03:00 Mina : > Hi, > This pat

[FFmpeg-devel] [PATCH] avcodec/get_bits: Document skip_bits_long()

2018-03-23 Thread Michael Niedermayer
Found-by: Kieran Signed-off-by: Michael Niedermayer --- libavcodec/get_bits.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/libavcodec/get_bits.h b/libavcodec/get_bits.h index 0c7f5ff0c6..3ec45e7ab6 100644 --- a/libavcodec/get_bits.h +++ b/libavcodec/get_bits.h @@ -201,6 +201,13 @@ s

Re: [FFmpeg-devel] [PATCH 1/1] Add Sega FILM muxer

2018-03-23 Thread Michael Niedermayer
On Wed, Mar 21, 2018 at 10:46:31PM -0700, mi...@brew.sh wrote: > From: Misty De Meo [...] > +static int film_write_header(AVFormatContext *format_context) > +{ > +int ret = 0; > +int64_t stabstart_pos, sample_table_size, stabsize, headersize; > +int8_t audio_codec; > +AVIOContext

Re: [FFmpeg-devel] [PATCH] lavf/utils.c: Don't compute start_time from DISCARD packets for video.

2018-03-23 Thread Sasi Inguva
friendly ping On Wed, Mar 21, 2018 at 2:55 PM, Michael Niedermayer wrote: > On Wed, Mar 21, 2018 at 01:35:05PM -0700, Sasi Inguva wrote: > > Attaching fate sample. > > sample uploded > > thx > > [...] > > -- > Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB > > Take away

[FFmpeg-devel] [PATCH 0/5] Add lavfi api & remove device iteration

2018-03-23 Thread Josh de Kock
This set is an alternative to the previous set I posted, it makes it so that the current behaviour is kept (devices are returned in by the iteration functions but must be loaded in manually). It is a compromise between what Nicolas George suggested and a full rewrite. I personally would like to ju

[FFmpeg-devel] [PATCH 1/5] checkasm/Makefile: add EXTRALIBS-libavformat

2018-03-23 Thread Josh de Kock
--- tests/checkasm/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/checkasm/Makefile b/tests/checkasm/Makefile index 0520e264e2..ae7e810d25 100644 --- a/tests/checkasm/Makefile +++ b/tests/checkasm/Makefile @@ -61,7 +61,7 @@ tests/checkasm/checkasm.o: CFLAGS += -

[FFmpeg-devel] [PATCH 2/5] lavfi: add new iteration API

2018-03-23 Thread Josh de Kock
--- configure| 24 +- doc/APIchanges | 4 + doc/writing_filters.txt | 6 +- libavfilter/allfilters.c | 820 +-- libavfilter/avfilter.c | 45 --- libavfilter/avfilter.h | 29 +- libavfilter/version.h| 3 + 7 fil

[FFmpeg-devel] [PATCH 5/5] cmdutils: use new APIs

2018-03-23 Thread Josh de Kock
--- fftools/cmdutils.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/fftools/cmdutils.c b/fftools/cmdutils.c index c0ddf0b287..a6cf002fd0 100644 --- a/fftools/cmdutils.c +++ b/fftools/cmdutils.c @@ -1259,8 +1259,10 @@ static int is_device(const AVClass *avcla

[FFmpeg-devel] [PATCH 4/5] lavd: remove linked lists

2018-03-23 Thread Josh de Kock
--- configure| 23 +++-- libavdevice/alldevices.c | 87 ++-- libavformat/allformats.c | 78 +-- libavformat/avformat.h | 2 ++ 4 files changed, 120 insertions(+), 70 deletions(-) diff --

[FFmpeg-devel] [PATCH 3/5] Revert "lavd: add new API for iterating input and output devices"

2018-03-23 Thread Josh de Kock
This reverts commit 0fd475704e871ef3a535947596a012894bae3cbd. Revert "lavd: fix iterating of input and output devices" This reverts commit ce1d77a5e7cebce11074bf6f9e38ad6da37338ff. --- Makefile | 3 +- configure| 23 +++--- doc/APIchanges | 5 -- li

Re: [FFmpeg-devel] [PATCH] avcodec/get_bits: Document skip_bits_long()

2018-03-23 Thread Thilo Borgmann
Am 23.03.18 um 20:20 schrieb Michael Niedermayer: > Found-by: Kieran > Signed-off-by: Michael Niedermayer > --- > libavcodec/get_bits.h | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/libavcodec/get_bits.h b/libavcodec/get_bits.h > index 0c7f5ff0c6..3ec45e7ab6 100644 > --- a/liba

Re: [FFmpeg-devel] Reimbursement request

2018-03-23 Thread Thilo Borgmann
Am 18.03.18 um 20:57 schrieb Thilo Borgmann: > Hi, > >> As already discussed, FFmpeg was present on Chemnitzer Linux Tage, in >> addition, Thilo and I went to Brussels for FOSDEM where we attended >> the talks in the multimedia room kindly (co-) organized by Kieran and >> answered some questions.

[FFmpeg-devel] [PATCH] avcodec/bsf: make sure the AVBSFInternal stored packet is reference counted

2018-03-23 Thread James Almer
Some bitstream filters may buffer said packet in their own contexts for latter use. The documentation for av_bsf_send_packet() doesn't forbid feeding it non-reference counted packets, which depending on the way said packets were internally buffered by the bsf it may result in the data described in

Re: [FFmpeg-devel] [PATCH] avcodec/bsf: make sure the AVBSFInternal stored packet is reference counted

2018-03-23 Thread Paul B Mahol
On 3/23/18, James Almer wrote: > Some bitstream filters may buffer said packet in their own contexts > for latter use. > The documentation for av_bsf_send_packet() doesn't forbid feeding > it non-reference counted packets, which depending on the way said > packets were internally buffered by the b

[FFmpeg-devel] [PATCH 2/2] hlsenc: set target duration always exact or longer than max segment duration

2018-03-23 Thread Jan Ekström
From: Jan Ekström Follows the RFC with floating point durations. F.ex., 5.005 => 6 Signed-off-by: Jan Ekström --- libavformat/hlsenc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index 07569dbff1..ecb581acb9 100644 --- a/lib

[FFmpeg-devel] [PATCH 1/2] hlsenc: use stream's maximum bit rate as fall-back advertised rate

2018-03-23 Thread Jan Ekström
From: Jan Ekström Enables having proper bit rate values being written into the master playlist in case of hard-constrained VBR where the maximum bit rate utilized is known before hand. Does the same thing as movenc.c, for example. Signed-off-by: Jan Ekström --- libavformat/hlsenc.c | 15 +

Re: [FFmpeg-devel] [PATCH] avcodec/bsf: make sure the AVBSFInternal stored packet is reference counted

2018-03-23 Thread wm4
On Fri, 23 Mar 2018 18:38:22 -0300 James Almer wrote: > Some bitstream filters may buffer said packet in their own contexts > for latter use. > The documentation for av_bsf_send_packet() doesn't forbid feeding > it non-reference counted packets, which depending on the way said > packets were inte

Re: [FFmpeg-devel] [PATCH] avcodec/bsf: make sure the AVBSFInternal stored packet is reference counted

2018-03-23 Thread James Almer
On 3/23/2018 7:46 PM, wm4 wrote: > On Fri, 23 Mar 2018 18:38:22 -0300 > James Almer wrote: > >> Some bitstream filters may buffer said packet in their own contexts >> for latter use. >> The documentation for av_bsf_send_packet() doesn't forbid feeding >> it non-reference counted packets, which de

Re: [FFmpeg-devel] [PATCH 2/5] lavfi: add new iteration API

2018-03-23 Thread Michael Niedermayer
On Fri, Mar 23, 2018 at 08:48:16PM +, Josh de Kock wrote: > --- > configure| 24 +- > doc/APIchanges | 4 + > doc/writing_filters.txt | 6 +- > libavfilter/allfilters.c | 820 > +-- > libavfilter/avfilter.c | 45 --

Re: [FFmpeg-devel] [PATCH] avfilter: add hrtfm filter

2018-03-23 Thread Michael Niedermayer
On Fri, Mar 23, 2018 at 02:45:06PM +0100, Aurelien Jacobs wrote: > On Fri, Mar 23, 2018 at 10:18:47AM +0100, Paul B Mahol wrote: > > On 3/22/18, Aurelien Jacobs wrote: > > > On Mon, Mar 19, 2018 at 10:49:28PM -0800, Lou Logan wrote: > > >> On Fri, Mar 16, 2018, at 11:44 AM, Paul B Mahol wrote: > >

Re: [FFmpeg-devel] [PATCH] avfilter: add hrtfm filter

2018-03-23 Thread Lou Logan
On Tue, Mar 20, 2018, at 1:20 AM, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > doc/filters.texi | 66 ++ > libavfilter/Makefile | 1 + > libavfilter/af_hrtfm.c | 557 > +++ > libavfilter/allfilters.c | 1 + > 4 files

Re: [FFmpeg-devel] Moving enum AVFieldOrder to libavutil?

2018-03-23 Thread Marton Balint
On Fri, 23 Mar 2018, Devin Heitmueller wrote: Hello, I am in the process of reworking libavfilter to pass along the field order across links. For the moment I followed the model found in AVFrame where there are two int fields: “interlaced_frame” and “top_field_first”. However it seems li

Re: [FFmpeg-devel] [PATCH] ffmpeg_filter: enable stream_loop in HWAccel transcoding.

2018-03-23 Thread Michael Niedermayer
On Wed, Mar 14, 2018 at 04:26:54PM +0800, Jun Zhao wrote: > > ffmpeg_filter.c |4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > 170327a7137d3ce26124c86525566d32c523a948 > 0001-ffmpeg_filter-enable-stream_loop-in-HWAccel-transcod.patch > From 731b6cb1f3a13fa18cfe39c1ddba92050b9996

Re: [FFmpeg-devel] [RFC] avcodec/avcodec.h: Add encryption info side data

2018-03-23 Thread Michael Niedermayer
On Mon, Jan 08, 2018 at 05:03:32PM -0800, Jacob Trimble wrote: > On Mon, Jan 8, 2018 at 11:40 AM, Jacob Trimble wrote: > >> I'd assume we'd wait with applying this until the mp4 patch that uses > >> it is reviewed. I'm fine with this patch and I think it can be pushed > >> as it is, although I jus

Re: [FFmpeg-devel] [PATCH 1/2] ffmpeg: fallback to codecpar parameters on input filter eof

2018-03-23 Thread Marton Balint
On Mon, 19 Mar 2018, Marton Balint wrote: On Mon, 19 Mar 2018, wm4 wrote: On Sun, 18 Mar 2018 20:09:08 +0100 Marton Balint wrote: Fixes ticket #6854 and the following simpler case: ffmpeg -f lavfi -i testsrc=d=1 -f lavfi -i testsrc=d=0 -filter_complex overlay -f null none [...]

Re: [FFmpeg-devel] [PATCH] lavf/utils.c: Don't compute start_time from DISCARD packets for video.

2018-03-23 Thread Michael Niedermayer
On Wed, Mar 21, 2018 at 01:36:38PM -0700, Sasi Inguva wrote: > Signed-off-by: Sasi Inguva > --- > libavformat/utils.c | 4 +++- > tests/fate/mov.mak| 10 +++- > tests/ref/fate/mov-neg-firstpts-discard | 3 +++ > .../ref/fate/mov-ne

Re: [FFmpeg-devel] [PATCH] Support signaling of last segment number

2018-03-23 Thread Michael Niedermayer
On Thu, Mar 22, 2018 at 10:14:36PM +0200, Jan Ekström wrote: > On Thu, Mar 22, 2018 at 9:51 PM, sanilraut wrote: > > Last segment indicated by mpd is not parsed. > > Example stream: > > http://dash.akamaized.net/dash264/TestCasesIOP41/LastSegmentNumber/1/manifest_last_segment_num.mpd > > > > This

Re: [FFmpeg-devel] Moving enum AVFieldOrder to libavutil?

2018-03-23 Thread Hendrik Leppkes
On Sat, Mar 24, 2018 at 1:07 AM, Marton Balint wrote: > > > On Fri, 23 Mar 2018, Devin Heitmueller wrote: > >> Hello, >> >> I am in the process of reworking libavfilter to pass along the field order >> across links. For the moment I followed the model found in AVFrame where >> there are two int f

[FFmpeg-devel] [PATCH] avcodec/get_bits: Make sure the input bitstream with padding can be addressed

2018-03-23 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavcodec/get_bits.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/get_bits.h b/libavcodec/get_bits.h index f90a06c7a5..56ef5f0cbe 100644 --- a/libavcodec/get_bits.h +++ b/libavcodec/get_bits.h @@ -32,6 +32,7 @@ #include

Re: [FFmpeg-devel] [PATCH 2/2] ffmpeg: pass reference counted packets on codec copy when possible

2018-03-23 Thread James Almer
On 3/21/2018 8:08 PM, Michael Niedermayer wrote: > On Wed, Mar 21, 2018 at 12:03:32PM -0300, James Almer wrote: >> Should prevent unnecessary copy of data in cases where new references >> to the packet are created within the muxer or a bitstream filter. >> >> Signed-off-by: James Almer >> --- >>

Re: [FFmpeg-devel] [PATCH] avcodec/bsf: make sure the AVBSFInternal stored packet is reference counted

2018-03-23 Thread James Almer
On 3/23/2018 8:15 PM, James Almer wrote: > On 3/23/2018 7:46 PM, wm4 wrote: >> On Fri, 23 Mar 2018 18:38:22 -0300 >> James Almer wrote: >> >>> Some bitstream filters may buffer said packet in their own contexts >>> for latter use. >>> The documentation for av_bsf_send_packet() doesn't forbid feedi

Re: [FFmpeg-devel] [PATCH v2] avcodec/noise_bsf: move the reference in the bsf internal buffer

2018-03-23 Thread Michael Niedermayer
On Wed, Mar 21, 2018 at 10:53:04PM -0300, James Almer wrote: > There's no need to allocate a new packet for it. > > Signed-off-by: James Almer > --- > Now using av_packet_make_writable() to make sure the packet can be > written to. > > libavcodec/noise_bsf.c | 25 + > 1

[FFmpeg-devel] [PATCH] Revert "avcodec/vp9_superframe_bsf: cache packets by creating new references rather than moving them"

2018-03-23 Thread James Almer
This reverts commit 7a02b364b68c0bf7f065f5c217fae458f0efdb8d. The packet fetched by ff_bsf_get_packet() and ff_bsf_get_packet_ref() is now guaranteed to be reference counted. --- libavcodec/vp9_superframe_bsf.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/libavcodec/vp9_

[FFmpeg-devel] [PATCH v2 2/5] lavfi: add new iteration API

2018-03-23 Thread Josh de Kock
Signed-off-by: Josh de Kock --- configure| 24 +- doc/APIchanges | 4 + doc/writing_filters.txt | 6 +- libavfilter/allfilters.c | 820 +-- libavfilter/avfilter.c | 50 +-- libavfilter/avfilter.h | 29 +- libavfilte

Re: [FFmpeg-devel] [PATCH v2] avcodec/noise_bsf: move the reference in the bsf internal buffer

2018-03-23 Thread James Almer
On 3/23/2018 10:24 PM, Michael Niedermayer wrote: > On Wed, Mar 21, 2018 at 10:53:04PM -0300, James Almer wrote: >> There's no need to allocate a new packet for it. >> >> Signed-off-by: James Almer >> --- >> Now using av_packet_make_writable() to make sure the packet can be >> written to. >> >> l

Re: [FFmpeg-devel] [PATCH] libavfilter: Add OpenCL convolution filter v0.2: add name

2018-03-23 Thread Josh de Kock
On 2018/03/23 13:22, Danil Iashchenko wrote: Thanks, fixed! --- libavfilter/opencl/convolution.cl | 2 ++ libavfilter/vf_convolution_opencl.c | 2 ++ 2 files changed, 4 insertions(+) When you update patches you should send the same patch again (yes the whole patch) with the required cha

Re: [FFmpeg-devel] [PATCH] avformat/segafilm - fix keyframe detection and set packet, flags

2018-03-23 Thread Michael Niedermayer
On Thu, Mar 22, 2018 at 11:04:21PM +0530, Gyan Doshi wrote: > Set the packet flag using constant as well. > segafilm.c |3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > d9d4db403c46a179ea93aab0d85904e7b4a831d2 > 0001-avformat-segafilm-fix-keyframe-detection-and-set-pac.patch > From

Re: [FFmpeg-devel] [PATCH] avcodec/vp9_raw_reorder: cache input packets using new references

2018-03-23 Thread James Almer
On 3/22/2018 12:05 AM, James Almer wrote: > Input packets may not be ref counted, meaning the data described in them > may be gone at any time. > > Fixes segfaults related to the above. Dropping this patch. Packets are now guaranteed to be ref counted, so there's no point for the extra alloc this

[FFmpeg-devel] [PATCH 1/1] Add Sega FILM muxer

2018-03-23 Thread misty
From: Misty De Meo --- Changelog | 1 + libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/segafilmenc.c | 377 ++ 4 files changed, 380 insertions(+) create mode 100644 libavformat/segafilmenc.c diff -

[FFmpeg-devel] [PATCH 0/1] re: Add Sega FILM muxer

2018-03-23 Thread misty
From: Misty De Meo > Just move allocation after all declarations. OK, changed. > Do you check that this condition is set in code? > > I mean, if user set codec for wrong case. Oh, good point. I thought about this, and then realized that for mono audio, there is no difference between planar and

[FFmpeg-devel] [PATCH] avcodec/trace_headers: always unref the input packet

2018-03-23 Thread James Almer
ff_cbs_read_packet() does not take ownership of it. Regression since c266049191. Signed-off-by: James Almer --- libavcodec/trace_headers_bsf.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/libavcodec/trace_headers_bsf.c b/libavcodec/trace_headers_bsf.c index 94a3e

Re: [FFmpeg-devel] [PATCH] avcodec/trace_headers: always unref the input packet

2018-03-23 Thread James Almer
On 3/24/2018 1:02 AM, James Almer wrote: > ff_cbs_read_packet() does not take ownership of it. > > Regression since c266049191. > > Signed-off-by: James Almer > --- > libavcodec/trace_headers_bsf.c | 9 ++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/libavcodec/tra

Re: [FFmpeg-devel] [PATCH 1/2] hlsenc: use stream's maximum bit rate as fall-back advertised rate

2018-03-23 Thread Steven Liu
2018-03-24 6:42 GMT+08:00 Jan Ekström : > From: Jan Ekström > > Enables having proper bit rate values being written into the master > playlist in case of hard-constrained VBR where the maximum bit > rate utilized is known before hand. > > Does the same thing as movenc.c, for example. > > Signed-of

Re: [FFmpeg-devel] [PATCH 2/2] hlsenc: set target duration always exact or longer than max segment duration

2018-03-23 Thread Steven Liu
2018-03-24 6:42 GMT+08:00 Jan Ekström : > From: Jan Ekström > > Follows the RFC with floating point durations. > F.ex., 5.005 => 6 > > Signed-off-by: Jan Ekström > --- > libavformat/hlsenc.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/libavformat/hlsenc.c b/libavfo