On Mon, Jan 08, 2018 at 05:03:32PM -0800, Jacob Trimble wrote: > On Mon, Jan 8, 2018 at 11:40 AM, Jacob Trimble <modma...@google.com> wrote: > >> I'd assume we'd wait with applying this until the mp4 patch that uses > >> it is reviewed. I'm fine with this patch and I think it can be pushed > >> as it is, although I just noticed an APIchanges entry and minor version > >> bump is actually missing. You could add them when sending the final > >> patch set. > > > > Added APIchanges entry and version bump. > > > >> The format of teh side data should be choosen so that demuxers and encoders > >> producing it can interoperate with muxers and decoders consuming it. > > > >> Please correct me if iam wrong but if some containers can store more than > >> others, then the "other" containers would not use that extra information > >> nor > >> set it but it could still be using a compatible representation for > >> interoperability > > > > Well I guess I can do the same thing for this as for the > > frame-specific encryption info. There will be a user-friendly struct > > for accessing it and a binary format that will be stored in the side > > data. This will allow different (de)muxers to use the data in a > > generic way. > > > >> These should be checked against size, making sure the data is consistent > > > > Done. Also added addition overflow checking. > > > > On Fri, Jan 5, 2018 at 2:42 PM, James Almer <jamr...@gmail.com> wrote: > >> This being in libavutil, the two functions using AVPacket should be > >> changed to take and return a byte array instead, that the caller > >> manually either got from side data, or will afterwards adds as side data. > > > > Done. > > Noticed some bugs when integrating with my other changes.
> doc/APIchanges | 4 > libavcodec/avcodec.h | 13 + > libavutil/Makefile | 2 > libavutil/encryption_info.c | 295 > ++++++++++++++++++++++++++++++++++++++++++++ > libavutil/encryption_info.h | 200 +++++++++++++++++++++++++++++ > libavutil/version.h | 2 > 6 files changed, 515 insertions(+), 1 deletion(-) > d8243c445d7bb638a1599ca9b847674a925578b8 encryption-info-v9.patch > From 54f6666996fd8b8b8e44506739b58784e6038309 Mon Sep 17 00:00:00 2001 > From: Jacob Trimble <modma...@google.com> > Date: Tue, 5 Dec 2017 14:52:22 -0800 > Subject: [PATCH] avcodec/avcodec.h: Add encryption info side data. > > This new side-data will contain info on how a packet is encrypted. > This allows the app to handle packet decryption. will apply, as this is blocking other patches and noone seems to have objected thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Everything should be made as simple as possible, but not simpler. -- Albert Einstein
signature.asc
Description: PGP signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
