On Fri, Mar 23, 2018 at 10:18:47AM +0100, Paul B Mahol wrote: > On 3/22/18, Aurelien Jacobs <au...@gnuage.org> wrote: > > On Mon, Mar 19, 2018 at 10:49:28PM -0800, Lou Logan wrote: > >> On Fri, Mar 16, 2018, at 11:44 AM, Paul B Mahol wrote: > >> > Signed-off-by: Paul B Mahol <one...@gmail.com> > >> > --- > >> > doc/filters.texi | 60 ++++++ > >> > libavfilter/Makefile | 1 + > >> > libavfilter/af_hrtfm.c | 486 > >> > +++++++++++++++++++++++++++++++++++++++++++++++> > >> > libavfilter/allfilters.c | 1 + > >> > 4 files changed, 548 insertions(+) > >> > create mode 100644 libavfilter/af_hrtfm.c > >> > > >> > diff --git a/doc/filters.texi b/doc/filters.texi > >> > index bd43a7ac6e..c298054325 100644 > >> > --- a/doc/filters.texi > >> > +++ b/doc/filters.texi > >> > @@ -3218,6 +3218,66 @@ Change highpass width. > >> > Syntax for the command is : "@var{width}" > >> > @end table > >> > > >> > +@section hrtfm > >> > + > >> > +Apply simple Head Related Transfer Function Model to audio stream. > >> > + > >> > +hrtfm filter creates virtual loudspeakers around the user for > >> > binaural> +listening via headphones (audio formats up to 9 channels > >> > supported).> + > >> > +This is very simple implementation which does not use any HRIRs. > >> > + > >> > +It accepts the following parameters: > >> > + > >> > +@table @option > >> > +@item hradius > >> > >> You didn't like the head_radius option name suggestion? > >> > >> > +Set head radius of listener. In meters. Default value is > >> > @code{0.0891}. > >> Why meters instead of cm? > > > > Because if you want to specify centimeters, you can use the option > > like this: -hradius 8.91c > > Shouldn't it be 8.91cm?
Ideally it should yes. But currently the option system does not support units. It would be great to specify that this option is representing a length so that the parser could validate the unit and take it into account. But for now, options are unit-less numbers. You can't use "-bitrate 128kb/s", but you are instead limited to "-bitrate 128k" without specifying unit. Same for hradius for which you can use 8.91c but not 8.91cm. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel