Re: [FFmpeg-devel] [PATCH 1/2] avformat: move public AVStream fields up in the struct

2017-10-28 Thread Paul B Mahol
On 10/23/17, James Almer wrote: > Remove the silly second notice. > > Signed-off-by: James Almer > --- > libavformat/avformat.h | 65 > ++ > 1 file changed, 28 insertions(+), 37 deletions(-) > > diff --git a/libavformat/avformat.h b/libavformat/avf

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: remove limit of max tile size

2017-10-28 Thread Paul B Mahol
On 10/27/17, Nicolas George wrote: > Le sextidi 6 brumaire, an CCXXVI, Paul B Mahol a ecrit : >> Signed-off-by: Paul B Mahol >> --- >> libavfilter/vf_tile.c | 8 >> 1 file changed, 8 deletions(-) > > Nack. > > ./ffmpeg_g -lavfi testsrc2=s=2x2,tile=65536x65536,scale=1024x1024 -f > framec

Re: [FFmpeg-devel] [PATCH] avutil/frame: deprecate getters and setters for AVFrame fields

2017-10-28 Thread Paul B Mahol
On 10/28/17, James Almer wrote: > On 10/23/2017 11:13 AM, James Almer wrote: >> The fields can be accessed directly, so these are not needed anymore. >> >> Signed-off-by: James Almer >> --- >> libavutil/frame.c | 2 ++ >> libavutil/frame.h | 26 ++ >> libavutil/versi

Re: [FFmpeg-devel] [PATCH 1/2] avfilter: pass correct argument to helper function

2017-10-28 Thread Paul B Mahol
On 10/27/17, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libavfilter/avfilter.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavfilter/avfilter.c b/libavfilter/avfilter.c > index bc9e60bb85..b98b32bacb 100644 > --- a/libavfilter/avfilter.c > +++ b/liba

Re: [FFmpeg-devel] [PATCH] avfilter/zscale: fix segfault on library error

2017-10-28 Thread Paul B Mahol
On 10/28/17, Dxfhgwet wrote: > Sent with [ProtonMail](https://protonmail.com) Secure Email. I do not like how you changed return type of function to void. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-de

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: remove limit of max tile size

2017-10-28 Thread Nicolas George
Le septidi 7 brumaire, an CCXXVI, Paul B Mahol a écrit : > testsrc2 hangs here. So please rework your patch. Regards, -- Nicolas George signature.asc Description: Digital signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpe

Re: [FFmpeg-devel] [PATCH 1/2] avfilter: pass correct argument to helper function

2017-10-28 Thread Nicolas George
Le sextidi 6 brumaire, an CCXXVI, Paul B Mahol a écrit : > Signed-off-by: Paul B Mahol > --- > libavfilter/avfilter.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Give me more time to review this change. -- Nicolas George signature.asc Description: Digital signature

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: remove limit of max tile size

2017-10-28 Thread Paul B Mahol
On 10/28/17, Nicolas George wrote: > Le septidi 7 brumaire, an CCXXVI, Paul B Mahol a ecrit : >> testsrc2 hangs here. > > So please rework your patch. Why? When it hangs without using tile filter at all. Do I need to write things out of blue moon now?

Re: [FFmpeg-devel] order T-shirts

2017-10-28 Thread Thilo Borgmann
Hi, > Am 24.10.17 um 02:43 schrieb Lou Logan: >> On Sat, Oct 21, 2017, at 07:53 AM, Lou Logan wrote: >>> I'll attach the SVG file when I get back home on Monday or Tuesday. >> >> SVG attached. Let me know if you need changes or if the printer needs a >> different format. > > then we are talking a

Re: [FFmpeg-devel] [PATCH 1/2] avfilter: pass correct argument to helper function

2017-10-28 Thread Paul B Mahol
On 10/28/17, Nicolas George wrote: > Le sextidi 6 brumaire, an CCXXVI, Paul B Mahol a ecrit : >> Signed-off-by: Paul B Mahol >> --- >> libavfilter/avfilter.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > > Give me more time to review this change. No. ___

Re: [FFmpeg-devel] [PATCH 1/2] avfilter: pass correct argument to helper function

2017-10-28 Thread Nicolas George
Le septidi 7 brumaire, an CCXXVI, Paul B Mahol a écrit : > No. Yes. Sixteen hours is unacceptable. -- Nicolas George ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: remove limit of max tile size

2017-10-28 Thread Nicolas George
Le septidi 7 brumaire, an CCXXVI, Paul B Mahol a écrit : > Why? Because it is wrong. I wrote the test case by looking at your changes and finding a flaw in them. -- Nicolas George signature.asc Description: Digital signature ___ ffmpeg-devel mailin

Re: [FFmpeg-devel] [PATCH] avfilter: initial macroblock types export and visualization

2017-10-28 Thread Ronald S. Bultje
Hi, On Fri, Oct 27, 2017 at 10:14 PM, Michael Niedermayer < mich...@niedermayer.cc> wrote: > On Fri, Oct 27, 2017 at 10:03:54PM +0200, Paul B Mahol wrote: > > Signed-off-by: Paul B Mahol > > --- > > libavcodec/mpegvideo.c | 10 + > > libavfilter/vf_codecview.c | 105 +++

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: remove limit of max tile size

2017-10-28 Thread Paul B Mahol
On 10/28/17, Nicolas George wrote: > Le septidi 7 brumaire, an CCXXVI, Paul B Mahol a ecrit : >> Why? > > Because it is wrong. I wrote the test case by looking at your changes > and finding a flaw in them. No, your test is flawed. I have no longer obligations to communicate with you. Simply said

[FFmpeg-devel] fate/utvideo add test for decoding and encoding V2

2017-10-28 Thread Martin Vignali
Hello, New patch in attach, with more samples, in order to test most of the not covered case Sample can be found here https://we.tl/EV2lBmOXk0 And need to be put inside ./fate-suite/utvideo Decoding test add : - interlace median/gradient (YUV420, YUV422, YUV444, RGB) - gradient (YUV420, YUV422,

Re: [FFmpeg-devel] libavcodec/lossless_videodsp : add add_bytes AVX2

2017-10-28 Thread Martin Vignali
2017-10-25 22:54 GMT+02:00 Paul B Mahol : > On 10/25/17, Martin Vignali wrote: > > 2017-10-25 22:08 GMT+02:00 Paul B Mahol : > > > >> On 10/25/17, Martin Vignali wrote: > >> > 2017-10-25 21:53 GMT+02:00 Paul B Mahol : > >> > > >> >> On 10/25/17, Martin Vignali wrote: > >> >> > 2017-10-25 9:43 G

Re: [FFmpeg-devel] libavcodec/bswapdsp : add AVX2 for bswap_buf

2017-10-28 Thread Martin Vignali
2017-10-25 9:39 GMT+02:00 Paul B Mahol : > On 10/22/17, Martin Vignali wrote: > > Hello, > > > > In attach patch in order to add an AVX2 version for bswap_buf > > (swap uint32 in a buffer) > > > > Checkasm result (Kaby Lake 10.12) > > bswap_buf_c: 122.8 > > bswap_buf_sse2: 67.8 > > bswap_buf_ssse

Re: [FFmpeg-devel] libavcodec/blockdsp : fix comment

2017-10-28 Thread Martin Vignali
2017-10-21 22:20 GMT+02:00 Ronald S. Bultje : > Hi, > > On Sat, Oct 21, 2017 at 1:30 PM, Martin Vignali > wrote: > > > Hello, > > > > in attach patch to fix comment in blockdsp > > > > the dsp need align 32 now. > > > > lgtm. > > > > ping for apply ___

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: remove limit of max tile size

2017-10-28 Thread Clément Bœsch
On Fri, Oct 27, 2017 at 10:38:11PM +0200, Nicolas George wrote: > Le sextidi 6 brumaire, an CCXXVI, Paul B Mahol a écrit : > > Signed-off-by: Paul B Mahol > > --- > > libavfilter/vf_tile.c | 8 > > 1 file changed, 8 deletions(-) > > Nack. > > ./ffmpeg_g -lavfi testsrc2=s=2x2,tile=65536

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: remove limit of max tile size

2017-10-28 Thread Paul B Mahol
On 10/28/17, Clement Boesch wrote: > On Fri, Oct 27, 2017 at 10:38:11PM +0200, Nicolas George wrote: >> Le sextidi 6 brumaire, an CCXXVI, Paul B Mahol a ecrit : >> > Signed-off-by: Paul B Mahol >> > --- >> > libavfilter/vf_tile.c | 8 >> > 1 file changed, 8 deletions(-) >> >> Nack. >> >

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: remove limit of max tile size

2017-10-28 Thread Clément Bœsch
On Sat, Oct 28, 2017 at 02:42:26PM +0200, Paul B Mahol wrote: > On 10/28/17, Clement Boesch wrote: > > On Fri, Oct 27, 2017 at 10:38:11PM +0200, Nicolas George wrote: > >> Le sextidi 6 brumaire, an CCXXVI, Paul B Mahol a ecrit : > >> > Signed-off-by: Paul B Mahol > >> > --- > >> > libavfilter/vf

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: remove limit of max tile size

2017-10-28 Thread Paul B Mahol
On 10/28/17, Clement Boesch wrote: > On Sat, Oct 28, 2017 at 02:42:26PM +0200, Paul B Mahol wrote: >> On 10/28/17, Clement Boesch wrote: >> > On Fri, Oct 27, 2017 at 10:38:11PM +0200, Nicolas George wrote: >> >> Le sextidi 6 brumaire, an CCXXVI, Paul B Mahol a ecrit : >> >> > Signed-off-by: Paul

Re: [FFmpeg-devel] libavcodec/bswapdsp : add AVX2 for bswap_buf

2017-10-28 Thread James Darnley
On 2017-10-22 19:14, Martin Vignali wrote: > @@ -86,16 +101,20 @@ SECTION .text > > ; void ff_bswap_buf(uint32_t *dst, const uint32_t *src, int w); > %macro BSWAP32_BUF 0 > -%if cpuflag(ssse3) > +%if cpuflag(ssse3)||cpuflag(avx2) > cglobal bswap32_buf, 3,4,3 > mov r3, r1 > +%if cpufl

Re: [FFmpeg-devel] libavcodec/bswapdsp : add AVX2 for bswap_buf

2017-10-28 Thread Martin Vignali
2017-10-28 15:47 GMT+02:00 James Darnley : > On 2017-10-22 19:14, Martin Vignali wrote: > > @@ -86,16 +101,20 @@ SECTION .text > > > > ; void ff_bswap_buf(uint32_t *dst, const uint32_t *src, int w); > > %macro BSWAP32_BUF 0 > > -%if cpuflag(ssse3) > > +%if cpuflag(ssse3)||cpuflag(avx2) > > cglo

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: remove limit of max tile size

2017-10-28 Thread Paul B Mahol
On 10/28/17, Paul B Mahol wrote: > On 10/28/17, Clement Boesch wrote: >> On Sat, Oct 28, 2017 at 02:42:26PM +0200, Paul B Mahol wrote: >>> On 10/28/17, Clement Boesch wrote: >>> > On Fri, Oct 27, 2017 at 10:38:11PM +0200, Nicolas George wrote: >>> >> Le sextidi 6 brumaire, an CCXXVI, Paul B Maho

Re: [FFmpeg-devel] [PATCH] lavfi/paletteuse: fix to support transparency

2017-10-28 Thread Clément Bœsch
On Mon, Oct 23, 2017 at 07:12:57PM -0400, Bjorn Roche wrote: > This patch enables paletteuse to identify the transparency in incoming > video and tag transparent pixels on outgoing video with the correct > index from the palette. > > This requires tracking the transparency index in the palette, >

[FFmpeg-devel] libavcodec/utvideodec : remove step arg for decode plane

2017-10-28 Thread Martin Vignali
Hello, In attach a patch to remove the step arg for the decode plane func decode_plane and decode_plane10 are only call with step = 1 Martin 0002-libavcodec-utvideo-simplify-decode_plane.patch Description: Binary data ___ ffmpeg-devel mailing list f

Re: [FFmpeg-devel] libavcodec/bswapdsp : add AVX2 for bswap_buf

2017-10-28 Thread James Darnley
On 2017-10-28 16:14, Martin Vignali wrote: > 2017-10-28 15:47 GMT+02:00 James Darnley : > >> On 2017-10-22 19:14, Martin Vignali wrote: >>> @@ -86,16 +101,20 @@ SECTION .text >>> >>> ; void ff_bswap_buf(uint32_t *dst, const uint32_t *src, int w); >>> %macro BSWAP32_BUF 0 >>> -%if cpuflag(ssse3)

Re: [FFmpeg-devel] libavcodec/utvideodec : remove step arg for decode plane

2017-10-28 Thread Paul B Mahol
On 10/28/17, Martin Vignali wrote: > Hello, > > In attach a patch to remove the step arg for the decode plane func > > decode_plane and decode_plane10 are only call with step = 1 > > > Martin > lgtm ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] libavcodec/bswapdsp : add AVX2 for bswap_buf

2017-10-28 Thread Martin Vignali
> >> > > For this, i follow Henrik Gramner's code, in the discussion > > libavcodec/exr : add x86 SIMD for predictor. > > That's fine. I will look at that on my own time. I don't want to hold > up applying the patch. Would you like me to push it for you? > > > Yes please push it if you can. Than

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: remove limit of max tile size

2017-10-28 Thread Nicolas George
Le septidi 7 brumaire, an CCXXVI, Paul B Mahol a écrit : > Gonna apply this patch soonTM because of no valid reasons to block it. No, you will not. -- Nicolas George ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/list

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: remove limit of max tile size

2017-10-28 Thread Paul B Mahol
On 10/28/17, Nicolas George wrote: > Le septidi 7 brumaire, an CCXXVI, Paul B Mahol a ecrit : >> Gonna apply this patch soonTM because of no valid reasons to block it. > > No, you will not. You still have not provided valid reason to block it. testsrc2 filter hang is unrelated to my change.

Re: [FFmpeg-devel] [PATCH 1/2] avfilter: pass correct argument to helper function

2017-10-28 Thread Paul B Mahol
On 10/28/17, Nicolas George wrote: > Le septidi 7 brumaire, an CCXXVI, Paul B Mahol a ecrit : >> No. > > Yes. Sixteen hours is unacceptable. When you will retire? ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/f

[FFmpeg-devel] [PATCH] avfilter/vf_tile: remove limit of max tile size

2017-10-28 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavfilter/vf_tile.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/libavfilter/vf_tile.c b/libavfilter/vf_tile.c index 87e0b940cf..5752ca080e 100644 --- a/libavfilter/vf_tile.c +++ b/libavfilter/vf_tile.c @@ -23,6 +23,7 @@ * ti

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: remove limit of max tile size

2017-10-28 Thread Nicolas George
Le septidi 7 brumaire, an CCXXVI, Paul B Mahol a écrit : > You still have not provided valid reason to block it. Your first patch was wrong. I have observed a possible flaw in the second one. I thought I had a test case to show it, maybe I was wrong. I need to check and test. Now, I might add, if

[FFmpeg-devel] libavfilter/vsrc_testsrc : fix hang with testsrc2 and small size

2017-10-28 Thread Martin Vignali
Hello, Following another discussion, the testsrc2 filter can hang with small size Possible fix in attach Martin 0002-libavfilter-vsrc_testsrc-fix-hang-with-testsrc2-and-.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg

[FFmpeg-devel] fate/vsrc_testsrc : add fate test for testsrc2 and small size

2017-10-28 Thread Martin Vignali
Hello, Fate test for testsrc2 with small size Need to be apply after patch in discussion : libavfilter/vsrc_testsrc : fix hang with testsrc2 and small size Martin 0003-fate-vsrc_testsrc-add-test-for-testsrc2-s-2x2.patch Description: Binary data ___

Re: [FFmpeg-devel] libavfilter/vsrc_testsrc : fix hang with testsrc2 and small size

2017-10-28 Thread Nicolas George
Le septidi 7 brumaire, an CCXXVI, Martin Vignali a écrit : > Hello, > > Following another discussion, > the testsrc2 filter can hang with small size > > Possible fix in attach > > Martin > From 3eaa767833647ab8ce270e091925557543ae5d35 Mon Sep 17 00:00:00 2001 > From: Martin Vignali > Date: Sat

Re: [FFmpeg-devel] libavfilter/vsrc_testsrc : fix hang with testsrc2 and small size

2017-10-28 Thread Martin Vignali
2017-10-28 18:49 GMT+02:00 Nicolas George : > Le septidi 7 brumaire, an CCXXVI, Martin Vignali a écrit : > > Hello, > > > > Following another discussion, > > the testsrc2 filter can hang with small size > > > > Possible fix in attach > > > > Martin > > > From 3eaa767833647ab8ce270e091925557543ae5d

Re: [FFmpeg-devel] libavfilter/vsrc_testsrc : fix hang with testsrc2 and small size

2017-10-28 Thread Nicolas George
Le septidi 7 brumaire, an CCXXVI, Martin Vignali a écrit : > Don't know if there is a better way to fix it > but if the variable stay unsigned > this for loop create the problem > for (y = ymin; y < ymax - 15; y += 16) { Looks like a job for FFMAX or FFMIN to me. Regards, -- Nicolas George __

[FFmpeg-devel] libavfilter/tests/filtfmts : remove warning

2017-10-28 Thread Martin Vignali
Hello, In attach patch to fix a warning (clang os X) libavfilter/tests/filtfmts.c:145:9: warning: ignoring return value of function declared with 'warn_unused_result' attribute [-Wunused-result] ff_default_query_formats(filter_ctx); can be test with make fate-filter-pixfmts-copy

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: remove limit of max tile size

2017-10-28 Thread Paul B Mahol
On 10/28/17, Nicolas George wrote: > Le septidi 7 brumaire, an CCXXVI, Paul B Mahol a ecrit : >> You still have not provided valid reason to block it. > > Your first patch was wrong. I have observed a possible flaw in the > second one. I thought I had a test case to show it, maybe I was wrong. I >

Re: [FFmpeg-devel] [PATCH] avfilter/zscale: fix segfault on library error

2017-10-28 Thread Dxfhgwet
> Original Message >Subject: Re: [FFmpeg-devel] [PATCH] avfilter/zscale: fix segfault on library >error >Local Time: October 28, 2017 1:26 AM >UTC Time: October 28, 2017 8:26 AM >From: one...@gmail.com >To: FFmpeg development discussions and patches > >On 10/28/17, Dxfhgwet dxfhg

[FFmpeg-devel] [BUMP][PATCH] avfilter/zscale: fix memory leak

2017-10-28 Thread Dxfhgwet
Sent with [ProtonMail](https://protonmail.com) Secure Email. 0001-avfilter-zscale-fix-memory-leak.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] libavfilter/vsrc_testsrc : fix hang with testsrc2 and small size

2017-10-28 Thread Martin Vignali
2017-10-28 18:57 GMT+02:00 Nicolas George : > Le septidi 7 brumaire, an CCXXVI, Martin Vignali a écrit : > > Don't know if there is a better way to fix it > > but if the variable stay unsigned > > this for loop create the problem > > for (y = ymin; y < ymax - 15; y += 16) { > > Looks like a job fo

Re: [FFmpeg-devel] libavfilter/vsrc_testsrc : fix hang with testsrc2 and small size

2017-10-28 Thread Paul B Mahol
On 10/28/17, Martin Vignali wrote: > 2017-10-28 18:57 GMT+02:00 Nicolas George : > >> Le septidi 7 brumaire, an CCXXVI, Martin Vignali a ecrit : >> > Don't know if there is a better way to fix it >> > but if the variable stay unsigned >> > this for loop create the problem >> > for (y = ymin; y < y

Re: [FFmpeg-devel] fate/vsrc_testsrc : add fate test for testsrc2 and small size

2017-10-28 Thread Martin Vignali
2017-10-28 18:39 GMT+02:00 Martin Vignali : > Hello, > > Fate test for testsrc2 with small size > > Need to be apply after patch in discussion : > libavfilter/vsrc_testsrc : fix hang with testsrc2 and small size > > > New patch in attach with two tests one for too small height (same as the previou

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: remove limit of max tile size

2017-10-28 Thread Nicolas George
Le septidi 7 brumaire, an CCXXVI, Paul B Mahol a écrit : > I already posted another version which I will push shortly. No, you will wait until I approve the patch, since it is code that I maintain. That is how it works. Regards, -- Nicolas George __

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: remove limit of max tile size

2017-10-28 Thread Paul B Mahol
On 10/28/17, Nicolas George wrote: > Le septidi 7 brumaire, an CCXXVI, Paul B Mahol a ecrit : >> I already posted another version which I will push shortly. > > No, you will wait until I approve the patch, since it is code that I > maintain. That is how it works. No it doesn't work like that any

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: remove limit of max tile size

2017-10-28 Thread Paul B Mahol
On 10/28/17, Paul B Mahol wrote: > On 10/28/17, Nicolas George wrote: >> Le septidi 7 brumaire, an CCXXVI, Paul B Mahol a ecrit : >>> I already posted another version which I will push shortly. >> >> No, you will wait until I approve the patch, since it is code that I >> maintain. That is how it

Re: [FFmpeg-devel] [PATCH] fate: change fate-ffmpeg-attached_pics to encode to pcm_s16le

2017-10-28 Thread Michael Niedermayer
On Fri, Oct 27, 2017 at 10:54:49PM +0200, Marton Balint wrote: > Previously alac encoder was used, from a first glance I thought it is > bitexact, > but it turns out it is using floating point arithmetic as well, so probably it > is not. Fixes fate failures on mingw32/64. seems working locally on

Re: [FFmpeg-devel] [PATCH] avfilter/vf_tile: remove limit of max tile size

2017-10-28 Thread Nicolas George
Le septidi 7 brumaire, an CCXXVI, Paul B Mahol a écrit : > No it doesn't work like that any more. > > Some folks commit to maintained code by someone else without prior review. > > Why I should not be one of them? Are you trying to derail the project on purpose? Now, please behave like a civili

Re: [FFmpeg-devel] [PATCH] lavf/mov.c: Fix parsing of edit list atoms with invalid elst entry count.

2017-10-28 Thread Michael Niedermayer
On Thu, Oct 26, 2017 at 08:51:50PM -0700, Sasi Inguva wrote: > On Tue, Oct 24, 2017 at 2:48 PM, Michael Niedermayer > wrote: > > > On Mon, Oct 23, 2017 at 04:18:28PM -0700, Sasi Inguva wrote: > > > Signed-off-by: Sasi Inguva > > > --- > > > libavformat/mov.c | 15 +

Re: [FFmpeg-devel] DASH manifest conformance (was: Re: [PATCH 0/7] dashenc fixes)

2017-10-28 Thread Michael Niedermayer
On Fri, Oct 27, 2017 at 09:28:16PM +0200, Peter Große wrote: > On Thu, 26 Oct 2017 18:32:57 +0200 > Carl Eugen Hoyos wrote: > > > 2017-10-26 18:28 GMT+02:00 Peter Große : > > > On Thu, 26 Oct 2017 18:07:55 +0200 > > > Carl Eugen Hoyos wrote: > > > > > >> Did you test our dash muxer lately with

Re: [FFmpeg-devel] DASH manifest conformance (was: Re: [PATCH 0/7] dashenc fixes)

2017-10-28 Thread Carl Eugen Hoyos
2017-10-27 21:28 GMT+02:00 Peter Große : > On Thu, 26 Oct 2017 18:32:57 +0200 > Carl Eugen Hoyos wrote: > >> 2017-10-26 18:28 GMT+02:00 Peter Große : >> > On Thu, 26 Oct 2017 18:07:55 +0200 >> > Carl Eugen Hoyos wrote: >> > >> >> Did you test our dash muxer lately with some validation tool? >> >>

Re: [FFmpeg-devel] Added - HW accelerated H.264 and HEVC encoding for AMD GPUs based on AMF SDK

2017-10-28 Thread Carl Eugen Hoyos
2017-10-27 20:09 GMT+02:00 mmironov : > +const enum AVPixelFormat ff_amf_pix_fmts[] = { > +AV_PIX_FMT_NV12, > +AV_PIX_FMT_BGRA, > +AV_PIX_FMT_ARGB, > +AV_PIX_FMT_RGBA, This is wrong, your encoders do not convert transparency information, there are 32 rgb formats without alpha chan

Re: [FFmpeg-devel] [PATCH]lswr/swresample: Mention actually supported formats when erroring out

2017-10-28 Thread Carl Eugen Hoyos
2017-10-27 4:12 GMT+02:00 Michael Niedermayer : > On Thu, Oct 26, 2017 at 05:03:37PM +0200, Carl Eugen Hoyos wrote: >> Hi! >> >> Attached patch is supposed to fix ticket #6779. >> >> Please comment, Carl Eugen > >> swresample.c |4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> d66

[FFmpeg-devel] Feature suggestion for FFMPEG

2017-10-28 Thread Ben Hutchinson
FFMPEG should be able to output raw AAC audio stream, without any encapsulation, in the same way that a raw h264 video stream can be output from FFMPEG. Currently AAC audio can only be output within various container/encapsulation formats (such as MP4 or ADTS containers). If you try to output raw A

Re: [FFmpeg-devel] Feature suggestion for FFMPEG

2017-10-28 Thread Carl Eugen Hoyos
2017-10-28 14:10 GMT+02:00 Ben Hutchinson : > Currently AAC audio can only be output within various > container/encapsulation formats (such as MP4 or ADTS containers). This is not correct. Please post all usage questions on the user mailing list. Carl Eugen __

Re: [FFmpeg-devel] [PATCH] fate: change fate-ffmpeg-attached_pics to encode to pcm_s16le

2017-10-28 Thread Marton Balint
On Sat, 28 Oct 2017, Michael Niedermayer wrote: On Fri, Oct 27, 2017 at 10:54:49PM +0200, Marton Balint wrote: Previously alac encoder was used, from a first glance I thought it is bitexact, but it turns out it is using floating point arithmetic as well, so probably it is not. Fixes fate failu

[FFmpeg-devel] [RFC]lswr/rematrix: Support s32p

2017-10-28 Thread Carl Eugen Hoyos
Hi! Attached patch fixes a random testcase for ticket #6785 here but I don't know if this is the correct fix. Please review, Carl Eugen From a93b9309d74f5eadece371ee1e682d266af6cd83 Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Sat, 28 Oct 2017 22:52:02 +0200 Subject: [PATCH] lswr/rematr

Re: [FFmpeg-devel] [PATCH]lavfi/palettegen: Allow setting the background colour

2017-10-28 Thread Carl Eugen Hoyos
2017-10-17 23:42 GMT+02:00 Carl Eugen Hoyos : > Attached patch is useful in combination with the transparency patch > for paletteuse. > +{ "background", "set a background color for transparency", > OFFSET(background), AV_OPT_TYPE_COLOR, {.str="white"}, CHAR_MIN, CHAR_MAX, > FLAGS }, Locall

[FFmpeg-devel] [PATCH 2/2] ffplay: only use hardware accelerated SDL texture formats

2017-10-28 Thread Marton Balint
Typically only a small subset of the SDL texture formats are supported directly by the SDL renderer drivers, the rest is software emulated. It's better if libswscale does the format conversion to a hardware-accelerated texture format instead of SDL. This should fix video render slowdowns with some

[FFmpeg-devel] [PATCH 1/2] ffplay: create the window and the renderer before starting playback

2017-10-28 Thread Marton Balint
Signed-off-by: Marton Balint --- fftools/ffplay.c | 67 +--- 1 file changed, 35 insertions(+), 32 deletions(-) diff --git a/fftools/ffplay.c b/fftools/ffplay.c index 8e88a77820..bebc2b392b 100644 --- a/fftools/ffplay.c +++ b/fftools/ffplay.c @@

[FFmpeg-devel] libavcodec/magicyuvenc : fix warning

2017-10-28 Thread Martin Vignali
Hello, Patch in attach fix clang warning warning: suggest braces around initialization of subobject [-Wmissing-braces] PTable counts[256] = { 0 }; Martin 0001-libavcodec-magicyuvenc-fix-warning.patch Description: Binary data ___ ffmpeg-devel mai

Re: [FFmpeg-devel] lavf/img2enc: updatefirst

2017-10-28 Thread Michael Niedermayer
On Tue, Oct 24, 2017 at 12:32:43PM +0530, Gyan Doshi wrote: > The doc for image2 muxer makes mention of only the 'update' option > but the muxer contains a 'updatefirst' option as well that effects > the same behaviour. Obviously, the latter isn't a shorthand for the > former. > > Should 'updatefi

[FFmpeg-devel] libavcodec/magicyuv : remove unneed variable assignment

2017-10-28 Thread Martin Vignali
Hello, In attach patch to remove unneed variable assignment (for left and left top in gradient and median prediction) in gradient prediction : left and left top are not use in the first line(s) and doesn't depend of previous value in the rest of the slice in median prediction : left and left

Re: [FFmpeg-devel] Added - HW accelerated H.264 and HEVC encoding for AMD GPUs based on AMF SDK

2017-10-28 Thread Mark Thompson
On 27/10/17 19:09, mmironov wrote: > From b1b697aed459947cfa04bccdca0f7cfb5c8be72c Mon Sep 17 00:00:00 2001 > From: mmironov > Date: Fri, 27 Oct 2017 13:03:15 -0400 > Subject: [PATCH] Added: HW accelerated H.264 and HEVC encoding for AMD GPUs > based on AMF SDK There isn't any sense in which thi

Re: [FFmpeg-devel] [PATCH]lavfi/palettegen: Allow setting the background colour

2017-10-28 Thread Clément Bœsch
On Sat, Oct 28, 2017 at 10:57:32PM +0200, Carl Eugen Hoyos wrote: > 2017-10-17 23:42 GMT+02:00 Carl Eugen Hoyos : > > > Attached patch is useful in combination with the transparency patch > > for paletteuse. > > > +{ "background", "set a background color for transparency", > > OFFSET(backgro

Re: [FFmpeg-devel] [PATCH 1/2] ffplay: create the window and the renderer before starting playback

2017-10-28 Thread Clément Bœsch
On Sat, Oct 28, 2017 at 11:05:15PM +0200, Marton Balint wrote: > Signed-off-by: Marton Balint > --- > fftools/ffplay.c | 67 > +--- > 1 file changed, 35 insertions(+), 32 deletions(-) > Won't this prevent using ffplay without a display? Think

Re: [FFmpeg-devel] [BUMP][PATCH] avfilter/zscale: fix memory leak

2017-10-28 Thread Moritz Barsnick
On Sat, Oct 28, 2017 at 13:29:01 -0400, Dxfhgwet wrote: > From: dxfhgwet A patch should name a proper author. Whether you establish that name "dxfhgwet" used there instead of your real name is up to you, but the email address doesn't identify you at all. (This remark is also valid for your other

Re: [FFmpeg-devel] [PATCH 1/2] ffplay: create the window and the renderer before starting playback

2017-10-28 Thread Marton Balint
On Sat, 28 Oct 2017, Clément Bœsch wrote: On Sat, Oct 28, 2017 at 11:05:15PM +0200, Marton Balint wrote: Signed-off-by: Marton Balint --- fftools/ffplay.c | 67 +--- 1 file changed, 35 insertions(+), 32 deletions(-) Won't this prevent u

Re: [FFmpeg-devel] [PATCH] Fix for paletteuse to support transparency

2017-10-28 Thread Carl Eugen Hoyos
2017-10-17 23:27 GMT+02:00 Carl Eugen Hoyos : > 2017-10-17 3:16 GMT+02:00 Carl Eugen Hoyos : > Remaining comment is: > The paletteuse filter does not work correctly on big-endian The issue was yuva->rgb on big-endian, patch sent. Sorry, Carl Eugen ___

[FFmpeg-devel] [PATCH]lsws/yuv2rgb: Fix yuva2rgb32 on big-endian hardware

2017-10-28 Thread Carl Eugen Hoyos
Hi! Attached patch fixes using paletteuse with yuva input on big endian. I will push soon, Carl Eugen From 5f231955f4d09cb70b2ed6dd4229940b1b9ef910 Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Sun, 29 Oct 2017 01:40:18 +0200 Subject: [PATCH] lsws/yuv2rgb: Fix yuva2rgb32 on big endian.

Re: [FFmpeg-devel] [PATCH]lavfi/palettegen: Allow setting the background colour

2017-10-28 Thread Carl Eugen Hoyos
2017-10-28 23:50 GMT+02:00 Clément Bœsch : > On Sat, Oct 28, 2017 at 10:57:32PM +0200, Carl Eugen Hoyos wrote: >> 2017-10-17 23:42 GMT+02:00 Carl Eugen Hoyos : >> >> > Attached patch is useful in combination with the transparency patch >> > for paletteuse. >> >> > +{ "background", "set a backgr

Re: [FFmpeg-devel] [PATCH]lavfi/palettegen: Allow setting the background colour

2017-10-28 Thread James Almer
On 10/28/2017 8:47 PM, Carl Eugen Hoyos wrote: > 2017-10-28 23:50 GMT+02:00 Clément Bœsch : >> On Sat, Oct 28, 2017 at 10:57:32PM +0200, Carl Eugen Hoyos wrote: >>> 2017-10-17 23:42 GMT+02:00 Carl Eugen Hoyos : >>> Attached patch is useful in combination with the transparency patch for pa

Re: [FFmpeg-devel] [PATCH]lavfi/palettegen: Allow setting the background colour

2017-10-28 Thread Carl Eugen Hoyos
2017-10-29 2:32 GMT+02:00 James Almer : > On 10/28/2017 8:47 PM, Carl Eugen Hoyos wrote: >> +uint8_t[4] transparency_color; // background color for >> transparency > > This broke compilation Should be fixed, sorry, I was already testing yuva2rgb on BE and forgot to compile on my des

[FFmpeg-devel] [PATCH] avfilter/zscale: add explanation for error 3074

2017-10-28 Thread Dxfhgwet
Sent with [ProtonMail](https://protonmail.com) Secure Email. 0001-avfilter-zscale-add-explanation-for-error-3074.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] Fix signed integer overflow in mov_write_single_packet Detected with clang and -fsanitize=signed-integer-overflow

2017-10-28 Thread Vitaly Buka
ping On Fri, Oct 6, 2017 at 4:20 PM, Vitaly Buka wrote: > Signed-off-by: Vitaly Buka > --- > libavformat/movenc.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/libavformat/movenc.c b/libavformat/movenc.c > index 2838286141..e70500ae2c 100644 > --- a/libavformat/movenc.c > +++ b/

Re: [FFmpeg-devel] [PATCH 1/2] avformat/hlsenc: fix base_output_dirname is null when basename_size is 0 bug

2017-10-28 Thread Liu Steven
> 在 2017年10月26日,上午7:54,Steven Liu 写道: > > fix ticket id: #6777 > when use argument hls_segment_filename, the basename_size will be 0 > > Signed-off-by: Steven Liu > --- > libavformat/hlsenc.c | 16 +++- > 1 file changed, 11 insertions(+), 5 deletions(-) > > diff --git a/libavformat

Re: [FFmpeg-devel] [PATCH 1/2] avformat/hlsenc: fix missing first segment bug in fmp4 mode

2017-10-28 Thread Liu Steven
> 在 2017年10月27日,上午8:11,Steven Liu 写道: > > fix ticket id: #6776 > fix code logic error, need not check first segment. > > Signed-off-by: Steven Liu > --- > libavformat/hlsenc.c | 6 ++ > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/libavformat/hlsenc.c b/libavformat/hlse

Re: [FFmpeg-devel] [PATCH 2/2] avformat/hlsenc: reindent hlsenc code

2017-10-28 Thread Liu Steven
> 在 2017年10月27日,上午8:11,Steven Liu 写道: > > Signed-off-by: Steven Liu > --- > libavformat/hlsenc.c | 20 ++-- > 1 file changed, 10 insertions(+), 10 deletions(-) > > diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c > index 530fc11305..0ea93480a5 100644 > --- a/libavformat/