[FFmpeg-devel] [PATCH] avformat: Fix error when writing uncoded frames.

2016-01-24 Thread Matt Oliver
commit "lavf: add automatic bitstream filtering; bump version" broke the use av_interleaved_write_uncoded_frame as any input uncoded frame has an invalid packet size that will crash when av_packet_ref tries to allocate 'size' new memory. Since the packet is a temporary created within mux itself it

Re: [FFmpeg-devel] [PATCH] avfilter: add nnedi filter

2016-01-24 Thread Michael Niedermayer
On Sat, Jan 23, 2016 at 07:53:59PM +0100, Paul B Mahol wrote: > Hi, > > patch attached. > configure|1 > libavfilter/Makefile |1 > libavfilter/allfilters.c |1 > libavfilter/vf_nnedi.c | 939 > +++ > 4 files chan

Re: [FFmpeg-devel] [PATCH] avfilter: add nnedi filter

2016-01-24 Thread Paul B Mahol
On 1/24/16, Michael Niedermayer wrote: > On Sat, Jan 23, 2016 at 07:53:59PM +0100, Paul B Mahol wrote: >> Hi, >> >> patch attached. > >> configure|1 >> libavfilter/Makefile |1 >> libavfilter/allfilters.c |1 >> libavfilter/vf_nnedi.c | 939 >> +

Re: [FFmpeg-devel] [PATCH] avfilter: add nnedi filter

2016-01-24 Thread Andy Furniss
Michael Niedermayer wrote: On Sat, Jan 23, 2016 at 07:53:59PM +0100, Paul B Mahol wrote: Hi, patch attached. configure|1 libavfilter/Makefile |1 libavfilter/allfilters.c |1 libavfilter/vf_nnedi.c | 939 ++

Re: [FFmpeg-devel] [PATCH] avfilter: add nnedi filter

2016-01-24 Thread Paul B Mahol
On 1/24/16, Andy Furniss wrote: > Michael Niedermayer wrote: >> On Sat, Jan 23, 2016 at 07:53:59PM +0100, Paul B Mahol wrote: >>> Hi, >>> >>> patch attached. >> >>> configure|1 >>> libavfilter/Makefile |1 >>> libavfilter/allfilters.c |1 >>> libavfilter/vf_nn

Re: [FFmpeg-devel] [PATCH] avfilter: add nnedi filter

2016-01-24 Thread Andy Furniss
Paul B Mahol wrote: On 1/24/16, Andy Furniss wrote: Michael Niedermayer wrote: On Sat, Jan 23, 2016 at 07:53:59PM +0100, Paul B Mahol wrote: Hi, patch attached. configure|1 libavfilter/Makefile | 1 libavfilter/allfilters.c |1 libavfilter/vf_nnedi.c | 939

Re: [FFmpeg-devel] [PATCH] avformat/mpegtsenc: Fix multi program so that it supports adding the same stream to multiple programs.

2016-01-24 Thread Michael Niedermayer
On Sun, Jan 24, 2016 at 06:06:36AM +0100, Vittorio Gambaletta (VittGam) wrote: > Signed-off-by: Vittorio Gambaletta > --- > libavformat/mpegtsenc.c | 15 +-- > 1 file changed, 13 insertions(+), 2 deletions(-) > > diff --git a/libavformat/mpegtsenc.c b/libavformat/mpegtsenc.c > inde

Re: [FFmpeg-devel] [PATCH] avfilter: add nnedi filter

2016-01-24 Thread Michael Niedermayer
On Sun, Jan 24, 2016 at 10:50:37AM +0100, Paul B Mahol wrote: > On 1/24/16, Michael Niedermayer wrote: > > On Sat, Jan 23, 2016 at 07:53:59PM +0100, Paul B Mahol wrote: > >> Hi, > >> > >> patch attached. > > > >> configure|1 > >> libavfilter/Makefile |1 > >> libavfil

Re: [FFmpeg-devel] [PATCH] avformat: Document urls a bit

2016-01-24 Thread Moritz Barsnick
On Sat, Jan 23, 2016 at 00:36:51 +0100, Michael Niedermayer wrote: > libavformat/avformat.h |9 + > 1 file changed, 9 insertions(+) This will at least need some spelling fixes and commas. ;-) > + * @section urls > + * URLs in libavformat are made of a protocol a ':' and a protocol sp

Re: [FFmpeg-devel] [PATCH] ffmpeg_opt: Allow program metadata other than title to be set.

2016-01-24 Thread Michael Niedermayer
On Sun, Jan 24, 2016 at 05:23:22AM +0100, Vittorio Gambaletta (VittGam) wrote: > This commit makes it possible to add optional metadata (such as > "service_provider") to an mpegts output stream composed by multiple programs > (mpts). > > This is needed because the global metadata is not inherite

Re: [FFmpeg-devel] [PATCH 2/2] avformat: add protocol_whitelist

2016-01-24 Thread Nicolas George
Le quintidi 5 pluviôse, an CCXXIV, Michael Niedermayer a écrit : > --- a/libavformat/avio.h > +++ b/libavformat/avio.h > @@ -595,6 +595,10 @@ int avio_open(AVIOContext **s, const char *url, int > flags); > int avio_open2(AVIOContext **s, const char *url, int flags, > const AVIOInt

Re: [FFmpeg-devel] [PATCH] build: fix make checkheaders in out-of-tree builds

2016-01-24 Thread Andreas Cadhalpun
On 24.01.2016 03:19, Hendrik Leppkes wrote: > The hastly pushed fix doesn't actually work, It might not work in your environment, but it worked in Charlie's tests. > all my MSVC fate boxes are still broken, ie. > http://fatebeta.ffmpeg.org/report/x86_32-msvc14-dll-windows-native/20160123234847 T

[FFmpeg-devel] [PATCH] avfilter/vf_zoompan: do not cache all output frames in memory

2016-01-24 Thread Paul B Mahol
Hi, patch attached. Please comment. From e6a47c61473d35e952957dfd74cc4ebd5a4f181e Mon Sep 17 00:00:00 2001 From: Paul B Mahol Date: Sun, 24 Jan 2016 11:38:15 +0100 Subject: [PATCH] avfilter/vf_zoompan: rewrite so it doesn't cache all output frames Signed-off-by: Paul B Mahol --- libavfilter/

Re: [FFmpeg-devel] [PATCH] avformat: Document urls a bit

2016-01-24 Thread Michael Niedermayer
On Sun, Jan 24, 2016 at 12:28:23PM +0100, Moritz Barsnick wrote: > On Sat, Jan 23, 2016 at 00:36:51 +0100, Michael Niedermayer wrote: > > libavformat/avformat.h |9 + > > 1 file changed, 9 insertions(+) > > This will at least need some spelling fixes and commas. ;-) > > > + * @sectio

Re: [FFmpeg-devel] [PATCH v4 1/5] libavutil: VAAPI infrastructure

2016-01-24 Thread wm4
On Sat, 23 Jan 2016 16:34:45 -0800 Timothy Gu wrote: > On Sat, Jan 23, 2016 at 07:13:38PM +, Mark Thompson wrote: > > +av_log(0, AV_LOG_ERROR, "Failed to destroy surface: " > > + "%d (%s).\n", vas, vaErrorStr(vas)); > > Maybe you can consider adding an AVClass just fo

[FFmpeg-devel] [PATCH] avfilter: update some comments

2016-01-24 Thread Paul B Mahol
Hi, patch attached. From 5e1d45290115d2e865249d633ff1612877d8c0eb Mon Sep 17 00:00:00 2001 From: Paul B Mahol Date: Sun, 24 Jan 2016 13:14:26 +0100 Subject: [PATCH] avfilter: update some docs start_frame is no more, samplesref argument is now frame argument. Signed-off-by: Paul B Mahol --- li

Re: [FFmpeg-devel] [PATCH] avformat: Document urls a bit

2016-01-24 Thread Michael Niedermayer
On Sun, Jan 24, 2016 at 01:02:28PM +0100, Michael Niedermayer wrote: > On Sun, Jan 24, 2016 at 12:28:23PM +0100, Moritz Barsnick wrote: > > On Sat, Jan 23, 2016 at 00:36:51 +0100, Michael Niedermayer wrote: > > > libavformat/avformat.h |9 + > > > 1 file changed, 9 insertions(+) > > >

Re: [FFmpeg-devel] [PATCH] build: fix make checkheaders in out-of-tree builds

2016-01-24 Thread Michael Niedermayer
On Sun, Jan 24, 2016 at 12:52:37PM +0100, Andreas Cadhalpun wrote: > On 24.01.2016 03:19, Hendrik Leppkes wrote: > > The hastly pushed fix doesn't actually work, > > It might not work in your environment, but it worked in Charlie's tests. > > > all my MSVC fate boxes are still broken, ie. > > htt

Re: [FFmpeg-devel] [PATCH v4 1/5] libavutil: VAAPI infrastructure

2016-01-24 Thread wm4
On Sat, 23 Jan 2016 19:13:38 + Mark Thompson wrote: > --- > configure | 5 + > libavutil/Makefile | 1 + > libavutil/vaapi.c | 546 > + > libavutil/vaapi.h | 115 +++ > 4 files changed, 667 insertions(+) > create mo

Re: [FFmpeg-devel] [PATCH] build: fix make checkheaders in out-of-tree builds

2016-01-24 Thread Hendrik Leppkes
On Sun, Jan 24, 2016 at 12:52 PM, Andreas Cadhalpun wrote: > On 24.01.2016 03:19, Hendrik Leppkes wrote: >> The hastly pushed fix doesn't actually work, > > It might not work in your environment, but it worked in Charlie's tests. > >> all my MSVC fate boxes are still broken, ie. >> http://fatebeta

Re: [FFmpeg-devel] [PATCH v4 2/5] ffmpeg: VAAPI hwaccel helper and related initialisation

2016-01-24 Thread wm4
On Sat, 23 Jan 2016 19:14:29 + Mark Thompson wrote: > --- > Makefile | 1 + > configure | 5 + > ffmpeg.c | 6 + > ffmpeg.h | 5 + > ffmpeg_opt.c | 16 ++ > ffmpeg_vaapi.c | 633 > + > 6 files changed,

Re: [FFmpeg-devel] [PATCH] build: fix make checkheaders in out-of-tree builds

2016-01-24 Thread Derek Buitenhuis
On 1/24/2016 11:52 AM, Andreas Cadhalpun wrote: > On 24.01.2016 03:19, Hendrik Leppkes wrote: >> Lets just revert this entire batch and re-try after proper testing and >> review. > > You're very quick to suggest a revert here, but very reluctant about reverting > commit 31741ae. That's not consis

Re: [FFmpeg-devel] [PATCH 2/2] avformat: add protocol_whitelist

2016-01-24 Thread Clément Bœsch
On Sun, Jan 24, 2016 at 12:47:59PM +0100, Nicolas George wrote: > Le quintidi 5 pluviôse, an CCXXIV, Michael Niedermayer a écrit : > > --- a/libavformat/avio.h > > +++ b/libavformat/avio.h > > @@ -595,6 +595,10 @@ int avio_open(AVIOContext **s, const char *url, int > > flags); > > int avio_open2(

Re: [FFmpeg-devel] [PATCH v4 5/5] libavfilter: VAAPI surface converter

2016-01-24 Thread wm4
On Sat, 23 Jan 2016 19:17:00 + Mark Thompson wrote: > --- > configure | 2 + > libavfilter/Makefile| 1 + > libavfilter/allfilters.c| 1 + > libavfilter/vf_vaapi_conv.c | 537 > > 4 files changed, 541 insertion

Re: [FFmpeg-devel] [PATCH 2/2] avformat: add protocol_whitelist

2016-01-24 Thread wm4
On Sun, 24 Jan 2016 12:47:59 +0100 Nicolas George wrote: > Le quintidi 5 pluviôse, an CCXXIV, Michael Niedermayer a écrit : > > --- a/libavformat/avio.h > > +++ b/libavformat/avio.h > > @@ -595,6 +595,10 @@ int avio_open(AVIOContext **s, const char *url, int > > flags); > > int avio_open2(AVIOC

Re: [FFmpeg-devel] [PATCH 2/2] avformat: add protocol_whitelist

2016-01-24 Thread wm4
On Sun, 24 Jan 2016 13:43:40 +0100 Clément Bœsch wrote: > On Sun, Jan 24, 2016 at 12:47:59PM +0100, Nicolas George wrote: > > Le quintidi 5 pluviôse, an CCXXIV, Michael Niedermayer a écrit : > > > --- a/libavformat/avio.h > > > +++ b/libavformat/avio.h > > > @@ -595,6 +595,10 @@ int avio_open(A

Re: [FFmpeg-devel] [PATCH 2/2] avformat: add protocol_whitelist

2016-01-24 Thread Nicolas George
Le quintidi 5 pluviôse, an CCXXIV, Clement Boesch a écrit : > Why not an entry in the AVDictionary options? That could be a short-term solution to avoid introducing a new API with ad-hoc parameters, but AVDictionary is still based on strings exclusively, that is very unpractical for applications.

Re: [FFmpeg-devel] [PATCH v4 5/5] libavfilter: VAAPI surface converter

2016-01-24 Thread wm4
On Sat, 23 Jan 2016 16:21:04 -0800 Timothy Gu wrote: > On Sat, Jan 23, 2016 at 07:17:00PM +, Mark Thompson wrote: > > > > --- > > configure | 2 + > > libavfilter/Makefile| 1 + > > libavfilter/allfilters.c| 1 + > > libavfilter/vf_vaapi_conv.c | 537 > >

Re: [FFmpeg-devel] [PATCH] lavu: add ff_pthread_setname() and use it in various places

2016-01-24 Thread Clément Bœsch
On Wed, Jan 20, 2016 at 09:15:15PM -0300, James Almer wrote: > On 1/20/2016 7:46 PM, Clément Bœsch wrote: > > diff --git a/libavutil/thread.h b/libavutil/thread.h > > index 32ddf40..42430fb 100644 > > --- a/libavutil/thread.h > > +++ b/libavutil/thread.h > > @@ -31,6 +31,15 @@ > > #if HAVE_PTHREAD

Re: [FFmpeg-devel] [PATCH v4 1/5] libavutil: VAAPI infrastructure

2016-01-24 Thread Timo Rothenpieler
>> +void *address; >> +// On current Intel drivers, derive gives you memory which is very slow >> +// to read (uncached?). It can be better for write-only cases, but for >> +// now play it safe and never use derive. > > Still subject to debate when we introduce a "GPU memcpy". >

Re: [FFmpeg-devel] [PATCH 2/2] avformat: add protocol_whitelist

2016-01-24 Thread Clément Bœsch
On Sun, Jan 24, 2016 at 01:57:05PM +0100, wm4 wrote: > On Sun, 24 Jan 2016 13:43:40 +0100 > Clément Bœsch wrote: > > > On Sun, Jan 24, 2016 at 12:47:59PM +0100, Nicolas George wrote: > > > Le quintidi 5 pluviôse, an CCXXIV, Michael Niedermayer a écrit : > > > > --- a/libavformat/avio.h > > > >

Re: [FFmpeg-devel] [PATCH] avfilter: update some comments

2016-01-24 Thread Ronald S. Bultje
Hi, On Sun, Jan 24, 2016 at 7:17 AM, Paul B Mahol wrote: > Hi, > > patch attached. lgtm. Ronald ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] lavu: add ff_pthread_setname() and use it in various places

2016-01-24 Thread Clément Bœsch
On Thu, Jan 21, 2016 at 10:52:46AM +0100, Moritz Barsnick wrote: > On Wed, Jan 20, 2016 at 23:46:02 +0100, Clément Bœsch wrote: > > Subject: [PATCH] lavu: add ff_pthread_setname() and use it in various places > [...] > > +static inline void ff_thread_setname(const char *name) > > The commit messag

Re: [FFmpeg-devel] [PATCH] build: fix make checkheaders in out-of-tree builds

2016-01-24 Thread Ronald S. Bultje
Hi, On Sun, Jan 24, 2016 at 6:52 AM, Andreas Cadhalpun < andreas.cadhal...@googlemail.com> wrote: > Thus I object to reverting this before the regression caused by 31741ae is > fixed. This is ridiculous, I (who didn't break it and don't even have hw supporting any of our hwaccel implementatons)

Re: [FFmpeg-devel] [PATCH v4 1/5] libavutil: VAAPI infrastructure

2016-01-24 Thread wm4
On Sun, 24 Jan 2016 13:58:59 +0100 Timo Rothenpieler wrote: > >> +void *address; > >> +// On current Intel drivers, derive gives you memory which is very > >> slow > >> +// to read (uncached?). It can be better for write-only cases, but > >> for > >> +// now play it safe and ne

Re: [FFmpeg-devel] [PATCH v4 5/5] libavfilter: VAAPI surface converter

2016-01-24 Thread Mark Thompson
On 24/01/16 00:21, Timothy Gu wrote: > On Sat, Jan 23, 2016 at 07:17:00PM +, Mark Thompson wrote: >> +err = ...(...); >> +if(err) { > > err < 0? > Is there a policy on this? For functions with only zero success or error code, I would prefer to check for nonzero as error. It will c

Re: [FFmpeg-devel] [PATCH v4 5/5] libavfilter: VAAPI surface converter

2016-01-24 Thread wm4
On Sun, 24 Jan 2016 13:12:44 + Mark Thompson wrote: > On 24/01/16 00:21, Timothy Gu wrote: > > On Sat, Jan 23, 2016 at 07:17:00PM +, Mark Thompson wrote: > >> +err = ...(...); > >> +if(err) { > > > > err < 0? > > > > Is there a policy on this? > > For functions with only

Re: [FFmpeg-devel] [PATCH v4 1/5] libavutil: VAAPI infrastructure

2016-01-24 Thread Mark Thompson
On 24/01/16 00:34, Timothy Gu wrote: > On Sat, Jan 23, 2016 at 07:13:38PM +, Mark Thompson wrote: >> +av_log(0, AV_LOG_ERROR, "Failed to destroy surface: " >> + "%d (%s).\n", vas, vaErrorStr(vas)); > > Maybe you can consider adding an AVClass just for logging. Either way

Re: [FFmpeg-devel] [PATCH v4 2/5] ffmpeg: VAAPI hwaccel helper and related initialisation

2016-01-24 Thread Mark Thompson
On 24/01/16 00:43, Timothy Gu wrote: > On Sat, Jan 23, 2016 at 07:14:29PM +, Mark Thompson wrote: >> >> +#if CONFIG_VAAPI_RECENT >> +{ "vaapi", HAS_ARG, { .func_arg = opt_vaapi }, "set VAAPI hardware >> context" }, > > What is "hardware context"? The address of an AVVAAPIHardwareContext?

Re: [FFmpeg-devel] [PATCH v4 2/5] ffmpeg: VAAPI hwaccel helper and related initialisation

2016-01-24 Thread Paul B Mahol
On 1/23/16, Mark Thompson wrote: > > --- > Makefile | 1 + > configure | 5 + > ffmpeg.c | 6 + > ffmpeg.h | 5 + > ffmpeg_opt.c | 16 ++ > ffmpeg_vaapi.c | 633 > + > 6 files changed, 666 insertions(+)

Re: [FFmpeg-devel] [PATCH v4 1/5] libavutil: VAAPI infrastructure

2016-01-24 Thread Mark Thompson
On 24/01/16 12:29, wm4 wrote: > On Sat, 23 Jan 2016 19:13:38 + > Mark Thompson wrote: > >> --- >> configure | 5 + >> libavutil/Makefile | 1 + >> libavutil/vaapi.c | 546 >> + >> libavutil/vaapi.h | 115 +++ >> 4 fi

Re: [FFmpeg-devel] [PATCH 2/2] avformat: add protocol_whitelist

2016-01-24 Thread Michael Niedermayer
On Sun, Jan 24, 2016 at 12:47:59PM +0100, Nicolas George wrote: > Le quintidi 5 pluviôse, an CCXXIV, Michael Niedermayer a écrit : > > --- a/libavformat/avio.h > > +++ b/libavformat/avio.h > > @@ -595,6 +595,10 @@ int avio_open(AVIOContext **s, const char *url, int > > flags); > > int avio_open2(

Re: [FFmpeg-devel] [PATCH 2/2] avformat: add protocol_whitelist

2016-01-24 Thread Michael Niedermayer
On Sun, Jan 24, 2016 at 01:56:51PM +0100, Nicolas George wrote: > Le quintidi 5 pluviôse, an CCXXIV, Clement Boesch a écrit : > > Why not an entry in the AVDictionary options? > > That could be a short-term solution to avoid introducing a new API with > ad-hoc parameters, but AVDictionary is still

Re: [FFmpeg-devel] [PATCH v4 2/5] ffmpeg: VAAPI hwaccel helper and related initialisation

2016-01-24 Thread Mark Thompson
On 24/01/16 12:42, wm4 wrote: > On Sat, 23 Jan 2016 19:14:29 + > Mark Thompson wrote: > >> --- >> Makefile | 1 + >> configure | 5 + >> ffmpeg.c | 6 + >> ffmpeg.h | 5 + >> ffmpeg_opt.c | 16 ++ >> ffmpeg_vaapi.c | 633 >> +

Re: [FFmpeg-devel] [PATCH 2/2] avformat: add protocol_whitelist

2016-01-24 Thread Andreas Cadhalpun
On 24.01.2016 03:42, Michael Niedermayer wrote: > From: Michael Niedermayer > > TODO: Docs > TODO: version bump > > Note to maintainers: update tools > > Note, testing and checking for missing changes is needed > > Signed-off-by: Michael Niedermayer > --- > ffmpeg_opt.c

Re: [FFmpeg-devel] [PATCH v4 1/5] libavutil: VAAPI infrastructure

2016-01-24 Thread wm4
On Sun, 24 Jan 2016 13:44:47 + Mark Thompson wrote: > ... > >> + > >> +vas = vaSyncSurface(hw_ctx->display, surface->id); > > > > Is this strictly needed? (I don't know.) > > It's definitely needed in some cases - the hwaccel decoder does not call > vaSyncSurface(), so we have to s

Re: [FFmpeg-devel] [PATCH] build: fix make checkheaders in out-of-tree builds

2016-01-24 Thread Andreas Cadhalpun
On 24.01.2016 13:38, Hendrik Leppkes wrote: > On Sun, Jan 24, 2016 at 12:52 PM, Andreas Cadhalpun >> Thus I object to reverting this before the regression caused by 31741ae is >> fixed. > > So you break building of git master, and you try to leverage this to > get your own agenda forward? Serious

Re: [FFmpeg-devel] [PATCH v4 2/5] ffmpeg: VAAPI hwaccel helper and related initialisation

2016-01-24 Thread wm4
On Sun, 24 Jan 2016 14:20:54 + Mark Thompson wrote: > ... > >> +static int vaapi_get_buffer(AVCodecContext *s, AVFrame *frame, int flags) > >> +{ > >> +InputStream *ist = s->opaque; > >> +VAAPIDecoderContext *ctx = ist->hwaccel_ctx; > >> +AVFrame *new_frame; > >> + > >> +av_as

Re: [FFmpeg-devel] [PATCH] avformat/mpegtsenc: Fix multi program so that it supports adding the same stream to multiple programs.

2016-01-24 Thread Vittorio Gambaletta (VittGam)
Hi, On 24/01/2016 12:01:38 CET, Michael Niedermayer wrote: On Sun, Jan 24, 2016 at 06:06:36AM +0100, Vittorio Gambaletta (VittGam) wrote: Signed-off-by: Vittorio Gambaletta --- libavformat/mpegtsenc.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/libav

Re: [FFmpeg-devel] [PATCH] build: fix make checkheaders in out-of-tree builds

2016-01-24 Thread Andreas Cadhalpun
Hi Ronald, On 24.01.2016 14:06, Ronald S. Bultje wrote: > On Sun, Jan 24, 2016 at 6:52 AM, Andreas Cadhalpun < > andreas.cadhal...@googlemail.com> wrote: > >> Thus I object to reverting this before the regression caused by 31741ae is >> fixed. > > > This is ridiculous, I (who didn't break it an

Re: [FFmpeg-devel] [PATCH 2/2] avformat: add protocol_whitelist

2016-01-24 Thread Michael Niedermayer
On Sun, Jan 24, 2016 at 03:37:24PM +0100, Andreas Cadhalpun wrote: > On 24.01.2016 03:42, Michael Niedermayer wrote: > > From: Michael Niedermayer > > > > TODO: Docs > > TODO: version bump > > > > Note to maintainers: update tools > > > > Note, testing and checking for missing changes is needed

Re: [FFmpeg-devel] [PATCH] ffmpeg_opt: Allow program metadata other than title to be set.

2016-01-24 Thread Vittorio Gambaletta (VittGam)
Hi, On 24/01/2016 12:33:51 CET, Michael Niedermayer wrote: On Sun, Jan 24, 2016 at 05:23:22AM +0100, Vittorio Gambaletta (VittGam) wrote: This commit makes it possible to add optional metadata (such as "service_provider") to an mpegts output stream composed by multiple programs (mpts). This

Re: [FFmpeg-devel] [PATCH 2/2] avformat: add protocol_whitelist

2016-01-24 Thread Michael Niedermayer
On Sun, Jan 24, 2016 at 04:03:40PM +0100, Michael Niedermayer wrote: > On Sun, Jan 24, 2016 at 03:37:24PM +0100, Andreas Cadhalpun wrote: > > On 24.01.2016 03:42, Michael Niedermayer wrote: [...] > > > if ((ret = av_opt_set_dict(*puc, options)) < 0) > > > goto fail; > > > + > > > +

Re: [FFmpeg-devel] [PATCH] build: fix make checkheaders in out-of-tree builds

2016-01-24 Thread Hendrik Leppkes
On Sun, Jan 24, 2016 at 3:45 PM, Andreas Cadhalpun wrote: > > So here the correct path is passed to '-Fo'. > >> D:\Multimedia\ffmpeg\develop\libavdevice\alldevices.c : fatal error >> C1083: Cannot open compiler generated file: >> 'D:\Multimedia\ffmpeg\develop\D:\Multimedia\BuildEnv\MSYS2\Multimedi

Re: [FFmpeg-devel] [PATCH 1/3] common.mak: Use CCFLAGS for assembly generation as well

2016-01-24 Thread Timothy Gu
On Tue, Dec 01, 2015 at 09:46:04PM -0800, Timothy Gu wrote: > CCFLAGS is equivalent to CPPFLAGS + CFLAGS. > --- > common.mak | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Set pushed (some with improved commit messages). [...] Timothy ___ ffm

Re: [FFmpeg-devel] [PATCH] build: fix make checkheaders in out-of-tree builds

2016-01-24 Thread Andreas Cadhalpun
On 24.01.2016 16:29, Hendrik Leppkes wrote: > On Sun, Jan 24, 2016 at 3:45 PM, Andreas Cadhalpun > wrote: >> >> So here the correct path is passed to '-Fo'. >> >>> D:\Multimedia\ffmpeg\develop\libavdevice\alldevices.c : fatal error >>> C1083: Cannot open compiler generated file: >>> 'D:\Multimedia

Re: [FFmpeg-devel] [PATCH] build: fix make checkheaders in out-of-tree builds

2016-01-24 Thread Hendrik Leppkes
On Sun, Jan 24, 2016 at 4:56 PM, Andreas Cadhalpun wrote: > On 24.01.2016 16:29, Hendrik Leppkes wrote: >> On Sun, Jan 24, 2016 at 3:45 PM, Andreas Cadhalpun >> wrote: >>> >>> So here the correct path is passed to '-Fo'. >>> D:\Multimedia\ffmpeg\develop\libavdevice\alldevices.c : fatal error

Re: [FFmpeg-devel] [PATCH v4 2/5] ffmpeg: VAAPI hwaccel helper and related initialisation

2016-01-24 Thread Mark Thompson
On 24/01/16 14:52, wm4 wrote: > On Sun, 24 Jan 2016 14:20:54 + > Mark Thompson wrote: > > ... > + +new_frame = av_frame_alloc(); +if(!new_frame) +return AVERROR(ENOMEM); + +av_vaapi_surface_pool_get(&ctx->pool, new_frame); + +av

Re: [FFmpeg-devel] [PATCH] build: fix make checkheaders in out-of-tree builds

2016-01-24 Thread Henrik Gramner
On Sun, Jan 24, 2016 at 5:02 PM, Hendrik Leppkes wrote: > Windows doesn't particularly care which slash direction you give it, > so no, that changes nothing. I'm not quite sure why it fails with the > include path this way, maybe some msys shenanigans. > For fun and giggles, I hard-coded the corre

[FFmpeg-devel] [PATCH] avcodec: Remove libvo-aacenc support.

2016-01-24 Thread Kieran Kunhya
The internal encoder is superior to libvo-aacenc. --- configure | 6 -- doc/encoders.texi | 25 -- doc/general.texi | 8 -- libavcodec/Makefile | 1 - libavcodec/allcodecs.c| 1 - libavcodec/libvo-aacenc.c | 200 --

[FFmpeg-devel] [PATCH] avcodec/put_bits: fix off be one

2016-01-24 Thread Paul B Mahol
Hi, patch attached. From cdbc09536a21400fd2df1cc7d00d806eae84572a Mon Sep 17 00:00:00 2001 From: Paul B Mahol Date: Sun, 24 Jan 2016 17:39:39 +0100 Subject: [PATCH] avcodec/put_bits: fix off by one Signed-off-by: Paul B Mahol --- libavcodec/put_bits.h | 2 +- 1 file changed, 1 insertion(+), 1

Re: [FFmpeg-devel] [PATCH] build: fix make checkheaders in out-of-tree builds

2016-01-24 Thread Ronald S. Bultje
Hi, On Sun, Jan 24, 2016 at 11:14 AM, Henrik Gramner wrote: > On Sun, Jan 24, 2016 at 5:02 PM, Hendrik Leppkes > wrote: > > Windows doesn't particularly care which slash direction you give it, > > so no, that changes nothing. I'm not quite sure why it fails with the > > include path this way, m

Re: [FFmpeg-devel] [PATCH] avcodec/put_bits: fix off be one

2016-01-24 Thread Ronald S. Bultje
Hi, On Sun, Jan 24, 2016 at 11:41 AM, Paul B Mahol wrote: > patch attached. I think that's wrong. buf_end is buf_start+size, so if size=1, this allows writing up to and including buf_start[1], which overflows size=1. Ronald ___ ffmpeg-devel mailing

Re: [FFmpeg-devel] [PATCH] lavfi: recognize GBR9-14P as RGB in ff_fill_rgba_map().

2016-01-24 Thread Ronald S. Bultje
Hi, On Thu, Jan 21, 2016 at 12:50 PM, Paul B Mahol wrote: > On 1/21/16, Ronald S. Bultje wrote: > > --- > > libavfilter/drawutils.c | 4 > > 1 file changed, 4 insertions(+) > > > > diff --git a/libavfilter/drawutils.c b/libavfilter/drawutils.c > > index 3257192..f9a5eb8 100644 > > --- a/l

Re: [FFmpeg-devel] [PATCH] avcodec/put_bits: fix off be one

2016-01-24 Thread Paul B Mahol
On 1/24/16, Ronald S. Bultje wrote: > Hi, > > On Sun, Jan 24, 2016 at 11:41 AM, Paul B Mahol wrote: > >> patch attached. > > > I think that's wrong. buf_end is buf_start+size, so if size=1, this allows > writing up to and including buf_start[1], which overflows size=1. Assert happens otherwise w

Re: [FFmpeg-devel] [PATCH] avcodec/put_bits: fix off be one

2016-01-24 Thread Hendrik Leppkes
On Sun, Jan 24, 2016 at 5:51 PM, Paul B Mahol wrote: > On 1/24/16, Ronald S. Bultje wrote: >> Hi, >> >> On Sun, Jan 24, 2016 at 11:41 AM, Paul B Mahol wrote: >> >>> patch attached. >> >> >> I think that's wrong. buf_end is buf_start+size, so if size=1, this allows >> writing up to and including

Re: [FFmpeg-devel] [PATCH] avcodec/put_bits: fix off be one

2016-01-24 Thread Paul B Mahol
On 1/24/16, Paul B Mahol wrote: > On 1/24/16, Ronald S. Bultje wrote: >> Hi, >> >> On Sun, Jan 24, 2016 at 11:41 AM, Paul B Mahol wrote: >> >>> patch attached. >> >> >> I think that's wrong. buf_end is buf_start+size, so if size=1, this >> allows >> writing up to and including buf_start[1], whic

Re: [FFmpeg-devel] [PATCH] avcodec/put_bits: fix off be one

2016-01-24 Thread Ronald S. Bultje
Hi, On Sun, Jan 24, 2016 at 12:02 PM, Paul B Mahol wrote: > On 1/24/16, Paul B Mahol wrote: > > On 1/24/16, Ronald S. Bultje wrote: > >> Hi, > >> > >> On Sun, Jan 24, 2016 at 11:41 AM, Paul B Mahol > wrote: > >> > >>> patch attached. > >> > >> > >> I think that's wrong. buf_end is buf_start+s

Re: [FFmpeg-devel] [PATCH] avcodec/put_bits: fix off be one

2016-01-24 Thread Paul B Mahol
On 1/24/16, Ronald S. Bultje wrote: > Hi, > > On Sun, Jan 24, 2016 at 12:02 PM, Paul B Mahol wrote: > >> On 1/24/16, Paul B Mahol wrote: >> > On 1/24/16, Ronald S. Bultje wrote: >> >> Hi, >> >> >> >> On Sun, Jan 24, 2016 at 11:41 AM, Paul B Mahol >> wrote: >> >> >> >>> patch attached. >> >> >>

Re: [FFmpeg-devel] [PATCH v4 2/5] ffmpeg: VAAPI hwaccel helper and related initialisation

2016-01-24 Thread wm4
On Sun, 24 Jan 2016 16:12:15 + Mark Thompson wrote: > On 24/01/16 14:52, wm4 wrote: > > On Sun, 24 Jan 2016 14:20:54 + > > Mark Thompson wrote: > > > > ... > > > + > +new_frame = av_frame_alloc(); > +if(!new_frame) > +return AVERROR(ENOMEM); >

Re: [FFmpeg-devel] [PATCH] avcodec: Remove libvo-aacenc support.

2016-01-24 Thread Derek Buitenhuis
On 1/24/2016 4:33 PM, Kieran Kunhya wrote: > The internal encoder is superior to libvo-aacenc. > --- Just about everything is. +1 to removing. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avcodec/put_bits: fix off be one

2016-01-24 Thread Ronald S. Bultje
Hi, On Sun, Jan 24, 2016 at 12:13 PM, Paul B Mahol wrote: > On 1/24/16, Ronald S. Bultje wrote: > > Hi, > > > > On Sun, Jan 24, 2016 at 12:02 PM, Paul B Mahol wrote: > > > >> On 1/24/16, Paul B Mahol wrote: > >> > On 1/24/16, Ronald S. Bultje wrote: > >> >> Hi, > >> >> > >> >> On Sun, Jan 24

Re: [FFmpeg-devel] [PATCH] avcodec/put_bits: fix off be one

2016-01-24 Thread Ronald S. Bultje
Hi, On Sun, Jan 24, 2016 at 12:24 PM, Ronald S. Bultje wrote: > Hi, > > On Sun, Jan 24, 2016 at 12:13 PM, Paul B Mahol wrote: > >> On 1/24/16, Ronald S. Bultje wrote: >> > Hi, >> > >> > On Sun, Jan 24, 2016 at 12:02 PM, Paul B Mahol >> wrote: >> > >> >> On 1/24/16, Paul B Mahol wrote: >> >>

Re: [FFmpeg-devel] [PATCH] build: fix make checkheaders in out-of-tree builds

2016-01-24 Thread Ganesh Ajjanagadde
On Sun, Jan 24, 2016 at 10:14 PM, Ronald S. Bultje wrote: > Hi, > > On Sun, Jan 24, 2016 at 11:14 AM, Henrik Gramner wrote: > >> On Sun, Jan 24, 2016 at 5:02 PM, Hendrik Leppkes >> wrote: >> > Windows doesn't particularly care which slash direction you give it, >> > so no, that changes nothing.

[FFmpeg-devel] [PATCH] avcodec: Remove libaacplus

2016-01-24 Thread Timothy Gu
It's inferior to fdk-aac and has an arguably more problematic license. --- LICENSE.md | 2 +- configure | 5 -- doc/general.texi| 6 +- doc/platform.texi | 2 +- libavcodec/Makefile | 1 - libavcodec/allcodecs.c | 1 - libavcodec/libaacplus

Re: [FFmpeg-devel] [PATCH] build: fix make checkheaders in out-of-tree builds

2016-01-24 Thread Nicolas George
Le quintidi 5 pluviôse, an CCXXIV, Ronald S. Bultje a écrit : > I think Andreas' original patch removed that so in-tree and out-tree builds > are bit-exact (i.e. the pathnames to in-tree source files are identical > between the two build types). > > I don't know if that's worth it. Andreas seems t

Re: [FFmpeg-devel] [PATCH] build: fix make checkheaders in out-of-tree builds

2016-01-24 Thread Andreas Cadhalpun
On 24.01.2016 17:14, Henrik Gramner wrote: > On Sun, Jan 24, 2016 at 5:02 PM, Hendrik Leppkes wrote: >> Windows doesn't particularly care which slash direction you give it, >> so no, that changes nothing. I'm not quite sure why it fails with the >> include path this way, maybe some msys shenanigan

Re: [FFmpeg-devel] [PATCH] build: fix make checkheaders in out-of-tree builds

2016-01-24 Thread Andreas Cadhalpun
On 24.01.2016 18:58, Nicolas George wrote: > Le quintidi 5 pluviôse, an CCXXIV, Ronald S. Bultje a écrit : >> I think Andreas' original patch removed that so in-tree and out-tree builds >> are bit-exact (i.e. the pathnames to in-tree source files are identical >> between the two build types). >> >>

Re: [FFmpeg-devel] [PATCH] build: fix make checkheaders in out-of-tree builds

2016-01-24 Thread Nicolas George
Le quintidi 5 pluviôse, an CCXXIV, Andreas Cadhalpun a écrit : > I can't reproduce this. The path is only included in the debugging > information. > And that happened even more before my change. I just built in-tree with: ./configure && nice make -j 8, and then I get: /tmp/ff2 $ grep /tmp/ff2 f

Re: [FFmpeg-devel] [PATCH 2/2] avformat: add protocol_whitelist

2016-01-24 Thread Nicolas George
Le quintidi 5 pluviôse, an CCXXIV, Michael Niedermayer a écrit : > the argument is added, not out of strict need, (there already is a > AVDictionary that can be used) but to make it clear that the author > set the whitelist correctly. Also it simplifies the code compared > to using the AVDictionary

Re: [FFmpeg-devel] [PATCH] build: fix make checkheaders in out-of-tree builds

2016-01-24 Thread Andreas Cadhalpun
On 24.01.2016 19:37, Nicolas George wrote: > Le quintidi 5 pluviôse, an CCXXIV, Andreas Cadhalpun a écrit : >> I can't reproduce this. The path is only included in the debugging >> information. >> And that happened even more before my change. > > I just built in-tree with: > > ./configure && nic

Re: [FFmpeg-devel] [PATCH 2/2] avformat: add protocol_whitelist

2016-01-24 Thread Andreas Cadhalpun
On 24.01.2016 16:03, Michael Niedermayer wrote: > On Sun, Jan 24, 2016 at 03:37:24PM +0100, Andreas Cadhalpun wrote: >> On 24.01.2016 03:42, Michael Niedermayer wrote: >>> From: Michael Niedermayer >>> diff --git a/libavformat/avformat.h b/libavformat/avformat.h >>> index 4964263..2fb9130 100644 >

Re: [FFmpeg-devel] [PATCH 2/2] avformat: add protocol_whitelist

2016-01-24 Thread Nicolas George
Le quintidi 5 pluviôse, an CCXXIV, Andreas Cadhalpun a écrit : > The idea is to classify protocols as local (file, concat) or remote (http, > tcp). I am sorry, but this is completely broken. First, concat is not local. Second, local/remote is not a relevant distinction for security. Any design m

Re: [FFmpeg-devel] [PATCH 2/2] avformat: add protocol_whitelist

2016-01-24 Thread Andreas Cadhalpun
On 24.01.2016 20:20, Nicolas George wrote: > Le quintidi 5 pluviôse, an CCXXIV, Andreas Cadhalpun a écrit : >> The idea is to classify protocols as local (file, concat) or remote (http, >> tcp). > > I am sorry, but this is completely broken. No. It would have prevented the issue with hls. > Fir

Re: [FFmpeg-devel] [PATCH] build: fix make checkheaders in out-of-tree builds

2016-01-24 Thread Hendrik Leppkes
On Sun, Jan 24, 2016 at 7:27 PM, Andreas Cadhalpun wrote: > On 24.01.2016 17:14, Henrik Gramner wrote: >> On Sun, Jan 24, 2016 at 5:02 PM, Hendrik Leppkes wrote: >>> Windows doesn't particularly care which slash direction you give it, >>> so no, that changes nothing. I'm not quite sure why it fai

Re: [FFmpeg-devel] [PATCH] build: fix make checkheaders in out-of-tree builds

2016-01-24 Thread Andreas Cadhalpun
On 24.01.2016 20:40, Hendrik Leppkes wrote: > On Sun, Jan 24, 2016 at 7:27 PM, Andreas Cadhalpun > wrote: >> On 24.01.2016 17:14, Henrik Gramner wrote: >> I have a hard time believing that there are environments, where one >> can't use absolute paths... > > Its about the combination of msys and i

[FFmpeg-devel] [PATCH] avcodec/flacenc: fix calculation of bits required in case of custom sample rate

2016-01-24 Thread Paul B Mahol
Hi, patch attached. From c450396407c7fb6b4fbe32a3d5c095ee6fc98d96 Mon Sep 17 00:00:00 2001 From: Paul B Mahol Date: Sun, 24 Jan 2016 20:47:49 +0100 Subject: [PATCH] avcodec/flacenc: fix calculation of bits required in case of custom sample rate Signed-off-by: Paul B Mahol --- libavcodec/flace

Re: [FFmpeg-devel] [PATCH] build: fix make checkheaders in out-of-tree builds

2016-01-24 Thread Hendrik Leppkes
On Sun, Jan 24, 2016 at 8:51 PM, Andreas Cadhalpun wrote: > On 24.01.2016 20:40, Hendrik Leppkes wrote: >> On Sun, Jan 24, 2016 at 7:27 PM, Andreas Cadhalpun >> wrote: >>> On 24.01.2016 17:14, Henrik Gramner wrote: >>> I have a hard time believing that there are environments, where one >>> can't

Re: [FFmpeg-devel] [PATCH] build: fix make checkheaders in out-of-tree builds

2016-01-24 Thread Andreas Cadhalpun
On 24.01.2016 20:54, Hendrik Leppkes wrote: > On Sun, Jan 24, 2016 at 8:51 PM, Andreas Cadhalpun > wrote: >> On 24.01.2016 20:40, Hendrik Leppkes wrote: >>> Unfortunately that doesn't work when there is no common path, ie. >>> sources on another drive (say D:) as my build directory (say C:) >> >>

Re: [FFmpeg-devel] [PATCH] build: fix make checkheaders in out-of-tree builds

2016-01-24 Thread Ronald S. Bultje
Hi, On Sun, Jan 24, 2016 at 3:10 PM, Andreas Cadhalpun < andreas.cadhal...@googlemail.com> wrote: > On 24.01.2016 20:54, Hendrik Leppkes wrote: > > On Sun, Jan 24, 2016 at 8:51 PM, Andreas Cadhalpun > > wrote: > >> On 24.01.2016 20:40, Hendrik Leppkes wrote: > >>> Unfortunately that doesn't work

Re: [FFmpeg-devel] [PATCH] build: fix make checkheaders in out-of-tree builds

2016-01-24 Thread Henrik Gramner
On Sun, Jan 24, 2016 at 8:54 PM, Hendrik Leppkes wrote: > Its just how it works. Relative paths can't switch drive in windows > path, no matter how many ..'s you chain. > Once you hit the root of a drive, .. just redirects to itself, just > like a unix / would, except that you get one per drive in

Re: [FFmpeg-devel] [PATCH] build: fix make checkheaders in out-of-tree builds

2016-01-24 Thread Timothy Gu
Hi, On Sun, Jan 24, 2016 at 09:10:53PM +0100, Andreas Cadhalpun wrote: > When the build environment has so many limitations some things just > don't work. > > Why is it necessary to do MSVC out-of-tree builds across different > drives? It's not, but it used to work, and it doesn't work now. Thus

Re: [FFmpeg-devel] [PATCH] build: fix make checkheaders in out-of-tree builds

2016-01-24 Thread Andreas Cadhalpun
On 24.01.2016 21:14, Ronald S. Bultje wrote: > On Sun, Jan 24, 2016 at 3:10 PM, Andreas Cadhalpun < > andreas.cadhal...@googlemail.com> wrote: > >> On 24.01.2016 20:54, Hendrik Leppkes wrote: >>> On Sun, Jan 24, 2016 at 8:51 PM, Andreas Cadhalpun >>> wrote: On 24.01.2016 20:40, Hendrik Leppk

Re: [FFmpeg-devel] [PATCH 2/2] avformat: add protocol_whitelist

2016-01-24 Thread Nicolas George
Le quintidi 5 pluviôse, an CCXXIV, Andreas Cadhalpun a écrit : > No. It would have prevented the issue with hls. Reacting to known attacks by ad-hoc hole-plugging is no way of building proper security. > But it's usually only used with local files. I do not know that. Do you? > Why not? Becaus

Re: [FFmpeg-devel] [PATCH] build: fix make checkheaders in out-of-tree builds

2016-01-24 Thread James Almer
On 1/24/2016 5:20 PM, Andreas Cadhalpun wrote: > On 24.01.2016 21:14, Ronald S. Bultje wrote: >> On Sun, Jan 24, 2016 at 3:10 PM, Andreas Cadhalpun < >> andreas.cadhal...@googlemail.com> wrote: >> >>> On 24.01.2016 20:54, Hendrik Leppkes wrote: On Sun, Jan 24, 2016 at 8:51 PM, Andreas Cadhalpu

Re: [FFmpeg-devel] [PATCH] build: fix make checkheaders in out-of-tree builds

2016-01-24 Thread Paul B Mahol
On 1/24/16, James Almer wrote: > On 1/24/2016 5:20 PM, Andreas Cadhalpun wrote: >> On 24.01.2016 21:14, Ronald S. Bultje wrote: >>> On Sun, Jan 24, 2016 at 3:10 PM, Andreas Cadhalpun < >>> andreas.cadhal...@googlemail.com> wrote: >>> On 24.01.2016 20:54, Hendrik Leppkes wrote: > On Sun, J

Re: [FFmpeg-devel] [PATCH] avcodec/flacenc: fix calculation of bits required in case of custom sample rate

2016-01-24 Thread Rostislav Pehlivanov
On 24 January 2016 at 19:53, Paul B Mahol wrote: > Hi, > > patch attached. > LGTM sr_code will be 12 in case the samplerate is below 255000 (so the header will be +1 bytes long) and 14 (> 12 so the header will be +2 bytes long) if it's above. The previous code assumed the first part in the brac

Re: [FFmpeg-devel] [PATCH] ffmpeg_opt: Allow program metadata other than title to be set.

2016-01-24 Thread Michael Niedermayer
On Sun, Jan 24, 2016 at 04:03:30PM +0100, Vittorio Gambaletta (VittGam) wrote: > Hi, > > On 24/01/2016 12:33:51 CET, Michael Niedermayer wrote: > >On Sun, Jan 24, 2016 at 05:23:22AM +0100, Vittorio Gambaletta (VittGam) > >wrote: > >>This commit makes it possible to add optional metadata (such as

[FFmpeg-devel] [PATCH] avcodec: split off synth_filter

2016-01-24 Thread James Almer
Signed-off-by: James Almer --- This should make replacing the current dca decoder for foo86's easier, without having to disable/reenable the compilation of synth_filter files in between removal/addition commits. aarch64 and arm changes untested. configure

Re: [FFmpeg-devel] [PATCH] lavu: add ff_pthread_setname() and use it in various places

2016-01-24 Thread Michael Niedermayer
On Sun, Jan 24, 2016 at 01:58:29PM +0100, Clément Bœsch wrote: > On Wed, Jan 20, 2016 at 09:15:15PM -0300, James Almer wrote: > > On 1/20/2016 7:46 PM, Clément Bœsch wrote: > > > diff --git a/libavutil/thread.h b/libavutil/thread.h > > > index 32ddf40..42430fb 100644 > > > --- a/libavutil/thread.h

  1   2   >