Re: [FFmpeg-devel] [PATCH] avcodec/put_bits: Always check buffer end before writing

2016-01-01 Thread Paul B Mahol
On 1/1/16, Michael Niedermayer wrote: > From: Michael Niedermayer > > This causes a overall slowdown of 0.1 % (tested with mpeg4 single thread > encoding of matrixbench at QP=3) > > Signed-off-by: Michael Niedermayer > --- > libavcodec/put_bits.h | 16 ++-- > 1 file changed, 10 in

[FFmpeg-devel] [PATCH 2/2] avfilter: add showspectrumpic filter

2016-01-01 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- doc/filters.texi | 106 +++ libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/avf_showspectrum.c | 233 ++--- 4 files changed, 326 insertions(+), 15 deletion

[FFmpeg-devel] [PATCH 1/2] avfilter/avf_showspectrum: store win_size in private context and calculate it only once

2016-01-01 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavfilter/avf_showspectrum.c | 39 +-- 1 file changed, 17 insertions(+), 22 deletions(-) diff --git a/libavfilter/avf_showspectrum.c b/libavfilter/avf_showspectrum.c index 5380994..0fa1be1 100644 --- a/libavfilter/avf_showspec

Re: [FFmpeg-devel] [PATCH] libi264: Add Hardware Accelerated H.264 Encoder based on libVA

2016-01-01 Thread Hendrik Leppkes
On Thu, Dec 31, 2015 at 6:35 PM, ha...@mayartech.com wrote: > From: Bryan Christ > I see you are not the author of this patch. Will you be maintaining it in the future? Such huge patches and complicated features do need a maintainer, or it'll likely result in breaking sooner or later. > This co

Re: [FFmpeg-devel] [PATCH] avcodec/put_bits: Always check buffer end before writing

2016-01-01 Thread Michael Niedermayer
On Fri, Jan 01, 2016 at 08:59:23AM +, Paul B Mahol wrote: > On 1/1/16, Michael Niedermayer wrote: > > From: Michael Niedermayer > > > > This causes a overall slowdown of 0.1 % (tested with mpeg4 single thread > > encoding of matrixbench at QP=3) > > > > Signed-off-by: Michael Niedermayer > >

Re: [FFmpeg-devel] [PATCH] avcodec/put_bits: Always check buffer end before writing

2016-01-01 Thread Hendrik Leppkes
On Fri, Jan 1, 2016 at 1:39 PM, Michael Niedermayer wrote: > On Fri, Jan 01, 2016 at 08:59:23AM +, Paul B Mahol wrote: >> On 1/1/16, Michael Niedermayer wrote: >> > From: Michael Niedermayer >> > >> > This causes a overall slowdown of 0.1 % (tested with mpeg4 single thread >> > encoding of m

Re: [FFmpeg-devel] [PATCH 2/2] avfilter: add showspectrumpic filter

2016-01-01 Thread Paul B Mahol
On 1/1/16, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > doc/filters.texi | 106 +++ > libavfilter/Makefile | 1 + > libavfilter/allfilters.c | 1 + > libavfilter/avf_showspectrum.c | 233 > ++--- >

Re: [FFmpeg-devel] [PATCH] avcodec/put_bits: Always check buffer end before writing

2016-01-01 Thread Michael Niedermayer
On Fri, Jan 01, 2016 at 02:07:34PM +0100, Hendrik Leppkes wrote: > On Fri, Jan 1, 2016 at 1:39 PM, Michael Niedermayer > wrote: > > On Fri, Jan 01, 2016 at 08:59:23AM +, Paul B Mahol wrote: > >> On 1/1/16, Michael Niedermayer wrote: > >> > From: Michael Niedermayer > >> > > >> > This causes

[FFmpeg-devel] 2.9/3.0, 2.8.5, ...

2016-01-01 Thread Michael Niedermayer
Hi all Its a while since 2.8 so unless there are objections i will make a 2.9 or if people prefer a 3.0 within the next month or so Also ill likely make another round of point releases from the 2.8/2.7/2.6/2.5 branches soon, that is if someone wants to backport something or fix and backport ...

Re: [FFmpeg-devel] 2.9/3.0, 2.8.5, ...

2016-01-01 Thread Paul B Mahol
On 1/1/16, Michael Niedermayer wrote: > Hi all > > Its a while since 2.8 so unless there are objections i will make a > 2.9 or if people prefer a 3.0 within the next month or so > > Also ill likely make another round of point releases from the > 2.8/2.7/2.6/2.5 branches soon, that is if someone wa

Re: [FFmpeg-devel] [PATCH][WIP] lavc/cbrt_tablegen: speed up tablegen

2016-01-01 Thread Ronald S. Bultje
Hi, On Thu, Dec 31, 2015 at 9:55 PM, Ganesh Ajjanagadde wrote: > This exploits an approach based on the sieve of Eratosthenes, a popular > method for generating prime numbers. > > Tables are identical to previous ones. > > Tested with FATE. Does not work yet with --enable-hardcoded-tables due >

[FFmpeg-devel] [PATCH] avcodec/put_bits: Always check buffer end before writing

2016-01-01 Thread Michael Niedermayer
From: Michael Niedermayer This causes a overall slowdown of 0.1 % (tested with mpeg4 single thread encoding of matrixbench at QP=3) Signed-off-by: Michael Niedermayer --- libavcodec/put_bits.h | 20 ++-- 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/libavcod

[FFmpeg-devel] [PATCH] Revert "Merge commit '9f1eccb97bf8894cb18b14f642500686505ef186'"

2016-01-01 Thread Michael Niedermayer
From: Michael Niedermayer This unbreaks encoding Example: ffmpeg -i matrixbench_mpeg2.mpg new.avi -rw-r- 1 michael michael 226035354 Jan 1 16:27 new.avi -rw-r- 1 michael michael 10016802 Jan 1 16:28 ref.avi Also av_get_audio_frame_duration() itself uses frame_size This reverts commi

Re: [FFmpeg-devel] 2.9/3.0, 2.8.5, ...

2016-01-01 Thread Rostislav Pehlivanov
I think a 3.0 release needs more major things, so a 2.9 would make more sense IMO. On 1 January 2016 at 14:28, Paul B Mahol wrote: > On 1/1/16, Michael Niedermayer wrote: > > Hi all > > > > Its a while since 2.8 so unless there are objections i will make a > > 2.9 or if people prefer a 3.0 with

Re: [FFmpeg-devel] [PATCH][WIP] lavc/cbrt_tablegen: speed up tablegen

2016-01-01 Thread Ganesh Ajjanagadde
On Fri, Jan 1, 2016 at 6:54 AM, Ronald S. Bultje wrote: > Hi, > > On Thu, Dec 31, 2015 at 9:55 PM, Ganesh Ajjanagadde > wrote: >> >> This exploits an approach based on the sieve of Eratosthenes, a popular >> method for generating prime numbers. >> >> Tables are identical to previous ones. >> >> T

Re: [FFmpeg-devel] [PATCH][WIP] lavc/cbrt_tablegen: speed up tablegen

2016-01-01 Thread Ronald S. Bultje
Hi, On Fri, Jan 1, 2016 at 10:40 AM, Ganesh Ajjanagadde wrote: > On Fri, Jan 1, 2016 at 6:54 AM, Ronald S. Bultje > wrote: > > Hi, > > > > On Thu, Dec 31, 2015 at 9:55 PM, Ganesh Ajjanagadde < > gajjanaga...@gmail.com> > > wrote: > >> > >> This exploits an approach based on the sieve of Eratost

Re: [FFmpeg-devel] [PATCH][WIP] lavc/cbrt_tablegen: speed up tablegen

2016-01-01 Thread Ganesh Ajjanagadde
On Fri, Jan 1, 2016 at 7:43 AM, Ronald S. Bultje wrote: > Hi, > > On Fri, Jan 1, 2016 at 10:40 AM, Ganesh Ajjanagadde > wrote: >> >> On Fri, Jan 1, 2016 at 6:54 AM, Ronald S. Bultje >> wrote: >> > Hi, >> > >> > On Thu, Dec 31, 2015 at 9:55 PM, Ganesh Ajjanagadde >> > >> > wrote: >> >> >> >> Thi

Re: [FFmpeg-devel] 2.9/3.0, 2.8.5, ...

2016-01-01 Thread Carl Eugen Hoyos
Paul B Mahol gmail.com> writes: > On 1/1/16, Michael Niedermayer niedermayer.cc> wrote: > > Hi all > > > > Its a while since 2.8 so unless there are objections i will make a > > 2.9 or if people prefer a 3.0 within the next month or so The number of open regressions is quite high atm... > Ther

Re: [FFmpeg-devel] [PATCH] Revert "Merge commit '9f1eccb97bf8894cb18b14f642500686505ef186'"

2016-01-01 Thread Hendrik Leppkes
On Fri, Jan 1, 2016 at 4:37 PM, Michael Niedermayer wrote: > From: Michael Niedermayer > > This unbreaks encoding > Example: > ffmpeg -i matrixbench_mpeg2.mpg new.avi > > -rw-r- 1 michael michael 226035354 Jan 1 16:27 new.avi > -rw-r- 1 michael michael 10016802 Jan 1 16:28 ref.avi > >

Re: [FFmpeg-devel] [PATCH][WIP] lavc/cbrt_tablegen: speed up tablegen

2016-01-01 Thread Ronald S. Bultje
Hi, On Fri, Jan 1, 2016 at 10:46 AM, Ganesh Ajjanagadde wrote: > On Fri, Jan 1, 2016 at 7:43 AM, Ronald S. Bultje > wrote: > > Hi, > > > > On Fri, Jan 1, 2016 at 10:40 AM, Ganesh Ajjanagadde < > gajjanaga...@gmail.com> > > wrote: > >> > >> On Fri, Jan 1, 2016 at 6:54 AM, Ronald S. Bultje > >>

Re: [FFmpeg-devel] [PATCH][WIP] lavc/cbrt_tablegen: speed up tablegen

2016-01-01 Thread Ganesh Ajjanagadde
On Fri, Jan 1, 2016 at 7:51 AM, Ronald S. Bultje wrote: > Hi, > > On Fri, Jan 1, 2016 at 10:46 AM, Ganesh Ajjanagadde > wrote: >> >> On Fri, Jan 1, 2016 at 7:43 AM, Ronald S. Bultje >> wrote: >> > Hi, >> > >> > On Fri, Jan 1, 2016 at 10:40 AM, Ganesh Ajjanagadde >> > >> > wrote: >> >> >> >> On

Re: [FFmpeg-devel] [PATCH] lavf/qtpalette: Ignore greyscale bit in 1-bit video

2016-01-01 Thread Carl Eugen Hoyos
Michael Niedermayer niedermayer.cc> writes: > On Thu, Dec 31, 2015 at 03:59:53PM +, Carl Eugen Hoyos wrote: > > Mats Peterson ffmpeg.org> writes: > > > > > And this patch doesn't affect the current state of > > > the qtrle decoder > > > > Then there is no need for this patch to be > > co

Re: [FFmpeg-devel] [PATCH] libi264: Add Hardware Accelerated H.264 Encoder based on libVA

2016-01-01 Thread Carl Eugen Hoyos
hamza mayartech.com mayartech.com> writes: > + --enable-libi264 enable H.264 encoding via Intel's libva [no] What is the difference between (your) libva and the (existing) libvaapi? If they are the same external library, please do not add a new configure switch. Carl Eugen

Re: [FFmpeg-devel] [PATCH][WIP] lavc/cbrt_tablegen: speed up tablegen

2016-01-01 Thread Ronald S. Bultje
Hi, On Fri, Jan 1, 2016 at 10:52 AM, Ganesh Ajjanagadde wrote: > On Fri, Jan 1, 2016 at 7:51 AM, Ronald S. Bultje > wrote: > > Hi, > > > > On Fri, Jan 1, 2016 at 10:46 AM, Ganesh Ajjanagadde < > gajjanaga...@gmail.com> > > wrote: > >> > >> On Fri, Jan 1, 2016 at 7:43 AM, Ronald S. Bultje > >>

[FFmpeg-devel] [RFC] Disable compile-time tablegen for cbrt if total cycle count < 200000

2016-01-01 Thread Ganesh Ajjanagadde
Hi all, Motivated by a remark by Ronald: https://ffmpeg.org/pipermail/ffmpeg-devel/2016-January/186200.html, this is a request for comment on disabling compile time tablegen for cbrt if the total cycle count < 20. Note that cbrt tables are only used in aacdec. Regards, Ganesh

Re: [FFmpeg-devel] [PATCH] Revert "Merge commit '9f1eccb97bf8894cb18b14f642500686505ef186'"

2016-01-01 Thread Michael Niedermayer
On Fri, Jan 01, 2016 at 04:48:12PM +0100, Hendrik Leppkes wrote: > On Fri, Jan 1, 2016 at 4:37 PM, Michael Niedermayer wrote: > > From: Michael Niedermayer > > > > This unbreaks encoding > > Example: > > ffmpeg -i matrixbench_mpeg2.mpg new.avi > > > > -rw-r- 1 michael michael 226035354 Jan 1

Re: [FFmpeg-devel] [PATCH][WIP] lavc/cbrt_tablegen: speed up tablegen

2016-01-01 Thread Ganesh Ajjanagadde
On Fri, Jan 1, 2016 at 7:56 AM, Ronald S. Bultje wrote: > Hi, > > On Fri, Jan 1, 2016 at 10:52 AM, Ganesh Ajjanagadde > wrote: >> >> On Fri, Jan 1, 2016 at 7:51 AM, Ronald S. Bultje >> wrote: >> > Hi, >> > >> > On Fri, Jan 1, 2016 at 10:46 AM, Ganesh Ajjanagadde >> > >> > wrote: >> >> >> >> On

[FFmpeg-devel] [RFC v3 2/2] oggenc: add support for remuxing of files with the Daala video codec

2016-01-01 Thread Rostislav Pehlivanov
Requires the parser from the decoder (previous commit). Signed-off-by: Rostislav Pehlivanov --- libavformat/oggenc.c | 25 - 1 file changed, 16 insertions(+), 9 deletions(-) diff --git a/libavformat/oggenc.c b/libavformat/oggenc.c index 4907512..7f0cfc1 100644 --- a/liba

[FFmpeg-devel] [PATCH] avcodec/utils: Add case for mp3 to av_get_audio_frame_duration()

2016-01-01 Thread Michael Niedermayer
From: Michael Niedermayer This is not guranteed to be correct but only the encoder or the packet headers can really provide the correct value. And before the first packet there is no alternative to receiving the value from the encoder by some means other codecs like AAC are still missing and are

[FFmpeg-devel] [PATCH] avcodec/codec_desc: Add ff_aac_profiles to aac_latm

2016-01-01 Thread Michael Niedermayer
From: Michael Niedermayer Signed-off-by: Michael Niedermayer --- libavcodec/codec_desc.c |1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/codec_desc.c b/libavcodec/codec_desc.c index e814507..5fbe624 100644 --- a/libavcodec/codec_desc.c +++ b/libavcodec/codec_desc.c @@ -2446,6

Re: [FFmpeg-devel] [PATCHv2] lavf/srtdec: rewrite parsing logic

2016-01-01 Thread Clément Bœsch
On Sat, Dec 26, 2015 at 06:51:00PM +0100, Clément Bœsch wrote: > Fixes Ticket #5032 > > The samples in Ticket #5032 is using \r\r\n as line breaks. Since we > already are handling \r, or \n, or \r\n as line breaks, \r\n\n will be > considered as a double line breaks. This is an issue because > ff

Re: [FFmpeg-devel] [PATCH] avcodec/utils: Add case for mp3 to av_get_audio_frame_duration()

2016-01-01 Thread Ronald S. Bultje
Hi, On Fri, Jan 1, 2016 at 11:43 AM, Michael Niedermayer wrote: > From: Michael Niedermayer > > This is not guranteed to be correct but only the encoder or the packet > headers > can really provide the correct value. And before the first packet there is > no alternative to receiving the value f

Re: [FFmpeg-devel] [PATCH] avcodec/utils: Add case for mp3 to av_get_audio_frame_duration()

2016-01-01 Thread Hendrik Leppkes
On Fri, Jan 1, 2016 at 7:29 PM, Ronald S. Bultje wrote: > Hi, > > On Fri, Jan 1, 2016 at 11:43 AM, Michael Niedermayer > wrote: > >> From: Michael Niedermayer >> >> This is not guranteed to be correct but only the encoder or the packet >> headers >> can really provide the correct value. And befo

Re: [FFmpeg-devel] [PATCH] avcodec/utils: Add case for mp3 to av_get_audio_frame_duration()

2016-01-01 Thread Derek Buitenhuis
On 1/1/2016 6:29 PM, Ronald S. Bultje wrote: > Please, no more codec-specific hacks in generic code. Eh, how is being generic even possible for audio frame size? What defines an audio "frame", if not the codec? - Derek ___ ffmpeg-devel mailing list ffm

Re: [FFmpeg-devel] [PATCH] lavfi/af_sofalizer: remove exp2 and replace clz by ff_clz

2016-01-01 Thread Ganesh Ajjanagadde
On Tue, Dec 29, 2015 at 1:17 PM, Ganesh Ajjanagadde wrote: > ff_clz is faster, and uses an intrinsic (at the moment on GCC). exp2 is > a wasteful function for a simple integer exponentiation. > > Untested. > > Signed-off-by: Ganesh Ajjanagadde > --- > libavfilter/af_sofalizer.c | 5 +++-- > 1 fi

Re: [FFmpeg-devel] [PATCH 2/2] avfilter: add showspectrumpic filter

2016-01-01 Thread Paul B Mahol
Latest version attached. From d9517bc3d07bd1d4ca939198f8da44f36dd3319f Mon Sep 17 00:00:00 2001 From: Paul B Mahol Date: Thu, 31 Dec 2015 20:45:37 +0100 Subject: [PATCH 2/2] avfilter: add showspectrumpic filter Signed-off-by: Paul B Mahol --- doc/filters.texi | 106 +++

Re: [FFmpeg-devel] [PATCH 2/2] avfilter: add showspectrumpic filter

2016-01-01 Thread Clément Bœsch
On Fri, Jan 01, 2016 at 10:00:31AM +0100, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > doc/filters.texi | 106 +++ > libavfilter/Makefile | 1 + > libavfilter/allfilters.c | 1 + > libavfilter/avf_showspectrum.c | 233 > +

Re: [FFmpeg-devel] [PATCH 2/2] avfilter: add showspectrumpic filter

2016-01-01 Thread Paul B Mahol
On 1/1/16, Clement Boesch wrote: > On Fri, Jan 01, 2016 at 10:00:31AM +0100, Paul B Mahol wrote: >> Signed-off-by: Paul B Mahol >> --- >> doc/filters.texi | 106 +++ >> libavfilter/Makefile | 1 + >> libavfilter/allfilters.c | 1 + >> libavfilter

Re: [FFmpeg-devel] [PATCH] lavfi/af_sofalizer: remove exp2 and replace clz by ff_clz

2016-01-01 Thread Paul B Mahol
On 1/1/16, Ganesh Ajjanagadde wrote: > On Tue, Dec 29, 2015 at 1:17 PM, Ganesh Ajjanagadde > wrote: >> ff_clz is faster, and uses an intrinsic (at the moment on GCC). exp2 is >> a wasteful function for a simple integer exponentiation. >> >> Untested. >> >> Signed-off-by: Ganesh Ajjanagadde >> --

Re: [FFmpeg-devel] [RFC v3 1/2] libavcodec: add a native decoder for the Daala video codec

2016-01-01 Thread James Almer
On 1/1/2016 1:22 PM, Rostislav Pehlivanov wrote: > +/* Gets a single bit if !!cond and returns ±1 */ > +static av_always_inline int _daalaent_cphase(DaalaEntropy *e, int cond) Don't start function names with a _ prefix. > +{ > +if (cond) > +return 1 - 2*daalaent_decode_bits(e, 1); > +

Re: [FFmpeg-devel] [PATCH] lavfi/af_sofalizer: remove exp2 and replace clz by ff_clz

2016-01-01 Thread Ganesh Ajjanagadde
On Fri, Jan 1, 2016 at 11:08 AM, Paul B Mahol wrote: > On 1/1/16, Ganesh Ajjanagadde wrote: >> On Tue, Dec 29, 2015 at 1:17 PM, Ganesh Ajjanagadde >> wrote: >>> ff_clz is faster, and uses an intrinsic (at the moment on GCC). exp2 is >>> a wasteful function for a simple integer exponentiation. >>

Re: [FFmpeg-devel] [RFC v4] libbavcodec: add a native decoder for the Daala video codec

2016-01-01 Thread Ganesh Ajjanagadde
On Fri, Jan 1, 2016 at 12:16 PM, Rostislav Pehlivanov wrote: > Thanks for the feedback. > Fixed all the issues you reported. The new revision is in this email. > > I've replaced the daalaent_cphase with a macro instead. Saves a few lines. > > I don't think it's a problem having large functions mar

Re: [FFmpeg-devel] [RFC v4] libbavcodec: add a native decoder for the Daala video codec

2016-01-01 Thread Michael Niedermayer
On Fri, Jan 01, 2016 at 08:16:12PM +, Rostislav Pehlivanov wrote: [...] > +static av_cold int daala_decode_init(AVCodecContext *avctx) > +{ > +int i, r_w, r_h, err = 0; > +DaalaContext *s = avctx->priv_data; > + > +/* Inits a default QM, if the file isn't using the default it will

Re: [FFmpeg-devel] [RFC v4] libbavcodec: add a native decoder for the Daala video codec

2016-01-01 Thread Rostislav Pehlivanov
>this would fail on beos acording to doc/errno.txt Fixed, replaced with EINVAL in my private tree ( https://github.com/atomnuker/FFmpeg) and in the patch attached with this email. Not sure how appropriate EINVAL is but other decoders use it too. Also as suggested moved the vector functions to daal

Re: [FFmpeg-devel] [PATCH] avcodec/utils: Add case for mp3 to av_get_audio_frame_duration()

2016-01-01 Thread Michael Niedermayer
On Fri, Jan 01, 2016 at 07:33:58PM +0100, Hendrik Leppkes wrote: > On Fri, Jan 1, 2016 at 7:29 PM, Ronald S. Bultje wrote: > > Hi, > > > > On Fri, Jan 1, 2016 at 11:43 AM, Michael Niedermayer > > wrote: > > > >> From: Michael Niedermayer > >> > >> This is not guranteed to be correct but only the

Re: [FFmpeg-devel] 2.9/3.0, 2.8.5, ...

2016-01-01 Thread Ganesh Ajjanagadde
On Fri, Jan 1, 2016 at 6:19 AM, Michael Niedermayer wrote: > Hi all > > Its a while since 2.8 so unless there are objections i will make a > 2.9 or if people prefer a 3.0 within the next month or so No opinion on 2.9 vs 3.0. If going with 3.0, I propose the release name "Boole" or "Shannon" - htt

Re: [FFmpeg-devel] [RFC v4] libbavcodec: add a native decoder for the Daala video codec

2016-01-01 Thread Carl Eugen Hoyos
Rostislav Pehlivanov gmail.com> writes: > >this would fail on beos acording to doc/errno.txt > Fixed, replaced with EINVAL in my private tree ( > https://github.com/atomnuker/FFmpeg Sorry but the licensing simply makes no sense now: The files should be - at you choice - either licensed under t

Re: [FFmpeg-devel] [RFC v4] libbavcodec: add a native decoder for the Daala video codec

2016-01-01 Thread Rostislav Pehlivanov
The reason why the FFmpeg license was added as well was to keep FATE happy and not have to put an exception for it (since all the exceptions are just for empty template files). The way I understand it is that the license above is the license for the file and all the code within it, while the licens

Re: [FFmpeg-devel] [RFC v4] libbavcodec: add a native decoder for the Daala video codec

2016-01-01 Thread Carl Eugen Hoyos
Rostislav Pehlivanov gmail.com> writes: > The reason why the FFmpeg license was added as well > was to keep FATE happy Then please add the new license to FATE but remove the unintended license from the new source files. You could also leave the test broken: I believe that this should not be

Re: [FFmpeg-devel] [RFC v4] libbavcodec: add a native decoder for the Daala video codec

2016-01-01 Thread Rostislav Pehlivanov
Fair enough, I will leave only the BSD-2 clause license and I'll put the files as an exception when I send the decoder as another RFC. Ronald has agreed to review the decoder (on a technical side of things) if he has time this weekend so I'll wait for him to try to finish his review. In any case,

[FFmpeg-devel] [PATCH] avcodec/utils: fix AVPacket lifetime in seek_frame_generic

2016-01-01 Thread Hendrik Leppkes
Fixes ticket #5117 --- libavformat/utils.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/libavformat/utils.c b/libavformat/utils.c index 95acbf3..7606502 100644 --- a/libavformat/utils.c +++ b/libavformat/utils.c @@ -2142,15 +2142,18 @@ static int seek_frame_generic(AV

[FFmpeg-devel] [PATCH] libavcodec/ccaption_dec: remove unnecessary buffering of closed caption packets

2016-01-01 Thread Aman Gupta
From: Aman Gupta CC data is fed to in small chunks (usually 60 bytes at a time) and is parsed fully by the eia608 decoder. There is no reason to copy it into a secondary buffer first. --- libavcodec/ccaption_dec.c | 22 +- 1 file changed, 1 insertion(+), 21 deletions(-) diff

Re: [FFmpeg-devel] [RFC v4] libbavcodec: add a native decoder for the Daala video codec

2016-01-01 Thread Carl Eugen Hoyos
Rostislav Pehlivanov gmail.com> writes: > Fair enough, I will leave only the BSD-2 clause license > and I'll put the files as an exception when I send the > decoder as another RFC. This would be fine but please see below: If you prefer the LGPL, please use it! > Ronald has agreed to review t

Re: [FFmpeg-devel] [RFC v4] libbavcodec: add a native decoder for the Daala video codec

2016-01-01 Thread Rostislav Pehlivanov
>To the very best of my knowledge you are allowed >to relicense code that was published under a two- >(or three-) clause BSD license under the GPL (and >the LGPL) as long as you keep the copyright >notice. Yes, that's what I've concluded as well. Basically, the license says: >Redistributions of so

Re: [FFmpeg-devel] [RFC v4] libbavcodec: add a native decoder for the Daala video codec

2016-01-01 Thread Carl Eugen Hoyos
Carl Eugen Hoyos ag.or.at> writes: [...] We were apparently both wrong: https://www.softwarefreedom.org/resources/2007/gpl-non-gpl-collaboration.html So please place the original (two-clause BSD) license including the copyright statement under your (new) LGPL license. Sorry for the noise, Ca

Re: [FFmpeg-devel] [RFC v4] libbavcodec: add a native decoder for the Daala video codec

2016-01-01 Thread Rostislav Pehlivanov
I'm not sure about that, the page doesn't list what happens if an LGPL project uses some parts of a BSD project. The decoder was started from scratch and the parts which were taken from libdaala (DCTs, PVQ and the entropy decoder) have had major modifications done to them. So I still think it's fin

Re: [FFmpeg-devel] [PATCH] avcodec/utils: fix AVPacket lifetime in seek_frame_generic

2016-01-01 Thread Michael Niedermayer
On Sat, Jan 02, 2016 at 01:21:04AM +0100, Hendrik Leppkes wrote: > Fixes ticket #5117 > --- > libavformat/utils.c | 7 +-- > 1 file changed, 5 insertions(+), 2 deletions(-) LGTM thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB I know you won't believe m

Re: [FFmpeg-devel] [RFC v4] libbavcodec: add a native decoder for the Daala video codec

2016-01-01 Thread Rostislav Pehlivanov
Oh and by the way the title of the article is "Maintaining Permissive-Licensed Files in a GPL-Licensed Project: Guidelines for Developers". I read most of it and I'm under the impression that this is about keeping BSD code inside LGPL code but still allowing the BSD code to be used outside of the p

Re: [FFmpeg-devel] [PATCH] oggparsedaala: reject too large gpshift

2016-01-01 Thread Michael Niedermayer
On Wed, Dec 30, 2015 at 01:00:43AM +0100, Andreas Cadhalpun wrote: > On 29.12.2015 22:27, Rostislav Pehlivanov wrote: > > oggparsetheora has the same bit of code to read the gpshift, so it would > > probably be a good idea to add it to this patch as well. > > No, oggparsetheora only reads 5 bits f

Re: [FFmpeg-devel] [PATCH] avfilter: add swaprect filter

2016-01-01 Thread Michael Niedermayer
On Tue, Dec 08, 2015 at 12:58:15PM +0100, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > doc/filters.texi | 54 ++ > libavfilter/Makefile | 1 + > libavfilter/allfilters.c | 1 + > libavfilter/vf_swaprect.c | 267 > ++

Re: [FFmpeg-devel] [PATCH] ffmpeg: replace log2 by faster variant

2016-01-01 Thread Ganesh Ajjanagadde
On Wed, Dec 30, 2015 at 1:01 AM, Hendrik Leppkes wrote: > On Wed, Dec 30, 2015 at 4:39 AM, Ganesh Ajjanagadde > wrote: >> The log is anyway rounded to an integer, so one may use an frexp >> based approach. Note that this may be made frexpf; if arguments are less than >> 2^24 there is no loss. Kep

Re: [FFmpeg-devel] [PATCH] doc: make apidoc output independent of SRC_PATH

2016-01-01 Thread Michael Niedermayer
On Sun, Dec 20, 2015 at 11:31:29PM +0100, Andreas Cadhalpun wrote: > Previously it included the SRC_PATH in every title. > > Signed-off-by: Andreas Cadhalpun > --- > doc/Makefile| 7 --- > doc/doxy-wrapper.sh | 11 ++- > 2 files changed, 10 insertions(+), 8 deletions(-) sho

[FFmpeg-devel] PATCH] lavf/qtpalette: Ignore greyscale bit in certain cases

2016-01-01 Thread Mats Peterson
The QuickTime File Format Specification states the following: "Depth: A 16-bit integer that indicates the pixel depth of the compressed image. Values of 1, 2, 4, 8 ,16, 24, and 32 indicate the depth of color images. The value 32 should be used only if the image contains an alpha channel. Values o

[FFmpeg-devel] [PATCH] lavf/qtpalette: Ignore greyscale bit in certain cases

2016-01-01 Thread Mats Peterson
The QuickTime File Format Specification states the following: "Depth: A 16-bit integer that indicates the pixel depth of the compressed image. Values of 1, 2, 4, 8 ,16, 24, and 32 indicate the depth of color images. The value 32 should be used only if the image contains an alpha channel. Values o

Re: [FFmpeg-devel] [PATCH] lavf/qtpalette: Ignore greyscale bit in certain cases

2016-01-01 Thread Mats Peterson
On 01/02/2016 06:40 AM, Mats Peterson wrote: The text with the links got lost. And the second file is not Animation, but Graphics (smc). It's irrelevant, though. Sample file 1 (1-bit QuickTime Animation): https://drive.google.com/open?id=0B3_pEBoLs0faTThSek1EeXQ0ZHM Sample file 2 (8-bit Quick