Re: [FFmpeg-devel] [PATCH 5/9] x86: simple_idct10_template: fix overflow in pass

2015-10-13 Thread Christophe Gisquet
Hi, 2015-10-13 2:26 GMT+02:00 Michael Niedermayer : > On Mon, Oct 12, 2015 at 07:37:46PM +0200, Christophe Gisquet wrote: >> When the input of a pass has 15 or 16 bits of precision (in particular >> the column pass), the addition of a bias to W4 may lead to overflows >> in the input to pmaddwd. >>

Re: [FFmpeg-devel] mips & aac breakage

2015-10-13 Thread Nedeljko Babic
Hi Michael, I am checking fate test results and posts on the ffmpeg-devel list basically only once a day so thanks for this info. -Nedeljko Od: Michael Niedermayer [mich...@niedermayer.cc] Poslato: 13. oktobar 2015 4:57 Za: FFmpeg development discussions

Re: [FFmpeg-devel] [PATCH 2/9] fate: add 10bits YUV4:2:2 test

2015-10-13 Thread Christophe Gisquet
Hi, 2015-10-13 0:00 GMT+02:00 Michael Niedermayer : >> I'm so bad at this codec stuff. > > no, you are not, this stuff is rather convoluted and the mpegvideo > *dct stuff is not well documented. Sorry for the outburst, it was really frustrating to get caught in whatever hurdle a modification ran

Re: [FFmpeg-devel] [PATCH 2/9] fate: add 10bits YUV4:2:2 test

2015-10-13 Thread Christophe Gisquet
Hi, 2015-10-13 4:04 GMT+02:00 Michael Niedermayer : > wasnt that easy, there was another difference, between 32 and 64bit > it may be float rounding in the scaler but its not dnxhd i worked > around it by adjusting the scaler parameters. I'm not completely sure now, but I think I didn't run into

Re: [FFmpeg-devel] [PATCH] Stream specifier enhancement

2015-10-13 Thread Bodecs Bela
Dear Marton Balint, 2015.10.12. 23:07 keltezéssel, Marton Balint írta: On Mon, 12 Oct 2015, Bodecs Bela wrote: Dear All, currently stream specifiers may contain stream index, stream type, stream id, program id, metadata key/value es usable config settings. But you can not combine them. In so

Re: [FFmpeg-devel] [PATCH] avfilter, swresample, swscale: use fabs, fabsf instead of FFABS

2015-10-13 Thread Paul B Mahol
On 10/13/15, Clement Boesch wrote: > On Tue, Oct 13, 2015 at 12:31:10AM -0400, Ganesh Ajjanagadde wrote: >> On Tue, Oct 13, 2015 at 12:26 AM, Ganesh Ajjanagadde >> wrote: >> > On Tue, Oct 13, 2015 at 12:16 AM, Carl Eugen Hoyos >> > wrote: >> >> Ganesh Ajjanagadde mit.edu> writes: >> >> >> >>> B

Re: [FFmpeg-devel] [PATCH] vf_lut: Add support for RGB48 and RGBA64

2015-10-13 Thread Paul B Mahol
On 10/11/15, Steven Robertson wrote: > Thanks for taking a look! > > Steve > lgtm, do you need to update fate? ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avfilter, swresample, swscale: use fabs, fabsf instead of FFABS

2015-10-13 Thread Clément Bœsch
On Tue, Oct 13, 2015 at 09:25:03AM +0200, Paul B Mahol wrote: [...] > What about fmax/FFMAX? Feel free to try that out (it looks OT regarding the patch), but fmax() looks glibc specific -- Clément B. signature.asc Description: PGP signature ___ ffmpe

Re: [FFmpeg-devel] [RFC] QSV support clarifications

2015-10-13 Thread Gwenole Beauchesne
Hi, 2015-10-12 20:10 GMT+02:00 Stefano Sabatini : > Hi all, > > I wanted to test QSV encoding and decoding, which is included since > several months in FFmpeg, and have a few questions. > > 1. QSV encoding and decoding depends on libmfx, but no references are > present in the code to the library,

Re: [FFmpeg-devel] [PATCH] avfilter/avf_showcqt: fix frame management

2015-10-13 Thread Muhammad Faiz
On Tue, Oct 13, 2015 at 1:31 PM, Clément Bœsch wrote: > > Did you test if you get the same results with and without the perms > filter? > it gives mostly same result (e.g in common usage with ffplay) it gives more correct result when you still need frame reference like this code // buffersink i

Re: [FFmpeg-devel] [PATCH] avcodec/fft: out of place permutation with av_fft_permute2

2015-10-13 Thread Muhammad Faiz
remaining patches (2 patches) i am sorry i dont send them as patchset thanks From 83b82b028232d1bbe91b636a94ad68b6d8026dab Mon Sep 17 00:00:00 2001 From: Muhammad Faiz Date: Tue, 13 Oct 2015 11:59:21 +0700 Subject: [PATCH] avcodec/x86/fft: use default fft_permute default fft_permute is faster --

[FFmpeg-devel] [PATCH] avfilter/fifo: fix failed assertion

2015-10-13 Thread Muhammad Faiz
From 93ba60f844d8e81435eeefe6cc7cac2d79d518c6 Mon Sep 17 00:00:00 2001 From: Muhammad Faiz Date: Tue, 13 Oct 2015 15:09:17 +0700 Subject: [PATCH] avfilter/fifo: fix failed assertion some filters make fifo filter fail: at least showcqt and showwaves (i don't check all) command: ffmpeg -loglevel d

Re: [FFmpeg-devel] [PATCH 3/3][RFC] avfilter/vf_chromakey: Add OpenCL acceleration

2015-10-13 Thread highgod0401
From: Timo Rothenpieler Date: 2015-10-10 17:47 To: FFmpeg development discussions and patches CC: highgod0401 Subject: Re: [FFmpeg-devel] [PATCH 3/3][RFC] avfilter/vf_chromakey: Add OpenCL acceleration > Could you please fix it? > > Thanks > > Best regards curl https://github.com/BtbN/FFmpeg/c

Re: [FFmpeg-devel] Survey for the community

2015-10-13 Thread Thomas Volkert
On Fri, Oct 09, 2015 at 06:13:05PM +0200, Clément Bœsch wrote: [...] You have 24 hours to make comments. 24 hours is IMHO too little. What is the hurry? Maybe at least 96 hours? People had time to comment on the thread already, but sure OK for 96 hours. Not sure if I counted well, but the su

[FFmpeg-devel] [PATCH] avformat: add genh demuxer

2015-10-13 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/genh.c | 113 +++ 3 files changed, 115 insertions(+) create mode 100644 libavformat/genh.c diff --git a/libavformat/Makefile b/libavf

Re: [FFmpeg-devel] [PATCH 3/3][RFC] avfilter/vf_chromakey: Add OpenCL acceleration

2015-10-13 Thread Timo Rothenpieler
Hi I use your filter, but the kernel can't pass the compile, you should consider the "double" type in the kernel, some GPU card does not support double type I add "#pragma OPENCL_EXTENSION cl_khr_fp64: enable " to the kernel, but it does not works I will check the error tomorrow I tested thi

[FFmpeg-devel] [PATCH 1/2] avutil/fifo: add function av_fifo_generic_peek_at()

2015-10-13 Thread Zhang Rui
--- libavutil/fifo.c| 37 + libavutil/fifo.h| 11 +++ tests/ref/fate/fifo | 14 ++ 3 files changed, 62 insertions(+) diff --git a/libavutil/fifo.c b/libavutil/fifo.c index 07fb4ec..cabb009 100644 --- a/libavutil/fifo.c +++ b/libavuti

[FFmpeg-devel] [PATCH 2/2] avformat/async: cache some data for fast seek backward

2015-10-13 Thread Zhang Rui
--- libavformat/async.c | 123 1 file changed, 104 insertions(+), 19 deletions(-) diff --git a/libavformat/async.c b/libavformat/async.c index a8c8f54..9fac84a 100644 --- a/libavformat/async.c +++ b/libavformat/async.c @@ -24,7 +24,6 @@ /**

Re: [FFmpeg-devel] RTP API in ffmpeg

2015-10-13 Thread Ronald S. Bultje
Hi, On Tue, Oct 13, 2015 at 2:47 AM, Abhilash Mhaisne wrote: > Hey all, > Does ffmpeg have an API for the real time transport protocol? > If yes, can you give links? I am unable to find. Just open a rtp://ip.ip.ip.ip:port link as argument to avformat_open_input. You can use privat

Re: [FFmpeg-devel] [PATCH 5/9] x86: simple_idct10_template: fix overflow in pass

2015-10-13 Thread Michael Niedermayer
On Tue, Oct 13, 2015 at 09:01:44AM +0200, Christophe Gisquet wrote: > Hi, > > 2015-10-13 2:26 GMT+02:00 Michael Niedermayer : > > On Mon, Oct 12, 2015 at 07:37:46PM +0200, Christophe Gisquet wrote: > >> When the input of a pass has 15 or 16 bits of precision (in particular > >> the column pass), t

Re: [FFmpeg-devel] [RFC] QSV support clarifications

2015-10-13 Thread Michael Niedermayer
CC-ing Ivan so he doesnt miss this though he should be following ffmpeg-devel and keeping an eye on qsv anyway ... On Mon, Oct 12, 2015 at 08:10:04PM +0200, Stefano Sabatini wrote: > Hi all, > > I wanted to test QSV encoding and decoding, which is included since > several months in FFmpeg, and ha

Re: [FFmpeg-devel] [PATCH]vc1 Autodetection

2015-10-13 Thread Carl Eugen Hoyos
On Monday 05 October 2015 03:53:32 am Michael Niedermayer wrote: > On Sun, Oct 04, 2015 at 11:47:59PM +0200, Carl Eugen Hoyos wrote: > > Hi! > > > > Attached is a patch implementing vc-1 autodetection. > > > > Please review, Carl Eugen > > > > Makefile |2 - > > rawdec.c |4 --- > > vc1d

Re: [FFmpeg-devel] [PATCH 5/9] x86: simple_idct10_template: fix overflow in pass

2015-10-13 Thread Christophe Gisquet
Hi, 2015-10-13 13:10 GMT+02:00 Michael Niedermayer : > hmm, iam a bit concerned that adding the rounder (which effectively is > 0.5) causes a overflow, that would if iam not mistaken imlpy that > things are very close to overflowing already without it It's true, but the immediate cause here is th

Re: [FFmpeg-devel] [PATCH 2/9] fate: add 10bits YUV4:2:2 test

2015-10-13 Thread Christophe Gisquet
2015-10-13 9:06 GMT+02:00 Christophe Gisquet : >I think I didn't run into those failures under Win64. Confirmed, as well as under Win32 (also gcc 5.2.0) and gcc x86_64 4.9.2 under a linux environment. -- Christophe ___ ffmpeg-devel mailing list ffmpeg-

Re: [FFmpeg-devel] [RFC] QSV support clarifications

2015-10-13 Thread Ivan Uskov
Hello Stefano, Monday, October 12, 2015, 9:10:04 PM, you wrote: SS> 2. The mfx_dispatch library compiles fine on my system, but then I SS> wonder how it is supposed to reference the Intel Media library: SS> https://software.intel.com/en-us/intel-media-server-studio SS> ... SS> I'm able to compil

Re: [FFmpeg-devel] [PATCH 01/10] lavu: add AESNI CPU flag

2015-10-13 Thread Moritz Barsnick
On Tue, Oct 13, 2015 at 04:27:07 +0200, Michael Niedermayer wrote: > > @@ -117,6 +117,7 @@ static const struct { > > { "SSSE3","ssse3",AV_CPU_FLAG_SSSE3|AV_CPU_FLAG_ATOM }, > > { "SSE4.1", "sse4", AV_CPU_FLAG_SSE4 }, > > { "SSE4.2", "sse42",AV_CPU_FLAG_SSE42 }, >

[FFmpeg-devel] [PATCH 2/2] avformat: add vag demuxer

2015-10-13 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/vag.c| 78 3 files changed, 80 insertions(+) create mode 100644 libavformat/vag.c diff --git a/libavformat/Makefile b/libavforma

[FFmpeg-devel] [PATCH 1/2] avcodec: add ADPCM PSX decoder

2015-10-13 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavcodec/Makefile| 1 + libavcodec/adpcm.c | 43 +++ libavcodec/allcodecs.c | 1 + libavcodec/avcodec.h | 1 + 4 files changed, 46 insertions(+) diff --git a/libavcodec/Makefile b/libavcodec/Makefile index b8b

Re: [FFmpeg-devel] [PATCH] avfilter, swresample, swscale: use fabs, fabsf instead of FFABS

2015-10-13 Thread Ganesh Ajjanagadde
On Tue, Oct 13, 2015 at 2:45 AM, Clément Bœsch wrote: > On Tue, Oct 13, 2015 at 12:31:10AM -0400, Ganesh Ajjanagadde wrote: >> On Tue, Oct 13, 2015 at 12:26 AM, Ganesh Ajjanagadde >> wrote: >> > On Tue, Oct 13, 2015 at 12:16 AM, Carl Eugen Hoyos >> > wrote: >> >> Ganesh Ajjanagadde mit.edu> w

Re: [FFmpeg-devel] [PATCH] avfilter, swresample, swscale: use fabs, fabsf instead of FFABS

2015-10-13 Thread Ganesh Ajjanagadde
On Tue, Oct 13, 2015 at 4:02 AM, Clément Bœsch wrote: > On Tue, Oct 13, 2015 at 09:25:03AM +0200, Paul B Mahol wrote: > [...] >> What about fmax/FFMAX? > > Feel free to try that out (it looks OT regarding the patch), but fmax() > looks glibc specific Maybe (long term) we can use an av_fabs, av_fa

Re: [FFmpeg-devel] [PATCH] news: add thank you note for telepoint/mediahub

2015-10-13 Thread compn
On Mon, 12 Oct 2015 15:10:22 -0700 "Reynaldo H. Verdejo Pinochet" wrote: > Signed-off-by: Reynaldo H. Verdejo Pinochet > --- > src/index | 33 + > 1 file changed, 33 insertions(+) thanks applied. -compn ___ ffmpeg-d

[FFmpeg-devel] [PATCHv2] web/src/about: add note on portability

2015-10-13 Thread Ganesh Ajjanagadde
--- src/about | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/about b/src/about index 8d8f606..cd0da12 100644 --- a/src/about +++ b/src/about @@ -4,7 +4,11 @@ transcode, mux, demux, stream, filter and play pretty much anything that humans and machines have cr

Re: [FFmpeg-devel] [PATCH] web/src/about: add note on portability

2015-10-13 Thread Ganesh Ajjanagadde
On Mon, Oct 12, 2015 at 3:44 PM, Ganesh Ajjanagadde wrote: > On Sun, Oct 11, 2015 at 8:27 PM, Ganesh Ajjanagadde wrote: >> On Sun, Oct 11, 2015 at 6:00 PM, Moritz Barsnick wrote: >>> On Sun, Oct 11, 2015 at 16:29:16 -0400, Ganesh Ajjanagadde wrote: + Microsoft Windows, the BSD's, Solaris,

Re: [FFmpeg-devel] [PATCH] news: add thank you note for telepoint/mediahub

2015-10-13 Thread Ganesh Ajjanagadde
On Tue, Oct 13, 2015 at 9:13 AM, compn wrote: > On Mon, 12 Oct 2015 15:10:22 -0700 > "Reynaldo H. Verdejo Pinochet" wrote: > >> Signed-off-by: Reynaldo H. Verdejo Pinochet >> --- >> src/index | 33 + >> 1 file changed, 33 insertions(+) > > thanks > > applied. Wa

Re: [FFmpeg-devel] [PATCH 7/9] x86: simple_idct: add pure idct functions

2015-10-13 Thread Michael Niedermayer
On Mon, Oct 12, 2015 at 07:37:48PM +0200, Christophe Gisquet wrote: > This is done by not passing clamping regs to the macro, and there, > deducing that this is a pure idct. > > There are not many users (vf_spp is one), and the _add version doesn't > look like it will ever be used. > --- > libavc

Re: [FFmpeg-devel] [PATCH] news: add thank you note for telepoint/mediahub

2015-10-13 Thread compn
On Tue, 13 Oct 2015 09:18:35 -0400 Ganesh Ajjanagadde wrote: > On Tue, Oct 13, 2015 at 9:13 AM, compn wrote: > > On Mon, 12 Oct 2015 15:10:22 -0700 > > "Reynaldo H. Verdejo Pinochet" wrote: > > > >> Signed-off-by: Reynaldo H. Verdejo Pinochet > >> --- > >> src/index | 33 +

Re: [FFmpeg-devel] [PATCH 6/9] x86: simple_idct_put: 10bits versions

2015-10-13 Thread Michael Niedermayer
On Mon, Oct 12, 2015 at 07:37:47PM +0200, Christophe Gisquet wrote: > Modeled from the prores version. Clips to [0;1023] and is bitexact. > Bitexactness requires to add offsets in different places compared to > prores or C, and makes the function approximately 2% slower. > > For 16 frames of a DNx

Re: [FFmpeg-devel] [PATCH 5/9] x86: simple_idct10_template: fix overflow in pass

2015-10-13 Thread Michael Niedermayer
On Tue, Oct 13, 2015 at 01:33:07PM +0200, Christophe Gisquet wrote: > Hi, > > 2015-10-13 13:10 GMT+02:00 Michael Niedermayer : > > hmm, iam a bit concerned that adding the rounder (which effectively is > > 0.5) causes a overflow, that would if iam not mistaken imlpy that > > things are very close

Re: [FFmpeg-devel] [RFC] avformat/mxfenc: stop encoding if unfilled video packet

2015-10-13 Thread Tobias Rapp
On 13.10.2015 08:42, Tomas Härdin wrote: On Mon, 2015-10-05 at 14:25 +0200, Tobias Rapp wrote: On 05.10.2015 09:10, tim nicholson wrote: On 04/10/15 13:07, Tomas Härdin wrote: On Mon, 2015-09-28 at 15:11 +0200, Tobias Rapp wrote: [...] For me the most important thing is that anything dealin

Re: [FFmpeg-devel] [PATCH 8/9] x86: simple_idct: 12bits versions

2015-10-13 Thread Michael Niedermayer
On Mon, Oct 12, 2015 at 07:37:49PM +0200, Christophe Gisquet wrote: > On 12 frames of a 444p 12 bits DNxHR sequence, _put function: > C: 78902 decicycles in idct, 262071 runs, 73 skips > avx: 32478 decicycles in idct, 262045 runs, 99 skips > > Difference between the 2: > st

[FFmpeg-devel] [PATCH] avcodec/mips/aaccoder_mips: Sync with the generic code

2015-10-13 Thread Nedeljko Babic
This patch fixes build of AAC encoder optimized for mips that was broken due to some changes in generic code that were not propagated to the optimized code. Also, some functions in the optimized code are basically duplicate of functions from generic code. Since they do not bring enough improveme

Re: [FFmpeg-devel] [PATCH 9/9] x86: dct-test: add more idcts

2015-10-13 Thread Michael Niedermayer
On Mon, Oct 12, 2015 at 07:37:50PM +0200, Christophe Gisquet wrote: > In particular for 10 and 12 bits. > --- > libavcodec/dct-test.c | 2 ++ > libavcodec/x86/dct-test.c | 10 ++ > 2 files changed, 12 insertions(+) > > diff --git a/libavcodec/dct-test.c b/libavcodec/dct-test.c > inde

Re: [FFmpeg-devel] [PATCH 01/10] lavu: add AESNI CPU flag

2015-10-13 Thread Michael Niedermayer
On Tue, Oct 13, 2015 at 02:46:55PM +0200, Moritz Barsnick wrote: > On Tue, Oct 13, 2015 at 04:27:07 +0200, Michael Niedermayer wrote: > > > @@ -117,6 +117,7 @@ static const struct { > > > { "SSSE3","ssse3",AV_CPU_FLAG_SSSE3|AV_CPU_FLAG_ATOM }, > > > { "SSE4.1", "sse4", AV_CP

Re: [FFmpeg-devel] [PATCHv2] web/src/about: add note on portability

2015-10-13 Thread Moritz Barsnick
> + environments, machine architecture, and configurations. ^^ plural -> architectures Moritz ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 06/10] lavu/aes: add x86 AESNI optimizations

2015-10-13 Thread Henrik Gramner
On Tue, Oct 13, 2015 at 2:33 AM, Rodger Combs wrote: > +%macro AES_CRYPT 1 > +%if %1 == 1 > +%define CRYPT aesdec > +%define LAST aesdeclast > +cglobal aes_decrypt, 6,6,2 > +%else > +%define CRYPT aesenc > +%define LAST aesenclast > +cglobal aes_encrypt, 6,6,2 > +%endif > +pxor xm1, xm1 > +

Re: [FFmpeg-devel] [PATCH 5/9] x86: simple_idct10_template: fix overflow in pass

2015-10-13 Thread Christophe Gisquet
2015-10-13 15:43 GMT+02:00 Michael Niedermayer : > On Tue, Oct 13, 2015 at 01:33:07PM +0200, Christophe Gisquet wrote: >> Hi, >> >> 2015-10-13 13:10 GMT+02:00 Michael Niedermayer : >> > hmm, iam a bit concerned that adding the rounder (which effectively is >> > 0.5) causes a overflow, that would if

[FFmpeg-devel] [PATCHv3] web/src/about: add note on portability

2015-10-13 Thread Ganesh Ajjanagadde
--- src/about | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/about b/src/about index 8d8f606..67342a1 100644 --- a/src/about +++ b/src/about @@ -4,7 +4,11 @@ transcode, mux, demux, stream, filter and play pretty much anything that humans and machines have cr

Re: [FFmpeg-devel] [PATCH] avcodec/mips/aaccoder_mips: Sync with the generic code

2015-10-13 Thread Michael Niedermayer
On Tue, Oct 13, 2015 at 04:14:51PM +0200, Nedeljko Babic wrote: > This patch fixes build of AAC encoder optimized for mips that was broken due > to some changes in generic code that were not propagated to the optimized > code. > > Also, some functions in the optimized code are basically duplicat

[FFmpeg-devel] [PATCHv2] avformat/mov: fix integer overflow

2015-10-13 Thread Ganesh Ajjanagadde
Partially fixes Ticket 4727. -duration is not a safe expression, since duration can be INT_MIN. One might ask how it can become INT_MIN. Although it is true that line 2574 is no longer reached with INT_MIN due to commit 053e80f6eaf8d87521fe58ea96886b6ee0bbe59d (which fixed another integer overflow

Re: [FFmpeg-devel] [PATCH 5/9] x86: simple_idct10_template: fix overflow in pass

2015-10-13 Thread Christophe Gisquet
2015-10-13 17:44 GMT+02:00 Christophe Gisquet : > But I'll check. Indeed not bit-exact to faani and C simple idct: stddev:0.00 PSNR:163.48 MAXDIFF:1 This would at least result in fate no longer passing as this stands. I don't think it's worth the speed difference. No change on dct-test r

Re: [FFmpeg-devel] [PATCH 1/2] avutil/fifo: add function av_fifo_generic_peek_at()

2015-10-13 Thread Michael Niedermayer
On Tue, Oct 13, 2015 at 06:30:46PM +0800, Zhang Rui wrote: > --- > libavutil/fifo.c| 37 + > libavutil/fifo.h| 11 +++ > tests/ref/fate/fifo | 14 ++ > 3 files changed, 62 insertions(+) > > diff --git a/libavutil/fifo.c b/libavutil/f

[FFmpeg-devel] Warnings (Was: Re: [PATCH 1/2] avutil/attributes: extend av_uninit to clang)

2015-10-13 Thread Moritz Barsnick
On Wed, Oct 07, 2015 at 23:35:08 +0200, Moritz Barsnick wrote: > On Wed, Oct 07, 2015 at 16:07:53 -0400, Ronald S. Bultje wrote: > > > BTW, are the "remaining" (meaning: more than from gcc) warnings emitted > > > by the Intel C(++) Compiler redundant or false? The icc configuration > > > should the

Re: [FFmpeg-devel] [PATCHv2] avformat/mov: fix integer overflow

2015-10-13 Thread Michael Niedermayer
On Tue, Oct 13, 2015 at 12:26:24PM -0400, Ganesh Ajjanagadde wrote: > Partially fixes Ticket 4727. > > -duration is not a safe expression, since duration can be INT_MIN. > One might ask how it can become INT_MIN. > Although it is true that line 2574 is no longer reached with INT_MIN due > to commi

Re: [FFmpeg-devel] [PATCH 2/2] avformat: add vag demuxer

2015-10-13 Thread Michael Niedermayer
On Tue, Oct 13, 2015 at 03:07:36PM +0200, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libavformat/Makefile | 1 + > libavformat/allformats.c | 1 + > libavformat/vag.c| 78 > > 3 files changed, 80 insertions(+) > creat

[FFmpeg-devel] [PATCH 1/3] x86: simple_idct10_template: use const

2015-10-13 Thread Christophe Gisquet
This avoid going through constants.c while still sharing them with proresdsp.asm --- libavcodec/x86/constants.c| 28 libavcodec/x86/constants.h| 16 libavcodec/x86/proresdsp.asm | 13 + libavcode

[FFmpeg-devel] [PATCH 3/3] fate: add 12bpp sample

2015-10-13 Thread Christophe Gisquet
Allows testing simple_idct12 correctness/bitexactness, as the sample was generated using faani as idct. --- tests/fate/image.mak | 6 ++ tests/ref/fate/jpg-12bpp | 2 ++ 2 files changed, 8 insertions(+) create mode 100644 tests/ref/fate/jpg-12bpp diff --git a/tests/fate/image.mak b/tests

[FFmpeg-devel] [PATCH 2/3] simple_idct12: align C and x86

2015-10-13 Thread Christophe Gisquet
Results for omse on the 3 idct dct-test. C: 0.16915859 0.11848359 0.12913125 x86: 0.16883281 0.11849063 0.19041875 Using 14 and 17 as shifts subtantially improve those, but actually cause overflows and incorrect decoding of 12bpp content. --- libavcodec/simple_idct_template.c | 17

[FFmpeg-devel] [PATCH 0/3] simple_idct leftovers

2015-10-13 Thread Christophe Gisquet
First patch addresses an issue raised by Donald. Second is one forgotten during the patchset iterations Third requires sample from ticket #4683, whose license isn't clear, all the more since it has a watermark indicating an unlicensed s/w. Having a 12bpp sample of that nature has been however very

Re: [FFmpeg-devel] [PATCH 0/3] simple_idct leftovers

2015-10-13 Thread Christophe Gisquet
While I'm at it, I've tested the 8-bits version, with the following omse results: SIMPLE: 0.00851563 0.00675937 0.00273906 xvid: 0.00917266 0.01386797 0.00784922 SIMPLE8: 0.00756641 0.00654844 0. I don't think having yet another idct8x8 is so nice, so I'm not going to submit a

Re: [FFmpeg-devel] [PATCH 2/9] fate: add 10bits YUV4:2:2 test

2015-10-13 Thread James Almer
On 10/12/2015 11:04 PM, Michael Niedermayer wrote: > On Tue, Oct 13, 2015 at 12:00:07AM +0200, Michael Niedermayer wrote: >> On Mon, Oct 12, 2015 at 10:39:23PM +0200, Christophe Gisquet wrote: >>> Le 12 oct. 2015 21:37, "Michael Niedermayer" a >>> écrit : On Mon, Oct 12, 2015 at 07:37:43

Re: [FFmpeg-devel] [PATCH] ffserver_config: check for INT_MIN before doing FFABS

2015-10-13 Thread Michael Niedermayer
On Fri, Oct 09, 2015 at 11:31:22AM -0400, Ganesh Ajjanagadde wrote: > FFABS(INT_MIN) is not safe. Alternative of using FFNABS is not as > readable. > > Signed-off-by: Ganesh Ajjanagadde > --- > ffserver_config.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) LGTM thanks [...] -- Mic

Re: [FFmpeg-devel] [PATCH 2/9] fate: add 10bits YUV4:2:2 test

2015-10-13 Thread Christophe Gisquet
Hi, 2015-10-13 21:41 GMT+02:00 James Almer : > This test is failing on pretty much every fate client. Valgrind seems to > complain about uninitialized values. > http://fate.ffmpeg.org/report.cgi?time=20151013040721&slot=x86_64-archlinux-gcc-valgrindundef Can someone test the following patch? I do

Re: [FFmpeg-devel] [PATCH 1/3] x86: simple_idct10_template: use const

2015-10-13 Thread Ronald S. Bultje
Hi, On Tue, Oct 13, 2015 at 3:21 PM, Christophe Gisquet < christophe.gisq...@gmail.com> wrote: > This avoid going through constants.c while still sharing them > with proresdsp.asm > --- > libavcodec/x86/constants.c| 28 > > libavcodec/x86/constants.h

Re: [FFmpeg-devel] [PATCH 06/10] lavu/aes: add x86 AESNI optimizations

2015-10-13 Thread Henrik Gramner
I changed the asm a bit and made it about 1 cycle faster on Haswell and slightly smaller (-48 bytes overall incl. alignment on 64-bit Linux). %macro AES_CRYPT 1 cglobal aes_%1rypt, 6,6,2 shl r3d, 4 add r5d, r5d add r0, 0x60 add r2, r3 add r1, r3

Re: [FFmpeg-devel] [PATCH 1/3] x86: simple_idct10_template: use const

2015-10-13 Thread Michael Niedermayer
On Tue, Oct 13, 2015 at 04:10:15PM -0400, Ronald S. Bultje wrote: > Hi, > > On Tue, Oct 13, 2015 at 3:21 PM, Christophe Gisquet < > christophe.gisq...@gmail.com> wrote: > > > This avoid going through constants.c while still sharing them > > with proresdsp.asm > > --- > > libavcodec/x86/constants

Re: [FFmpeg-devel] [PATCH 07/10] checkasm: add tests for AES

2015-10-13 Thread Henrik Gramner
Added some randomization to count and made report() less verbose: diff --git a/tests/checkasm/aes.c b/tests/checkasm/aes.c index 67b..4549a3d 100644 --- a/tests/checkasm/aes.c +++ b/tests/checkasm/aes.c @@ -23,12 +23,14 @@ #include "libavutil/aes_internal.h" #include "libavutil/internal.h"

Re: [FFmpeg-devel] [PATCH 07/10] checkasm: add tests for AES

2015-10-13 Thread Ganesh Ajjanagadde
On Tue, Oct 13, 2015 at 5:06 PM, Henrik Gramner wrote: > Added some randomization to count and made report() less verbose: > > diff --git a/tests/checkasm/aes.c b/tests/checkasm/aes.c > index 67b..4549a3d 100644 > --- a/tests/checkasm/aes.c > +++ b/tests/checkasm/aes.c > @@ -23,12 +23,14 @@ >

[FFmpeg-devel] [PATCH] concatdec: fix file_start_time calculation regression

2015-10-13 Thread Marton Balint
Fixes ticket #4924. Found-by: Jaroslav Šnajdr Signed-off-by: Marton Balint --- libavformat/concatdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/concatdec.c b/libavformat/concatdec.c index 832b7f4..7686f28 100644 --- a/libavformat/concatdec.c +++ b/libavfor

Re: [FFmpeg-devel] [PATCH 2/9] fate: add 10bits YUV4:2:2 test

2015-10-13 Thread James Almer
On 10/13/2015 5:06 PM, Christophe Gisquet wrote: > Hi, > > 2015-10-13 21:41 GMT+02:00 James Almer : >> > This test is failing on pretty much every fate client. Valgrind seems to >> > complain about uninitialized values. >> > http://fate.ffmpeg.org/report.cgi?time=20151013040721&slot=x86_64-archlin

Re: [FFmpeg-devel] [PATCH 07/10] checkasm: add tests for AES

2015-10-13 Thread Henrik Gramner
On Tue, Oct 13, 2015 at 11:28 PM, Ganesh Ajjanagadde wrote: > Not really that important, but unless this increases FATE time > significantly, I would recommend a much larger MAX_COUNT, and multiple > iterations (e.g #define an ITER_COUNT), so that the testing is more > extensive over random inputs

Re: [FFmpeg-devel] [PATCH 07/10] checkasm: add tests for AES

2015-10-13 Thread Ganesh Ajjanagadde
On Tue, Oct 13, 2015 at 5:55 PM, Henrik Gramner wrote: > On Tue, Oct 13, 2015 at 11:28 PM, Ganesh Ajjanagadde wrote: >> Not really that important, but unless this increases FATE time >> significantly, I would recommend a much larger MAX_COUNT, and multiple >> iterations (e.g #define an ITER_COUNT

Re: [FFmpeg-devel] [PATCH 2/3] simple_idct12: align C and x86

2015-10-13 Thread Michael Niedermayer
On Tue, Oct 13, 2015 at 09:21:40PM +0200, Christophe Gisquet wrote: > Results for omse on the 3 idct dct-test. > > C: 0.16915859 0.11848359 0.12913125 > x86: 0.16883281 0.11849063 0.19041875 > > Using 14 and 17 as shifts subtantially improve those, but actually > cause overflows and inc

Re: [FFmpeg-devel] [PATCH 2/3] simple_idct12: align C and x86

2015-10-13 Thread Ganesh Ajjanagadde
On Tue, Oct 13, 2015 at 6:04 PM, Michael Niedermayer wrote: > On Tue, Oct 13, 2015 at 09:21:40PM +0200, Christophe Gisquet wrote: >> Results for omse on the 3 idct dct-test. >> >> C: 0.16915859 0.11848359 0.12913125 >> x86: 0.16883281 0.11849063 0.19041875 >> >> Using 14 and 17 as shifts

Re: [FFmpeg-devel] [PATCH 07/10] checkasm: add tests for AES

2015-10-13 Thread Henrik Gramner
On Tue, Oct 13, 2015 at 11:58 PM, Ganesh Ajjanagadde wrote: > On Tue, Oct 13, 2015 at 5:55 PM, Henrik Gramner wrote: >> On Tue, Oct 13, 2015 at 11:28 PM, Ganesh Ajjanagadde >> wrote: >>> Not really that important, but unless this increases FATE time >>> significantly, I would recommend a much l

Re: [FFmpeg-devel] [PATCH 07/10] checkasm: add tests for AES

2015-10-13 Thread Ganesh Ajjanagadde
On Tue, Oct 13, 2015 at 6:16 PM, Henrik Gramner wrote: > On Tue, Oct 13, 2015 at 11:58 PM, Ganesh Ajjanagadde wrote: >> On Tue, Oct 13, 2015 at 5:55 PM, Henrik Gramner wrote: >>> On Tue, Oct 13, 2015 at 11:28 PM, Ganesh Ajjanagadde >>> wrote: Not really that important, but unless this inc

[FFmpeg-devel] [PATCH] avutil: install des.h, rc4.h and tree.h as public headers

2015-10-13 Thread Andreas Cadhalpun
These headers contain functions supposed to be public. libavutil/des.h: av_des_alloc av_des_crypt av_des_init av_des_mac libavutil/rc4.h: av_rc4_alloc av_rc4_crypt av_rc4_init libavutil/tree.h av_tree_destroy av_tree_enumerate av_tree_find av_tree_insert av_tree_node_alloc av_tree_nod

Re: [FFmpeg-devel] [PATCH 3/3] fate: add 12bpp sample

2015-10-13 Thread Michael Niedermayer
On Tue, Oct 13, 2015 at 09:21:41PM +0200, Christophe Gisquet wrote: > Allows testing simple_idct12 correctness/bitexactness, as the sample > was generated using faani as idct. > --- > tests/fate/image.mak | 6 ++ > tests/ref/fate/jpg-12bpp | 2 ++ > 2 files changed, 8 insertions(+) > crea

Re: [FFmpeg-devel] [PATCH] avfilter, swresample, swscale: use fabs, fabsf instead of FFABS

2015-10-13 Thread Ganesh Ajjanagadde
On Tue, Oct 13, 2015 at 9:12 AM, Ganesh Ajjanagadde wrote: > On Tue, Oct 13, 2015 at 4:02 AM, Clément Bœsch wrote: >> On Tue, Oct 13, 2015 at 09:25:03AM +0200, Paul B Mahol wrote: >> [...] >>> What about fmax/FFMAX? >> >> Feel free to try that out (it looks OT regarding the patch), but fmax() >>

Re: [FFmpeg-devel] [PATCH] intmath: remove av_ctz.

2015-10-13 Thread Andreas Cadhalpun
On 13.10.2015 04:21, Michael Niedermayer wrote: > On Mon, Oct 12, 2015 at 08:15:10PM +0200, Andreas Cadhalpun wrote: >> It seems several headers are intended to be installed, but actually aren't: > >> libavutil/des.h: >> av_des_alloc >> av_des_crypt >> av_des_init >> av_des_mac >> libavutil/rc

Re: [FFmpeg-devel] [PATCH 2/9] fate: add 10bits YUV4:2:2 test

2015-10-13 Thread Michael Niedermayer
On Tue, Oct 13, 2015 at 04:41:50PM -0300, James Almer wrote: > On 10/12/2015 11:04 PM, Michael Niedermayer wrote: > > On Tue, Oct 13, 2015 at 12:00:07AM +0200, Michael Niedermayer wrote: > >> On Mon, Oct 12, 2015 at 10:39:23PM +0200, Christophe Gisquet wrote: > >>> Le 12 oct. 2015 21:37, "Michael N

[FFmpeg-devel] [PATCH] x86/vp9itxfm: fix register clobbering in ff_vp9_idct_idct_4x4_add_12_sse2

2015-10-13 Thread James Almer
Signed-off-by: James Almer --- libavcodec/x86/vp9itxfm_16bpp.asm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/x86/vp9itxfm_16bpp.asm b/libavcodec/x86/vp9itxfm_16bpp.asm index 06b39ff..902685e 100644 --- a/libavcodec/x86/vp9itxfm_16bpp.asm +++ b/libavcodec/x86/vp

Re: [FFmpeg-devel] [PATCH] x86/vp9itxfm: fix register clobbering in ff_vp9_idct_idct_4x4_add_12_sse2

2015-10-13 Thread Henrik Gramner
On Wed, Oct 14, 2015 at 1:04 AM, James Almer wrote: > Signed-off-by: James Almer > --- > libavcodec/x86/vp9itxfm_16bpp.asm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/x86/vp9itxfm_16bpp.asm > b/libavcodec/x86/vp9itxfm_16bpp.asm > index 06b39ff..902685e 10

Re: [FFmpeg-devel] [PATCH] Stream specifier enhancement

2015-10-13 Thread Marton Balint
On Tue, 13 Oct 2015, Bodecs Bela wrote: Dear Marton Balint, 2015.10.12. 23:07 keltezéssel, Marton Balint írta: On Mon, 12 Oct 2015, Bodecs Bela wrote: Dear All, currently stream specifiers may contain stream index, stream type, stream id, program id, metadata key/value es usable config se

Re: [FFmpeg-devel] [PATCH] x86/vp9itxfm: fix register clobbering in ff_vp9_idct_idct_4x4_add_12_sse2

2015-10-13 Thread James Almer
On 10/13/2015 8:10 PM, Henrik Gramner wrote: > On Wed, Oct 14, 2015 at 1:04 AM, James Almer wrote: >> Signed-off-by: James Almer >> --- >> libavcodec/x86/vp9itxfm_16bpp.asm | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/libavcodec/x86/vp9itxfm_16bpp.asm >> b/libavco

Re: [FFmpeg-devel] [PATCH] avutil: install des.h, rc4.h and tree.h as public headers

2015-10-13 Thread James Almer
On 10/13/2015 7:37 PM, Andreas Cadhalpun wrote: > These headers contain functions supposed to be public. > > libavutil/des.h: > av_des_alloc > av_des_crypt > av_des_init > av_des_mac > libavutil/rc4.h: > av_rc4_alloc > av_rc4_crypt > av_rc4_init Since these two were never installed, we can

Re: [FFmpeg-devel] [PATCH] news: add thank you note for telepoint/mediahub

2015-10-13 Thread Ganesh Ajjanagadde
On Tue, Oct 13, 2015 at 9:37 AM, compn wrote: > On Tue, 13 Oct 2015 09:18:35 -0400 > Ganesh Ajjanagadde wrote: > >> On Tue, Oct 13, 2015 at 9:13 AM, compn wrote: >> > On Mon, 12 Oct 2015 15:10:22 -0700 >> > "Reynaldo H. Verdejo Pinochet" wrote: >> > >> >> Signed-off-by: Reynaldo H. Verdejo Pino

Re: [FFmpeg-devel] [PATCH] ffserver_config: check for INT_MIN before doing FFABS

2015-10-13 Thread Ganesh Ajjanagadde
On Tue, Oct 13, 2015 at 3:45 PM, Michael Niedermayer wrote: > On Fri, Oct 09, 2015 at 11:31:22AM -0400, Ganesh Ajjanagadde wrote: >> FFABS(INT_MIN) is not safe. Alternative of using FFNABS is not as >> readable. >> >> Signed-off-by: Ganesh Ajjanagadde >> --- >> ffserver_config.c | 2 +- >> 1 fil

[FFmpeg-devel] [PATCH] avutil: merge avpriv_float_dsp_init into avpriv_float_dsp_alloc

2015-10-13 Thread Andreas Cadhalpun
Also replace the last two usages of avpriv_float_dsp_init with avpriv_float_dsp_alloc. Signed-off-by: Andreas Cadhalpun --- libavutil/float_dsp.c | 47 ++- libavutil/float_dsp.h | 9 - 2 files changed, 26 insertions(+), 30 deletions(-) diff -

Re: [FFmpeg-devel] [PATCHv2] avformat/mov: fix integer overflow

2015-10-13 Thread Ganesh Ajjanagadde
On Tue, Oct 13, 2015 at 1:49 PM, Michael Niedermayer wrote: > On Tue, Oct 13, 2015 at 12:26:24PM -0400, Ganesh Ajjanagadde wrote: >> Partially fixes Ticket 4727. >> >> -duration is not a safe expression, since duration can be INT_MIN. >> One might ask how it can become INT_MIN. >> Although it is t

[FFmpeg-devel] [PATCH] avcodec: remove unused avpriv_ac3_parse_header

2015-10-13 Thread Andreas Cadhalpun
It was replaced by avpriv_ac3_parse_header2. Signed-off-by: Andreas Cadhalpun --- libavcodec/ac3_parser.c | 9 - libavcodec/ac3_parser.h | 2 -- 2 files changed, 11 deletions(-) diff --git a/libavcodec/ac3_parser.c b/libavcodec/ac3_parser.c index 5ab5627..0dd98b9 100644 --- a/libavcodec

[FFmpeg-devel] [PATCH] avcodec: rename avpriv_color_frame to ff_color_frame

2015-10-13 Thread Andreas Cadhalpun
It is only used inside libavcodec. Signed-off-by: Andreas Cadhalpun --- libavcodec/h264_slice.c | 2 +- libavcodec/internal.h | 2 +- libavcodec/utils.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/libavcodec/h264_slice.c b/libavcodec/h264_slice.c index a346ccb..

Re: [FFmpeg-devel] Warnings (Was: Re: [PATCH 1/2] avutil/attributes: extend av_uninit to clang)

2015-10-13 Thread Ganesh Ajjanagadde
On Tue, Oct 13, 2015 at 12:54 PM, Moritz Barsnick wrote: > On Wed, Oct 07, 2015 at 23:35:08 +0200, Moritz Barsnick wrote: >> On Wed, Oct 07, 2015 at 16:07:53 -0400, Ronald S. Bultje wrote: >> > > BTW, are the "remaining" (meaning: more than from gcc) warnings emitted >> > > by the Intel C(++) Comp

Re: [FFmpeg-devel] [PATCH] avcodec: remove unused avpriv_ac3_parse_header

2015-10-13 Thread James Almer
On 10/13/2015 8:50 PM, Andreas Cadhalpun wrote: > It was replaced by avpriv_ac3_parse_header2. You could rename it to avpriv_ac3_parse_header() while at it. The 2 suffix becomes silly with this. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http:

Re: [FFmpeg-devel] [PATCH] .gitignore: some font temporaries

2015-10-13 Thread Ganesh Ajjanagadde
On Sun, Oct 11, 2015 at 4:27 PM, Ganesh Ajjanagadde wrote: > --- > .gitignore | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/.gitignore b/.gitignore > index 0b26f68..b215828 100644 > --- a/.gitignore > +++ b/.gitignore > @@ -3,3 +3,4 @@ > /htdocs/main.rss > /htdocs/components > /htdo

Re: [FFmpeg-devel] [PATCHv3] web/src/about: add note on portability

2015-10-13 Thread Ganesh Ajjanagadde
On Tue, Oct 13, 2015 at 12:10 PM, Ganesh Ajjanagadde wrote: > --- > src/about | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/src/about b/src/about > index 8d8f606..67342a1 100644 > --- a/src/about > +++ b/src/about > @@ -4,7 +4,11 @@ > transcode, mux, demux, >

Re: [FFmpeg-devel] [PATCH] avutil: merge avpriv_float_dsp_init into avpriv_float_dsp_alloc

2015-10-13 Thread James Almer
On 10/13/2015 8:48 PM, Andreas Cadhalpun wrote: > Also replace the last two usages of avpriv_float_dsp_init with > avpriv_float_dsp_alloc. > > Signed-off-by: Andreas Cadhalpun > --- > libavutil/float_dsp.c | 47 ++- > libavutil/float_dsp.h | 9 ---

Re: [FFmpeg-devel] [PATCH] avcodec: remove unused avpriv_ac3_parse_header

2015-10-13 Thread Michael Niedermayer
On Wed, Oct 14, 2015 at 01:50:13AM +0200, Andreas Cadhalpun wrote: > It was replaced by avpriv_ac3_parse_header2. > > Signed-off-by: Andreas Cadhalpun > --- > libavcodec/ac3_parser.c | 9 - > libavcodec/ac3_parser.h | 2 -- > 2 files changed, 11 deletions(-) should be ok [...] -- Mich

Re: [FFmpeg-devel] [PATCH] avfilter, swresample, swscale: use fabs, fabsf instead of FFABS

2015-10-13 Thread Ganesh Ajjanagadde
On Tue, Oct 13, 2015 at 2:45 AM, Clément Bœsch wrote: > On Tue, Oct 13, 2015 at 12:31:10AM -0400, Ganesh Ajjanagadde wrote: >> On Tue, Oct 13, 2015 at 12:26 AM, Ganesh Ajjanagadde >> wrote: >> > On Tue, Oct 13, 2015 at 12:16 AM, Carl Eugen Hoyos >> > wrote: >> >> Ganesh Ajjanagadde mit.edu> w

Re: [FFmpeg-devel] [PATCH] .gitignore: some font temporaries

2015-10-13 Thread Michael Niedermayer
On Sun, Oct 11, 2015 at 04:27:49PM -0400, Ganesh Ajjanagadde wrote: > --- > .gitignore | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/.gitignore b/.gitignore > index 0b26f68..b215828 100644 > --- a/.gitignore > +++ b/.gitignore > @@ -3,3 +3,4 @@ > /htdocs/main.rss > /htdocs/components

Re: [FFmpeg-devel] [PATCH] .gitignore: some font temporaries

2015-10-13 Thread Ganesh Ajjanagadde
On Tue, Oct 13, 2015 at 8:13 PM, Michael Niedermayer wrote: > On Sun, Oct 11, 2015 at 04:27:49PM -0400, Ganesh Ajjanagadde wrote: >> --- >> .gitignore | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/.gitignore b/.gitignore >> index 0b26f68..b215828 100644 >> --- a/.gitignore >> +++ b/

  1   2   >