[FFmpeg-devel] [PATCH] lavf/matroskadec: work around additional broken index cases

2015-08-23 Thread Rodger Combs
--- libavformat/matroskadec.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c index f97ae16..7f4a52b 100644 --- a/libavformat/matroskadec.c +++ b/libavformat/matroskadec.c @@ -1520,8 +1520,10 @@ static void matroska_a

Re: [FFmpeg-devel] [PATCHv2] avdevice/lavfi: fix self assignment warning

2015-08-23 Thread Nicolas George
Le quintidi 5 fructidor, an CCXXIII, Ganesh Ajjanagadde a écrit : > FAIL(ret) expands to statements including a silly ret=ret. > This triggers a -Wself-assign on confirmed clang 3.6, and so we fix it. > > Signed-off-by: Ganesh Ajjanagadde > --- > libavdevice/lavfi.c | 2 +- > 1 file changed, 1 i

Re: [FFmpeg-devel] [PATCH] all: silence clang -Wabsolute-value for unsigned subtractions

2015-08-23 Thread Nicolas George
Le quintidi 5 fructidor, an CCXXIII, Ganesh Ajjanagadde a écrit : > >> +return abs((int) (t1 - t2)) + abs((int) ((c1 & 0x00ff) - (c2 & > >> 0x00ff))) + > >> +abs((int) (((c1 & 0xff00) >> 8) - ((c2 & 0xff00) >> 8))) + > >> +abs((int) (((c1 & 0x00ff) >> 16) -

Re: [FFmpeg-devel] [PATCH 13/13] disable deprecation warnings in deprecated code

2015-08-23 Thread Andreas Cadhalpun
On 22.08.2015 20:40, James Almer wrote: > On 08/08/15 8:33 AM, Andreas Cadhalpun wrote: >> diff --git a/libavutil/opt.c b/libavutil/opt.c >> index 62db1b5..b5df9a3 100644 >> --- a/libavutil/opt.c >> +++ b/libavutil/opt.c >> @@ -1178,11 +1178,13 @@ int av_opt_show2(void *obj, void *av_log_obj, int

Re: [FFmpeg-devel] [PATCH 1/4] avcodec: remove FF_API_LOWRES around max_lowres

2015-08-23 Thread Andreas Cadhalpun
On 22.08.2015 20:27, James Almer wrote: > Could you please configure git to send patchsets in a single thread? Maybe. ;) Best regards, Andreas ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [FFmpeg-cvslog] disable deprecation warnings in deprecated code

2015-08-23 Thread Andreas Cadhalpun
On 23.08.2015 05:11, James Almer wrote: >> ffmpeg | branch: master | Andreas Cadhalpun > googlemail.com> | Sat Aug 8 10:41:33 2015 +0200| >> [095347ffe4c73143dbeb7b05cde8891fd1289389] | committer: Andreas Cadhalpun >> >> disable deprecation warnings in deprecated code >> >> Reviewed-by: wm4 >> S

[FFmpeg-devel] [PATCH] fate: add tests for waveform filter

2015-08-23 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- tests/fate/filter-video.mak | 13 ++-- tests/ref/fate/filter-histogram-waveform | 51 tests/ref/fate/filter-waveform_column| 51 tests/ref/fate/filter-waveform_envelope | 51 +++

Re: [FFmpeg-devel] [FFmpeg-cvslog] disable deprecation warnings in deprecated code

2015-08-23 Thread Hendrik Leppkes
On Sun, Aug 23, 2015 at 10:51 AM, Andreas Cadhalpun wrote: > On 23.08.2015 05:11, James Almer wrote: >>> ffmpeg | branch: master | Andreas Cadhalpun >> googlemail.com> | Sat Aug 8 10:41:33 2015 +0200| >>> [095347ffe4c73143dbeb7b05cde8891fd1289389] | committer: Andreas Cadhalpun >>> >>> disable d

[FFmpeg-devel] [PATCH 2/2] ffmpeg: Warn if the muxers bitexact flag is not set but it looks as if the user wants it set

2015-08-23 Thread Michael Niedermayer
From: Michael Niedermayer Note: I doubt requiring this in the future is a good idea See: [FFmpeg-devel] [PATCH 3/4] fate: add -fflags +bitexact to the relevant targets Signed-off-by: Michael Niedermayer --- ffmpeg.c |5 + 1 file changed, 5 insertions(+) diff --git a/ffmpeg.c b/ffmpeg.

[FFmpeg-devel] [PATCH 1/2] avformat/mux: Warn if the muxers bitexact flag is not set but it looks as if the user wants it set

2015-08-23 Thread Michael Niedermayer
From: Michael Niedermayer Note: I doubt requiring this in the future is a good idea See: [FFmpeg-devel] [PATCH 3/4] fate: add -fflags +bitexact to the relevant targets Signed-off-by: Michael Niedermayer --- libavformat/mux.c |7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff

Re: [FFmpeg-devel] [FFmpeg-cvslog] disable deprecation warnings in deprecated code

2015-08-23 Thread Andreas Cadhalpun
On 23.08.2015 11:05, Hendrik Leppkes wrote: > On Sun, Aug 23, 2015 at 10:51 AM, Andreas Cadhalpun >> So instead of including that, one can copy the definition of the >> FF_{DIS,EN}ABLE_DEPRECATION_WARNINGS macros, see attached patch. >> >> Alternatively one could just revert the changes to libavcod

Re: [FFmpeg-devel] [PATCH 1/2] avformat/mux: Warn if the muxers bitexact flag is not set but it looks as if the user wants it set

2015-08-23 Thread Andreas Cadhalpun
On 23.08.2015 11:09, Michael Niedermayer wrote: > From: Michael Niedermayer > > Note: I doubt requiring this in the future is a good idea > See: [FFmpeg-devel] [PATCH 3/4] fate: add -fflags +bitexact to the relevant > targets > Signed-off-by: Michael Niedermayer > --- > libavformat/mux.c |

Re: [FFmpeg-devel] [PATCH 3/4] fate: add -fflags +bitexact to the relevant targets

2015-08-23 Thread Andreas Cadhalpun
Hi Ronald, On 22.08.2015 20:30, Ronald S. Bultje wrote: > On Sat, Aug 22, 2015 at 1:57 PM, Andreas Cadhalpun < > andreas.cadhal...@googlemail.com> wrote: > >> This fixes fate with FF_API_LAVF_BITEXACT disabled. > > > Does this fix lavf-mov? I couldn't get that one to work... That's an intrigui

[FFmpeg-devel] [PATCH] rtpenc_chain: also copy AVFMT_FLAG_BITEXACT to new AVFormatContext

2015-08-23 Thread Andreas Cadhalpun
Otherwise it is impossible to make '-movflags +rtphint' bitexact after FF_API_LAVF_BITEXACT has been disabled. Signed-off-by: Andreas Cadhalpun --- libavformat/rtpenc_chain.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/rtpenc_chain.c b/libavformat/rtpenc_chain

Re: [FFmpeg-devel] [PATCH 3/4] fate: add -fflags +bitexact to the relevant targets

2015-08-23 Thread Ronald S. Bultje
Hi Andreas, On Sun, Aug 23, 2015 at 5:58 AM, Andreas Cadhalpun < andreas.cadhal...@googlemail.com> wrote: > Hi Ronald, > > On 22.08.2015 20:30, Ronald S. Bultje wrote: > > On Sat, Aug 22, 2015 at 1:57 PM, Andreas Cadhalpun < > > andreas.cadhal...@googlemail.com> wrote: > > > >> This fixes fate wi

Re: [FFmpeg-devel] [PATCH 1/2] avformat/mux: Warn if the muxers bitexact flag is not set but it looks as if the user wants it set

2015-08-23 Thread Ronald S. Bultje
Hi, On Sun, Aug 23, 2015 at 5:52 AM, Andreas Cadhalpun < andreas.cadhal...@googlemail.com> wrote: > On 23.08.2015 11:09, Michael Niedermayer wrote: > > From: Michael Niedermayer > > > > Note: I doubt requiring this in the future is a good idea > > See: [FFmpeg-devel] [PATCH 3/4] fate: add -fflag

Re: [FFmpeg-devel] [PATCH] rtpenc_chain: also copy AVFMT_FLAG_BITEXACT to new AVFormatContext

2015-08-23 Thread Ronald S. Bultje
Hi, On Sun, Aug 23, 2015 at 5:59 AM, Andreas Cadhalpun < andreas.cadhal...@googlemail.com> wrote: > Otherwise it is impossible to make '-movflags +rtphint' bitexact after > FF_API_LAVF_BITEXACT has been disabled. > > Signed-off-by: Andreas Cadhalpun > --- > libavformat/rtpenc_chain.c | 2 +- >

Re: [FFmpeg-devel] [PATCH] all: silence clang -Wabsolute-value for unsigned subtractions

2015-08-23 Thread Ganesh Ajjanagadde
On Sun, Aug 23, 2015 at 4:20 AM, Nicolas George wrote: > Le quintidi 5 fructidor, an CCXXIII, Ganesh Ajjanagadde a écrit : >> >> +return abs((int) (t1 - t2)) + abs((int) ((c1 & 0x00ff) - (c2 & >> >> 0x00ff))) + >> >> +abs((int) (((c1 & 0xff00) >> 8) - ((c2 & 0xff00) >>

Re: [FFmpeg-devel] [PATCHv2] avdevice/lavfi: fix self assignment warning

2015-08-23 Thread Ganesh Ajjanagadde
On Sun, Aug 23, 2015 at 4:16 AM, Nicolas George wrote: > Le quintidi 5 fructidor, an CCXXIII, Ganesh Ajjanagadde a écrit : >> FAIL(ret) expands to statements including a silly ret=ret. >> This triggers a -Wself-assign on confirmed clang 3.6, and so we fix it. >> >> Signed-off-by: Ganesh Ajjanagadd

Re: [FFmpeg-devel] [PATCH] all: silence clang -Wabsolute-value for unsigned subtractions

2015-08-23 Thread Ganesh Ajjanagadde
On Sun, Aug 23, 2015 at 9:57 AM, Ganesh Ajjanagadde wrote: > On Sun, Aug 23, 2015 at 4:20 AM, Nicolas George wrote: >> Le quintidi 5 fructidor, an CCXXIII, Ganesh Ajjanagadde a écrit : >>> >> +return abs((int) (t1 - t2)) + abs((int) ((c1 & 0x00ff) - (c2 & >>> >> 0x00ff))) + >>> >> +

[FFmpeg-devel] [PATCH 1/2] avutil/common: add FFUABSDIFF macro

2015-08-23 Thread Ganesh Ajjanagadde
FFUABSDIFF(a,b) returns |a-b|. It is designed to guarantee the correct result for unsigned operands a and b, while with integer operands overflow may occur depending on how it is used. This macro is useful across at least 3 places in the codebase, and is therefore placed in avutil/common. Signed-o

[FFmpeg-devel] [PATCH 2/2] all: do standards compliant absdiff computation

2015-08-23 Thread Ganesh Ajjanagadde
This resolves undefined behavior, and also silences -Wabsolute-value in clang 3.5+. Signed-off-by: Ganesh Ajjanagadde --- libavcodec/flashsv2enc.c | 6 +++--- libavfilter/vf_hqx.c | 6 +++--- libavfilter/vf_xbr.c | 6 +++--- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a

Re: [FFmpeg-devel] [PATCH]lavf/segment: Fix memleak

2015-08-23 Thread Ganesh Ajjanagadde
On Fri, Aug 21, 2015 at 6:21 AM, Carl Eugen Hoyos wrote: > Hi! > > Attached patch fixes a memleak for me, reproducible with: > $ valgrind --leak-check=full ./ffmpeg_g -i > fate-suite/lena.pnm -reset_timestamps 1 -f segment out%1d.avi It fixes a memleak for me, but note that valgrind output is sti

Re: [FFmpeg-devel] [PATCH]lavf/segment: Fix memleak

2015-08-23 Thread Ganesh Ajjanagadde
On Sun, Aug 23, 2015 at 12:04 PM, Ganesh Ajjanagadde wrote: > On Fri, Aug 21, 2015 at 6:21 AM, Carl Eugen Hoyos wrote: >> Hi! >> >> Attached patch fixes a memleak for me, reproducible with: >> $ valgrind --leak-check=full ./ffmpeg_g -i >> fate-suite/lena.pnm -reset_timestamps 1 -f segment out%1d.

Re: [FFmpeg-devel] [PATCH 1/2] libx265: 4:2:2 and 4:4:4 are no longer experimental

2015-08-23 Thread Derek Buitenhuis
On 8/22/2015 7:17 PM, Stephen Hutchinson wrote: > x265 itself removed its warnings about these a while ago. > --- > libavcodec/libx265.c | 8 > 1 file changed, 8 deletions(-) Are they ratified in the standard now? - Derek ___ ffmpeg-devel mail

Re: [FFmpeg-devel] [PATCH 2/2] libx265: Enable 12-bit encoding

2015-08-23 Thread Derek Buitenhuis
On 8/22/2015 7:17 PM, Stephen Hutchinson wrote: > This was introduced in x265 in July, and the experimental warnings > about it in libx265 were recently removed, so there shouldn't be > any reason to have it as experimental here. > > The configure detection is bumped to X265_BUILD >= 60, as the >

Re: [FFmpeg-devel] [PATCH 1/2] libx265: 4:2:2 and 4:4:4 are no longer experimental

2015-08-23 Thread Ganesh Ajjanagadde
On Sun, Aug 23, 2015 at 1:14 PM, Derek Buitenhuis wrote: > On 8/22/2015 7:17 PM, Stephen Hutchinson wrote: >> x265 itself removed its warnings about these a while ago. >> --- >> libavcodec/libx265.c | 8 >> 1 file changed, 8 deletions(-) > > Are they ratified in the standard now? FWIW,

Re: [FFmpeg-devel] [PATCH] lavf/matroskadec: work around additional broken index cases

2015-08-23 Thread wm4
On Sun, 23 Aug 2015 02:47:39 -0500 Rodger Combs wrote: > --- > libavformat/matroskadec.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c > index f97ae16..7f4a52b 100644 > --- a/libavformat/matroskadec.c > +++ b

Re: [FFmpeg-devel] [FFmpeg-cvslog] disable deprecation warnings in deprecated code

2015-08-23 Thread Michael Niedermayer
On Sun, Aug 23, 2015 at 11:24:06AM +0200, Andreas Cadhalpun wrote: > On 23.08.2015 11:05, Hendrik Leppkes wrote: > > On Sun, Aug 23, 2015 at 10:51 AM, Andreas Cadhalpun > >> So instead of including that, one can copy the definition of the > >> FF_{DIS,EN}ABLE_DEPRECATION_WARNINGS macros, see attach

Re: [FFmpeg-devel] [PATCH 2/3] avformat/hls: comment out unused function

2015-08-23 Thread wm4
On Sat, 22 Aug 2015 22:48:39 -0400 Ganesh Ajjanagadde wrote: > On Thu, Aug 20, 2015 at 7:27 PM, Ganesh Ajjanagadde > wrote: > > Fixes -Wunused-function from > > http://fate.ffmpeg.org/report.cgi?time=20150820031140&slot=arm64-darwin-clang-apple-5.1 > > > > Signed-off-by: Ganesh Ajjanagadde > >

Re: [FFmpeg-devel] [PATCHv2] avdevice/lavfi: fix self assignment warning

2015-08-23 Thread Michael Niedermayer
On Sun, Aug 23, 2015 at 10:16:36AM +0200, Nicolas George wrote: > Le quintidi 5 fructidor, an CCXXIII, Ganesh Ajjanagadde a écrit : > > FAIL(ret) expands to statements including a silly ret=ret. > > This triggers a -Wself-assign on confirmed clang 3.6, and so we fix it. > > > > Signed-off-by: Gane

Re: [FFmpeg-devel] [PATCH 2/3] avformat/hls: comment out unused function

2015-08-23 Thread Ganesh Ajjanagadde
On Sun, Aug 23, 2015 at 2:01 PM, wm4 wrote: > On Sat, 22 Aug 2015 22:48:39 -0400 > Ganesh Ajjanagadde wrote: > >> On Thu, Aug 20, 2015 at 7:27 PM, Ganesh Ajjanagadde >> wrote: >> > Fixes -Wunused-function from >> > http://fate.ffmpeg.org/report.cgi?time=20150820031140&slot=arm64-darwin-clang-app

[FFmpeg-devel] [PATCH][RFC] swresample/dither: use integer arithmetic

2015-08-23 Thread Ganesh Ajjanagadde
This fixes a -Wabsolute-value reported by clang 3.5+ complaining about misuse of fabs() for integer absolute value. An additional benefit is the removal of floating point calculations. Note that the behaviors are not exactly identical, but should be ok in most situations. Signed-off-by: Ganesh A

Re: [FFmpeg-devel] [PATCH][RFC] swresample/dither: use integer arithmetic

2015-08-23 Thread Michael Niedermayer
On Sun, Aug 23, 2015 at 02:28:07PM -0400, Ganesh Ajjanagadde wrote: > This fixes a -Wabsolute-value reported by clang 3.5+ complaining about misuse > of fabs() for integer absolute value. > An additional benefit is the removal of floating point calculations. > Note that the behaviors are not exact

Re: [FFmpeg-devel] [PATCH 1/2] libx265: 4:2:2 and 4:4:4 are no longer experimental

2015-08-23 Thread Stephen Hutchinson
On 8/23/2015 1:14 PM, Derek Buitenhuis wrote: On 8/22/2015 7:17 PM, Stephen Hutchinson wrote: x265 itself removed its warnings about these a while ago. --- libavcodec/libx265.c | 8 1 file changed, 8 deletions(-) Are they ratified in the standard now? - Derek _

Re: [FFmpeg-devel] [PATCH][RFC] swresample/dither: use integer arithmetic

2015-08-23 Thread Ganesh Ajjanagadde
On Sun, Aug 23, 2015 at 2:45 PM, Michael Niedermayer wrote: > On Sun, Aug 23, 2015 at 02:28:07PM -0400, Ganesh Ajjanagadde wrote: >> This fixes a -Wabsolute-value reported by clang 3.5+ complaining about >> misuse of fabs() for integer absolute value. >> An additional benefit is the removal of fl

Re: [FFmpeg-devel] [PATCH][RFC] swresample/dither: use integer arithmetic

2015-08-23 Thread James Almer
On 23/08/15 4:10 PM, Ganesh Ajjanagadde wrote: > On Sun, Aug 23, 2015 at 2:45 PM, Michael Niedermayer > wrote: >> On Sun, Aug 23, 2015 at 02:28:07PM -0400, Ganesh Ajjanagadde wrote: >>> This fixes a -Wabsolute-value reported by clang 3.5+ complaining about >>> misuse of fabs() for integer absolut

Re: [FFmpeg-devel] [PATCH][RFC] swresample/dither: use integer arithmetic

2015-08-23 Thread James Almer
On 23/08/15 4:10 PM, Ganesh Ajjanagadde wrote: > I notice one use in entire codebase (line 515 of avformat/dump.c), so > it should be ok in my view. Nevermind, missed this. Not sure how it works with msvc 2012 though, assuming the msdn link documentation is right.

[FFmpeg-devel] [PATCH] configure: warn if GCC 4.2 is being used

2015-08-23 Thread Ganesh Ajjanagadde
The wiki, Ticket1464, and Ticket3970 warn about the usage of GCC 4.2. This fixes Ticket3970. Signed-off-by: Ganesh Ajjanagadde --- configure | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/configure b/configure index e67ddf6..5b10017 100755 --- a/configure +++ b/configu

Re: [FFmpeg-devel] [PATCH][RFC] swresample/dither: use integer arithmetic

2015-08-23 Thread Ganesh Ajjanagadde
On Sun, Aug 23, 2015 at 3:42 PM, James Almer wrote: > On 23/08/15 4:10 PM, Ganesh Ajjanagadde wrote: >> I notice one use in entire codebase (line 515 of avformat/dump.c), so >> it should be ok in my view. > > Nevermind, missed this. > > Not sure how it works with msvc 2012 though, assuming the msd

Re: [FFmpeg-devel] [PATCH][RFC] swresample/dither: use integer arithmetic

2015-08-23 Thread James Almer
On 23/08/15 5:09 PM, Ganesh Ajjanagadde wrote: > On Sun, Aug 23, 2015 at 3:42 PM, James Almer wrote: >> On 23/08/15 4:10 PM, Ganesh Ajjanagadde wrote: >>> I notice one use in entire codebase (line 515 of avformat/dump.c), so >>> it should be ok in my view. >> >> Nevermind, missed this. >> >> Not s

Re: [FFmpeg-devel] [PATCH][RFC] swresample/dither: use integer arithmetic

2015-08-23 Thread Ganesh Ajjanagadde
On Sun, Aug 23, 2015 at 4:17 PM, James Almer wrote: > On 23/08/15 5:09 PM, Ganesh Ajjanagadde wrote: >> On Sun, Aug 23, 2015 at 3:42 PM, James Almer wrote: >>> On 23/08/15 4:10 PM, Ganesh Ajjanagadde wrote: I notice one use in entire codebase (line 515 of avformat/dump.c), so it should

[FFmpeg-devel] [PATCHv2] swresample/dither: use integer arithmetic

2015-08-23 Thread Ganesh Ajjanagadde
This fixes a -Wabsolute-value reported by clang 3.5+ complaining about misuse of fabs() for integer absolute value. An additional benefit is the removal of floating point calculations. Signed-off-by: Ganesh Ajjanagadde --- libswresample/dither.c | 2 +- 1 file changed, 1 insertion(+), 1 deletio

Re: [FFmpeg-devel] [PATCH] fate: add tests for waveform filter

2015-08-23 Thread Michael Niedermayer
On Sat, Aug 22, 2015 at 09:20:09PM +, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > tests/fate/filter-video.mak | 13 ++-- > tests/ref/fate/filter-histogram-waveform | 51 > > tests/ref/fate/filter-waveform_column| 51 > +

Re: [FFmpeg-devel] [PATCH][RFC] swresample/dither: use integer arithmetic

2015-08-23 Thread Michael Niedermayer
On Sun, Aug 23, 2015 at 03:10:40PM -0400, Ganesh Ajjanagadde wrote: > On Sun, Aug 23, 2015 at 2:45 PM, Michael Niedermayer > wrote: > > On Sun, Aug 23, 2015 at 02:28:07PM -0400, Ganesh Ajjanagadde wrote: > >> This fixes a -Wabsolute-value reported by clang 3.5+ complaining about > >> misuse of fa

Re: [FFmpeg-devel] [PATCH][RFC] swresample/dither: use integer arithmetic

2015-08-23 Thread Ganesh Ajjanagadde
On Sun, Aug 23, 2015 at 4:53 PM, Michael Niedermayer wrote: > On Sun, Aug 23, 2015 at 03:10:40PM -0400, Ganesh Ajjanagadde wrote: >> On Sun, Aug 23, 2015 at 2:45 PM, Michael Niedermayer >> wrote: >> > On Sun, Aug 23, 2015 at 02:28:07PM -0400, Ganesh Ajjanagadde wrote: >> >> This fixes a -Wabsolut

Re: [FFmpeg-devel] [PATCHv2] swresample/dither: use integer arithmetic

2015-08-23 Thread Michael Niedermayer
On Sun, Aug 23, 2015 at 04:31:12PM -0400, Ganesh Ajjanagadde wrote: > This fixes a -Wabsolute-value reported by clang 3.5+ complaining about misuse > of fabs() for integer absolute value. > An additional benefit is the removal of floating point calculations. > > Signed-off-by: Ganesh Ajjanagadde

Re: [FFmpeg-devel] [PATCH 2/2] all: do standards compliant absdiff computation

2015-08-23 Thread Clément Bœsch
On Sun, Aug 23, 2015 at 11:58:23AM -0400, Ganesh Ajjanagadde wrote: [...] > diff --git a/libavfilter/vf_hqx.c b/libavfilter/vf_hqx.c > index fa15d9c..0178793 100644 > --- a/libavfilter/vf_hqx.c > +++ b/libavfilter/vf_hqx.c > @@ -65,9 +65,9 @@ static av_always_inline int yuv_diff(uint32_t yuv1, > u

Re: [FFmpeg-devel] [PATCH 2/2] all: do standards compliant absdiff computation

2015-08-23 Thread Clément Bœsch
On Sun, Aug 23, 2015 at 11:23:54PM +0200, Clément Bœsch wrote: > On Sun, Aug 23, 2015 at 11:58:23AM -0400, Ganesh Ajjanagadde wrote: > [...] > > diff --git a/libavfilter/vf_hqx.c b/libavfilter/vf_hqx.c > > index fa15d9c..0178793 100644 > > --- a/libavfilter/vf_hqx.c > > +++ b/libavfilter/vf_hqx.c >

Re: [FFmpeg-devel] [PATCH 2/2] all: do standards compliant absdiff computation

2015-08-23 Thread Ganesh Ajjanagadde
On Sun, Aug 23, 2015 at 5:28 PM, Clément Bœsch wrote: > On Sun, Aug 23, 2015 at 11:23:54PM +0200, Clément Bœsch wrote: >> On Sun, Aug 23, 2015 at 11:58:23AM -0400, Ganesh Ajjanagadde wrote: >> [...] >> > diff --git a/libavfilter/vf_hqx.c b/libavfilter/vf_hqx.c >> > index fa15d9c..0178793 100644 >>

Re: [FFmpeg-devel] [PATCH 1/4] avcodec: remove FF_API_LOWRES around max_lowres

2015-08-23 Thread Andreas Cadhalpun
On 22.08.2015 20:36, wm4 wrote: > On Sat, 22 Aug 2015 20:23:28 +0200 > Andreas Cadhalpun wrote: > >> On 22.08.2015 20:16, wm4 wrote: >>> On Sat, 22 Aug 2015 19:56:53 +0200 >>> Andreas Cadhalpun wrote: >>> This fixes building with FF_API_LOWRES disabled. Signed-off-by: Andreas Cadh

Re: [FFmpeg-devel] [PATCH] rtpenc_chain: also copy AVFMT_FLAG_BITEXACT to new AVFormatContext

2015-08-23 Thread Andreas Cadhalpun
On 23.08.2015 13:08, Ronald S. Bultje wrote: > Hi, > > On Sun, Aug 23, 2015 at 5:59 AM, Andreas Cadhalpun < > andreas.cadhal...@googlemail.com> wrote: > >> Otherwise it is impossible to make '-movflags +rtphint' bitexact after >> FF_API_LAVF_BITEXACT has been disabled. >> >> Signed-off-by: Andrea

Re: [FFmpeg-devel] [FFmpeg-cvslog] disable deprecation warnings in deprecated code

2015-08-23 Thread Andreas Cadhalpun
On 23.08.2015 19:58, Michael Niedermayer wrote: > On Sun, Aug 23, 2015 at 11:24:06AM +0200, Andreas Cadhalpun wrote: >> options_table.h |3 --- >> 1 file changed, 3 deletions(-) >> a47e74fd475ff47b15f37f0c9caabf354f82c8e3 >> 0001-options_table-fix-compatibility-with-MSVC.patch >> From 96592b

Re: [FFmpeg-devel] [PATCH 2/2] all: do standards compliant absdiff computation

2015-08-23 Thread Clément Bœsch
On Sun, Aug 23, 2015 at 05:33:11PM -0400, Ganesh Ajjanagadde wrote: > On Sun, Aug 23, 2015 at 5:28 PM, Clément Bœsch wrote: > > On Sun, Aug 23, 2015 at 11:23:54PM +0200, Clément Bœsch wrote: > >> On Sun, Aug 23, 2015 at 11:58:23AM -0400, Ganesh Ajjanagadde wrote: > >> [...] > >> > diff --git a/lib

Re: [FFmpeg-devel] [PATCH 1/2] avformat/mux: Warn if the muxers bitexact flag is not set but it looks as if the user wants it set

2015-08-23 Thread Andreas Cadhalpun
Hi, On 23.08.2015 13:10, Ronald S. Bultje wrote: > On Sun, Aug 23, 2015 at 5:52 AM, Andreas Cadhalpun < > andreas.cadhal...@googlemail.com> wrote: > >> On 23.08.2015 11:09, Michael Niedermayer wrote: >>> From: Michael Niedermayer >>> >>> Note: I doubt requiring this in the future is a good idea

Re: [FFmpeg-devel] [PATCH 2/2] all: do standards compliant absdiff computation

2015-08-23 Thread Ganesh Ajjanagadde
On Sun, Aug 23, 2015 at 5:41 PM, Clément Bœsch wrote: > On Sun, Aug 23, 2015 at 05:33:11PM -0400, Ganesh Ajjanagadde wrote: >> On Sun, Aug 23, 2015 at 5:28 PM, Clément Bœsch wrote: >> > On Sun, Aug 23, 2015 at 11:23:54PM +0200, Clément Bœsch wrote: >> >> On Sun, Aug 23, 2015 at 11:58:23AM -0400,

[FFmpeg-devel] [PATCHv2 1/2] avutil/common: add FFABSDIFF macro

2015-08-23 Thread Ganesh Ajjanagadde
FFABSDIFF(a,b) expands to effectively abs((int)a-(int)b). Note that this is not safe in general as it makes assumptions on the widths. This macro is useful across at least 3 places in the codebase, and is therefore placed in avutil/common. Signed-off-by: Ganesh Ajjanagadde --- libavutil/common.h

[FFmpeg-devel] [PATCHv2 2/2] all: do standards compliant absdiff computation

2015-08-23 Thread Ganesh Ajjanagadde
This resolves undefined behavior, and also silences -Wabsolute-value in clang 3.5+. Signed-off-by: Ganesh Ajjanagadde --- libavcodec/flashsv2enc.c | 6 +++--- libavfilter/vf_hqx.c | 6 +++--- libavfilter/vf_xbr.c | 6 +++--- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a

Re: [FFmpeg-devel] [PATCH] all: silence clang -Wabsolute-value for unsigned subtractions

2015-08-23 Thread Michael Niedermayer
On Sat, Aug 22, 2015 at 04:26:53PM +0200, Nicolas George wrote: > Le quintidi 5 fructidor, an CCXXIII, Ganesh Ajjanagadde a écrit : > > +/* cast for -Wabsolute-value in clang 3.5+ */ > > +return abs((int) (t1 - t2)) + abs((int) ((c1 & 0x00ff) - (c2 & > > 0x00ff))) + > > +ab

Re: [FFmpeg-devel] [PATCH] all: silence clang -Wabsolute-value for unsigned subtractions

2015-08-23 Thread Ganesh Ajjanagadde
On Sun, Aug 23, 2015 at 6:58 PM, Michael Niedermayer wrote: > On Sat, Aug 22, 2015 at 04:26:53PM +0200, Nicolas George wrote: >> Le quintidi 5 fructidor, an CCXXIII, Ganesh Ajjanagadde a écrit : >> > +/* cast for -Wabsolute-value in clang 3.5+ */ >> > +return abs((int) (t1 - t2)) + abs((in

[FFmpeg-devel] [PATCH] api-band-test: first version

2015-08-23 Thread Ludmila Glinskih
Works only for flv, h263 and huffyuv decoders. Makes only one pass through the file (this should be changed to two passes) --- tests/api/Makefile| 1 + tests/api/api-band-test.c | 222 ++ tests/fate/api.mak| 6 ++ 3 files changed, 229

Re: [FFmpeg-devel] [PATCH 1/2] avformat/mux: Warn if the muxers bitexact flag is not set but it looks as if the user wants it set

2015-08-23 Thread Michael Niedermayer
On Sun, Aug 23, 2015 at 11:52:37AM +0200, Andreas Cadhalpun wrote: > On 23.08.2015 11:09, Michael Niedermayer wrote: > > From: Michael Niedermayer > > > > Note: I doubt requiring this in the future is a good idea > > See: [FFmpeg-devel] [PATCH 3/4] fate: add -fflags +bitexact to the relevant > >

[FFmpeg-devel] [PATCH] MAINTAINERS: add myself as an API tests maintainer

2015-08-23 Thread Ludmila Glinskih
--- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index a909211..68f0f18 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -48,6 +48,7 @@ project server Árpád Gereöffy, Michael Niedermayer, presets R

Re: [FFmpeg-devel] [PATCH] api-band-test: first version

2015-08-23 Thread Michael Niedermayer
On Mon, Aug 24, 2015 at 03:11:45AM +0300, Ludmila Glinskih wrote: > Works only for flv, h263 and huffyuv decoders. > Makes only one pass through the file (this should be changed to two passes) > --- > tests/api/Makefile| 1 + > tests/api/api-band-test.c | 222 > +

Re: [FFmpeg-devel] [PATCH] MAINTAINERS: add myself as an API tests maintainer

2015-08-23 Thread Michael Niedermayer
On Mon, Aug 24, 2015 at 03:37:42AM +0300, Ludmila Glinskih wrote: > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) looks good to me thanks -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB In fact, the RIAA has been known to suggest that students drop out o

Re: [FFmpeg-devel] [PATCH] configure: warn if GCC 4.2 is being used

2015-08-23 Thread Carl Eugen Hoyos
Ganesh Ajjanagadde gmail.com> writes: > +if [ "$first" = true ] && $_cc -dumpversion | grep -q '^4\.2'; then Will this not trigger for 4.4.2? > +warn "$gcc_version does not build ffmpeg correctly. > Please do not use GCC 4.2!" > +warn "See Ticket #1464 for more details." P