[FFmpeg-devel] [RFC]Don't use round when encoding png

2015-03-01 Thread Carl Eugen Hoyos
Hi! Attached untested patch should fix compilation on broken platforms. We don't use round() currently because it appears less portable than lrintf(). Please comment, Carl Eugen diff --git a/libavcodec/pngenc.c b/libavcodec/pngenc.c index 9fd8eef..2826f36 100644 --- a/libavcodec/pngenc.c +++ b/l

[FFmpeg-devel] [PATCH]Improve video creation examples

2015-03-01 Thread Carl Eugen Hoyos
Hi! The examples for video creation from images drop frames which is probably not what users expect. Please comment, Carl Eugen diff --git a/doc/ffmpeg.texi b/doc/ffmpeg.texi index 6772f2f..1dde682 100644 --- a/doc/ffmpeg.texi +++ b/doc/ffmpeg.texi @@ -1469,7 +1469,7 @@ combination with -ss to s

Re: [FFmpeg-devel] [RFC]Don't use round when encoding png

2015-03-01 Thread Michael Niedermayer
On Sun, Mar 01, 2015 at 09:44:30AM +0100, Carl Eugen Hoyos wrote: > Hi! > > Attached untested patch should fix compilation on broken platforms. > We don't use round() currently because it appears less portable than > lrintf(). which platform is that ? but yes reducing float code usage should be

Re: [FFmpeg-devel] [PATCH]Improve video creation examples

2015-03-01 Thread Michael Niedermayer
On Sun, Mar 01, 2015 at 10:13:34AM +0100, Carl Eugen Hoyos wrote: > Hi! > > The examples for video creation from images drop frames > which is probably not what users expect. > > Please comment, Carl Eugen > ffmpeg.texi |4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > 3e2ef09ab

Re: [FFmpeg-devel] [RFC]Don't use round when encoding png

2015-03-01 Thread Carl Eugen Hoyos
Michael Niedermayer gmx.at> writes: > > Attached untested patch should fix compilation on > > broken platforms. We don't use round() currently > > because it appears less portable than lrintf(). > > which platform is that ? http://fate.ffmpeg.org/history.cgi?slot=x86-opensolaris-suncc5.10 Loo

Re: [FFmpeg-devel] [RFC]Don't use round when encoding png

2015-03-01 Thread Carl Eugen Hoyos
On Sunday 01 March 2015 11:22:10 am Michael Niedermayer wrote: > On Sun, Mar 01, 2015 at 09:44:30AM +0100, Carl Eugen Hoyos wrote: > > Attached untested patch should fix compilation on broken platforms. > > We don't use round() currently because it appears less portable than > > lrintf(). > yes re

[FFmpeg-devel] [PATCH]Improve the intra_dc_precision API doc

2015-03-01 Thread Carl Eugen Hoyos
Hi! The mpegvideo decoder sets intra_dc_precision since forever (!). Please comment, Carl Eugen diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index 575dae1..a9dbff7 100644 --- a/libavcodec/avcodec.h +++ b/libavcodec/avcodec.h @@ -1823,7 +1823,7 @@ typedef struct AVCodecContext { /

[FFmpeg-devel] [PATCH] mxfenc: Adjust product name when opatom muxer is used

2015-03-01 Thread Robert Krüger
Currently the product name that ends up in mxf files muxed using the new op atom muxer is "OP1A muxer" which is misleading. Attached patch changes that. mxf_opatom_product_name.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ff

Re: [FFmpeg-devel] Why is writing the colr atom not the default in the mov muxer?

2015-03-01 Thread Robert Krüger
On Tue, Feb 24, 2015 at 11:55 AM, Michael Niedermayer wrote: > On Tue, Feb 24, 2015 at 08:00:07AM +, tim nicholson wrote: > > On 21/02/15 01:34, Dave Rice wrote: > > > Hi Robert, Kevin, > > > > > >> On Feb 20, 2015, at 9:56 AM, Robert Krüger > wrote: > > >> > > >> Am Freitag, 20. Februar 201

Re: [FFmpeg-devel] [PATCH]Improve the intra_dc_precision API doc

2015-03-01 Thread Michael Niedermayer
On Sun, Mar 01, 2015 at 12:56:44PM +0100, Carl Eugen Hoyos wrote: > Hi! > > The mpegvideo decoder sets intra_dc_precision since forever (!). > > Please comment, Carl Eugen LGTM [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Its not that you shouldnt use goto

Re: [FFmpeg-devel] [RFC]Don't use round when encoding png

2015-03-01 Thread Michael Niedermayer
On Sun, Mar 01, 2015 at 12:09:28PM +0100, Carl Eugen Hoyos wrote: > On Sunday 01 March 2015 11:22:10 am Michael Niedermayer wrote: > > On Sun, Mar 01, 2015 at 09:44:30AM +0100, Carl Eugen Hoyos wrote: > > > Attached untested patch should fix compilation on broken platforms. > > > We don't use round

Re: [FFmpeg-devel] [RFC]Don't use round when encoding png

2015-03-01 Thread wm4
On Sun, 1 Mar 2015 12:09:28 +0100 Carl Eugen Hoyos wrote: > On Sunday 01 March 2015 11:22:10 am Michael Niedermayer wrote: > > On Sun, Mar 01, 2015 at 09:44:30AM +0100, Carl Eugen Hoyos wrote: > > > Attached untested patch should fix compilation on broken platforms. > > > We don't use round() cur

[FFmpeg-devel] [PATCH] lavfi: add erosion, dilation, median, deflate & inflate filter

2015-03-01 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- Changelog | 1 + doc/filters.texi | 91 +++ libavfilter/Makefile | 5 + libavfilter/allfilters.c | 5 + libavfilter/vf_neighbor.c | 648 ++ 5 files changed, 750 insertions(+) cre

Re: [FFmpeg-devel] [RFC]Don't use round when encoding png

2015-03-01 Thread Michael Niedermayer
On Sun, Mar 01, 2015 at 01:11:08PM +0100, wm4 wrote: > On Sun, 1 Mar 2015 12:09:28 +0100 > Carl Eugen Hoyos wrote: > > > On Sunday 01 March 2015 11:22:10 am Michael Niedermayer wrote: > > > On Sun, Mar 01, 2015 at 09:44:30AM +0100, Carl Eugen Hoyos wrote: > > > > Attached untested patch should fi

Re: [FFmpeg-devel] [PATCH 1/2] avutil/opt: Also test/compare the av_log output i the selftest

2015-03-01 Thread Michael Niedermayer
On Sat, Feb 28, 2015 at 12:11:19AM +0100, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavutil/opt.c|8 +++ > tests/ref/fate/opt | 203 > > 2 files changed, 211 insertions(+) applied [...] -- Michael

Re: [FFmpeg-devel] [PATCH 2/2] avutil/opt: also test av_opt_show2()

2015-03-01 Thread Michael Niedermayer
On Sat, Feb 28, 2015 at 12:11:20AM +0100, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavutil/opt.c| 47 +-- > tests/ref/fate/opt | 23 +++ > 2 files changed, 48 insertions(+), 22 deletions(-) a

[FFmpeg-devel] FFmpeg 2.6 release

2015-03-01 Thread Michael Niedermayer
Hi all its a while since FFmpeg 2.5, so its getting time to make 2.6 if you want something in it or something fixed, now is your last chance ;) About the name if noone suggests something then ill pick a random scientist from the list i have from past suggestions -- Michael GnuPG fingerprin

Re: [FFmpeg-devel] [PATCH] lavfi: add erosion, dilation, median, deflate & inflate filter

2015-03-01 Thread Nicolas George
Le primidi 11 ventôse, an CCXXIII, Paul B Mahol a écrit : > +AVFilterContext *ctx = inlink->dst; > +AVFilterLink *outlink = ctx->outputs[0]; > +EDContext *s = ctx->priv; > +AVFrame *out; > +int plane, y, x, i; > + > +out = ff_get_video_buffer(outlink, outlink->w, outlink->h)

Re: [FFmpeg-devel] [RFC]Don't use round when encoding png

2015-03-01 Thread wm4
On Sun, 1 Mar 2015 16:26:20 +0100 Michael Niedermayer wrote: > On Sun, Mar 01, 2015 at 01:11:08PM +0100, wm4 wrote: > > On Sun, 1 Mar 2015 12:09:28 +0100 > > Carl Eugen Hoyos wrote: > > > > > On Sunday 01 March 2015 11:22:10 am Michael Niedermayer wrote: > > > > On Sun, Mar 01, 2015 at 09:44:30

Re: [FFmpeg-devel] Why is writing the colr atom not the default in the mov muxer?

2015-03-01 Thread Derek Buitenhuis
On 3/1/2015 12:26 PM, Robert Krüger wrote: > Am I reading the committed patch incorrectly or is colr still not written > by default? I thought the argument against replacing the flag (Derek's > first patch) was withdrawn because there has not been a release that > contained the original flag. The

Re: [FFmpeg-devel] [RFC]Don't use round when encoding png

2015-03-01 Thread Nicolas George
Le primidi 11 ventôse, an CCXXIII, wm4 a écrit : > I prefer the color of fuck broken platforms nobody uses. Well, obviously someone uses a platform where it makes a difference, otherwise nobody would have noticed. Regards, -- Nicolas George signature.asc Description: Digital signature _

Re: [FFmpeg-devel] [RFC]Don't use round when encoding png

2015-03-01 Thread wm4
On Sun, 1 Mar 2015 19:48:20 +0100 Nicolas George wrote: > Le primidi 11 ventôse, an CCXXIII, wm4 a écrit : > > I prefer the color of fuck broken platforms nobody uses. > > Well, obviously someone uses a platform where it makes a difference, > otherwise nobody would have noticed. > > Regards, >

Re: [FFmpeg-devel] Why is writing the colr atom not the default in the mov muxer?

2015-03-01 Thread Robert Krüger
Am Sonntag, 1. März 2015 schrieb Derek Buitenhuis : > On 3/1/2015 12:26 PM, Robert Krüger wrote: > > Am I reading the committed patch incorrectly or is colr still not written > > by default? I thought the argument against replacing the flag (Derek's > > first patch) was withdrawn because there has

Re: [FFmpeg-devel] [RFC]Don't use round when encoding png

2015-03-01 Thread Michael Niedermayer
On Sun, Mar 01, 2015 at 07:57:56PM +0100, wm4 wrote: > On Sun, 1 Mar 2015 19:48:20 +0100 > Nicolas George wrote: > > > Le primidi 11 ventôse, an CCXXIII, wm4 a écrit : > > > I prefer the color of fuck broken platforms nobody uses. > > > > Well, obviously someone uses a platform where it makes a

Re: [FFmpeg-devel] [RFC]Don't use round when encoding png

2015-03-01 Thread wm4
On Sun, 1 Mar 2015 20:34:57 +0100 Michael Niedermayer wrote: > On Sun, Mar 01, 2015 at 07:57:56PM +0100, wm4 wrote: > > On Sun, 1 Mar 2015 19:48:20 +0100 > > Nicolas George wrote: > > > > > Le primidi 11 ventôse, an CCXXIII, wm4 a écrit : > > > > I prefer the color of fuck broken platforms nobo

Re: [FFmpeg-devel] [PATCH 2/3] avformat: map T.140 RTP codec to text

2015-03-01 Thread Gilles Chanteperdrix
On Sun, Mar 01, 2015 at 08:25:12AM +0100, Clément Bœsch wrote: > On Sat, Feb 28, 2015 at 11:15:40PM +0100, Gilles Chanteperdrix wrote: > > This makes more sense than mapping to AV_CODEC_ID_SUBRIP. Nothing > > indicates that a T.140 track contains subrip sub-titles. > > > > Signed-off-by: Gilles Ch

[FFmpeg-devel] [PATCH] x86/hevc_sao: use unaligned movs for sao_{band, filter} with width 8

2015-03-01 Thread James Almer
Suggested-by: Christophe Gisquet Signed-off-by: James Almer --- libavcodec/x86/hevc_sao.asm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavcodec/x86/hevc_sao.asm b/libavcodec/x86/hevc_sao.asm index 8c2436b..86ef847 100644 --- a/libavcodec/x86/hevc_sao.asm +++ b/li

Re: [FFmpeg-devel] FFmpeg 2.6 release

2015-03-01 Thread Clément Bœsch
On Sun, Mar 01, 2015 at 05:53:59PM +0100, Michael Niedermayer wrote: > Hi all > > its a while since FFmpeg 2.5, so its getting time to make 2.6 > if you want something in it or something fixed, now is your last > chance ;) > > About the name if noone suggests something then ill pick a random > sc

Re: [FFmpeg-devel] [RFC]Don't use round when encoding png

2015-03-01 Thread Michael Niedermayer
On Sun, Mar 01, 2015 at 09:34:46PM +0100, wm4 wrote: > On Sun, 1 Mar 2015 20:34:57 +0100 > Michael Niedermayer wrote: > > > On Sun, Mar 01, 2015 at 07:57:56PM +0100, wm4 wrote: > > > On Sun, 1 Mar 2015 19:48:20 +0100 > > > Nicolas George wrote: > > > > > > > Le primidi 11 ventôse, an CCXXIII, w

Re: [FFmpeg-devel] FFmpeg 2.6 release

2015-03-01 Thread Michael Niedermayer
On Sun, Mar 01, 2015 at 10:17:15PM +0100, Clément Bœsch wrote: > On Sun, Mar 01, 2015 at 05:53:59PM +0100, Michael Niedermayer wrote: > > Hi all > > > > its a while since FFmpeg 2.5, so its getting time to make 2.6 > > if you want something in it or something fixed, now is your last > > chance ;)

[FFmpeg-devel] [PATCH 0/2] libavformat/mxfenc: write package name metadata

2015-03-01 Thread Mark Reid
changes since v1: * split into 2 patches * added avformat minor version bump * search for file_package_name in stream metadata as well, thats where the demuxer puts the key Mark Reid (2): libavformat/avio: added avio_put_str16be libavformat/mxfenc: write package name metadata libavformat/avi

[FFmpeg-devel] [PATCH 1/2] libavformat/avio: added avio_put_str16be

2015-03-01 Thread Mark Reid
--- libavformat/avio.h| 6 ++ libavformat/aviobuf.c | 50 +++--- libavformat/version.h | 2 +- 3 files changed, 34 insertions(+), 24 deletions(-) diff --git a/libavformat/avio.h b/libavformat/avio.h index b9b4017..8fc7e27 100644 --- a/libavfor

[FFmpeg-devel] [PATCH 2/2] libavformat/mxfenc: write package name metadata

2015-03-01 Thread Mark Reid
--- libavformat/mxfenc.c | 88 +-- tests/ref/lavf/mxf| 6 ++-- tests/ref/lavf/mxf_d10| 2 +- tests/ref/lavf/mxf_opatom | 2 +- 4 files changed, 82 insertions(+), 16 deletions(-) diff --git a/libavformat/mxfenc.c b/libavformat/mxfenc.

Re: [FFmpeg-devel] [PATCH] mxfenc: Adjust product name when opatom muxer is used

2015-03-01 Thread Mark Reid
On Sun, Mar 1, 2015 at 4:06 AM, Robert Krüger wrote: > Currently the product name that ends up in mxf files muxed using the new op > atom muxer is "OP1A muxer" which is misleading. Attached patch changes > that. > > ___ > ffmpeg-devel mailing list > ffm

Re: [FFmpeg-devel] FFmpeg 2.6 release

2015-03-01 Thread James Almer
On 01/03/15 6:17 PM, Clément Bœsch wrote: > I might help writing the RELEASE_NOTES. Anything not present in the > Changelog that I should mention? Particular optimizations, area where a > large amount of fixes happened (and are not going to be backported), OPW, > or other various project changes?

[FFmpeg-devel] [PATCH] avformat/dashenc: Update codec_str on extradata_size change

2015-03-01 Thread Timo Rothenpieler
--- libavformat/dashenc.c | 24 +--- 1 file changed, 21 insertions(+), 3 deletions(-) diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c index 98036d3..25c699e 100644 --- a/libavformat/dashenc.c +++ b/libavformat/dashenc.c @@ -72,6 +72,7 @@ typedef struct OutputStream

Re: [FFmpeg-devel] [PATCH] x86/hevc_sao: use unaligned movs for sao_{band, filter} with width 8

2015-03-01 Thread Michael Niedermayer
On Sun, Mar 01, 2015 at 06:07:23PM -0300, James Almer wrote: > Suggested-by: Christophe Gisquet > Signed-off-by: James Almer > --- > libavcodec/x86/hevc_sao.asm | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) LGTM [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF1336

Re: [FFmpeg-devel] [PATCH] x86/hevc_sao: use unaligned movs for sao_{band, filter} with width 8

2015-03-01 Thread James Almer
On 01/03/15 7:04 PM, Michael Niedermayer wrote: > On Sun, Mar 01, 2015 at 06:07:23PM -0300, James Almer wrote: >> Suggested-by: Christophe Gisquet >> Signed-off-by: James Almer >> --- >> libavcodec/x86/hevc_sao.asm | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) > > LGTM Pushed,

[FFmpeg-devel] [PATCH] tests/fate: Add S302M test

2015-03-01 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- tests/fate/acodec.mak |6 ++ tests/ref/acodec/s302m |4 2 files changed, 10 insertions(+) create mode 100644 tests/ref/acodec/s302m diff --git a/tests/fate/acodec.mak b/tests/fate/acodec.mak index 691f9ff..b7e510c 100644 --- a/tests/fate/

Re: [FFmpeg-devel] [PATCH] Port FFT domain filter.

2015-03-01 Thread Stefano Sabatini
On date Saturday 2015-02-28 20:22:49 +0530, Arwa Arif encoded: > Updated the patch. > From ba761516b97b146f4c62d6c5c08dc5ea02c06af5 Mon Sep 17 00:00:00 2001 > From: Arwa Arif > Date: Tue, 24 Feb 2015 12:17:30 +0530 > Subject: [PATCH] Port FFT domain filter. Subject: lavfi: add FFT domain filter

Re: [FFmpeg-devel] [PATCH 2/2] avutil/common: minor simplification in av_clip_intp2_c()

2015-03-01 Thread Michael Niedermayer
On Fri, Feb 27, 2015 at 11:07:23PM +0100, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavutil/common.h |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) applied [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Observe your

[FFmpeg-devel] [PATCH] avcodec/pngenc: cast double to integer type to avoid problems with some AV_WB32() implementations

2015-03-01 Thread Michael Niedermayer
alternatively lrint(f)() could be used or various other options Signed-off-by: Michael Niedermayer --- libavcodec/pngenc.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/pngenc.c b/libavcodec/pngenc.c index 9fd8eef..3a94366 100644 --- a/libavcodec/pngenc.c +++

Re: [FFmpeg-devel] [PATCH] avcodec/pngenc: cast double to integer type to avoid problems with some AV_WB32() implementations

2015-03-01 Thread Ronald S. Bultje
Hi, On Sun, Mar 1, 2015 at 7:38 PM, Michael Niedermayer wrote: > alternatively lrint(f)() could be used > or various other options > > Signed-off-by: Michael Niedermayer > --- > libavcodec/pngenc.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/pngenc.c

[FFmpeg-devel] [PATCH] libavformat/mxfdec: refactor reading strong ref array

2015-03-01 Thread Mark Reid
hi, I was unsure whether this should be a function or a macro, I went with a function. --- libavformat/mxfdec.c | 61 +++- 1 file changed, 22 insertions(+), 39 deletions(-) diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index 1376a7a..f3

Re: [FFmpeg-devel] [PATCH] ffprobe: Force string_validation to int type, its accessed via AVOption as int

2015-03-01 Thread Michael Niedermayer
On Mon, Feb 09, 2015 at 05:21:59AM +0100, Michael Niedermayer wrote: > On Mon, Feb 09, 2015 at 01:44:43AM +0100, Clément Bœsch wrote: > > On Fri, Feb 06, 2015 at 10:10:22PM +0100, Michael Niedermayer wrote: > > > Signed-off-by: Michael Niedermayer > > > --- > > > ffprobe.c |3 ++- > > > 1 fil

Re: [FFmpeg-devel] [PATCH 1/7] ffprobe: Change string_validation to int, its accessed via AVOption as int

2015-03-01 Thread Michael Niedermayer
On Mon, Feb 02, 2015 at 11:22:09PM +0100, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > ffprobe.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) patchset applied after clement expressed preferrance and stefano did not object [...] -- Michael GnuPG fing

Re: [FFmpeg-devel] [PATCH 1/2] libavformat/avio: added avio_put_str16be

2015-03-01 Thread Timothy Gu
On Sun, Mar 1, 2015 at 1:31 PM Mark Reid wrote: > --- > libavformat/avio.h| 6 ++ > libavformat/aviobuf.c | 50 +++--- > > libavformat/version.h | 2 +- > 3 files changed, 34 insertions(+), 24 deletions(-) > Also doc/APICHANGES Timothy ___

[FFmpeg-devel] [PATCH] aac: smal fix in aacpsy pe reduction step

2015-03-01 Thread Claudio Freire
This is a small patch, but it does have a big impact on bit allocation. Measured with the attached scripts (in case someone might find them useful), all the regressions marked in the report have no audible difference (I didn't check them all though), but the improvements can be heard. This affect

[FFmpeg-devel] [PATCH] configure: autodetect opencl

2015-03-01 Thread Gupta, Maneesh
Hi, Similar to the way SDL is being autodetected, the attached patch proposes to autodetect OpenCL. Rationale for the change: * OpenCL linking typically happens against the OpenCL ICD's import library. Hence there is no hard-linking against the OpenCL ICD's DLL/shared library. So ffmpeg should

Re: [FFmpeg-devel] [PATCH] tests/fate: Add S302M test

2015-03-01 Thread Reimar Döffinger
On 02.03.2015, at 00:41, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > tests/fate/acodec.mak |6 ++ > tests/ref/acodec/s302m |4 > 2 files changed, 10 insertions(+) > create mode 100644 tests/ref/acodec/s302m Should be fine, more tests are always welcome