Re: [FFmpeg-devel] [PATCH] avcodec/mpegvideo: also export 0, 0 motion vectors

On Mon, Jan 19, 2015 at 11:58:09PM +0100, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavcodec/mpegvideo.c |2 -- > tests/ref/fate/filter-codecview-mvs | 30 +++--- > 2 files changed, 15 insertions(+), 17 deletions(-) > > d

Re: [FFmpeg-devel] [PATCH] Port mp=eq/eq2 to FFmpeg

On Thu, 22 Jan 2015 01:38:11 +0530 arwa arif wrote: > From 703cc1887903c2868537e19e99b76927bec07884 Mon Sep 17 00:00:00 2001 > From: Arwa Arif > Date: Mon, 19 Jan 2015 03:56:48 +0530 > Subject: [PATCH] Port mp=eq/eq2 to FFmpeg > > Code adapted from James Darnley's previous commits > [...] > +

Re: [FFmpeg-devel] [PATCH] libavformat/img2dec: fix warning when !HAVE_GLOB

Le duodi 2 pluviôse, an CCXXIII, Christophe Gisquet a écrit : > the attached patch fixes a warning under MinGW (no idea about msys2). return AVERROR(EATTACHMENTFORGOTTEN); Regards, -- Nicolas George signature.asc Description: Digital signature ___

Re: [FFmpeg-devel] [PATCH] avformat/dashenc: fix format string generation

On Wed, Jan 21, 2015 at 09:36:53AM -0600, Rodger Combs wrote: > --- > libavformat/dashenc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) applied merged commit that changes it to PRId64 thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Concerni

Re: [FFmpeg-devel] [shan...@gmail.com: [libav-devel] Decoder for CEA-608 and World System Teletext]

On Thu, Jan 22, 2015 at 06:42:30AM +, Shan wrote: > On 2015-01-20T11:52:39+0100 u...@pkh.me relayed: > > > The patches are welcome though, it might be easier to > > work with. > > Here's a base64 patch for the CEA-608, EIA-708, Teletext, DVB VBI and > MXF VANC decoder, as well as some other

Re: [FFmpeg-devel] [PATCH] avcodec/mpegvideo: also export 0, 0 motion vectors

On Thu, Jan 22, 2015 at 09:59:54AM +0100, Clément Bœsch wrote: > On Mon, Jan 19, 2015 at 11:58:09PM +0100, Michael Niedermayer wrote: > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/mpegvideo.c |2 -- > > tests/ref/fate/filter-codecview-mvs | 30 +++---

Re: [FFmpeg-devel] [PATCH 1/2] avformat/flvenc: accept AVMEDIA_TYPE_SUBTITLE instead of DATA for subtitles

On 1/20/15, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavformat/flvenc.c | 12 +++- > 1 file changed, 11 insertions(+), 1 deletion(-) > lgtm ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.

Re: [FFmpeg-devel] [PATCH 1/2] avformat/flvenc: accept AVMEDIA_TYPE_SUBTITLE instead of DATA for subtitles

On Thu, Jan 22, 2015 at 11:43:25AM +, Paul B Mahol wrote: > On 1/20/15, Michael Niedermayer wrote: > > Signed-off-by: Michael Niedermayer > > --- > > libavformat/flvenc.c | 12 +++- > > 1 file changed, 11 insertions(+), 1 deletion(-) > > > > lgtm applied thanks [...] -- Michae

Re: [FFmpeg-devel] [PATCH] configure: add --build-date and --build-time options

Hi, On 22.01.2015 02:58, Timothy Gu wrote: I'd rather have an option disabling it. Sounds cleaner. In which way cleaner? Replacing the date/time with a reproducible one is the least invasive change. Removing it altogether would produce a different end result. Best regards, Andreas

Re: [FFmpeg-devel] [PATCH] configure: add --build-date and --build-time options

On Thu, 22 Jan 2015 15:03:40 +0100 Andreas Cadhalpun wrote: > Hi, > > On 22.01.2015 02:58, Timothy Gu wrote: > > I'd rather have an option disabling it. Sounds cleaner. > > In which way cleaner? > > Replacing the date/time with a reproducible one is the least invasive > change. Removing it al

Re: [FFmpeg-devel] Duration/bitrate estimation

On Thu, Jan 22, 2015 at 12:05:24AM -0500, Marcus Johnson wrote: > What functions are used to estimate the duration and bit rate of a file? > I'd like to add support for these features for the DTS format, and would > rather not dig around the source looking for it. you can set AVStream.duration and

[FFmpeg-devel] [PATCH] libx265: Pass through user-set frame type

Signed-off-by: Derek Buitenhuis --- libavcodec/libx265.c | 5 + 1 file changed, 5 insertions(+) diff --git a/libavcodec/libx265.c b/libavcodec/libx265.c index 923c750..aee7ae2 100644 --- a/libavcodec/libx265.c +++ b/libavcodec/libx265.c @@ -224,6 +224,11 @@ static int libx265_encode_frame(AV

Re: [FFmpeg-devel] [PATCH] libx265: Pass through user-set frame type

On 1/22/2015 2:44 PM, Derek Buitenhuis wrote: > Signed-off-by: Derek Buitenhuis > --- > libavcodec/libx265.c | 5 + > 1 file changed, 5 insertions(+) This is v2. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailm

Re: [FFmpeg-devel] [PATCH] configure: add --build-date and --build-time options

Hi, On 22.01.2015 15:31, wm4 wrote: If the build date is not correct, then what value does the build date have at all? How do you know it is 'correct' currently? One can change the system clock (or use faketime). What value has the 'correct' build date? If you build an ffmpeg version from a y

[FFmpeg-devel] [PATCH] avformat/network: Check for av_malloc* failures in ff_tls_init()

Signed-off-by: Michael Niedermayer --- libavformat/network.c |6 +- libavformat/network.h |2 +- libavformat/tls.c |3 ++- libavformat/utils.c |3 ++- 4 files changed, 10 insertions(+), 4 deletions(-) diff --git a/libavformat/network.c b/libavformat/network.c index 9f02

Re: [FFmpeg-devel] [PATCH] configure: add --build-date and --build-time options

Hi, Le 21/01/2015 23:10, Andreas Cadhalpun a écrit : Hi, Debian tries to make binary packages build reproducible [1]. FFmpeg embeds date and time in the program and documentation, which makes it hard to have binary reproducible packages. The attached patch allows to specify the build date a

Re: [FFmpeg-devel] [PATCH] libx265: Pass through user-set frame type

On Thu, Jan 22, 2015 at 02:44:55PM +, Derek Buitenhuis wrote: > Signed-off-by: Derek Buitenhuis > --- > libavcodec/libx265.c | 5 + > 1 file changed, 5 insertions(+) LGTM [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB What does censorship reveal? It r

Re: [FFmpeg-devel] [PATCH] Port mp=eq/eq2 to FFmpeg

On Thu, Jan 22, 2015 at 2:59 PM, wm4 wrote: > On Thu, 22 Jan 2015 01:38:11 +0530 > arwa arif wrote: > > > From 703cc1887903c2868537e19e99b76927bec07884 Mon Sep 17 00:00:00 2001 > > From: Arwa Arif > > Date: Mon, 19 Jan 2015 03:56:48 +0530 > > Subject: [PATCH] Port mp=eq/eq2 to FFmpeg > > > > Co

Re: [FFmpeg-devel] [PATCH] configure: add --build-date and --build-time options

Hi, On 22.01.2015 17:02, Benoit Fouet wrote: If this patch is accepted in the content, then, I'd decorrelate BUILD_DATE and BUILD_TIME a bit more than what it is in your patch (see below). Do you think one would ever want to specify one, but not the other? [...] @@ -5712,6 +5716,16 @@ cat

Re: [FFmpeg-devel] Suggested Patch for timecode timebase calculation in mov.c

I never heard back about this and I think I have a new better solution now. I don't think the current mov.c timecode processing is handling the case where the timecode is in counter mode. Please read the following page 190 from: https://developer.apple.com/library/mac/documentation/QuickTime/Q

Re: [FFmpeg-devel] [PATCH] nvenc: Compensate for hardware trying to mess with aspect ratio of DVD content.

On Thu, 22 Jan 2015 13:12:59 +0800 Agatha Hu wrote: > Disabling compensation is the best result, adding a flag is > acceptable, but NVENC5.0 has just released, such option won't be > available until 6.0 is available, so... > Still waiting for nvenc teams feedback, the worst case is adding the >

Re: [FFmpeg-devel] [PATCH] Port mp=eq/eq2 to FFmpeg

On 22/01/15 6:29 AM, wm4 wrote: > IMO the asm shouldn't be added at all. It's not important enough for a > ported video filter, but has high maintenance overhead - there's a > reason the FFmpeg loathes inline asm, right? Unless the asm is slower than the C code as compiled by recent versions of gc

Re: [FFmpeg-devel] [PATCH] avformat/mov: Stricter sanity checks on the display_matrix

On Wed, Jan 21, 2015 at 05:02:01PM +0100, Michael Niedermayer wrote: > Fixes "broken" tkhd > Found-by: koda > Signed-off-by: Michael Niedermayer > --- > libavformat/mov.c |3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) applied [...] -- Michael GnuPG fingerprint: 9FF2128B147EF

Re: [FFmpeg-devel] [PATCH] Port mp=eq/eq2 to FFmpeg

On Thu, 22 Jan 2015 21:45:04 +0530 arwa arif wrote: > On Thu, Jan 22, 2015 at 2:59 PM, wm4 wrote: > > > On Thu, 22 Jan 2015 01:38:11 +0530 > > arwa arif wrote: > > > > > From 703cc1887903c2868537e19e99b76927bec07884 Mon Sep 17 00:00:00 2001 > > > From: Arwa Arif > > > Date: Mon, 19 Jan 2015 0

Re: [FFmpeg-devel] [PATCH] Port mp=eq/eq2 to FFmpeg

On 22/01/15 4:27 PM, wm4 wrote: > Then I'd definitely vote for remove. > > The asm probably mattered on ancient CPUs and ancient compilers, but > there's no reason to keep it anymore. No. If the handwritten asm is better than the C code, even if slightly, then it should not be removed. And if so

Re: [FFmpeg-devel] [PATCH] Port mp=eq/eq2 to FFmpeg

On Thu, 22 Jan 2015 16:43:16 -0300 James Almer wrote: > On 22/01/15 4:27 PM, wm4 wrote: > > Then I'd definitely vote for remove. > > > > The asm probably mattered on ancient CPUs and ancient compilers, but > > there's no reason to keep it anymore. > > No. If the handwritten asm is better than t

Re: [FFmpeg-devel] [PATCH] Port mp=eq/eq2 to FFmpeg

On 22/01/15 4:52 PM, wm4 wrote: > On Thu, 22 Jan 2015 16:43:16 -0300 > James Almer wrote: > >> On 22/01/15 4:27 PM, wm4 wrote: >>> Then I'd definitely vote for remove. >>> >>> The asm probably mattered on ancient CPUs and ancient compilers, but >>> there's no reason to keep it anymore. >> >> No.

Re: [FFmpeg-devel] [PATCH] Port mp=eq/eq2 to FFmpeg

On Thu, Jan 22, 2015 at 09:45:04PM +0530, arwa arif wrote: [...] > I checked the runtime of the codes with and without asm, it turns out that > there is not much difference. The difference is coming out to be in > milliseconds. > > 26.014s with asm and > 26.129 without asm. > > So, should I remo

Re: [FFmpeg-devel] [PATCH] Port mp=eq/eq2 to FFmpeg

On Thu, 22 Jan 2015 16:59:24 -0300 James Almer wrote: > On 22/01/15 4:52 PM, wm4 wrote: > > On Thu, 22 Jan 2015 16:43:16 -0300 > > James Almer wrote: > > > >> On 22/01/15 4:27 PM, wm4 wrote: > >>> Then I'd definitely vote for remove. > >>> > >>> The asm probably mattered on ancient CPUs and anc

Re: [FFmpeg-devel] [PATCH] Port mp=eq/eq2 to FFmpeg

On Wed, 21 Jan 2015 20:38:20 +0530 arwa arif wrote: > > > > I still expect that eq and eq2 should have the same performances, > > since the adjust callback is set depending on the parameter values. So > > we should have a single eq filter. > > > > Please investigate about why you get different be

[FFmpeg-devel] [PATCH] avformat: allow .264 as extension for raw H.264 stream

In addition to .h264, .264 is also commonly used by people to name raw H.264 streams. Enables automatic recognition of the h264 format for the .264 extension. Signed-off-by: Werner Robitza --- libavformat/rawenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/ra

Re: [FFmpeg-devel] [PATCH] Port mp=eq/eq2 to FFmpeg

So... 2015-01-21 21:08 GMT+01:00 arwa arif : > Updated the patch. There are trailing spaces, and the patch does not apply here (error on libavfilter/x86/Makefile) Furthemore, I think that hunk is incorrect: +set_gamma(eq); +set_contrast(eq); +set_brightness(eq); +set_saturation(

Re: [FFmpeg-devel] [PATCH] avformat: allow .264 as extension for raw H.264 stream

On Thu, Jan 22, 2015 at 10:02:36PM +0100, Werner Robitza wrote: > In addition to .h264, .264 is also commonly used by people to name raw H.264 > streams. Enables automatic recognition of the h264 format for the .264 > extension. > > Signed-off-by: Werner Robitza > --- > libavformat/rawenc.c | 2

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/nvenc: Fix b-frame parameter handling

On Fri, Jan 16, 2015 at 01:02:38AM +0100, Timo Rothenpieler wrote: > --- > libavcodec/nvenc.c | 20 > 1 file changed, 8 insertions(+), 12 deletions(-) > > diff --git a/libavcodec/nvenc.c b/libavcodec/nvenc.c > index 5cd7727..90856be 100644 > --- a/libavcodec/nvenc.c > +++ b/l

Re: [FFmpeg-devel] [PATCH] mark null encoder as ts-nonstrict , avoids error messages for null output

On Wed, Aug 27, 2014 at 08:13:24PM -0500, Rodger Combs wrote: > > On Thu, Aug 21, 2014 at 02:00:22PM +0200, Hendrik Leppkes wrote: > > > On Thu, Aug 21, 2014 at 1:38 PM, compn > > > wrote: > > > > https://gist.github.com/anonymous/0e26f490ec13d67996

Re: [FFmpeg-devel] [PATCH] avcodec/h264: Partially decode and display single fields try #2

On Wed, Jan 21, 2015 at 02:28:36PM +, Kieran Kunhya wrote: > > yes, its overall 3 lines shorter as well > > ive locally changed it to this: > > Thanks, much easier to understand. applied thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Freedom in cap

[FFmpeg-devel] [PATCH] nvenc: Propagate desired number of reference frames.

Signed-off-by: Philip Langdale --- libavcodec/nvenc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/nvenc.c b/libavcodec/nvenc.c index c52beb7..34ec112 100644 --- a/libavcodec/nvenc.c +++ b/libavcodec/nvenc.c @@ -614,6 +614,8 @@ static av_cold int nvenc_encode_init(AVCodecConte

Re: [FFmpeg-devel] libavutil: Added twofish block cipher

Hi On Wed, Jan 21, 2015 at 01:26:18AM +0530, supraja reddy wrote: > Hello, > > Thanks for you reviews. > > I see this is only use during init but if it still matters speedwise > > and assuming this is a galois field multiplication the it can be > > written as > > > > EXP_GF256[LOG_GF256[a] + LOG

[FFmpeg-devel] [PATCH] web/download: Change main snapshot url to point to github

The url did just end at a "403 - Snapshots not allowed" We also could point to ffmpeg.org, but the snapshots there are upto 24h old with the current cronjob --- src/download |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/download b/src/download index 20c42f8..4e56bc1 1

Re: [FFmpeg-devel] Suggested Patch for timecode timebase calculation in mov.c

On Thu, Jan 22, 2015 at 09:09:53AM -0800, jon wrote: > I never heard back about this and I think I have a new better are you subscribed to ffmpeg-devel ? > solution now. I don't think the current mov.c timecode processing is > handling the case where the timecode is in counter mode. Please read

Re: [FFmpeg-devel] [PATCH 1/3] avutil/buffer: factor buffer_replace() out

On Thu, Jan 15, 2015 at 01:04:54AM +0100, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavutil/buffer.c | 21 - > 1 file changed, 16 insertions(+), 5 deletions(-) applied [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787